Wed, 25 Apr 2012 15:06:51 -0700
7164344: enabling ZIP_DEBUGINFO_FILES causes unexpected test failures on Solaris and Windows
Summary: Disable FDS by default on Solaris; disable ZIP_DEBUGINFO_FILES by default on Windows.
Reviewed-by: acorn, sspitsyn
1 #
2 # Copyright (c) 2006, 2012, Oracle and/or its affiliates. All rights reserved.
3 # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4 #
5 # This code is free software; you can redistribute it and/or modify it
6 # under the terms of the GNU General Public License version 2 only, as
7 # published by the Free Software Foundation.
8 #
9 # This code is distributed in the hope that it will be useful, but WITHOUT
10 # ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11 # FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
12 # version 2 for more details (a copy is included in the LICENSE file that
13 # accompanied this code).
14 #
15 # You should have received a copy of the GNU General Public License version
16 # 2 along with this work; if not, write to the Free Software Foundation,
17 # Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
18 #
19 # Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
20 # or visit www.oracle.com if you need additional information or have any
21 # questions.
22 #
23 #
25 # The common definitions for hotspot solaris builds.
26 # Include the top level defs.make under make directory instead of this one.
27 # This file is included into make/defs.make.
29 # Need PLATFORM (os-arch combo names) for jdk and hotspot, plus libarch name
30 SLASH_JAVA ?= /java
31 ARCH:=$(shell uname -p)
32 PATH_SEP = :
33 ifeq ($(LP64), 1)
34 ARCH_DATA_MODEL=64
35 else
36 ARCH_DATA_MODEL=32
37 endif
39 ifeq ($(ARCH),sparc)
40 ifeq ($(ARCH_DATA_MODEL), 64)
41 MAKE_ARGS += LP64=1
42 PLATFORM=solaris-sparcv9
43 VM_PLATFORM=solaris_sparcv9
44 else
45 PLATFORM=solaris-sparc
46 VM_PLATFORM=solaris_sparc
47 endif
48 HS_ARCH=sparc
49 else
50 ifeq ($(ARCH_DATA_MODEL), 64)
51 MAKE_ARGS += LP64=1
52 PLATFORM=solaris-amd64
53 VM_PLATFORM=solaris_amd64
54 HS_ARCH=x86
55 else
56 PLATFORM=solaris-i586
57 VM_PLATFORM=solaris_i486
58 HS_ARCH=x86
59 endif
60 endif
62 # On 32 bit solaris we build server and client, on 64 bit just server.
63 ifeq ($(JVM_VARIANTS),)
64 ifeq ($(ARCH_DATA_MODEL), 32)
65 JVM_VARIANTS:=client,server
66 JVM_VARIANT_CLIENT:=true
67 JVM_VARIANT_SERVER:=true
68 else
69 JVM_VARIANTS:=server
70 JVM_VARIANT_SERVER:=true
71 endif
72 endif
74 # determine if HotSpot is being built in JDK6 or earlier version
75 JDK6_OR_EARLIER=0
76 ifeq "$(shell expr \( '$(JDK_MAJOR_VERSION)' != '' \& '$(JDK_MINOR_VERSION)' != '' \& '$(JDK_MICRO_VERSION)' != '' \))" "1"
77 # if the longer variable names (newer build style) are set, then check those
78 ifeq "$(shell expr \( $(JDK_MAJOR_VERSION) = 1 \& $(JDK_MINOR_VERSION) \< 7 \))" "1"
79 JDK6_OR_EARLIER=1
80 endif
81 else
82 # the longer variables aren't set so check the shorter variable names
83 ifeq "$(shell expr \( '$(JDK_MAJOR_VER)' = 1 \& '$(JDK_MINOR_VER)' \< 7 \))" "1"
84 JDK6_OR_EARLIER=1
85 endif
86 endif
88 ifeq ($(JDK6_OR_EARLIER),0)
89 # Full Debug Symbols is supported on JDK7 or newer.
90 # The Full Debug Symbols (FDS) default for BUILD_FLAVOR == product
91 # builds is enabled with debug info files ZIP'ed to save space. For
92 # BUILD_FLAVOR != product builds, FDS is always enabled, after all a
93 # debug build without debug info isn't very useful.
94 # The ZIP_DEBUGINFO_FILES option only has meaning when FDS is enabled.
95 #
96 # If you invoke a build with FULL_DEBUG_SYMBOLS=0, then FDS will be
97 # disabled for a BUILD_FLAVOR == product build.
98 #
99 # Note: Use of a different variable name for the FDS override option
100 # versus the FDS enabled check is intentional (FULL_DEBUG_SYMBOLS
101 # versus ENABLE_FULL_DEBUG_SYMBOLS). For auto build systems that pass
102 # in options via environment variables, use of distinct variables
103 # prevents strange behaviours. For example, in a BUILD_FLAVOR !=
104 # product build, the FULL_DEBUG_SYMBOLS environment variable will be
105 # 0, but the ENABLE_FULL_DEBUG_SYMBOLS make variable will be 1. If
106 # the same variable name is used, then different values can be picked
107 # up by different parts of the build. Just to be clear, we only need
108 # two variable names because the incoming option value can be
109 # overridden in some situations, e.g., a BUILD_FLAVOR != product
110 # build.
112 # Disable FULL_DEBUG_SYMBOLS by default because dtrace tests are
113 # failing in nightly when the debug info files are ZIP'ed. On
114 # Solaris debug info files need to be ZIP'ed to reduce the impact
115 # on disk space footprint.
116 FULL_DEBUG_SYMBOLS ?= 0
117 ifeq ($(BUILD_FLAVOR), product)
118 # FULL_DEBUG_SYMBOLS ?= 1
119 ENABLE_FULL_DEBUG_SYMBOLS = $(FULL_DEBUG_SYMBOLS)
120 else
121 # debug variants always get Full Debug Symbols (if available)
122 # ENABLE_FULL_DEBUG_SYMBOLS = 1
123 ENABLE_FULL_DEBUG_SYMBOLS = $(FULL_DEBUG_SYMBOLS)
124 endif
125 _JUNK_ := $(shell \
126 echo >&2 "INFO: ENABLE_FULL_DEBUG_SYMBOLS=$(ENABLE_FULL_DEBUG_SYMBOLS)")
127 # since objcopy is optional, we set ZIP_DEBUGINFO_FILES later
129 ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1)
130 # Default OBJCOPY comes from the SUNWbinutils package:
131 DEF_OBJCOPY=/usr/sfw/bin/gobjcopy
132 ifeq ($(VM_PLATFORM),solaris_amd64)
133 # On Solaris AMD64/X64, gobjcopy is not happy and fails:
134 #
135 # usr/sfw/bin/gobjcopy --add-gnu-debuglink=<lib>.debuginfo <lib>.so
136 # BFD: stKPaiop: Not enough room for program headers, try linking with -N
137 # /usr/sfw/bin/gobjcopy: stKPaiop: Bad value
138 # BFD: stKPaiop: Not enough room for program headers, try linking with -N
139 # /usr/sfw/bin/gobjcopy: libsaproc.debuginfo: Bad value
140 # BFD: stKPaiop: Not enough room for program headers, try linking with -N
141 # /usr/sfw/bin/gobjcopy: stKPaiop: Bad value
142 _JUNK_ := $(shell \
143 echo >&2 "INFO: $(DEF_OBJCOPY) is not working on Solaris AMD64/X64")
144 OBJCOPY=
145 else
146 OBJCOPY=$(shell test -x $(DEF_OBJCOPY) && echo $(DEF_OBJCOPY))
147 ifneq ($(ALT_OBJCOPY),)
148 _JUNK_ := $(shell echo >&2 "INFO: ALT_OBJCOPY=$(ALT_OBJCOPY)")
149 OBJCOPY=$(shell test -x $(ALT_OBJCOPY) && echo $(ALT_OBJCOPY))
150 endif
151 endif
152 else
153 OBJCOPY=
154 endif
156 ifeq ($(OBJCOPY),)
157 _JUNK_ := $(shell \
158 echo >&2 "INFO: no objcopy cmd found so cannot create .debuginfo files.")
159 ENABLE_FULL_DEBUG_SYMBOLS=0
160 _JUNK_ := $(shell \
161 echo >&2 "INFO: ENABLE_FULL_DEBUG_SYMBOLS=$(ENABLE_FULL_DEBUG_SYMBOLS)")
162 else
163 _JUNK_ := $(shell \
164 echo >&2 "INFO: $(OBJCOPY) cmd found so will create .debuginfo files.")
166 # Library stripping policies for .debuginfo configs:
167 # all_strip - strips everything from the library
168 # min_strip - strips most stuff from the library; leaves minimum symbols
169 # no_strip - does not strip the library at all
170 #
171 # Oracle security policy requires "all_strip". A waiver was granted on
172 # 2011.09.01 that permits using "min_strip" in the Java JDK and Java JRE.
173 #
174 # Currently, STRIP_POLICY is only used when Full Debug Symbols is enabled.
175 #
176 STRIP_POLICY ?= min_strip
178 _JUNK_ := $(shell \
179 echo >&2 "INFO: STRIP_POLICY=$(STRIP_POLICY)")
181 # Disable ZIP_DEBUGINFO_FILES by default because dtrace tests are
182 # failing in nightly when the debug info files are ZIP'ed.
183 ZIP_DEBUGINFO_FILES ?= 0
185 _JUNK_ := $(shell \
186 echo >&2 "INFO: ZIP_DEBUGINFO_FILES=$(ZIP_DEBUGINFO_FILES)")
187 endif
188 endif
190 JDK_INCLUDE_SUBDIR=solaris
192 # Library suffix
193 LIBRARY_SUFFIX=so
195 # FIXUP: The subdirectory for a debug build is NOT the same on all platforms
196 VM_DEBUG=jvmg
198 EXPORT_LIST += $(EXPORT_DOCS_DIR)/platform/jvmti/jvmti.html
200 # client and server subdirectories have symbolic links to ../libjsig.$(LIBRARY_SUFFIX)
201 EXPORT_LIST += $(EXPORT_JRE_LIB_ARCH_DIR)/libjsig.$(LIBRARY_SUFFIX)
202 ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1)
203 ifeq ($(ZIP_DEBUGINFO_FILES),1)
204 EXPORT_LIST += $(EXPORT_JRE_LIB_ARCH_DIR)/libjsig.diz
205 else
206 EXPORT_LIST += $(EXPORT_JRE_LIB_ARCH_DIR)/libjsig.debuginfo
207 endif
208 endif
210 EXPORT_LIST += $(EXPORT_JRE_LIB_DIR)/wb.jar
212 EXPORT_SERVER_DIR = $(EXPORT_JRE_LIB_ARCH_DIR)/server
213 EXPORT_CLIENT_DIR = $(EXPORT_JRE_LIB_ARCH_DIR)/client
215 ifeq ($(JVM_VARIANT_SERVER),true)
216 EXPORT_LIST += $(EXPORT_SERVER_DIR)/Xusage.txt
217 EXPORT_LIST += $(EXPORT_SERVER_DIR)/libjvm.$(LIBRARY_SUFFIX)
218 EXPORT_LIST += $(EXPORT_SERVER_DIR)/libjvm_db.$(LIBRARY_SUFFIX)
219 EXPORT_LIST += $(EXPORT_SERVER_DIR)/libjvm_dtrace.$(LIBRARY_SUFFIX)
220 ifeq ($(ARCH_DATA_MODEL),32)
221 EXPORT_LIST += $(EXPORT_SERVER_DIR)/64/libjvm_db.$(LIBRARY_SUFFIX)
222 EXPORT_LIST += $(EXPORT_SERVER_DIR)/64/libjvm_dtrace.$(LIBRARY_SUFFIX)
223 endif
224 ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1)
225 ifeq ($(ZIP_DEBUGINFO_FILES),1)
226 EXPORT_LIST += $(EXPORT_SERVER_DIR)/libjvm.diz
227 EXPORT_LIST += $(EXPORT_SERVER_DIR)/libjvm_db.diz
228 EXPORT_LIST += $(EXPORT_SERVER_DIR)/libjvm_dtrace.diz
229 else
230 EXPORT_LIST += $(EXPORT_SERVER_DIR)/libjvm.debuginfo
231 EXPORT_LIST += $(EXPORT_SERVER_DIR)/libjvm_db.debuginfo
232 EXPORT_LIST += $(EXPORT_SERVER_DIR)/libjvm_dtrace.debuginfo
233 endif
234 endif
235 endif
236 ifeq ($(JVM_VARIANT_CLIENT),true)
237 EXPORT_LIST += $(EXPORT_CLIENT_DIR)/Xusage.txt
238 EXPORT_LIST += $(EXPORT_CLIENT_DIR)/libjvm.$(LIBRARY_SUFFIX)
239 EXPORT_LIST += $(EXPORT_CLIENT_DIR)/libjvm_db.$(LIBRARY_SUFFIX)
240 EXPORT_LIST += $(EXPORT_CLIENT_DIR)/libjvm_dtrace.$(LIBRARY_SUFFIX)
241 ifeq ($(ARCH_DATA_MODEL),32)
242 EXPORT_LIST += $(EXPORT_CLIENT_DIR)/64/libjvm_db.$(LIBRARY_SUFFIX)
243 EXPORT_LIST += $(EXPORT_CLIENT_DIR)/64/libjvm_dtrace.$(LIBRARY_SUFFIX)
244 endif
245 ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1)
246 ifeq ($(ZIP_DEBUGINFO_FILES),1)
247 EXPORT_LIST += $(EXPORT_CLIENT_DIR)/libjvm.diz
248 EXPORT_LIST += $(EXPORT_CLIENT_DIR)/libjvm_db.diz
249 EXPORT_LIST += $(EXPORT_CLIENT_DIR)/libjvm_dtrace.diz
250 ifeq ($(ARCH_DATA_MODEL),32)
251 EXPORT_LIST += $(EXPORT_CLIENT_DIR)/64/libjvm_db.diz
252 EXPORT_LIST += $(EXPORT_CLIENT_DIR)/64/libjvm_dtrace.diz
253 endif
254 else
255 EXPORT_LIST += $(EXPORT_CLIENT_DIR)/libjvm.debuginfo
256 EXPORT_LIST += $(EXPORT_CLIENT_DIR)/libjvm_db.debuginfo
257 EXPORT_LIST += $(EXPORT_CLIENT_DIR)/libjvm_dtrace.debuginfo
258 ifeq ($(ARCH_DATA_MODEL),32)
259 EXPORT_LIST += $(EXPORT_CLIENT_DIR)/64/libjvm_db.debuginfo
260 EXPORT_LIST += $(EXPORT_CLIENT_DIR)/64/libjvm_dtrace.debuginfo
261 endif
262 endif
263 endif
264 endif
266 EXPORT_LIST += $(EXPORT_JRE_LIB_ARCH_DIR)/libsaproc.$(LIBRARY_SUFFIX)
267 ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1)
268 ifeq ($(ZIP_DEBUGINFO_FILES),1)
269 EXPORT_LIST += $(EXPORT_JRE_LIB_ARCH_DIR)/libsaproc.diz
270 else
271 EXPORT_LIST += $(EXPORT_JRE_LIB_ARCH_DIR)/libsaproc.debuginfo
272 endif
273 endif
274 EXPORT_LIST += $(EXPORT_LIB_DIR)/sa-jdi.jar