Tue, 11 Jan 2011 20:26:13 -0800
7011386: race in objArrayKlass::array_klass_impl
Summary: Move _lower_dimension field initialization before _higher_dimension and add storestore barrier.
Reviewed-by: dholmes, iveresov, never
1 /*
2 * Copyright (c) 1997, 2011, Oracle and/or its affiliates. All rights reserved.
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4 *
5 * This code is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 only, as
7 * published by the Free Software Foundation.
8 *
9 * This code is distributed in the hope that it will be useful, but WITHOUT
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
12 * version 2 for more details (a copy is included in the LICENSE file that
13 * accompanied this code).
14 *
15 * You should have received a copy of the GNU General Public License version
16 * 2 along with this work; if not, write to the Free Software Foundation,
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
18 *
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
20 * or visit www.oracle.com if you need additional information or have any
21 * questions.
22 *
23 */
25 #include "precompiled.hpp"
26 #include "classfile/systemDictionary.hpp"
27 #include "classfile/vmSymbols.hpp"
28 #include "gc_interface/collectedHeap.hpp"
29 #include "gc_interface/collectedHeap.inline.hpp"
30 #include "memory/resourceArea.hpp"
31 #include "memory/universe.hpp"
32 #include "memory/universe.inline.hpp"
33 #include "oops/instanceKlass.hpp"
34 #include "oops/klassOop.hpp"
35 #include "oops/objArrayKlassKlass.hpp"
36 #include "oops/oop.inline.hpp"
37 #include "oops/typeArrayKlass.hpp"
38 #include "oops/typeArrayOop.hpp"
39 #include "runtime/handles.inline.hpp"
41 bool typeArrayKlass::compute_is_subtype_of(klassOop k) {
42 if (!k->klass_part()->oop_is_typeArray()) {
43 return arrayKlass::compute_is_subtype_of(k);
44 }
46 typeArrayKlass* tak = typeArrayKlass::cast(k);
47 if (dimension() != tak->dimension()) return false;
49 return element_type() == tak->element_type();
50 }
52 klassOop typeArrayKlass::create_klass(BasicType type, int scale,
53 const char* name_str, TRAPS) {
54 typeArrayKlass o;
56 symbolHandle sym(symbolOop(NULL));
57 // bootstrapping: don't create sym if symbolKlass not created yet
58 if (Universe::symbolKlassObj() != NULL && name_str != NULL) {
59 sym = oopFactory::new_symbol_handle(name_str, CHECK_NULL);
60 }
61 KlassHandle klassklass (THREAD, Universe::typeArrayKlassKlassObj());
63 arrayKlassHandle k = base_create_array_klass(o.vtbl_value(), header_size(), klassklass, CHECK_NULL);
64 typeArrayKlass* ak = typeArrayKlass::cast(k());
65 ak->set_name(sym());
66 ak->set_layout_helper(array_layout_helper(type));
67 assert(scale == (1 << ak->log2_element_size()), "scale must check out");
68 assert(ak->oop_is_javaArray(), "sanity");
69 assert(ak->oop_is_typeArray(), "sanity");
70 ak->set_max_length(arrayOopDesc::max_array_length(type));
71 assert(k()->size() > header_size(), "bad size");
73 // Call complete_create_array_klass after all instance variables have been initialized.
74 KlassHandle super (THREAD, k->super());
75 complete_create_array_klass(k, super, CHECK_NULL);
77 return k();
78 }
80 typeArrayOop typeArrayKlass::allocate(int length, TRAPS) {
81 assert(log2_element_size() >= 0, "bad scale");
82 if (length >= 0) {
83 if (length <= max_length()) {
84 size_t size = typeArrayOopDesc::object_size(layout_helper(), length);
85 KlassHandle h_k(THREAD, as_klassOop());
86 typeArrayOop t;
87 CollectedHeap* ch = Universe::heap();
88 if (size < ch->large_typearray_limit()) {
89 t = (typeArrayOop)CollectedHeap::array_allocate(h_k, (int)size, length, CHECK_NULL);
90 } else {
91 t = (typeArrayOop)CollectedHeap::large_typearray_allocate(h_k, (int)size, length, CHECK_NULL);
92 }
93 assert(t->is_parsable(), "Don't publish unless parsable");
94 return t;
95 } else {
96 report_java_out_of_memory("Requested array size exceeds VM limit");
97 THROW_OOP_0(Universe::out_of_memory_error_array_size());
98 }
99 } else {
100 THROW_0(vmSymbols::java_lang_NegativeArraySizeException());
101 }
102 }
104 typeArrayOop typeArrayKlass::allocate_permanent(int length, TRAPS) {
105 if (length < 0) THROW_0(vmSymbols::java_lang_NegativeArraySizeException());
106 int size = typeArrayOopDesc::object_size(layout_helper(), length);
107 KlassHandle h_k(THREAD, as_klassOop());
108 typeArrayOop t = (typeArrayOop)
109 CollectedHeap::permanent_array_allocate(h_k, size, length, CHECK_NULL);
110 assert(t->is_parsable(), "Can't publish until parsable");
111 return t;
112 }
114 oop typeArrayKlass::multi_allocate(int rank, jint* last_size, TRAPS) {
115 // For typeArrays this is only called for the last dimension
116 assert(rank == 1, "just checking");
117 int length = *last_size;
118 return allocate(length, THREAD);
119 }
122 void typeArrayKlass::copy_array(arrayOop s, int src_pos, arrayOop d, int dst_pos, int length, TRAPS) {
123 assert(s->is_typeArray(), "must be type array");
125 // Check destination
126 if (!d->is_typeArray() || element_type() != typeArrayKlass::cast(d->klass())->element_type()) {
127 THROW(vmSymbols::java_lang_ArrayStoreException());
128 }
130 // Check is all offsets and lengths are non negative
131 if (src_pos < 0 || dst_pos < 0 || length < 0) {
132 THROW(vmSymbols::java_lang_ArrayIndexOutOfBoundsException());
133 }
134 // Check if the ranges are valid
135 if ( (((unsigned int) length + (unsigned int) src_pos) > (unsigned int) s->length())
136 || (((unsigned int) length + (unsigned int) dst_pos) > (unsigned int) d->length()) ) {
137 THROW(vmSymbols::java_lang_ArrayIndexOutOfBoundsException());
138 }
139 // Check zero copy
140 if (length == 0)
141 return;
143 // This is an attempt to make the copy_array fast.
144 int l2es = log2_element_size();
145 int ihs = array_header_in_bytes() / wordSize;
146 char* src = (char*) ((oop*)s + ihs) + ((size_t)src_pos << l2es);
147 char* dst = (char*) ((oop*)d + ihs) + ((size_t)dst_pos << l2es);
148 Copy::conjoint_memory_atomic(src, dst, (size_t)length << l2es);
149 }
152 // create a klass of array holding typeArrays
153 klassOop typeArrayKlass::array_klass_impl(bool or_null, int n, TRAPS) {
154 typeArrayKlassHandle h_this(THREAD, as_klassOop());
155 return array_klass_impl(h_this, or_null, n, THREAD);
156 }
158 klassOop typeArrayKlass::array_klass_impl(typeArrayKlassHandle h_this, bool or_null, int n, TRAPS) {
159 int dimension = h_this->dimension();
160 assert(dimension <= n, "check order of chain");
161 if (dimension == n)
162 return h_this();
164 objArrayKlassHandle h_ak(THREAD, h_this->higher_dimension());
165 if (h_ak.is_null()) {
166 if (or_null) return NULL;
168 ResourceMark rm;
169 JavaThread *jt = (JavaThread *)THREAD;
170 {
171 MutexLocker mc(Compile_lock, THREAD); // for vtables
172 // Atomic create higher dimension and link into list
173 MutexLocker mu(MultiArray_lock, THREAD);
175 h_ak = objArrayKlassHandle(THREAD, h_this->higher_dimension());
176 if (h_ak.is_null()) {
177 klassOop oak = objArrayKlassKlass::cast(
178 Universe::objArrayKlassKlassObj())->allocate_objArray_klass(
179 dimension + 1, h_this, CHECK_NULL);
180 h_ak = objArrayKlassHandle(THREAD, oak);
181 h_ak->set_lower_dimension(h_this());
182 OrderAccess::storestore();
183 h_this->set_higher_dimension(h_ak());
184 assert(h_ak->oop_is_objArray(), "incorrect initialization of objArrayKlass");
185 }
186 }
187 } else {
188 CHECK_UNHANDLED_OOPS_ONLY(Thread::current()->clear_unhandled_oops());
189 }
190 if (or_null) {
191 return h_ak->array_klass_or_null(n);
192 }
193 return h_ak->array_klass(n, CHECK_NULL);
194 }
196 klassOop typeArrayKlass::array_klass_impl(bool or_null, TRAPS) {
197 return array_klass_impl(or_null, dimension() + 1, THREAD);
198 }
200 int typeArrayKlass::oop_size(oop obj) const {
201 assert(obj->is_typeArray(),"must be a type array");
202 typeArrayOop t = typeArrayOop(obj);
203 return t->object_size();
204 }
206 void typeArrayKlass::oop_follow_contents(oop obj) {
207 assert(obj->is_typeArray(),"must be a type array");
208 // Performance tweak: We skip iterating over the klass pointer since we
209 // know that Universe::typeArrayKlass never moves.
210 }
212 #ifndef SERIALGC
213 void typeArrayKlass::oop_follow_contents(ParCompactionManager* cm, oop obj) {
214 assert(obj->is_typeArray(),"must be a type array");
215 // Performance tweak: We skip iterating over the klass pointer since we
216 // know that Universe::typeArrayKlass never moves.
217 }
218 #endif // SERIALGC
220 int typeArrayKlass::oop_adjust_pointers(oop obj) {
221 assert(obj->is_typeArray(),"must be a type array");
222 typeArrayOop t = typeArrayOop(obj);
223 // Performance tweak: We skip iterating over the klass pointer since we
224 // know that Universe::typeArrayKlass never moves.
225 return t->object_size();
226 }
228 int typeArrayKlass::oop_oop_iterate(oop obj, OopClosure* blk) {
229 assert(obj->is_typeArray(),"must be a type array");
230 typeArrayOop t = typeArrayOop(obj);
231 // Performance tweak: We skip iterating over the klass pointer since we
232 // know that Universe::typeArrayKlass never moves.
233 return t->object_size();
234 }
236 int typeArrayKlass::oop_oop_iterate_m(oop obj, OopClosure* blk, MemRegion mr) {
237 assert(obj->is_typeArray(),"must be a type array");
238 typeArrayOop t = typeArrayOop(obj);
239 // Performance tweak: We skip iterating over the klass pointer since we
240 // know that Universe::typeArrayKlass never moves.
241 return t->object_size();
242 }
244 #ifndef SERIALGC
245 void typeArrayKlass::oop_push_contents(PSPromotionManager* pm, oop obj) {
246 assert(obj->is_typeArray(),"must be a type array");
247 }
249 int
250 typeArrayKlass::oop_update_pointers(ParCompactionManager* cm, oop obj) {
251 assert(obj->is_typeArray(),"must be a type array");
252 return typeArrayOop(obj)->object_size();
253 }
255 int
256 typeArrayKlass::oop_update_pointers(ParCompactionManager* cm, oop obj,
257 HeapWord* beg_addr, HeapWord* end_addr) {
258 assert(obj->is_typeArray(),"must be a type array");
259 return typeArrayOop(obj)->object_size();
260 }
261 #endif // SERIALGC
263 void typeArrayKlass::initialize(TRAPS) {
264 // Nothing to do. Having this function is handy since objArrayKlasses can be
265 // initialized by calling initialize on their bottom_klass, see objArrayKlass::initialize
266 }
268 const char* typeArrayKlass::external_name(BasicType type) {
269 switch (type) {
270 case T_BOOLEAN: return "[Z";
271 case T_CHAR: return "[C";
272 case T_FLOAT: return "[F";
273 case T_DOUBLE: return "[D";
274 case T_BYTE: return "[B";
275 case T_SHORT: return "[S";
276 case T_INT: return "[I";
277 case T_LONG: return "[J";
278 default: ShouldNotReachHere();
279 }
280 return NULL;
281 }
283 #ifndef PRODUCT
284 // Printing
286 static void print_boolean_array(typeArrayOop ta, int print_len, outputStream* st) {
287 for (int index = 0; index < print_len; index++) {
288 st->print_cr(" - %3d: %s", index, (ta->bool_at(index) == 0) ? "false" : "true");
289 }
290 }
293 static void print_char_array(typeArrayOop ta, int print_len, outputStream* st) {
294 for (int index = 0; index < print_len; index++) {
295 jchar c = ta->char_at(index);
296 st->print_cr(" - %3d: %x %c", index, c, isprint(c) ? c : ' ');
297 }
298 }
301 static void print_float_array(typeArrayOop ta, int print_len, outputStream* st) {
302 for (int index = 0; index < print_len; index++) {
303 st->print_cr(" - %3d: %g", index, ta->float_at(index));
304 }
305 }
308 static void print_double_array(typeArrayOop ta, int print_len, outputStream* st) {
309 for (int index = 0; index < print_len; index++) {
310 st->print_cr(" - %3d: %g", index, ta->double_at(index));
311 }
312 }
315 static void print_byte_array(typeArrayOop ta, int print_len, outputStream* st) {
316 for (int index = 0; index < print_len; index++) {
317 jbyte c = ta->byte_at(index);
318 st->print_cr(" - %3d: %x %c", index, c, isprint(c) ? c : ' ');
319 }
320 }
323 static void print_short_array(typeArrayOop ta, int print_len, outputStream* st) {
324 for (int index = 0; index < print_len; index++) {
325 int v = ta->ushort_at(index);
326 st->print_cr(" - %3d: 0x%x\t %d", index, v, v);
327 }
328 }
331 static void print_int_array(typeArrayOop ta, int print_len, outputStream* st) {
332 for (int index = 0; index < print_len; index++) {
333 jint v = ta->int_at(index);
334 st->print_cr(" - %3d: 0x%x %d", index, v, v);
335 }
336 }
339 static void print_long_array(typeArrayOop ta, int print_len, outputStream* st) {
340 for (int index = 0; index < print_len; index++) {
341 jlong v = ta->long_at(index);
342 st->print_cr(" - %3d: 0x%x 0x%x", index, high(v), low(v));
343 }
344 }
347 void typeArrayKlass::oop_print_on(oop obj, outputStream* st) {
348 arrayKlass::oop_print_on(obj, st);
349 typeArrayOop ta = typeArrayOop(obj);
350 int print_len = MIN2((intx) ta->length(), MaxElementPrintSize);
351 switch (element_type()) {
352 case T_BOOLEAN: print_boolean_array(ta, print_len, st); break;
353 case T_CHAR: print_char_array(ta, print_len, st); break;
354 case T_FLOAT: print_float_array(ta, print_len, st); break;
355 case T_DOUBLE: print_double_array(ta, print_len, st); break;
356 case T_BYTE: print_byte_array(ta, print_len, st); break;
357 case T_SHORT: print_short_array(ta, print_len, st); break;
358 case T_INT: print_int_array(ta, print_len, st); break;
359 case T_LONG: print_long_array(ta, print_len, st); break;
360 default: ShouldNotReachHere();
361 }
362 int remaining = ta->length() - print_len;
363 if (remaining > 0) {
364 tty->print_cr(" - <%d more elements, increase MaxElementPrintSize to print>", remaining);
365 }
366 }
368 #endif // PRODUCT
370 const char* typeArrayKlass::internal_name() const {
371 return Klass::external_name();
372 }