Wed, 03 Jun 2015 14:22:57 +0200
8077504: Unsafe load can loose control dependency and cause crash
Summary: Node::depends_only_on_test() should return false for Unsafe loads
Reviewed-by: kvn, adinn
1 /*
2 * Copyright (c) 1997, 2013, Oracle and/or its affiliates. All rights reserved.
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4 *
5 * This code is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 only, as
7 * published by the Free Software Foundation.
8 *
9 * This code is distributed in the hope that it will be useful, but WITHOUT
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
12 * version 2 for more details (a copy is included in the LICENSE file that
13 * accompanied this code).
14 *
15 * You should have received a copy of the GNU General Public License version
16 * 2 along with this work; if not, write to the Free Software Foundation,
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
18 *
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
20 * or visit www.oracle.com if you need additional information or have any
21 * questions.
22 *
23 */
25 #ifndef SHARE_VM_OPTO_SUBNODE_HPP
26 #define SHARE_VM_OPTO_SUBNODE_HPP
28 #include "opto/node.hpp"
29 #include "opto/opcodes.hpp"
30 #include "opto/type.hpp"
32 // Portions of code courtesy of Clifford Click
34 //------------------------------SUBNode----------------------------------------
35 // Class SUBTRACTION functionality. This covers all the usual 'subtract'
36 // behaviors. Subtract-integer, -float, -double, binary xor, compare-integer,
37 // -float, and -double are all inherited from this class. The compare
38 // functions behave like subtract functions, except that all negative answers
39 // are compressed into -1, and all positive answers compressed to 1.
40 class SubNode : public Node {
41 public:
42 SubNode( Node *in1, Node *in2 ) : Node(0,in1,in2) {
43 init_class_id(Class_Sub);
44 }
46 // Handle algebraic identities here. If we have an identity, return the Node
47 // we are equivalent to. We look for "add of zero" as an identity.
48 virtual Node *Identity( PhaseTransform *phase );
50 // Compute a new Type for this node. Basically we just do the pre-check,
51 // then call the virtual add() to set the type.
52 virtual const Type *Value( PhaseTransform *phase ) const;
53 const Type* Value_common( PhaseTransform *phase ) const;
55 // Supplied function returns the subtractend of the inputs.
56 // This also type-checks the inputs for sanity. Guaranteed never to
57 // be passed a TOP or BOTTOM type, these are filtered out by a pre-check.
58 virtual const Type *sub( const Type *, const Type * ) const = 0;
60 // Supplied function to return the additive identity type.
61 // This is returned whenever the subtracts inputs are the same.
62 virtual const Type *add_id() const = 0;
64 };
67 // NOTE: SubINode should be taken away and replaced by add and negate
68 //------------------------------SubINode---------------------------------------
69 // Subtract 2 integers
70 class SubINode : public SubNode {
71 public:
72 SubINode( Node *in1, Node *in2 ) : SubNode(in1,in2) {}
73 virtual int Opcode() const;
74 virtual Node *Ideal(PhaseGVN *phase, bool can_reshape);
75 virtual const Type *sub( const Type *, const Type * ) const;
76 const Type *add_id() const { return TypeInt::ZERO; }
77 const Type *bottom_type() const { return TypeInt::INT; }
78 virtual uint ideal_reg() const { return Op_RegI; }
79 };
81 //------------------------------SubLNode---------------------------------------
82 // Subtract 2 integers
83 class SubLNode : public SubNode {
84 public:
85 SubLNode( Node *in1, Node *in2 ) : SubNode(in1,in2) {}
86 virtual int Opcode() const;
87 virtual Node *Ideal(PhaseGVN *phase, bool can_reshape);
88 virtual const Type *sub( const Type *, const Type * ) const;
89 const Type *add_id() const { return TypeLong::ZERO; }
90 const Type *bottom_type() const { return TypeLong::LONG; }
91 virtual uint ideal_reg() const { return Op_RegL; }
92 };
94 // NOTE: SubFPNode should be taken away and replaced by add and negate
95 //------------------------------SubFPNode--------------------------------------
96 // Subtract 2 floats or doubles
97 class SubFPNode : public SubNode {
98 protected:
99 SubFPNode( Node *in1, Node *in2 ) : SubNode(in1,in2) {}
100 public:
101 const Type *Value( PhaseTransform *phase ) const;
102 };
104 // NOTE: SubFNode should be taken away and replaced by add and negate
105 //------------------------------SubFNode---------------------------------------
106 // Subtract 2 doubles
107 class SubFNode : public SubFPNode {
108 public:
109 SubFNode( Node *in1, Node *in2 ) : SubFPNode(in1,in2) {}
110 virtual int Opcode() const;
111 virtual Node *Ideal(PhaseGVN *phase, bool can_reshape);
112 virtual const Type *sub( const Type *, const Type * ) const;
113 const Type *add_id() const { return TypeF::ZERO; }
114 const Type *bottom_type() const { return Type::FLOAT; }
115 virtual uint ideal_reg() const { return Op_RegF; }
116 };
118 // NOTE: SubDNode should be taken away and replaced by add and negate
119 //------------------------------SubDNode---------------------------------------
120 // Subtract 2 doubles
121 class SubDNode : public SubFPNode {
122 public:
123 SubDNode( Node *in1, Node *in2 ) : SubFPNode(in1,in2) {}
124 virtual int Opcode() const;
125 virtual Node *Ideal(PhaseGVN *phase, bool can_reshape);
126 virtual const Type *sub( const Type *, const Type * ) const;
127 const Type *add_id() const { return TypeD::ZERO; }
128 const Type *bottom_type() const { return Type::DOUBLE; }
129 virtual uint ideal_reg() const { return Op_RegD; }
130 };
132 //------------------------------CmpNode---------------------------------------
133 // Compare 2 values, returning condition codes (-1, 0 or 1).
134 class CmpNode : public SubNode {
135 public:
136 CmpNode( Node *in1, Node *in2 ) : SubNode(in1,in2) {
137 init_class_id(Class_Cmp);
138 }
139 virtual Node *Identity( PhaseTransform *phase );
140 const Type *add_id() const { return TypeInt::ZERO; }
141 const Type *bottom_type() const { return TypeInt::CC; }
142 virtual uint ideal_reg() const { return Op_RegFlags; }
143 };
145 //------------------------------CmpINode---------------------------------------
146 // Compare 2 signed values, returning condition codes (-1, 0 or 1).
147 class CmpINode : public CmpNode {
148 public:
149 CmpINode( Node *in1, Node *in2 ) : CmpNode(in1,in2) {}
150 virtual int Opcode() const;
151 virtual Node *Ideal(PhaseGVN *phase, bool can_reshape);
152 virtual const Type *sub( const Type *, const Type * ) const;
153 };
155 //------------------------------CmpUNode---------------------------------------
156 // Compare 2 unsigned values (integer or pointer), returning condition codes (-1, 0 or 1).
157 class CmpUNode : public CmpNode {
158 public:
159 CmpUNode( Node *in1, Node *in2 ) : CmpNode(in1,in2) {}
160 virtual int Opcode() const;
161 virtual const Type *sub( const Type *, const Type * ) const;
162 const Type *Value( PhaseTransform *phase ) const;
163 bool is_index_range_check() const;
164 };
166 //------------------------------CmpPNode---------------------------------------
167 // Compare 2 pointer values, returning condition codes (-1, 0 or 1).
168 class CmpPNode : public CmpNode {
169 public:
170 CmpPNode( Node *in1, Node *in2 ) : CmpNode(in1,in2) {}
171 virtual int Opcode() const;
172 virtual Node *Ideal(PhaseGVN *phase, bool can_reshape);
173 virtual const Type *sub( const Type *, const Type * ) const;
174 };
176 //------------------------------CmpNNode--------------------------------------
177 // Compare 2 narrow oop values, returning condition codes (-1, 0 or 1).
178 class CmpNNode : public CmpNode {
179 public:
180 CmpNNode( Node *in1, Node *in2 ) : CmpNode(in1,in2) {}
181 virtual int Opcode() const;
182 virtual Node *Ideal(PhaseGVN *phase, bool can_reshape);
183 virtual const Type *sub( const Type *, const Type * ) const;
184 };
186 //------------------------------CmpLNode---------------------------------------
187 // Compare 2 long values, returning condition codes (-1, 0 or 1).
188 class CmpLNode : public CmpNode {
189 public:
190 CmpLNode( Node *in1, Node *in2 ) : CmpNode(in1,in2) {}
191 virtual int Opcode() const;
192 virtual const Type *sub( const Type *, const Type * ) const;
193 };
195 //------------------------------CmpL3Node--------------------------------------
196 // Compare 2 long values, returning integer value (-1, 0 or 1).
197 class CmpL3Node : public CmpLNode {
198 public:
199 CmpL3Node( Node *in1, Node *in2 ) : CmpLNode(in1,in2) {
200 // Since it is not consumed by Bools, it is not really a Cmp.
201 init_class_id(Class_Sub);
202 }
203 virtual int Opcode() const;
204 virtual uint ideal_reg() const { return Op_RegI; }
205 };
207 //------------------------------CmpFNode---------------------------------------
208 // Compare 2 float values, returning condition codes (-1, 0 or 1).
209 // This implements the Java bytecode fcmpl, so unordered returns -1.
210 // Operands may not commute.
211 class CmpFNode : public CmpNode {
212 public:
213 CmpFNode( Node *in1, Node *in2 ) : CmpNode(in1,in2) {}
214 virtual int Opcode() const;
215 virtual const Type *sub( const Type *, const Type * ) const { ShouldNotReachHere(); return NULL; }
216 const Type *Value( PhaseTransform *phase ) const;
217 };
219 //------------------------------CmpF3Node--------------------------------------
220 // Compare 2 float values, returning integer value (-1, 0 or 1).
221 // This implements the Java bytecode fcmpl, so unordered returns -1.
222 // Operands may not commute.
223 class CmpF3Node : public CmpFNode {
224 public:
225 CmpF3Node( Node *in1, Node *in2 ) : CmpFNode(in1,in2) {
226 // Since it is not consumed by Bools, it is not really a Cmp.
227 init_class_id(Class_Sub);
228 }
229 virtual int Opcode() const;
230 // Since it is not consumed by Bools, it is not really a Cmp.
231 virtual uint ideal_reg() const { return Op_RegI; }
232 };
235 //------------------------------CmpDNode---------------------------------------
236 // Compare 2 double values, returning condition codes (-1, 0 or 1).
237 // This implements the Java bytecode dcmpl, so unordered returns -1.
238 // Operands may not commute.
239 class CmpDNode : public CmpNode {
240 public:
241 CmpDNode( Node *in1, Node *in2 ) : CmpNode(in1,in2) {}
242 virtual int Opcode() const;
243 virtual const Type *sub( const Type *, const Type * ) const { ShouldNotReachHere(); return NULL; }
244 const Type *Value( PhaseTransform *phase ) const;
245 virtual Node *Ideal(PhaseGVN *phase, bool can_reshape);
246 };
248 //------------------------------CmpD3Node--------------------------------------
249 // Compare 2 double values, returning integer value (-1, 0 or 1).
250 // This implements the Java bytecode dcmpl, so unordered returns -1.
251 // Operands may not commute.
252 class CmpD3Node : public CmpDNode {
253 public:
254 CmpD3Node( Node *in1, Node *in2 ) : CmpDNode(in1,in2) {
255 // Since it is not consumed by Bools, it is not really a Cmp.
256 init_class_id(Class_Sub);
257 }
258 virtual int Opcode() const;
259 virtual uint ideal_reg() const { return Op_RegI; }
260 };
263 //------------------------------BoolTest---------------------------------------
264 // Convert condition codes to a boolean test value (0 or -1).
265 // We pick the values as 3 bits; the low order 2 bits we compare against the
266 // condition codes, the high bit flips the sense of the result.
267 struct BoolTest VALUE_OBJ_CLASS_SPEC {
268 enum mask { eq = 0, ne = 4, le = 5, ge = 7, lt = 3, gt = 1, overflow = 2, no_overflow = 6, illegal = 8 };
269 mask _test;
270 BoolTest( mask btm ) : _test(btm) {}
271 const Type *cc2logical( const Type *CC ) const;
272 // Commute the test. I use a small table lookup. The table is created as
273 // a simple char array where each element is the ASCII version of a 'mask'
274 // enum from above.
275 mask commute( ) const { return mask("032147658"[_test]-'0'); }
276 mask negate( ) const { return mask(_test^4); }
277 bool is_canonical( ) const { return (_test == BoolTest::ne || _test == BoolTest::lt || _test == BoolTest::le || _test == BoolTest::overflow); }
278 void dump_on(outputStream *st) const;
279 };
281 //------------------------------BoolNode---------------------------------------
282 // A Node to convert a Condition Codes to a Logical result.
283 class BoolNode : public Node {
284 virtual uint hash() const;
285 virtual uint cmp( const Node &n ) const;
286 virtual uint size_of() const;
287 public:
288 const BoolTest _test;
289 BoolNode( Node *cc, BoolTest::mask t): _test(t), Node(0,cc) {
290 init_class_id(Class_Bool);
291 }
292 // Convert an arbitrary int value to a Bool or other suitable predicate.
293 static Node* make_predicate(Node* test_value, PhaseGVN* phase);
294 // Convert self back to an integer value.
295 Node* as_int_value(PhaseGVN* phase);
296 // Invert sense of self, returning new Bool.
297 BoolNode* negate(PhaseGVN* phase);
298 virtual int Opcode() const;
299 virtual Node *Ideal(PhaseGVN *phase, bool can_reshape);
300 virtual const Type *Value( PhaseTransform *phase ) const;
301 virtual const Type *bottom_type() const { return TypeInt::BOOL; }
302 uint match_edge(uint idx) const { return 0; }
303 virtual uint ideal_reg() const { return Op_RegI; }
305 bool is_counted_loop_exit_test();
306 #ifndef PRODUCT
307 virtual void dump_spec(outputStream *st) const;
308 #endif
309 };
311 //------------------------------AbsNode----------------------------------------
312 // Abstract class for absolute value. Mostly used to get a handy wrapper
313 // for finding this pattern in the graph.
314 class AbsNode : public Node {
315 public:
316 AbsNode( Node *value ) : Node(0,value) {}
317 };
319 //------------------------------AbsINode---------------------------------------
320 // Absolute value an integer. Since a naive graph involves control flow, we
321 // "match" it in the ideal world (so the control flow can be removed).
322 class AbsINode : public AbsNode {
323 public:
324 AbsINode( Node *in1 ) : AbsNode(in1) {}
325 virtual int Opcode() const;
326 const Type *bottom_type() const { return TypeInt::INT; }
327 virtual uint ideal_reg() const { return Op_RegI; }
328 };
330 //------------------------------AbsFNode---------------------------------------
331 // Absolute value a float, a common float-point idiom with a cheap hardware
332 // implemention on most chips. Since a naive graph involves control flow, we
333 // "match" it in the ideal world (so the control flow can be removed).
334 class AbsFNode : public AbsNode {
335 public:
336 AbsFNode( Node *in1 ) : AbsNode(in1) {}
337 virtual int Opcode() const;
338 const Type *bottom_type() const { return Type::FLOAT; }
339 virtual uint ideal_reg() const { return Op_RegF; }
340 };
342 //------------------------------AbsDNode---------------------------------------
343 // Absolute value a double, a common float-point idiom with a cheap hardware
344 // implemention on most chips. Since a naive graph involves control flow, we
345 // "match" it in the ideal world (so the control flow can be removed).
346 class AbsDNode : public AbsNode {
347 public:
348 AbsDNode( Node *in1 ) : AbsNode(in1) {}
349 virtual int Opcode() const;
350 const Type *bottom_type() const { return Type::DOUBLE; }
351 virtual uint ideal_reg() const { return Op_RegD; }
352 };
355 //------------------------------CmpLTMaskNode----------------------------------
356 // If p < q, return -1 else return 0. Nice for flow-free idioms.
357 class CmpLTMaskNode : public Node {
358 public:
359 CmpLTMaskNode( Node *p, Node *q ) : Node(0, p, q) {}
360 virtual int Opcode() const;
361 const Type *bottom_type() const { return TypeInt::INT; }
362 virtual uint ideal_reg() const { return Op_RegI; }
363 };
366 //------------------------------NegNode----------------------------------------
367 class NegNode : public Node {
368 public:
369 NegNode( Node *in1 ) : Node(0,in1) {}
370 };
372 //------------------------------NegFNode---------------------------------------
373 // Negate value a float. Negating 0.0 returns -0.0, but subtracting from
374 // zero returns +0.0 (per JVM spec on 'fneg' bytecode). As subtraction
375 // cannot be used to replace negation we have to implement negation as ideal
376 // node; note that negation and addition can replace subtraction.
377 class NegFNode : public NegNode {
378 public:
379 NegFNode( Node *in1 ) : NegNode(in1) {}
380 virtual int Opcode() const;
381 const Type *bottom_type() const { return Type::FLOAT; }
382 virtual uint ideal_reg() const { return Op_RegF; }
383 };
385 //------------------------------NegDNode---------------------------------------
386 // Negate value a double. Negating 0.0 returns -0.0, but subtracting from
387 // zero returns +0.0 (per JVM spec on 'dneg' bytecode). As subtraction
388 // cannot be used to replace negation we have to implement negation as ideal
389 // node; note that negation and addition can replace subtraction.
390 class NegDNode : public NegNode {
391 public:
392 NegDNode( Node *in1 ) : NegNode(in1) {}
393 virtual int Opcode() const;
394 const Type *bottom_type() const { return Type::DOUBLE; }
395 virtual uint ideal_reg() const { return Op_RegD; }
396 };
398 //------------------------------CosDNode---------------------------------------
399 // Cosinus of a double
400 class CosDNode : public Node {
401 public:
402 CosDNode(Compile* C, Node *c, Node *in1) : Node(c, in1) {
403 init_flags(Flag_is_expensive);
404 C->add_expensive_node(this);
405 }
406 virtual int Opcode() const;
407 const Type *bottom_type() const { return Type::DOUBLE; }
408 virtual uint ideal_reg() const { return Op_RegD; }
409 virtual const Type *Value( PhaseTransform *phase ) const;
410 };
412 //------------------------------CosDNode---------------------------------------
413 // Sinus of a double
414 class SinDNode : public Node {
415 public:
416 SinDNode(Compile* C, Node *c, Node *in1) : Node(c, in1) {
417 init_flags(Flag_is_expensive);
418 C->add_expensive_node(this);
419 }
420 virtual int Opcode() const;
421 const Type *bottom_type() const { return Type::DOUBLE; }
422 virtual uint ideal_reg() const { return Op_RegD; }
423 virtual const Type *Value( PhaseTransform *phase ) const;
424 };
427 //------------------------------TanDNode---------------------------------------
428 // tangens of a double
429 class TanDNode : public Node {
430 public:
431 TanDNode(Compile* C, Node *c,Node *in1) : Node(c, in1) {
432 init_flags(Flag_is_expensive);
433 C->add_expensive_node(this);
434 }
435 virtual int Opcode() const;
436 const Type *bottom_type() const { return Type::DOUBLE; }
437 virtual uint ideal_reg() const { return Op_RegD; }
438 virtual const Type *Value( PhaseTransform *phase ) const;
439 };
442 //------------------------------AtanDNode--------------------------------------
443 // arcus tangens of a double
444 class AtanDNode : public Node {
445 public:
446 AtanDNode(Node *c, Node *in1, Node *in2 ) : Node(c, in1, in2) {}
447 virtual int Opcode() const;
448 const Type *bottom_type() const { return Type::DOUBLE; }
449 virtual uint ideal_reg() const { return Op_RegD; }
450 };
453 //------------------------------SqrtDNode--------------------------------------
454 // square root a double
455 class SqrtDNode : public Node {
456 public:
457 SqrtDNode(Compile* C, Node *c, Node *in1) : Node(c, in1) {
458 init_flags(Flag_is_expensive);
459 C->add_expensive_node(this);
460 }
461 virtual int Opcode() const;
462 const Type *bottom_type() const { return Type::DOUBLE; }
463 virtual uint ideal_reg() const { return Op_RegD; }
464 virtual const Type *Value( PhaseTransform *phase ) const;
465 };
467 //------------------------------ExpDNode---------------------------------------
468 // Exponentiate a double
469 class ExpDNode : public Node {
470 public:
471 ExpDNode(Compile* C, Node *c, Node *in1) : Node(c, in1) {
472 init_flags(Flag_is_expensive);
473 C->add_expensive_node(this);
474 }
475 virtual int Opcode() const;
476 const Type *bottom_type() const { return Type::DOUBLE; }
477 virtual uint ideal_reg() const { return Op_RegD; }
478 virtual const Type *Value( PhaseTransform *phase ) const;
479 };
481 //------------------------------LogDNode---------------------------------------
482 // Log_e of a double
483 class LogDNode : public Node {
484 public:
485 LogDNode(Compile* C, Node *c, Node *in1) : Node(c, in1) {
486 init_flags(Flag_is_expensive);
487 C->add_expensive_node(this);
488 }
489 virtual int Opcode() const;
490 const Type *bottom_type() const { return Type::DOUBLE; }
491 virtual uint ideal_reg() const { return Op_RegD; }
492 virtual const Type *Value( PhaseTransform *phase ) const;
493 };
495 //------------------------------Log10DNode---------------------------------------
496 // Log_10 of a double
497 class Log10DNode : public Node {
498 public:
499 Log10DNode(Compile* C, Node *c, Node *in1) : Node(c, in1) {
500 init_flags(Flag_is_expensive);
501 C->add_expensive_node(this);
502 }
503 virtual int Opcode() const;
504 const Type *bottom_type() const { return Type::DOUBLE; }
505 virtual uint ideal_reg() const { return Op_RegD; }
506 virtual const Type *Value( PhaseTransform *phase ) const;
507 };
509 //------------------------------PowDNode---------------------------------------
510 // Raise a double to a double power
511 class PowDNode : public Node {
512 public:
513 PowDNode(Compile* C, Node *c, Node *in1, Node *in2 ) : Node(c, in1, in2) {
514 init_flags(Flag_is_expensive);
515 C->add_expensive_node(this);
516 }
517 virtual int Opcode() const;
518 const Type *bottom_type() const { return Type::DOUBLE; }
519 virtual uint ideal_reg() const { return Op_RegD; }
520 virtual const Type *Value( PhaseTransform *phase ) const;
521 };
523 //-------------------------------ReverseBytesINode--------------------------------
524 // reverse bytes of an integer
525 class ReverseBytesINode : public Node {
526 public:
527 ReverseBytesINode(Node *c, Node *in1) : Node(c, in1) {}
528 virtual int Opcode() const;
529 const Type *bottom_type() const { return TypeInt::INT; }
530 virtual uint ideal_reg() const { return Op_RegI; }
531 };
533 //-------------------------------ReverseBytesLNode--------------------------------
534 // reverse bytes of a long
535 class ReverseBytesLNode : public Node {
536 public:
537 ReverseBytesLNode(Node *c, Node *in1) : Node(c, in1) {}
538 virtual int Opcode() const;
539 const Type *bottom_type() const { return TypeLong::LONG; }
540 virtual uint ideal_reg() const { return Op_RegL; }
541 };
543 //-------------------------------ReverseBytesUSNode--------------------------------
544 // reverse bytes of an unsigned short / char
545 class ReverseBytesUSNode : public Node {
546 public:
547 ReverseBytesUSNode(Node *c, Node *in1) : Node(c, in1) {}
548 virtual int Opcode() const;
549 const Type *bottom_type() const { return TypeInt::CHAR; }
550 virtual uint ideal_reg() const { return Op_RegI; }
551 };
553 //-------------------------------ReverseBytesSNode--------------------------------
554 // reverse bytes of a short
555 class ReverseBytesSNode : public Node {
556 public:
557 ReverseBytesSNode(Node *c, Node *in1) : Node(c, in1) {}
558 virtual int Opcode() const;
559 const Type *bottom_type() const { return TypeInt::SHORT; }
560 virtual uint ideal_reg() const { return Op_RegI; }
561 };
563 #endif // SHARE_VM_OPTO_SUBNODE_HPP