src/share/vm/gc_implementation/shared/markSweep.inline.hpp

Thu, 20 Sep 2012 09:52:56 -0700

author
johnc
date
Thu, 20 Sep 2012 09:52:56 -0700
changeset 4067
b2ef234911c9
parent 4037
da91efe96a93
child 4384
b735136e0d82
permissions
-rw-r--r--

7190666: G1: assert(_unused == 0) failed: Inconsistency in PLAB stats
Summary: Reset the fields in ParGCAllocBuffer, that are used for accumulating values for the ResizePLAB sensors in PLABStats, to zero after flushing the values to the PLABStats fields. Flush PLABStats values only when retiring the final allocation buffers prior to disposing of a G1ParScanThreadState object, rather than when retiring every allocation buffer.
Reviewed-by: jwilhelm, jmasa, ysr

     1 /*
     2  * Copyright (c) 2000, 2012, Oracle and/or its affiliates. All rights reserved.
     3  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
     4  *
     5  * This code is free software; you can redistribute it and/or modify it
     6  * under the terms of the GNU General Public License version 2 only, as
     7  * published by the Free Software Foundation.
     8  *
     9  * This code is distributed in the hope that it will be useful, but WITHOUT
    10  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
    11  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
    12  * version 2 for more details (a copy is included in the LICENSE file that
    13  * accompanied this code).
    14  *
    15  * You should have received a copy of the GNU General Public License version
    16  * 2 along with this work; if not, write to the Free Software Foundation,
    17  * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
    18  *
    19  * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
    20  * or visit www.oracle.com if you need additional information or have any
    21  * questions.
    22  *
    23  */
    25 #ifndef SHARE_VM_GC_IMPLEMENTATION_SHARED_MARKSWEEP_INLINE_HPP
    26 #define SHARE_VM_GC_IMPLEMENTATION_SHARED_MARKSWEEP_INLINE_HPP
    28 #include "gc_implementation/shared/markSweep.hpp"
    29 #include "gc_interface/collectedHeap.hpp"
    30 #include "utilities/stack.inline.hpp"
    31 #ifndef SERIALGC
    32 #include "gc_implementation/parallelScavenge/psParallelCompact.hpp"
    33 #endif
    35 inline void MarkSweep::mark_object(oop obj) {
    36   // some marks may contain information we need to preserve so we store them away
    37   // and overwrite the mark.  We'll restore it at the end of markSweep.
    38   markOop mark = obj->mark();
    39   obj->set_mark(markOopDesc::prototype()->set_marked());
    41   if (mark->must_be_preserved(obj)) {
    42     preserve_mark(obj, mark);
    43   }
    44 }
    46 template <class T> inline void MarkSweep::follow_root(T* p) {
    47   assert(!Universe::heap()->is_in_reserved(p),
    48          "roots shouldn't be things within the heap");
    49 #ifdef VALIDATE_MARK_SWEEP
    50   if (ValidateMarkSweep) {
    51     guarantee(!_root_refs_stack->contains(p), "should only be in here once");
    52     _root_refs_stack->push(p);
    53   }
    54 #endif
    55   T heap_oop = oopDesc::load_heap_oop(p);
    56   if (!oopDesc::is_null(heap_oop)) {
    57     oop obj = oopDesc::decode_heap_oop_not_null(heap_oop);
    58     if (!obj->mark()->is_marked()) {
    59       mark_object(obj);
    60       obj->follow_contents();
    61     }
    62   }
    63   follow_stack();
    64 }
    66 template <class T> inline void MarkSweep::mark_and_push(T* p) {
    67 //  assert(Universe::heap()->is_in_reserved(p), "should be in object space");
    68   T heap_oop = oopDesc::load_heap_oop(p);
    69   if (!oopDesc::is_null(heap_oop)) {
    70     oop obj = oopDesc::decode_heap_oop_not_null(heap_oop);
    71     if (!obj->mark()->is_marked()) {
    72       mark_object(obj);
    73       _marking_stack.push(obj);
    74     }
    75   }
    76 }
    78 void MarkSweep::push_objarray(oop obj, size_t index) {
    79   ObjArrayTask task(obj, index);
    80   assert(task.is_valid(), "bad ObjArrayTask");
    81   _objarray_stack.push(task);
    82 }
    84 template <class T> inline void MarkSweep::adjust_pointer(T* p, bool isroot) {
    85   T heap_oop = oopDesc::load_heap_oop(p);
    86   if (!oopDesc::is_null(heap_oop)) {
    87     oop obj     = oopDesc::decode_heap_oop_not_null(heap_oop);
    88     oop new_obj = oop(obj->mark()->decode_pointer());
    89     assert(new_obj != NULL ||                         // is forwarding ptr?
    90            obj->mark() == markOopDesc::prototype() || // not gc marked?
    91            (UseBiasedLocking && obj->mark()->has_bias_pattern()),
    92                                                       // not gc marked?
    93            "should be forwarded");
    94     if (new_obj != NULL) {
    95       assert(Universe::heap()->is_in_reserved(new_obj),
    96              "should be in object space");
    97       oopDesc::encode_store_heap_oop_not_null(p, new_obj);
    98     }
    99   }
   100   VALIDATE_MARK_SWEEP_ONLY(track_adjusted_pointer(p, isroot));
   101 }
   103 template <class T> inline void MarkSweep::KeepAliveClosure::do_oop_work(T* p) {
   104 #ifdef VALIDATE_MARK_SWEEP
   105   if (ValidateMarkSweep) {
   106     if (!Universe::heap()->is_in_reserved(p)) {
   107       _root_refs_stack->push(p);
   108     } else {
   109       _other_refs_stack->push(p);
   110     }
   111   }
   112 #endif
   113   mark_and_push(p);
   114 }
   116 #endif // SHARE_VM_GC_IMPLEMENTATION_SHARED_MARKSWEEP_INLINE_HPP

mercurial