Thu, 20 Sep 2012 09:52:56 -0700
7190666: G1: assert(_unused == 0) failed: Inconsistency in PLAB stats
Summary: Reset the fields in ParGCAllocBuffer, that are used for accumulating values for the ResizePLAB sensors in PLABStats, to zero after flushing the values to the PLABStats fields. Flush PLABStats values only when retiring the final allocation buffers prior to disposing of a G1ParScanThreadState object, rather than when retiring every allocation buffer.
Reviewed-by: jwilhelm, jmasa, ysr
1 /*
2 * Copyright (c) 2011, Oracle and/or its affiliates. All rights reserved.
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4 *
5 * This code is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 only, as
7 * published by the Free Software Foundation.
8 *
9 * This code is distributed in the hope that it will be useful, but WITHOUT
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
12 * version 2 for more details (a copy is included in the LICENSE file that
13 * accompanied this code).
14 *
15 * You should have received a copy of the GNU General Public License version
16 * 2 along with this work; if not, write to the Free Software Foundation,
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
18 *
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
20 * or visit www.oracle.com if you need additional information or have any
21 * questions.
22 *
23 */
25 #ifndef SHARE_VM_GC_IMPLEMENTATION_SHARED_HSPACECOUNTERS_HPP
26 #define SHARE_VM_GC_IMPLEMENTATION_SHARED_HSPACECOUNTERS_HPP
28 #ifndef SERIALGC
29 #include "gc_implementation/shared/generationCounters.hpp"
30 #include "memory/generation.hpp"
31 #include "runtime/perfData.hpp"
32 #endif
34 // A HSpaceCounter is a holder class for performance counters
35 // that track a collections (logical spaces) in a heap;
37 class HeapSpaceUsedHelper;
38 class G1SpaceMonitoringSupport;
40 class HSpaceCounters: public CHeapObj<mtGC> {
41 friend class VMStructs;
43 private:
44 PerfVariable* _capacity;
45 PerfVariable* _used;
47 // Constant PerfData types don't need to retain a reference.
48 // However, it's a good idea to document them here.
50 char* _name_space;
52 public:
54 HSpaceCounters(const char* name, int ordinal, size_t max_size,
55 size_t initial_capacity, GenerationCounters* gc);
57 ~HSpaceCounters() {
58 if (_name_space != NULL) FREE_C_HEAP_ARRAY(char, _name_space, mtGC);
59 }
61 inline void update_capacity(size_t v) {
62 _capacity->set_value(v);
63 }
65 inline void update_used(size_t v) {
66 _used->set_value(v);
67 }
69 debug_only(
70 // for security reasons, we do not allow arbitrary reads from
71 // the counters as they may live in shared memory.
72 jlong used() {
73 return _used->get_value();
74 }
75 jlong capacity() {
76 return _used->get_value();
77 }
78 )
80 inline void update_all(size_t capacity, size_t used) {
81 update_capacity(capacity);
82 update_used(used);
83 }
85 const char* name_space() const { return _name_space; }
86 };
87 #endif // SHARE_VM_GC_IMPLEMENTATION_SHARED_HSPACECOUNTERS_HPP