Thu, 20 Sep 2012 09:52:56 -0700
7190666: G1: assert(_unused == 0) failed: Inconsistency in PLAB stats
Summary: Reset the fields in ParGCAllocBuffer, that are used for accumulating values for the ResizePLAB sensors in PLABStats, to zero after flushing the values to the PLABStats fields. Flush PLABStats values only when retiring the final allocation buffers prior to disposing of a G1ParScanThreadState object, rather than when retiring every allocation buffer.
Reviewed-by: jwilhelm, jmasa, ysr
1 /*
2 * Copyright (c) 2003, 2010, Oracle and/or its affiliates. All rights reserved.
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4 *
5 * This code is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 only, as
7 * published by the Free Software Foundation.
8 *
9 * This code is distributed in the hope that it will be useful, but WITHOUT
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
12 * version 2 for more details (a copy is included in the LICENSE file that
13 * accompanied this code).
14 *
15 * You should have received a copy of the GNU General Public License version
16 * 2 along with this work; if not, write to the Free Software Foundation,
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
18 *
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
20 * or visit www.oracle.com if you need additional information or have any
21 * questions.
22 *
23 */
25 #ifndef SHARE_VM_GC_IMPLEMENTATION_SHARED_GCSTATS_HPP
26 #define SHARE_VM_GC_IMPLEMENTATION_SHARED_GCSTATS_HPP
28 #include "gc_implementation/shared/gcUtil.hpp"
30 class GCStats : public CHeapObj<mtGC> {
31 protected:
32 // Avg amount promoted; used for avoiding promotion undo
33 // This class does not update deviations if the sample is zero.
34 AdaptivePaddedNoZeroDevAverage* _avg_promoted;
36 public:
37 GCStats();
39 enum Name {
40 GCStatsKind,
41 CMSGCStatsKind
42 };
44 virtual Name kind() {
45 return GCStatsKind;
46 }
48 AdaptivePaddedNoZeroDevAverage* avg_promoted() const { return _avg_promoted; }
50 // Average in bytes
51 size_t average_promoted_in_bytes() const {
52 return (size_t)_avg_promoted->average();
53 }
55 // Padded average in bytes
56 size_t padded_average_promoted_in_bytes() const {
57 return (size_t)_avg_promoted->padded_average();
58 }
59 };
61 class CMSGCStats : public GCStats {
62 public:
63 CMSGCStats();
65 virtual Name kind() {
66 return CMSGCStatsKind;
67 }
68 };
70 #endif // SHARE_VM_GC_IMPLEMENTATION_SHARED_GCSTATS_HPP