Thu, 20 Sep 2012 09:52:56 -0700
7190666: G1: assert(_unused == 0) failed: Inconsistency in PLAB stats
Summary: Reset the fields in ParGCAllocBuffer, that are used for accumulating values for the ResizePLAB sensors in PLABStats, to zero after flushing the values to the PLABStats fields. Flush PLABStats values only when retiring the final allocation buffers prior to disposing of a G1ParScanThreadState object, rather than when retiring every allocation buffer.
Reviewed-by: jwilhelm, jmasa, ysr
1 /*
2 * Copyright (c) 1997, 2010, Oracle and/or its affiliates. All rights reserved.
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4 *
5 * This code is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 only, as
7 * published by the Free Software Foundation.
8 *
9 * This code is distributed in the hope that it will be useful, but WITHOUT
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
12 * version 2 for more details (a copy is included in the LICENSE file that
13 * accompanied this code).
14 *
15 * You should have received a copy of the GNU General Public License version
16 * 2 along with this work; if not, write to the Free Software Foundation,
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
18 *
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
20 * or visit www.oracle.com if you need additional information or have any
21 * questions.
22 *
23 */
25 #include "precompiled.hpp"
26 #include "gc_implementation/shared/ageTable.hpp"
27 #include "gc_implementation/shared/gcPolicyCounters.hpp"
28 #include "memory/collectorPolicy.hpp"
29 #include "memory/resourceArea.hpp"
30 #include "memory/sharedHeap.hpp"
31 #include "utilities/copy.hpp"
33 /* Copyright (c) 1992-2009 Oracle and/or its affiliates, and Stanford University.
34 See the LICENSE file for license information. */
36 ageTable::ageTable(bool global) {
38 clear();
40 if (UsePerfData && global) {
42 ResourceMark rm;
43 EXCEPTION_MARK;
45 const char* agetable_ns = "generation.0.agetable";
46 const char* bytes_ns = PerfDataManager::name_space(agetable_ns, "bytes");
48 for(int age = 0; age < table_size; age ++) {
49 char age_name[10];
50 jio_snprintf(age_name, sizeof(age_name), "%2.2d", age);
51 const char* cname = PerfDataManager::counter_name(bytes_ns, age_name);
52 _perf_sizes[age] = PerfDataManager::create_variable(SUN_GC, cname,
53 PerfData::U_Bytes,
54 CHECK);
55 }
57 const char* cname = PerfDataManager::counter_name(agetable_ns, "size");
58 PerfDataManager::create_constant(SUN_GC, cname, PerfData::U_None,
59 table_size, CHECK);
60 }
61 }
63 void ageTable::clear() {
64 for (size_t* p = sizes; p < sizes + table_size; ++p) {
65 *p = 0;
66 }
67 }
69 void ageTable::merge(ageTable* subTable) {
70 for (int i = 0; i < table_size; i++) {
71 sizes[i]+= subTable->sizes[i];
72 }
73 }
75 void ageTable::merge_par(ageTable* subTable) {
76 for (int i = 0; i < table_size; i++) {
77 Atomic::add_ptr(subTable->sizes[i], &sizes[i]);
78 }
79 }
81 int ageTable::compute_tenuring_threshold(size_t survivor_capacity) {
82 size_t desired_survivor_size = (size_t)((((double) survivor_capacity)*TargetSurvivorRatio)/100);
83 size_t total = 0;
84 int age = 1;
85 assert(sizes[0] == 0, "no objects with age zero should be recorded");
86 while (age < table_size) {
87 total += sizes[age];
88 // check if including objects of age 'age' made us pass the desired
89 // size, if so 'age' is the new threshold
90 if (total > desired_survivor_size) break;
91 age++;
92 }
93 int result = age < MaxTenuringThreshold ? age : MaxTenuringThreshold;
95 if (PrintTenuringDistribution || UsePerfData) {
97 if (PrintTenuringDistribution) {
98 gclog_or_tty->cr();
99 gclog_or_tty->print_cr("Desired survivor size %ld bytes, new threshold %d (max %d)",
100 desired_survivor_size*oopSize, result, MaxTenuringThreshold);
101 }
103 total = 0;
104 age = 1;
105 while (age < table_size) {
106 total += sizes[age];
107 if (sizes[age] > 0) {
108 if (PrintTenuringDistribution) {
109 gclog_or_tty->print_cr("- age %3d: %10ld bytes, %10ld total",
110 age, sizes[age]*oopSize, total*oopSize);
111 }
112 }
113 if (UsePerfData) {
114 _perf_sizes[age]->set_value(sizes[age]*oopSize);
115 }
116 age++;
117 }
118 if (UsePerfData) {
119 SharedHeap* sh = SharedHeap::heap();
120 CollectorPolicy* policy = sh->collector_policy();
121 GCPolicyCounters* gc_counters = policy->counters();
122 gc_counters->tenuring_threshold()->set_value(result);
123 gc_counters->desired_survivor_size()->set_value(
124 desired_survivor_size*oopSize);
125 }
126 }
128 return result;
129 }