Tue, 20 Jul 2010 08:41:42 -0700
6964170: Verifier crashes
Summary: Check if klassOop != NULL rather than klass_part != NULL
Reviewed-by: kamg, never
1 /*
2 * Copyright (c) 1997, 2009, Oracle and/or its affiliates. All rights reserved.
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4 *
5 * This code is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 only, as
7 * published by the Free Software Foundation.
8 *
9 * This code is distributed in the hope that it will be useful, but WITHOUT
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
12 * version 2 for more details (a copy is included in the LICENSE file that
13 * accompanied this code).
14 *
15 * You should have received a copy of the GNU General Public License version
16 * 2 along with this work; if not, write to the Free Software Foundation,
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
18 *
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
20 * or visit www.oracle.com if you need additional information or have any
21 * questions.
22 *
23 */
25 # include "incls/_precompiled.incl"
26 # include "incls/_vmSymbols.cpp.incl"
29 symbolOop vmSymbols::_symbols[vmSymbols::SID_LIMIT];
31 symbolOop vmSymbols::_type_signatures[T_VOID+1] = { NULL /*, NULL...*/ };
33 inline int compare_symbol(symbolOop a, symbolOop b) {
34 if (a == b) return 0;
35 // follow the natural address order:
36 return (address)a > (address)b ? +1 : -1;
37 }
39 static vmSymbols::SID vm_symbol_index[vmSymbols::SID_LIMIT];
40 extern "C" {
41 static int compare_vmsymbol_sid(const void* void_a, const void* void_b) {
42 symbolOop a = vmSymbols::symbol_at(*((vmSymbols::SID*) void_a));
43 symbolOop b = vmSymbols::symbol_at(*((vmSymbols::SID*) void_b));
44 return compare_symbol(a, b);
45 }
46 }
48 #ifndef PRODUCT
49 #define VM_SYMBOL_ENUM_NAME_BODY(name, string) #name "\0"
50 static const char* vm_symbol_enum_names =
51 VM_SYMBOLS_DO(VM_SYMBOL_ENUM_NAME_BODY, VM_ALIAS_IGNORE)
52 "\0";
53 static const char* vm_symbol_enum_name(vmSymbols::SID sid) {
54 const char* string = &vm_symbol_enum_names[0];
55 int skip = (int)sid - (int)vmSymbols::FIRST_SID;
56 for (; skip != 0; skip--) {
57 size_t skiplen = strlen(string);
58 if (skiplen == 0) return "<unknown>"; // overflow
59 string += skiplen+1;
60 }
61 return string;
62 }
63 #endif //PRODUCT
65 // Put all the VM symbol strings in one place.
66 // Makes for a more compact libjvm.
67 #define VM_SYMBOL_BODY(name, string) string "\0"
68 static const char* vm_symbol_bodies = VM_SYMBOLS_DO(VM_SYMBOL_BODY, VM_ALIAS_IGNORE);
70 void vmSymbols::initialize(TRAPS) {
71 assert((int)SID_LIMIT <= (1<<log2_SID_LIMIT), "must fit in this bitfield");
72 assert((int)SID_LIMIT*5 > (1<<log2_SID_LIMIT), "make the bitfield smaller, please");
73 assert(vmIntrinsics::FLAG_LIMIT <= (1 << vmIntrinsics::log2_FLAG_LIMIT), "must fit in this bitfield");
75 if (!UseSharedSpaces) {
76 const char* string = &vm_symbol_bodies[0];
77 for (int index = (int)FIRST_SID; index < (int)SID_LIMIT; index++) {
78 symbolOop sym = oopFactory::new_symbol(string, CHECK);
79 _symbols[index] = sym;
80 string += strlen(string); // skip string body
81 string += 1; // skip trailing null
82 }
84 _type_signatures[T_BYTE] = byte_signature();
85 _type_signatures[T_CHAR] = char_signature();
86 _type_signatures[T_DOUBLE] = double_signature();
87 _type_signatures[T_FLOAT] = float_signature();
88 _type_signatures[T_INT] = int_signature();
89 _type_signatures[T_LONG] = long_signature();
90 _type_signatures[T_SHORT] = short_signature();
91 _type_signatures[T_BOOLEAN] = bool_signature();
92 _type_signatures[T_VOID] = void_signature();
93 // no single signatures for T_OBJECT or T_ARRAY
94 }
96 #ifdef ASSERT
97 // Check for duplicates:
98 for (int i1 = (int)FIRST_SID; i1 < (int)SID_LIMIT; i1++) {
99 symbolOop sym = symbol_at((SID)i1);
100 for (int i2 = (int)FIRST_SID; i2 < i1; i2++) {
101 if (symbol_at((SID)i2) == sym) {
102 tty->print("*** Duplicate VM symbol SIDs %s(%d) and %s(%d): \"",
103 vm_symbol_enum_name((SID)i2), i2,
104 vm_symbol_enum_name((SID)i1), i1);
105 sym->print_symbol_on(tty);
106 tty->print_cr("\"");
107 }
108 }
109 }
110 #endif //ASSERT
112 // Create an index for find_id:
113 {
114 for (int index = (int)FIRST_SID; index < (int)SID_LIMIT; index++) {
115 vm_symbol_index[index] = (SID)index;
116 }
117 int num_sids = SID_LIMIT-FIRST_SID;
118 qsort(&vm_symbol_index[FIRST_SID], num_sids, sizeof(vm_symbol_index[0]),
119 compare_vmsymbol_sid);
120 }
122 #ifdef ASSERT
123 {
124 // Spot-check correspondence between strings, symbols, and enums:
125 assert(_symbols[NO_SID] == NULL, "must be");
126 const char* str = "java/lang/Object";
127 symbolOop sym = oopFactory::new_symbol(str, CHECK);
128 assert(strcmp(str, (char*)sym->base()) == 0, "");
129 assert(sym == java_lang_Object(), "");
130 SID sid = VM_SYMBOL_ENUM_NAME(java_lang_Object);
131 assert(find_sid(sym) == sid, "");
132 assert(symbol_at(sid) == sym, "");
134 // Make sure find_sid produces the right answer in each case.
135 for (int index = (int)FIRST_SID; index < (int)SID_LIMIT; index++) {
136 sym = symbol_at((SID)index);
137 sid = find_sid(sym);
138 assert(sid == (SID)index, "symbol index works");
139 // Note: If there are duplicates, this assert will fail.
140 // A "Duplicate VM symbol" message will have already been printed.
141 }
143 // The string "format" happens (at the moment) not to be a vmSymbol,
144 // though it is a method name in java.lang.String.
145 str = "format";
146 sym = oopFactory::new_symbol(str, CHECK);
147 sid = find_sid(sym);
148 assert(sid == NO_SID, "symbol index works (negative test)");
149 }
150 #endif
151 }
154 #ifndef PRODUCT
155 const char* vmSymbols::name_for(vmSymbols::SID sid) {
156 if (sid == NO_SID)
157 return "NO_SID";
158 const char* string = &vm_symbol_bodies[0];
159 for (int index = (int)FIRST_SID; index < (int)SID_LIMIT; index++) {
160 if (index == (int)sid)
161 return string;
162 string += strlen(string); // skip string body
163 string += 1; // skip trailing null
164 }
165 return "BAD_SID";
166 }
167 #endif
171 void vmSymbols::oops_do(OopClosure* f, bool do_all) {
172 for (int index = (int)FIRST_SID; index < (int)SID_LIMIT; index++) {
173 f->do_oop((oop*) &_symbols[index]);
174 }
175 for (int i = 0; i < T_VOID+1; i++) {
176 if (_type_signatures[i] != NULL) {
177 assert(i >= T_BOOLEAN, "checking");
178 f->do_oop((oop*)&_type_signatures[i]);
179 } else if (do_all) {
180 f->do_oop((oop*)&_type_signatures[i]);
181 }
182 }
183 }
186 BasicType vmSymbols::signature_type(symbolOop s) {
187 assert(s != NULL, "checking");
188 for (int i = T_BOOLEAN; i < T_VOID+1; i++) {
189 if (s == _type_signatures[i]) {
190 return (BasicType)i;
191 }
192 }
193 return T_OBJECT;
194 }
197 static int mid_hint = (int)vmSymbols::FIRST_SID+1;
199 #ifndef PRODUCT
200 static int find_sid_calls, find_sid_probes;
201 // (Typical counts are calls=7000 and probes=17000.)
202 #endif
204 vmSymbols::SID vmSymbols::find_sid(symbolOop symbol) {
205 // Handle the majority of misses by a bounds check.
206 // Then, use a binary search over the index.
207 // Expected trip count is less than log2_SID_LIMIT, about eight.
208 // This is slow but acceptable, given that calls are not
209 // dynamically common. (methodOop::intrinsic_id has a cache.)
210 NOT_PRODUCT(find_sid_calls++);
211 int min = (int)FIRST_SID, max = (int)SID_LIMIT - 1;
212 SID sid = NO_SID, sid1;
213 int cmp1;
214 sid1 = vm_symbol_index[min];
215 cmp1 = compare_symbol(symbol, symbol_at(sid1));
216 if (cmp1 <= 0) { // before the first
217 if (cmp1 == 0) sid = sid1;
218 } else {
219 sid1 = vm_symbol_index[max];
220 cmp1 = compare_symbol(symbol, symbol_at(sid1));
221 if (cmp1 >= 0) { // after the last
222 if (cmp1 == 0) sid = sid1;
223 } else {
224 // After checking the extremes, do a binary search.
225 ++min; --max; // endpoints are done
226 int mid = mid_hint; // start at previous success
227 while (max >= min) {
228 assert(mid >= min && mid <= max, "");
229 NOT_PRODUCT(find_sid_probes++);
230 sid1 = vm_symbol_index[mid];
231 cmp1 = compare_symbol(symbol, symbol_at(sid1));
232 if (cmp1 == 0) {
233 mid_hint = mid;
234 sid = sid1;
235 break;
236 }
237 if (cmp1 < 0)
238 max = mid - 1; // symbol < symbol_at(sid)
239 else
240 min = mid + 1;
242 // Pick a new probe point:
243 mid = (max + min) / 2;
244 }
245 }
246 }
248 #ifdef ASSERT
249 // Perform the exhaustive self-check the first 1000 calls,
250 // and every 100 calls thereafter.
251 static int find_sid_check_count = -2000;
252 if ((uint)++find_sid_check_count > (uint)100) {
253 if (find_sid_check_count > 0) find_sid_check_count = 0;
255 // Make sure this is the right answer, using linear search.
256 // (We have already proven that there are no duplicates in the list.)
257 SID sid2 = NO_SID;
258 for (int index = (int)FIRST_SID; index < (int)SID_LIMIT; index++) {
259 symbolOop sym2 = symbol_at((SID)index);
260 if (sym2 == symbol) {
261 sid2 = (SID)index;
262 break;
263 }
264 }
265 // Unless it's a duplicate, assert that the sids are the same.
266 if (_symbols[sid] != _symbols[sid2]) {
267 assert(sid == sid2, "binary same as linear search");
268 }
269 }
270 #endif //ASSERT
272 return sid;
273 }
275 static vmIntrinsics::ID wrapper_intrinsic(BasicType type, bool unboxing) {
276 #define TYPE2(type, unboxing) ((int)(type)*2 + ((unboxing) ? 1 : 0))
277 switch (TYPE2(type, unboxing)) {
278 #define BASIC_TYPE_CASE(type, box, unbox) \
279 case TYPE2(type, false): return vmIntrinsics::box; \
280 case TYPE2(type, true): return vmIntrinsics::unbox
281 BASIC_TYPE_CASE(T_BOOLEAN, _Boolean_valueOf, _booleanValue);
282 BASIC_TYPE_CASE(T_BYTE, _Byte_valueOf, _byteValue);
283 BASIC_TYPE_CASE(T_CHAR, _Character_valueOf, _charValue);
284 BASIC_TYPE_CASE(T_SHORT, _Short_valueOf, _shortValue);
285 BASIC_TYPE_CASE(T_INT, _Integer_valueOf, _intValue);
286 BASIC_TYPE_CASE(T_LONG, _Long_valueOf, _longValue);
287 BASIC_TYPE_CASE(T_FLOAT, _Float_valueOf, _floatValue);
288 BASIC_TYPE_CASE(T_DOUBLE, _Double_valueOf, _doubleValue);
289 #undef BASIC_TYPE_CASE
290 }
291 #undef TYPE2
292 return vmIntrinsics::_none;
293 }
295 vmIntrinsics::ID vmIntrinsics::for_boxing(BasicType type) {
296 return wrapper_intrinsic(type, false);
297 }
298 vmIntrinsics::ID vmIntrinsics::for_unboxing(BasicType type) {
299 return wrapper_intrinsic(type, true);
300 }
302 vmIntrinsics::ID vmIntrinsics::for_raw_conversion(BasicType src, BasicType dest) {
303 #define SRC_DEST(s,d) (((int)(s) << 4) + (int)(d))
304 switch (SRC_DEST(src, dest)) {
305 case SRC_DEST(T_INT, T_FLOAT): return vmIntrinsics::_intBitsToFloat;
306 case SRC_DEST(T_FLOAT, T_INT): return vmIntrinsics::_floatToRawIntBits;
308 case SRC_DEST(T_LONG, T_DOUBLE): return vmIntrinsics::_longBitsToDouble;
309 case SRC_DEST(T_DOUBLE, T_LONG): return vmIntrinsics::_doubleToRawLongBits;
310 }
311 #undef SRC_DEST
313 return vmIntrinsics::_none;
314 }
316 methodOop vmIntrinsics::method_for(vmIntrinsics::ID id) {
317 if (id == _none) return NULL;
318 symbolOop cname = vmSymbols::symbol_at(class_for(id));
319 symbolOop mname = vmSymbols::symbol_at(name_for(id));
320 symbolOop msig = vmSymbols::symbol_at(signature_for(id));
321 if (cname == NULL || mname == NULL || msig == NULL) return NULL;
322 klassOop k = SystemDictionary::find_well_known_klass(cname);
323 if (k == NULL) return NULL;
324 return instanceKlass::cast(k)->find_method(mname, msig);
325 }
328 #define VM_INTRINSIC_INITIALIZE(id, klass, name, sig, flags) #id "\0"
329 static const char* vm_intrinsic_name_bodies =
330 VM_INTRINSICS_DO(VM_INTRINSIC_INITIALIZE,
331 VM_SYMBOL_IGNORE, VM_SYMBOL_IGNORE, VM_SYMBOL_IGNORE, VM_ALIAS_IGNORE);
333 static const char* vm_intrinsic_name_table[vmIntrinsics::ID_LIMIT];
335 const char* vmIntrinsics::name_at(vmIntrinsics::ID id) {
336 const char** nt = &vm_intrinsic_name_table[0];
337 if (nt[_none] == NULL) {
338 char* string = (char*) &vm_intrinsic_name_bodies[0];
339 for (int index = FIRST_ID; index < ID_LIMIT; index++) {
340 nt[index] = string;
341 string += strlen(string); // skip string body
342 string += 1; // skip trailing null
343 }
344 assert(!strcmp(nt[_hashCode], "_hashCode"), "lined up");
345 nt[_none] = "_none";
346 }
347 if ((uint)id < (uint)ID_LIMIT)
348 return vm_intrinsic_name_table[(uint)id];
349 else
350 return "(unknown intrinsic)";
351 }
353 // These are flag-matching functions:
354 inline bool match_F_R(jshort flags) {
355 const int req = 0;
356 const int neg = JVM_ACC_STATIC | JVM_ACC_SYNCHRONIZED;
357 return (flags & (req | neg)) == req;
358 }
359 inline bool match_F_Y(jshort flags) {
360 const int req = JVM_ACC_SYNCHRONIZED;
361 const int neg = JVM_ACC_STATIC;
362 return (flags & (req | neg)) == req;
363 }
364 inline bool match_F_RN(jshort flags) {
365 const int req = JVM_ACC_NATIVE;
366 const int neg = JVM_ACC_STATIC | JVM_ACC_SYNCHRONIZED;
367 return (flags & (req | neg)) == req;
368 }
369 inline bool match_F_S(jshort flags) {
370 const int req = JVM_ACC_STATIC;
371 const int neg = JVM_ACC_SYNCHRONIZED;
372 return (flags & (req | neg)) == req;
373 }
374 inline bool match_F_SN(jshort flags) {
375 const int req = JVM_ACC_STATIC | JVM_ACC_NATIVE;
376 const int neg = JVM_ACC_SYNCHRONIZED;
377 return (flags & (req | neg)) == req;
378 }
379 inline bool match_F_RNY(jshort flags) {
380 const int req = JVM_ACC_NATIVE | JVM_ACC_SYNCHRONIZED;
381 const int neg = JVM_ACC_STATIC;
382 return (flags & (req | neg)) == req;
383 }
385 // These are for forming case labels:
386 #define ID3(x, y, z) (( jlong)(z) + \
387 ((jlong)(y) << vmSymbols::log2_SID_LIMIT) + \
388 ((jlong)(x) << (2*vmSymbols::log2_SID_LIMIT)) )
389 #define SID_ENUM(n) vmSymbols::VM_SYMBOL_ENUM_NAME(n)
391 vmIntrinsics::ID vmIntrinsics::find_id_impl(vmSymbols::SID holder,
392 vmSymbols::SID name,
393 vmSymbols::SID sig,
394 jshort flags) {
395 assert((int)vmSymbols::SID_LIMIT <= (1<<vmSymbols::log2_SID_LIMIT), "must fit");
397 // Let the C compiler build the decision tree.
399 #define VM_INTRINSIC_CASE(id, klass, name, sig, fcode) \
400 case ID3(SID_ENUM(klass), SID_ENUM(name), SID_ENUM(sig)): \
401 if (!match_##fcode(flags)) break; \
402 return id;
404 switch (ID3(holder, name, sig)) {
405 VM_INTRINSICS_DO(VM_INTRINSIC_CASE,
406 VM_SYMBOL_IGNORE, VM_SYMBOL_IGNORE, VM_SYMBOL_IGNORE, VM_ALIAS_IGNORE);
407 }
408 return vmIntrinsics::_none;
410 #undef VM_INTRINSIC_CASE
411 }
414 const char* vmIntrinsics::short_name_as_C_string(vmIntrinsics::ID id, char* buf, int buflen) {
415 const char* str = name_at(id);
416 #ifndef PRODUCT
417 const char* kname = vmSymbols::name_for(class_for(id));
418 const char* mname = vmSymbols::name_for(name_for(id));
419 const char* sname = vmSymbols::name_for(signature_for(id));
420 const char* fname = "";
421 switch (flags_for(id)) {
422 case F_Y: fname = "synchronized "; break;
423 case F_RN: fname = "native "; break;
424 case F_SN: fname = "native static "; break;
425 case F_S: fname = "static "; break;
426 case F_RNY:fname = "native synchronized "; break;
427 }
428 const char* kptr = strrchr(kname, '/');
429 if (kptr != NULL) kname = kptr + 1;
430 int len = jio_snprintf(buf, buflen, "%s: %s%s.%s%s",
431 str, fname, kname, mname, sname);
432 if (len < buflen)
433 str = buf;
434 #endif //PRODUCT
435 return str;
436 }
439 // These are to get information about intrinsics.
441 #define ID4(x, y, z, f) ((ID3(x, y, z) << vmIntrinsics::log2_FLAG_LIMIT) | (jlong) (f))
443 static const jlong intrinsic_info_array[vmIntrinsics::ID_LIMIT+1] = {
444 #define VM_INTRINSIC_INFO(ignore_id, klass, name, sig, fcode) \
445 ID4(SID_ENUM(klass), SID_ENUM(name), SID_ENUM(sig), vmIntrinsics::fcode),
447 0, VM_INTRINSICS_DO(VM_INTRINSIC_INFO,
448 VM_SYMBOL_IGNORE, VM_SYMBOL_IGNORE, VM_SYMBOL_IGNORE, VM_ALIAS_IGNORE)
449 0
450 #undef VM_INTRINSIC_INFO
451 };
453 inline jlong intrinsic_info(vmIntrinsics::ID id) {
454 return intrinsic_info_array[vmIntrinsics::ID_from((int)id)];
455 }
457 vmSymbols::SID vmIntrinsics::class_for(vmIntrinsics::ID id) {
458 jlong info = intrinsic_info(id);
459 int shift = 2*vmSymbols::log2_SID_LIMIT + log2_FLAG_LIMIT, mask = right_n_bits(vmSymbols::log2_SID_LIMIT);
460 assert(((ID4(1021,1022,1023,15) >> shift) & mask) == 1021, "");
461 return vmSymbols::SID( (info >> shift) & mask );
462 }
464 vmSymbols::SID vmIntrinsics::name_for(vmIntrinsics::ID id) {
465 jlong info = intrinsic_info(id);
466 int shift = vmSymbols::log2_SID_LIMIT + log2_FLAG_LIMIT, mask = right_n_bits(vmSymbols::log2_SID_LIMIT);
467 assert(((ID4(1021,1022,1023,15) >> shift) & mask) == 1022, "");
468 return vmSymbols::SID( (info >> shift) & mask );
469 }
471 vmSymbols::SID vmIntrinsics::signature_for(vmIntrinsics::ID id) {
472 jlong info = intrinsic_info(id);
473 int shift = log2_FLAG_LIMIT, mask = right_n_bits(vmSymbols::log2_SID_LIMIT);
474 assert(((ID4(1021,1022,1023,15) >> shift) & mask) == 1023, "");
475 return vmSymbols::SID( (info >> shift) & mask );
476 }
478 vmIntrinsics::Flags vmIntrinsics::flags_for(vmIntrinsics::ID id) {
479 jlong info = intrinsic_info(id);
480 int shift = 0, mask = right_n_bits(log2_FLAG_LIMIT);
481 assert(((ID4(1021,1022,1023,15) >> shift) & mask) == 15, "");
482 return Flags( (info >> shift) & mask );
483 }
486 #ifndef PRODUCT
487 // verify_method performs an extra check on a matched intrinsic method
489 static bool match_method(methodOop m, symbolOop n, symbolOop s) {
490 return (m->name() == n &&
491 m->signature() == s);
492 }
494 static vmIntrinsics::ID match_method_with_klass(methodOop m, symbolOop mk) {
495 #define VM_INTRINSIC_MATCH(id, klassname, namepart, sigpart, flags) \
496 { symbolOop k = vmSymbols::klassname(); \
497 if (mk == k) { \
498 symbolOop n = vmSymbols::namepart(); \
499 symbolOop s = vmSymbols::sigpart(); \
500 if (match_method(m, n, s)) \
501 return vmIntrinsics::id; \
502 } }
503 VM_INTRINSICS_DO(VM_INTRINSIC_MATCH,
504 VM_SYMBOL_IGNORE, VM_SYMBOL_IGNORE, VM_SYMBOL_IGNORE, VM_ALIAS_IGNORE);
505 return vmIntrinsics::_none;
506 #undef VM_INTRINSIC_MATCH
507 }
509 void vmIntrinsics::verify_method(ID actual_id, methodOop m) {
510 symbolOop mk = Klass::cast(m->method_holder())->name();
511 ID declared_id = match_method_with_klass(m, mk);
513 if (declared_id == actual_id) return; // success
515 if (declared_id == _none && actual_id != _none && mk == vmSymbols::java_lang_StrictMath()) {
516 // Here are a few special cases in StrictMath not declared in vmSymbols.hpp.
517 switch (actual_id) {
518 case _min:
519 case _max:
520 case _dsqrt:
521 declared_id = match_method_with_klass(m, vmSymbols::java_lang_Math());
522 if (declared_id == actual_id) return; // acceptable alias
523 break;
524 }
525 }
527 const char* declared_name = name_at(declared_id);
528 const char* actual_name = name_at(actual_id);
529 methodHandle mh = m;
530 m = NULL;
531 ttyLocker ttyl;
532 if (xtty != NULL) {
533 xtty->begin_elem("intrinsic_misdeclared actual='%s' declared='%s'",
534 actual_name, declared_name);
535 xtty->method(mh);
536 xtty->end_elem("");
537 }
538 if (PrintMiscellaneous && (WizardMode || Verbose)) {
539 tty->print_cr("*** misidentified method; %s(%d) should be %s(%d):",
540 declared_name, declared_id, actual_name, actual_id);
541 mh()->print_short_name(tty);
542 tty->cr();
543 }
544 }
545 #endif //PRODUCT