Tue, 05 May 2009 22:15:35 -0700
6833576: G1: assert illegal index, growableArray.hpp:186
Summary: The code that calculates the heap region index for an object address incorrectly used signed arithmetic.
Reviewed-by: jcoomes, ysr
1 /*
2 * Copyright 2001-2007 Sun Microsystems, Inc. All Rights Reserved.
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4 *
5 * This code is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 only, as
7 * published by the Free Software Foundation.
8 *
9 * This code is distributed in the hope that it will be useful, but WITHOUT
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
12 * version 2 for more details (a copy is included in the LICENSE file that
13 * accompanied this code).
14 *
15 * You should have received a copy of the GNU General Public License version
16 * 2 along with this work; if not, write to the Free Software Foundation,
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
18 *
19 * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
20 * CA 95054 USA or visit www.sun.com if you need additional information or
21 * have any questions.
22 *
23 */
25 class ObjectClosure;
26 class JavaThread;
28 // A ptrQueue whose elements are "oops", pointers to object heads.
29 class ObjPtrQueue: public PtrQueue {
30 public:
31 ObjPtrQueue(PtrQueueSet* qset_, bool perm = false) :
32 PtrQueue(qset_, perm)
33 {}
34 // Apply the closure to all elements, and reset the index to make the
35 // buffer empty.
36 void apply_closure(ObjectClosure* cl);
38 // Apply the closure to all elements of "buf", down to "index" (inclusive.)
39 static void apply_closure_to_buffer(ObjectClosure* cl,
40 void** buf, size_t index, size_t sz);
42 };
46 class SATBMarkQueueSet: public PtrQueueSet {
47 ObjectClosure* _closure;
48 ObjectClosure** _par_closures; // One per ParGCThread.
50 ObjPtrQueue _shared_satb_queue;
52 // Utility function to support sequential and parallel versions. If
53 // "par" is true, then "worker" is the par thread id; if "false", worker
54 // is ignored.
55 bool apply_closure_to_completed_buffer_work(bool par, int worker);
58 public:
59 SATBMarkQueueSet();
61 void initialize(Monitor* cbl_mon, Mutex* fl_lock,
62 int max_completed_queue = 0,
63 Mutex* lock = NULL);
65 static void handle_zero_index_for_thread(JavaThread* t);
67 // Apply "set_active(b)" to all thread tloq's. Should be called only
68 // with the world stopped.
69 void set_active_all_threads(bool b);
71 // Register "blk" as "the closure" for all queues. Only one such closure
72 // is allowed. The "apply_closure_to_completed_buffer" method will apply
73 // this closure to a completed buffer, and "iterate_closure_all_threads"
74 // applies it to partially-filled buffers (the latter should only be done
75 // with the world stopped).
76 void set_closure(ObjectClosure* closure);
77 // Set the parallel closures: pointer is an array of pointers to
78 // closures, one for each parallel GC thread.
79 void set_par_closure(int i, ObjectClosure* closure);
81 // If there is a registered closure for buffers, apply it to all entries
82 // in all currently-active buffers. This should only be applied at a
83 // safepoint. (Currently must not be called in parallel; this should
84 // change in the future.)
85 void iterate_closure_all_threads();
86 // Parallel version of the above.
87 void par_iterate_closure_all_threads(int worker);
89 // If there exists some completed buffer, pop it, then apply the
90 // registered closure to all its elements, and return true. If no
91 // completed buffers exist, return false.
92 bool apply_closure_to_completed_buffer() {
93 return apply_closure_to_completed_buffer_work(false, 0);
94 }
95 // Parallel version of the above.
96 bool par_apply_closure_to_completed_buffer(int worker) {
97 return apply_closure_to_completed_buffer_work(true, worker);
98 }
100 ObjPtrQueue* shared_satb_queue() { return &_shared_satb_queue; }
102 // If a marking is being abandoned, reset any unprocessed log buffers.
103 void abandon_partial_marking();
105 };