Thu, 13 Jan 2011 22:15:41 -0800
4926272: methodOopDesc::method_from_bcp is unsafe
Reviewed-by: coleenp, jrose, kvn, dcubed
1 /*
2 * Copyright (c) 1997, 2011, Oracle and/or its affiliates. All rights reserved.
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4 *
5 * This code is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 only, as
7 * published by the Free Software Foundation.
8 *
9 * This code is distributed in the hope that it will be useful, but WITHOUT
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
12 * version 2 for more details (a copy is included in the LICENSE file that
13 * accompanied this code).
14 *
15 * You should have received a copy of the GNU General Public License version
16 * 2 along with this work; if not, write to the Free Software Foundation,
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
18 *
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
20 * or visit www.oracle.com if you need additional information or have any
21 * questions.
22 *
23 */
25 #include "precompiled.hpp"
26 #include "interpreter/bytecode.hpp"
27 #include "interpreter/linkResolver.hpp"
28 #include "oops/constantPoolOop.hpp"
29 #include "oops/oop.inline.hpp"
30 #include "runtime/fieldType.hpp"
31 #include "runtime/handles.inline.hpp"
32 #include "runtime/safepoint.hpp"
33 #include "runtime/signature.hpp"
35 // Implementation of Bytecode
37 #ifdef ASSERT
39 void Bytecode::assert_same_format_as(Bytecodes::Code testbc, bool is_wide) const {
40 Bytecodes::Code thisbc = Bytecodes::cast(byte_at(0));
41 if (thisbc == Bytecodes::_breakpoint) return; // let the assertion fail silently
42 if (is_wide) {
43 assert(thisbc == Bytecodes::_wide, "expected a wide instruction");
44 thisbc = Bytecodes::cast(byte_at(1));
45 if (thisbc == Bytecodes::_breakpoint) return;
46 }
47 int thisflags = Bytecodes::flags(testbc, is_wide) & Bytecodes::_all_fmt_bits;
48 int testflags = Bytecodes::flags(thisbc, is_wide) & Bytecodes::_all_fmt_bits;
49 if (thisflags != testflags)
50 tty->print_cr("assert_same_format_as(%d) failed on bc=%d%s; %d != %d",
51 (int)testbc, (int)thisbc, (is_wide?"/wide":""), testflags, thisflags);
52 assert(thisflags == testflags, "expected format");
53 }
55 void Bytecode::assert_index_size(int size, Bytecodes::Code bc, bool is_wide) {
56 int have_fmt = (Bytecodes::flags(bc, is_wide)
57 & (Bytecodes::_fmt_has_u2 | Bytecodes::_fmt_has_u4 |
58 Bytecodes::_fmt_not_simple |
59 // Not an offset field:
60 Bytecodes::_fmt_has_o));
61 int need_fmt = -1;
62 switch (size) {
63 case 1: need_fmt = 0; break;
64 case 2: need_fmt = Bytecodes::_fmt_has_u2; break;
65 case 4: need_fmt = Bytecodes::_fmt_has_u4; break;
66 }
67 if (is_wide) need_fmt |= Bytecodes::_fmt_not_simple;
68 if (have_fmt != need_fmt) {
69 tty->print_cr("assert_index_size %d: bc=%d%s %d != %d", size, bc, (is_wide?"/wide":""), have_fmt, need_fmt);
70 assert(have_fmt == need_fmt, "assert_index_size");
71 }
72 }
74 void Bytecode::assert_offset_size(int size, Bytecodes::Code bc, bool is_wide) {
75 int have_fmt = Bytecodes::flags(bc, is_wide) & Bytecodes::_all_fmt_bits;
76 int need_fmt = -1;
77 switch (size) {
78 case 2: need_fmt = Bytecodes::_fmt_bo2; break;
79 case 4: need_fmt = Bytecodes::_fmt_bo4; break;
80 }
81 if (is_wide) need_fmt |= Bytecodes::_fmt_not_simple;
82 if (have_fmt != need_fmt) {
83 tty->print_cr("assert_offset_size %d: bc=%d%s %d != %d", size, bc, (is_wide?"/wide":""), have_fmt, need_fmt);
84 assert(have_fmt == need_fmt, "assert_offset_size");
85 }
86 }
88 void Bytecode::assert_constant_size(int size, int where, Bytecodes::Code bc, bool is_wide) {
89 int have_fmt = Bytecodes::flags(bc, is_wide) & (Bytecodes::_all_fmt_bits
90 // Ignore any 'i' field (for iinc):
91 & ~Bytecodes::_fmt_has_i);
92 int need_fmt = -1;
93 switch (size) {
94 case 1: need_fmt = Bytecodes::_fmt_bc; break;
95 case 2: need_fmt = Bytecodes::_fmt_bc | Bytecodes::_fmt_has_u2; break;
96 }
97 if (is_wide) need_fmt |= Bytecodes::_fmt_not_simple;
98 int length = is_wide ? Bytecodes::wide_length_for(bc) : Bytecodes::length_for(bc);
99 if (have_fmt != need_fmt || where + size != length) {
100 tty->print_cr("assert_constant_size %d @%d: bc=%d%s %d != %d", size, where, bc, (is_wide?"/wide":""), have_fmt, need_fmt);
101 }
102 assert(have_fmt == need_fmt, "assert_constant_size");
103 assert(where + size == length, "assert_constant_size oob");
104 }
106 void Bytecode::assert_native_index(Bytecodes::Code bc, bool is_wide) {
107 assert((Bytecodes::flags(bc, is_wide) & Bytecodes::_fmt_has_nbo) != 0, "native index");
108 }
110 #endif //ASSERT
112 // Implementation of Bytecode_tableupswitch
114 int Bytecode_tableswitch::dest_offset_at(int i) const {
115 return get_Java_u4_at(aligned_offset(1 + (3 + i)*jintSize));
116 }
119 // Implementation of Bytecode_invoke
121 void Bytecode_invoke::verify() const {
122 assert(is_valid(), "check invoke");
123 assert(method()->constants()->cache() != NULL, "do not call this from verifier or rewriter");
124 }
127 symbolOop Bytecode_member_ref::signature() const {
128 constantPoolOop constants = method()->constants();
129 return constants->signature_ref_at(index());
130 }
133 symbolOop Bytecode_member_ref::name() const {
134 constantPoolOop constants = method()->constants();
135 return constants->name_ref_at(index());
136 }
139 BasicType Bytecode_member_ref::result_type(Thread *thread) const {
140 symbolHandle sh(thread, signature());
141 ResultTypeFinder rts(sh);
142 rts.iterate();
143 return rts.type();
144 }
147 methodHandle Bytecode_invoke::static_target(TRAPS) {
148 methodHandle m;
149 KlassHandle resolved_klass;
150 constantPoolHandle constants(THREAD, _method->constants());
152 if (java_code() == Bytecodes::_invokedynamic) {
153 LinkResolver::resolve_dynamic_method(m, resolved_klass, constants, index(), CHECK_(methodHandle()));
154 } else if (java_code() != Bytecodes::_invokeinterface) {
155 LinkResolver::resolve_method(m, resolved_klass, constants, index(), CHECK_(methodHandle()));
156 } else {
157 LinkResolver::resolve_interface_method(m, resolved_klass, constants, index(), CHECK_(methodHandle()));
158 }
159 return m;
160 }
163 int Bytecode_member_ref::index() const {
164 // Note: Rewriter::rewrite changes the Java_u2 of an invokedynamic to a native_u4,
165 // at the same time it allocates per-call-site CP cache entries.
166 Bytecodes::Code rawc = code();
167 if (has_index_u4(rawc))
168 return get_index_u4(rawc);
169 else
170 return get_index_u2_cpcache(rawc);
171 }
173 int Bytecode_member_ref::pool_index() const {
174 int index = this->index();
175 DEBUG_ONLY({
176 if (!has_index_u4(code()))
177 index -= constantPoolOopDesc::CPCACHE_INDEX_TAG;
178 });
179 return _method->constants()->cache()->entry_at(index)->constant_pool_index();
180 }
182 // Implementation of Bytecode_field
184 void Bytecode_field::verify() const {
185 assert(is_valid(), "check field");
186 }
189 // Implementation of Bytecode_loadconstant
191 int Bytecode_loadconstant::raw_index() const {
192 Bytecodes::Code rawc = code();
193 assert(rawc != Bytecodes::_wide, "verifier prevents this");
194 if (Bytecodes::java_code(rawc) == Bytecodes::_ldc)
195 return get_index_u1(rawc);
196 else
197 return get_index_u2(rawc, false);
198 }
200 int Bytecode_loadconstant::pool_index() const {
201 int index = raw_index();
202 if (has_cache_index()) {
203 return _method->constants()->cache()->entry_at(index)->constant_pool_index();
204 }
205 return index;
206 }
208 BasicType Bytecode_loadconstant::result_type() const {
209 int index = pool_index();
210 constantTag tag = _method->constants()->tag_at(index);
211 return tag.basic_type();
212 }
214 oop Bytecode_loadconstant::resolve_constant(TRAPS) const {
215 assert(_method.not_null(), "must supply method to resolve constant");
216 int index = raw_index();
217 constantPoolOop constants = _method->constants();
218 if (has_cache_index()) {
219 return constants->resolve_cached_constant_at(index, THREAD);
220 } else {
221 return constants->resolve_constant_at(index, THREAD);
222 }
223 }
225 //------------------------------------------------------------------------------
226 // Non-product code
228 #ifndef PRODUCT
230 void Bytecode_lookupswitch::verify() const {
231 switch (Bytecodes::java_code(code())) {
232 case Bytecodes::_lookupswitch:
233 { int i = number_of_pairs() - 1;
234 while (i-- > 0) {
235 assert(pair_at(i).match() < pair_at(i+1).match(), "unsorted table entries");
236 }
237 }
238 break;
239 default:
240 fatal("not a lookupswitch bytecode");
241 }
242 }
244 void Bytecode_tableswitch::verify() const {
245 switch (Bytecodes::java_code(code())) {
246 case Bytecodes::_tableswitch:
247 { int lo = low_key();
248 int hi = high_key();
249 assert (hi >= lo, "incorrect hi/lo values in tableswitch");
250 int i = hi - lo - 1 ;
251 while (i-- > 0) {
252 // no special check needed
253 }
254 }
255 break;
256 default:
257 fatal("not a tableswitch bytecode");
258 }
259 }
261 #endif