Tue, 21 Aug 2012 14:10:39 -0700
7185699: G1: Prediction model discrepancies
Summary: Correct the result value of G1CollectedHeap::pending_card_num(). Change the code that calculates the GC efficiency of a non-young heap region to use historical data from mixed GCs and the actual number of live bytes when predicting how long it would take to collect the region. Changes were also reviewed by Thomas Schatzl.
Reviewed-by: azeemj, brutisso
1 #
2 # Copyright (c) 2011, Oracle and/or its affiliates. All rights reserved.
3 # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4 #
5 # This code is free software; you can redistribute it and/or modify it
6 # under the terms of the GNU General Public License version 2 only, as
7 # published by the Free Software Foundation.
8 #
9 # This code is distributed in the hope that it will be useful, but WITHOUT
10 # ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11 # FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
12 # version 2 for more details (a copy is included in the LICENSE file that
13 # accompanied this code).
14 #
15 # You should have received a copy of the GNU General Public License version
16 # 2 along with this work; if not, write to the Free Software Foundation,
17 # Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
18 #
19 # Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
20 # or visit www.oracle.com if you need additional information or have any
21 # questions.
22 #
23 #
25 # This file defines variables and macros which are used in the makefiles to
26 # allow distributions to augment or replace common hotspot code with
27 # distribution-specific source files. This capability is disabled when
28 # an OPENJDK build is requested, unless HS_ALT_SRC_REL has been set externally.
30 # Requires: GAMMADIR
31 # Provides:
32 # variables: HS_COMMON_SRC, HS_ALT_SRC, HS_COMMON_SRC_REL, and HS_ALT_SRC_REL
33 # functions: altsrc-equiv, if-has-altsrc, altsrc, altsrc-replace
35 HS_COMMON_SRC_REL=src
37 ifneq ($(OPENJDK),true)
38 # This needs to be changed to a more generic location, but we keep it
39 # as this for now for compatibility
40 HS_ALT_SRC_REL=src/closed
41 else
42 HS_ALT_SRC_REL=NO_SUCH_PATH
43 endif
45 HS_COMMON_SRC=$(GAMMADIR)/$(HS_COMMON_SRC_REL)
46 HS_ALT_SRC=$(GAMMADIR)/$(HS_ALT_SRC_REL)
48 ## altsrc-equiv
49 #
50 # Convert a common source path to an alternative source path
51 #
52 # Parameter: An absolute path into the common sources
53 # Result: The matching path to the alternate-source location
54 #
55 altsrc-equiv=$(subst $(HS_COMMON_SRC)/,$(HS_ALT_SRC)/,$(1))
58 ## if-has-altsrc
59 #
60 # Conditional macro to test for the existence of an alternate source path
61 #
62 # Parameter: An absolute path into the common sources
63 # Parameter: Result if the alternative-source location exists
64 # Parameter: Result if the alternative-source location does not exist
65 # Result: expands to parameter 2 or 3 depending on existence of alternate source
66 #
67 if-has-altsrc=$(if $(wildcard $(call altsrc-equiv,$(1))),$(2),$(3))
70 ## altsrc
71 #
72 # Converts common source path to alternate source path if the alternate
73 # path exists, otherwise evaluates to nul (empty string)
74 #
75 # Parameter: An absolute path into the common sources
76 # Result: The equivalent path to the alternate-source location, if such a
77 # location exists on the filesystem. Otherwise it expands to empty.
78 #
79 altsrc=$(call if-has-altsrc,$(1),$(call altsrc-equiv,$(1)))
81 ## commonsrc
82 #
83 # Returns parameter.
84 #
85 commonsrc=$(1)
88 ## altsrc-replace
89 #
90 # Converts a common source path to an alternate source path if the alternate
91 # source path exists. Otherwise it evaluates to the input common source path.
92 #
93 # Parameter: An absolute path into the common sources
94 # Result: A path to either the common or alternate sources
95 #
96 altsrc-replace=$(call if-has-altsrc,$(1),$(call altsrc-equiv,$(1)),$(1))