src/share/vm/oops/arrayOop.hpp

Mon, 31 Oct 2011 08:01:20 +0100

author
brutisso
date
Mon, 31 Oct 2011 08:01:20 +0100
changeset 3266
6fd81579526f
parent 2314
f95d63e2154a
child 3271
aa4c21b00f7f
permissions
-rw-r--r--

7102044: G1: VM crashes with assert(old_end != new_end) failed: don't call this otherwise
Summary: arrayOopDesc::max_array_length() should return a value that does not overflow a size_t if it is converted to bytes.
Reviewed-by: kvn, dholmes

     1 /*
     2  * Copyright (c) 1997, 2011, Oracle and/or its affiliates. All rights reserved.
     3  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
     4  *
     5  * This code is free software; you can redistribute it and/or modify it
     6  * under the terms of the GNU General Public License version 2 only, as
     7  * published by the Free Software Foundation.
     8  *
     9  * This code is distributed in the hope that it will be useful, but WITHOUT
    10  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
    11  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
    12  * version 2 for more details (a copy is included in the LICENSE file that
    13  * accompanied this code).
    14  *
    15  * You should have received a copy of the GNU General Public License version
    16  * 2 along with this work; if not, write to the Free Software Foundation,
    17  * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
    18  *
    19  * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
    20  * or visit www.oracle.com if you need additional information or have any
    21  * questions.
    22  *
    23  */
    25 #ifndef SHARE_VM_OOPS_ARRAYOOP_HPP
    26 #define SHARE_VM_OOPS_ARRAYOOP_HPP
    28 #include "memory/universe.inline.hpp"
    29 #include "oops/oop.hpp"
    31 // arrayOopDesc is the abstract baseclass for all arrays.  It doesn't
    32 // declare pure virtual to enforce this because that would allocate a vtbl
    33 // in each instance, which we don't want.
    35 // The layout of array Oops is:
    36 //
    37 //  markOop
    38 //  klassOop  // 32 bits if compressed but declared 64 in LP64.
    39 //  length    // shares klass memory or allocated after declared fields.
    42 class arrayOopDesc : public oopDesc {
    43   friend class VMStructs;
    45   // Interpreter/Compiler offsets
    47   // Header size computation.
    48   // The header is considered the oop part of this type plus the length.
    49   // Returns the aligned header_size_in_bytes.  This is not equivalent to
    50   // sizeof(arrayOopDesc) which should not appear in the code.
    51   static int header_size_in_bytes() {
    52     size_t hs = align_size_up(length_offset_in_bytes() + sizeof(int),
    53                               HeapWordSize);
    54 #ifdef ASSERT
    55     // make sure it isn't called before UseCompressedOops is initialized.
    56     static size_t arrayoopdesc_hs = 0;
    57     if (arrayoopdesc_hs == 0) arrayoopdesc_hs = hs;
    58     assert(arrayoopdesc_hs == hs, "header size can't change");
    59 #endif // ASSERT
    60     return (int)hs;
    61   }
    63  public:
    64   // The _length field is not declared in C++.  It is allocated after the
    65   // declared nonstatic fields in arrayOopDesc if not compressed, otherwise
    66   // it occupies the second half of the _klass field in oopDesc.
    67   static int length_offset_in_bytes() {
    68     return UseCompressedOops ? klass_gap_offset_in_bytes() :
    69                                sizeof(arrayOopDesc);
    70   }
    72   // Returns the offset of the first element.
    73   static int base_offset_in_bytes(BasicType type) {
    74     return header_size(type) * HeapWordSize;
    75   }
    77   // Returns the address of the first element.
    78   void* base(BasicType type) const {
    79     return (void*) (((intptr_t) this) + base_offset_in_bytes(type));
    80   }
    82   // Tells whether index is within bounds.
    83   bool is_within_bounds(int index) const        { return 0 <= index && index < length(); }
    85   // Accessors for instance variable which is not a C++ declared nonstatic
    86   // field.
    87   int length() const {
    88     return *(int*)(((intptr_t)this) + length_offset_in_bytes());
    89   }
    90   void set_length(int length) {
    91     *(int*)(((intptr_t)this) + length_offset_in_bytes()) = length;
    92   }
    94   // Should only be called with constants as argument
    95   // (will not constant fold otherwise)
    96   // Returns the header size in words aligned to the requirements of the
    97   // array object type.
    98   static int header_size(BasicType type) {
    99     size_t typesize_in_bytes = header_size_in_bytes();
   100     return (int)(Universe::element_type_should_be_aligned(type)
   101       ? align_object_offset(typesize_in_bytes/HeapWordSize)
   102       : typesize_in_bytes/HeapWordSize);
   103   }
   105   // Return the maximum length of an array of BasicType.  The length can passed
   106   // to typeArrayOop::object_size(scale, length, header_size) without causing an
   107   // overflow. We also need to make sure that this will not overflow a size_t on
   108   // 32 bit platforms when we convert it to a byte size.
   109   static int32_t max_array_length(BasicType type) {
   110     assert(type >= 0 && type < T_CONFLICT, "wrong type");
   111     assert(type2aelembytes(type) != 0, "wrong type");
   113     const size_t max_element_words_per_size_t  = align_size_down((SIZE_MAX/HeapWordSize - header_size(type)), MinObjAlignment);
   114     const size_t max_elements_per_size_t = HeapWordSize * max_element_words_per_size_t  / type2aelembytes(type);
   115     if ((size_t)max_jint < max_elements_per_size_t) {
   116       return max_jint;
   117     }
   118     return (int32_t)max_elements_per_size_t;
   119   }
   121 // for unit testing
   122 #ifndef PRODUCT
   123   static bool check_max_length_overflow(BasicType type);
   124   static int32_t old_max_array_length(BasicType type);
   125   static bool test_max_array_length();
   126 #endif
   127 };
   129 #endif // SHARE_VM_OOPS_ARRAYOOP_HPP

mercurial