Mon, 12 Mar 2012 14:59:00 -0700
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
Summary: Attempting to initiate a marking cycle when allocating a humongous object can, if a marking cycle is successfully initiated by another thread, result in the allocating thread spinning until the marking cycle is complete. Eliminate a deadlock between the main ConcurrentMarkThread, the SurrogateLocker thread, the VM thread, and a mutator thread waiting on the SecondaryFreeList_lock (while free regions are going to become available) by not manipulating the pending list lock during the prologue and epilogue of the cleanup pause.
Reviewed-by: brutisso, jcoomes, tonyp
1 /*
2 * Copyright (c) 2001, 2011, Oracle and/or its affiliates. All rights reserved.
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4 *
5 * This code is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 only, as
7 * published by the Free Software Foundation.
8 *
9 * This code is distributed in the hope that it will be useful, but WITHOUT
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
12 * version 2 for more details (a copy is included in the LICENSE file that
13 * accompanied this code).
14 *
15 * You should have received a copy of the GNU General Public License version
16 * 2 along with this work; if not, write to the Free Software Foundation,
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
18 *
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
20 * or visit www.oracle.com if you need additional information or have any
21 * questions.
22 *
23 */
25 #ifndef SHARE_VM_GC_IMPLEMENTATION_G1_HEAPREGIONSEQ_INLINE_HPP
26 #define SHARE_VM_GC_IMPLEMENTATION_G1_HEAPREGIONSEQ_INLINE_HPP
28 #include "gc_implementation/g1/heapRegion.hpp"
29 #include "gc_implementation/g1/heapRegionSeq.hpp"
31 inline size_t HeapRegionSeq::addr_to_index_biased(HeapWord* addr) const {
32 assert(_heap_bottom <= addr && addr < _heap_end,
33 err_msg("addr: "PTR_FORMAT" bottom: "PTR_FORMAT" end: "PTR_FORMAT,
34 addr, _heap_bottom, _heap_end));
35 size_t index = (size_t) addr >> _region_shift;
36 return index;
37 }
39 inline HeapRegion* HeapRegionSeq::addr_to_region_unsafe(HeapWord* addr) const {
40 assert(_heap_bottom <= addr && addr < _heap_end,
41 err_msg("addr: "PTR_FORMAT" bottom: "PTR_FORMAT" end: "PTR_FORMAT,
42 addr, _heap_bottom, _heap_end));
43 size_t index_biased = addr_to_index_biased(addr);
44 HeapRegion* hr = _regions_biased[index_biased];
45 assert(hr != NULL, "invariant");
46 return hr;
47 }
49 inline HeapRegion* HeapRegionSeq::addr_to_region(HeapWord* addr) const {
50 if (addr != NULL && addr < _heap_end) {
51 assert(addr >= _heap_bottom,
52 err_msg("addr: "PTR_FORMAT" bottom: "PTR_FORMAT, addr, _heap_bottom));
53 return addr_to_region_unsafe(addr);
54 }
55 return NULL;
56 }
58 inline HeapRegion* HeapRegionSeq::at(size_t index) const {
59 assert(index < length(), "pre-condition");
60 HeapRegion* hr = _regions[index];
61 assert(hr != NULL, "sanity");
62 assert(hr->hrs_index() == index, "sanity");
63 return hr;
64 }
66 #endif // SHARE_VM_GC_IMPLEMENTATION_G1_HEAPREGIONSEQ_INLINE_HPP