Mon, 12 Mar 2012 14:59:00 -0700
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
Summary: Attempting to initiate a marking cycle when allocating a humongous object can, if a marking cycle is successfully initiated by another thread, result in the allocating thread spinning until the marking cycle is complete. Eliminate a deadlock between the main ConcurrentMarkThread, the SurrogateLocker thread, the VM thread, and a mutator thread waiting on the SecondaryFreeList_lock (while free regions are going to become available) by not manipulating the pending list lock during the prologue and epilogue of the cleanup pause.
Reviewed-by: brutisso, jcoomes, tonyp
1 /*
2 * Copyright (c) 2001, 2012, Oracle and/or its affiliates. All rights reserved.
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4 *
5 * This code is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 only, as
7 * published by the Free Software Foundation.
8 *
9 * This code is distributed in the hope that it will be useful, but WITHOUT
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
12 * version 2 for more details (a copy is included in the LICENSE file that
13 * accompanied this code).
14 *
15 * You should have received a copy of the GNU General Public License version
16 * 2 along with this work; if not, write to the Free Software Foundation,
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
18 *
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
20 * or visit www.oracle.com if you need additional information or have any
21 * questions.
22 *
23 */
25 #ifndef SHARE_VM_GC_IMPLEMENTATION_G1_HEAPREGION_INLINE_HPP
26 #define SHARE_VM_GC_IMPLEMENTATION_G1_HEAPREGION_INLINE_HPP
28 inline HeapWord* G1OffsetTableContigSpace::allocate(size_t size) {
29 HeapWord* res = ContiguousSpace::allocate(size);
30 if (res != NULL) {
31 _offsets.alloc_block(res, size);
32 }
33 return res;
34 }
36 // Because of the requirement of keeping "_offsets" up to date with the
37 // allocations, we sequentialize these with a lock. Therefore, best if
38 // this is used for larger LAB allocations only.
39 inline HeapWord* G1OffsetTableContigSpace::par_allocate(size_t size) {
40 MutexLocker x(&_par_alloc_lock);
41 // Given that we take the lock no need to use par_allocate() here.
42 HeapWord* res = ContiguousSpace::allocate(size);
43 if (res != NULL) {
44 _offsets.alloc_block(res, size);
45 }
46 return res;
47 }
49 inline HeapWord* G1OffsetTableContigSpace::block_start(const void* p) {
50 return _offsets.block_start(p);
51 }
53 inline HeapWord*
54 G1OffsetTableContigSpace::block_start_const(const void* p) const {
55 return _offsets.block_start_const(p);
56 }
58 inline void HeapRegion::note_start_of_marking() {
59 init_top_at_conc_mark_count();
60 _next_marked_bytes = 0;
61 _next_top_at_mark_start = top();
62 }
64 inline void HeapRegion::note_end_of_marking() {
65 _prev_top_at_mark_start = _next_top_at_mark_start;
66 _prev_marked_bytes = _next_marked_bytes;
67 _next_marked_bytes = 0;
69 assert(_prev_marked_bytes <=
70 (size_t) pointer_delta(prev_top_at_mark_start(), bottom()) *
71 HeapWordSize, "invariant");
72 }
74 inline void HeapRegion::note_start_of_copying(bool during_initial_mark) {
75 if (is_survivor()) {
76 // This is how we always allocate survivors.
77 assert(_next_top_at_mark_start == bottom(), "invariant");
78 } else {
79 if (during_initial_mark) {
80 // During initial-mark we'll explicitly mark any objects on old
81 // regions that are pointed to by roots. Given that explicit
82 // marks only make sense under NTAMS it'd be nice if we could
83 // check that condition if we wanted to. Given that we don't
84 // know where the top of this region will end up, we simply set
85 // NTAMS to the end of the region so all marks will be below
86 // NTAMS. We'll set it to the actual top when we retire this region.
87 _next_top_at_mark_start = end();
88 } else {
89 // We could have re-used this old region as to-space over a
90 // couple of GCs since the start of the concurrent marking
91 // cycle. This means that [bottom,NTAMS) will contain objects
92 // copied up to and including initial-mark and [NTAMS, top)
93 // will contain objects copied during the concurrent marking cycle.
94 assert(top() >= _next_top_at_mark_start, "invariant");
95 }
96 }
97 }
99 inline void HeapRegion::note_end_of_copying(bool during_initial_mark) {
100 if (is_survivor()) {
101 // This is how we always allocate survivors.
102 assert(_next_top_at_mark_start == bottom(), "invariant");
103 } else {
104 if (during_initial_mark) {
105 // See the comment for note_start_of_copying() for the details
106 // on this.
107 assert(_next_top_at_mark_start == end(), "pre-condition");
108 _next_top_at_mark_start = top();
109 } else {
110 // See the comment for note_start_of_copying() for the details
111 // on this.
112 assert(top() >= _next_top_at_mark_start, "invariant");
113 }
114 }
115 }
117 #endif // SHARE_VM_GC_IMPLEMENTATION_G1_HEAPREGION_INLINE_HPP