Mon, 12 Mar 2012 14:59:00 -0700
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
Summary: Attempting to initiate a marking cycle when allocating a humongous object can, if a marking cycle is successfully initiated by another thread, result in the allocating thread spinning until the marking cycle is complete. Eliminate a deadlock between the main ConcurrentMarkThread, the SurrogateLocker thread, the VM thread, and a mutator thread waiting on the SecondaryFreeList_lock (while free regions are going to become available) by not manipulating the pending list lock during the prologue and epilogue of the cleanup pause.
Reviewed-by: brutisso, jcoomes, tonyp
1 /*
2 * Copyright (c) 2001, 2011, Oracle and/or its affiliates. All rights reserved.
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4 *
5 * This code is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 only, as
7 * published by the Free Software Foundation.
8 *
9 * This code is distributed in the hope that it will be useful, but WITHOUT
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
12 * version 2 for more details (a copy is included in the LICENSE file that
13 * accompanied this code).
14 *
15 * You should have received a copy of the GNU General Public License version
16 * 2 along with this work; if not, write to the Free Software Foundation,
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
18 *
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
20 * or visit www.oracle.com if you need additional information or have any
21 * questions.
22 *
23 */
25 #ifndef SHARE_VM_GC_IMPLEMENTATION_G1_G1SATBCARDTABLEMODREFBS_HPP
26 #define SHARE_VM_GC_IMPLEMENTATION_G1_G1SATBCARDTABLEMODREFBS_HPP
28 #include "memory/cardTableModRefBS.hpp"
29 #include "memory/memRegion.hpp"
30 #include "oops/oop.inline.hpp"
32 #ifndef SERIALGC
34 class DirtyCardQueueSet;
36 // This barrier is specialized to use a logging barrier to support
37 // snapshot-at-the-beginning marking.
39 class G1SATBCardTableModRefBS: public CardTableModRefBSForCTRS {
40 public:
41 // Add "pre_val" to a set of objects that may have been disconnected from the
42 // pre-marking object graph.
43 static void enqueue(oop pre_val);
45 G1SATBCardTableModRefBS(MemRegion whole_heap,
46 int max_covered_regions);
48 bool is_a(BarrierSet::Name bsn) {
49 return bsn == BarrierSet::G1SATBCT || CardTableModRefBS::is_a(bsn);
50 }
52 virtual bool has_write_ref_pre_barrier() { return true; }
54 // This notes that we don't need to access any BarrierSet data
55 // structures, so this can be called from a static context.
56 template <class T> static void write_ref_field_pre_static(T* field, oop newVal) {
57 T heap_oop = oopDesc::load_heap_oop(field);
58 if (!oopDesc::is_null(heap_oop)) {
59 enqueue(oopDesc::decode_heap_oop(heap_oop));
60 }
61 }
63 // We export this to make it available in cases where the static
64 // type of the barrier set is known. Note that it is non-virtual.
65 template <class T> inline void inline_write_ref_field_pre(T* field, oop newVal) {
66 write_ref_field_pre_static(field, newVal);
67 }
69 // These are the more general virtual versions.
70 virtual void write_ref_field_pre_work(oop* field, oop new_val) {
71 inline_write_ref_field_pre(field, new_val);
72 }
73 virtual void write_ref_field_pre_work(narrowOop* field, oop new_val) {
74 inline_write_ref_field_pre(field, new_val);
75 }
76 virtual void write_ref_field_pre_work(void* field, oop new_val) {
77 guarantee(false, "Not needed");
78 }
80 template <class T> void write_ref_array_pre_work(T* dst, int count);
81 virtual void write_ref_array_pre(oop* dst, int count, bool dest_uninitialized) {
82 if (!dest_uninitialized) {
83 write_ref_array_pre_work(dst, count);
84 }
85 }
86 virtual void write_ref_array_pre(narrowOop* dst, int count, bool dest_uninitialized) {
87 if (!dest_uninitialized) {
88 write_ref_array_pre_work(dst, count);
89 }
90 }
91 };
93 // Adds card-table logging to the post-barrier.
94 // Usual invariant: all dirty cards are logged in the DirtyCardQueueSet.
95 class G1SATBCardTableLoggingModRefBS: public G1SATBCardTableModRefBS {
96 private:
97 DirtyCardQueueSet& _dcqs;
98 public:
99 G1SATBCardTableLoggingModRefBS(MemRegion whole_heap,
100 int max_covered_regions);
102 bool is_a(BarrierSet::Name bsn) {
103 return bsn == BarrierSet::G1SATBCTLogging ||
104 G1SATBCardTableModRefBS::is_a(bsn);
105 }
107 void write_ref_field_work(void* field, oop new_val);
109 // Can be called from static contexts.
110 static void write_ref_field_static(void* field, oop new_val);
112 // NB: if you do a whole-heap invalidation, the "usual invariant" defined
113 // above no longer applies.
114 void invalidate(MemRegion mr, bool whole_heap = false);
116 void write_region_work(MemRegion mr) { invalidate(mr); }
117 void write_ref_array_work(MemRegion mr) { invalidate(mr); }
120 };
123 #endif // SERIALGC
125 #endif // SHARE_VM_GC_IMPLEMENTATION_G1_G1SATBCARDTABLEMODREFBS_HPP