Mon, 12 Mar 2012 14:59:00 -0700
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
Summary: Attempting to initiate a marking cycle when allocating a humongous object can, if a marking cycle is successfully initiated by another thread, result in the allocating thread spinning until the marking cycle is complete. Eliminate a deadlock between the main ConcurrentMarkThread, the SurrogateLocker thread, the VM thread, and a mutator thread waiting on the SecondaryFreeList_lock (while free regions are going to become available) by not manipulating the pending list lock during the prologue and epilogue of the cleanup pause.
Reviewed-by: brutisso, jcoomes, tonyp
1 /*
2 * Copyright (c) 2001, 2011, Oracle and/or its affiliates. All rights reserved.
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4 *
5 * This code is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 only, as
7 * published by the Free Software Foundation.
8 *
9 * This code is distributed in the hope that it will be useful, but WITHOUT
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
12 * version 2 for more details (a copy is included in the LICENSE file that
13 * accompanied this code).
14 *
15 * You should have received a copy of the GNU General Public License version
16 * 2 along with this work; if not, write to the Free Software Foundation,
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
18 *
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
20 * or visit www.oracle.com if you need additional information or have any
21 * questions.
22 *
23 */
25 #include "precompiled.hpp"
26 #include "gc_implementation/g1/g1SATBCardTableModRefBS.hpp"
27 #include "gc_implementation/g1/heapRegion.hpp"
28 #include "gc_implementation/g1/satbQueue.hpp"
29 #include "runtime/mutexLocker.hpp"
30 #include "runtime/thread.hpp"
31 #ifdef TARGET_OS_FAMILY_linux
32 # include "thread_linux.inline.hpp"
33 #endif
34 #ifdef TARGET_OS_FAMILY_solaris
35 # include "thread_solaris.inline.hpp"
36 #endif
37 #ifdef TARGET_OS_FAMILY_windows
38 # include "thread_windows.inline.hpp"
39 #endif
40 #ifdef TARGET_OS_FAMILY_bsd
41 # include "thread_bsd.inline.hpp"
42 #endif
44 G1SATBCardTableModRefBS::G1SATBCardTableModRefBS(MemRegion whole_heap,
45 int max_covered_regions) :
46 CardTableModRefBSForCTRS(whole_heap, max_covered_regions)
47 {
48 _kind = G1SATBCT;
49 }
52 void G1SATBCardTableModRefBS::enqueue(oop pre_val) {
53 // Nulls should have been already filtered.
54 assert(pre_val->is_oop(true), "Error");
56 if (!JavaThread::satb_mark_queue_set().is_active()) return;
57 Thread* thr = Thread::current();
58 if (thr->is_Java_thread()) {
59 JavaThread* jt = (JavaThread*)thr;
60 jt->satb_mark_queue().enqueue(pre_val);
61 } else {
62 MutexLocker x(Shared_SATB_Q_lock);
63 JavaThread::satb_mark_queue_set().shared_satb_queue()->enqueue(pre_val);
64 }
65 }
67 template <class T> void
68 G1SATBCardTableModRefBS::write_ref_array_pre_work(T* dst, int count) {
69 if (!JavaThread::satb_mark_queue_set().is_active()) return;
70 T* elem_ptr = dst;
71 for (int i = 0; i < count; i++, elem_ptr++) {
72 T heap_oop = oopDesc::load_heap_oop(elem_ptr);
73 if (!oopDesc::is_null(heap_oop)) {
74 enqueue(oopDesc::decode_heap_oop_not_null(heap_oop));
75 }
76 }
77 }
79 G1SATBCardTableLoggingModRefBS::
80 G1SATBCardTableLoggingModRefBS(MemRegion whole_heap,
81 int max_covered_regions) :
82 G1SATBCardTableModRefBS(whole_heap, max_covered_regions),
83 _dcqs(JavaThread::dirty_card_queue_set())
84 {
85 _kind = G1SATBCTLogging;
86 }
88 void
89 G1SATBCardTableLoggingModRefBS::write_ref_field_work(void* field,
90 oop new_val) {
91 jbyte* byte = byte_for(field);
92 if (*byte != dirty_card) {
93 *byte = dirty_card;
94 Thread* thr = Thread::current();
95 if (thr->is_Java_thread()) {
96 JavaThread* jt = (JavaThread*)thr;
97 jt->dirty_card_queue().enqueue(byte);
98 } else {
99 MutexLockerEx x(Shared_DirtyCardQ_lock,
100 Mutex::_no_safepoint_check_flag);
101 _dcqs.shared_dirty_card_queue()->enqueue(byte);
102 }
103 }
104 }
106 void
107 G1SATBCardTableLoggingModRefBS::write_ref_field_static(void* field,
108 oop new_val) {
109 uintptr_t field_uint = (uintptr_t)field;
110 uintptr_t new_val_uint = (uintptr_t)new_val;
111 uintptr_t comb = field_uint ^ new_val_uint;
112 comb = comb >> HeapRegion::LogOfHRGrainBytes;
113 if (comb == 0) return;
114 if (new_val == NULL) return;
115 // Otherwise, log it.
116 G1SATBCardTableLoggingModRefBS* g1_bs =
117 (G1SATBCardTableLoggingModRefBS*)Universe::heap()->barrier_set();
118 g1_bs->write_ref_field_work(field, new_val);
119 }
121 void
122 G1SATBCardTableLoggingModRefBS::invalidate(MemRegion mr, bool whole_heap) {
123 jbyte* byte = byte_for(mr.start());
124 jbyte* last_byte = byte_for(mr.last());
125 Thread* thr = Thread::current();
126 if (whole_heap) {
127 while (byte <= last_byte) {
128 *byte = dirty_card;
129 byte++;
130 }
131 } else {
132 // Enqueue if necessary.
133 if (thr->is_Java_thread()) {
134 JavaThread* jt = (JavaThread*)thr;
135 while (byte <= last_byte) {
136 if (*byte != dirty_card) {
137 *byte = dirty_card;
138 jt->dirty_card_queue().enqueue(byte);
139 }
140 byte++;
141 }
142 } else {
143 MutexLockerEx x(Shared_DirtyCardQ_lock,
144 Mutex::_no_safepoint_check_flag);
145 while (byte <= last_byte) {
146 if (*byte != dirty_card) {
147 *byte = dirty_card;
148 _dcqs.shared_dirty_card_queue()->enqueue(byte);
149 }
150 byte++;
151 }
152 }
153 }
154 }