jdk8-mips64-public/hotspot: src/share/vm/memory/permGen.cpp@60fb9c4db4e6

6718086: CMS assert: _concurrent_iteration_safe_limit update missed
Summary: Initialize the field correctly in ContiguousSpace's constructor and initialize() methods, using the latter for the survivor spaces upon initial construction or a subsequent resizing of the young generation. Add some missing Space sub-class constructors.
Reviewed-by: apetrusenko

     1 /*

     2  * Copyright 2000-2006 Sun Microsystems, Inc.  All Rights Reserved.

     3  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.

     4  *

     5  * This code is free software; you can redistribute it and/or modify it

     6  * under the terms of the GNU General Public License version 2 only, as

     7  * published by the Free Software Foundation.

     8  *

     9  * This code is distributed in the hope that it will be useful, but WITHOUT

    10  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or

    11  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License

    12  * version 2 for more details (a copy is included in the LICENSE file that

    13  * accompanied this code).

    14  *

    15  * You should have received a copy of the GNU General Public License version

    16  * 2 along with this work; if not, write to the Free Software Foundation,

    17  * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.

    18  *

    19  * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,

    20  * CA 95054 USA or visit www.sun.com if you need additional information or

    21  * have any questions.

    22  *

    23  */

    25 #include "incls/_precompiled.incl"

    26 #include "incls/_permGen.cpp.incl"

    28 HeapWord* PermGen::mem_allocate_in_gen(size_t size, Generation* gen) {

    29   MutexLocker ml(Heap_lock);

    30   GCCause::Cause next_cause = GCCause::_permanent_generation_full;

    31   GCCause::Cause prev_cause = GCCause::_no_gc;

    33   for (;;) {

    34     HeapWord* obj = gen->allocate(size, false);

    35     if (obj != NULL) {

    36       return obj;

    37     }

    38     if (gen->capacity() < _capacity_expansion_limit ||

    39         prev_cause != GCCause::_no_gc) {

    40       obj = gen->expand_and_allocate(size, false);

    41     }

    42     if (obj == NULL && prev_cause != GCCause::_last_ditch_collection) {

    43       if (GC_locker::is_active_and_needs_gc()) {

    44         // If this thread is not in a jni critical section, we stall

    45         // the requestor until the critical section has cleared and

    46         // GC allowed. When the critical section clears, a GC is

    47         // initiated by the last thread exiting the critical section; so

    48         // we retry the allocation sequence from the beginning of the loop,

    49         // rather than causing more, now probably unnecessary, GC attempts.

    50         JavaThread* jthr = JavaThread::current();

    51         if (!jthr->in_critical()) {

    52           MutexUnlocker mul(Heap_lock);

    53           // Wait for JNI critical section to be exited

    54           GC_locker::stall_until_clear();

    55           continue;

    56         } else {

    57           if (CheckJNICalls) {

    58             fatal("Possible deadlock due to allocating while"

    59                   " in jni critical section");

    60           }

    61           return NULL;

    62         }

    63       }

    65       // Read the GC count while holding the Heap_lock

    66       unsigned int gc_count_before      = SharedHeap::heap()->total_collections();

    67       unsigned int full_gc_count_before = SharedHeap::heap()->total_full_collections();

    68       {

    69         MutexUnlocker mu(Heap_lock);  // give up heap lock, execute gets it back

    70         VM_GenCollectForPermanentAllocation op(size, gc_count_before, full_gc_count_before,

    71                                                next_cause);

    72         VMThread::execute(&op);

    73         if (!op.prologue_succeeded() || op.gc_locked()) {

    74           assert(op.result() == NULL, "must be NULL if gc_locked() is true");

    75           continue;  // retry and/or stall as necessary

    76         }

    77         obj = op.result();

    78         assert(obj == NULL || SharedHeap::heap()->is_in_reserved(obj),

    79                "result not in heap");

    80         if (obj != NULL) {

    81           return obj;

    82         }

    83       }

    84       prev_cause = next_cause;

    85       next_cause = GCCause::_last_ditch_collection;

    86     } else {

    87       return obj;

    88     }

    89   }

    90 }

    92 CompactingPermGen::CompactingPermGen(ReservedSpace rs,

    93                                      ReservedSpace shared_rs,

    94                                      size_t initial_byte_size,

    95                                      GenRemSet* remset,

    96                                      PermanentGenerationSpec* perm_spec)

    97 {

    98   CompactingPermGenGen* g =

    99     new CompactingPermGenGen(rs, shared_rs, initial_byte_size, -1, remset,

   100                              NULL, perm_spec);

   101   if (g == NULL)

   102     vm_exit_during_initialization("Could not allocate a CompactingPermGen");

   103   _gen = g;

   105   g->initialize_performance_counters();

   107   _capacity_expansion_limit = g->capacity() + MaxPermHeapExpansion;

   108 }

   110 HeapWord* CompactingPermGen::mem_allocate(size_t size) {

   111   return mem_allocate_in_gen(size, _gen);

   112 }

   114 void CompactingPermGen::compute_new_size() {

   115   size_t desired_capacity = align_size_up(_gen->used(), MinPermHeapExpansion);

   116   if (desired_capacity < PermSize) {

   117     desired_capacity = PermSize;

   118   }

   119   if (_gen->capacity() > desired_capacity) {

   120     _gen->shrink(_gen->capacity() - desired_capacity);

   121   }

   122   _capacity_expansion_limit = _gen->capacity() + MaxPermHeapExpansion;

   123 }

Mercurial > jdk8-mips64-public > hotspot / file revision

src/share/vm/memory/permGen.cpp@60fb9c4db4e6

src/share/vm/memory/permGen.cpp