src/share/vm/interpreter/rewriter.cpp

Fri, 30 Oct 2009 16:22:59 -0700

author
jrose
date
Fri, 30 Oct 2009 16:22:59 -0700
changeset 1494
389049f3f393
parent 1291
75596850f863
child 1573
dd57230ba8fe
permissions
-rw-r--r--

6858164: invokedynamic code needs some cleanup (post-6655638)
Summary: Fix several crashers, remove needless paths for boxed-style bootstrap method call, refactor & simplify APIs for rewriter constantPoolOop, remove sun.dyn.CallSiteImpl
Reviewed-by: kvn

     1 /*
     2  * Copyright 1998-2009 Sun Microsystems, Inc.  All Rights Reserved.
     3  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
     4  *
     5  * This code is free software; you can redistribute it and/or modify it
     6  * under the terms of the GNU General Public License version 2 only, as
     7  * published by the Free Software Foundation.
     8  *
     9  * This code is distributed in the hope that it will be useful, but WITHOUT
    10  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
    11  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
    12  * version 2 for more details (a copy is included in the LICENSE file that
    13  * accompanied this code).
    14  *
    15  * You should have received a copy of the GNU General Public License version
    16  * 2 along with this work; if not, write to the Free Software Foundation,
    17  * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
    18  *
    19  * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
    20  * CA 95054 USA or visit www.sun.com if you need additional information or
    21  * have any questions.
    22  *
    23  */
    25 # include "incls/_precompiled.incl"
    26 # include "incls/_rewriter.cpp.incl"
    28 // Computes a CPC map (new_index -> original_index) for constant pool entries
    29 // that are referred to by the interpreter at runtime via the constant pool cache.
    30 // Also computes a CP map (original_index -> new_index).
    31 // Marks entries in CP which require additional processing.
    32 void Rewriter::compute_index_maps() {
    33   const int length  = _pool->length();
    34   init_cp_map(length);
    35   for (int i = 0; i < length; i++) {
    36     int tag = _pool->tag_at(i).value();
    37     switch (tag) {
    38       case JVM_CONSTANT_InterfaceMethodref:
    39       case JVM_CONSTANT_Fieldref          : // fall through
    40       case JVM_CONSTANT_Methodref         : // fall through
    41         add_cp_cache_entry(i);
    42         break;
    43     }
    44   }
    46   guarantee((int)_cp_cache_map.length()-1 <= (int)((u2)-1),
    47             "all cp cache indexes fit in a u2");
    48 }
    51 // Creates a constant pool cache given a CPC map
    52 // This creates the constant pool cache initially in a state
    53 // that is unsafe for concurrent GC processing but sets it to
    54 // a safe mode before the constant pool cache is returned.
    55 void Rewriter::make_constant_pool_cache(TRAPS) {
    56   const int length = _cp_cache_map.length();
    57   constantPoolCacheOop cache =
    58       oopFactory::new_constantPoolCache(length, methodOopDesc::IsUnsafeConc, CHECK);
    59   cache->initialize(_cp_cache_map);
    60   _pool->set_cache(cache);
    61   cache->set_constant_pool(_pool());
    62 }
    66 // The new finalization semantics says that registration of
    67 // finalizable objects must be performed on successful return from the
    68 // Object.<init> constructor.  We could implement this trivially if
    69 // <init> were never rewritten but since JVMTI allows this to occur, a
    70 // more complicated solution is required.  A special return bytecode
    71 // is used only by Object.<init> to signal the finalization
    72 // registration point.  Additionally local 0 must be preserved so it's
    73 // available to pass to the registration function.  For simplicty we
    74 // require that local 0 is never overwritten so it's available as an
    75 // argument for registration.
    77 void Rewriter::rewrite_Object_init(methodHandle method, TRAPS) {
    78   RawBytecodeStream bcs(method);
    79   while (!bcs.is_last_bytecode()) {
    80     Bytecodes::Code opcode = bcs.raw_next();
    81     switch (opcode) {
    82       case Bytecodes::_return: *bcs.bcp() = Bytecodes::_return_register_finalizer; break;
    84       case Bytecodes::_istore:
    85       case Bytecodes::_lstore:
    86       case Bytecodes::_fstore:
    87       case Bytecodes::_dstore:
    88       case Bytecodes::_astore:
    89         if (bcs.get_index() != 0) continue;
    91         // fall through
    92       case Bytecodes::_istore_0:
    93       case Bytecodes::_lstore_0:
    94       case Bytecodes::_fstore_0:
    95       case Bytecodes::_dstore_0:
    96       case Bytecodes::_astore_0:
    97         THROW_MSG(vmSymbols::java_lang_IncompatibleClassChangeError(),
    98                   "can't overwrite local 0 in Object.<init>");
    99         break;
   100     }
   101   }
   102 }
   105 // Rewrite a classfile-order CP index into a native-order CPC index.
   106 int Rewriter::rewrite_member_reference(address bcp, int offset) {
   107   address p = bcp + offset;
   108   int  cp_index    = Bytes::get_Java_u2(p);
   109   int  cache_index = cp_entry_to_cp_cache(cp_index);
   110   Bytes::put_native_u2(p, cache_index);
   111   return cp_index;
   112 }
   115 void Rewriter::rewrite_invokedynamic(address bcp, int offset, int delete_me) {
   116   address p = bcp + offset;
   117   assert(p[-1] == Bytecodes::_invokedynamic, "");
   118   int cp_index = Bytes::get_Java_u2(p);
   119   int cpc  = maybe_add_cp_cache_entry(cp_index);  // add lazily
   120   int cpc2 = add_secondary_cp_cache_entry(cpc);
   122   // Replace the trailing four bytes with a CPC index for the dynamic
   123   // call site.  Unlike other CPC entries, there is one per bytecode,
   124   // not just one per distinct CP entry.  In other words, the
   125   // CPC-to-CP relation is many-to-one for invokedynamic entries.
   126   // This means we must use a larger index size than u2 to address
   127   // all these entries.  That is the main reason invokedynamic
   128   // must have a five-byte instruction format.  (Of course, other JVM
   129   // implementations can use the bytes for other purposes.)
   130   Bytes::put_native_u4(p, constantPoolCacheOopDesc::encode_secondary_index(cpc2));
   131   // Note: We use native_u4 format exclusively for 4-byte indexes.
   132 }
   135 // Rewrites a method given the index_map information
   136 void Rewriter::scan_method(methodOop method) {
   138   int nof_jsrs = 0;
   139   bool has_monitor_bytecodes = false;
   141   {
   142     // We cannot tolerate a GC in this block, because we've
   143     // cached the bytecodes in 'code_base'. If the methodOop
   144     // moves, the bytecodes will also move.
   145     No_Safepoint_Verifier nsv;
   146     Bytecodes::Code c;
   148     // Bytecodes and their length
   149     const address code_base = method->code_base();
   150     const int code_length = method->code_size();
   152     int bc_length;
   153     for (int bci = 0; bci < code_length; bci += bc_length) {
   154       address bcp = code_base + bci;
   155       int prefix_length = 0;
   156       c = (Bytecodes::Code)(*bcp);
   158       // Since we have the code, see if we can get the length
   159       // directly. Some more complicated bytecodes will report
   160       // a length of zero, meaning we need to make another method
   161       // call to calculate the length.
   162       bc_length = Bytecodes::length_for(c);
   163       if (bc_length == 0) {
   164         bc_length = Bytecodes::length_at(bcp);
   166         // length_at will put us at the bytecode after the one modified
   167         // by 'wide'. We don't currently examine any of the bytecodes
   168         // modified by wide, but in case we do in the future...
   169         if (c == Bytecodes::_wide) {
   170           prefix_length = 1;
   171           c = (Bytecodes::Code)bcp[1];
   172         }
   173       }
   175       assert(bc_length != 0, "impossible bytecode length");
   177       switch (c) {
   178         case Bytecodes::_lookupswitch   : {
   179 #ifndef CC_INTERP
   180           Bytecode_lookupswitch* bc = Bytecode_lookupswitch_at(bcp);
   181           bc->set_code(
   182             bc->number_of_pairs() < BinarySwitchThreshold
   183             ? Bytecodes::_fast_linearswitch
   184             : Bytecodes::_fast_binaryswitch
   185           );
   186 #endif
   187           break;
   188         }
   189         case Bytecodes::_getstatic      : // fall through
   190         case Bytecodes::_putstatic      : // fall through
   191         case Bytecodes::_getfield       : // fall through
   192         case Bytecodes::_putfield       : // fall through
   193         case Bytecodes::_invokevirtual  : // fall through
   194         case Bytecodes::_invokespecial  : // fall through
   195         case Bytecodes::_invokestatic   :
   196         case Bytecodes::_invokeinterface:
   197           rewrite_member_reference(bcp, prefix_length+1);
   198           break;
   199         case Bytecodes::_invokedynamic:
   200           rewrite_invokedynamic(bcp, prefix_length+1, int(sizeof"@@@@DELETE ME"));
   201           break;
   202         case Bytecodes::_jsr            : // fall through
   203         case Bytecodes::_jsr_w          : nof_jsrs++;                   break;
   204         case Bytecodes::_monitorenter   : // fall through
   205         case Bytecodes::_monitorexit    : has_monitor_bytecodes = true; break;
   206       }
   207     }
   208   }
   210   // Update access flags
   211   if (has_monitor_bytecodes) {
   212     method->set_has_monitor_bytecodes();
   213   }
   215   // The present of a jsr bytecode implies that the method might potentially
   216   // have to be rewritten, so we run the oopMapGenerator on the method
   217   if (nof_jsrs > 0) {
   218     method->set_has_jsrs();
   219     // Second pass will revisit this method.
   220     assert(method->has_jsrs(), "");
   221   }
   222 }
   224 // After constant pool is created, revisit methods containing jsrs.
   225 methodHandle Rewriter::rewrite_jsrs(methodHandle method, TRAPS) {
   226   ResolveOopMapConflicts romc(method);
   227   methodHandle original_method = method;
   228   method = romc.do_potential_rewrite(CHECK_(methodHandle()));
   229   if (method() != original_method()) {
   230     // Insert invalid bytecode into original methodOop and set
   231     // interpreter entrypoint, so that a executing this method
   232     // will manifest itself in an easy recognizable form.
   233     address bcp = original_method->bcp_from(0);
   234     *bcp = (u1)Bytecodes::_shouldnotreachhere;
   235     int kind = Interpreter::method_kind(original_method);
   236     original_method->set_interpreter_kind(kind);
   237   }
   239   // Update monitor matching info.
   240   if (romc.monitor_safe()) {
   241     method->set_guaranteed_monitor_matching();
   242   }
   244   return method;
   245 }
   248 void Rewriter::rewrite(instanceKlassHandle klass, TRAPS) {
   249   ResourceMark rm(THREAD);
   250   Rewriter     rw(klass, CHECK);
   251   // (That's all, folks.)
   252 }
   254 Rewriter::Rewriter(instanceKlassHandle klass, TRAPS)
   255   : _klass(klass),
   256     // gather starting points
   257     _pool(   THREAD, klass->constants()),
   258     _methods(THREAD, klass->methods())
   259 {
   260   assert(_pool->cache() == NULL, "constant pool cache must not be set yet");
   262   // determine index maps for methodOop rewriting
   263   compute_index_maps();
   265   if (RegisterFinalizersAtInit && _klass->name() == vmSymbols::java_lang_Object()) {
   266     bool did_rewrite = false;
   267     int i = _methods->length();
   268     while (i-- > 0) {
   269       methodOop method = (methodOop)_methods->obj_at(i);
   270       if (method->intrinsic_id() == vmIntrinsics::_Object_init) {
   271         // rewrite the return bytecodes of Object.<init> to register the
   272         // object for finalization if needed.
   273         methodHandle m(THREAD, method);
   274         rewrite_Object_init(m, CHECK);
   275         did_rewrite = true;
   276         break;
   277       }
   278     }
   279     assert(did_rewrite, "must find Object::<init> to rewrite it");
   280   }
   282   // rewrite methods, in two passes
   283   int i, len = _methods->length();
   285   for (i = len; --i >= 0; ) {
   286     methodOop method = (methodOop)_methods->obj_at(i);
   287     scan_method(method);
   288   }
   290   // allocate constant pool cache, now that we've seen all the bytecodes
   291   make_constant_pool_cache(CHECK);
   293   for (i = len; --i >= 0; ) {
   294     methodHandle m(THREAD, (methodOop)_methods->obj_at(i));
   296     if (m->has_jsrs()) {
   297       m = rewrite_jsrs(m, CHECK);
   298       // Method might have gotten rewritten.
   299       _methods->obj_at_put(i, m());
   300     }
   302     // Set up method entry points for compiler and interpreter.
   303     m->link_method(m, CHECK);
   304   }
   305 }

mercurial