jdk8-mips64-public/hotspot: src/share/vm/memory/universe.inline.hpp@2c022e432e10

8024974: Incorrect use of GC_locker::is_active()
Summary: SymbolTable and StringTable can make calls to GC_locker::is_active() outside a safepoint. This isn't safe because the GC_locker active state (lock count) is only updated at a safepoint and only remains valid as long as _needs_gc is true. However, outside a safepoint_needs_gc can change to false at any time, which makes it impossible to do a correct call to is_active() in that context. In this case these calls can just be removed since the input argument to basic_add() should never be on the heap and so there's no need to check the GC_locker state. This change also adjusts the assert() in is_active() to makes sure all calls to this function are always done under a safepoint.
Reviewed-by: brutisso, dcubed
Contributed-by: per.liden@oracle.com

     1 /*

     2  * Copyright (c) 1997, 2010, Oracle and/or its affiliates. All rights reserved.

     3  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.

     4  *

     5  * This code is free software; you can redistribute it and/or modify it

     6  * under the terms of the GNU General Public License version 2 only, as

     7  * published by the Free Software Foundation.

     8  *

     9  * This code is distributed in the hope that it will be useful, but WITHOUT

    10  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or

    11  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License

    12  * version 2 for more details (a copy is included in the LICENSE file that

    13  * accompanied this code).

    14  *

    15  * You should have received a copy of the GNU General Public License version

    16  * 2 along with this work; if not, write to the Free Software Foundation,

    17  * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.

    18  *

    19  * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA

    20  * or visit www.oracle.com if you need additional information or have any

    21  * questions.

    22  *

    23  */

    25 #ifndef SHARE_VM_MEMORY_UNIVERSE_INLINE_HPP

    26 #define SHARE_VM_MEMORY_UNIVERSE_INLINE_HPP

    28 #include "memory/universe.hpp"

    30 // Check whether an element of a typeArrayOop with the given type must be

    31 // aligned 0 mod 8.  The typeArrayOop itself must be aligned at least this

    32 // strongly.

    34 inline bool Universe::element_type_should_be_aligned(BasicType type) {

    35   return type == T_DOUBLE || type == T_LONG;

    36 }

    38 // Check whether an object field (static/non-static) of the given type must be aligned 0 mod 8.

    40 inline bool Universe::field_type_should_be_aligned(BasicType type) {

    41   return type == T_DOUBLE || type == T_LONG;

    42 }

    44 #endif // SHARE_VM_MEMORY_UNIVERSE_INLINE_HPP

Mercurial > jdk8-mips64-public > hotspot / file revision

src/share/vm/memory/universe.inline.hpp@2c022e432e10

src/share/vm/memory/universe.inline.hpp