Mercurial > jdk8-mips64-public > hotspot / file revision
make/linux/adlc_updater@2c022e432e10
make/linux/adlc_updater
Fri, 20 Sep 2013 10:53:28 +0200
- author
- stefank
- date
- Fri, 20 Sep 2013 10:53:28 +0200
- changeset 5769
- 2c022e432e10
- parent 2186
- a50abfc67f31
- child 6876
- 710a3c8b516e
- permissions
- -rw-r--r--
8024974: Incorrect use of GC_locker::is_active()
Summary: SymbolTable and StringTable can make calls to GC_locker::is_active() outside a safepoint. This isn't safe because the GC_locker active state (lock count) is only updated at a safepoint and only remains valid as long as _needs_gc is true. However, outside a safepoint_needs_gc can change to false at any time, which makes it impossible to do a correct call to is_active() in that context. In this case these calls can just be removed since the input argument to basic_add() should never be on the heap and so there's no need to check the GC_locker state. This change also adjusts the assert() in is_active() to makes sure all calls to this function are always done under a safepoint.
Reviewed-by: brutisso, dcubed
Contributed-by: per.liden@oracle.com
1 #! /bin/sh
2 #
3 # This file is used by adlc.make to selectively update generated
4 # adlc files. Because source and target diretories are relative
5 # paths, this file is copied to the target build directory before
6 # use.
7 #
8 # adlc-updater <file> <source-dir> <target-dir>
9 #
10 fix_lines() {
11 # repair bare #line directives in $1 to refer to $2
12 awk < $1 > $1+ '
13 /^#line 999999$/ {print "#line " (NR+1) " \"" F2 "\""; next}
14 {print}
15 ' F2=$2
16 mv $1+ $1
17 }
18 fix_lines $2/$1 $3/$1
19 [ -f $3/$1 ] && cmp -s $2/$1 $3/$1 || \
20 ( [ -f $3/$1 ] && echo Updating $3/$1 ; touch $2/made-change ; mv $2/$1 $3/$1 )
