Mercurial > jdk8-mips64-public > hotspot / file revision
make/linux/README@2c022e432e10
make/linux/README
Fri, 20 Sep 2013 10:53:28 +0200
- author
- stefank
- date
- Fri, 20 Sep 2013 10:53:28 +0200
- changeset 5769
- 2c022e432e10
- parent 3058
- 3be7439273c5
- child 6876
- 710a3c8b516e
- permissions
- -rw-r--r--
8024974: Incorrect use of GC_locker::is_active()
Summary: SymbolTable and StringTable can make calls to GC_locker::is_active() outside a safepoint. This isn't safe because the GC_locker active state (lock count) is only updated at a safepoint and only remains valid as long as _needs_gc is true. However, outside a safepoint_needs_gc can change to false at any time, which makes it impossible to do a correct call to is_active() in that context. In this case these calls can just be removed since the input argument to basic_add() should never be on the heap and so there's no need to check the GC_locker state. This change also adjusts the assert() in is_active() to makes sure all calls to this function are always done under a safepoint.
Reviewed-by: brutisso, dcubed
Contributed-by: per.liden@oracle.com
1 Copyright (c) 2007, Oracle and/or its affiliates. All rights reserved.
2 DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4 This code is free software; you can redistribute it and/or modify it
5 under the terms of the GNU General Public License version 2 only, as
6 published by the Free Software Foundation.
8 This code is distributed in the hope that it will be useful, but WITHOUT
9 ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10 FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
11 version 2 for more details (a copy is included in the LICENSE file that
12 accompanied this code).
14 You should have received a copy of the GNU General Public License version
15 2 along with this work; if not, write to the Free Software Foundation,
16 Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
18 Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
19 or visit www.oracle.com if you need additional information or have any
20 questions.
22 ________________________________________________________________________
24 Please refer to the comments in the Makefile in this directory
25 for instructions how to build the Solaris versions.
