Mon, 29 Jun 2009 14:42:12 -0700
6850957: Honor -XX:OnOutOfMemoryError when array size exceeds VM limit
Summary: call report_java_out_of_memory("Requested array size exceeds VM limit")
Reviewed-by: tbell, dholmes, alanb, ysr
Contributed-by: jeremymanson@google.com
1 /*
2 * Copyright 1997-2009 Sun Microsystems, Inc. All Rights Reserved.
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4 *
5 * This code is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 only, as
7 * published by the Free Software Foundation.
8 *
9 * This code is distributed in the hope that it will be useful, but WITHOUT
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
12 * version 2 for more details (a copy is included in the LICENSE file that
13 * accompanied this code).
14 *
15 * You should have received a copy of the GNU General Public License version
16 * 2 along with this work; if not, write to the Free Software Foundation,
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
18 *
19 * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
20 * CA 95054 USA or visit www.sun.com if you need additional information or
21 * have any questions.
22 *
23 */
25 # include "incls/_precompiled.incl"
26 # include "incls/_objArrayKlass.cpp.incl"
28 int objArrayKlass::oop_size(oop obj) const {
29 assert(obj->is_objArray(), "must be object array");
30 return objArrayOop(obj)->object_size();
31 }
33 objArrayOop objArrayKlass::allocate(int length, TRAPS) {
34 if (length >= 0) {
35 if (length <= arrayOopDesc::max_array_length(T_OBJECT)) {
36 int size = objArrayOopDesc::object_size(length);
37 KlassHandle h_k(THREAD, as_klassOop());
38 objArrayOop a = (objArrayOop)CollectedHeap::array_allocate(h_k, size, length, CHECK_NULL);
39 assert(a->is_parsable(), "Can't publish unless parsable");
40 return a;
41 } else {
42 report_java_out_of_memory("Requested array size exceeds VM limit");
43 THROW_OOP_0(Universe::out_of_memory_error_array_size());
44 }
45 } else {
46 THROW_0(vmSymbols::java_lang_NegativeArraySizeException());
47 }
48 }
50 static int multi_alloc_counter = 0;
52 oop objArrayKlass::multi_allocate(int rank, jint* sizes, TRAPS) {
53 int length = *sizes;
54 // Call to lower_dimension uses this pointer, so most be called before a
55 // possible GC
56 KlassHandle h_lower_dimension(THREAD, lower_dimension());
57 // If length < 0 allocate will throw an exception.
58 objArrayOop array = allocate(length, CHECK_NULL);
59 assert(array->is_parsable(), "Don't handlize unless parsable");
60 objArrayHandle h_array (THREAD, array);
61 if (rank > 1) {
62 if (length != 0) {
63 for (int index = 0; index < length; index++) {
64 arrayKlass* ak = arrayKlass::cast(h_lower_dimension());
65 oop sub_array = ak->multi_allocate(rank-1, &sizes[1], CHECK_NULL);
66 assert(sub_array->is_parsable(), "Don't publish until parsable");
67 h_array->obj_at_put(index, sub_array);
68 }
69 } else {
70 // Since this array dimension has zero length, nothing will be
71 // allocated, however the lower dimension values must be checked
72 // for illegal values.
73 for (int i = 0; i < rank - 1; ++i) {
74 sizes += 1;
75 if (*sizes < 0) {
76 THROW_0(vmSymbols::java_lang_NegativeArraySizeException());
77 }
78 }
79 }
80 }
81 return h_array();
82 }
84 // Either oop or narrowOop depending on UseCompressedOops.
85 template <class T> void objArrayKlass::do_copy(arrayOop s, T* src,
86 arrayOop d, T* dst, int length, TRAPS) {
88 const size_t word_len = objArrayOopDesc::array_size(length);
90 BarrierSet* bs = Universe::heap()->barrier_set();
91 // For performance reasons, we assume we are that the write barrier we
92 // are using has optimized modes for arrays of references. At least one
93 // of the asserts below will fail if this is not the case.
94 assert(bs->has_write_ref_array_opt(), "Barrier set must have ref array opt");
95 assert(bs->has_write_ref_array_pre_opt(), "For pre-barrier as well.");
97 MemRegion dst_mr = MemRegion((HeapWord*)dst, word_len);
98 if (s == d) {
99 // since source and destination are equal we do not need conversion checks.
100 assert(length > 0, "sanity check");
101 bs->write_ref_array_pre(dst_mr);
102 Copy::conjoint_oops_atomic(src, dst, length);
103 } else {
104 // We have to make sure all elements conform to the destination array
105 klassOop bound = objArrayKlass::cast(d->klass())->element_klass();
106 klassOop stype = objArrayKlass::cast(s->klass())->element_klass();
107 if (stype == bound || Klass::cast(stype)->is_subtype_of(bound)) {
108 // elements are guaranteed to be subtypes, so no check necessary
109 bs->write_ref_array_pre(dst_mr);
110 Copy::conjoint_oops_atomic(src, dst, length);
111 } else {
112 // slow case: need individual subtype checks
113 // note: don't use obj_at_put below because it includes a redundant store check
114 T* from = src;
115 T* end = from + length;
116 for (T* p = dst; from < end; from++, p++) {
117 // XXX this is going to be slow.
118 T element = *from;
119 // even slower now
120 bool element_is_null = oopDesc::is_null(element);
121 oop new_val = element_is_null ? oop(NULL)
122 : oopDesc::decode_heap_oop_not_null(element);
123 if (element_is_null ||
124 Klass::cast((new_val->klass()))->is_subtype_of(bound)) {
125 bs->write_ref_field_pre(p, new_val);
126 *p = *from;
127 } else {
128 // We must do a barrier to cover the partial copy.
129 const size_t pd = pointer_delta(p, dst, (size_t)heapOopSize);
130 // pointer delta is scaled to number of elements (length field in
131 // objArrayOop) which we assume is 32 bit.
132 assert(pd == (size_t)(int)pd, "length field overflow");
133 const size_t done_word_len = objArrayOopDesc::array_size((int)pd);
134 bs->write_ref_array(MemRegion((HeapWord*)dst, done_word_len));
135 THROW(vmSymbols::java_lang_ArrayStoreException());
136 return;
137 }
138 }
139 }
140 }
141 bs->write_ref_array(MemRegion((HeapWord*)dst, word_len));
142 }
144 void objArrayKlass::copy_array(arrayOop s, int src_pos, arrayOop d,
145 int dst_pos, int length, TRAPS) {
146 assert(s->is_objArray(), "must be obj array");
148 if (!d->is_objArray()) {
149 THROW(vmSymbols::java_lang_ArrayStoreException());
150 }
152 // Check is all offsets and lengths are non negative
153 if (src_pos < 0 || dst_pos < 0 || length < 0) {
154 THROW(vmSymbols::java_lang_ArrayIndexOutOfBoundsException());
155 }
156 // Check if the ranges are valid
157 if ( (((unsigned int) length + (unsigned int) src_pos) > (unsigned int) s->length())
158 || (((unsigned int) length + (unsigned int) dst_pos) > (unsigned int) d->length()) ) {
159 THROW(vmSymbols::java_lang_ArrayIndexOutOfBoundsException());
160 }
162 // Special case. Boundary cases must be checked first
163 // This allows the following call: copy_array(s, s.length(), d.length(), 0).
164 // This is correct, since the position is supposed to be an 'in between point', i.e., s.length(),
165 // points to the right of the last element.
166 if (length==0) {
167 return;
168 }
169 if (UseCompressedOops) {
170 narrowOop* const src = objArrayOop(s)->obj_at_addr<narrowOop>(src_pos);
171 narrowOop* const dst = objArrayOop(d)->obj_at_addr<narrowOop>(dst_pos);
172 do_copy<narrowOop>(s, src, d, dst, length, CHECK);
173 } else {
174 oop* const src = objArrayOop(s)->obj_at_addr<oop>(src_pos);
175 oop* const dst = objArrayOop(d)->obj_at_addr<oop>(dst_pos);
176 do_copy<oop> (s, src, d, dst, length, CHECK);
177 }
178 }
181 klassOop objArrayKlass::array_klass_impl(bool or_null, int n, TRAPS) {
182 objArrayKlassHandle h_this(THREAD, as_klassOop());
183 return array_klass_impl(h_this, or_null, n, CHECK_NULL);
184 }
187 klassOop objArrayKlass::array_klass_impl(objArrayKlassHandle this_oop, bool or_null, int n, TRAPS) {
189 assert(this_oop->dimension() <= n, "check order of chain");
190 int dimension = this_oop->dimension();
191 if (dimension == n)
192 return this_oop();
194 objArrayKlassHandle ak (THREAD, this_oop->higher_dimension());
195 if (ak.is_null()) {
196 if (or_null) return NULL;
198 ResourceMark rm;
199 JavaThread *jt = (JavaThread *)THREAD;
200 {
201 MutexLocker mc(Compile_lock, THREAD); // for vtables
202 // Ensure atomic creation of higher dimensions
203 MutexLocker mu(MultiArray_lock, THREAD);
205 // Check if another thread beat us
206 ak = objArrayKlassHandle(THREAD, this_oop->higher_dimension());
207 if( ak.is_null() ) {
209 // Create multi-dim klass object and link them together
210 klassOop new_klass =
211 objArrayKlassKlass::cast(Universe::objArrayKlassKlassObj())->
212 allocate_objArray_klass(dimension + 1, this_oop, CHECK_NULL);
213 ak = objArrayKlassHandle(THREAD, new_klass);
214 this_oop->set_higher_dimension(ak());
215 ak->set_lower_dimension(this_oop());
216 assert(ak->oop_is_objArray(), "incorrect initialization of objArrayKlass");
217 }
218 }
219 } else {
220 CHECK_UNHANDLED_OOPS_ONLY(Thread::current()->clear_unhandled_oops());
221 }
223 if (or_null) {
224 return ak->array_klass_or_null(n);
225 }
226 return ak->array_klass(n, CHECK_NULL);
227 }
229 klassOop objArrayKlass::array_klass_impl(bool or_null, TRAPS) {
230 return array_klass_impl(or_null, dimension() + 1, CHECK_NULL);
231 }
233 bool objArrayKlass::can_be_primary_super_slow() const {
234 if (!bottom_klass()->klass_part()->can_be_primary_super())
235 // array of interfaces
236 return false;
237 else
238 return Klass::can_be_primary_super_slow();
239 }
241 objArrayOop objArrayKlass::compute_secondary_supers(int num_extra_slots, TRAPS) {
242 // interfaces = { cloneable_klass, serializable_klass, elemSuper[], ... };
243 objArrayOop es = Klass::cast(element_klass())->secondary_supers();
244 objArrayHandle elem_supers (THREAD, es);
245 int num_elem_supers = elem_supers.is_null() ? 0 : elem_supers->length();
246 int num_secondaries = num_extra_slots + 2 + num_elem_supers;
247 if (num_secondaries == 2) {
248 // Must share this for correct bootstrapping!
249 return Universe::the_array_interfaces_array();
250 } else {
251 objArrayOop sec_oop = oopFactory::new_system_objArray(num_secondaries, CHECK_NULL);
252 objArrayHandle secondaries(THREAD, sec_oop);
253 secondaries->obj_at_put(num_extra_slots+0, SystemDictionary::cloneable_klass());
254 secondaries->obj_at_put(num_extra_slots+1, SystemDictionary::serializable_klass());
255 for (int i = 0; i < num_elem_supers; i++) {
256 klassOop elem_super = (klassOop) elem_supers->obj_at(i);
257 klassOop array_super = elem_super->klass_part()->array_klass_or_null();
258 assert(array_super != NULL, "must already have been created");
259 secondaries->obj_at_put(num_extra_slots+2+i, array_super);
260 }
261 return secondaries();
262 }
263 }
265 bool objArrayKlass::compute_is_subtype_of(klassOop k) {
266 if (!k->klass_part()->oop_is_objArray())
267 return arrayKlass::compute_is_subtype_of(k);
269 objArrayKlass* oak = objArrayKlass::cast(k);
270 return element_klass()->klass_part()->is_subtype_of(oak->element_klass());
271 }
273 void objArrayKlass::initialize(TRAPS) {
274 Klass::cast(bottom_klass())->initialize(THREAD); // dispatches to either instanceKlass or typeArrayKlass
275 }
277 #define ObjArrayKlass_SPECIALIZED_OOP_ITERATE(T, a, p, do_oop) \
278 { \
279 T* p = (T*)(a)->base(); \
280 T* const end = p + (a)->length(); \
281 while (p < end) { \
282 do_oop; \
283 p++; \
284 } \
285 }
287 #define ObjArrayKlass_SPECIALIZED_BOUNDED_OOP_ITERATE(T, a, p, low, high, do_oop) \
288 { \
289 T* const l = (T*)(low); \
290 T* const h = (T*)(high); \
291 T* p = (T*)(a)->base(); \
292 T* end = p + (a)->length(); \
293 if (p < l) p = l; \
294 if (end > h) end = h; \
295 while (p < end) { \
296 do_oop; \
297 ++p; \
298 } \
299 }
301 #define ObjArrayKlass_OOP_ITERATE(a, p, do_oop) \
302 if (UseCompressedOops) { \
303 ObjArrayKlass_SPECIALIZED_OOP_ITERATE(narrowOop, \
304 a, p, do_oop) \
305 } else { \
306 ObjArrayKlass_SPECIALIZED_OOP_ITERATE(oop, \
307 a, p, do_oop) \
308 }
310 #define ObjArrayKlass_BOUNDED_OOP_ITERATE(a, p, low, high, do_oop) \
311 if (UseCompressedOops) { \
312 ObjArrayKlass_SPECIALIZED_BOUNDED_OOP_ITERATE(narrowOop, \
313 a, p, low, high, do_oop) \
314 } else { \
315 ObjArrayKlass_SPECIALIZED_BOUNDED_OOP_ITERATE(oop, \
316 a, p, low, high, do_oop) \
317 }
319 void objArrayKlass::oop_follow_contents(oop obj) {
320 assert (obj->is_array(), "obj must be array");
321 objArrayOop a = objArrayOop(obj);
322 a->follow_header();
323 ObjArrayKlass_OOP_ITERATE( \
324 a, p, \
325 /* we call mark_and_follow here to avoid excessive marking stack usage */ \
326 MarkSweep::mark_and_follow(p))
327 }
329 #ifndef SERIALGC
330 void objArrayKlass::oop_follow_contents(ParCompactionManager* cm,
331 oop obj) {
332 assert (obj->is_array(), "obj must be array");
333 objArrayOop a = objArrayOop(obj);
334 a->follow_header(cm);
335 ObjArrayKlass_OOP_ITERATE( \
336 a, p, \
337 /* we call mark_and_follow here to avoid excessive marking stack usage */ \
338 PSParallelCompact::mark_and_follow(cm, p))
339 }
340 #endif // SERIALGC
342 #define ObjArrayKlass_OOP_OOP_ITERATE_DEFN(OopClosureType, nv_suffix) \
343 \
344 int objArrayKlass::oop_oop_iterate##nv_suffix(oop obj, \
345 OopClosureType* closure) { \
346 SpecializationStats::record_iterate_call##nv_suffix(SpecializationStats::oa); \
347 assert (obj->is_array(), "obj must be array"); \
348 objArrayOop a = objArrayOop(obj); \
349 /* Get size before changing pointers. */ \
350 /* Don't call size() or oop_size() since that is a virtual call. */ \
351 int size = a->object_size(); \
352 if (closure->do_header()) { \
353 a->oop_iterate_header(closure); \
354 } \
355 ObjArrayKlass_OOP_ITERATE(a, p, (closure)->do_oop##nv_suffix(p)) \
356 return size; \
357 }
359 #define ObjArrayKlass_OOP_OOP_ITERATE_DEFN_m(OopClosureType, nv_suffix) \
360 \
361 int objArrayKlass::oop_oop_iterate##nv_suffix##_m(oop obj, \
362 OopClosureType* closure, \
363 MemRegion mr) { \
364 SpecializationStats::record_iterate_call##nv_suffix(SpecializationStats::oa); \
365 assert(obj->is_array(), "obj must be array"); \
366 objArrayOop a = objArrayOop(obj); \
367 /* Get size before changing pointers. */ \
368 /* Don't call size() or oop_size() since that is a virtual call */ \
369 int size = a->object_size(); \
370 if (closure->do_header()) { \
371 a->oop_iterate_header(closure, mr); \
372 } \
373 ObjArrayKlass_BOUNDED_OOP_ITERATE( \
374 a, p, mr.start(), mr.end(), (closure)->do_oop##nv_suffix(p)) \
375 return size; \
376 }
378 // Like oop_oop_iterate but only iterates over a specified range and only used
379 // for objArrayOops.
380 #define ObjArrayKlass_OOP_OOP_ITERATE_DEFN_r(OopClosureType, nv_suffix) \
381 \
382 int objArrayKlass::oop_oop_iterate_range##nv_suffix(oop obj, \
383 OopClosureType* closure, \
384 int start, int end) { \
385 SpecializationStats::record_iterate_call##nv_suffix(SpecializationStats::oa); \
386 assert(obj->is_array(), "obj must be array"); \
387 objArrayOop a = objArrayOop(obj); \
388 /* Get size before changing pointers. */ \
389 /* Don't call size() or oop_size() since that is a virtual call */ \
390 int size = a->object_size(); \
391 if (UseCompressedOops) { \
392 HeapWord* low = start == 0 ? (HeapWord*)a : (HeapWord*)a->obj_at_addr<narrowOop>(start);\
393 /* this might be wierd if end needs to be aligned on HeapWord boundary */ \
394 HeapWord* high = (HeapWord*)((narrowOop*)a->base() + end); \
395 MemRegion mr(low, high); \
396 if (closure->do_header()) { \
397 a->oop_iterate_header(closure, mr); \
398 } \
399 ObjArrayKlass_SPECIALIZED_BOUNDED_OOP_ITERATE(narrowOop, \
400 a, p, low, high, (closure)->do_oop##nv_suffix(p)) \
401 } else { \
402 HeapWord* low = start == 0 ? (HeapWord*)a : (HeapWord*)a->obj_at_addr<oop>(start); \
403 HeapWord* high = (HeapWord*)((oop*)a->base() + end); \
404 MemRegion mr(low, high); \
405 if (closure->do_header()) { \
406 a->oop_iterate_header(closure, mr); \
407 } \
408 ObjArrayKlass_SPECIALIZED_BOUNDED_OOP_ITERATE(oop, \
409 a, p, low, high, (closure)->do_oop##nv_suffix(p)) \
410 } \
411 return size; \
412 }
414 ALL_OOP_OOP_ITERATE_CLOSURES_1(ObjArrayKlass_OOP_OOP_ITERATE_DEFN)
415 ALL_OOP_OOP_ITERATE_CLOSURES_2(ObjArrayKlass_OOP_OOP_ITERATE_DEFN)
416 ALL_OOP_OOP_ITERATE_CLOSURES_1(ObjArrayKlass_OOP_OOP_ITERATE_DEFN_m)
417 ALL_OOP_OOP_ITERATE_CLOSURES_2(ObjArrayKlass_OOP_OOP_ITERATE_DEFN_m)
418 ALL_OOP_OOP_ITERATE_CLOSURES_1(ObjArrayKlass_OOP_OOP_ITERATE_DEFN_r)
419 ALL_OOP_OOP_ITERATE_CLOSURES_2(ObjArrayKlass_OOP_OOP_ITERATE_DEFN_r)
421 int objArrayKlass::oop_adjust_pointers(oop obj) {
422 assert(obj->is_objArray(), "obj must be obj array");
423 objArrayOop a = objArrayOop(obj);
424 // Get size before changing pointers.
425 // Don't call size() or oop_size() since that is a virtual call.
426 int size = a->object_size();
427 a->adjust_header();
428 ObjArrayKlass_OOP_ITERATE(a, p, MarkSweep::adjust_pointer(p))
429 return size;
430 }
432 #ifndef SERIALGC
433 void objArrayKlass::oop_copy_contents(PSPromotionManager* pm, oop obj) {
434 assert(!pm->depth_first(), "invariant");
435 assert(obj->is_objArray(), "obj must be obj array");
436 ObjArrayKlass_OOP_ITERATE( \
437 objArrayOop(obj), p, \
438 if (PSScavenge::should_scavenge(p)) { \
439 pm->claim_or_forward_breadth(p); \
440 })
441 }
443 void objArrayKlass::oop_push_contents(PSPromotionManager* pm, oop obj) {
444 assert(pm->depth_first(), "invariant");
445 assert(obj->is_objArray(), "obj must be obj array");
446 ObjArrayKlass_OOP_ITERATE( \
447 objArrayOop(obj), p, \
448 if (PSScavenge::should_scavenge(p)) { \
449 pm->claim_or_forward_depth(p); \
450 })
451 }
453 int objArrayKlass::oop_update_pointers(ParCompactionManager* cm, oop obj) {
454 assert (obj->is_objArray(), "obj must be obj array");
455 objArrayOop a = objArrayOop(obj);
456 ObjArrayKlass_OOP_ITERATE(a, p, PSParallelCompact::adjust_pointer(p))
457 return a->object_size();
458 }
460 int objArrayKlass::oop_update_pointers(ParCompactionManager* cm, oop obj,
461 HeapWord* beg_addr, HeapWord* end_addr) {
462 assert (obj->is_objArray(), "obj must be obj array");
463 objArrayOop a = objArrayOop(obj);
464 ObjArrayKlass_BOUNDED_OOP_ITERATE( \
465 a, p, beg_addr, end_addr, \
466 PSParallelCompact::adjust_pointer(p))
467 return a->object_size();
468 }
469 #endif // SERIALGC
471 // JVM support
473 jint objArrayKlass::compute_modifier_flags(TRAPS) const {
474 // The modifier for an objectArray is the same as its element
475 if (element_klass() == NULL) {
476 assert(Universe::is_bootstrapping(), "partial objArray only at startup");
477 return JVM_ACC_ABSTRACT | JVM_ACC_FINAL | JVM_ACC_PUBLIC;
478 }
479 // Return the flags of the bottom element type.
480 jint element_flags = Klass::cast(bottom_klass())->compute_modifier_flags(CHECK_0);
482 return (element_flags & (JVM_ACC_PUBLIC | JVM_ACC_PRIVATE | JVM_ACC_PROTECTED))
483 | (JVM_ACC_ABSTRACT | JVM_ACC_FINAL);
484 }
487 #ifndef PRODUCT
488 // Printing
490 void objArrayKlass::oop_print_on(oop obj, outputStream* st) {
491 arrayKlass::oop_print_on(obj, st);
492 assert(obj->is_objArray(), "must be objArray");
493 objArrayOop oa = objArrayOop(obj);
494 int print_len = MIN2((intx) oa->length(), MaxElementPrintSize);
495 for(int index = 0; index < print_len; index++) {
496 st->print(" - %3d : ", index);
497 oa->obj_at(index)->print_value_on(st);
498 st->cr();
499 }
500 int remaining = oa->length() - print_len;
501 if (remaining > 0) {
502 tty->print_cr(" - <%d more elements, increase MaxElementPrintSize to print>", remaining);
503 }
504 }
506 static int max_objArray_print_length = 4;
508 void objArrayKlass::oop_print_value_on(oop obj, outputStream* st) {
509 assert(obj->is_objArray(), "must be objArray");
510 st->print("a ");
511 element_klass()->print_value_on(st);
512 int len = objArrayOop(obj)->length();
513 st->print("[%d] ", len);
514 obj->print_address_on(st);
515 if (PrintOopAddress || PrintMiscellaneous && (WizardMode || Verbose)) {
516 st->print("{");
517 for (int i = 0; i < len; i++) {
518 if (i > max_objArray_print_length) {
519 st->print("..."); break;
520 }
521 st->print(" "INTPTR_FORMAT, (intptr_t)(void*)objArrayOop(obj)->obj_at(i));
522 }
523 st->print(" }");
524 }
525 }
527 #endif // PRODUCT
529 const char* objArrayKlass::internal_name() const {
530 return external_name();
531 }
533 // Verification
535 void objArrayKlass::oop_verify_on(oop obj, outputStream* st) {
536 arrayKlass::oop_verify_on(obj, st);
537 guarantee(obj->is_objArray(), "must be objArray");
538 objArrayOop oa = objArrayOop(obj);
539 for(int index = 0; index < oa->length(); index++) {
540 guarantee(oa->obj_at(index)->is_oop_or_null(), "should be oop");
541 }
542 }
544 void objArrayKlass::oop_verify_old_oop(oop obj, oop* p, bool allow_dirty) {
545 /* $$$ move into remembered set verification?
546 RememberedSet::verify_old_oop(obj, p, allow_dirty, true);
547 */
548 }
549 void objArrayKlass::oop_verify_old_oop(oop obj, narrowOop* p, bool allow_dirty) {}