src/share/vm/memory/cardTableModRefBS.hpp

Fri, 29 Apr 2011 14:59:04 -0400

author
tonyp
date
Fri, 29 Apr 2011 14:59:04 -0400
changeset 2849
063382f9b575
parent 2819
c48ad6ab8bdf
child 2889
fc2b798ab316
permissions
-rw-r--r--

7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
Summary: We should only undirty cards after we decide that they are not on a young region, not before. The fix also includes improvements to the verify_dirty_region() method which print out which cards were not found dirty.
Reviewed-by: johnc, brutisso

     1 /*
     2  * Copyright (c) 2000, 2011, Oracle and/or its affiliates. All rights reserved.
     3  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
     4  *
     5  * This code is free software; you can redistribute it and/or modify it
     6  * under the terms of the GNU General Public License version 2 only, as
     7  * published by the Free Software Foundation.
     8  *
     9  * This code is distributed in the hope that it will be useful, but WITHOUT
    10  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
    11  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
    12  * version 2 for more details (a copy is included in the LICENSE file that
    13  * accompanied this code).
    14  *
    15  * You should have received a copy of the GNU General Public License version
    16  * 2 along with this work; if not, write to the Free Software Foundation,
    17  * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
    18  *
    19  * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
    20  * or visit www.oracle.com if you need additional information or have any
    21  * questions.
    22  *
    23  */
    25 #ifndef SHARE_VM_MEMORY_CARDTABLEMODREFBS_HPP
    26 #define SHARE_VM_MEMORY_CARDTABLEMODREFBS_HPP
    28 #include "memory/modRefBarrierSet.hpp"
    29 #include "oops/oop.hpp"
    30 #include "oops/oop.inline2.hpp"
    32 // This kind of "BarrierSet" allows a "CollectedHeap" to detect and
    33 // enumerate ref fields that have been modified (since the last
    34 // enumeration.)
    36 // As it currently stands, this barrier is *imprecise*: when a ref field in
    37 // an object "o" is modified, the card table entry for the card containing
    38 // the head of "o" is dirtied, not necessarily the card containing the
    39 // modified field itself.  For object arrays, however, the barrier *is*
    40 // precise; only the card containing the modified element is dirtied.
    41 // Any MemRegionClosures used to scan dirty cards should take these
    42 // considerations into account.
    44 class Generation;
    45 class OopsInGenClosure;
    46 class DirtyCardToOopClosure;
    47 class ClearNoncleanCardWrapper;
    49 class CardTableModRefBS: public ModRefBarrierSet {
    50   // Some classes get to look at some private stuff.
    51   friend class BytecodeInterpreter;
    52   friend class VMStructs;
    53   friend class CardTableRS;
    54   friend class CheckForUnmarkedOops; // Needs access to raw card bytes.
    55   friend class SharkBuilder;
    56 #ifndef PRODUCT
    57   // For debugging.
    58   friend class GuaranteeNotModClosure;
    59 #endif
    60  protected:
    62   enum CardValues {
    63     clean_card                  = -1,
    64     // The mask contains zeros in places for all other values.
    65     clean_card_mask             = clean_card - 31,
    67     dirty_card                  =  0,
    68     precleaned_card             =  1,
    69     claimed_card                =  2,
    70     deferred_card               =  4,
    71     last_card                   =  8,
    72     CT_MR_BS_last_reserved      = 16
    73   };
    75   // dirty and precleaned are equivalent wrt younger_refs_iter.
    76   static bool card_is_dirty_wrt_gen_iter(jbyte cv) {
    77     return cv == dirty_card || cv == precleaned_card;
    78   }
    80   // Returns "true" iff the value "cv" will cause the card containing it
    81   // to be scanned in the current traversal.  May be overridden by
    82   // subtypes.
    83   virtual bool card_will_be_scanned(jbyte cv) {
    84     return CardTableModRefBS::card_is_dirty_wrt_gen_iter(cv);
    85   }
    87   // Returns "true" iff the value "cv" may have represented a dirty card at
    88   // some point.
    89   virtual bool card_may_have_been_dirty(jbyte cv) {
    90     return card_is_dirty_wrt_gen_iter(cv);
    91   }
    93   // The declaration order of these const fields is important; see the
    94   // constructor before changing.
    95   const MemRegion _whole_heap;       // the region covered by the card table
    96   const size_t    _guard_index;      // index of very last element in the card
    97                                      // table; it is set to a guard value
    98                                      // (last_card) and should never be modified
    99   const size_t    _last_valid_index; // index of the last valid element
   100   const size_t    _page_size;        // page size used when mapping _byte_map
   101   const size_t    _byte_map_size;    // in bytes
   102   jbyte*          _byte_map;         // the card marking array
   104   int _cur_covered_regions;
   105   // The covered regions should be in address order.
   106   MemRegion* _covered;
   107   // The committed regions correspond one-to-one to the covered regions.
   108   // They represent the card-table memory that has been committed to service
   109   // the corresponding covered region.  It may be that committed region for
   110   // one covered region corresponds to a larger region because of page-size
   111   // roundings.  Thus, a committed region for one covered region may
   112   // actually extend onto the card-table space for the next covered region.
   113   MemRegion* _committed;
   115   // The last card is a guard card, and we commit the page for it so
   116   // we can use the card for verification purposes. We make sure we never
   117   // uncommit the MemRegion for that page.
   118   MemRegion _guard_region;
   120  protected:
   121   // Initialization utilities; covered_words is the size of the covered region
   122   // in, um, words.
   123   inline size_t cards_required(size_t covered_words);
   124   inline size_t compute_byte_map_size();
   126   // Finds and return the index of the region, if any, to which the given
   127   // region would be contiguous.  If none exists, assign a new region and
   128   // returns its index.  Requires that no more than the maximum number of
   129   // covered regions defined in the constructor are ever in use.
   130   int find_covering_region_by_base(HeapWord* base);
   132   // Same as above, but finds the region containing the given address
   133   // instead of starting at a given base address.
   134   int find_covering_region_containing(HeapWord* addr);
   136   // Resize one of the regions covered by the remembered set.
   137   void resize_covered_region(MemRegion new_region);
   139   // Returns the leftmost end of a committed region corresponding to a
   140   // covered region before covered region "ind", or else "NULL" if "ind" is
   141   // the first covered region.
   142   HeapWord* largest_prev_committed_end(int ind) const;
   144   // Returns the part of the region mr that doesn't intersect with
   145   // any committed region other than self.  Used to prevent uncommitting
   146   // regions that are also committed by other regions.  Also protects
   147   // against uncommitting the guard region.
   148   MemRegion committed_unique_to_self(int self, MemRegion mr) const;
   150   // Mapping from address to card marking array entry
   151   jbyte* byte_for(const void* p) const {
   152     assert(_whole_heap.contains(p),
   153            "out of bounds access to card marking array");
   154     jbyte* result = &byte_map_base[uintptr_t(p) >> card_shift];
   155     assert(result >= _byte_map && result < _byte_map + _byte_map_size,
   156            "out of bounds accessor for card marking array");
   157     return result;
   158   }
   160   // The card table byte one after the card marking array
   161   // entry for argument address. Typically used for higher bounds
   162   // for loops iterating through the card table.
   163   jbyte* byte_after(const void* p) const {
   164     return byte_for(p) + 1;
   165   }
   167   // Iterate over the portion of the card-table which covers the given
   168   // region mr in the given space and apply cl to any dirty sub-regions
   169   // of mr. Dirty cards are _not_ cleared by the iterator method itself,
   170   // but closures may arrange to do so on their own should they so wish.
   171   void non_clean_card_iterate_serial(MemRegion mr, MemRegionClosure* cl);
   173   // A variant of the above that will operate in a parallel mode if
   174   // worker threads are available, and clear the dirty cards as it
   175   // processes them.
   176   // ClearNoncleanCardWrapper cl must wrap the DirtyCardToOopClosure dcto_cl,
   177   // which may itself be modified by the method.
   178   void non_clean_card_iterate_possibly_parallel(Space* sp, MemRegion mr,
   179                                                 DirtyCardToOopClosure* dcto_cl,
   180                                                 ClearNoncleanCardWrapper* cl);
   182  private:
   183   // Work method used to implement non_clean_card_iterate_possibly_parallel()
   184   // above in the parallel case.
   185   void non_clean_card_iterate_parallel_work(Space* sp, MemRegion mr,
   186                                             DirtyCardToOopClosure* dcto_cl,
   187                                             ClearNoncleanCardWrapper* cl,
   188                                             int n_threads);
   190  protected:
   191   // Dirty the bytes corresponding to "mr" (not all of which must be
   192   // covered.)
   193   void dirty_MemRegion(MemRegion mr);
   195   // Clear (to clean_card) the bytes entirely contained within "mr" (not
   196   // all of which must be covered.)
   197   void clear_MemRegion(MemRegion mr);
   199   // *** Support for parallel card scanning.
   201   enum SomeConstantsForParallelism {
   202     StridesPerThread    = 2,
   203     CardsPerStrideChunk = 256
   204   };
   206   // This is an array, one element per covered region of the card table.
   207   // Each entry is itself an array, with one element per chunk in the
   208   // covered region.  Each entry of these arrays is the lowest non-clean
   209   // card of the corresponding chunk containing part of an object from the
   210   // previous chunk, or else NULL.
   211   typedef jbyte*  CardPtr;
   212   typedef CardPtr* CardArr;
   213   CardArr* _lowest_non_clean;
   214   size_t*  _lowest_non_clean_chunk_size;
   215   uintptr_t* _lowest_non_clean_base_chunk_index;
   216   int* _last_LNC_resizing_collection;
   218   // Initializes "lowest_non_clean" to point to the array for the region
   219   // covering "sp", and "lowest_non_clean_base_chunk_index" to the chunk
   220   // index of the corresponding to the first element of that array.
   221   // Ensures that these arrays are of sufficient size, allocating if necessary.
   222   // May be called by several threads concurrently.
   223   void get_LNC_array_for_space(Space* sp,
   224                                jbyte**& lowest_non_clean,
   225                                uintptr_t& lowest_non_clean_base_chunk_index,
   226                                size_t& lowest_non_clean_chunk_size);
   228   // Returns the number of chunks necessary to cover "mr".
   229   size_t chunks_to_cover(MemRegion mr) {
   230     return (size_t)(addr_to_chunk_index(mr.last()) -
   231                     addr_to_chunk_index(mr.start()) + 1);
   232   }
   234   // Returns the index of the chunk in a stride which
   235   // covers the given address.
   236   uintptr_t addr_to_chunk_index(const void* addr) {
   237     uintptr_t card = (uintptr_t) byte_for(addr);
   238     return card / CardsPerStrideChunk;
   239   }
   241   // Apply cl, which must either itself apply dcto_cl or be dcto_cl,
   242   // to the cards in the stride (of n_strides) within the given space.
   243   void process_stride(Space* sp,
   244                       MemRegion used,
   245                       jint stride, int n_strides,
   246                       DirtyCardToOopClosure* dcto_cl,
   247                       ClearNoncleanCardWrapper* cl,
   248                       jbyte** lowest_non_clean,
   249                       uintptr_t lowest_non_clean_base_chunk_index,
   250                       size_t lowest_non_clean_chunk_size);
   252   // Makes sure that chunk boundaries are handled appropriately, by
   253   // adjusting the min_done of dcto_cl, and by using a special card-table
   254   // value to indicate how min_done should be set.
   255   void process_chunk_boundaries(Space* sp,
   256                                 DirtyCardToOopClosure* dcto_cl,
   257                                 MemRegion chunk_mr,
   258                                 MemRegion used,
   259                                 jbyte** lowest_non_clean,
   260                                 uintptr_t lowest_non_clean_base_chunk_index,
   261                                 size_t    lowest_non_clean_chunk_size);
   263 public:
   264   // Constants
   265   enum SomePublicConstants {
   266     card_shift                  = 9,
   267     card_size                   = 1 << card_shift,
   268     card_size_in_words          = card_size / sizeof(HeapWord)
   269   };
   271   static int clean_card_val()      { return clean_card; }
   272   static int clean_card_mask_val() { return clean_card_mask; }
   273   static int dirty_card_val()      { return dirty_card; }
   274   static int claimed_card_val()    { return claimed_card; }
   275   static int precleaned_card_val() { return precleaned_card; }
   276   static int deferred_card_val()   { return deferred_card; }
   278   // For RTTI simulation.
   279   bool is_a(BarrierSet::Name bsn) {
   280     return bsn == BarrierSet::CardTableModRef || ModRefBarrierSet::is_a(bsn);
   281   }
   283   CardTableModRefBS(MemRegion whole_heap, int max_covered_regions);
   285   // *** Barrier set functions.
   287   bool has_write_ref_pre_barrier() { return false; }
   289   inline bool write_ref_needs_barrier(void* field, oop new_val) {
   290     // Note that this assumes the perm gen is the highest generation
   291     // in the address space
   292     return new_val != NULL && !new_val->is_perm();
   293   }
   295   // Record a reference update. Note that these versions are precise!
   296   // The scanning code has to handle the fact that the write barrier may be
   297   // either precise or imprecise. We make non-virtual inline variants of
   298   // these functions here for performance.
   299 protected:
   300   void write_ref_field_work(oop obj, size_t offset, oop newVal);
   301   virtual void write_ref_field_work(void* field, oop newVal);
   302 public:
   304   bool has_write_ref_array_opt() { return true; }
   305   bool has_write_region_opt() { return true; }
   307   inline void inline_write_region(MemRegion mr) {
   308     dirty_MemRegion(mr);
   309   }
   310 protected:
   311   void write_region_work(MemRegion mr) {
   312     inline_write_region(mr);
   313   }
   314 public:
   316   inline void inline_write_ref_array(MemRegion mr) {
   317     dirty_MemRegion(mr);
   318   }
   319 protected:
   320   void write_ref_array_work(MemRegion mr) {
   321     inline_write_ref_array(mr);
   322   }
   323 public:
   325   bool is_aligned(HeapWord* addr) {
   326     return is_card_aligned(addr);
   327   }
   329   // *** Card-table-barrier-specific things.
   331   template <class T> inline void inline_write_ref_field_pre(T* field, oop newVal) {}
   333   template <class T> inline void inline_write_ref_field(T* field, oop newVal) {
   334     jbyte* byte = byte_for((void*)field);
   335     *byte = dirty_card;
   336   }
   338   // These are used by G1, when it uses the card table as a temporary data
   339   // structure for card claiming.
   340   bool is_card_dirty(size_t card_index) {
   341     return _byte_map[card_index] == dirty_card_val();
   342   }
   344   void mark_card_dirty(size_t card_index) {
   345     _byte_map[card_index] = dirty_card_val();
   346   }
   348   bool is_card_claimed(size_t card_index) {
   349     jbyte val = _byte_map[card_index];
   350     return (val & (clean_card_mask_val() | claimed_card_val())) == claimed_card_val();
   351   }
   353   void set_card_claimed(size_t card_index) {
   354       jbyte val = _byte_map[card_index];
   355       if (val == clean_card_val()) {
   356         val = (jbyte)claimed_card_val();
   357       } else {
   358         val |= (jbyte)claimed_card_val();
   359       }
   360       _byte_map[card_index] = val;
   361   }
   363   bool claim_card(size_t card_index);
   365   bool is_card_clean(size_t card_index) {
   366     return _byte_map[card_index] == clean_card_val();
   367   }
   369   bool is_card_deferred(size_t card_index) {
   370     jbyte val = _byte_map[card_index];
   371     return (val & (clean_card_mask_val() | deferred_card_val())) == deferred_card_val();
   372   }
   374   bool mark_card_deferred(size_t card_index);
   376   // Card marking array base (adjusted for heap low boundary)
   377   // This would be the 0th element of _byte_map, if the heap started at 0x0.
   378   // But since the heap starts at some higher address, this points to somewhere
   379   // before the beginning of the actual _byte_map.
   380   jbyte* byte_map_base;
   382   // Return true if "p" is at the start of a card.
   383   bool is_card_aligned(HeapWord* p) {
   384     jbyte* pcard = byte_for(p);
   385     return (addr_for(pcard) == p);
   386   }
   388   HeapWord* align_to_card_boundary(HeapWord* p) {
   389     jbyte* pcard = byte_for(p + card_size_in_words - 1);
   390     return addr_for(pcard);
   391   }
   393   // The kinds of precision a CardTableModRefBS may offer.
   394   enum PrecisionStyle {
   395     Precise,
   396     ObjHeadPreciseArray
   397   };
   399   // Tells what style of precision this card table offers.
   400   PrecisionStyle precision() {
   401     return ObjHeadPreciseArray; // Only one supported for now.
   402   }
   404   // ModRefBS functions.
   405   virtual void invalidate(MemRegion mr, bool whole_heap = false);
   406   void clear(MemRegion mr);
   407   void dirty(MemRegion mr);
   409   // *** Card-table-RemSet-specific things.
   411   // Invoke "cl.do_MemRegion" on a set of MemRegions that collectively
   412   // includes all the modified cards (expressing each card as a
   413   // MemRegion).  Thus, several modified cards may be lumped into one
   414   // region.  The regions are non-overlapping, and are visited in
   415   // *decreasing* address order.  (This order aids with imprecise card
   416   // marking, where a dirty card may cause scanning, and summarization
   417   // marking, of objects that extend onto subsequent cards.)
   418   void mod_card_iterate(MemRegionClosure* cl) {
   419     non_clean_card_iterate_serial(_whole_heap, cl);
   420   }
   422   // Like the "mod_cards_iterate" above, except only invokes the closure
   423   // for cards within the MemRegion "mr" (which is required to be
   424   // card-aligned and sized.)
   425   void mod_card_iterate(MemRegion mr, MemRegionClosure* cl) {
   426     non_clean_card_iterate_serial(mr, cl);
   427   }
   429   static uintx ct_max_alignment_constraint();
   431   // Apply closure "cl" to the dirty cards containing some part of
   432   // MemRegion "mr".
   433   void dirty_card_iterate(MemRegion mr, MemRegionClosure* cl);
   435   // Return the MemRegion corresponding to the first maximal run
   436   // of dirty cards lying completely within MemRegion mr.
   437   // If reset is "true", then sets those card table entries to the given
   438   // value.
   439   MemRegion dirty_card_range_after_reset(MemRegion mr, bool reset,
   440                                          int reset_val);
   442   // Set all the dirty cards in the given region to precleaned state.
   443   void preclean_dirty_cards(MemRegion mr);
   445   // Provide read-only access to the card table array.
   446   const jbyte* byte_for_const(const void* p) const {
   447     return byte_for(p);
   448   }
   449   const jbyte* byte_after_const(const void* p) const {
   450     return byte_after(p);
   451   }
   453   // Mapping from card marking array entry to address of first word
   454   HeapWord* addr_for(const jbyte* p) const {
   455     assert(p >= _byte_map && p < _byte_map + _byte_map_size,
   456            "out of bounds access to card marking array");
   457     size_t delta = pointer_delta(p, byte_map_base, sizeof(jbyte));
   458     HeapWord* result = (HeapWord*) (delta << card_shift);
   459     assert(_whole_heap.contains(result),
   460            "out of bounds accessor from card marking array");
   461     return result;
   462   }
   464   // Mapping from address to card marking array index.
   465   size_t index_for(void* p) {
   466     assert(_whole_heap.contains(p),
   467            "out of bounds access to card marking array");
   468     return byte_for(p) - _byte_map;
   469   }
   471   const jbyte* byte_for_index(const size_t card_index) const {
   472     return _byte_map + card_index;
   473   }
   475   void verify();
   476   void verify_guard();
   478   // val_equals -> it will check that all cards covered by mr equal val
   479   // !val_equals -> it will check that all cards covered by mr do not equal val
   480   void verify_region(MemRegion mr, jbyte val, bool val_equals) PRODUCT_RETURN;
   481   void verify_not_dirty_region(MemRegion mr) PRODUCT_RETURN;
   482   void verify_dirty_region(MemRegion mr) PRODUCT_RETURN;
   484   static size_t par_chunk_heapword_alignment() {
   485     return CardsPerStrideChunk * card_size_in_words;
   486   }
   488 };
   490 class CardTableRS;
   492 // A specialization for the CardTableRS gen rem set.
   493 class CardTableModRefBSForCTRS: public CardTableModRefBS {
   494   CardTableRS* _rs;
   495 protected:
   496   bool card_will_be_scanned(jbyte cv);
   497   bool card_may_have_been_dirty(jbyte cv);
   498 public:
   499   CardTableModRefBSForCTRS(MemRegion whole_heap,
   500                            int max_covered_regions) :
   501     CardTableModRefBS(whole_heap, max_covered_regions) {}
   503   void set_CTRS(CardTableRS* rs) { _rs = rs; }
   504 };
   507 #endif // SHARE_VM_MEMORY_CARDTABLEMODREFBS_HPP

mercurial