src/share/vm/gc_implementation/g1/satbQueue.hpp

Fri, 29 Apr 2011 14:59:04 -0400

author
tonyp
date
Fri, 29 Apr 2011 14:59:04 -0400
changeset 2849
063382f9b575
parent 2469
7e37af9d69ef
child 3416
2ace1c4ee8da
permissions
-rw-r--r--

7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
Summary: We should only undirty cards after we decide that they are not on a young region, not before. The fix also includes improvements to the verify_dirty_region() method which print out which cards were not found dirty.
Reviewed-by: johnc, brutisso

     1 /*
     2  * Copyright (c) 2001, 2011, Oracle and/or its affiliates. All rights reserved.
     3  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
     4  *
     5  * This code is free software; you can redistribute it and/or modify it
     6  * under the terms of the GNU General Public License version 2 only, as
     7  * published by the Free Software Foundation.
     8  *
     9  * This code is distributed in the hope that it will be useful, but WITHOUT
    10  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
    11  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
    12  * version 2 for more details (a copy is included in the LICENSE file that
    13  * accompanied this code).
    14  *
    15  * You should have received a copy of the GNU General Public License version
    16  * 2 along with this work; if not, write to the Free Software Foundation,
    17  * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
    18  *
    19  * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
    20  * or visit www.oracle.com if you need additional information or have any
    21  * questions.
    22  *
    23  */
    25 #ifndef SHARE_VM_GC_IMPLEMENTATION_G1_SATBQUEUE_HPP
    26 #define SHARE_VM_GC_IMPLEMENTATION_G1_SATBQUEUE_HPP
    28 #include "gc_implementation/g1/ptrQueue.hpp"
    30 class ObjectClosure;
    31 class JavaThread;
    33 // A ptrQueue whose elements are "oops", pointers to object heads.
    34 class ObjPtrQueue: public PtrQueue {
    35 public:
    36   ObjPtrQueue(PtrQueueSet* qset, bool perm = false) :
    37     // SATB queues are only active during marking cycles. We create
    38     // them with their active field set to false. If a thread is
    39     // created during a cycle and its SATB queue needs to be activated
    40     // before the thread starts running, we'll need to set its active
    41     // field to true. This is done in JavaThread::initialize_queues().
    42     PtrQueue(qset, perm, false /* active */) { }
    44   // Overrides PtrQueue::should_enqueue_buffer(). See the method's
    45   // definition for more information.
    46   virtual bool should_enqueue_buffer();
    48   // Apply the closure to all elements, and reset the index to make the
    49   // buffer empty.
    50   void apply_closure(ObjectClosure* cl);
    52   // Apply the closure to all elements of "buf", down to "index" (inclusive.)
    53   static void apply_closure_to_buffer(ObjectClosure* cl,
    54                                       void** buf, size_t index, size_t sz);
    56   void verify_oops_in_buffer() NOT_DEBUG_RETURN;
    57 };
    61 class SATBMarkQueueSet: public PtrQueueSet {
    62   ObjectClosure* _closure;
    63   ObjectClosure** _par_closures;  // One per ParGCThread.
    65   ObjPtrQueue _shared_satb_queue;
    67   // Utility function to support sequential and parallel versions.  If
    68   // "par" is true, then "worker" is the par thread id; if "false", worker
    69   // is ignored.
    70   bool apply_closure_to_completed_buffer_work(bool par, int worker);
    72 #ifdef ASSERT
    73   void dump_active_values(JavaThread* first, bool expected_active);
    74 #endif // ASSERT
    76 public:
    77   SATBMarkQueueSet();
    79   void initialize(Monitor* cbl_mon, Mutex* fl_lock,
    80                   int process_completed_threshold,
    81                   Mutex* lock);
    83   static void handle_zero_index_for_thread(JavaThread* t);
    85   // Apply "set_active(b)" to all Java threads' SATB queues. It should be
    86   // called only with the world stopped. The method will assert that the
    87   // SATB queues of all threads it visits, as well as the SATB queue
    88   // set itself, has an active value same as expected_active.
    89   void set_active_all_threads(bool b, bool expected_active);
    91   // Register "blk" as "the closure" for all queues.  Only one such closure
    92   // is allowed.  The "apply_closure_to_completed_buffer" method will apply
    93   // this closure to a completed buffer, and "iterate_closure_all_threads"
    94   // applies it to partially-filled buffers (the latter should only be done
    95   // with the world stopped).
    96   void set_closure(ObjectClosure* closure);
    97   // Set the parallel closures: pointer is an array of pointers to
    98   // closures, one for each parallel GC thread.
    99   void set_par_closure(int i, ObjectClosure* closure);
   101   // If there is a registered closure for buffers, apply it to all entries
   102   // in all currently-active buffers.  This should only be applied at a
   103   // safepoint.  (Currently must not be called in parallel; this should
   104   // change in the future.)
   105   void iterate_closure_all_threads();
   106   // Parallel version of the above.
   107   void par_iterate_closure_all_threads(int worker);
   109   // If there exists some completed buffer, pop it, then apply the
   110   // registered closure to all its elements, and return true.  If no
   111   // completed buffers exist, return false.
   112   bool apply_closure_to_completed_buffer() {
   113     return apply_closure_to_completed_buffer_work(false, 0);
   114   }
   115   // Parallel version of the above.
   116   bool par_apply_closure_to_completed_buffer(int worker) {
   117     return apply_closure_to_completed_buffer_work(true, worker);
   118   }
   120   ObjPtrQueue* shared_satb_queue() { return &_shared_satb_queue; }
   122   // If a marking is being abandoned, reset any unprocessed log buffers.
   123   void abandon_partial_marking();
   125 };
   127 #endif // SHARE_VM_GC_IMPLEMENTATION_G1_SATBQUEUE_HPP

mercurial