src/share/vm/gc_implementation/g1/heapRegionSets.hpp

Fri, 29 Apr 2011 14:59:04 -0400

author
tonyp
date
Fri, 29 Apr 2011 14:59:04 -0400
changeset 2849
063382f9b575
parent 2472
0fa27f37d4d4
child 2962
ae5b2f1dcf12
permissions
-rw-r--r--

7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
Summary: We should only undirty cards after we decide that they are not on a young region, not before. The fix also includes improvements to the verify_dirty_region() method which print out which cards were not found dirty.
Reviewed-by: johnc, brutisso

     1 /*
     2  * copyright (c) 2011, Oracle and/or its affiliates. All rights reserved.
     3  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
     4  *
     5  * This code is free software; you can redistribute it and/or modify it
     6  * under the terms of the GNU General Public License version 2 only, as
     7  * published by the Free Software Foundation.
     8  *
     9  * This code is distributed in the hope that it will be useful, but WITHOUT
    10  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
    11  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
    12  * version 2 for more details (a copy is included in the LICENSE file that
    13  * accompanied this code).
    14  *
    15  * You should have received a copy of the GNU General Public License version
    16  * 2 along with this work; if not, write to the Free Software Foundation,
    17  * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
    18  *
    19  * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
    20  * or visit www.oracle.com if you need additional information or have any
    21  * questions.
    22  *
    23  */
    25 #ifndef SHARE_VM_GC_IMPLEMENTATION_G1_HEAPREGIONSETS_HPP
    26 #define SHARE_VM_GC_IMPLEMENTATION_G1_HEAPREGIONSETS_HPP
    28 #include "gc_implementation/g1/heapRegionSet.inline.hpp"
    30 //////////////////// FreeRegionList ////////////////////
    32 class FreeRegionList : public HeapRegionLinkedList {
    33 protected:
    34   virtual const char* verify_region_extra(HeapRegion* hr);
    36   virtual bool regions_humongous() { return false; }
    37   virtual bool regions_empty()     { return true;  }
    39 public:
    40   FreeRegionList(const char* name) : HeapRegionLinkedList(name) { }
    41 };
    43 //////////////////// MasterFreeRegionList ////////////////////
    45 class MasterFreeRegionList : public FreeRegionList {
    46 protected:
    47   virtual bool check_mt_safety();
    49 public:
    50   MasterFreeRegionList(const char* name) : FreeRegionList(name) { }
    51 };
    53 //////////////////// SecondaryFreeRegionList ////////////////////
    55 class SecondaryFreeRegionList : public FreeRegionList {
    56 protected:
    57   virtual bool check_mt_safety();
    59 public:
    60   SecondaryFreeRegionList(const char* name) : FreeRegionList(name) { }
    61 };
    63 //////////////////// HumongousRegionSet ////////////////////
    65 class HumongousRegionSet : public HeapRegionSet {
    66 protected:
    67   virtual const char* verify_region_extra(HeapRegion* hr);
    69   virtual bool regions_humongous() { return true;  }
    70   virtual bool regions_empty()     { return false; }
    72 public:
    73   HumongousRegionSet(const char* name) : HeapRegionSet(name) { }
    74 };
    76 //////////////////// MasterHumongousRegionSet ////////////////////
    78 class MasterHumongousRegionSet : public HumongousRegionSet {
    79 protected:
    80   virtual bool check_mt_safety();
    82 public:
    83   MasterHumongousRegionSet(const char* name) : HumongousRegionSet(name) { }
    84 };
    86 #endif // SHARE_VM_GC_IMPLEMENTATION_G1_HEAPREGIONSETS_HPP

mercurial