src/share/vm/gc_implementation/g1/heapRegionSeq.inline.hpp

Fri, 29 Apr 2011 14:59:04 -0400

author
tonyp
date
Fri, 29 Apr 2011 14:59:04 -0400
changeset 2849
063382f9b575
parent 2314
f95d63e2154a
child 2963
c3f1170908be
permissions
-rw-r--r--

7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
Summary: We should only undirty cards after we decide that they are not on a young region, not before. The fix also includes improvements to the verify_dirty_region() method which print out which cards were not found dirty.
Reviewed-by: johnc, brutisso

     1 /*
     2  * Copyright (c) 2001, 2010, Oracle and/or its affiliates. All rights reserved.
     3  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
     4  *
     5  * This code is free software; you can redistribute it and/or modify it
     6  * under the terms of the GNU General Public License version 2 only, as
     7  * published by the Free Software Foundation.
     8  *
     9  * This code is distributed in the hope that it will be useful, but WITHOUT
    10  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
    11  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
    12  * version 2 for more details (a copy is included in the LICENSE file that
    13  * accompanied this code).
    14  *
    15  * You should have received a copy of the GNU General Public License version
    16  * 2 along with this work; if not, write to the Free Software Foundation,
    17  * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
    18  *
    19  * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
    20  * or visit www.oracle.com if you need additional information or have any
    21  * questions.
    22  *
    23  */
    25 #ifndef SHARE_VM_GC_IMPLEMENTATION_G1_HEAPREGIONSEQ_INLINE_HPP
    26 #define SHARE_VM_GC_IMPLEMENTATION_G1_HEAPREGIONSEQ_INLINE_HPP
    28 #include "gc_implementation/g1/heapRegionSeq.hpp"
    30 inline HeapRegion* HeapRegionSeq::addr_to_region(const void* addr) {
    31   assert(_seq_bottom != NULL, "bad _seq_bottom in addr_to_region");
    32   if ((char*) addr >= _seq_bottom) {
    33     size_t diff = (size_t) pointer_delta((HeapWord*) addr,
    34                                          (HeapWord*) _seq_bottom);
    35     int index = (int) (diff >> HeapRegion::LogOfHRGrainWords);
    36     assert(index >= 0, "invariant / paranoia");
    37     if (index < _regions.length()) {
    38       HeapRegion* hr = _regions.at(index);
    39       assert(hr->is_in_reserved(addr),
    40              "addr_to_region is wrong...");
    41       return hr;
    42     }
    43   }
    44   return NULL;
    45 }
    47 #endif // SHARE_VM_GC_IMPLEMENTATION_G1_HEAPREGIONSEQ_INLINE_HPP

mercurial