src/share/vm/gc_implementation/g1/heapRegion.inline.hpp

Fri, 29 Apr 2011 14:59:04 -0400

author
tonyp
date
Fri, 29 Apr 2011 14:59:04 -0400
changeset 2849
063382f9b575
parent 2715
abdfc822206f
child 3416
2ace1c4ee8da
permissions
-rw-r--r--

7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
Summary: We should only undirty cards after we decide that they are not on a young region, not before. The fix also includes improvements to the verify_dirty_region() method which print out which cards were not found dirty.
Reviewed-by: johnc, brutisso

     1 /*
     2  * Copyright (c) 2001, 2010, Oracle and/or its affiliates. All rights reserved.
     3  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
     4  *
     5  * This code is free software; you can redistribute it and/or modify it
     6  * under the terms of the GNU General Public License version 2 only, as
     7  * published by the Free Software Foundation.
     8  *
     9  * This code is distributed in the hope that it will be useful, but WITHOUT
    10  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
    11  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
    12  * version 2 for more details (a copy is included in the LICENSE file that
    13  * accompanied this code).
    14  *
    15  * You should have received a copy of the GNU General Public License version
    16  * 2 along with this work; if not, write to the Free Software Foundation,
    17  * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
    18  *
    19  * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
    20  * or visit www.oracle.com if you need additional information or have any
    21  * questions.
    22  *
    23  */
    25 #ifndef SHARE_VM_GC_IMPLEMENTATION_G1_HEAPREGION_INLINE_HPP
    26 #define SHARE_VM_GC_IMPLEMENTATION_G1_HEAPREGION_INLINE_HPP
    28 inline HeapWord* G1OffsetTableContigSpace::allocate(size_t size) {
    29   HeapWord* res = ContiguousSpace::allocate(size);
    30   if (res != NULL) {
    31     _offsets.alloc_block(res, size);
    32   }
    33   return res;
    34 }
    36 // Because of the requirement of keeping "_offsets" up to date with the
    37 // allocations, we sequentialize these with a lock.  Therefore, best if
    38 // this is used for larger LAB allocations only.
    39 inline HeapWord* G1OffsetTableContigSpace::par_allocate(size_t size) {
    40   MutexLocker x(&_par_alloc_lock);
    41   // Given that we take the lock no need to use par_allocate() here.
    42   HeapWord* res = ContiguousSpace::allocate(size);
    43   if (res != NULL) {
    44     _offsets.alloc_block(res, size);
    45   }
    46   return res;
    47 }
    49 inline HeapWord* G1OffsetTableContigSpace::block_start(const void* p) {
    50   return _offsets.block_start(p);
    51 }
    53 inline HeapWord*
    54 G1OffsetTableContigSpace::block_start_const(const void* p) const {
    55   return _offsets.block_start_const(p);
    56 }
    58 #endif // SHARE_VM_GC_IMPLEMENTATION_G1_HEAPREGION_INLINE_HPP

mercurial