Fri, 29 Apr 2011 14:59:04 -0400
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
Summary: We should only undirty cards after we decide that they are not on a young region, not before. The fix also includes improvements to the verify_dirty_region() method which print out which cards were not found dirty.
Reviewed-by: johnc, brutisso
1 /*
2 * Copyright (c) 2001, 2011, Oracle and/or its affiliates. All rights reserved.
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4 *
5 * This code is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 only, as
7 * published by the Free Software Foundation.
8 *
9 * This code is distributed in the hope that it will be useful, but WITHOUT
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
12 * version 2 for more details (a copy is included in the LICENSE file that
13 * accompanied this code).
14 *
15 * You should have received a copy of the GNU General Public License version
16 * 2 along with this work; if not, write to the Free Software Foundation,
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
18 *
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
20 * or visit www.oracle.com if you need additional information or have any
21 * questions.
22 *
23 */
25 #include "precompiled.hpp"
26 #include "gc_implementation/g1/g1SATBCardTableModRefBS.hpp"
27 #include "gc_implementation/g1/heapRegion.hpp"
28 #include "gc_implementation/g1/satbQueue.hpp"
29 #include "runtime/mutexLocker.hpp"
30 #include "runtime/thread.hpp"
31 #ifdef TARGET_OS_FAMILY_linux
32 # include "thread_linux.inline.hpp"
33 #endif
34 #ifdef TARGET_OS_FAMILY_solaris
35 # include "thread_solaris.inline.hpp"
36 #endif
37 #ifdef TARGET_OS_FAMILY_windows
38 # include "thread_windows.inline.hpp"
39 #endif
41 G1SATBCardTableModRefBS::G1SATBCardTableModRefBS(MemRegion whole_heap,
42 int max_covered_regions) :
43 CardTableModRefBSForCTRS(whole_heap, max_covered_regions)
44 {
45 _kind = G1SATBCT;
46 }
49 void G1SATBCardTableModRefBS::enqueue(oop pre_val) {
50 // Nulls should have been already filtered.
51 assert(pre_val->is_oop(true), "Error");
53 if (!JavaThread::satb_mark_queue_set().is_active()) return;
54 Thread* thr = Thread::current();
55 if (thr->is_Java_thread()) {
56 JavaThread* jt = (JavaThread*)thr;
57 jt->satb_mark_queue().enqueue(pre_val);
58 } else {
59 MutexLocker x(Shared_SATB_Q_lock);
60 JavaThread::satb_mark_queue_set().shared_satb_queue()->enqueue(pre_val);
61 }
62 }
64 template <class T> void
65 G1SATBCardTableModRefBS::write_ref_array_pre_work(T* dst, int count) {
66 if (!JavaThread::satb_mark_queue_set().is_active()) return;
67 T* elem_ptr = dst;
68 for (int i = 0; i < count; i++, elem_ptr++) {
69 T heap_oop = oopDesc::load_heap_oop(elem_ptr);
70 if (!oopDesc::is_null(heap_oop)) {
71 enqueue(oopDesc::decode_heap_oop_not_null(heap_oop));
72 }
73 }
74 }
76 G1SATBCardTableLoggingModRefBS::
77 G1SATBCardTableLoggingModRefBS(MemRegion whole_heap,
78 int max_covered_regions) :
79 G1SATBCardTableModRefBS(whole_heap, max_covered_regions),
80 _dcqs(JavaThread::dirty_card_queue_set())
81 {
82 _kind = G1SATBCTLogging;
83 }
85 void
86 G1SATBCardTableLoggingModRefBS::write_ref_field_work(void* field,
87 oop new_val) {
88 jbyte* byte = byte_for(field);
89 if (*byte != dirty_card) {
90 *byte = dirty_card;
91 Thread* thr = Thread::current();
92 if (thr->is_Java_thread()) {
93 JavaThread* jt = (JavaThread*)thr;
94 jt->dirty_card_queue().enqueue(byte);
95 } else {
96 MutexLockerEx x(Shared_DirtyCardQ_lock,
97 Mutex::_no_safepoint_check_flag);
98 _dcqs.shared_dirty_card_queue()->enqueue(byte);
99 }
100 }
101 }
103 void
104 G1SATBCardTableLoggingModRefBS::write_ref_field_static(void* field,
105 oop new_val) {
106 uintptr_t field_uint = (uintptr_t)field;
107 uintptr_t new_val_uint = (uintptr_t)new_val;
108 uintptr_t comb = field_uint ^ new_val_uint;
109 comb = comb >> HeapRegion::LogOfHRGrainBytes;
110 if (comb == 0) return;
111 if (new_val == NULL) return;
112 // Otherwise, log it.
113 G1SATBCardTableLoggingModRefBS* g1_bs =
114 (G1SATBCardTableLoggingModRefBS*)Universe::heap()->barrier_set();
115 g1_bs->write_ref_field_work(field, new_val);
116 }
118 void
119 G1SATBCardTableLoggingModRefBS::invalidate(MemRegion mr, bool whole_heap) {
120 jbyte* byte = byte_for(mr.start());
121 jbyte* last_byte = byte_for(mr.last());
122 Thread* thr = Thread::current();
123 if (whole_heap) {
124 while (byte <= last_byte) {
125 *byte = dirty_card;
126 byte++;
127 }
128 } else {
129 // Enqueue if necessary.
130 if (thr->is_Java_thread()) {
131 JavaThread* jt = (JavaThread*)thr;
132 while (byte <= last_byte) {
133 if (*byte != dirty_card) {
134 *byte = dirty_card;
135 jt->dirty_card_queue().enqueue(byte);
136 }
137 byte++;
138 }
139 } else {
140 MutexLockerEx x(Shared_DirtyCardQ_lock,
141 Mutex::_no_safepoint_check_flag);
142 while (byte <= last_byte) {
143 if (*byte != dirty_card) {
144 *byte = dirty_card;
145 _dcqs.shared_dirty_card_queue()->enqueue(byte);
146 }
147 byte++;
148 }
149 }
150 }
151 }