src/share/vm/runtime/globals.cpp

changeset 6472
2b8e28fdf503
parent 5790
72b7e96c1922
child 6123
396564992823
equal deleted inserted replaced
6471:3068270ba476 6472:2b8e28fdf503
60 MATERIALIZE_NOTPRODUCT_FLAG) 60 MATERIALIZE_NOTPRODUCT_FLAG)
61 61
62 MATERIALIZE_FLAGS_EXT 62 MATERIALIZE_FLAGS_EXT
63 63
64 64
65 void Flag::check_writable() {
66 if (is_constant_in_binary()) {
67 fatal(err_msg("flag is constant: %s", _name));
68 }
69 }
70
71 bool Flag::is_bool() const {
72 return strcmp(_type, "bool") == 0;
73 }
74
75 bool Flag::get_bool() const {
76 return *((bool*) _addr);
77 }
78
79 void Flag::set_bool(bool value) {
80 check_writable();
81 *((bool*) _addr) = value;
82 }
83
84 bool Flag::is_intx() const {
85 return strcmp(_type, "intx") == 0;
86 }
87
88 intx Flag::get_intx() const {
89 return *((intx*) _addr);
90 }
91
92 void Flag::set_intx(intx value) {
93 check_writable();
94 *((intx*) _addr) = value;
95 }
96
97 bool Flag::is_uintx() const {
98 return strcmp(_type, "uintx") == 0;
99 }
100
101 uintx Flag::get_uintx() const {
102 return *((uintx*) _addr);
103 }
104
105 void Flag::set_uintx(uintx value) {
106 check_writable();
107 *((uintx*) _addr) = value;
108 }
109
110 bool Flag::is_uint64_t() const {
111 return strcmp(_type, "uint64_t") == 0;
112 }
113
114 uint64_t Flag::get_uint64_t() const {
115 return *((uint64_t*) _addr);
116 }
117
118 void Flag::set_uint64_t(uint64_t value) {
119 check_writable();
120 *((uint64_t*) _addr) = value;
121 }
122
123 bool Flag::is_double() const {
124 return strcmp(_type, "double") == 0;
125 }
126
127 double Flag::get_double() const {
128 return *((double*) _addr);
129 }
130
131 void Flag::set_double(double value) {
132 check_writable();
133 *((double*) _addr) = value;
134 }
135
136 bool Flag::is_ccstr() const {
137 return strcmp(_type, "ccstr") == 0 || strcmp(_type, "ccstrlist") == 0;
138 }
139
140 bool Flag::ccstr_accumulates() const {
141 return strcmp(_type, "ccstrlist") == 0;
142 }
143
144 ccstr Flag::get_ccstr() const {
145 return *((ccstr*) _addr);
146 }
147
148 void Flag::set_ccstr(ccstr value) {
149 check_writable();
150 *((ccstr*) _addr) = value;
151 }
152
153
154 Flag::Flags Flag::get_origin() {
155 return Flags(_flags & VALUE_ORIGIN_MASK);
156 }
157
158 void Flag::set_origin(Flags origin) {
159 assert((origin & VALUE_ORIGIN_MASK) == origin, "sanity");
160 _flags = Flags((_flags & ~VALUE_ORIGIN_MASK) | origin);
161 }
162
163 bool Flag::is_default() {
164 return (get_origin() == DEFAULT);
165 }
166
167 bool Flag::is_ergonomic() {
168 return (get_origin() == ERGONOMIC);
169 }
170
171 bool Flag::is_command_line() {
172 return (get_origin() == COMMAND_LINE);
173 }
174
175 bool Flag::is_product() const {
176 return (_flags & KIND_PRODUCT) != 0;
177 }
178
179 bool Flag::is_manageable() const {
180 return (_flags & KIND_MANAGEABLE) != 0;
181 }
182
183 bool Flag::is_diagnostic() const {
184 return (_flags & KIND_DIAGNOSTIC) != 0;
185 }
186
187 bool Flag::is_experimental() const {
188 return (_flags & KIND_EXPERIMENTAL) != 0;
189 }
190
191 bool Flag::is_notproduct() const {
192 return (_flags & KIND_NOT_PRODUCT) != 0;
193 }
194
195 bool Flag::is_develop() const {
196 return (_flags & KIND_DEVELOP) != 0;
197 }
198
199 bool Flag::is_read_write() const {
200 return (_flags & KIND_READ_WRITE) != 0;
201 }
202
203 bool Flag::is_commercial() const {
204 return (_flags & KIND_COMMERCIAL) != 0;
205 }
206
207 /**
208 * Returns if this flag is a constant in the binary. Right now this is
209 * true for notproduct and develop flags in product builds.
210 */
211 bool Flag::is_constant_in_binary() const {
212 #ifdef PRODUCT
213 return is_notproduct() || is_develop();
214 #else
215 return false;
216 #endif
217 }
218
65 bool Flag::is_unlocker() const { 219 bool Flag::is_unlocker() const {
66 return strcmp(name, "UnlockDiagnosticVMOptions") == 0 || 220 return strcmp(_name, "UnlockDiagnosticVMOptions") == 0 ||
67 strcmp(name, "UnlockExperimentalVMOptions") == 0 || 221 strcmp(_name, "UnlockExperimentalVMOptions") == 0 ||
68 is_unlocker_ext(); 222 is_unlocker_ext();
69 } 223 }
70 224
71 bool Flag::is_unlocked() const { 225 bool Flag::is_unlocked() const {
72 if (strcmp(kind, "{diagnostic}") == 0 || 226 if (is_diagnostic()) {
73 strcmp(kind, "{C2 diagnostic}") == 0 ||
74 strcmp(kind, "{ARCH diagnostic}") == 0 ||
75 strcmp(kind, "{Shark diagnostic}") == 0) {
76 return UnlockDiagnosticVMOptions; 227 return UnlockDiagnosticVMOptions;
77 } else if (strcmp(kind, "{experimental}") == 0 || 228 }
78 strcmp(kind, "{C2 experimental}") == 0 || 229 if (is_experimental()) {
79 strcmp(kind, "{ARCH experimental}") == 0 ||
80 strcmp(kind, "{Shark experimental}") == 0) {
81 return UnlockExperimentalVMOptions; 230 return UnlockExperimentalVMOptions;
82 } else { 231 }
83 return is_unlocked_ext(); 232 return is_unlocked_ext();
84 }
85 } 233 }
86 234
87 // Get custom message for this locked flag, or return NULL if 235 // Get custom message for this locked flag, or return NULL if
88 // none is available. 236 // none is available.
89 void Flag::get_locked_message(char* buf, int buflen) const { 237 void Flag::get_locked_message(char* buf, int buflen) const {
90 get_locked_message_ext(buf, buflen); 238 get_locked_message_ext(buf, buflen);
91 } 239 }
92 240
93 bool Flag::is_writeable() const { 241 bool Flag::is_writeable() const {
94 return strcmp(kind, "{manageable}") == 0 || 242 return is_manageable() || (is_product() && is_read_write()) || is_writeable_ext();
95 strcmp(kind, "{product rw}") == 0 ||
96 is_writeable_ext();
97 } 243 }
98 244
99 // All flags except "manageable" are assumed to be internal flags. 245 // All flags except "manageable" are assumed to be internal flags.
100 // Long term, we need to define a mechanism to specify which flags 246 // Long term, we need to define a mechanism to specify which flags
101 // are external/stable and change this function accordingly. 247 // are external/stable and change this function accordingly.
102 bool Flag::is_external() const { 248 bool Flag::is_external() const {
103 return strcmp(kind, "{manageable}") == 0 || is_external_ext(); 249 return is_manageable() || is_external_ext();
104 } 250 }
105 251
106 252
107 // Length of format string (e.g. "%.1234s") for printing ccstr below 253 // Length of format string (e.g. "%.1234s") for printing ccstr below
108 #define FORMAT_BUFFER_LEN 16 254 #define FORMAT_BUFFER_LEN 16
109 255
110 void Flag::print_on(outputStream* st, bool withComments) { 256 void Flag::print_on(outputStream* st, bool withComments) {
111 st->print("%9s %-40s %c= ", type, name, (origin != DEFAULT ? ':' : ' ')); 257 // Don't print notproduct and develop flags in a product build.
112 if (is_bool()) st->print("%-16s", get_bool() ? "true" : "false"); 258 if (is_constant_in_binary()) {
113 if (is_intx()) st->print("%-16ld", get_intx()); 259 return;
114 if (is_uintx()) st->print("%-16lu", get_uintx()); 260 }
115 if (is_uint64_t()) st->print("%-16lu", get_uint64_t()); 261
116 if (is_double()) st->print("%-16f", get_double()); 262 st->print("%9s %-40s %c= ", _type, _name, (!is_default() ? ':' : ' '));
117 263
264 if (is_bool()) {
265 st->print("%-16s", get_bool() ? "true" : "false");
266 }
267 if (is_intx()) {
268 st->print("%-16ld", get_intx());
269 }
270 if (is_uintx()) {
271 st->print("%-16lu", get_uintx());
272 }
273 if (is_uint64_t()) {
274 st->print("%-16lu", get_uint64_t());
275 }
276 if (is_double()) {
277 st->print("%-16f", get_double());
278 }
118 if (is_ccstr()) { 279 if (is_ccstr()) {
119 const char* cp = get_ccstr(); 280 const char* cp = get_ccstr();
120 if (cp != NULL) { 281 if (cp != NULL) {
121 const char* eol; 282 const char* eol;
122 while ((eol = strchr(cp, '\n')) != NULL) { 283 while ((eol = strchr(cp, '\n')) != NULL) {
123 char format_buffer[FORMAT_BUFFER_LEN]; 284 char format_buffer[FORMAT_BUFFER_LEN];
124 size_t llen = pointer_delta(eol, cp, sizeof(char)); 285 size_t llen = pointer_delta(eol, cp, sizeof(char));
125 jio_snprintf(format_buffer, FORMAT_BUFFER_LEN, 286 jio_snprintf(format_buffer, FORMAT_BUFFER_LEN,
126 "%%." SIZE_FORMAT "s", llen); 287 "%%." SIZE_FORMAT "s", llen);
127 st->print(format_buffer, cp); 288 st->print(format_buffer, cp);
128 st->cr(); 289 st->cr();
129 cp = eol+1; 290 cp = eol+1;
130 st->print("%5s %-35s += ", "", name); 291 st->print("%5s %-35s += ", "", _name);
131 } 292 }
132 st->print("%-16s", cp); 293 st->print("%-16s", cp);
133 } 294 }
134 else st->print("%-16s", ""); 295 else st->print("%-16s", "");
135 } 296 }
136 st->print("%-20s", kind); 297
298 st->print("%-20");
299 print_kind(st);
300
137 if (withComments) { 301 if (withComments) {
138 #ifndef PRODUCT 302 #ifndef PRODUCT
139 st->print("%s", doc ); 303 st->print("%s", _doc);
140 #endif 304 #endif
141 } 305 }
142 st->cr(); 306 st->cr();
307 }
308
309 void Flag::print_kind(outputStream* st) {
310 struct Data {
311 int flag;
312 const char* name;
313 };
314
315 Data data[] = {
316 { KIND_C1, "C1" },
317 { KIND_C2, "C2" },
318 { KIND_ARCH, "ARCH" },
319 { KIND_SHARK, "SHARK" },
320 { KIND_PLATFORM_DEPENDENT, "pd" },
321 { KIND_PRODUCT, "product" },
322 { KIND_MANAGEABLE, "manageable" },
323 { KIND_DIAGNOSTIC, "diagnostic" },
324 { KIND_NOT_PRODUCT, "notproduct" },
325 { KIND_DEVELOP, "develop" },
326 { KIND_LP64_PRODUCT, "lp64_product" },
327 { KIND_READ_WRITE, "rw" },
328 { -1, "" }
329 };
330
331 if ((_flags & KIND_MASK) != 0) {
332 st->print("{");
333 bool is_first = true;
334
335 for (int i = 0; data[i].flag != -1; i++) {
336 Data d = data[i];
337 if ((_flags & d.flag) != 0) {
338 if (is_first) {
339 is_first = false;
340 } else {
341 st->print(" ");
342 }
343 st->print(d.name);
344 }
345 }
346
347 st->print("}");
348 }
143 } 349 }
144 350
145 void Flag::print_as_flag(outputStream* st) { 351 void Flag::print_as_flag(outputStream* st) {
146 if (is_bool()) { 352 if (is_bool()) {
147 st->print("-XX:%s%s", get_bool() ? "+" : "-", name); 353 st->print("-XX:%s%s", get_bool() ? "+" : "-", _name);
148 } else if (is_intx()) { 354 } else if (is_intx()) {
149 st->print("-XX:%s=" INTX_FORMAT, name, get_intx()); 355 st->print("-XX:%s=" INTX_FORMAT, _name, get_intx());
150 } else if (is_uintx()) { 356 } else if (is_uintx()) {
151 st->print("-XX:%s=" UINTX_FORMAT, name, get_uintx()); 357 st->print("-XX:%s=" UINTX_FORMAT, _name, get_uintx());
152 } else if (is_uint64_t()) { 358 } else if (is_uint64_t()) {
153 st->print("-XX:%s=" UINT64_FORMAT, name, get_uint64_t()); 359 st->print("-XX:%s=" UINT64_FORMAT, _name, get_uint64_t());
154 } else if (is_double()) { 360 } else if (is_double()) {
155 st->print("-XX:%s=%f", name, get_double()); 361 st->print("-XX:%s=%f", _name, get_double());
156 } else if (is_ccstr()) { 362 } else if (is_ccstr()) {
157 st->print("-XX:%s=", name); 363 st->print("-XX:%s=", _name);
158 const char* cp = get_ccstr(); 364 const char* cp = get_ccstr();
159 if (cp != NULL) { 365 if (cp != NULL) {
160 // Need to turn embedded '\n's back into separate arguments 366 // Need to turn embedded '\n's back into separate arguments
161 // Not so efficient to print one character at a time, 367 // Not so efficient to print one character at a time,
162 // but the choice is to do the transformation to a buffer 368 // but the choice is to do the transformation to a buffer
165 switch (*cp) { 371 switch (*cp) {
166 default: 372 default:
167 st->print("%c", *cp); 373 st->print("%c", *cp);
168 break; 374 break;
169 case '\n': 375 case '\n':
170 st->print(" -XX:%s=", name); 376 st->print(" -XX:%s=", _name);
171 break; 377 break;
172 } 378 }
173 } 379 }
174 } 380 }
175 } else { 381 } else {
178 } 384 }
179 385
180 // 4991491 do not "optimize out" the was_set false values: omitting them 386 // 4991491 do not "optimize out" the was_set false values: omitting them
181 // tickles a Microsoft compiler bug causing flagTable to be malformed 387 // tickles a Microsoft compiler bug causing flagTable to be malformed
182 388
183 #define RUNTIME_PRODUCT_FLAG_STRUCT(type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) "{product}", DEFAULT }, 389 #define NAME(name) NOT_PRODUCT(&name) PRODUCT_ONLY(&CONST_##name)
184 #define RUNTIME_PD_PRODUCT_FLAG_STRUCT(type, name, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) "{pd product}", DEFAULT }, 390
185 #define RUNTIME_DIAGNOSTIC_FLAG_STRUCT(type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) "{diagnostic}", DEFAULT }, 391 #define RUNTIME_PRODUCT_FLAG_STRUCT( type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_PRODUCT) },
186 #define RUNTIME_EXPERIMENTAL_FLAG_STRUCT(type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) "{experimental}", DEFAULT }, 392 #define RUNTIME_PD_PRODUCT_FLAG_STRUCT( type, name, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_PRODUCT | Flag::KIND_PLATFORM_DEPENDENT) },
187 #define RUNTIME_MANAGEABLE_FLAG_STRUCT(type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) "{manageable}", DEFAULT }, 393 #define RUNTIME_DIAGNOSTIC_FLAG_STRUCT( type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_DIAGNOSTIC) },
188 #define RUNTIME_PRODUCT_RW_FLAG_STRUCT(type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) "{product rw}", DEFAULT }, 394 #define RUNTIME_EXPERIMENTAL_FLAG_STRUCT(type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_EXPERIMENTAL) },
189 395 #define RUNTIME_MANAGEABLE_FLAG_STRUCT( type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_MANAGEABLE) },
190 #ifdef PRODUCT 396 #define RUNTIME_PRODUCT_RW_FLAG_STRUCT( type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_PRODUCT | Flag::KIND_READ_WRITE) },
191 #define RUNTIME_DEVELOP_FLAG_STRUCT(type, name, value, doc) /* flag is constant */ 397 #define RUNTIME_DEVELOP_FLAG_STRUCT( type, name, value, doc) { #type, XSTR(name), NAME(name), NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_DEVELOP) },
192 #define RUNTIME_PD_DEVELOP_FLAG_STRUCT(type, name, doc) /* flag is constant */ 398 #define RUNTIME_PD_DEVELOP_FLAG_STRUCT( type, name, doc) { #type, XSTR(name), NAME(name), NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_DEVELOP | Flag::KIND_PLATFORM_DEPENDENT) },
193 #define RUNTIME_NOTPRODUCT_FLAG_STRUCT(type, name, value, doc) 399 #define RUNTIME_NOTPRODUCT_FLAG_STRUCT( type, name, value, doc) { #type, XSTR(name), NAME(name), NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_NOT_PRODUCT) },
400
401 #ifdef _LP64
402 #define RUNTIME_LP64_PRODUCT_FLAG_STRUCT(type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_LP64_PRODUCT) },
194 #else 403 #else
195 #define RUNTIME_DEVELOP_FLAG_STRUCT(type, name, value, doc) { #type, XSTR(name), &name, doc, "", DEFAULT }, 404 #define RUNTIME_LP64_PRODUCT_FLAG_STRUCT(type, name, value, doc) /* flag is constant */
196 #define RUNTIME_PD_DEVELOP_FLAG_STRUCT(type, name, doc) { #type, XSTR(name), &name, doc, "{pd}", DEFAULT },
197 #define RUNTIME_NOTPRODUCT_FLAG_STRUCT(type, name, value, doc) { #type, XSTR(name), &name, doc, "{notproduct}", DEFAULT },
198 #endif
199
200 #ifdef _LP64
201 #define RUNTIME_LP64_PRODUCT_FLAG_STRUCT(type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) "{lp64_product}", DEFAULT },
202 #else
203 #define RUNTIME_LP64_PRODUCT_FLAG_STRUCT(type, name, value, doc) /* flag is constant */
204 #endif // _LP64 405 #endif // _LP64
205 406
206 #define C1_PRODUCT_FLAG_STRUCT(type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) "{C1 product}", DEFAULT }, 407 #define C1_PRODUCT_FLAG_STRUCT( type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_C1 | Flag::KIND_PRODUCT) },
207 #define C1_PD_PRODUCT_FLAG_STRUCT(type, name, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) "{C1 pd product}", DEFAULT }, 408 #define C1_PD_PRODUCT_FLAG_STRUCT( type, name, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_C1 | Flag::KIND_PRODUCT | Flag::KIND_PLATFORM_DEPENDENT) },
208 #ifdef PRODUCT 409 #define C1_DIAGNOSTIC_FLAG_STRUCT( type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_C1 | Flag::KIND_DIAGNOSTIC) },
209 #define C1_DEVELOP_FLAG_STRUCT(type, name, value, doc) /* flag is constant */ 410 #define C1_DEVELOP_FLAG_STRUCT( type, name, value, doc) { #type, XSTR(name), NAME(name), NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_C1 | Flag::KIND_DEVELOP) },
210 #define C1_PD_DEVELOP_FLAG_STRUCT(type, name, doc) /* flag is constant */ 411 #define C1_PD_DEVELOP_FLAG_STRUCT( type, name, doc) { #type, XSTR(name), NAME(name), NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_C1 | Flag::KIND_DEVELOP | Flag::KIND_PLATFORM_DEPENDENT) },
211 #define C1_NOTPRODUCT_FLAG_STRUCT(type, name, value, doc) 412 #define C1_NOTPRODUCT_FLAG_STRUCT( type, name, value, doc) { #type, XSTR(name), NAME(name), NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_C1 | Flag::KIND_NOT_PRODUCT) },
212 #else 413
213 #define C1_DEVELOP_FLAG_STRUCT(type, name, value, doc) { #type, XSTR(name), &name, doc, "{C1}", DEFAULT }, 414 #define C2_PRODUCT_FLAG_STRUCT( type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_C2 | Flag::KIND_PRODUCT) },
214 #define C1_PD_DEVELOP_FLAG_STRUCT(type, name, doc) { #type, XSTR(name), &name, doc, "{C1 pd}", DEFAULT }, 415 #define C2_PD_PRODUCT_FLAG_STRUCT( type, name, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_C2 | Flag::KIND_PRODUCT | Flag::KIND_PLATFORM_DEPENDENT) },
215 #define C1_NOTPRODUCT_FLAG_STRUCT(type, name, value, doc) { #type, XSTR(name), &name, doc, "{C1 notproduct}", DEFAULT }, 416 #define C2_DIAGNOSTIC_FLAG_STRUCT( type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_C2 | Flag::KIND_DIAGNOSTIC) },
216 #endif 417 #define C2_EXPERIMENTAL_FLAG_STRUCT( type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_C2 | Flag::KIND_EXPERIMENTAL) },
217 418 #define C2_DEVELOP_FLAG_STRUCT( type, name, value, doc) { #type, XSTR(name), NAME(name), NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_C2 | Flag::KIND_DEVELOP) },
218 #define C2_PRODUCT_FLAG_STRUCT(type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) "{C2 product}", DEFAULT }, 419 #define C2_PD_DEVELOP_FLAG_STRUCT( type, name, doc) { #type, XSTR(name), NAME(name), NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_C2 | Flag::KIND_DEVELOP | Flag::KIND_PLATFORM_DEPENDENT) },
219 #define C2_PD_PRODUCT_FLAG_STRUCT(type, name, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) "{C2 pd product}", DEFAULT }, 420 #define C2_NOTPRODUCT_FLAG_STRUCT( type, name, value, doc) { #type, XSTR(name), NAME(name), NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_C2 | Flag::KIND_NOT_PRODUCT) },
220 #define C2_DIAGNOSTIC_FLAG_STRUCT(type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) "{C2 diagnostic}", DEFAULT }, 421
221 #define C2_EXPERIMENTAL_FLAG_STRUCT(type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) "{C2 experimental}", DEFAULT }, 422 #define ARCH_PRODUCT_FLAG_STRUCT( type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_ARCH | Flag::KIND_PRODUCT) },
222 #ifdef PRODUCT 423 #define ARCH_DIAGNOSTIC_FLAG_STRUCT( type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_ARCH | Flag::KIND_DIAGNOSTIC) },
223 #define C2_DEVELOP_FLAG_STRUCT(type, name, value, doc) /* flag is constant */ 424 #define ARCH_EXPERIMENTAL_FLAG_STRUCT( type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_ARCH | Flag::KIND_EXPERIMENTAL) },
224 #define C2_PD_DEVELOP_FLAG_STRUCT(type, name, doc) /* flag is constant */ 425 #define ARCH_DEVELOP_FLAG_STRUCT( type, name, value, doc) { #type, XSTR(name), NAME(name), NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_ARCH | Flag::KIND_DEVELOP) },
225 #define C2_NOTPRODUCT_FLAG_STRUCT(type, name, value, doc) 426 #define ARCH_NOTPRODUCT_FLAG_STRUCT( type, name, value, doc) { #type, XSTR(name), NAME(name), NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_ARCH | Flag::KIND_NOT_PRODUCT) },
226 #else 427
227 #define C2_DEVELOP_FLAG_STRUCT(type, name, value, doc) { #type, XSTR(name), &name, doc, "{C2}", DEFAULT }, 428 #define SHARK_PRODUCT_FLAG_STRUCT( type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_SHARK | Flag::KIND_PRODUCT) },
228 #define C2_PD_DEVELOP_FLAG_STRUCT(type, name, doc) { #type, XSTR(name), &name, doc, "{C2 pd}", DEFAULT }, 429 #define SHARK_PD_PRODUCT_FLAG_STRUCT( type, name, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_SHARK | Flag::KIND_PRODUCT | Flag::KIND_PLATFORM_DEPENDENT) },
229 #define C2_NOTPRODUCT_FLAG_STRUCT(type, name, value, doc) { #type, XSTR(name), &name, doc, "{C2 notproduct}", DEFAULT }, 430 #define SHARK_DIAGNOSTIC_FLAG_STRUCT( type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_SHARK | Flag::KIND_DIAGNOSTIC) },
230 #endif 431 #define SHARK_DEVELOP_FLAG_STRUCT( type, name, value, doc) { #type, XSTR(name), NAME(name), NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_SHARK | Flag::KIND_DEVELOP) },
231 432 #define SHARK_PD_DEVELOP_FLAG_STRUCT( type, name, doc) { #type, XSTR(name), NAME(name), NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_SHARK | Flag::KIND_DEVELOP | Flag::KIND_PLATFORM_DEPENDENT) },
232 #define ARCH_PRODUCT_FLAG_STRUCT(type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) "{ARCH product}", DEFAULT }, 433 #define SHARK_NOTPRODUCT_FLAG_STRUCT( type, name, value, doc) { #type, XSTR(name), NAME(name), NOT_PRODUCT_ARG(doc) Flag::Flags(Flag::DEFAULT | Flag::KIND_SHARK | Flag::KIND_NOT_PRODUCT) },
233 #define ARCH_DIAGNOSTIC_FLAG_STRUCT(type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) "{ARCH diagnostic}", DEFAULT },
234 #define ARCH_EXPERIMENTAL_FLAG_STRUCT(type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) "{ARCH experimental}", DEFAULT },
235 #ifdef PRODUCT
236 #define ARCH_DEVELOP_FLAG_STRUCT(type, name, value, doc) /* flag is constant */
237 #define ARCH_NOTPRODUCT_FLAG_STRUCT(type, name, value, doc)
238 #else
239 #define ARCH_DEVELOP_FLAG_STRUCT(type, name, value, doc) { #type, XSTR(name), &name, doc, "{ARCH}", DEFAULT },
240 #define ARCH_NOTPRODUCT_FLAG_STRUCT(type, name, value, doc) { #type, XSTR(name), &name, doc, "{ARCH notproduct}", DEFAULT },
241 #endif
242
243 #define SHARK_PRODUCT_FLAG_STRUCT(type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) "{Shark product}", DEFAULT },
244 #define SHARK_PD_PRODUCT_FLAG_STRUCT(type, name, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) "{Shark pd product}", DEFAULT },
245 #define SHARK_DIAGNOSTIC_FLAG_STRUCT(type, name, value, doc) { #type, XSTR(name), &name, NOT_PRODUCT_ARG(doc) "{Shark diagnostic}", DEFAULT },
246 #ifdef PRODUCT
247 #define SHARK_DEVELOP_FLAG_STRUCT(type, name, value, doc) /* flag is constant */
248 #define SHARK_PD_DEVELOP_FLAG_STRUCT(type, name, doc) /* flag is constant */
249 #define SHARK_NOTPRODUCT_FLAG_STRUCT(type, name, value, doc)
250 #else
251 #define SHARK_DEVELOP_FLAG_STRUCT(type, name, value, doc) { #type, XSTR(name), &name, doc, "{Shark}", DEFAULT },
252 #define SHARK_PD_DEVELOP_FLAG_STRUCT(type, name, doc) { #type, XSTR(name), &name, doc, "{Shark pd}", DEFAULT },
253 #define SHARK_NOTPRODUCT_FLAG_STRUCT(type, name, value, doc) { #type, XSTR(name), &name, doc, "{Shark notproduct}", DEFAULT },
254 #endif
255 434
256 static Flag flagTable[] = { 435 static Flag flagTable[] = {
257 RUNTIME_FLAGS(RUNTIME_DEVELOP_FLAG_STRUCT, RUNTIME_PD_DEVELOP_FLAG_STRUCT, RUNTIME_PRODUCT_FLAG_STRUCT, RUNTIME_PD_PRODUCT_FLAG_STRUCT, RUNTIME_DIAGNOSTIC_FLAG_STRUCT, RUNTIME_EXPERIMENTAL_FLAG_STRUCT, RUNTIME_NOTPRODUCT_FLAG_STRUCT, RUNTIME_MANAGEABLE_FLAG_STRUCT, RUNTIME_PRODUCT_RW_FLAG_STRUCT, RUNTIME_LP64_PRODUCT_FLAG_STRUCT) 436 RUNTIME_FLAGS(RUNTIME_DEVELOP_FLAG_STRUCT, RUNTIME_PD_DEVELOP_FLAG_STRUCT, RUNTIME_PRODUCT_FLAG_STRUCT, RUNTIME_PD_PRODUCT_FLAG_STRUCT, RUNTIME_DIAGNOSTIC_FLAG_STRUCT, RUNTIME_EXPERIMENTAL_FLAG_STRUCT, RUNTIME_NOTPRODUCT_FLAG_STRUCT, RUNTIME_MANAGEABLE_FLAG_STRUCT, RUNTIME_PRODUCT_RW_FLAG_STRUCT, RUNTIME_LP64_PRODUCT_FLAG_STRUCT)
258 RUNTIME_OS_FLAGS(RUNTIME_DEVELOP_FLAG_STRUCT, RUNTIME_PD_DEVELOP_FLAG_STRUCT, RUNTIME_PRODUCT_FLAG_STRUCT, RUNTIME_PD_PRODUCT_FLAG_STRUCT, RUNTIME_DIAGNOSTIC_FLAG_STRUCT, RUNTIME_NOTPRODUCT_FLAG_STRUCT) 437 RUNTIME_OS_FLAGS(RUNTIME_DEVELOP_FLAG_STRUCT, RUNTIME_PD_DEVELOP_FLAG_STRUCT, RUNTIME_PRODUCT_FLAG_STRUCT, RUNTIME_PD_PRODUCT_FLAG_STRUCT, RUNTIME_DIAGNOSTIC_FLAG_STRUCT, RUNTIME_NOTPRODUCT_FLAG_STRUCT)
259 #if INCLUDE_ALL_GCS 438 #if INCLUDE_ALL_GCS
260 G1_FLAGS(RUNTIME_DEVELOP_FLAG_STRUCT, RUNTIME_PD_DEVELOP_FLAG_STRUCT, RUNTIME_PRODUCT_FLAG_STRUCT, RUNTIME_PD_PRODUCT_FLAG_STRUCT, RUNTIME_DIAGNOSTIC_FLAG_STRUCT, RUNTIME_EXPERIMENTAL_FLAG_STRUCT, RUNTIME_NOTPRODUCT_FLAG_STRUCT, RUNTIME_MANAGEABLE_FLAG_STRUCT, RUNTIME_PRODUCT_RW_FLAG_STRUCT) 439 G1_FLAGS(RUNTIME_DEVELOP_FLAG_STRUCT, RUNTIME_PD_DEVELOP_FLAG_STRUCT, RUNTIME_PRODUCT_FLAG_STRUCT, RUNTIME_PD_PRODUCT_FLAG_STRUCT, RUNTIME_DIAGNOSTIC_FLAG_STRUCT, RUNTIME_EXPERIMENTAL_FLAG_STRUCT, RUNTIME_NOTPRODUCT_FLAG_STRUCT, RUNTIME_MANAGEABLE_FLAG_STRUCT, RUNTIME_PRODUCT_RW_FLAG_STRUCT)
261 #endif // INCLUDE_ALL_GCS 440 #endif // INCLUDE_ALL_GCS
262 #ifdef COMPILER1 441 #ifdef COMPILER1
263 C1_FLAGS(C1_DEVELOP_FLAG_STRUCT, C1_PD_DEVELOP_FLAG_STRUCT, C1_PRODUCT_FLAG_STRUCT, C1_PD_PRODUCT_FLAG_STRUCT, C1_NOTPRODUCT_FLAG_STRUCT) 442 C1_FLAGS(C1_DEVELOP_FLAG_STRUCT, C1_PD_DEVELOP_FLAG_STRUCT, C1_PRODUCT_FLAG_STRUCT, C1_PD_PRODUCT_FLAG_STRUCT, C1_DIAGNOSTIC_FLAG_STRUCT, C1_NOTPRODUCT_FLAG_STRUCT)
264 #endif 443 #endif
265 #ifdef COMPILER2 444 #ifdef COMPILER2
266 C2_FLAGS(C2_DEVELOP_FLAG_STRUCT, C2_PD_DEVELOP_FLAG_STRUCT, C2_PRODUCT_FLAG_STRUCT, C2_PD_PRODUCT_FLAG_STRUCT, C2_DIAGNOSTIC_FLAG_STRUCT, C2_EXPERIMENTAL_FLAG_STRUCT, C2_NOTPRODUCT_FLAG_STRUCT) 445 C2_FLAGS(C2_DEVELOP_FLAG_STRUCT, C2_PD_DEVELOP_FLAG_STRUCT, C2_PRODUCT_FLAG_STRUCT, C2_PD_PRODUCT_FLAG_STRUCT, C2_DIAGNOSTIC_FLAG_STRUCT, C2_EXPERIMENTAL_FLAG_STRUCT, C2_NOTPRODUCT_FLAG_STRUCT)
267 #endif 446 #endif
268 #ifdef SHARK 447 #ifdef SHARK
282 return strncmp(s, q, len) == 0; 461 return strncmp(s, q, len) == 0;
283 } 462 }
284 463
285 // Search the flag table for a named flag 464 // Search the flag table for a named flag
286 Flag* Flag::find_flag(const char* name, size_t length, bool allow_locked) { 465 Flag* Flag::find_flag(const char* name, size_t length, bool allow_locked) {
287 for (Flag* current = &flagTable[0]; current->name != NULL; current++) { 466 for (Flag* current = &flagTable[0]; current->_name != NULL; current++) {
288 if (str_equal(current->name, name, length)) { 467 if (str_equal(current->_name, name, length)) {
289 // Found a matching entry. Report locked flags only if allowed. 468 // Found a matching entry.
469 // Don't report notproduct and develop flags in product builds.
470 if (current->is_constant_in_binary()) {
471 return NULL;
472 }
473 // Report locked flags only if allowed.
290 if (!(current->is_unlocked() || current->is_unlocker())) { 474 if (!(current->is_unlocked() || current->is_unlocker())) {
291 if (!allow_locked) { 475 if (!allow_locked) {
292 // disable use of locked flags, e.g. diagnostic, experimental, 476 // disable use of locked flags, e.g. diagnostic, experimental,
293 // commercial... until they are explicitly unlocked 477 // commercial... until they are explicitly unlocked
294 return NULL; 478 return NULL;
324 float VMOptionsFuzzyMatchSimilarity = 0.7f; 508 float VMOptionsFuzzyMatchSimilarity = 0.7f;
325 Flag* match = NULL; 509 Flag* match = NULL;
326 float score; 510 float score;
327 float max_score = -1; 511 float max_score = -1;
328 512
329 for (Flag* current = &flagTable[0]; current->name != NULL; current++) { 513 for (Flag* current = &flagTable[0]; current->_name != NULL; current++) {
330 score = str_similar(current->name, name, length); 514 score = str_similar(current->_name, name, length);
331 if (score > max_score) { 515 if (score > max_score) {
332 max_score = score; 516 max_score = score;
333 match = current; 517 match = current;
334 } 518 }
335 } 519 }
354 } 538 }
355 539
356 bool CommandLineFlagsEx::is_default(CommandLineFlag flag) { 540 bool CommandLineFlagsEx::is_default(CommandLineFlag flag) {
357 assert((size_t)flag < Flag::numFlags, "bad command line flag index"); 541 assert((size_t)flag < Flag::numFlags, "bad command line flag index");
358 Flag* f = &Flag::flags[flag]; 542 Flag* f = &Flag::flags[flag];
359 return (f->origin == DEFAULT); 543 return f->is_default();
360 } 544 }
361 545
362 bool CommandLineFlagsEx::is_ergo(CommandLineFlag flag) { 546 bool CommandLineFlagsEx::is_ergo(CommandLineFlag flag) {
363 assert((size_t)flag < Flag::numFlags, "bad command line flag index"); 547 assert((size_t)flag < Flag::numFlags, "bad command line flag index");
364 Flag* f = &Flag::flags[flag]; 548 Flag* f = &Flag::flags[flag];
365 return (f->origin == ERGONOMIC); 549 return f->is_ergonomic();
366 } 550 }
367 551
368 bool CommandLineFlagsEx::is_cmdline(CommandLineFlag flag) { 552 bool CommandLineFlagsEx::is_cmdline(CommandLineFlag flag) {
369 assert((size_t)flag < Flag::numFlags, "bad command line flag index"); 553 assert((size_t)flag < Flag::numFlags, "bad command line flag index");
370 Flag* f = &Flag::flags[flag]; 554 Flag* f = &Flag::flags[flag];
371 return (f->origin == COMMAND_LINE); 555 return f->is_command_line();
372 } 556 }
373 557
374 bool CommandLineFlags::wasSetOnCmdline(const char* name, bool* value) { 558 bool CommandLineFlags::wasSetOnCmdline(const char* name, bool* value) {
375 Flag* result = Flag::find_flag((char*)name, strlen(name)); 559 Flag* result = Flag::find_flag((char*)name, strlen(name));
376 if (result == NULL) return false; 560 if (result == NULL) return false;
377 *value = (result->origin == COMMAND_LINE); 561 *value = result->is_command_line();
378 return true; 562 return true;
379 } 563 }
380 564
381 bool CommandLineFlags::boolAt(char* name, size_t len, bool* value) { 565 bool CommandLineFlags::boolAt(char* name, size_t len, bool* value) {
382 Flag* result = Flag::find_flag(name, len); 566 Flag* result = Flag::find_flag(name, len);
384 if (!result->is_bool()) return false; 568 if (!result->is_bool()) return false;
385 *value = result->get_bool(); 569 *value = result->get_bool();
386 return true; 570 return true;
387 } 571 }
388 572
389 bool CommandLineFlags::boolAtPut(char* name, size_t len, bool* value, FlagValueOrigin origin) { 573 bool CommandLineFlags::boolAtPut(char* name, size_t len, bool* value, Flag::Flags origin) {
390 Flag* result = Flag::find_flag(name, len); 574 Flag* result = Flag::find_flag(name, len);
391 if (result == NULL) return false; 575 if (result == NULL) return false;
392 if (!result->is_bool()) return false; 576 if (!result->is_bool()) return false;
393 bool old_value = result->get_bool(); 577 bool old_value = result->get_bool();
394 result->set_bool(*value); 578 result->set_bool(*value);
395 *value = old_value; 579 *value = old_value;
396 result->origin = origin; 580 result->set_origin(origin);
397 return true; 581 return true;
398 } 582 }
399 583
400 void CommandLineFlagsEx::boolAtPut(CommandLineFlagWithType flag, bool value, FlagValueOrigin origin) { 584 void CommandLineFlagsEx::boolAtPut(CommandLineFlagWithType flag, bool value, Flag::Flags origin) {
401 Flag* faddr = address_of_flag(flag); 585 Flag* faddr = address_of_flag(flag);
402 guarantee(faddr != NULL && faddr->is_bool(), "wrong flag type"); 586 guarantee(faddr != NULL && faddr->is_bool(), "wrong flag type");
403 faddr->set_bool(value); 587 faddr->set_bool(value);
404 faddr->origin = origin; 588 faddr->set_origin(origin);
405 } 589 }
406 590
407 bool CommandLineFlags::intxAt(char* name, size_t len, intx* value) { 591 bool CommandLineFlags::intxAt(char* name, size_t len, intx* value) {
408 Flag* result = Flag::find_flag(name, len); 592 Flag* result = Flag::find_flag(name, len);
409 if (result == NULL) return false; 593 if (result == NULL) return false;
410 if (!result->is_intx()) return false; 594 if (!result->is_intx()) return false;
411 *value = result->get_intx(); 595 *value = result->get_intx();
412 return true; 596 return true;
413 } 597 }
414 598
415 bool CommandLineFlags::intxAtPut(char* name, size_t len, intx* value, FlagValueOrigin origin) { 599 bool CommandLineFlags::intxAtPut(char* name, size_t len, intx* value, Flag::Flags origin) {
416 Flag* result = Flag::find_flag(name, len); 600 Flag* result = Flag::find_flag(name, len);
417 if (result == NULL) return false; 601 if (result == NULL) return false;
418 if (!result->is_intx()) return false; 602 if (!result->is_intx()) return false;
419 intx old_value = result->get_intx(); 603 intx old_value = result->get_intx();
420 result->set_intx(*value); 604 result->set_intx(*value);
421 *value = old_value; 605 *value = old_value;
422 result->origin = origin; 606 result->set_origin(origin);
423 return true; 607 return true;
424 } 608 }
425 609
426 void CommandLineFlagsEx::intxAtPut(CommandLineFlagWithType flag, intx value, FlagValueOrigin origin) { 610 void CommandLineFlagsEx::intxAtPut(CommandLineFlagWithType flag, intx value, Flag::Flags origin) {
427 Flag* faddr = address_of_flag(flag); 611 Flag* faddr = address_of_flag(flag);
428 guarantee(faddr != NULL && faddr->is_intx(), "wrong flag type"); 612 guarantee(faddr != NULL && faddr->is_intx(), "wrong flag type");
429 faddr->set_intx(value); 613 faddr->set_intx(value);
430 faddr->origin = origin; 614 faddr->set_origin(origin);
431 } 615 }
432 616
433 bool CommandLineFlags::uintxAt(char* name, size_t len, uintx* value) { 617 bool CommandLineFlags::uintxAt(char* name, size_t len, uintx* value) {
434 Flag* result = Flag::find_flag(name, len); 618 Flag* result = Flag::find_flag(name, len);
435 if (result == NULL) return false; 619 if (result == NULL) return false;
436 if (!result->is_uintx()) return false; 620 if (!result->is_uintx()) return false;
437 *value = result->get_uintx(); 621 *value = result->get_uintx();
438 return true; 622 return true;
439 } 623 }
440 624
441 bool CommandLineFlags::uintxAtPut(char* name, size_t len, uintx* value, FlagValueOrigin origin) { 625 bool CommandLineFlags::uintxAtPut(char* name, size_t len, uintx* value, Flag::Flags origin) {
442 Flag* result = Flag::find_flag(name, len); 626 Flag* result = Flag::find_flag(name, len);
443 if (result == NULL) return false; 627 if (result == NULL) return false;
444 if (!result->is_uintx()) return false; 628 if (!result->is_uintx()) return false;
445 uintx old_value = result->get_uintx(); 629 uintx old_value = result->get_uintx();
446 result->set_uintx(*value); 630 result->set_uintx(*value);
447 *value = old_value; 631 *value = old_value;
448 result->origin = origin; 632 result->set_origin(origin);
449 return true; 633 return true;
450 } 634 }
451 635
452 void CommandLineFlagsEx::uintxAtPut(CommandLineFlagWithType flag, uintx value, FlagValueOrigin origin) { 636 void CommandLineFlagsEx::uintxAtPut(CommandLineFlagWithType flag, uintx value, Flag::Flags origin) {
453 Flag* faddr = address_of_flag(flag); 637 Flag* faddr = address_of_flag(flag);
454 guarantee(faddr != NULL && faddr->is_uintx(), "wrong flag type"); 638 guarantee(faddr != NULL && faddr->is_uintx(), "wrong flag type");
455 faddr->set_uintx(value); 639 faddr->set_uintx(value);
456 faddr->origin = origin; 640 faddr->set_origin(origin);
457 } 641 }
458 642
459 bool CommandLineFlags::uint64_tAt(char* name, size_t len, uint64_t* value) { 643 bool CommandLineFlags::uint64_tAt(char* name, size_t len, uint64_t* value) {
460 Flag* result = Flag::find_flag(name, len); 644 Flag* result = Flag::find_flag(name, len);
461 if (result == NULL) return false; 645 if (result == NULL) return false;
462 if (!result->is_uint64_t()) return false; 646 if (!result->is_uint64_t()) return false;
463 *value = result->get_uint64_t(); 647 *value = result->get_uint64_t();
464 return true; 648 return true;
465 } 649 }
466 650
467 bool CommandLineFlags::uint64_tAtPut(char* name, size_t len, uint64_t* value, FlagValueOrigin origin) { 651 bool CommandLineFlags::uint64_tAtPut(char* name, size_t len, uint64_t* value, Flag::Flags origin) {
468 Flag* result = Flag::find_flag(name, len); 652 Flag* result = Flag::find_flag(name, len);
469 if (result == NULL) return false; 653 if (result == NULL) return false;
470 if (!result->is_uint64_t()) return false; 654 if (!result->is_uint64_t()) return false;
471 uint64_t old_value = result->get_uint64_t(); 655 uint64_t old_value = result->get_uint64_t();
472 result->set_uint64_t(*value); 656 result->set_uint64_t(*value);
473 *value = old_value; 657 *value = old_value;
474 result->origin = origin; 658 result->set_origin(origin);
475 return true; 659 return true;
476 } 660 }
477 661
478 void CommandLineFlagsEx::uint64_tAtPut(CommandLineFlagWithType flag, uint64_t value, FlagValueOrigin origin) { 662 void CommandLineFlagsEx::uint64_tAtPut(CommandLineFlagWithType flag, uint64_t value, Flag::Flags origin) {
479 Flag* faddr = address_of_flag(flag); 663 Flag* faddr = address_of_flag(flag);
480 guarantee(faddr != NULL && faddr->is_uint64_t(), "wrong flag type"); 664 guarantee(faddr != NULL && faddr->is_uint64_t(), "wrong flag type");
481 faddr->set_uint64_t(value); 665 faddr->set_uint64_t(value);
482 faddr->origin = origin; 666 faddr->set_origin(origin);
483 } 667 }
484 668
485 bool CommandLineFlags::doubleAt(char* name, size_t len, double* value) { 669 bool CommandLineFlags::doubleAt(char* name, size_t len, double* value) {
486 Flag* result = Flag::find_flag(name, len); 670 Flag* result = Flag::find_flag(name, len);
487 if (result == NULL) return false; 671 if (result == NULL) return false;
488 if (!result->is_double()) return false; 672 if (!result->is_double()) return false;
489 *value = result->get_double(); 673 *value = result->get_double();
490 return true; 674 return true;
491 } 675 }
492 676
493 bool CommandLineFlags::doubleAtPut(char* name, size_t len, double* value, FlagValueOrigin origin) { 677 bool CommandLineFlags::doubleAtPut(char* name, size_t len, double* value, Flag::Flags origin) {
494 Flag* result = Flag::find_flag(name, len); 678 Flag* result = Flag::find_flag(name, len);
495 if (result == NULL) return false; 679 if (result == NULL) return false;
496 if (!result->is_double()) return false; 680 if (!result->is_double()) return false;
497 double old_value = result->get_double(); 681 double old_value = result->get_double();
498 result->set_double(*value); 682 result->set_double(*value);
499 *value = old_value; 683 *value = old_value;
500 result->origin = origin; 684 result->set_origin(origin);
501 return true; 685 return true;
502 } 686 }
503 687
504 void CommandLineFlagsEx::doubleAtPut(CommandLineFlagWithType flag, double value, FlagValueOrigin origin) { 688 void CommandLineFlagsEx::doubleAtPut(CommandLineFlagWithType flag, double value, Flag::Flags origin) {
505 Flag* faddr = address_of_flag(flag); 689 Flag* faddr = address_of_flag(flag);
506 guarantee(faddr != NULL && faddr->is_double(), "wrong flag type"); 690 guarantee(faddr != NULL && faddr->is_double(), "wrong flag type");
507 faddr->set_double(value); 691 faddr->set_double(value);
508 faddr->origin = origin; 692 faddr->set_origin(origin);
509 } 693 }
510 694
511 bool CommandLineFlags::ccstrAt(char* name, size_t len, ccstr* value) { 695 bool CommandLineFlags::ccstrAt(char* name, size_t len, ccstr* value) {
512 Flag* result = Flag::find_flag(name, len); 696 Flag* result = Flag::find_flag(name, len);
513 if (result == NULL) return false; 697 if (result == NULL) return false;
516 return true; 700 return true;
517 } 701 }
518 702
519 // Contract: Flag will make private copy of the incoming value. 703 // Contract: Flag will make private copy of the incoming value.
520 // Outgoing value is always malloc-ed, and caller MUST call free. 704 // Outgoing value is always malloc-ed, and caller MUST call free.
521 bool CommandLineFlags::ccstrAtPut(char* name, size_t len, ccstr* value, FlagValueOrigin origin) { 705 bool CommandLineFlags::ccstrAtPut(char* name, size_t len, ccstr* value, Flag::Flags origin) {
522 Flag* result = Flag::find_flag(name, len); 706 Flag* result = Flag::find_flag(name, len);
523 if (result == NULL) return false; 707 if (result == NULL) return false;
524 if (!result->is_ccstr()) return false; 708 if (!result->is_ccstr()) return false;
525 ccstr old_value = result->get_ccstr(); 709 ccstr old_value = result->get_ccstr();
526 char* new_value = NULL; 710 char* new_value = NULL;
527 if (*value != NULL) { 711 if (*value != NULL) {
528 new_value = NEW_C_HEAP_ARRAY(char, strlen(*value)+1, mtInternal); 712 new_value = NEW_C_HEAP_ARRAY(char, strlen(*value)+1, mtInternal);
529 strcpy(new_value, *value); 713 strcpy(new_value, *value);
530 } 714 }
531 result->set_ccstr(new_value); 715 result->set_ccstr(new_value);
532 if (result->origin == DEFAULT && old_value != NULL) { 716 if (result->is_default() && old_value != NULL) {
533 // Prior value is NOT heap allocated, but was a literal constant. 717 // Prior value is NOT heap allocated, but was a literal constant.
534 char* old_value_to_free = NEW_C_HEAP_ARRAY(char, strlen(old_value)+1, mtInternal); 718 char* old_value_to_free = NEW_C_HEAP_ARRAY(char, strlen(old_value)+1, mtInternal);
535 strcpy(old_value_to_free, old_value); 719 strcpy(old_value_to_free, old_value);
536 old_value = old_value_to_free; 720 old_value = old_value_to_free;
537 } 721 }
538 *value = old_value; 722 *value = old_value;
539 result->origin = origin; 723 result->set_origin(origin);
540 return true; 724 return true;
541 } 725 }
542 726
543 // Contract: Flag will make private copy of the incoming value. 727 // Contract: Flag will make private copy of the incoming value.
544 void CommandLineFlagsEx::ccstrAtPut(CommandLineFlagWithType flag, ccstr value, FlagValueOrigin origin) { 728 void CommandLineFlagsEx::ccstrAtPut(CommandLineFlagWithType flag, ccstr value, Flag::Flags origin) {
545 Flag* faddr = address_of_flag(flag); 729 Flag* faddr = address_of_flag(flag);
546 guarantee(faddr != NULL && faddr->is_ccstr(), "wrong flag type"); 730 guarantee(faddr != NULL && faddr->is_ccstr(), "wrong flag type");
547 ccstr old_value = faddr->get_ccstr(); 731 ccstr old_value = faddr->get_ccstr();
548 char* new_value = NEW_C_HEAP_ARRAY(char, strlen(value)+1, mtInternal); 732 char* new_value = NEW_C_HEAP_ARRAY(char, strlen(value)+1, mtInternal);
549 strcpy(new_value, value); 733 strcpy(new_value, value);
550 faddr->set_ccstr(new_value); 734 faddr->set_ccstr(new_value);
551 if (faddr->origin != DEFAULT && old_value != NULL) { 735 if (!faddr->is_default() && old_value != NULL) {
552 // Prior value is heap allocated so free it. 736 // Prior value is heap allocated so free it.
553 FREE_C_HEAP_ARRAY(char, old_value, mtInternal); 737 FREE_C_HEAP_ARRAY(char, old_value, mtInternal);
554 } 738 }
555 faddr->origin = origin; 739 faddr->set_origin(origin);
556 } 740 }
557 741
558 extern "C" { 742 extern "C" {
559 static int compare_flags(const void* void_a, const void* void_b) { 743 static int compare_flags(const void* void_a, const void* void_b) {
560 return strcmp((*((Flag**) void_a))->name, (*((Flag**) void_b))->name); 744 return strcmp((*((Flag**) void_a))->_name, (*((Flag**) void_b))->_name);
561 } 745 }
562 } 746 }
563 747
564 void CommandLineFlags::printSetFlags(outputStream* out) { 748 void CommandLineFlags::printSetFlags(outputStream* out) {
565 // Print which flags were set on the command line 749 // Print which flags were set on the command line
566 // note: this method is called before the thread structure is in place 750 // note: this method is called before the thread structure is in place
567 // which means resource allocation cannot be used. 751 // which means resource allocation cannot be used.
568 752
569 // Compute size 753 // The last entry is the null entry.
570 int length= 0; 754 const size_t length = Flag::numFlags - 1;
571 while (flagTable[length].name != NULL) length++;
572 755
573 // Sort 756 // Sort
574 Flag** array = NEW_C_HEAP_ARRAY(Flag*, length, mtInternal); 757 Flag** array = NEW_C_HEAP_ARRAY(Flag*, length, mtInternal);
575 for (int index = 0; index < length; index++) { 758 for (size_t i = 0; i < length; i++) {
576 array[index] = &flagTable[index]; 759 array[i] = &flagTable[i];
577 } 760 }
578 qsort(array, length, sizeof(Flag*), compare_flags); 761 qsort(array, length, sizeof(Flag*), compare_flags);
579 762
580 // Print 763 // Print
581 for (int i = 0; i < length; i++) { 764 for (size_t i = 0; i < length; i++) {
582 if (array[i]->origin /* naked field! */) { 765 if (array[i]->get_origin() /* naked field! */) {
583 array[i]->print_as_flag(out); 766 array[i]->print_as_flag(out);
584 out->print(" "); 767 out->print(" ");
585 } 768 }
586 } 769 }
587 out->cr(); 770 out->cr();
600 void CommandLineFlags::printFlags(outputStream* out, bool withComments) { 783 void CommandLineFlags::printFlags(outputStream* out, bool withComments) {
601 // Print the flags sorted by name 784 // Print the flags sorted by name
602 // note: this method is called before the thread structure is in place 785 // note: this method is called before the thread structure is in place
603 // which means resource allocation cannot be used. 786 // which means resource allocation cannot be used.
604 787
605 // Compute size 788 // The last entry is the null entry.
606 int length= 0; 789 const size_t length = Flag::numFlags - 1;
607 while (flagTable[length].name != NULL) length++;
608 790
609 // Sort 791 // Sort
610 Flag** array = NEW_C_HEAP_ARRAY(Flag*, length, mtInternal); 792 Flag** array = NEW_C_HEAP_ARRAY(Flag*, length, mtInternal);
611 for (int index = 0; index < length; index++) { 793 for (size_t i = 0; i < length; i++) {
612 array[index] = &flagTable[index]; 794 array[i] = &flagTable[i];
613 } 795 }
614 qsort(array, length, sizeof(Flag*), compare_flags); 796 qsort(array, length, sizeof(Flag*), compare_flags);
615 797
616 // Print 798 // Print
617 out->print_cr("[Global flags]"); 799 out->print_cr("[Global flags]");
618 for (int i = 0; i < length; i++) { 800 for (size_t i = 0; i < length; i++) {
619 if (array[i]->is_unlocked()) { 801 if (array[i]->is_unlocked()) {
620 array[i]->print_on(out, withComments); 802 array[i]->print_on(out, withComments);
621 } 803 }
622 } 804 }
623 FREE_C_HEAP_ARRAY(Flag*, array, mtInternal); 805 FREE_C_HEAP_ARRAY(Flag*, array, mtInternal);

mercurial