Tue, 10 May 2011 00:33:21 -0700
6883834: ParNew: assert(!_g->to()->is_in_reserved(obj),"Scanning field twice?") with LargeObjects tests
Summary: Fixed process_chunk_boundaries(), used for parallel card scanning when using ParNew/CMS, so as to prevent double-scanning, or worse, non-scanning of imprecisely marked objects exceeding parallel chunk size. Made some sizing parameters for parallel card scanning diagnostic, disabled ParallelGCRetainPLAB, and elaborated and clarified some comments.
Reviewed-by: stefank, johnc
duke@435 | 1 | /* |
jcoomes@2020 | 2 | * Copyright (c) 2007, 2010, Oracle and/or its affiliates. All rights reserved. |
duke@435 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
duke@435 | 4 | * |
duke@435 | 5 | * This code is free software; you can redistribute it and/or modify it |
duke@435 | 6 | * under the terms of the GNU General Public License version 2 only, as |
duke@435 | 7 | * published by the Free Software Foundation. |
duke@435 | 8 | * |
duke@435 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
duke@435 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
duke@435 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
duke@435 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
duke@435 | 13 | * accompanied this code). |
duke@435 | 14 | * |
duke@435 | 15 | * You should have received a copy of the GNU General Public License version |
duke@435 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
duke@435 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
duke@435 | 18 | * |
trims@1907 | 19 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
trims@1907 | 20 | * or visit www.oracle.com if you need additional information or have any |
trims@1907 | 21 | * questions. |
duke@435 | 22 | * |
duke@435 | 23 | */ |
duke@435 | 24 | |
stefank@2314 | 25 | #ifndef SHARE_VM_GC_IMPLEMENTATION_PARNEW_PAROOPCLOSURES_HPP |
stefank@2314 | 26 | #define SHARE_VM_GC_IMPLEMENTATION_PARNEW_PAROOPCLOSURES_HPP |
stefank@2314 | 27 | |
stefank@2314 | 28 | #include "memory/genOopClosures.hpp" |
stefank@2314 | 29 | |
duke@435 | 30 | // Closures for ParNewGeneration |
duke@435 | 31 | |
duke@435 | 32 | class ParScanThreadState; |
duke@435 | 33 | class ParNewGeneration; |
jcoomes@2020 | 34 | typedef Padded<OopTaskQueue> ObjToScanQueue; |
jcoomes@2020 | 35 | typedef GenericTaskQueueSet<ObjToScanQueue> ObjToScanQueueSet; |
duke@435 | 36 | class ParallelTaskTerminator; |
duke@435 | 37 | |
duke@435 | 38 | class ParScanClosure: public OopsInGenClosure { |
coleenp@548 | 39 | protected: |
duke@435 | 40 | ParScanThreadState* _par_scan_state; |
coleenp@548 | 41 | ParNewGeneration* _g; |
coleenp@548 | 42 | HeapWord* _boundary; |
coleenp@548 | 43 | template <class T> void inline par_do_barrier(T* p); |
coleenp@548 | 44 | template <class T> void inline do_oop_work(T* p, |
coleenp@548 | 45 | bool gc_barrier, |
coleenp@548 | 46 | bool root_scan); |
coleenp@548 | 47 | public: |
duke@435 | 48 | ParScanClosure(ParNewGeneration* g, ParScanThreadState* par_scan_state); |
duke@435 | 49 | }; |
duke@435 | 50 | |
duke@435 | 51 | class ParScanWithBarrierClosure: public ParScanClosure { |
coleenp@548 | 52 | public: |
duke@435 | 53 | ParScanWithBarrierClosure(ParNewGeneration* g, |
duke@435 | 54 | ParScanThreadState* par_scan_state) : |
duke@435 | 55 | ParScanClosure(g, par_scan_state) {} |
coleenp@548 | 56 | virtual void do_oop(oop* p); |
coleenp@548 | 57 | virtual void do_oop(narrowOop* p); |
coleenp@548 | 58 | inline void do_oop_nv(oop* p); |
coleenp@548 | 59 | inline void do_oop_nv(narrowOop* p); |
duke@435 | 60 | }; |
duke@435 | 61 | |
duke@435 | 62 | class ParScanWithoutBarrierClosure: public ParScanClosure { |
coleenp@548 | 63 | public: |
duke@435 | 64 | ParScanWithoutBarrierClosure(ParNewGeneration* g, |
duke@435 | 65 | ParScanThreadState* par_scan_state) : |
duke@435 | 66 | ParScanClosure(g, par_scan_state) {} |
coleenp@548 | 67 | virtual void do_oop(oop* p); |
coleenp@548 | 68 | virtual void do_oop(narrowOop* p); |
coleenp@548 | 69 | inline void do_oop_nv(oop* p); |
coleenp@548 | 70 | inline void do_oop_nv(narrowOop* p); |
duke@435 | 71 | }; |
duke@435 | 72 | |
duke@435 | 73 | class ParRootScanWithBarrierTwoGensClosure: public ParScanClosure { |
coleenp@548 | 74 | public: |
duke@435 | 75 | ParRootScanWithBarrierTwoGensClosure(ParNewGeneration* g, |
duke@435 | 76 | ParScanThreadState* par_scan_state) : |
duke@435 | 77 | ParScanClosure(g, par_scan_state) {} |
coleenp@548 | 78 | virtual void do_oop(oop* p); |
coleenp@548 | 79 | virtual void do_oop(narrowOop* p); |
duke@435 | 80 | }; |
duke@435 | 81 | |
duke@435 | 82 | class ParRootScanWithoutBarrierClosure: public ParScanClosure { |
coleenp@548 | 83 | public: |
duke@435 | 84 | ParRootScanWithoutBarrierClosure(ParNewGeneration* g, |
duke@435 | 85 | ParScanThreadState* par_scan_state) : |
duke@435 | 86 | ParScanClosure(g, par_scan_state) {} |
coleenp@548 | 87 | virtual void do_oop(oop* p); |
coleenp@548 | 88 | virtual void do_oop(narrowOop* p); |
duke@435 | 89 | }; |
duke@435 | 90 | |
duke@435 | 91 | class ParScanWeakRefClosure: public ScanWeakRefClosure { |
coleenp@548 | 92 | protected: |
duke@435 | 93 | ParScanThreadState* _par_scan_state; |
coleenp@548 | 94 | template <class T> inline void do_oop_work(T* p); |
coleenp@548 | 95 | public: |
duke@435 | 96 | ParScanWeakRefClosure(ParNewGeneration* g, |
duke@435 | 97 | ParScanThreadState* par_scan_state); |
coleenp@548 | 98 | virtual void do_oop(oop* p); |
coleenp@548 | 99 | virtual void do_oop(narrowOop* p); |
coleenp@548 | 100 | inline void do_oop_nv(oop* p); |
coleenp@548 | 101 | inline void do_oop_nv(narrowOop* p); |
duke@435 | 102 | }; |
duke@435 | 103 | |
duke@435 | 104 | class ParEvacuateFollowersClosure: public VoidClosure { |
coleenp@548 | 105 | private: |
duke@435 | 106 | ParScanThreadState* _par_scan_state; |
duke@435 | 107 | ParScanThreadState* par_scan_state() { return _par_scan_state; } |
duke@435 | 108 | |
duke@435 | 109 | // We want to preserve the specific types here (rather than "OopClosure") |
duke@435 | 110 | // for later de-virtualization of do_oop calls. |
duke@435 | 111 | ParScanWithoutBarrierClosure* _to_space_closure; |
duke@435 | 112 | ParScanWithoutBarrierClosure* to_space_closure() { |
duke@435 | 113 | return _to_space_closure; |
duke@435 | 114 | } |
duke@435 | 115 | ParRootScanWithoutBarrierClosure* _to_space_root_closure; |
duke@435 | 116 | ParRootScanWithoutBarrierClosure* to_space_root_closure() { |
duke@435 | 117 | return _to_space_root_closure; |
duke@435 | 118 | } |
duke@435 | 119 | |
duke@435 | 120 | ParScanWithBarrierClosure* _old_gen_closure; |
duke@435 | 121 | ParScanWithBarrierClosure* old_gen_closure () { |
duke@435 | 122 | return _old_gen_closure; |
duke@435 | 123 | } |
duke@435 | 124 | ParRootScanWithBarrierTwoGensClosure* _old_gen_root_closure; |
duke@435 | 125 | ParRootScanWithBarrierTwoGensClosure* old_gen_root_closure () { |
duke@435 | 126 | return _old_gen_root_closure; |
duke@435 | 127 | } |
duke@435 | 128 | |
duke@435 | 129 | ParNewGeneration* _par_gen; |
duke@435 | 130 | ParNewGeneration* par_gen() { return _par_gen; } |
duke@435 | 131 | |
duke@435 | 132 | ObjToScanQueueSet* _task_queues; |
duke@435 | 133 | ObjToScanQueueSet* task_queues() { return _task_queues; } |
duke@435 | 134 | |
duke@435 | 135 | ParallelTaskTerminator* _terminator; |
duke@435 | 136 | ParallelTaskTerminator* terminator() { return _terminator; } |
coleenp@548 | 137 | public: |
duke@435 | 138 | ParEvacuateFollowersClosure( |
duke@435 | 139 | ParScanThreadState* par_scan_state_, |
duke@435 | 140 | ParScanWithoutBarrierClosure* to_space_closure_, |
duke@435 | 141 | ParScanWithBarrierClosure* old_gen_closure_, |
duke@435 | 142 | ParRootScanWithoutBarrierClosure* to_space_root_closure_, |
duke@435 | 143 | ParNewGeneration* par_gen_, |
duke@435 | 144 | ParRootScanWithBarrierTwoGensClosure* old_gen_root_closure_, |
duke@435 | 145 | ObjToScanQueueSet* task_queues_, |
duke@435 | 146 | ParallelTaskTerminator* terminator_); |
coleenp@548 | 147 | virtual void do_void(); |
duke@435 | 148 | }; |
stefank@2314 | 149 | |
stefank@2314 | 150 | #endif // SHARE_VM_GC_IMPLEMENTATION_PARNEW_PAROOPCLOSURES_HPP |