Wed, 02 Nov 2011 08:04:23 +0100
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
Summary: _cset_rs_update_cl[] was indexed with values beyond what it is set up to handle.
Reviewed-by: ysr, jmasa, johnc
jmasa@2821 | 1 | /* |
jmasa@2821 | 2 | * Copyright (c) 2011, Oracle and/or its affiliates. All rights reserved. |
jmasa@2821 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
jmasa@2821 | 4 | * |
jmasa@2821 | 5 | * This code is free software; you can redistribute it and/or modify it |
jmasa@2821 | 6 | * under the terms of the GNU General Public License version 2 only, as |
jmasa@2821 | 7 | * published by the Free Software Foundation. |
jmasa@2821 | 8 | * |
jmasa@2821 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
jmasa@2821 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
jmasa@2821 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
jmasa@2821 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
jmasa@2821 | 13 | * accompanied this code). |
jmasa@2821 | 14 | * |
jmasa@2821 | 15 | * You should have received a copy of the GNU General Public License version |
jmasa@2821 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
jmasa@2821 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
jmasa@2821 | 18 | * |
jmasa@2821 | 19 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
jmasa@2821 | 20 | * or visit www.oracle.com if you need additional information or have any |
jmasa@2821 | 21 | * questions. |
jmasa@2821 | 22 | * |
jmasa@2821 | 23 | */ |
jmasa@2821 | 24 | |
jmasa@2821 | 25 | #include "precompiled.hpp" |
jmasa@2821 | 26 | #include "gc_implementation/g1/g1MonitoringSupport.hpp" |
jmasa@2821 | 27 | #include "gc_implementation/g1/g1CollectedHeap.inline.hpp" |
jmasa@2821 | 28 | #include "gc_implementation/g1/g1CollectorPolicy.hpp" |
jmasa@2821 | 29 | |
tonyp@3176 | 30 | G1GenerationCounters::G1GenerationCounters(G1MonitoringSupport* g1mm, |
tonyp@3176 | 31 | const char* name, |
tonyp@3176 | 32 | int ordinal, int spaces, |
tonyp@3176 | 33 | size_t min_capacity, |
tonyp@3176 | 34 | size_t max_capacity, |
tonyp@3176 | 35 | size_t curr_capacity) |
tonyp@3176 | 36 | : GenerationCounters(name, ordinal, spaces, min_capacity, |
tonyp@3176 | 37 | max_capacity, curr_capacity), _g1mm(g1mm) { } |
tonyp@3176 | 38 | |
tonyp@3176 | 39 | // We pad the capacity three times given that the young generation |
tonyp@3176 | 40 | // contains three spaces (eden and two survivors). |
tonyp@3176 | 41 | G1YoungGenerationCounters::G1YoungGenerationCounters(G1MonitoringSupport* g1mm, |
tonyp@3176 | 42 | const char* name) |
tonyp@3176 | 43 | : G1GenerationCounters(g1mm, name, 0 /* ordinal */, 3 /* spaces */, |
tonyp@3176 | 44 | G1MonitoringSupport::pad_capacity(0, 3) /* min_capacity */, |
tonyp@3176 | 45 | G1MonitoringSupport::pad_capacity(g1mm->young_gen_max(), 3), |
tonyp@3176 | 46 | G1MonitoringSupport::pad_capacity(0, 3) /* curr_capacity */) { |
tonyp@3176 | 47 | update_all(); |
tonyp@3176 | 48 | } |
tonyp@3176 | 49 | |
tonyp@3176 | 50 | G1OldGenerationCounters::G1OldGenerationCounters(G1MonitoringSupport* g1mm, |
tonyp@3176 | 51 | const char* name) |
tonyp@3176 | 52 | : G1GenerationCounters(g1mm, name, 1 /* ordinal */, 1 /* spaces */, |
tonyp@3176 | 53 | G1MonitoringSupport::pad_capacity(0) /* min_capacity */, |
tonyp@3176 | 54 | G1MonitoringSupport::pad_capacity(g1mm->old_gen_max()), |
tonyp@3176 | 55 | G1MonitoringSupport::pad_capacity(0) /* curr_capacity */) { |
tonyp@3176 | 56 | update_all(); |
tonyp@3176 | 57 | } |
tonyp@3176 | 58 | |
tonyp@3176 | 59 | void G1YoungGenerationCounters::update_all() { |
tonyp@3176 | 60 | size_t committed = |
tonyp@3176 | 61 | G1MonitoringSupport::pad_capacity(_g1mm->young_gen_committed(), 3); |
tonyp@3176 | 62 | _current_size->set_value(committed); |
tonyp@3176 | 63 | } |
tonyp@3176 | 64 | |
tonyp@3176 | 65 | void G1OldGenerationCounters::update_all() { |
tonyp@3176 | 66 | size_t committed = |
tonyp@3176 | 67 | G1MonitoringSupport::pad_capacity(_g1mm->old_gen_committed()); |
tonyp@3176 | 68 | _current_size->set_value(committed); |
tonyp@3176 | 69 | } |
tonyp@3176 | 70 | |
tonyp@3176 | 71 | G1MonitoringSupport::G1MonitoringSupport(G1CollectedHeap* g1h) : |
jmasa@2821 | 72 | _g1h(g1h), |
jmasa@2821 | 73 | _incremental_collection_counters(NULL), |
jmasa@2821 | 74 | _full_collection_counters(NULL), |
tonyp@3176 | 75 | _old_collection_counters(NULL), |
jmasa@2821 | 76 | _old_space_counters(NULL), |
jmasa@2821 | 77 | _young_collection_counters(NULL), |
jmasa@2821 | 78 | _eden_counters(NULL), |
jmasa@2821 | 79 | _from_counters(NULL), |
jmasa@2821 | 80 | _to_counters(NULL), |
tonyp@3176 | 81 | |
tonyp@3176 | 82 | _overall_reserved(0), |
tonyp@3176 | 83 | _overall_committed(0), _overall_used(0), |
tonyp@3176 | 84 | _young_region_num(0), |
tonyp@3176 | 85 | _young_gen_committed(0), |
tonyp@3176 | 86 | _eden_committed(0), _eden_used(0), |
tonyp@3176 | 87 | _survivor_committed(0), _survivor_used(0), |
tonyp@3176 | 88 | _old_committed(0), _old_used(0) { |
tonyp@3176 | 89 | |
tonyp@3176 | 90 | _overall_reserved = g1h->max_capacity(); |
tonyp@3176 | 91 | recalculate_sizes(); |
tonyp@3176 | 92 | |
jmasa@2821 | 93 | // Counters for GC collections |
jmasa@2821 | 94 | // |
jmasa@2821 | 95 | // name "collector.0". In a generational collector this would be the |
jmasa@2821 | 96 | // young generation collection. |
jmasa@2821 | 97 | _incremental_collection_counters = |
jmasa@2821 | 98 | new CollectorCounters("G1 incremental collections", 0); |
jmasa@2821 | 99 | // name "collector.1". In a generational collector this would be the |
jmasa@2821 | 100 | // old generation collection. |
jmasa@2821 | 101 | _full_collection_counters = |
jmasa@2821 | 102 | new CollectorCounters("G1 stop-the-world full collections", 1); |
jmasa@2821 | 103 | |
jmasa@2821 | 104 | // timer sampling for all counters supporting sampling only update the |
jmasa@2821 | 105 | // used value. See the take_sample() method. G1 requires both used and |
jmasa@2821 | 106 | // capacity updated so sampling is not currently used. It might |
jmasa@2821 | 107 | // be sufficient to update all counters in take_sample() even though |
jmasa@2821 | 108 | // take_sample() only returns "used". When sampling was used, there |
jmasa@2821 | 109 | // were some anomolous values emitted which may have been the consequence |
jmasa@2821 | 110 | // of not updating all values simultaneously (i.e., see the calculation done |
jmasa@2821 | 111 | // in eden_space_used(), is it possbile that the values used to |
jmasa@2821 | 112 | // calculate either eden_used or survivor_used are being updated by |
jmasa@2821 | 113 | // the collector when the sample is being done?). |
jmasa@2821 | 114 | const bool sampled = false; |
jmasa@2821 | 115 | |
jmasa@2821 | 116 | // "Generation" and "Space" counters. |
jmasa@2821 | 117 | // |
jmasa@2821 | 118 | // name "generation.1" This is logically the old generation in |
jmasa@2821 | 119 | // generational GC terms. The "1, 1" parameters are for |
jmasa@2821 | 120 | // the n-th generation (=1) with 1 space. |
jmasa@2821 | 121 | // Counters are created from minCapacity, maxCapacity, and capacity |
tonyp@3176 | 122 | _old_collection_counters = new G1OldGenerationCounters(this, "old"); |
jmasa@2821 | 123 | |
jmasa@2821 | 124 | // name "generation.1.space.0" |
jmasa@2821 | 125 | // Counters are created from maxCapacity, capacity, initCapacity, |
jmasa@2821 | 126 | // and used. |
tonyp@3176 | 127 | _old_space_counters = new HSpaceCounters("space", 0 /* ordinal */, |
tonyp@3176 | 128 | pad_capacity(overall_reserved()) /* max_capacity */, |
tonyp@3176 | 129 | pad_capacity(old_space_committed()) /* init_capacity */, |
tonyp@3176 | 130 | _old_collection_counters); |
jmasa@2821 | 131 | |
jmasa@2821 | 132 | // Young collection set |
jmasa@2821 | 133 | // name "generation.0". This is logically the young generation. |
jmasa@2821 | 134 | // The "0, 3" are paremeters for the n-th genertaion (=0) with 3 spaces. |
tonyp@3176 | 135 | // See _old_collection_counters for additional counters |
tonyp@3176 | 136 | _young_collection_counters = new G1YoungGenerationCounters(this, "young"); |
jmasa@2821 | 137 | |
jmasa@2821 | 138 | // name "generation.0.space.0" |
jmasa@2821 | 139 | // See _old_space_counters for additional counters |
tonyp@3176 | 140 | _eden_counters = new HSpaceCounters("eden", 0 /* ordinal */, |
tonyp@3176 | 141 | pad_capacity(overall_reserved()) /* max_capacity */, |
tonyp@3176 | 142 | pad_capacity(eden_space_committed()) /* init_capacity */, |
jmasa@2821 | 143 | _young_collection_counters); |
jmasa@2821 | 144 | |
jmasa@2821 | 145 | // name "generation.0.space.1" |
jmasa@2821 | 146 | // See _old_space_counters for additional counters |
jmasa@2821 | 147 | // Set the arguments to indicate that this survivor space is not used. |
tonyp@3176 | 148 | _from_counters = new HSpaceCounters("s0", 1 /* ordinal */, |
tonyp@3176 | 149 | pad_capacity(0) /* max_capacity */, |
tonyp@3176 | 150 | pad_capacity(0) /* init_capacity */, |
jmasa@2821 | 151 | _young_collection_counters); |
tonyp@3176 | 152 | // Given that this survivor space is not used, we update it here |
tonyp@3176 | 153 | // once to reflect that its used space is 0 so that we don't have to |
tonyp@3176 | 154 | // worry about updating it again later. |
tonyp@3176 | 155 | _from_counters->update_used(0); |
jmasa@2821 | 156 | |
jmasa@2821 | 157 | // name "generation.0.space.2" |
jmasa@2821 | 158 | // See _old_space_counters for additional counters |
tonyp@3176 | 159 | _to_counters = new HSpaceCounters("s1", 2 /* ordinal */, |
tonyp@3176 | 160 | pad_capacity(overall_reserved()) /* max_capacity */, |
tonyp@3176 | 161 | pad_capacity(survivor_space_committed()) /* init_capacity */, |
jmasa@2821 | 162 | _young_collection_counters); |
jmasa@2821 | 163 | } |
jmasa@2821 | 164 | |
tonyp@3176 | 165 | void G1MonitoringSupport::recalculate_sizes() { |
tonyp@3176 | 166 | G1CollectedHeap* g1 = g1h(); |
tonyp@3176 | 167 | |
tonyp@3176 | 168 | // Recalculate all the sizes from scratch. We assume that this is |
tonyp@3176 | 169 | // called at a point where no concurrent updates to the various |
tonyp@3176 | 170 | // values we read here are possible (i.e., at a STW phase at the end |
tonyp@3176 | 171 | // of a GC). |
tonyp@3176 | 172 | |
tonyp@3176 | 173 | size_t young_list_length = g1->young_list()->length(); |
tonyp@3176 | 174 | size_t survivor_list_length = g1->g1_policy()->recorded_survivor_regions(); |
tonyp@3176 | 175 | assert(young_list_length >= survivor_list_length, "invariant"); |
tonyp@3176 | 176 | size_t eden_list_length = young_list_length - survivor_list_length; |
tonyp@3176 | 177 | // Max length includes any potential extensions to the young gen |
tonyp@3176 | 178 | // we'll do when the GC locker is active. |
tonyp@3176 | 179 | size_t young_list_max_length = g1->g1_policy()->young_list_max_length(); |
tonyp@3176 | 180 | assert(young_list_max_length >= survivor_list_length, "invariant"); |
tonyp@3176 | 181 | size_t eden_list_max_length = young_list_max_length - survivor_list_length; |
tonyp@3176 | 182 | |
tonyp@3176 | 183 | _overall_used = g1->used_unlocked(); |
tonyp@3176 | 184 | _eden_used = eden_list_length * HeapRegion::GrainBytes; |
tonyp@3176 | 185 | _survivor_used = survivor_list_length * HeapRegion::GrainBytes; |
tonyp@3176 | 186 | _young_region_num = young_list_length; |
tonyp@3176 | 187 | _old_used = subtract_up_to_zero(_overall_used, _eden_used + _survivor_used); |
tonyp@3176 | 188 | |
tonyp@3176 | 189 | // First calculate the committed sizes that can be calculated independently. |
tonyp@3176 | 190 | _survivor_committed = _survivor_used; |
tonyp@3176 | 191 | _old_committed = HeapRegion::align_up_to_region_byte_size(_old_used); |
tonyp@3176 | 192 | |
tonyp@3176 | 193 | // Next, start with the overall committed size. |
tonyp@3176 | 194 | _overall_committed = g1->capacity(); |
tonyp@3176 | 195 | size_t committed = _overall_committed; |
tonyp@3176 | 196 | |
tonyp@3176 | 197 | // Remove the committed size we have calculated so far (for the |
tonyp@3176 | 198 | // survivor and old space). |
tonyp@3176 | 199 | assert(committed >= (_survivor_committed + _old_committed), "sanity"); |
tonyp@3176 | 200 | committed -= _survivor_committed + _old_committed; |
tonyp@3176 | 201 | |
tonyp@3176 | 202 | // Next, calculate and remove the committed size for the eden. |
tonyp@3176 | 203 | _eden_committed = eden_list_max_length * HeapRegion::GrainBytes; |
tonyp@3176 | 204 | // Somewhat defensive: be robust in case there are inaccuracies in |
tonyp@3176 | 205 | // the calculations |
tonyp@3176 | 206 | _eden_committed = MIN2(_eden_committed, committed); |
tonyp@3176 | 207 | committed -= _eden_committed; |
tonyp@3176 | 208 | |
tonyp@3176 | 209 | // Finally, give the rest to the old space... |
tonyp@3176 | 210 | _old_committed += committed; |
tonyp@3176 | 211 | // ..and calculate the young gen committed. |
tonyp@3176 | 212 | _young_gen_committed = _eden_committed + _survivor_committed; |
tonyp@3176 | 213 | |
tonyp@3176 | 214 | assert(_overall_committed == |
tonyp@3176 | 215 | (_eden_committed + _survivor_committed + _old_committed), |
tonyp@3176 | 216 | "the committed sizes should add up"); |
tonyp@3176 | 217 | // Somewhat defensive: cap the eden used size to make sure it |
tonyp@3176 | 218 | // never exceeds the committed size. |
tonyp@3176 | 219 | _eden_used = MIN2(_eden_used, _eden_committed); |
tonyp@3176 | 220 | // _survivor_committed and _old_committed are calculated in terms of |
tonyp@3176 | 221 | // the corresponding _*_used value, so the next two conditions |
tonyp@3176 | 222 | // should hold. |
tonyp@3176 | 223 | assert(_survivor_used <= _survivor_committed, "post-condition"); |
tonyp@3176 | 224 | assert(_old_used <= _old_committed, "post-condition"); |
jmasa@2821 | 225 | } |
jmasa@2821 | 226 | |
tonyp@3176 | 227 | void G1MonitoringSupport::recalculate_eden_size() { |
tonyp@3176 | 228 | G1CollectedHeap* g1 = g1h(); |
jmasa@2821 | 229 | |
tonyp@3176 | 230 | // When a new eden region is allocated, only the eden_used size is |
tonyp@3176 | 231 | // affected (since we have recalculated everything else at the last GC). |
jmasa@2821 | 232 | |
tonyp@3176 | 233 | size_t young_region_num = g1h()->young_list()->length(); |
tonyp@3176 | 234 | if (young_region_num > _young_region_num) { |
tonyp@3176 | 235 | size_t diff = young_region_num - _young_region_num; |
tonyp@3176 | 236 | _eden_used += diff * HeapRegion::GrainBytes; |
tonyp@3176 | 237 | // Somewhat defensive: cap the eden used size to make sure it |
tonyp@3176 | 238 | // never exceeds the committed size. |
tonyp@3176 | 239 | _eden_used = MIN2(_eden_used, _eden_committed); |
tonyp@3176 | 240 | _young_region_num = young_region_num; |
jmasa@2821 | 241 | } |
jmasa@2821 | 242 | } |
jmasa@2821 | 243 | |
tonyp@3176 | 244 | void G1MonitoringSupport::update_sizes() { |
tonyp@3176 | 245 | recalculate_sizes(); |
jmasa@2821 | 246 | if (UsePerfData) { |
tonyp@3176 | 247 | eden_counters()->update_capacity(pad_capacity(eden_space_committed())); |
tonyp@3176 | 248 | eden_counters()->update_used(eden_space_used()); |
tonyp@3176 | 249 | // only the to survivor space (s1) is active, so we don't need to |
tonyp@3176 | 250 | // update the counteres for the from survivor space (s0) |
tonyp@3176 | 251 | to_counters()->update_capacity(pad_capacity(survivor_space_committed())); |
tonyp@3176 | 252 | to_counters()->update_used(survivor_space_used()); |
tonyp@3176 | 253 | old_space_counters()->update_capacity(pad_capacity(old_space_committed())); |
tonyp@3176 | 254 | old_space_counters()->update_used(old_space_used()); |
tonyp@3176 | 255 | old_collection_counters()->update_all(); |
tonyp@3176 | 256 | young_collection_counters()->update_all(); |
tonyp@3176 | 257 | } |
tonyp@3176 | 258 | } |
tonyp@3176 | 259 | |
tonyp@3176 | 260 | void G1MonitoringSupport::update_eden_size() { |
tonyp@3176 | 261 | recalculate_eden_size(); |
tonyp@3176 | 262 | if (UsePerfData) { |
jmasa@2821 | 263 | eden_counters()->update_used(eden_space_used()); |
jmasa@2821 | 264 | } |
jmasa@2821 | 265 | } |