src/share/vm/opto/stringopts.cpp

Mon, 04 Jan 2010 18:38:08 +0100

author
twisti
date
Mon, 04 Jan 2010 18:38:08 +0100
changeset 1570
e66fd840cb6b
parent 1515
7c57aead6d3e
child 1685
3f5b7efb9642
permissions
-rw-r--r--

6893081: method handle & invokedynamic code needs additional cleanup (post 6815692, 6858164)
Summary: During the work for 6829187 we have fixed a number of basic bugs which are logically grouped with 6815692 and 6858164 but which must be reviewed and pushed separately.
Reviewed-by: kvn, never

never@1515 1 /*
never@1515 2 * Copyright 2009 Sun Microsystems, Inc. All Rights Reserved.
never@1515 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
never@1515 4 *
never@1515 5 * This code is free software; you can redistribute it and/or modify it
never@1515 6 * under the terms of the GNU General Public License version 2 only, as
never@1515 7 * published by the Free Software Foundation.
never@1515 8 *
never@1515 9 * This code is distributed in the hope that it will be useful, but WITHOUT
never@1515 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
never@1515 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
never@1515 12 * version 2 for more details (a copy is included in the LICENSE file that
never@1515 13 * accompanied this code).
never@1515 14 *
never@1515 15 * You should have received a copy of the GNU General Public License version
never@1515 16 * 2 along with this work; if not, write to the Free Software Foundation,
never@1515 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
never@1515 18 *
never@1515 19 * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
never@1515 20 * CA 95054 USA or visit www.sun.com if you need additional information or
never@1515 21 * have any questions.
never@1515 22 *
never@1515 23 */
never@1515 24
never@1515 25 #include "incls/_precompiled.incl"
never@1515 26 #include "incls/_stringopts.cpp.incl"
never@1515 27
never@1515 28 #define __ kit.
never@1515 29
never@1515 30 class StringConcat : public ResourceObj {
never@1515 31 private:
never@1515 32 PhaseStringOpts* _stringopts;
never@1515 33 Node* _string_alloc;
never@1515 34 AllocateNode* _begin; // The allocation the begins the pattern
never@1515 35 CallStaticJavaNode* _end; // The final call of the pattern. Will either be
never@1515 36 // SB.toString or or String.<init>(SB.toString)
never@1515 37 bool _multiple; // indicates this is a fusion of two or more
never@1515 38 // separate StringBuilders
never@1515 39
never@1515 40 Node* _arguments; // The list of arguments to be concatenated
never@1515 41 GrowableArray<int> _mode; // into a String along with a mode flag
never@1515 42 // indicating how to treat the value.
never@1515 43
never@1515 44 Node_List _control; // List of control nodes that will be deleted
never@1515 45 Node_List _uncommon_traps; // Uncommon traps that needs to be rewritten
never@1515 46 // to restart at the initial JVMState.
never@1515 47 public:
never@1515 48 // Mode for converting arguments to Strings
never@1515 49 enum {
never@1515 50 StringMode,
never@1515 51 IntMode,
never@1515 52 CharMode
never@1515 53 };
never@1515 54
never@1515 55 StringConcat(PhaseStringOpts* stringopts, CallStaticJavaNode* end):
never@1515 56 _end(end),
never@1515 57 _begin(NULL),
never@1515 58 _multiple(false),
never@1515 59 _string_alloc(NULL),
never@1515 60 _stringopts(stringopts) {
never@1515 61 _arguments = new (_stringopts->C, 1) Node(1);
never@1515 62 _arguments->del_req(0);
never@1515 63 }
never@1515 64
never@1515 65 bool validate_control_flow();
never@1515 66
never@1515 67 void merge_add() {
never@1515 68 #if 0
never@1515 69 // XXX This is place holder code for reusing an existing String
never@1515 70 // allocation but the logic for checking the state safety is
never@1515 71 // probably inadequate at the moment.
never@1515 72 CallProjections endprojs;
never@1515 73 sc->end()->extract_projections(&endprojs, false);
never@1515 74 if (endprojs.resproj != NULL) {
never@1515 75 for (SimpleDUIterator i(endprojs.resproj); i.has_next(); i.next()) {
never@1515 76 CallStaticJavaNode *use = i.get()->isa_CallStaticJava();
never@1515 77 if (use != NULL && use->method() != NULL &&
never@1515 78 use->method()->holder() == C->env()->String_klass() &&
never@1515 79 use->method()->name() == ciSymbol::object_initializer_name() &&
never@1515 80 use->in(TypeFunc::Parms + 1) == endprojs.resproj) {
never@1515 81 // Found useless new String(sb.toString()) so reuse the newly allocated String
never@1515 82 // when creating the result instead of allocating a new one.
never@1515 83 sc->set_string_alloc(use->in(TypeFunc::Parms));
never@1515 84 sc->set_end(use);
never@1515 85 }
never@1515 86 }
never@1515 87 }
never@1515 88 #endif
never@1515 89 }
never@1515 90
never@1515 91 StringConcat* merge(StringConcat* other, Node* arg);
never@1515 92
never@1515 93 void set_allocation(AllocateNode* alloc) {
never@1515 94 _begin = alloc;
never@1515 95 }
never@1515 96
never@1515 97 void append(Node* value, int mode) {
never@1515 98 _arguments->add_req(value);
never@1515 99 _mode.append(mode);
never@1515 100 }
never@1515 101 void push(Node* value, int mode) {
never@1515 102 _arguments->ins_req(0, value);
never@1515 103 _mode.insert_before(0, mode);
never@1515 104 }
never@1515 105 void push_string(Node* value) {
never@1515 106 push(value, StringMode);
never@1515 107 }
never@1515 108 void push_int(Node* value) {
never@1515 109 push(value, IntMode);
never@1515 110 }
never@1515 111 void push_char(Node* value) {
never@1515 112 push(value, CharMode);
never@1515 113 }
never@1515 114
never@1515 115 Node* argument(int i) {
never@1515 116 return _arguments->in(i);
never@1515 117 }
never@1515 118 void set_argument(int i, Node* value) {
never@1515 119 _arguments->set_req(i, value);
never@1515 120 }
never@1515 121 int num_arguments() {
never@1515 122 return _mode.length();
never@1515 123 }
never@1515 124 int mode(int i) {
never@1515 125 return _mode.at(i);
never@1515 126 }
never@1515 127 void add_control(Node* ctrl) {
never@1515 128 assert(!_control.contains(ctrl), "only push once");
never@1515 129 _control.push(ctrl);
never@1515 130 }
never@1515 131 CallStaticJavaNode* end() { return _end; }
never@1515 132 AllocateNode* begin() { return _begin; }
never@1515 133 Node* string_alloc() { return _string_alloc; }
never@1515 134
never@1515 135 void eliminate_unneeded_control();
never@1515 136 void eliminate_initialize(InitializeNode* init);
never@1515 137 void eliminate_call(CallNode* call);
never@1515 138
never@1515 139 void maybe_log_transform() {
never@1515 140 CompileLog* log = _stringopts->C->log();
never@1515 141 if (log != NULL) {
never@1515 142 log->head("replace_string_concat arguments='%d' string_alloc='%d' multiple='%d'",
never@1515 143 num_arguments(),
never@1515 144 _string_alloc != NULL,
never@1515 145 _multiple);
never@1515 146 JVMState* p = _begin->jvms();
never@1515 147 while (p != NULL) {
never@1515 148 log->elem("jvms bci='%d' method='%d'", p->bci(), log->identify(p->method()));
never@1515 149 p = p->caller();
never@1515 150 }
never@1515 151 log->tail("replace_string_concat");
never@1515 152 }
never@1515 153 }
never@1515 154
never@1515 155 void convert_uncommon_traps(GraphKit& kit, const JVMState* jvms) {
never@1515 156 for (uint u = 0; u < _uncommon_traps.size(); u++) {
never@1515 157 Node* uct = _uncommon_traps.at(u);
never@1515 158
never@1515 159 // Build a new call using the jvms state of the allocate
never@1515 160 address call_addr = SharedRuntime::uncommon_trap_blob()->instructions_begin();
never@1515 161 const TypeFunc* call_type = OptoRuntime::uncommon_trap_Type();
never@1515 162 int size = call_type->domain()->cnt();
never@1515 163 const TypePtr* no_memory_effects = NULL;
never@1515 164 Compile* C = _stringopts->C;
never@1515 165 CallStaticJavaNode* call = new (C, size) CallStaticJavaNode(call_type, call_addr, "uncommon_trap",
never@1515 166 jvms->bci(), no_memory_effects);
never@1515 167 for (int e = 0; e < TypeFunc::Parms; e++) {
never@1515 168 call->init_req(e, uct->in(e));
never@1515 169 }
never@1515 170 // Set the trap request to record intrinsic failure if this trap
never@1515 171 // is taken too many times. Ideally we would handle then traps by
never@1515 172 // doing the original bookkeeping in the MDO so that if it caused
never@1515 173 // the code to be thrown out we could still recompile and use the
never@1515 174 // optimization. Failing the uncommon traps doesn't really mean
never@1515 175 // that the optimization is a bad idea but there's no other way to
never@1515 176 // do the MDO updates currently.
never@1515 177 int trap_request = Deoptimization::make_trap_request(Deoptimization::Reason_intrinsic,
never@1515 178 Deoptimization::Action_make_not_entrant);
never@1515 179 call->init_req(TypeFunc::Parms, __ intcon(trap_request));
never@1515 180 kit.add_safepoint_edges(call);
never@1515 181
never@1515 182 _stringopts->gvn()->transform(call);
never@1515 183 C->gvn_replace_by(uct, call);
never@1515 184 uct->disconnect_inputs(NULL);
never@1515 185 }
never@1515 186 }
never@1515 187
never@1515 188 void cleanup() {
never@1515 189 // disconnect the hook node
never@1515 190 _arguments->disconnect_inputs(NULL);
never@1515 191 }
never@1515 192 };
never@1515 193
never@1515 194
never@1515 195 void StringConcat::eliminate_unneeded_control() {
never@1515 196 eliminate_initialize(begin()->initialization());
never@1515 197 for (uint i = 0; i < _control.size(); i++) {
never@1515 198 Node* n = _control.at(i);
never@1515 199 if (n->is_Call()) {
never@1515 200 if (n != _end) {
never@1515 201 eliminate_call(n->as_Call());
never@1515 202 }
never@1515 203 } else if (n->is_IfTrue()) {
never@1515 204 Compile* C = _stringopts->C;
never@1515 205 C->gvn_replace_by(n, n->in(0)->in(0));
never@1515 206 C->gvn_replace_by(n->in(0), C->top());
never@1515 207 }
never@1515 208 }
never@1515 209 }
never@1515 210
never@1515 211
never@1515 212 StringConcat* StringConcat::merge(StringConcat* other, Node* arg) {
never@1515 213 StringConcat* result = new StringConcat(_stringopts, _end);
never@1515 214 for (uint x = 0; x < _control.size(); x++) {
never@1515 215 Node* n = _control.at(x);
never@1515 216 if (n->is_Call()) {
never@1515 217 result->_control.push(n);
never@1515 218 }
never@1515 219 }
never@1515 220 for (uint x = 0; x < other->_control.size(); x++) {
never@1515 221 Node* n = other->_control.at(x);
never@1515 222 if (n->is_Call()) {
never@1515 223 result->_control.push(n);
never@1515 224 }
never@1515 225 }
never@1515 226 assert(result->_control.contains(other->_end), "what?");
never@1515 227 assert(result->_control.contains(_begin), "what?");
never@1515 228 for (int x = 0; x < num_arguments(); x++) {
never@1515 229 if (argument(x) == arg) {
never@1515 230 // replace the toString result with the all the arguments that
never@1515 231 // made up the other StringConcat
never@1515 232 for (int y = 0; y < other->num_arguments(); y++) {
never@1515 233 result->append(other->argument(y), other->mode(y));
never@1515 234 }
never@1515 235 } else {
never@1515 236 result->append(argument(x), mode(x));
never@1515 237 }
never@1515 238 }
never@1515 239 result->set_allocation(other->_begin);
never@1515 240 result->_multiple = true;
never@1515 241 return result;
never@1515 242 }
never@1515 243
never@1515 244
never@1515 245 void StringConcat::eliminate_call(CallNode* call) {
never@1515 246 Compile* C = _stringopts->C;
never@1515 247 CallProjections projs;
never@1515 248 call->extract_projections(&projs, false);
never@1515 249 if (projs.fallthrough_catchproj != NULL) {
never@1515 250 C->gvn_replace_by(projs.fallthrough_catchproj, call->in(TypeFunc::Control));
never@1515 251 }
never@1515 252 if (projs.fallthrough_memproj != NULL) {
never@1515 253 C->gvn_replace_by(projs.fallthrough_memproj, call->in(TypeFunc::Memory));
never@1515 254 }
never@1515 255 if (projs.catchall_memproj != NULL) {
never@1515 256 C->gvn_replace_by(projs.catchall_memproj, C->top());
never@1515 257 }
never@1515 258 if (projs.fallthrough_ioproj != NULL) {
never@1515 259 C->gvn_replace_by(projs.fallthrough_ioproj, call->in(TypeFunc::I_O));
never@1515 260 }
never@1515 261 if (projs.catchall_ioproj != NULL) {
never@1515 262 C->gvn_replace_by(projs.catchall_ioproj, C->top());
never@1515 263 }
never@1515 264 if (projs.catchall_catchproj != NULL) {
never@1515 265 // EA can't cope with the partially collapsed graph this
never@1515 266 // creates so put it on the worklist to be collapsed later.
never@1515 267 for (SimpleDUIterator i(projs.catchall_catchproj); i.has_next(); i.next()) {
never@1515 268 Node *use = i.get();
never@1515 269 int opc = use->Opcode();
never@1515 270 if (opc == Op_CreateEx || opc == Op_Region) {
never@1515 271 _stringopts->record_dead_node(use);
never@1515 272 }
never@1515 273 }
never@1515 274 C->gvn_replace_by(projs.catchall_catchproj, C->top());
never@1515 275 }
never@1515 276 if (projs.resproj != NULL) {
never@1515 277 C->gvn_replace_by(projs.resproj, C->top());
never@1515 278 }
never@1515 279 C->gvn_replace_by(call, C->top());
never@1515 280 }
never@1515 281
never@1515 282 void StringConcat::eliminate_initialize(InitializeNode* init) {
never@1515 283 Compile* C = _stringopts->C;
never@1515 284
never@1515 285 // Eliminate Initialize node.
never@1515 286 assert(init->outcnt() <= 2, "only a control and memory projection expected");
never@1515 287 assert(init->req() <= InitializeNode::RawStores, "no pending inits");
never@1515 288 Node *ctrl_proj = init->proj_out(TypeFunc::Control);
never@1515 289 if (ctrl_proj != NULL) {
never@1515 290 C->gvn_replace_by(ctrl_proj, init->in(TypeFunc::Control));
never@1515 291 }
never@1515 292 Node *mem_proj = init->proj_out(TypeFunc::Memory);
never@1515 293 if (mem_proj != NULL) {
never@1515 294 Node *mem = init->in(TypeFunc::Memory);
never@1515 295 C->gvn_replace_by(mem_proj, mem);
never@1515 296 }
never@1515 297 C->gvn_replace_by(init, C->top());
never@1515 298 init->disconnect_inputs(NULL);
never@1515 299 }
never@1515 300
never@1515 301 Node_List PhaseStringOpts::collect_toString_calls() {
never@1515 302 Node_List string_calls;
never@1515 303 Node_List worklist;
never@1515 304
never@1515 305 _visited.Clear();
never@1515 306
never@1515 307 // Prime the worklist
never@1515 308 for (uint i = 1; i < C->root()->len(); i++) {
never@1515 309 Node* n = C->root()->in(i);
never@1515 310 if (n != NULL && !_visited.test_set(n->_idx)) {
never@1515 311 worklist.push(n);
never@1515 312 }
never@1515 313 }
never@1515 314
never@1515 315 while (worklist.size() > 0) {
never@1515 316 Node* ctrl = worklist.pop();
never@1515 317 if (ctrl->is_CallStaticJava()) {
never@1515 318 CallStaticJavaNode* csj = ctrl->as_CallStaticJava();
never@1515 319 ciMethod* m = csj->method();
never@1515 320 if (m != NULL &&
never@1515 321 (m->intrinsic_id() == vmIntrinsics::_StringBuffer_toString ||
never@1515 322 m->intrinsic_id() == vmIntrinsics::_StringBuilder_toString)) {
never@1515 323 string_calls.push(csj);
never@1515 324 }
never@1515 325 }
never@1515 326 if (ctrl->in(0) != NULL && !_visited.test_set(ctrl->in(0)->_idx)) {
never@1515 327 worklist.push(ctrl->in(0));
never@1515 328 }
never@1515 329 if (ctrl->is_Region()) {
never@1515 330 for (uint i = 1; i < ctrl->len(); i++) {
never@1515 331 if (ctrl->in(i) != NULL && !_visited.test_set(ctrl->in(i)->_idx)) {
never@1515 332 worklist.push(ctrl->in(i));
never@1515 333 }
never@1515 334 }
never@1515 335 }
never@1515 336 }
never@1515 337 return string_calls;
never@1515 338 }
never@1515 339
never@1515 340
never@1515 341 StringConcat* PhaseStringOpts::build_candidate(CallStaticJavaNode* call) {
never@1515 342 ciMethod* m = call->method();
never@1515 343 ciSymbol* string_sig;
never@1515 344 ciSymbol* int_sig;
never@1515 345 ciSymbol* char_sig;
never@1515 346 if (m->holder() == C->env()->StringBuilder_klass()) {
never@1515 347 string_sig = ciSymbol::String_StringBuilder_signature();
never@1515 348 int_sig = ciSymbol::int_StringBuilder_signature();
never@1515 349 char_sig = ciSymbol::char_StringBuilder_signature();
never@1515 350 } else if (m->holder() == C->env()->StringBuffer_klass()) {
never@1515 351 string_sig = ciSymbol::String_StringBuffer_signature();
never@1515 352 int_sig = ciSymbol::int_StringBuffer_signature();
never@1515 353 char_sig = ciSymbol::char_StringBuffer_signature();
never@1515 354 } else {
never@1515 355 return NULL;
never@1515 356 }
never@1515 357 #ifndef PRODUCT
never@1515 358 if (PrintOptimizeStringConcat) {
never@1515 359 tty->print("considering toString call in ");
never@1515 360 call->jvms()->dump_spec(tty); tty->cr();
never@1515 361 }
never@1515 362 #endif
never@1515 363
never@1515 364 StringConcat* sc = new StringConcat(this, call);
never@1515 365
never@1515 366 AllocateNode* alloc = NULL;
never@1515 367 InitializeNode* init = NULL;
never@1515 368
never@1515 369 // possible opportunity for StringBuilder fusion
never@1515 370 CallStaticJavaNode* cnode = call;
never@1515 371 while (cnode) {
never@1515 372 Node* recv = cnode->in(TypeFunc::Parms)->uncast();
never@1515 373 if (recv->is_Proj()) {
never@1515 374 recv = recv->in(0);
never@1515 375 }
never@1515 376 cnode = recv->isa_CallStaticJava();
never@1515 377 if (cnode == NULL) {
never@1515 378 alloc = recv->isa_Allocate();
never@1515 379 if (alloc == NULL) {
never@1515 380 break;
never@1515 381 }
never@1515 382 // Find the constructor call
never@1515 383 Node* result = alloc->result_cast();
never@1515 384 if (result == NULL || !result->is_CheckCastPP()) {
never@1515 385 // strange looking allocation
never@1515 386 #ifndef PRODUCT
never@1515 387 if (PrintOptimizeStringConcat) {
never@1515 388 tty->print("giving up because allocation looks strange ");
never@1515 389 alloc->jvms()->dump_spec(tty); tty->cr();
never@1515 390 }
never@1515 391 #endif
never@1515 392 break;
never@1515 393 }
never@1515 394 Node* constructor = NULL;
never@1515 395 for (SimpleDUIterator i(result); i.has_next(); i.next()) {
never@1515 396 CallStaticJavaNode *use = i.get()->isa_CallStaticJava();
never@1515 397 if (use != NULL && use->method() != NULL &&
never@1515 398 use->method()->name() == ciSymbol::object_initializer_name() &&
never@1515 399 use->method()->holder() == m->holder()) {
never@1515 400 // Matched the constructor.
never@1515 401 ciSymbol* sig = use->method()->signature()->as_symbol();
never@1515 402 if (sig == ciSymbol::void_method_signature() ||
never@1515 403 sig == ciSymbol::int_void_signature() ||
never@1515 404 sig == ciSymbol::string_void_signature()) {
never@1515 405 if (sig == ciSymbol::string_void_signature()) {
never@1515 406 // StringBuilder(String) so pick this up as the first argument
never@1515 407 assert(use->in(TypeFunc::Parms + 1) != NULL, "what?");
never@1515 408 sc->push_string(use->in(TypeFunc::Parms + 1));
never@1515 409 }
never@1515 410 // The int variant takes an initial size for the backing
never@1515 411 // array so just treat it like the void version.
never@1515 412 constructor = use;
never@1515 413 } else {
never@1515 414 #ifndef PRODUCT
never@1515 415 if (PrintOptimizeStringConcat) {
never@1515 416 tty->print("unexpected constructor signature: %s", sig->as_utf8());
never@1515 417 }
never@1515 418 #endif
never@1515 419 }
never@1515 420 break;
never@1515 421 }
never@1515 422 }
never@1515 423 if (constructor == NULL) {
never@1515 424 // couldn't find constructor
never@1515 425 #ifndef PRODUCT
never@1515 426 if (PrintOptimizeStringConcat) {
never@1515 427 tty->print("giving up because couldn't find constructor ");
never@1515 428 alloc->jvms()->dump_spec(tty);
never@1515 429 }
never@1515 430 #endif
never@1515 431 break;
never@1515 432 }
never@1515 433
never@1515 434 // Walked all the way back and found the constructor call so see
never@1515 435 // if this call converted into a direct string concatenation.
never@1515 436 sc->add_control(call);
never@1515 437 sc->add_control(constructor);
never@1515 438 sc->add_control(alloc);
never@1515 439 sc->set_allocation(alloc);
never@1515 440 if (sc->validate_control_flow()) {
never@1515 441 return sc;
never@1515 442 } else {
never@1515 443 return NULL;
never@1515 444 }
never@1515 445 } else if (cnode->method() == NULL) {
never@1515 446 break;
never@1515 447 } else if (cnode->method()->holder() == m->holder() &&
never@1515 448 cnode->method()->name() == ciSymbol::append_name() &&
never@1515 449 (cnode->method()->signature()->as_symbol() == string_sig ||
never@1515 450 cnode->method()->signature()->as_symbol() == char_sig ||
never@1515 451 cnode->method()->signature()->as_symbol() == int_sig)) {
never@1515 452 sc->add_control(cnode);
never@1515 453 Node* arg = cnode->in(TypeFunc::Parms + 1);
never@1515 454 if (cnode->method()->signature()->as_symbol() == int_sig) {
never@1515 455 sc->push_int(arg);
never@1515 456 } else if (cnode->method()->signature()->as_symbol() == char_sig) {
never@1515 457 sc->push_char(arg);
never@1515 458 } else {
never@1515 459 if (arg->is_Proj() && arg->in(0)->is_CallStaticJava()) {
never@1515 460 CallStaticJavaNode* csj = arg->in(0)->as_CallStaticJava();
never@1515 461 if (csj->method() != NULL &&
never@1515 462 csj->method()->holder() == C->env()->Integer_klass() &&
never@1515 463 csj->method()->name() == ciSymbol::toString_name()) {
never@1515 464 sc->add_control(csj);
never@1515 465 sc->push_int(csj->in(TypeFunc::Parms));
never@1515 466 continue;
never@1515 467 }
never@1515 468 }
never@1515 469 sc->push_string(arg);
never@1515 470 }
never@1515 471 continue;
never@1515 472 } else {
never@1515 473 // some unhandled signature
never@1515 474 #ifndef PRODUCT
never@1515 475 if (PrintOptimizeStringConcat) {
never@1515 476 tty->print("giving up because encountered unexpected signature ");
never@1515 477 cnode->tf()->dump(); tty->cr();
never@1515 478 cnode->in(TypeFunc::Parms + 1)->dump();
never@1515 479 }
never@1515 480 #endif
never@1515 481 break;
never@1515 482 }
never@1515 483 }
never@1515 484 return NULL;
never@1515 485 }
never@1515 486
never@1515 487
never@1515 488 PhaseStringOpts::PhaseStringOpts(PhaseGVN* gvn, Unique_Node_List*):
never@1515 489 Phase(StringOpts),
never@1515 490 _gvn(gvn),
never@1515 491 _visited(Thread::current()->resource_area()) {
never@1515 492
never@1515 493 assert(OptimizeStringConcat, "shouldn't be here");
never@1515 494
never@1515 495 size_table_field = C->env()->Integer_klass()->get_field_by_name(ciSymbol::make("sizeTable"),
never@1515 496 ciSymbol::make("[I"), true);
never@1515 497 if (size_table_field == NULL) {
never@1515 498 // Something wrong so give up.
never@1515 499 assert(false, "why can't we find Integer.sizeTable?");
never@1515 500 return;
never@1515 501 }
never@1515 502
never@1515 503 // Collect the types needed to talk about the various slices of memory
never@1515 504 const TypeInstPtr* string_type = TypeInstPtr::make(TypePtr::NotNull, C->env()->String_klass(),
never@1515 505 false, NULL, 0);
never@1515 506
never@1515 507 const TypePtr* value_field_type = string_type->add_offset(java_lang_String::value_offset_in_bytes());
never@1515 508 const TypePtr* offset_field_type = string_type->add_offset(java_lang_String::offset_offset_in_bytes());
never@1515 509 const TypePtr* count_field_type = string_type->add_offset(java_lang_String::count_offset_in_bytes());
never@1515 510
never@1515 511 value_field_idx = C->get_alias_index(value_field_type);
never@1515 512 count_field_idx = C->get_alias_index(count_field_type);
never@1515 513 offset_field_idx = C->get_alias_index(offset_field_type);
never@1515 514 char_adr_idx = C->get_alias_index(TypeAryPtr::CHARS);
never@1515 515
never@1515 516 // For each locally allocated StringBuffer see if the usages can be
never@1515 517 // collapsed into a single String construction.
never@1515 518
never@1515 519 // Run through the list of allocation looking for SB.toString to see
never@1515 520 // if it's possible to fuse the usage of the SB into a single String
never@1515 521 // construction.
never@1515 522 GrowableArray<StringConcat*> concats;
never@1515 523 Node_List toStrings = collect_toString_calls();
never@1515 524 while (toStrings.size() > 0) {
never@1515 525 StringConcat* sc = build_candidate(toStrings.pop()->as_CallStaticJava());
never@1515 526 if (sc != NULL) {
never@1515 527 concats.push(sc);
never@1515 528 }
never@1515 529 }
never@1515 530
never@1515 531 // try to coalesce separate concats
never@1515 532 restart:
never@1515 533 for (int c = 0; c < concats.length(); c++) {
never@1515 534 StringConcat* sc = concats.at(c);
never@1515 535 for (int i = 0; i < sc->num_arguments(); i++) {
never@1515 536 Node* arg = sc->argument(i);
never@1515 537 if (arg->is_Proj() && arg->in(0)->is_CallStaticJava()) {
never@1515 538 CallStaticJavaNode* csj = arg->in(0)->as_CallStaticJava();
never@1515 539 if (csj->method() != NULL &&
never@1515 540 (csj->method()->holder() == C->env()->StringBuffer_klass() ||
never@1515 541 csj->method()->holder() == C->env()->StringBuilder_klass()) &&
never@1515 542 csj->method()->name() == ciSymbol::toString_name()) {
never@1515 543 for (int o = 0; o < concats.length(); o++) {
never@1515 544 if (c == o) continue;
never@1515 545 StringConcat* other = concats.at(o);
never@1515 546 if (other->end() == csj) {
never@1515 547 #ifndef PRODUCT
never@1515 548 if (PrintOptimizeStringConcat) {
never@1515 549 tty->print_cr("considering stacked concats");
never@1515 550 }
never@1515 551 #endif
never@1515 552
never@1515 553 StringConcat* merged = sc->merge(other, arg);
never@1515 554 if (merged->validate_control_flow()) {
never@1515 555 #ifndef PRODUCT
never@1515 556 if (PrintOptimizeStringConcat) {
never@1515 557 tty->print_cr("stacking would succeed");
never@1515 558 }
never@1515 559 #endif
never@1515 560 if (c < o) {
never@1515 561 concats.remove_at(o);
never@1515 562 concats.at_put(c, merged);
never@1515 563 } else {
never@1515 564 concats.remove_at(c);
never@1515 565 concats.at_put(o, merged);
never@1515 566 }
never@1515 567 goto restart;
never@1515 568 } else {
never@1515 569 #ifndef PRODUCT
never@1515 570 if (PrintOptimizeStringConcat) {
never@1515 571 tty->print_cr("stacking would fail");
never@1515 572 }
never@1515 573 #endif
never@1515 574 }
never@1515 575 }
never@1515 576 }
never@1515 577 }
never@1515 578 }
never@1515 579 }
never@1515 580 }
never@1515 581
never@1515 582
never@1515 583 for (int c = 0; c < concats.length(); c++) {
never@1515 584 StringConcat* sc = concats.at(c);
never@1515 585 replace_string_concat(sc);
never@1515 586 }
never@1515 587
never@1515 588 remove_dead_nodes();
never@1515 589 }
never@1515 590
never@1515 591 void PhaseStringOpts::record_dead_node(Node* dead) {
never@1515 592 dead_worklist.push(dead);
never@1515 593 }
never@1515 594
never@1515 595 void PhaseStringOpts::remove_dead_nodes() {
never@1515 596 // Delete any dead nodes to make things clean enough that escape
never@1515 597 // analysis doesn't get unhappy.
never@1515 598 while (dead_worklist.size() > 0) {
never@1515 599 Node* use = dead_worklist.pop();
never@1515 600 int opc = use->Opcode();
never@1515 601 switch (opc) {
never@1515 602 case Op_Region: {
never@1515 603 uint i = 1;
never@1515 604 for (i = 1; i < use->req(); i++) {
never@1515 605 if (use->in(i) != C->top()) {
never@1515 606 break;
never@1515 607 }
never@1515 608 }
never@1515 609 if (i >= use->req()) {
never@1515 610 for (SimpleDUIterator i(use); i.has_next(); i.next()) {
never@1515 611 Node* m = i.get();
never@1515 612 if (m->is_Phi()) {
never@1515 613 dead_worklist.push(m);
never@1515 614 }
never@1515 615 }
never@1515 616 C->gvn_replace_by(use, C->top());
never@1515 617 }
never@1515 618 break;
never@1515 619 }
never@1515 620 case Op_AddP:
never@1515 621 case Op_CreateEx: {
never@1515 622 // Recurisvely clean up references to CreateEx so EA doesn't
never@1515 623 // get unhappy about the partially collapsed graph.
never@1515 624 for (SimpleDUIterator i(use); i.has_next(); i.next()) {
never@1515 625 Node* m = i.get();
never@1515 626 if (m->is_AddP()) {
never@1515 627 dead_worklist.push(m);
never@1515 628 }
never@1515 629 }
never@1515 630 C->gvn_replace_by(use, C->top());
never@1515 631 break;
never@1515 632 }
never@1515 633 case Op_Phi:
never@1515 634 if (use->in(0) == C->top()) {
never@1515 635 C->gvn_replace_by(use, C->top());
never@1515 636 }
never@1515 637 break;
never@1515 638 }
never@1515 639 }
never@1515 640 }
never@1515 641
never@1515 642
never@1515 643 bool StringConcat::validate_control_flow() {
never@1515 644 // We found all the calls and arguments now lets see if it's
never@1515 645 // safe to transform the graph as we would expect.
never@1515 646
never@1515 647 // Check to see if this resulted in too many uncommon traps previously
never@1515 648 if (Compile::current()->too_many_traps(_begin->jvms()->method(), _begin->jvms()->bci(),
never@1515 649 Deoptimization::Reason_intrinsic)) {
never@1515 650 return false;
never@1515 651 }
never@1515 652
never@1515 653 // Walk backwards over the control flow from toString to the
never@1515 654 // allocation and make sure all the control flow is ok. This
never@1515 655 // means it's either going to be eliminated once the calls are
never@1515 656 // removed or it can safely be transformed into an uncommon
never@1515 657 // trap.
never@1515 658
never@1515 659 int null_check_count = 0;
never@1515 660 Unique_Node_List ctrl_path;
never@1515 661
never@1515 662 assert(_control.contains(_begin), "missing");
never@1515 663 assert(_control.contains(_end), "missing");
never@1515 664
never@1515 665 // Collect the nodes that we know about and will eliminate into ctrl_path
never@1515 666 for (uint i = 0; i < _control.size(); i++) {
never@1515 667 // Push the call and it's control projection
never@1515 668 Node* n = _control.at(i);
never@1515 669 if (n->is_Allocate()) {
never@1515 670 AllocateNode* an = n->as_Allocate();
never@1515 671 InitializeNode* init = an->initialization();
never@1515 672 ctrl_path.push(init);
never@1515 673 ctrl_path.push(init->as_Multi()->proj_out(0));
never@1515 674 }
never@1515 675 if (n->is_Call()) {
never@1515 676 CallNode* cn = n->as_Call();
never@1515 677 ctrl_path.push(cn);
never@1515 678 ctrl_path.push(cn->proj_out(0));
never@1515 679 ctrl_path.push(cn->proj_out(0)->unique_out());
never@1515 680 ctrl_path.push(cn->proj_out(0)->unique_out()->as_Catch()->proj_out(0));
never@1515 681 } else {
never@1515 682 ShouldNotReachHere();
never@1515 683 }
never@1515 684 }
never@1515 685
never@1515 686 // Skip backwards through the control checking for unexpected contro flow
never@1515 687 Node* ptr = _end;
never@1515 688 bool fail = false;
never@1515 689 while (ptr != _begin) {
never@1515 690 if (ptr->is_Call() && ctrl_path.member(ptr)) {
never@1515 691 ptr = ptr->in(0);
never@1515 692 } else if (ptr->is_CatchProj() && ctrl_path.member(ptr)) {
never@1515 693 ptr = ptr->in(0)->in(0)->in(0);
never@1515 694 assert(ctrl_path.member(ptr), "should be a known piece of control");
never@1515 695 } else if (ptr->is_IfTrue()) {
never@1515 696 IfNode* iff = ptr->in(0)->as_If();
never@1515 697 BoolNode* b = iff->in(1)->isa_Bool();
never@1515 698 Node* cmp = b->in(1);
never@1515 699 Node* v1 = cmp->in(1);
never@1515 700 Node* v2 = cmp->in(2);
never@1515 701 Node* otherproj = iff->proj_out(1 - ptr->as_Proj()->_con);
never@1515 702
never@1515 703 // Null check of the return of append which can simply be eliminated
never@1515 704 if (b->_test._test == BoolTest::ne &&
never@1515 705 v2->bottom_type() == TypePtr::NULL_PTR &&
never@1515 706 v1->is_Proj() && ctrl_path.member(v1->in(0))) {
never@1515 707 // NULL check of the return value of the append
never@1515 708 null_check_count++;
never@1515 709 if (otherproj->outcnt() == 1) {
never@1515 710 CallStaticJavaNode* call = otherproj->unique_out()->isa_CallStaticJava();
never@1515 711 if (call != NULL && call->_name != NULL && strcmp(call->_name, "uncommon_trap") == 0) {
never@1515 712 ctrl_path.push(call);
never@1515 713 }
never@1515 714 }
never@1515 715 _control.push(ptr);
never@1515 716 ptr = ptr->in(0)->in(0);
never@1515 717 continue;
never@1515 718 }
never@1515 719
never@1515 720 // A test which leads to an uncommon trap which should be safe.
never@1515 721 // Later this trap will be converted into a trap that restarts
never@1515 722 // at the beginning.
never@1515 723 if (otherproj->outcnt() == 1) {
never@1515 724 CallStaticJavaNode* call = otherproj->unique_out()->isa_CallStaticJava();
never@1515 725 if (call != NULL && call->_name != NULL && strcmp(call->_name, "uncommon_trap") == 0) {
never@1515 726 // control flow leads to uct so should be ok
never@1515 727 _uncommon_traps.push(call);
never@1515 728 ctrl_path.push(call);
never@1515 729 ptr = ptr->in(0)->in(0);
never@1515 730 continue;
never@1515 731 }
never@1515 732 }
never@1515 733
never@1515 734 #ifndef PRODUCT
never@1515 735 // Some unexpected control flow we don't know how to handle.
never@1515 736 if (PrintOptimizeStringConcat) {
never@1515 737 tty->print_cr("failing with unknown test");
never@1515 738 b->dump();
never@1515 739 cmp->dump();
never@1515 740 v1->dump();
never@1515 741 v2->dump();
never@1515 742 tty->cr();
never@1515 743 }
never@1515 744 #endif
never@1515 745 break;
never@1515 746 } else if (ptr->is_Proj() && ptr->in(0)->is_Initialize()) {
never@1515 747 ptr = ptr->in(0)->in(0);
never@1515 748 } else if (ptr->is_Region()) {
never@1515 749 Node* copy = ptr->as_Region()->is_copy();
never@1515 750 if (copy != NULL) {
never@1515 751 ptr = copy;
never@1515 752 continue;
never@1515 753 }
never@1515 754 if (ptr->req() == 3 &&
never@1515 755 ptr->in(1) != NULL && ptr->in(1)->is_Proj() &&
never@1515 756 ptr->in(2) != NULL && ptr->in(2)->is_Proj() &&
never@1515 757 ptr->in(1)->in(0) == ptr->in(2)->in(0) &&
never@1515 758 ptr->in(1)->in(0) != NULL && ptr->in(1)->in(0)->is_If()) {
never@1515 759 // Simple diamond.
never@1515 760 // XXX should check for possibly merging stores. simple data merges are ok.
never@1515 761 ptr = ptr->in(1)->in(0)->in(0);
never@1515 762 continue;
never@1515 763 }
never@1515 764 #ifndef PRODUCT
never@1515 765 if (PrintOptimizeStringConcat) {
never@1515 766 tty->print_cr("fusion would fail for region");
never@1515 767 _begin->dump();
never@1515 768 ptr->dump(2);
never@1515 769 }
never@1515 770 #endif
never@1515 771 fail = true;
never@1515 772 break;
never@1515 773 } else {
never@1515 774 // other unknown control
never@1515 775 if (!fail) {
never@1515 776 #ifndef PRODUCT
never@1515 777 if (PrintOptimizeStringConcat) {
never@1515 778 tty->print_cr("fusion would fail for");
never@1515 779 _begin->dump();
never@1515 780 }
never@1515 781 #endif
never@1515 782 fail = true;
never@1515 783 }
never@1515 784 #ifndef PRODUCT
never@1515 785 if (PrintOptimizeStringConcat) {
never@1515 786 ptr->dump();
never@1515 787 }
never@1515 788 #endif
never@1515 789 ptr = ptr->in(0);
never@1515 790 }
never@1515 791 }
never@1515 792 #ifndef PRODUCT
never@1515 793 if (PrintOptimizeStringConcat && fail) {
never@1515 794 tty->cr();
never@1515 795 }
never@1515 796 #endif
never@1515 797 if (fail) return !fail;
never@1515 798
never@1515 799 // Validate that all these results produced are contained within
never@1515 800 // this cluster of objects. First collect all the results produced
never@1515 801 // by calls in the region.
never@1515 802 _stringopts->_visited.Clear();
never@1515 803 Node_List worklist;
never@1515 804 Node* final_result = _end->proj_out(TypeFunc::Parms);
never@1515 805 for (uint i = 0; i < _control.size(); i++) {
never@1515 806 CallNode* cnode = _control.at(i)->isa_Call();
never@1515 807 if (cnode != NULL) {
never@1515 808 _stringopts->_visited.test_set(cnode->_idx);
never@1515 809 }
never@1515 810 Node* result = cnode != NULL ? cnode->proj_out(TypeFunc::Parms) : NULL;
never@1515 811 if (result != NULL && result != final_result) {
never@1515 812 worklist.push(result);
never@1515 813 }
never@1515 814 }
never@1515 815
never@1515 816 Node* last_result = NULL;
never@1515 817 while (worklist.size() > 0) {
never@1515 818 Node* result = worklist.pop();
never@1515 819 if (_stringopts->_visited.test_set(result->_idx))
never@1515 820 continue;
never@1515 821 for (SimpleDUIterator i(result); i.has_next(); i.next()) {
never@1515 822 Node *use = i.get();
never@1515 823 if (ctrl_path.member(use)) {
never@1515 824 // already checked this
never@1515 825 continue;
never@1515 826 }
never@1515 827 int opc = use->Opcode();
never@1515 828 if (opc == Op_CmpP || opc == Op_Node) {
never@1515 829 ctrl_path.push(use);
never@1515 830 continue;
never@1515 831 }
never@1515 832 if (opc == Op_CastPP || opc == Op_CheckCastPP) {
never@1515 833 for (SimpleDUIterator j(use); j.has_next(); j.next()) {
never@1515 834 worklist.push(j.get());
never@1515 835 }
never@1515 836 worklist.push(use->in(1));
never@1515 837 ctrl_path.push(use);
never@1515 838 continue;
never@1515 839 }
never@1515 840 #ifndef PRODUCT
never@1515 841 if (PrintOptimizeStringConcat) {
never@1515 842 if (result != last_result) {
never@1515 843 last_result = result;
never@1515 844 tty->print_cr("extra uses for result:");
never@1515 845 last_result->dump();
never@1515 846 }
never@1515 847 use->dump();
never@1515 848 }
never@1515 849 #endif
never@1515 850 fail = true;
never@1515 851 break;
never@1515 852 }
never@1515 853 }
never@1515 854
never@1515 855 #ifndef PRODUCT
never@1515 856 if (PrintOptimizeStringConcat && !fail) {
never@1515 857 ttyLocker ttyl;
never@1515 858 tty->cr();
never@1515 859 tty->print("fusion would succeed (%d %d) for ", null_check_count, _uncommon_traps.size());
never@1515 860 _begin->jvms()->dump_spec(tty); tty->cr();
never@1515 861 for (int i = 0; i < num_arguments(); i++) {
never@1515 862 argument(i)->dump();
never@1515 863 }
never@1515 864 _control.dump();
never@1515 865 tty->cr();
never@1515 866 }
never@1515 867 #endif
never@1515 868
never@1515 869 return !fail;
never@1515 870 }
never@1515 871
never@1515 872 Node* PhaseStringOpts::fetch_static_field(GraphKit& kit, ciField* field) {
never@1515 873 const TypeKlassPtr* klass_type = TypeKlassPtr::make(field->holder());
never@1515 874 Node* klass_node = __ makecon(klass_type);
never@1515 875 BasicType bt = field->layout_type();
never@1515 876 ciType* field_klass = field->type();
never@1515 877
never@1515 878 const Type *type;
never@1515 879 if( bt == T_OBJECT ) {
never@1515 880 if (!field->type()->is_loaded()) {
never@1515 881 type = TypeInstPtr::BOTTOM;
never@1515 882 } else if (field->is_constant()) {
never@1515 883 // This can happen if the constant oop is non-perm.
never@1515 884 ciObject* con = field->constant_value().as_object();
never@1515 885 // Do not "join" in the previous type; it doesn't add value,
never@1515 886 // and may yield a vacuous result if the field is of interface type.
never@1515 887 type = TypeOopPtr::make_from_constant(con)->isa_oopptr();
never@1515 888 assert(type != NULL, "field singleton type must be consistent");
never@1515 889 } else {
never@1515 890 type = TypeOopPtr::make_from_klass(field_klass->as_klass());
never@1515 891 }
never@1515 892 } else {
never@1515 893 type = Type::get_const_basic_type(bt);
never@1515 894 }
never@1515 895
never@1515 896 return kit.make_load(NULL, kit.basic_plus_adr(klass_node, field->offset_in_bytes()),
never@1515 897 type, T_OBJECT,
never@1515 898 C->get_alias_index(klass_type->add_offset(field->offset_in_bytes())));
never@1515 899 }
never@1515 900
never@1515 901 Node* PhaseStringOpts::int_stringSize(GraphKit& kit, Node* arg) {
never@1515 902 RegionNode *final_merge = new (C, 3) RegionNode(3);
never@1515 903 kit.gvn().set_type(final_merge, Type::CONTROL);
never@1515 904 Node* final_size = new (C, 3) PhiNode(final_merge, TypeInt::INT);
never@1515 905 kit.gvn().set_type(final_size, TypeInt::INT);
never@1515 906
never@1515 907 IfNode* iff = kit.create_and_map_if(kit.control(),
never@1515 908 __ Bool(__ CmpI(arg, __ intcon(0x80000000)), BoolTest::ne),
never@1515 909 PROB_FAIR, COUNT_UNKNOWN);
never@1515 910 Node* is_min = __ IfFalse(iff);
never@1515 911 final_merge->init_req(1, is_min);
never@1515 912 final_size->init_req(1, __ intcon(11));
never@1515 913
never@1515 914 kit.set_control(__ IfTrue(iff));
never@1515 915 if (kit.stopped()) {
never@1515 916 final_merge->init_req(2, C->top());
never@1515 917 final_size->init_req(2, C->top());
never@1515 918 } else {
never@1515 919
never@1515 920 // int size = (i < 0) ? stringSize(-i) + 1 : stringSize(i);
never@1515 921 RegionNode *r = new (C, 3) RegionNode(3);
never@1515 922 kit.gvn().set_type(r, Type::CONTROL);
never@1515 923 Node *phi = new (C, 3) PhiNode(r, TypeInt::INT);
never@1515 924 kit.gvn().set_type(phi, TypeInt::INT);
never@1515 925 Node *size = new (C, 3) PhiNode(r, TypeInt::INT);
never@1515 926 kit.gvn().set_type(size, TypeInt::INT);
never@1515 927 Node* chk = __ CmpI(arg, __ intcon(0));
never@1515 928 Node* p = __ Bool(chk, BoolTest::lt);
never@1515 929 IfNode* iff = kit.create_and_map_if(kit.control(), p, PROB_FAIR, COUNT_UNKNOWN);
never@1515 930 Node* lessthan = __ IfTrue(iff);
never@1515 931 Node* greaterequal = __ IfFalse(iff);
never@1515 932 r->init_req(1, lessthan);
never@1515 933 phi->init_req(1, __ SubI(__ intcon(0), arg));
never@1515 934 size->init_req(1, __ intcon(1));
never@1515 935 r->init_req(2, greaterequal);
never@1515 936 phi->init_req(2, arg);
never@1515 937 size->init_req(2, __ intcon(0));
never@1515 938 kit.set_control(r);
never@1515 939 C->record_for_igvn(r);
never@1515 940 C->record_for_igvn(phi);
never@1515 941 C->record_for_igvn(size);
never@1515 942
never@1515 943 // for (int i=0; ; i++)
never@1515 944 // if (x <= sizeTable[i])
never@1515 945 // return i+1;
never@1515 946 RegionNode *loop = new (C, 3) RegionNode(3);
never@1515 947 loop->init_req(1, kit.control());
never@1515 948 kit.gvn().set_type(loop, Type::CONTROL);
never@1515 949
never@1515 950 Node *index = new (C, 3) PhiNode(loop, TypeInt::INT);
never@1515 951 index->init_req(1, __ intcon(0));
never@1515 952 kit.gvn().set_type(index, TypeInt::INT);
never@1515 953 kit.set_control(loop);
never@1515 954 Node* sizeTable = fetch_static_field(kit, size_table_field);
never@1515 955
never@1515 956 Node* value = kit.load_array_element(NULL, sizeTable, index, TypeAryPtr::INTS);
never@1515 957 C->record_for_igvn(value);
never@1515 958 Node* limit = __ CmpI(phi, value);
never@1515 959 Node* limitb = __ Bool(limit, BoolTest::le);
never@1515 960 IfNode* iff2 = kit.create_and_map_if(kit.control(), limitb, PROB_MIN, COUNT_UNKNOWN);
never@1515 961 Node* lessEqual = __ IfTrue(iff2);
never@1515 962 Node* greater = __ IfFalse(iff2);
never@1515 963
never@1515 964 loop->init_req(2, greater);
never@1515 965 index->init_req(2, __ AddI(index, __ intcon(1)));
never@1515 966
never@1515 967 kit.set_control(lessEqual);
never@1515 968 C->record_for_igvn(loop);
never@1515 969 C->record_for_igvn(index);
never@1515 970
never@1515 971 final_merge->init_req(2, kit.control());
never@1515 972 final_size->init_req(2, __ AddI(__ AddI(index, size), __ intcon(1)));
never@1515 973 }
never@1515 974
never@1515 975 kit.set_control(final_merge);
never@1515 976 C->record_for_igvn(final_merge);
never@1515 977 C->record_for_igvn(final_size);
never@1515 978
never@1515 979 return final_size;
never@1515 980 }
never@1515 981
never@1515 982 void PhaseStringOpts::int_getChars(GraphKit& kit, Node* arg, Node* char_array, Node* start, Node* end) {
never@1515 983 RegionNode *final_merge = new (C, 4) RegionNode(4);
never@1515 984 kit.gvn().set_type(final_merge, Type::CONTROL);
never@1515 985 Node *final_mem = PhiNode::make(final_merge, kit.memory(char_adr_idx), Type::MEMORY, TypeAryPtr::CHARS);
never@1515 986 kit.gvn().set_type(final_mem, Type::MEMORY);
never@1515 987
never@1515 988 // need to handle Integer.MIN_VALUE specially because negating doesn't make it positive
never@1515 989 {
never@1515 990 // i == MIN_VALUE
never@1515 991 IfNode* iff = kit.create_and_map_if(kit.control(),
never@1515 992 __ Bool(__ CmpI(arg, __ intcon(0x80000000)), BoolTest::ne),
never@1515 993 PROB_FAIR, COUNT_UNKNOWN);
never@1515 994
never@1515 995 Node* old_mem = kit.memory(char_adr_idx);
never@1515 996
never@1515 997 kit.set_control(__ IfFalse(iff));
never@1515 998 if (kit.stopped()) {
never@1515 999 // Statically not equal to MIN_VALUE so this path is dead
never@1515 1000 final_merge->init_req(3, kit.control());
never@1515 1001 } else {
never@1515 1002 copy_string(kit, __ makecon(TypeInstPtr::make(C->env()->the_min_jint_string())),
never@1515 1003 char_array, start);
never@1515 1004 final_merge->init_req(3, kit.control());
never@1515 1005 final_mem->init_req(3, kit.memory(char_adr_idx));
never@1515 1006 }
never@1515 1007
never@1515 1008 kit.set_control(__ IfTrue(iff));
never@1515 1009 kit.set_memory(old_mem, char_adr_idx);
never@1515 1010 }
never@1515 1011
never@1515 1012
never@1515 1013 // Simplified version of Integer.getChars
never@1515 1014
never@1515 1015 // int q, r;
never@1515 1016 // int charPos = index;
never@1515 1017 Node* charPos = end;
never@1515 1018
never@1515 1019 // char sign = 0;
never@1515 1020
never@1515 1021 Node* i = arg;
never@1515 1022 Node* sign = __ intcon(0);
never@1515 1023
never@1515 1024 // if (i < 0) {
never@1515 1025 // sign = '-';
never@1515 1026 // i = -i;
never@1515 1027 // }
never@1515 1028 {
never@1515 1029 IfNode* iff = kit.create_and_map_if(kit.control(),
never@1515 1030 __ Bool(__ CmpI(arg, __ intcon(0)), BoolTest::lt),
never@1515 1031 PROB_FAIR, COUNT_UNKNOWN);
never@1515 1032
never@1515 1033 RegionNode *merge = new (C, 3) RegionNode(3);
never@1515 1034 kit.gvn().set_type(merge, Type::CONTROL);
never@1515 1035 i = new (C, 3) PhiNode(merge, TypeInt::INT);
never@1515 1036 kit.gvn().set_type(i, TypeInt::INT);
never@1515 1037 sign = new (C, 3) PhiNode(merge, TypeInt::INT);
never@1515 1038 kit.gvn().set_type(sign, TypeInt::INT);
never@1515 1039
never@1515 1040 merge->init_req(1, __ IfTrue(iff));
never@1515 1041 i->init_req(1, __ SubI(__ intcon(0), arg));
never@1515 1042 sign->init_req(1, __ intcon('-'));
never@1515 1043 merge->init_req(2, __ IfFalse(iff));
never@1515 1044 i->init_req(2, arg);
never@1515 1045 sign->init_req(2, __ intcon(0));
never@1515 1046
never@1515 1047 kit.set_control(merge);
never@1515 1048
never@1515 1049 C->record_for_igvn(merge);
never@1515 1050 C->record_for_igvn(i);
never@1515 1051 C->record_for_igvn(sign);
never@1515 1052 }
never@1515 1053
never@1515 1054 // for (;;) {
never@1515 1055 // q = i / 10;
never@1515 1056 // r = i - ((q << 3) + (q << 1)); // r = i-(q*10) ...
never@1515 1057 // buf [--charPos] = digits [r];
never@1515 1058 // i = q;
never@1515 1059 // if (i == 0) break;
never@1515 1060 // }
never@1515 1061
never@1515 1062 {
never@1515 1063 RegionNode *head = new (C, 3) RegionNode(3);
never@1515 1064 head->init_req(1, kit.control());
never@1515 1065 kit.gvn().set_type(head, Type::CONTROL);
never@1515 1066 Node *i_phi = new (C, 3) PhiNode(head, TypeInt::INT);
never@1515 1067 i_phi->init_req(1, i);
never@1515 1068 kit.gvn().set_type(i_phi, TypeInt::INT);
never@1515 1069 charPos = PhiNode::make(head, charPos);
never@1515 1070 kit.gvn().set_type(charPos, TypeInt::INT);
never@1515 1071 Node *mem = PhiNode::make(head, kit.memory(char_adr_idx), Type::MEMORY, TypeAryPtr::CHARS);
never@1515 1072 kit.gvn().set_type(mem, Type::MEMORY);
never@1515 1073 kit.set_control(head);
never@1515 1074 kit.set_memory(mem, char_adr_idx);
never@1515 1075
never@1515 1076 Node* q = __ DivI(kit.null(), i_phi, __ intcon(10));
never@1515 1077 Node* r = __ SubI(i_phi, __ AddI(__ LShiftI(q, __ intcon(3)),
never@1515 1078 __ LShiftI(q, __ intcon(1))));
never@1515 1079 Node* m1 = __ SubI(charPos, __ intcon(1));
never@1515 1080 Node* ch = __ AddI(r, __ intcon('0'));
never@1515 1081
never@1515 1082 Node* st = __ store_to_memory(kit.control(), kit.array_element_address(char_array, m1, T_CHAR),
never@1515 1083 ch, T_CHAR, char_adr_idx);
never@1515 1084
never@1515 1085
never@1515 1086 IfNode* iff = kit.create_and_map_if(head, __ Bool(__ CmpI(q, __ intcon(0)), BoolTest::ne),
never@1515 1087 PROB_FAIR, COUNT_UNKNOWN);
never@1515 1088 Node* ne = __ IfTrue(iff);
never@1515 1089 Node* eq = __ IfFalse(iff);
never@1515 1090
never@1515 1091 head->init_req(2, ne);
never@1515 1092 mem->init_req(2, st);
never@1515 1093 i_phi->init_req(2, q);
never@1515 1094 charPos->init_req(2, m1);
never@1515 1095
never@1515 1096 charPos = m1;
never@1515 1097
never@1515 1098 kit.set_control(eq);
never@1515 1099 kit.set_memory(st, char_adr_idx);
never@1515 1100
never@1515 1101 C->record_for_igvn(head);
never@1515 1102 C->record_for_igvn(mem);
never@1515 1103 C->record_for_igvn(i_phi);
never@1515 1104 C->record_for_igvn(charPos);
never@1515 1105 }
never@1515 1106
never@1515 1107 {
never@1515 1108 // if (sign != 0) {
never@1515 1109 // buf [--charPos] = sign;
never@1515 1110 // }
never@1515 1111 IfNode* iff = kit.create_and_map_if(kit.control(),
never@1515 1112 __ Bool(__ CmpI(sign, __ intcon(0)), BoolTest::ne),
never@1515 1113 PROB_FAIR, COUNT_UNKNOWN);
never@1515 1114
never@1515 1115 final_merge->init_req(2, __ IfFalse(iff));
never@1515 1116 final_mem->init_req(2, kit.memory(char_adr_idx));
never@1515 1117
never@1515 1118 kit.set_control(__ IfTrue(iff));
never@1515 1119 if (kit.stopped()) {
never@1515 1120 final_merge->init_req(1, C->top());
never@1515 1121 final_mem->init_req(1, C->top());
never@1515 1122 } else {
never@1515 1123 Node* m1 = __ SubI(charPos, __ intcon(1));
never@1515 1124 Node* st = __ store_to_memory(kit.control(), kit.array_element_address(char_array, m1, T_CHAR),
never@1515 1125 sign, T_CHAR, char_adr_idx);
never@1515 1126
never@1515 1127 final_merge->init_req(1, kit.control());
never@1515 1128 final_mem->init_req(1, st);
never@1515 1129 }
never@1515 1130
never@1515 1131 kit.set_control(final_merge);
never@1515 1132 kit.set_memory(final_mem, char_adr_idx);
never@1515 1133
never@1515 1134 C->record_for_igvn(final_merge);
never@1515 1135 C->record_for_igvn(final_mem);
never@1515 1136 }
never@1515 1137 }
never@1515 1138
never@1515 1139
never@1515 1140 Node* PhaseStringOpts::copy_string(GraphKit& kit, Node* str, Node* char_array, Node* start) {
never@1515 1141 Node* string = str;
never@1515 1142 Node* offset = kit.make_load(NULL,
never@1515 1143 kit.basic_plus_adr(string, string, java_lang_String::offset_offset_in_bytes()),
never@1515 1144 TypeInt::INT, T_INT, offset_field_idx);
never@1515 1145 Node* count = kit.make_load(NULL,
never@1515 1146 kit.basic_plus_adr(string, string, java_lang_String::count_offset_in_bytes()),
never@1515 1147 TypeInt::INT, T_INT, count_field_idx);
never@1515 1148 const TypeAryPtr* value_type = TypeAryPtr::make(TypePtr::NotNull,
never@1515 1149 TypeAry::make(TypeInt::CHAR,TypeInt::POS),
never@1515 1150 ciTypeArrayKlass::make(T_CHAR), true, 0);
never@1515 1151 Node* value = kit.make_load(NULL,
never@1515 1152 kit.basic_plus_adr(string, string, java_lang_String::value_offset_in_bytes()),
never@1515 1153 value_type, T_OBJECT, value_field_idx);
never@1515 1154
never@1515 1155 // copy the contents
never@1515 1156 if (offset->is_Con() && count->is_Con() && value->is_Con() && count->get_int() < unroll_string_copy_length) {
never@1515 1157 // For small constant strings just emit individual stores.
never@1515 1158 // A length of 6 seems like a good space/speed tradeof.
never@1515 1159 int c = count->get_int();
never@1515 1160 int o = offset->get_int();
never@1515 1161 const TypeOopPtr* t = kit.gvn().type(value)->isa_oopptr();
never@1515 1162 ciTypeArray* value_array = t->const_oop()->as_type_array();
never@1515 1163 for (int e = 0; e < c; e++) {
never@1515 1164 __ store_to_memory(kit.control(), kit.array_element_address(char_array, start, T_CHAR),
never@1515 1165 __ intcon(value_array->char_at(o + e)), T_CHAR, char_adr_idx);
never@1515 1166 start = __ AddI(start, __ intcon(1));
never@1515 1167 }
never@1515 1168 } else {
never@1515 1169 Node* src_ptr = kit.array_element_address(value, offset, T_CHAR);
never@1515 1170 Node* dst_ptr = kit.array_element_address(char_array, start, T_CHAR);
never@1515 1171 Node* c = count;
never@1515 1172 Node* extra = NULL;
never@1515 1173 #ifdef _LP64
never@1515 1174 c = __ ConvI2L(c);
never@1515 1175 extra = C->top();
never@1515 1176 #endif
never@1515 1177 Node* call = kit.make_runtime_call(GraphKit::RC_LEAF|GraphKit::RC_NO_FP,
never@1515 1178 OptoRuntime::fast_arraycopy_Type(),
never@1515 1179 CAST_FROM_FN_PTR(address, StubRoutines::jshort_disjoint_arraycopy()),
never@1515 1180 "jshort_disjoint_arraycopy", TypeAryPtr::CHARS,
never@1515 1181 src_ptr, dst_ptr, c, extra);
never@1515 1182 start = __ AddI(start, count);
never@1515 1183 }
never@1515 1184 return start;
never@1515 1185 }
never@1515 1186
never@1515 1187
never@1515 1188 void PhaseStringOpts::replace_string_concat(StringConcat* sc) {
never@1515 1189 // Log a little info about the transformation
never@1515 1190 sc->maybe_log_transform();
never@1515 1191
never@1515 1192 // pull the JVMState of the allocation into a SafePointNode to serve as
never@1515 1193 // as a shim for the insertion of the new code.
never@1515 1194 JVMState* jvms = sc->begin()->jvms()->clone_shallow(C);
never@1515 1195 uint size = sc->begin()->req();
never@1515 1196 SafePointNode* map = new (C, size) SafePointNode(size, jvms);
never@1515 1197
never@1515 1198 // copy the control and memory state from the final call into our
never@1515 1199 // new starting state. This allows any preceeding tests to feed
never@1515 1200 // into the new section of code.
never@1515 1201 for (uint i1 = 0; i1 < TypeFunc::Parms; i1++) {
never@1515 1202 map->init_req(i1, sc->end()->in(i1));
never@1515 1203 }
never@1515 1204 // blow away old allocation arguments
never@1515 1205 for (uint i1 = TypeFunc::Parms; i1 < jvms->debug_start(); i1++) {
never@1515 1206 map->init_req(i1, C->top());
never@1515 1207 }
never@1515 1208 // Copy the rest of the inputs for the JVMState
never@1515 1209 for (uint i1 = jvms->debug_start(); i1 < sc->begin()->req(); i1++) {
never@1515 1210 map->init_req(i1, sc->begin()->in(i1));
never@1515 1211 }
never@1515 1212 // Make sure the memory state is a MergeMem for parsing.
never@1515 1213 if (!map->in(TypeFunc::Memory)->is_MergeMem()) {
never@1515 1214 map->set_req(TypeFunc::Memory, MergeMemNode::make(C, map->in(TypeFunc::Memory)));
never@1515 1215 }
never@1515 1216
never@1515 1217 jvms->set_map(map);
never@1515 1218 map->ensure_stack(jvms, jvms->method()->max_stack());
never@1515 1219
never@1515 1220
never@1515 1221 // disconnect all the old StringBuilder calls from the graph
never@1515 1222 sc->eliminate_unneeded_control();
never@1515 1223
never@1515 1224 // At this point all the old work has been completely removed from
never@1515 1225 // the graph and the saved JVMState exists at the point where the
never@1515 1226 // final toString call used to be.
never@1515 1227 GraphKit kit(jvms);
never@1515 1228
never@1515 1229 // There may be uncommon traps which are still using the
never@1515 1230 // intermediate states and these need to be rewritten to point at
never@1515 1231 // the JVMState at the beginning of the transformation.
never@1515 1232 sc->convert_uncommon_traps(kit, jvms);
never@1515 1233
never@1515 1234 // Now insert the logic to compute the size of the string followed
never@1515 1235 // by all the logic to construct array and resulting string.
never@1515 1236
never@1515 1237 Node* null_string = __ makecon(TypeInstPtr::make(C->env()->the_null_string()));
never@1515 1238
never@1515 1239 // Create a region for the overflow checks to merge into.
never@1515 1240 int args = MAX2(sc->num_arguments(), 1);
never@1515 1241 RegionNode* overflow = new (C, args) RegionNode(args);
never@1515 1242 kit.gvn().set_type(overflow, Type::CONTROL);
never@1515 1243
never@1515 1244 // Create a hook node to hold onto the individual sizes since they
never@1515 1245 // are need for the copying phase.
never@1515 1246 Node* string_sizes = new (C, args) Node(args);
never@1515 1247
never@1515 1248 Node* length = __ intcon(0);
never@1515 1249 for (int argi = 0; argi < sc->num_arguments(); argi++) {
never@1515 1250 Node* arg = sc->argument(argi);
never@1515 1251 switch (sc->mode(argi)) {
never@1515 1252 case StringConcat::IntMode: {
never@1515 1253 Node* string_size = int_stringSize(kit, arg);
never@1515 1254
never@1515 1255 // accumulate total
never@1515 1256 length = __ AddI(length, string_size);
never@1515 1257
never@1515 1258 // Cache this value for the use by int_toString
never@1515 1259 string_sizes->init_req(argi, string_size);
never@1515 1260 break;
never@1515 1261 }
never@1515 1262 case StringConcat::StringMode: {
never@1515 1263 const Type* type = kit.gvn().type(arg);
never@1515 1264 if (type == TypePtr::NULL_PTR) {
never@1515 1265 // replace the argument with the null checked version
never@1515 1266 arg = null_string;
never@1515 1267 sc->set_argument(argi, arg);
never@1515 1268 } else if (!type->higher_equal(TypeInstPtr::NOTNULL)) {
never@1515 1269 // s = s != null ? s : "null";
never@1515 1270 // length = length + (s.count - s.offset);
never@1515 1271 RegionNode *r = new (C, 3) RegionNode(3);
never@1515 1272 kit.gvn().set_type(r, Type::CONTROL);
never@1515 1273 Node *phi = new (C, 3) PhiNode(r, type->join(TypeInstPtr::NOTNULL));
never@1515 1274 kit.gvn().set_type(phi, phi->bottom_type());
never@1515 1275 Node* p = __ Bool(__ CmpP(arg, kit.null()), BoolTest::ne);
never@1515 1276 IfNode* iff = kit.create_and_map_if(kit.control(), p, PROB_MIN, COUNT_UNKNOWN);
never@1515 1277 Node* notnull = __ IfTrue(iff);
never@1515 1278 Node* isnull = __ IfFalse(iff);
never@1515 1279 r->init_req(1, notnull);
never@1515 1280 phi->init_req(1, arg);
never@1515 1281 r->init_req(2, isnull);
never@1515 1282 phi->init_req(2, null_string);
never@1515 1283 kit.set_control(r);
never@1515 1284 C->record_for_igvn(r);
never@1515 1285 C->record_for_igvn(phi);
never@1515 1286 // replace the argument with the null checked version
never@1515 1287 arg = phi;
never@1515 1288 sc->set_argument(argi, arg);
never@1515 1289 }
never@1515 1290 // Node* offset = kit.make_load(NULL, kit.basic_plus_adr(arg, arg, offset_offset),
never@1515 1291 // TypeInt::INT, T_INT, offset_field_idx);
never@1515 1292 Node* count = kit.make_load(NULL, kit.basic_plus_adr(arg, arg, java_lang_String::count_offset_in_bytes()),
never@1515 1293 TypeInt::INT, T_INT, count_field_idx);
never@1515 1294 length = __ AddI(length, count);
never@1515 1295 string_sizes->init_req(argi, NULL);
never@1515 1296 break;
never@1515 1297 }
never@1515 1298 case StringConcat::CharMode: {
never@1515 1299 // one character only
never@1515 1300 length = __ AddI(length, __ intcon(1));
never@1515 1301 break;
never@1515 1302 }
never@1515 1303 default:
never@1515 1304 ShouldNotReachHere();
never@1515 1305 }
never@1515 1306 if (argi > 0) {
never@1515 1307 // Check that the sum hasn't overflowed
never@1515 1308 IfNode* iff = kit.create_and_map_if(kit.control(),
never@1515 1309 __ Bool(__ CmpI(length, __ intcon(0)), BoolTest::lt),
never@1515 1310 PROB_MIN, COUNT_UNKNOWN);
never@1515 1311 kit.set_control(__ IfFalse(iff));
never@1515 1312 overflow->set_req(argi, __ IfTrue(iff));
never@1515 1313 }
never@1515 1314 }
never@1515 1315
never@1515 1316 {
never@1515 1317 // Hook
never@1515 1318 PreserveJVMState pjvms(&kit);
never@1515 1319 kit.set_control(overflow);
never@1515 1320 kit.uncommon_trap(Deoptimization::Reason_intrinsic,
never@1515 1321 Deoptimization::Action_make_not_entrant);
never@1515 1322 }
never@1515 1323
never@1515 1324 // length now contains the number of characters needed for the
never@1515 1325 // char[] so create a new AllocateArray for the char[]
never@1515 1326 Node* char_array = NULL;
never@1515 1327 {
never@1515 1328 PreserveReexecuteState preexecs(&kit);
never@1515 1329 // The original jvms is for an allocation of either a String or
never@1515 1330 // StringBuffer so no stack adjustment is necessary for proper
never@1515 1331 // reexecution. If we deoptimize in the slow path the bytecode
never@1515 1332 // will be reexecuted and the char[] allocation will be thrown away.
never@1515 1333 kit.jvms()->set_should_reexecute(true);
never@1515 1334 char_array = kit.new_array(__ makecon(TypeKlassPtr::make(ciTypeArrayKlass::make(T_CHAR))),
never@1515 1335 length, 1);
never@1515 1336 }
never@1515 1337
never@1515 1338 // Mark the allocation so that zeroing is skipped since the code
never@1515 1339 // below will overwrite the entire array
never@1515 1340 AllocateArrayNode* char_alloc = AllocateArrayNode::Ideal_array_allocation(char_array, _gvn);
never@1515 1341 char_alloc->maybe_set_complete(_gvn);
never@1515 1342
never@1515 1343 // Now copy the string representations into the final char[]
never@1515 1344 Node* start = __ intcon(0);
never@1515 1345 for (int argi = 0; argi < sc->num_arguments(); argi++) {
never@1515 1346 Node* arg = sc->argument(argi);
never@1515 1347 switch (sc->mode(argi)) {
never@1515 1348 case StringConcat::IntMode: {
never@1515 1349 Node* end = __ AddI(start, string_sizes->in(argi));
never@1515 1350 // getChars words backwards so pass the ending point as well as the start
never@1515 1351 int_getChars(kit, arg, char_array, start, end);
never@1515 1352 start = end;
never@1515 1353 break;
never@1515 1354 }
never@1515 1355 case StringConcat::StringMode: {
never@1515 1356 start = copy_string(kit, arg, char_array, start);
never@1515 1357 break;
never@1515 1358 }
never@1515 1359 case StringConcat::CharMode: {
never@1515 1360 __ store_to_memory(kit.control(), kit.array_element_address(char_array, start, T_CHAR),
never@1515 1361 arg, T_CHAR, char_adr_idx);
never@1515 1362 start = __ AddI(start, __ intcon(1));
never@1515 1363 break;
never@1515 1364 }
never@1515 1365 default:
never@1515 1366 ShouldNotReachHere();
never@1515 1367 }
never@1515 1368 }
never@1515 1369
never@1515 1370 // If we're not reusing an existing String allocation then allocate one here.
never@1515 1371 Node* result = sc->string_alloc();
never@1515 1372 if (result == NULL) {
never@1515 1373 PreserveReexecuteState preexecs(&kit);
never@1515 1374 // The original jvms is for an allocation of either a String or
never@1515 1375 // StringBuffer so no stack adjustment is necessary for proper
never@1515 1376 // reexecution.
never@1515 1377 kit.jvms()->set_should_reexecute(true);
never@1515 1378 result = kit.new_instance(__ makecon(TypeKlassPtr::make(C->env()->String_klass())));
never@1515 1379 }
never@1515 1380
never@1515 1381 // Intialize the string
never@1515 1382 kit.store_to_memory(kit.control(), kit.basic_plus_adr(result, java_lang_String::offset_offset_in_bytes()),
never@1515 1383 __ intcon(0), T_INT, offset_field_idx);
never@1515 1384 kit.store_to_memory(kit.control(), kit.basic_plus_adr(result, java_lang_String::count_offset_in_bytes()),
never@1515 1385 length, T_INT, count_field_idx);
never@1515 1386 kit.store_to_memory(kit.control(), kit.basic_plus_adr(result, java_lang_String::value_offset_in_bytes()),
never@1515 1387 char_array, T_OBJECT, value_field_idx);
never@1515 1388
never@1515 1389 // hook up the outgoing control and result
never@1515 1390 kit.replace_call(sc->end(), result);
never@1515 1391
never@1515 1392 // Unhook any hook nodes
never@1515 1393 string_sizes->disconnect_inputs(NULL);
never@1515 1394 sc->cleanup();
never@1515 1395 }

mercurial