Mon, 28 Jul 2014 15:06:38 -0700
8051344: JVM crashed in Compile::start() during method parsing w/ UseRTMDeopt turned on
Summary: call rtm_deopt() only if there were no compilation bailouts before.
Reviewed-by: kvn
aoqi@0 | 1 | /* |
aoqi@0 | 2 | * Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved. |
aoqi@0 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
aoqi@0 | 4 | * |
aoqi@0 | 5 | * This code is free software; you can redistribute it and/or modify it |
aoqi@0 | 6 | * under the terms of the GNU General Public License version 2 only, as |
aoqi@0 | 7 | * published by the Free Software Foundation. |
aoqi@0 | 8 | * |
aoqi@0 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
aoqi@0 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
aoqi@0 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
aoqi@0 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
aoqi@0 | 13 | * accompanied this code). |
aoqi@0 | 14 | * |
aoqi@0 | 15 | * You should have received a copy of the GNU General Public License version |
aoqi@0 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
aoqi@0 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
aoqi@0 | 18 | * |
aoqi@0 | 19 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
aoqi@0 | 20 | * or visit www.oracle.com if you need additional information or have any |
aoqi@0 | 21 | * questions. |
aoqi@0 | 22 | * |
aoqi@0 | 23 | */ |
aoqi@0 | 24 | |
aoqi@0 | 25 | /** |
aoqi@0 | 26 | * @test |
aoqi@0 | 27 | * @bug 8031320 |
aoqi@0 | 28 | * @summary Verify that UseRTMXendForLockBusy option affects |
aoqi@0 | 29 | * method behaviour if lock is busy. |
aoqi@0 | 30 | * @library /testlibrary /testlibrary/whitebox /compiler/testlibrary |
aoqi@0 | 31 | * @build TestUseRTMXendForLockBusy |
aoqi@0 | 32 | * @run main ClassFileInstaller sun.hotspot.WhiteBox |
aoqi@0 | 33 | * @run main/othervm -Xbootclasspath/a:. -XX:+UnlockDiagnosticVMOptions |
aoqi@0 | 34 | * -XX:+WhiteBoxAPI TestUseRTMXendForLockBusy |
aoqi@0 | 35 | */ |
aoqi@0 | 36 | |
aoqi@0 | 37 | import java.util.List; |
aoqi@0 | 38 | |
aoqi@0 | 39 | import com.oracle.java.testlibrary.*; |
aoqi@0 | 40 | import com.oracle.java.testlibrary.cli.CommandLineOptionTest; |
aoqi@0 | 41 | import com.oracle.java.testlibrary.cli.predicate.AndPredicate; |
aoqi@0 | 42 | import rtm.*; |
aoqi@0 | 43 | import rtm.predicate.SupportedCPU; |
aoqi@0 | 44 | import rtm.predicate.SupportedVM; |
aoqi@0 | 45 | |
aoqi@0 | 46 | /** |
aoqi@0 | 47 | * Test verifies that with +UseRTMXendForLockBusy there will be no aborts |
aoqi@0 | 48 | * forced by the test. |
aoqi@0 | 49 | */ |
aoqi@0 | 50 | public class TestUseRTMXendForLockBusy extends CommandLineOptionTest { |
aoqi@0 | 51 | private final static int LOCKING_TIME = 5000; |
aoqi@0 | 52 | |
aoqi@0 | 53 | private TestUseRTMXendForLockBusy() { |
aoqi@0 | 54 | super(new AndPredicate(new SupportedVM(), new SupportedCPU())); |
aoqi@0 | 55 | } |
aoqi@0 | 56 | |
aoqi@0 | 57 | @Override |
aoqi@0 | 58 | protected void runTestCases() throws Throwable { |
aoqi@0 | 59 | // inflated lock, xabort on lock busy |
aoqi@0 | 60 | verifyXendForLockBusy(true, false); |
aoqi@0 | 61 | // inflated lock, xend on lock busy |
aoqi@0 | 62 | verifyXendForLockBusy(true, true); |
aoqi@0 | 63 | // stack lock, xabort on lock busy |
aoqi@0 | 64 | verifyXendForLockBusy(false, false); |
aoqi@0 | 65 | // stack lock, xend on lock busy |
aoqi@0 | 66 | verifyXendForLockBusy(false, true); |
aoqi@0 | 67 | } |
aoqi@0 | 68 | |
aoqi@0 | 69 | private void verifyXendForLockBusy(boolean inflateMonitor, |
aoqi@0 | 70 | boolean useXend) throws Throwable { |
aoqi@0 | 71 | CompilableTest test = new BusyLock(); |
aoqi@0 | 72 | |
aoqi@0 | 73 | OutputAnalyzer outputAnalyzer = RTMTestBase.executeRTMTest( |
aoqi@0 | 74 | test, |
aoqi@0 | 75 | CommandLineOptionTest.prepareBooleanFlag("UseRTMForStackLocks", |
aoqi@0 | 76 | inflateMonitor), |
aoqi@0 | 77 | CommandLineOptionTest.prepareBooleanFlag( |
aoqi@0 | 78 | "UseRTMXendForLockBusy", |
aoqi@0 | 79 | useXend), |
aoqi@0 | 80 | "-XX:RTMRetryCount=0", |
aoqi@0 | 81 | "-XX:RTMTotalCountIncrRate=1", |
aoqi@0 | 82 | "-XX:+PrintPreciseRTMLockingStatistics", |
aoqi@0 | 83 | BusyLock.class.getName(), |
aoqi@0 | 84 | Boolean.toString(inflateMonitor), |
aoqi@0 | 85 | Integer.toString(TestUseRTMXendForLockBusy.LOCKING_TIME) |
aoqi@0 | 86 | ); |
aoqi@0 | 87 | |
aoqi@0 | 88 | outputAnalyzer.shouldHaveExitValue(0); |
aoqi@0 | 89 | |
aoqi@0 | 90 | List<RTMLockingStatistics> statistics = RTMLockingStatistics.fromString( |
aoqi@0 | 91 | test.getMethodWithLockName(), outputAnalyzer.getOutput()); |
aoqi@0 | 92 | |
aoqi@0 | 93 | Asserts.assertEQ(statistics.size(), 1, "VM output should contain " |
aoqi@0 | 94 | + "exactly one rtm locking statistics entry for method " |
aoqi@0 | 95 | + test.getMethodWithLockName()); |
aoqi@0 | 96 | |
aoqi@0 | 97 | long aborts = statistics.get(0).getAborts(AbortType.XABORT); |
aoqi@0 | 98 | |
aoqi@0 | 99 | if (useXend) { |
aoqi@0 | 100 | Asserts.assertEQ(aborts, 0L, |
aoqi@0 | 101 | "Expected to get no aborts on busy lock"); |
aoqi@0 | 102 | } else { |
aoqi@0 | 103 | Asserts.assertGT(aborts, 0L, |
aoqi@0 | 104 | "Expected to get at least one abort on busy lock"); |
aoqi@0 | 105 | } |
aoqi@0 | 106 | } |
aoqi@0 | 107 | |
aoqi@0 | 108 | public static void main(String args[]) throws Throwable { |
aoqi@0 | 109 | new TestUseRTMXendForLockBusy().test(); |
aoqi@0 | 110 | } |
aoqi@0 | 111 | } |