Mon, 28 Jul 2014 15:06:38 -0700
8051344: JVM crashed in Compile::start() during method parsing w/ UseRTMDeopt turned on
Summary: call rtm_deopt() only if there were no compilation bailouts before.
Reviewed-by: kvn
aoqi@0 | 1 | /* |
aoqi@0 | 2 | * Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved. |
aoqi@0 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
aoqi@0 | 4 | * |
aoqi@0 | 5 | * This code is free software; you can redistribute it and/or modify it |
aoqi@0 | 6 | * under the terms of the GNU General Public License version 2 only, as |
aoqi@0 | 7 | * published by the Free Software Foundation. |
aoqi@0 | 8 | * |
aoqi@0 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
aoqi@0 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
aoqi@0 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
aoqi@0 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
aoqi@0 | 13 | * accompanied this code). |
aoqi@0 | 14 | * |
aoqi@0 | 15 | * You should have received a copy of the GNU General Public License version |
aoqi@0 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
aoqi@0 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
aoqi@0 | 18 | * |
aoqi@0 | 19 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
aoqi@0 | 20 | * or visit www.oracle.com if you need additional information or have any |
aoqi@0 | 21 | * questions. |
aoqi@0 | 22 | * |
aoqi@0 | 23 | */ |
aoqi@0 | 24 | |
aoqi@0 | 25 | /** |
aoqi@0 | 26 | * @test |
aoqi@0 | 27 | * @bug 8031320 |
aoqi@0 | 28 | * @summary Verify that RTMSpinLoopCount affects time spent |
aoqi@0 | 29 | * between locking attempts. |
aoqi@0 | 30 | * @library /testlibrary /testlibrary/whitebox /compiler/testlibrary |
aoqi@0 | 31 | * @build TestRTMSpinLoopCount |
aoqi@0 | 32 | * @run main ClassFileInstaller sun.hotspot.WhiteBox |
aoqi@0 | 33 | * @run main/othervm -Xbootclasspath/a:. -XX:+UnlockDiagnosticVMOptions |
aoqi@0 | 34 | * -XX:+WhiteBoxAPI TestRTMSpinLoopCount |
aoqi@0 | 35 | */ |
aoqi@0 | 36 | |
aoqi@0 | 37 | import java.util.List; |
aoqi@0 | 38 | import com.oracle.java.testlibrary.*; |
aoqi@0 | 39 | import com.oracle.java.testlibrary.cli.CommandLineOptionTest; |
aoqi@0 | 40 | import com.oracle.java.testlibrary.cli.predicate.AndPredicate; |
aoqi@0 | 41 | import rtm.*; |
aoqi@0 | 42 | import rtm.predicate.SupportedCPU; |
aoqi@0 | 43 | import rtm.predicate.SupportedVM; |
aoqi@0 | 44 | |
aoqi@0 | 45 | /** |
aoqi@0 | 46 | * Test verifies that RTMSpinLoopCount increase time spent between retries |
aoqi@0 | 47 | * by comparing amount of retries done with different RTMSpinLoopCount's values. |
aoqi@0 | 48 | */ |
aoqi@0 | 49 | public class TestRTMSpinLoopCount extends CommandLineOptionTest { |
aoqi@0 | 50 | private static final int LOCKING_TIME = 1000; |
aoqi@0 | 51 | private static final int RTM_RETRY_COUNT = 1000; |
aoqi@0 | 52 | private static final boolean INFLATE_MONITOR = true; |
aoqi@0 | 53 | private static final long MAX_ABORTS = RTM_RETRY_COUNT + 1L; |
aoqi@0 | 54 | private static final int[] SPIN_LOOP_COUNTS |
aoqi@0 | 55 | = new int[] { 0, 100, 1_000, 1_000_000, 10_000_000 }; |
aoqi@0 | 56 | |
aoqi@0 | 57 | private TestRTMSpinLoopCount() { |
aoqi@0 | 58 | super(new AndPredicate(new SupportedVM(), new SupportedCPU())); |
aoqi@0 | 59 | } |
aoqi@0 | 60 | |
aoqi@0 | 61 | @Override |
aoqi@0 | 62 | protected void runTestCases() throws Throwable { |
aoqi@0 | 63 | long[] aborts = new long[TestRTMSpinLoopCount.SPIN_LOOP_COUNTS.length]; |
aoqi@0 | 64 | for (int i = 0; i < TestRTMSpinLoopCount.SPIN_LOOP_COUNTS.length; i++) { |
aoqi@0 | 65 | aborts[i] = getAbortsCountOnLockBusy( |
aoqi@0 | 66 | TestRTMSpinLoopCount.SPIN_LOOP_COUNTS[i]); |
aoqi@0 | 67 | } |
aoqi@0 | 68 | |
aoqi@0 | 69 | for (int i = 1; i < aborts.length; i++) { |
aoqi@0 | 70 | Asserts.assertLTE(aborts[i], aborts[i - 1], "Increased spin loop " |
aoqi@0 | 71 | + "count should not increase retries count."); |
aoqi@0 | 72 | } |
aoqi@0 | 73 | } |
aoqi@0 | 74 | |
aoqi@0 | 75 | private long getAbortsCountOnLockBusy(int spinLoopCount) throws Throwable { |
aoqi@0 | 76 | CompilableTest test = new BusyLock(); |
aoqi@0 | 77 | |
aoqi@0 | 78 | OutputAnalyzer outputAnalyzer = RTMTestBase.executeRTMTest( |
aoqi@0 | 79 | test, |
aoqi@0 | 80 | CommandLineOptionTest.prepareNumericFlag("RTMRetryCount", |
aoqi@0 | 81 | TestRTMSpinLoopCount.RTM_RETRY_COUNT), |
aoqi@0 | 82 | CommandLineOptionTest.prepareNumericFlag("RTMSpinLoopCount", |
aoqi@0 | 83 | spinLoopCount), |
aoqi@0 | 84 | "-XX:-UseRTMXendForLockBusy", |
aoqi@0 | 85 | "-XX:RTMTotalCountIncrRate=1", |
aoqi@0 | 86 | "-XX:+PrintPreciseRTMLockingStatistics", |
aoqi@0 | 87 | BusyLock.class.getName(), |
aoqi@0 | 88 | Boolean.toString(TestRTMSpinLoopCount.INFLATE_MONITOR), |
aoqi@0 | 89 | Integer.toString(TestRTMSpinLoopCount.LOCKING_TIME) |
aoqi@0 | 90 | ); |
aoqi@0 | 91 | |
aoqi@0 | 92 | outputAnalyzer.shouldHaveExitValue(0); |
aoqi@0 | 93 | |
aoqi@0 | 94 | List<RTMLockingStatistics> statistics = RTMLockingStatistics.fromString( |
aoqi@0 | 95 | test.getMethodWithLockName(), outputAnalyzer.getOutput()); |
aoqi@0 | 96 | |
aoqi@0 | 97 | Asserts.assertEQ(statistics.size(), 1, |
aoqi@0 | 98 | "VM output should contain exactly one entry for method " |
aoqi@0 | 99 | + test.getMethodWithLockName()); |
aoqi@0 | 100 | |
aoqi@0 | 101 | RTMLockingStatistics lock = statistics.get(0); |
aoqi@0 | 102 | |
aoqi@0 | 103 | Asserts.assertLTE(lock.getTotalAborts(), |
aoqi@0 | 104 | TestRTMSpinLoopCount.MAX_ABORTS, String.format("Total aborts " |
aoqi@0 | 105 | + "count (%d) should be less or equal to %d", |
aoqi@0 | 106 | lock.getTotalAborts(), |
aoqi@0 | 107 | TestRTMSpinLoopCount.MAX_ABORTS)); |
aoqi@0 | 108 | |
aoqi@0 | 109 | return lock.getTotalAborts(); |
aoqi@0 | 110 | } |
aoqi@0 | 111 | |
aoqi@0 | 112 | public static void main(String args[]) throws Throwable { |
aoqi@0 | 113 | new TestRTMSpinLoopCount().test(); |
aoqi@0 | 114 | } |
aoqi@0 | 115 | } |