Mon, 28 Jul 2014 15:06:38 -0700
8051344: JVM crashed in Compile::start() during method parsing w/ UseRTMDeopt turned on
Summary: call rtm_deopt() only if there were no compilation bailouts before.
Reviewed-by: kvn
aoqi@0 | 1 | /* |
aoqi@0 | 2 | * Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved. |
aoqi@0 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
aoqi@0 | 4 | * |
aoqi@0 | 5 | * This code is free software; you can redistribute it and/or modify it |
aoqi@0 | 6 | * under the terms of the GNU General Public License version 2 only, as |
aoqi@0 | 7 | * published by the Free Software Foundation. |
aoqi@0 | 8 | * |
aoqi@0 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
aoqi@0 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
aoqi@0 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
aoqi@0 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
aoqi@0 | 13 | * accompanied this code). |
aoqi@0 | 14 | * |
aoqi@0 | 15 | * You should have received a copy of the GNU General Public License version |
aoqi@0 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
aoqi@0 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
aoqi@0 | 18 | * |
aoqi@0 | 19 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
aoqi@0 | 20 | * or visit www.oracle.com if you need additional information or have any |
aoqi@0 | 21 | * questions. |
aoqi@0 | 22 | * |
aoqi@0 | 23 | */ |
aoqi@0 | 24 | |
aoqi@0 | 25 | /** |
aoqi@0 | 26 | * @test |
aoqi@0 | 27 | * @bug 8031320 |
aoqi@0 | 28 | * @summary Verify that if we use RTMDeopt, then deoptimization |
aoqi@0 | 29 | * caused by reason other then rtm_state_change will reset |
aoqi@0 | 30 | * method's RTM state. And if we don't use RTMDeopt, then |
aoqi@0 | 31 | * RTM state remain the same after such deoptimization. |
aoqi@0 | 32 | * @library /testlibrary /testlibrary/whitebox /compiler/testlibrary |
aoqi@0 | 33 | * @build TestRTMAfterNonRTMDeopt |
aoqi@0 | 34 | * @run main ClassFileInstaller sun.hotspot.WhiteBox |
aoqi@0 | 35 | * @run main/othervm -Xbootclasspath/a:. -XX:+UnlockDiagnosticVMOptions |
aoqi@0 | 36 | * -XX:+WhiteBoxAPI TestRTMAfterNonRTMDeopt |
aoqi@0 | 37 | */ |
aoqi@0 | 38 | |
aoqi@0 | 39 | import java.util.List; |
aoqi@0 | 40 | import com.oracle.java.testlibrary.*; |
aoqi@0 | 41 | import com.oracle.java.testlibrary.cli.CommandLineOptionTest; |
aoqi@0 | 42 | import com.oracle.java.testlibrary.cli.predicate.AndPredicate; |
aoqi@0 | 43 | import rtm.*; |
aoqi@0 | 44 | import rtm.predicate.SupportedCPU; |
aoqi@0 | 45 | import rtm.predicate.SupportedVM; |
aoqi@0 | 46 | import sun.misc.Unsafe; |
aoqi@0 | 47 | |
aoqi@0 | 48 | /** |
aoqi@0 | 49 | * To verify that with +UseRTMDeopt method's RTM state will be |
aoqi@0 | 50 | * changed to ProfileRTM on deoptimization unrelated to |
aoqi@0 | 51 | * rtm_state_change following sequence of events is used: |
aoqi@0 | 52 | * <pre> |
aoqi@0 | 53 | * |
aoqi@0 | 54 | * rtm state ^ |
aoqi@0 | 55 | * | |
aoqi@0 | 56 | * UseRTM | ******| ****** |
aoqi@0 | 57 | * | | |
aoqi@0 | 58 | * ProfileRTM |******| |*****| |
aoqi@0 | 59 | * | | | | |
aoqi@0 | 60 | * 0-------|-----|-----|---------------------> time |
aoqi@0 | 61 | * | | \ force abort |
aoqi@0 | 62 | * | | |
aoqi@0 | 63 | * | \ force deoptimization |
aoqi@0 | 64 | * | |
aoqi@0 | 65 | * \ force xabort |
aoqi@0 | 66 | * </pre> |
aoqi@0 | 67 | * When xabort is forced by native method call method should |
aoqi@0 | 68 | * change it's state to UseRTM, because we use RTMAbortRatio=100 |
aoqi@0 | 69 | * and low RTMLockingThreshold, so at this point actual abort |
aoqi@0 | 70 | * ratio will be below 100% and there should be enough lock |
aoqi@0 | 71 | * attempts to recompile method without RTM profiling. |
aoqi@0 | 72 | */ |
aoqi@0 | 73 | public class TestRTMAfterNonRTMDeopt extends CommandLineOptionTest { |
aoqi@0 | 74 | private static final int ABORT_THRESHOLD = 1000; |
aoqi@0 | 75 | private static final String RANGE_CHECK = "range_check"; |
aoqi@0 | 76 | |
aoqi@0 | 77 | private TestRTMAfterNonRTMDeopt() { |
aoqi@0 | 78 | super(new AndPredicate(new SupportedCPU(), new SupportedVM())); |
aoqi@0 | 79 | } |
aoqi@0 | 80 | |
aoqi@0 | 81 | @Override |
aoqi@0 | 82 | protected void runTestCases() throws Throwable { |
aoqi@0 | 83 | verifyRTMAfterDeopt(false, false); |
aoqi@0 | 84 | verifyRTMAfterDeopt(true, false); |
aoqi@0 | 85 | |
aoqi@0 | 86 | verifyRTMAfterDeopt(false, true); |
aoqi@0 | 87 | verifyRTMAfterDeopt(true, true); |
aoqi@0 | 88 | } |
aoqi@0 | 89 | |
aoqi@0 | 90 | private void verifyRTMAfterDeopt(boolean useStackLock, |
aoqi@0 | 91 | boolean useRTMDeopt) throws Throwable { |
aoqi@0 | 92 | CompilableTest test = new Test(); |
aoqi@0 | 93 | String logFile = String.format("rtm_%s_stack_lock_%s_deopt.xml", |
aoqi@0 | 94 | (useStackLock ? "use" : "no"), (useRTMDeopt ? "use" : "no")); |
aoqi@0 | 95 | |
aoqi@0 | 96 | OutputAnalyzer outputAnalyzer = RTMTestBase.executeRTMTest( |
aoqi@0 | 97 | logFile, |
aoqi@0 | 98 | test, |
aoqi@0 | 99 | "-XX:CompileThreshold=1", |
aoqi@0 | 100 | CommandLineOptionTest.prepareBooleanFlag("UseRTMForStackLocks", |
aoqi@0 | 101 | useStackLock), |
aoqi@0 | 102 | CommandLineOptionTest.prepareBooleanFlag("UseRTMDeopt", |
aoqi@0 | 103 | useRTMDeopt), |
aoqi@0 | 104 | "-XX:RTMAbortRatio=100", |
aoqi@0 | 105 | CommandLineOptionTest.prepareNumericFlag("RTMAbortThreshold", |
aoqi@0 | 106 | TestRTMAfterNonRTMDeopt.ABORT_THRESHOLD), |
aoqi@0 | 107 | CommandLineOptionTest.prepareNumericFlag("RTMLockingThreshold", |
aoqi@0 | 108 | TestRTMAfterNonRTMDeopt.ABORT_THRESHOLD / 2L), |
aoqi@0 | 109 | "-XX:RTMTotalCountIncrRate=1", |
aoqi@0 | 110 | "-XX:+PrintPreciseRTMLockingStatistics", |
aoqi@0 | 111 | Test.class.getName(), |
aoqi@0 | 112 | Boolean.toString(!useStackLock) |
aoqi@0 | 113 | ); |
aoqi@0 | 114 | |
aoqi@0 | 115 | outputAnalyzer.shouldHaveExitValue(0); |
aoqi@0 | 116 | |
aoqi@0 | 117 | int traps = RTMTestBase.firedRTMStateChangeTraps(logFile); |
aoqi@0 | 118 | |
aoqi@0 | 119 | if (useRTMDeopt) { |
aoqi@0 | 120 | Asserts.assertEQ(traps, 2, "Two uncommon traps with " |
aoqi@0 | 121 | + "reason rtm_state_change should be fired."); |
aoqi@0 | 122 | } else { |
aoqi@0 | 123 | Asserts.assertEQ(traps, 0, "No uncommon traps with " |
aoqi@0 | 124 | + "reason rtm_state_change should be fired."); |
aoqi@0 | 125 | } |
aoqi@0 | 126 | |
aoqi@0 | 127 | int rangeCheckTraps = RTMTestBase.firedUncommonTraps(logFile, |
aoqi@0 | 128 | TestRTMAfterNonRTMDeopt.RANGE_CHECK); |
aoqi@0 | 129 | |
aoqi@0 | 130 | Asserts.assertEQ(rangeCheckTraps, 1, |
aoqi@0 | 131 | "One range_check uncommon trap should be fired."); |
aoqi@0 | 132 | |
aoqi@0 | 133 | List<RTMLockingStatistics> statistics = RTMLockingStatistics.fromString( |
aoqi@0 | 134 | test.getMethodWithLockName(), outputAnalyzer.getOutput()); |
aoqi@0 | 135 | |
aoqi@0 | 136 | int expectedStatEntries = (useRTMDeopt ? 4 : 2); |
aoqi@0 | 137 | |
aoqi@0 | 138 | Asserts.assertEQ(statistics.size(), expectedStatEntries, |
aoqi@0 | 139 | String.format("VM output should contain %d RTM locking " |
aoqi@0 | 140 | + "statistics entries.", expectedStatEntries)); |
aoqi@0 | 141 | } |
aoqi@0 | 142 | |
aoqi@0 | 143 | public static class Test implements CompilableTest { |
aoqi@0 | 144 | // Following field have to be static in order to avoid escape analysis. |
aoqi@0 | 145 | @SuppressWarnings("UnsuedDeclaration") |
aoqi@0 | 146 | private static int field = 0; |
aoqi@0 | 147 | private static final int ITERATIONS = 10000; |
aoqi@0 | 148 | private static final int RANGE_CHECK_AT = ITERATIONS / 2; |
aoqi@0 | 149 | private static final Unsafe UNSAFE = Utils.getUnsafe(); |
aoqi@0 | 150 | private final Object monitor = new Object(); |
aoqi@0 | 151 | |
aoqi@0 | 152 | @Override |
aoqi@0 | 153 | public String getMethodWithLockName() { |
aoqi@0 | 154 | return this.getClass().getName() + "::forceAbort"; |
aoqi@0 | 155 | } |
aoqi@0 | 156 | |
aoqi@0 | 157 | @Override |
aoqi@0 | 158 | public String[] getMethodsToCompileNames() { |
aoqi@0 | 159 | return new String[] { |
aoqi@0 | 160 | getMethodWithLockName(), |
aoqi@0 | 161 | sun.misc.Unsafe.class.getName() + "::forceAbort" |
aoqi@0 | 162 | }; |
aoqi@0 | 163 | } |
aoqi@0 | 164 | |
aoqi@0 | 165 | public void forceAbort(int a[], boolean abort) { |
aoqi@0 | 166 | try { |
aoqi@0 | 167 | synchronized(monitor) { |
aoqi@0 | 168 | a[0]++; |
aoqi@0 | 169 | if (abort) { |
aoqi@0 | 170 | Test.field = Test.UNSAFE.addressSize(); |
aoqi@0 | 171 | } |
aoqi@0 | 172 | } |
aoqi@0 | 173 | } catch (Throwable t) { |
aoqi@0 | 174 | // suppress any throwables |
aoqi@0 | 175 | } |
aoqi@0 | 176 | } |
aoqi@0 | 177 | |
aoqi@0 | 178 | /** |
aoqi@0 | 179 | * Usage: |
aoqi@0 | 180 | * Test <inflate monitor> |
aoqi@0 | 181 | */ |
aoqi@0 | 182 | public static void main(String args[]) throws Throwable { |
aoqi@0 | 183 | Test t = new Test(); |
aoqi@0 | 184 | |
aoqi@0 | 185 | if (Boolean.valueOf(args[0])) { |
aoqi@0 | 186 | AbortProvoker.inflateMonitor(t.monitor); |
aoqi@0 | 187 | } |
aoqi@0 | 188 | |
aoqi@0 | 189 | int tmp[] = new int[1]; |
aoqi@0 | 190 | |
aoqi@0 | 191 | for (int i = 0; i < Test.ITERATIONS; i++ ) { |
aoqi@0 | 192 | if (i == Test.RANGE_CHECK_AT) { |
aoqi@0 | 193 | t.forceAbort(new int[0], false); |
aoqi@0 | 194 | } else { |
aoqi@0 | 195 | boolean isThreshold |
aoqi@0 | 196 | = (i == TestRTMAfterNonRTMDeopt.ABORT_THRESHOLD); |
aoqi@0 | 197 | boolean isThresholdPlusRange |
aoqi@0 | 198 | = (i == TestRTMAfterNonRTMDeopt.ABORT_THRESHOLD |
aoqi@0 | 199 | + Test.RANGE_CHECK_AT); |
aoqi@0 | 200 | t.forceAbort(tmp, isThreshold || isThresholdPlusRange); |
aoqi@0 | 201 | } |
aoqi@0 | 202 | } |
aoqi@0 | 203 | } |
aoqi@0 | 204 | } |
aoqi@0 | 205 | |
aoqi@0 | 206 | public static void main(String args[]) throws Throwable { |
aoqi@0 | 207 | new TestRTMAfterNonRTMDeopt().test(); |
aoqi@0 | 208 | } |
aoqi@0 | 209 | } |
aoqi@0 | 210 |