src/share/vm/opto/stringopts.cpp

Thu, 21 Nov 2013 12:30:35 -0800

author
kvn
date
Thu, 21 Nov 2013 12:30:35 -0800
changeset 6485
da862781b584
parent 6479
2113136690bc
child 6876
710a3c8b516e
child 7561
007ed0fcee27
permissions
-rw-r--r--

Merge

never@1515 1 /*
iveresov@5928 2 * Copyright (c) 2009, 2013, Oracle and/or its affiliates. All rights reserved.
never@1515 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
never@1515 4 *
never@1515 5 * This code is free software; you can redistribute it and/or modify it
never@1515 6 * under the terms of the GNU General Public License version 2 only, as
never@1515 7 * published by the Free Software Foundation.
never@1515 8 *
never@1515 9 * This code is distributed in the hope that it will be useful, but WITHOUT
never@1515 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
never@1515 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
never@1515 12 * version 2 for more details (a copy is included in the LICENSE file that
never@1515 13 * accompanied this code).
never@1515 14 *
never@1515 15 * You should have received a copy of the GNU General Public License version
never@1515 16 * 2 along with this work; if not, write to the Free Software Foundation,
never@1515 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
never@1515 18 *
trims@1907 19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
trims@1907 20 * or visit www.oracle.com if you need additional information or have any
trims@1907 21 * questions.
never@1515 22 *
never@1515 23 */
never@1515 24
stefank@2314 25 #include "precompiled.hpp"
stefank@2314 26 #include "compiler/compileLog.hpp"
stefank@2314 27 #include "opto/addnode.hpp"
stefank@2314 28 #include "opto/callGenerator.hpp"
stefank@2314 29 #include "opto/callnode.hpp"
stefank@2314 30 #include "opto/divnode.hpp"
stefank@2314 31 #include "opto/graphKit.hpp"
stefank@2314 32 #include "opto/idealKit.hpp"
stefank@2314 33 #include "opto/rootnode.hpp"
stefank@2314 34 #include "opto/runtime.hpp"
stefank@2314 35 #include "opto/stringopts.hpp"
stefank@2314 36 #include "opto/subnode.hpp"
never@1515 37
never@1515 38 #define __ kit.
never@1515 39
never@1515 40 class StringConcat : public ResourceObj {
never@1515 41 private:
never@1515 42 PhaseStringOpts* _stringopts;
never@1515 43 Node* _string_alloc;
never@1515 44 AllocateNode* _begin; // The allocation the begins the pattern
never@1515 45 CallStaticJavaNode* _end; // The final call of the pattern. Will either be
never@1515 46 // SB.toString or or String.<init>(SB.toString)
never@1515 47 bool _multiple; // indicates this is a fusion of two or more
never@1515 48 // separate StringBuilders
never@1515 49
never@1515 50 Node* _arguments; // The list of arguments to be concatenated
never@1515 51 GrowableArray<int> _mode; // into a String along with a mode flag
never@1515 52 // indicating how to treat the value.
iveresov@5928 53 Node_List _constructors; // List of constructors (many in case of stacked concat)
never@1515 54 Node_List _control; // List of control nodes that will be deleted
never@1515 55 Node_List _uncommon_traps; // Uncommon traps that needs to be rewritten
never@1515 56 // to restart at the initial JVMState.
iveresov@5928 57
never@1515 58 public:
never@1515 59 // Mode for converting arguments to Strings
never@1515 60 enum {
never@1515 61 StringMode,
never@1515 62 IntMode,
kvn@2413 63 CharMode,
kvn@2413 64 StringNullCheckMode
never@1515 65 };
never@1515 66
never@1515 67 StringConcat(PhaseStringOpts* stringopts, CallStaticJavaNode* end):
never@1515 68 _end(end),
never@1515 69 _begin(NULL),
never@1515 70 _multiple(false),
never@1515 71 _string_alloc(NULL),
never@1515 72 _stringopts(stringopts) {
kvn@4115 73 _arguments = new (_stringopts->C) Node(1);
never@1515 74 _arguments->del_req(0);
never@1515 75 }
never@1515 76
iveresov@5928 77 bool validate_mem_flow();
never@1515 78 bool validate_control_flow();
never@1515 79
never@1515 80 void merge_add() {
never@1515 81 #if 0
never@1515 82 // XXX This is place holder code for reusing an existing String
never@1515 83 // allocation but the logic for checking the state safety is
never@1515 84 // probably inadequate at the moment.
never@1515 85 CallProjections endprojs;
never@1515 86 sc->end()->extract_projections(&endprojs, false);
never@1515 87 if (endprojs.resproj != NULL) {
never@1515 88 for (SimpleDUIterator i(endprojs.resproj); i.has_next(); i.next()) {
never@1515 89 CallStaticJavaNode *use = i.get()->isa_CallStaticJava();
never@1515 90 if (use != NULL && use->method() != NULL &&
never@2172 91 use->method()->intrinsic_id() == vmIntrinsics::_String_String &&
never@1515 92 use->in(TypeFunc::Parms + 1) == endprojs.resproj) {
never@1515 93 // Found useless new String(sb.toString()) so reuse the newly allocated String
never@1515 94 // when creating the result instead of allocating a new one.
never@1515 95 sc->set_string_alloc(use->in(TypeFunc::Parms));
never@1515 96 sc->set_end(use);
never@1515 97 }
never@1515 98 }
never@1515 99 }
never@1515 100 #endif
never@1515 101 }
never@1515 102
never@1515 103 StringConcat* merge(StringConcat* other, Node* arg);
never@1515 104
never@1515 105 void set_allocation(AllocateNode* alloc) {
never@1515 106 _begin = alloc;
never@1515 107 }
never@1515 108
never@1515 109 void append(Node* value, int mode) {
never@1515 110 _arguments->add_req(value);
never@1515 111 _mode.append(mode);
never@1515 112 }
never@1515 113 void push(Node* value, int mode) {
never@1515 114 _arguments->ins_req(0, value);
never@1515 115 _mode.insert_before(0, mode);
never@1515 116 }
kvn@3889 117
never@1515 118 void push_string(Node* value) {
never@1515 119 push(value, StringMode);
never@1515 120 }
kvn@2413 121 void push_string_null_check(Node* value) {
kvn@2413 122 push(value, StringNullCheckMode);
kvn@2413 123 }
never@1515 124 void push_int(Node* value) {
never@1515 125 push(value, IntMode);
never@1515 126 }
never@1515 127 void push_char(Node* value) {
never@1515 128 push(value, CharMode);
never@1515 129 }
never@1515 130
kvn@3889 131 static bool is_SB_toString(Node* call) {
kvn@3889 132 if (call->is_CallStaticJava()) {
kvn@3889 133 CallStaticJavaNode* csj = call->as_CallStaticJava();
kvn@3889 134 ciMethod* m = csj->method();
kvn@3889 135 if (m != NULL &&
kvn@3889 136 (m->intrinsic_id() == vmIntrinsics::_StringBuilder_toString ||
kvn@3889 137 m->intrinsic_id() == vmIntrinsics::_StringBuffer_toString)) {
kvn@3889 138 return true;
kvn@3889 139 }
kvn@3889 140 }
kvn@3889 141 return false;
kvn@3889 142 }
kvn@3889 143
kvn@3889 144 static Node* skip_string_null_check(Node* value) {
kvn@3889 145 // Look for a diamond shaped Null check of toString() result
kvn@3889 146 // (could be code from String.valueOf()):
kvn@3889 147 // (Proj == NULL) ? "null":"CastPP(Proj)#NotNULL
kvn@3889 148 if (value->is_Phi()) {
kvn@3889 149 int true_path = value->as_Phi()->is_diamond_phi();
kvn@3889 150 if (true_path != 0) {
kvn@3889 151 // phi->region->if_proj->ifnode->bool
kvn@3889 152 BoolNode* b = value->in(0)->in(1)->in(0)->in(1)->as_Bool();
kvn@3889 153 Node* cmp = b->in(1);
kvn@3889 154 Node* v1 = cmp->in(1);
kvn@3889 155 Node* v2 = cmp->in(2);
kvn@3889 156 // Null check of the return of toString which can simply be skipped.
kvn@3889 157 if (b->_test._test == BoolTest::ne &&
kvn@3889 158 v2->bottom_type() == TypePtr::NULL_PTR &&
kvn@3889 159 value->in(true_path)->Opcode() == Op_CastPP &&
kvn@3889 160 value->in(true_path)->in(1) == v1 &&
kvn@3889 161 v1->is_Proj() && is_SB_toString(v1->in(0))) {
kvn@3889 162 return v1;
kvn@3889 163 }
kvn@3889 164 }
kvn@3889 165 }
kvn@3889 166 return value;
kvn@3889 167 }
kvn@3889 168
never@1515 169 Node* argument(int i) {
never@1515 170 return _arguments->in(i);
never@1515 171 }
kvn@3889 172 Node* argument_uncast(int i) {
kvn@3889 173 Node* arg = argument(i);
kvn@3889 174 int amode = mode(i);
kvn@3889 175 if (amode == StringConcat::StringMode ||
kvn@3889 176 amode == StringConcat::StringNullCheckMode) {
kvn@3889 177 arg = skip_string_null_check(arg);
kvn@3889 178 }
kvn@3889 179 return arg;
kvn@3889 180 }
never@1515 181 void set_argument(int i, Node* value) {
never@1515 182 _arguments->set_req(i, value);
never@1515 183 }
never@1515 184 int num_arguments() {
never@1515 185 return _mode.length();
never@1515 186 }
never@1515 187 int mode(int i) {
never@1515 188 return _mode.at(i);
never@1515 189 }
never@1515 190 void add_control(Node* ctrl) {
never@1515 191 assert(!_control.contains(ctrl), "only push once");
never@1515 192 _control.push(ctrl);
never@1515 193 }
iveresov@5928 194 void add_constructor(Node* init) {
iveresov@5928 195 assert(!_constructors.contains(init), "only push once");
iveresov@5928 196 _constructors.push(init);
iveresov@5928 197 }
never@1515 198 CallStaticJavaNode* end() { return _end; }
never@1515 199 AllocateNode* begin() { return _begin; }
never@1515 200 Node* string_alloc() { return _string_alloc; }
never@1515 201
never@1515 202 void eliminate_unneeded_control();
never@1515 203 void eliminate_initialize(InitializeNode* init);
never@1515 204 void eliminate_call(CallNode* call);
never@1515 205
never@1515 206 void maybe_log_transform() {
never@1515 207 CompileLog* log = _stringopts->C->log();
never@1515 208 if (log != NULL) {
never@1515 209 log->head("replace_string_concat arguments='%d' string_alloc='%d' multiple='%d'",
never@1515 210 num_arguments(),
never@1515 211 _string_alloc != NULL,
never@1515 212 _multiple);
never@1515 213 JVMState* p = _begin->jvms();
never@1515 214 while (p != NULL) {
never@1515 215 log->elem("jvms bci='%d' method='%d'", p->bci(), log->identify(p->method()));
never@1515 216 p = p->caller();
never@1515 217 }
never@1515 218 log->tail("replace_string_concat");
never@1515 219 }
never@1515 220 }
never@1515 221
never@1515 222 void convert_uncommon_traps(GraphKit& kit, const JVMState* jvms) {
never@1515 223 for (uint u = 0; u < _uncommon_traps.size(); u++) {
never@1515 224 Node* uct = _uncommon_traps.at(u);
never@1515 225
never@1515 226 // Build a new call using the jvms state of the allocate
twisti@2103 227 address call_addr = SharedRuntime::uncommon_trap_blob()->entry_point();
never@1515 228 const TypeFunc* call_type = OptoRuntime::uncommon_trap_Type();
never@1515 229 const TypePtr* no_memory_effects = NULL;
never@1515 230 Compile* C = _stringopts->C;
kvn@4115 231 CallStaticJavaNode* call = new (C) CallStaticJavaNode(call_type, call_addr, "uncommon_trap",
kvn@4115 232 jvms->bci(), no_memory_effects);
never@1515 233 for (int e = 0; e < TypeFunc::Parms; e++) {
never@1515 234 call->init_req(e, uct->in(e));
never@1515 235 }
never@1515 236 // Set the trap request to record intrinsic failure if this trap
never@1515 237 // is taken too many times. Ideally we would handle then traps by
never@1515 238 // doing the original bookkeeping in the MDO so that if it caused
never@1515 239 // the code to be thrown out we could still recompile and use the
never@1515 240 // optimization. Failing the uncommon traps doesn't really mean
never@1515 241 // that the optimization is a bad idea but there's no other way to
never@1515 242 // do the MDO updates currently.
never@1515 243 int trap_request = Deoptimization::make_trap_request(Deoptimization::Reason_intrinsic,
never@1515 244 Deoptimization::Action_make_not_entrant);
never@1515 245 call->init_req(TypeFunc::Parms, __ intcon(trap_request));
never@1515 246 kit.add_safepoint_edges(call);
never@1515 247
never@1515 248 _stringopts->gvn()->transform(call);
never@1515 249 C->gvn_replace_by(uct, call);
bharadwaj@4315 250 uct->disconnect_inputs(NULL, C);
never@1515 251 }
never@1515 252 }
never@1515 253
never@1515 254 void cleanup() {
never@1515 255 // disconnect the hook node
bharadwaj@4315 256 _arguments->disconnect_inputs(NULL, _stringopts->C);
never@1515 257 }
never@1515 258 };
never@1515 259
never@1515 260
never@1515 261 void StringConcat::eliminate_unneeded_control() {
never@1515 262 for (uint i = 0; i < _control.size(); i++) {
never@1515 263 Node* n = _control.at(i);
kvn@3889 264 if (n->is_Allocate()) {
kvn@3889 265 eliminate_initialize(n->as_Allocate()->initialization());
kvn@3889 266 }
never@1515 267 if (n->is_Call()) {
never@1515 268 if (n != _end) {
never@1515 269 eliminate_call(n->as_Call());
never@1515 270 }
never@1515 271 } else if (n->is_IfTrue()) {
never@1515 272 Compile* C = _stringopts->C;
never@1515 273 C->gvn_replace_by(n, n->in(0)->in(0));
roland@4409 274 // get rid of the other projection
roland@4409 275 C->gvn_replace_by(n->in(0)->as_If()->proj_out(false), C->top());
never@1515 276 }
never@1515 277 }
never@1515 278 }
never@1515 279
never@1515 280
never@1515 281 StringConcat* StringConcat::merge(StringConcat* other, Node* arg) {
never@1515 282 StringConcat* result = new StringConcat(_stringopts, _end);
never@1515 283 for (uint x = 0; x < _control.size(); x++) {
never@1515 284 Node* n = _control.at(x);
never@1515 285 if (n->is_Call()) {
never@1515 286 result->_control.push(n);
never@1515 287 }
never@1515 288 }
never@1515 289 for (uint x = 0; x < other->_control.size(); x++) {
never@1515 290 Node* n = other->_control.at(x);
never@1515 291 if (n->is_Call()) {
never@1515 292 result->_control.push(n);
never@1515 293 }
never@1515 294 }
never@1515 295 assert(result->_control.contains(other->_end), "what?");
never@1515 296 assert(result->_control.contains(_begin), "what?");
never@1515 297 for (int x = 0; x < num_arguments(); x++) {
kvn@3889 298 Node* argx = argument_uncast(x);
kvn@3889 299 if (argx == arg) {
never@1515 300 // replace the toString result with the all the arguments that
never@1515 301 // made up the other StringConcat
never@1515 302 for (int y = 0; y < other->num_arguments(); y++) {
never@1515 303 result->append(other->argument(y), other->mode(y));
never@1515 304 }
never@1515 305 } else {
kvn@3889 306 result->append(argx, mode(x));
never@1515 307 }
never@1515 308 }
never@1515 309 result->set_allocation(other->_begin);
iveresov@5928 310 for (uint i = 0; i < _constructors.size(); i++) {
iveresov@5928 311 result->add_constructor(_constructors.at(i));
iveresov@5928 312 }
iveresov@5928 313 for (uint i = 0; i < other->_constructors.size(); i++) {
iveresov@5928 314 result->add_constructor(other->_constructors.at(i));
iveresov@5928 315 }
never@1515 316 result->_multiple = true;
never@1515 317 return result;
never@1515 318 }
never@1515 319
never@1515 320
never@1515 321 void StringConcat::eliminate_call(CallNode* call) {
never@1515 322 Compile* C = _stringopts->C;
never@1515 323 CallProjections projs;
never@1515 324 call->extract_projections(&projs, false);
never@1515 325 if (projs.fallthrough_catchproj != NULL) {
never@1515 326 C->gvn_replace_by(projs.fallthrough_catchproj, call->in(TypeFunc::Control));
never@1515 327 }
never@1515 328 if (projs.fallthrough_memproj != NULL) {
never@1515 329 C->gvn_replace_by(projs.fallthrough_memproj, call->in(TypeFunc::Memory));
never@1515 330 }
never@1515 331 if (projs.catchall_memproj != NULL) {
never@1515 332 C->gvn_replace_by(projs.catchall_memproj, C->top());
never@1515 333 }
never@1515 334 if (projs.fallthrough_ioproj != NULL) {
never@1515 335 C->gvn_replace_by(projs.fallthrough_ioproj, call->in(TypeFunc::I_O));
never@1515 336 }
never@1515 337 if (projs.catchall_ioproj != NULL) {
never@1515 338 C->gvn_replace_by(projs.catchall_ioproj, C->top());
never@1515 339 }
never@1515 340 if (projs.catchall_catchproj != NULL) {
never@1515 341 // EA can't cope with the partially collapsed graph this
never@1515 342 // creates so put it on the worklist to be collapsed later.
never@1515 343 for (SimpleDUIterator i(projs.catchall_catchproj); i.has_next(); i.next()) {
never@1515 344 Node *use = i.get();
never@1515 345 int opc = use->Opcode();
never@1515 346 if (opc == Op_CreateEx || opc == Op_Region) {
never@1515 347 _stringopts->record_dead_node(use);
never@1515 348 }
never@1515 349 }
never@1515 350 C->gvn_replace_by(projs.catchall_catchproj, C->top());
never@1515 351 }
never@1515 352 if (projs.resproj != NULL) {
never@1515 353 C->gvn_replace_by(projs.resproj, C->top());
never@1515 354 }
never@1515 355 C->gvn_replace_by(call, C->top());
never@1515 356 }
never@1515 357
never@1515 358 void StringConcat::eliminate_initialize(InitializeNode* init) {
never@1515 359 Compile* C = _stringopts->C;
never@1515 360
never@1515 361 // Eliminate Initialize node.
never@1515 362 assert(init->outcnt() <= 2, "only a control and memory projection expected");
never@1515 363 assert(init->req() <= InitializeNode::RawStores, "no pending inits");
never@1515 364 Node *ctrl_proj = init->proj_out(TypeFunc::Control);
never@1515 365 if (ctrl_proj != NULL) {
never@1515 366 C->gvn_replace_by(ctrl_proj, init->in(TypeFunc::Control));
never@1515 367 }
never@1515 368 Node *mem_proj = init->proj_out(TypeFunc::Memory);
never@1515 369 if (mem_proj != NULL) {
never@1515 370 Node *mem = init->in(TypeFunc::Memory);
never@1515 371 C->gvn_replace_by(mem_proj, mem);
never@1515 372 }
never@1515 373 C->gvn_replace_by(init, C->top());
bharadwaj@4315 374 init->disconnect_inputs(NULL, C);
never@1515 375 }
never@1515 376
never@1515 377 Node_List PhaseStringOpts::collect_toString_calls() {
never@1515 378 Node_List string_calls;
never@1515 379 Node_List worklist;
never@1515 380
never@1515 381 _visited.Clear();
never@1515 382
never@1515 383 // Prime the worklist
never@1515 384 for (uint i = 1; i < C->root()->len(); i++) {
never@1515 385 Node* n = C->root()->in(i);
never@1515 386 if (n != NULL && !_visited.test_set(n->_idx)) {
never@1515 387 worklist.push(n);
never@1515 388 }
never@1515 389 }
never@1515 390
never@1515 391 while (worklist.size() > 0) {
never@1515 392 Node* ctrl = worklist.pop();
kvn@3889 393 if (StringConcat::is_SB_toString(ctrl)) {
never@1515 394 CallStaticJavaNode* csj = ctrl->as_CallStaticJava();
kvn@3889 395 string_calls.push(csj);
never@1515 396 }
never@1515 397 if (ctrl->in(0) != NULL && !_visited.test_set(ctrl->in(0)->_idx)) {
never@1515 398 worklist.push(ctrl->in(0));
never@1515 399 }
never@1515 400 if (ctrl->is_Region()) {
never@1515 401 for (uint i = 1; i < ctrl->len(); i++) {
never@1515 402 if (ctrl->in(i) != NULL && !_visited.test_set(ctrl->in(i)->_idx)) {
never@1515 403 worklist.push(ctrl->in(i));
never@1515 404 }
never@1515 405 }
never@1515 406 }
never@1515 407 }
never@1515 408 return string_calls;
never@1515 409 }
never@1515 410
never@1515 411
never@1515 412 StringConcat* PhaseStringOpts::build_candidate(CallStaticJavaNode* call) {
never@1515 413 ciMethod* m = call->method();
never@1515 414 ciSymbol* string_sig;
never@1515 415 ciSymbol* int_sig;
never@1515 416 ciSymbol* char_sig;
never@1515 417 if (m->holder() == C->env()->StringBuilder_klass()) {
never@1515 418 string_sig = ciSymbol::String_StringBuilder_signature();
never@1515 419 int_sig = ciSymbol::int_StringBuilder_signature();
never@1515 420 char_sig = ciSymbol::char_StringBuilder_signature();
never@1515 421 } else if (m->holder() == C->env()->StringBuffer_klass()) {
never@1515 422 string_sig = ciSymbol::String_StringBuffer_signature();
never@1515 423 int_sig = ciSymbol::int_StringBuffer_signature();
never@1515 424 char_sig = ciSymbol::char_StringBuffer_signature();
never@1515 425 } else {
never@1515 426 return NULL;
never@1515 427 }
never@1515 428 #ifndef PRODUCT
never@1515 429 if (PrintOptimizeStringConcat) {
never@1515 430 tty->print("considering toString call in ");
never@1515 431 call->jvms()->dump_spec(tty); tty->cr();
never@1515 432 }
never@1515 433 #endif
never@1515 434
never@1515 435 StringConcat* sc = new StringConcat(this, call);
never@1515 436
never@1515 437 AllocateNode* alloc = NULL;
never@1515 438 InitializeNode* init = NULL;
never@1515 439
never@1515 440 // possible opportunity for StringBuilder fusion
never@1515 441 CallStaticJavaNode* cnode = call;
never@1515 442 while (cnode) {
never@1515 443 Node* recv = cnode->in(TypeFunc::Parms)->uncast();
never@1515 444 if (recv->is_Proj()) {
never@1515 445 recv = recv->in(0);
never@1515 446 }
never@1515 447 cnode = recv->isa_CallStaticJava();
never@1515 448 if (cnode == NULL) {
never@1515 449 alloc = recv->isa_Allocate();
never@1515 450 if (alloc == NULL) {
never@1515 451 break;
never@1515 452 }
never@1515 453 // Find the constructor call
never@1515 454 Node* result = alloc->result_cast();
roland@4409 455 if (result == NULL || !result->is_CheckCastPP() || alloc->in(TypeFunc::Memory)->is_top()) {
never@1515 456 // strange looking allocation
never@1515 457 #ifndef PRODUCT
never@1515 458 if (PrintOptimizeStringConcat) {
never@1515 459 tty->print("giving up because allocation looks strange ");
never@1515 460 alloc->jvms()->dump_spec(tty); tty->cr();
never@1515 461 }
never@1515 462 #endif
never@1515 463 break;
never@1515 464 }
never@1515 465 Node* constructor = NULL;
never@1515 466 for (SimpleDUIterator i(result); i.has_next(); i.next()) {
never@1515 467 CallStaticJavaNode *use = i.get()->isa_CallStaticJava();
never@2172 468 if (use != NULL &&
never@2172 469 use->method() != NULL &&
never@2172 470 !use->method()->is_static() &&
never@1515 471 use->method()->name() == ciSymbol::object_initializer_name() &&
never@1515 472 use->method()->holder() == m->holder()) {
never@1515 473 // Matched the constructor.
never@1515 474 ciSymbol* sig = use->method()->signature()->as_symbol();
never@1515 475 if (sig == ciSymbol::void_method_signature() ||
never@1515 476 sig == ciSymbol::int_void_signature() ||
never@1515 477 sig == ciSymbol::string_void_signature()) {
never@1515 478 if (sig == ciSymbol::string_void_signature()) {
never@1515 479 // StringBuilder(String) so pick this up as the first argument
never@1515 480 assert(use->in(TypeFunc::Parms + 1) != NULL, "what?");
kvn@2413 481 const Type* type = _gvn->type(use->in(TypeFunc::Parms + 1));
kvn@2413 482 if (type == TypePtr::NULL_PTR) {
kvn@2413 483 // StringBuilder(null) throws exception.
kvn@2413 484 #ifndef PRODUCT
kvn@2413 485 if (PrintOptimizeStringConcat) {
kvn@2413 486 tty->print("giving up because StringBuilder(null) throws exception");
kvn@2413 487 alloc->jvms()->dump_spec(tty); tty->cr();
kvn@2413 488 }
kvn@2413 489 #endif
kvn@2413 490 return NULL;
kvn@2413 491 }
kvn@2413 492 // StringBuilder(str) argument needs null check.
kvn@2413 493 sc->push_string_null_check(use->in(TypeFunc::Parms + 1));
never@1515 494 }
never@1515 495 // The int variant takes an initial size for the backing
never@1515 496 // array so just treat it like the void version.
never@1515 497 constructor = use;
never@1515 498 } else {
never@1515 499 #ifndef PRODUCT
never@1515 500 if (PrintOptimizeStringConcat) {
never@1515 501 tty->print("unexpected constructor signature: %s", sig->as_utf8());
never@1515 502 }
never@1515 503 #endif
never@1515 504 }
never@1515 505 break;
never@1515 506 }
never@1515 507 }
never@1515 508 if (constructor == NULL) {
never@1515 509 // couldn't find constructor
never@1515 510 #ifndef PRODUCT
never@1515 511 if (PrintOptimizeStringConcat) {
never@1515 512 tty->print("giving up because couldn't find constructor ");
kvn@2413 513 alloc->jvms()->dump_spec(tty); tty->cr();
never@1515 514 }
never@1515 515 #endif
never@1515 516 break;
never@1515 517 }
never@1515 518
never@1515 519 // Walked all the way back and found the constructor call so see
never@1515 520 // if this call converted into a direct string concatenation.
never@1515 521 sc->add_control(call);
never@1515 522 sc->add_control(constructor);
never@1515 523 sc->add_control(alloc);
never@1515 524 sc->set_allocation(alloc);
iveresov@5928 525 sc->add_constructor(constructor);
iveresov@5928 526 if (sc->validate_control_flow() && sc->validate_mem_flow()) {
never@1515 527 return sc;
never@1515 528 } else {
never@1515 529 return NULL;
never@1515 530 }
never@1515 531 } else if (cnode->method() == NULL) {
never@1515 532 break;
never@2172 533 } else if (!cnode->method()->is_static() &&
never@2172 534 cnode->method()->holder() == m->holder() &&
never@1515 535 cnode->method()->name() == ciSymbol::append_name() &&
never@1515 536 (cnode->method()->signature()->as_symbol() == string_sig ||
never@1515 537 cnode->method()->signature()->as_symbol() == char_sig ||
never@1515 538 cnode->method()->signature()->as_symbol() == int_sig)) {
never@1515 539 sc->add_control(cnode);
never@1515 540 Node* arg = cnode->in(TypeFunc::Parms + 1);
never@1515 541 if (cnode->method()->signature()->as_symbol() == int_sig) {
never@1515 542 sc->push_int(arg);
never@1515 543 } else if (cnode->method()->signature()->as_symbol() == char_sig) {
never@1515 544 sc->push_char(arg);
never@1515 545 } else {
never@1515 546 if (arg->is_Proj() && arg->in(0)->is_CallStaticJava()) {
never@1515 547 CallStaticJavaNode* csj = arg->in(0)->as_CallStaticJava();
never@1515 548 if (csj->method() != NULL &&
kvn@3927 549 csj->method()->intrinsic_id() == vmIntrinsics::_Integer_toString &&
kvn@3927 550 arg->outcnt() == 1) {
kvn@3927 551 // _control is the list of StringBuilder calls nodes which
kvn@3927 552 // will be replaced by new String code after this optimization.
kvn@3927 553 // Integer::toString() call is not part of StringBuilder calls
kvn@3927 554 // chain. It could be eliminated only if its result is used
kvn@3927 555 // only by this SB calls chain.
kvn@3927 556 // Another limitation: it should be used only once because
kvn@3927 557 // it is unknown that it is used only by this SB calls chain
kvn@3927 558 // until all related SB calls nodes are collected.
kvn@3927 559 assert(arg->unique_out() == cnode, "sanity");
never@1515 560 sc->add_control(csj);
never@1515 561 sc->push_int(csj->in(TypeFunc::Parms));
never@1515 562 continue;
never@1515 563 }
never@1515 564 }
never@1515 565 sc->push_string(arg);
never@1515 566 }
never@1515 567 continue;
never@1515 568 } else {
never@1515 569 // some unhandled signature
never@1515 570 #ifndef PRODUCT
never@1515 571 if (PrintOptimizeStringConcat) {
never@1515 572 tty->print("giving up because encountered unexpected signature ");
never@1515 573 cnode->tf()->dump(); tty->cr();
never@1515 574 cnode->in(TypeFunc::Parms + 1)->dump();
never@1515 575 }
never@1515 576 #endif
never@1515 577 break;
never@1515 578 }
never@1515 579 }
never@1515 580 return NULL;
never@1515 581 }
never@1515 582
never@1515 583
never@1515 584 PhaseStringOpts::PhaseStringOpts(PhaseGVN* gvn, Unique_Node_List*):
never@1515 585 Phase(StringOpts),
never@1515 586 _gvn(gvn),
never@1515 587 _visited(Thread::current()->resource_area()) {
never@1515 588
never@1515 589 assert(OptimizeStringConcat, "shouldn't be here");
never@1515 590
never@1515 591 size_table_field = C->env()->Integer_klass()->get_field_by_name(ciSymbol::make("sizeTable"),
never@1515 592 ciSymbol::make("[I"), true);
never@1515 593 if (size_table_field == NULL) {
never@1515 594 // Something wrong so give up.
never@1515 595 assert(false, "why can't we find Integer.sizeTable?");
never@1515 596 return;
never@1515 597 }
never@1515 598
never@1515 599 // Collect the types needed to talk about the various slices of memory
never@1515 600 char_adr_idx = C->get_alias_index(TypeAryPtr::CHARS);
never@1515 601
never@1515 602 // For each locally allocated StringBuffer see if the usages can be
never@1515 603 // collapsed into a single String construction.
never@1515 604
never@1515 605 // Run through the list of allocation looking for SB.toString to see
never@1515 606 // if it's possible to fuse the usage of the SB into a single String
never@1515 607 // construction.
never@1515 608 GrowableArray<StringConcat*> concats;
never@1515 609 Node_List toStrings = collect_toString_calls();
never@1515 610 while (toStrings.size() > 0) {
never@1515 611 StringConcat* sc = build_candidate(toStrings.pop()->as_CallStaticJava());
never@1515 612 if (sc != NULL) {
never@1515 613 concats.push(sc);
never@1515 614 }
never@1515 615 }
never@1515 616
never@1515 617 // try to coalesce separate concats
never@1515 618 restart:
never@1515 619 for (int c = 0; c < concats.length(); c++) {
never@1515 620 StringConcat* sc = concats.at(c);
never@1515 621 for (int i = 0; i < sc->num_arguments(); i++) {
kvn@3889 622 Node* arg = sc->argument_uncast(i);
kvn@3889 623 if (arg->is_Proj() && StringConcat::is_SB_toString(arg->in(0))) {
never@1515 624 CallStaticJavaNode* csj = arg->in(0)->as_CallStaticJava();
kvn@3889 625 for (int o = 0; o < concats.length(); o++) {
kvn@3889 626 if (c == o) continue;
kvn@3889 627 StringConcat* other = concats.at(o);
kvn@3889 628 if (other->end() == csj) {
kvn@3889 629 #ifndef PRODUCT
kvn@3889 630 if (PrintOptimizeStringConcat) {
kvn@3889 631 tty->print_cr("considering stacked concats");
kvn@3889 632 }
kvn@3889 633 #endif
kvn@3889 634
kvn@3889 635 StringConcat* merged = sc->merge(other, arg);
iveresov@5928 636 if (merged->validate_control_flow() && merged->validate_mem_flow()) {
never@1515 637 #ifndef PRODUCT
never@1515 638 if (PrintOptimizeStringConcat) {
kvn@3889 639 tty->print_cr("stacking would succeed");
never@1515 640 }
never@1515 641 #endif
kvn@3889 642 if (c < o) {
kvn@3889 643 concats.remove_at(o);
kvn@3889 644 concats.at_put(c, merged);
kvn@3889 645 } else {
kvn@3889 646 concats.remove_at(c);
kvn@3889 647 concats.at_put(o, merged);
kvn@3889 648 }
kvn@3889 649 goto restart;
kvn@3889 650 } else {
never@1515 651 #ifndef PRODUCT
kvn@3889 652 if (PrintOptimizeStringConcat) {
kvn@3889 653 tty->print_cr("stacking would fail");
kvn@3889 654 }
never@1515 655 #endif
never@1515 656 }
never@1515 657 }
never@1515 658 }
never@1515 659 }
never@1515 660 }
never@1515 661 }
never@1515 662
never@1515 663
never@1515 664 for (int c = 0; c < concats.length(); c++) {
never@1515 665 StringConcat* sc = concats.at(c);
never@1515 666 replace_string_concat(sc);
never@1515 667 }
never@1515 668
never@1515 669 remove_dead_nodes();
never@1515 670 }
never@1515 671
never@1515 672 void PhaseStringOpts::record_dead_node(Node* dead) {
never@1515 673 dead_worklist.push(dead);
never@1515 674 }
never@1515 675
never@1515 676 void PhaseStringOpts::remove_dead_nodes() {
never@1515 677 // Delete any dead nodes to make things clean enough that escape
never@1515 678 // analysis doesn't get unhappy.
never@1515 679 while (dead_worklist.size() > 0) {
never@1515 680 Node* use = dead_worklist.pop();
never@1515 681 int opc = use->Opcode();
never@1515 682 switch (opc) {
never@1515 683 case Op_Region: {
never@1515 684 uint i = 1;
never@1515 685 for (i = 1; i < use->req(); i++) {
never@1515 686 if (use->in(i) != C->top()) {
never@1515 687 break;
never@1515 688 }
never@1515 689 }
never@1515 690 if (i >= use->req()) {
never@1515 691 for (SimpleDUIterator i(use); i.has_next(); i.next()) {
never@1515 692 Node* m = i.get();
never@1515 693 if (m->is_Phi()) {
never@1515 694 dead_worklist.push(m);
never@1515 695 }
never@1515 696 }
never@1515 697 C->gvn_replace_by(use, C->top());
never@1515 698 }
never@1515 699 break;
never@1515 700 }
never@1515 701 case Op_AddP:
never@1515 702 case Op_CreateEx: {
never@1515 703 // Recurisvely clean up references to CreateEx so EA doesn't
never@1515 704 // get unhappy about the partially collapsed graph.
never@1515 705 for (SimpleDUIterator i(use); i.has_next(); i.next()) {
never@1515 706 Node* m = i.get();
never@1515 707 if (m->is_AddP()) {
never@1515 708 dead_worklist.push(m);
never@1515 709 }
never@1515 710 }
never@1515 711 C->gvn_replace_by(use, C->top());
never@1515 712 break;
never@1515 713 }
never@1515 714 case Op_Phi:
never@1515 715 if (use->in(0) == C->top()) {
never@1515 716 C->gvn_replace_by(use, C->top());
never@1515 717 }
never@1515 718 break;
never@1515 719 }
never@1515 720 }
never@1515 721 }
never@1515 722
never@1515 723
iveresov@5928 724 bool StringConcat::validate_mem_flow() {
iveresov@5928 725 Compile* C = _stringopts->C;
iveresov@5928 726
iveresov@5928 727 for (uint i = 0; i < _control.size(); i++) {
iveresov@5928 728 #ifndef PRODUCT
iveresov@5928 729 Node_List path;
iveresov@5928 730 #endif
iveresov@5928 731 Node* curr = _control.at(i);
iveresov@5928 732 if (curr->is_Call() && curr != _begin) { // For all calls except the first allocation
iveresov@5928 733 // Now here's the main invariant in our case:
iveresov@5928 734 // For memory between the constructor, and appends, and toString we should only see bottom memory,
iveresov@5928 735 // produced by the previous call we know about.
iveresov@5928 736 if (!_constructors.contains(curr)) {
iveresov@5928 737 NOT_PRODUCT(path.push(curr);)
iveresov@5928 738 Node* mem = curr->in(TypeFunc::Memory);
iveresov@5928 739 assert(mem != NULL, "calls should have memory edge");
iveresov@5928 740 assert(!mem->is_Phi(), "should be handled by control flow validation");
iveresov@5928 741 NOT_PRODUCT(path.push(mem);)
iveresov@5928 742 while (mem->is_MergeMem()) {
iveresov@5928 743 for (uint i = 1; i < mem->req(); i++) {
iveresov@5928 744 if (i != Compile::AliasIdxBot && mem->in(i) != C->top()) {
iveresov@5928 745 #ifndef PRODUCT
iveresov@5928 746 if (PrintOptimizeStringConcat) {
iveresov@5928 747 tty->print("fusion has incorrect memory flow (side effects) for ");
iveresov@5928 748 _begin->jvms()->dump_spec(tty); tty->cr();
iveresov@5928 749 path.dump();
iveresov@5928 750 }
iveresov@5928 751 #endif
iveresov@5928 752 return false;
iveresov@5928 753 }
iveresov@5928 754 }
iveresov@5928 755 // skip through a potential MergeMem chain, linked through Bot
iveresov@5928 756 mem = mem->in(Compile::AliasIdxBot);
iveresov@5928 757 NOT_PRODUCT(path.push(mem);)
iveresov@5928 758 }
iveresov@5928 759 // now let it fall through, and see if we have a projection
iveresov@5928 760 if (mem->is_Proj()) {
iveresov@5928 761 // Should point to a previous known call
iveresov@5928 762 Node *prev = mem->in(0);
iveresov@5928 763 NOT_PRODUCT(path.push(prev);)
iveresov@5928 764 if (!prev->is_Call() || !_control.contains(prev)) {
iveresov@5928 765 #ifndef PRODUCT
iveresov@5928 766 if (PrintOptimizeStringConcat) {
iveresov@5928 767 tty->print("fusion has incorrect memory flow (unknown call) for ");
iveresov@5928 768 _begin->jvms()->dump_spec(tty); tty->cr();
iveresov@5928 769 path.dump();
iveresov@5928 770 }
iveresov@5928 771 #endif
iveresov@5928 772 return false;
iveresov@5928 773 }
iveresov@5928 774 } else {
iveresov@5928 775 assert(mem->is_Store() || mem->is_LoadStore(), err_msg_res("unexpected node type: %s", mem->Name()));
iveresov@5928 776 #ifndef PRODUCT
iveresov@5928 777 if (PrintOptimizeStringConcat) {
iveresov@5928 778 tty->print("fusion has incorrect memory flow (unexpected source) for ");
iveresov@5928 779 _begin->jvms()->dump_spec(tty); tty->cr();
iveresov@5928 780 path.dump();
iveresov@5928 781 }
iveresov@5928 782 #endif
iveresov@5928 783 return false;
iveresov@5928 784 }
iveresov@5928 785 } else {
iveresov@5928 786 // For memory that feeds into constructors it's more complicated.
iveresov@5928 787 // However the advantage is that any side effect that happens between the Allocate/Initialize and
iveresov@5928 788 // the constructor will have to be control-dependent on Initialize.
iveresov@5928 789 // So we actually don't have to do anything, since it's going to be caught by the control flow
iveresov@5928 790 // analysis.
iveresov@5928 791 #ifdef ASSERT
iveresov@5928 792 // Do a quick verification of the control pattern between the constructor and the initialize node
iveresov@5928 793 assert(curr->is_Call(), "constructor should be a call");
iveresov@5928 794 // Go up the control starting from the constructor call
iveresov@5928 795 Node* ctrl = curr->in(0);
iveresov@5928 796 IfNode* iff = NULL;
iveresov@5928 797 RegionNode* copy = NULL;
iveresov@5928 798
iveresov@5928 799 while (true) {
iveresov@5928 800 // skip known check patterns
iveresov@5928 801 if (ctrl->is_Region()) {
iveresov@5928 802 if (ctrl->as_Region()->is_copy()) {
iveresov@5928 803 copy = ctrl->as_Region();
iveresov@5928 804 ctrl = copy->is_copy();
iveresov@5928 805 } else { // a cast
iveresov@5928 806 assert(ctrl->req() == 3 &&
iveresov@5928 807 ctrl->in(1) != NULL && ctrl->in(1)->is_Proj() &&
iveresov@5928 808 ctrl->in(2) != NULL && ctrl->in(2)->is_Proj() &&
iveresov@5928 809 ctrl->in(1)->in(0) == ctrl->in(2)->in(0) &&
iveresov@5928 810 ctrl->in(1)->in(0) != NULL && ctrl->in(1)->in(0)->is_If(),
iveresov@5928 811 "must be a simple diamond");
iveresov@5928 812 Node* true_proj = ctrl->in(1)->is_IfTrue() ? ctrl->in(1) : ctrl->in(2);
iveresov@5928 813 for (SimpleDUIterator i(true_proj); i.has_next(); i.next()) {
iveresov@5928 814 Node* use = i.get();
iveresov@5928 815 assert(use == ctrl || use->is_ConstraintCast(),
iveresov@5928 816 err_msg_res("unexpected user: %s", use->Name()));
iveresov@5928 817 }
iveresov@5928 818
iveresov@5928 819 iff = ctrl->in(1)->in(0)->as_If();
iveresov@5928 820 ctrl = iff->in(0);
iveresov@5928 821 }
iveresov@5928 822 } else if (ctrl->is_IfTrue()) { // null checks, class checks
iveresov@5928 823 iff = ctrl->in(0)->as_If();
iveresov@5928 824 assert(iff->is_If(), "must be if");
iveresov@5928 825 // Verify that the other arm is an uncommon trap
iveresov@5928 826 Node* otherproj = iff->proj_out(1 - ctrl->as_Proj()->_con);
iveresov@5928 827 CallStaticJavaNode* call = otherproj->unique_out()->isa_CallStaticJava();
iveresov@5928 828 assert(strcmp(call->_name, "uncommon_trap") == 0, "must be uncommond trap");
iveresov@5928 829 ctrl = iff->in(0);
iveresov@5928 830 } else {
iveresov@5928 831 break;
iveresov@5928 832 }
iveresov@5928 833 }
iveresov@5928 834
iveresov@5928 835 assert(ctrl->is_Proj(), "must be a projection");
iveresov@5928 836 assert(ctrl->in(0)->is_Initialize(), "should be initialize");
iveresov@5928 837 for (SimpleDUIterator i(ctrl); i.has_next(); i.next()) {
iveresov@5928 838 Node* use = i.get();
iveresov@5928 839 assert(use == copy || use == iff || use == curr || use->is_CheckCastPP() || use->is_Load(),
iveresov@5928 840 err_msg_res("unexpected user: %s", use->Name()));
iveresov@5928 841 }
iveresov@5928 842 #endif // ASSERT
iveresov@5928 843 }
iveresov@5928 844 }
iveresov@5928 845 }
iveresov@5928 846
iveresov@5928 847 #ifndef PRODUCT
iveresov@5928 848 if (PrintOptimizeStringConcat) {
iveresov@5928 849 tty->print("fusion has correct memory flow for ");
iveresov@5928 850 _begin->jvms()->dump_spec(tty); tty->cr();
iveresov@5928 851 tty->cr();
iveresov@5928 852 }
iveresov@5928 853 #endif
iveresov@5928 854 return true;
iveresov@5928 855 }
iveresov@5928 856
never@1515 857 bool StringConcat::validate_control_flow() {
never@1515 858 // We found all the calls and arguments now lets see if it's
never@1515 859 // safe to transform the graph as we would expect.
never@1515 860
never@1515 861 // Check to see if this resulted in too many uncommon traps previously
never@1515 862 if (Compile::current()->too_many_traps(_begin->jvms()->method(), _begin->jvms()->bci(),
never@1515 863 Deoptimization::Reason_intrinsic)) {
never@1515 864 return false;
never@1515 865 }
never@1515 866
never@1515 867 // Walk backwards over the control flow from toString to the
never@1515 868 // allocation and make sure all the control flow is ok. This
never@1515 869 // means it's either going to be eliminated once the calls are
never@1515 870 // removed or it can safely be transformed into an uncommon
never@1515 871 // trap.
never@1515 872
never@1515 873 int null_check_count = 0;
never@1515 874 Unique_Node_List ctrl_path;
never@1515 875
never@1515 876 assert(_control.contains(_begin), "missing");
never@1515 877 assert(_control.contains(_end), "missing");
never@1515 878
never@1515 879 // Collect the nodes that we know about and will eliminate into ctrl_path
never@1515 880 for (uint i = 0; i < _control.size(); i++) {
never@1515 881 // Push the call and it's control projection
never@1515 882 Node* n = _control.at(i);
never@1515 883 if (n->is_Allocate()) {
never@1515 884 AllocateNode* an = n->as_Allocate();
never@1515 885 InitializeNode* init = an->initialization();
never@1515 886 ctrl_path.push(init);
never@1515 887 ctrl_path.push(init->as_Multi()->proj_out(0));
never@1515 888 }
never@1515 889 if (n->is_Call()) {
never@1515 890 CallNode* cn = n->as_Call();
never@1515 891 ctrl_path.push(cn);
never@1515 892 ctrl_path.push(cn->proj_out(0));
never@1515 893 ctrl_path.push(cn->proj_out(0)->unique_out());
roland@4357 894 if (cn->proj_out(0)->unique_out()->as_Catch()->proj_out(0) != NULL) {
roland@4357 895 ctrl_path.push(cn->proj_out(0)->unique_out()->as_Catch()->proj_out(0));
roland@4357 896 }
never@1515 897 } else {
never@1515 898 ShouldNotReachHere();
never@1515 899 }
never@1515 900 }
never@1515 901
iveresov@5928 902 // Skip backwards through the control checking for unexpected control flow
never@1515 903 Node* ptr = _end;
never@1515 904 bool fail = false;
never@1515 905 while (ptr != _begin) {
never@1515 906 if (ptr->is_Call() && ctrl_path.member(ptr)) {
never@1515 907 ptr = ptr->in(0);
never@1515 908 } else if (ptr->is_CatchProj() && ctrl_path.member(ptr)) {
never@1515 909 ptr = ptr->in(0)->in(0)->in(0);
never@1515 910 assert(ctrl_path.member(ptr), "should be a known piece of control");
never@1515 911 } else if (ptr->is_IfTrue()) {
never@1515 912 IfNode* iff = ptr->in(0)->as_If();
never@1515 913 BoolNode* b = iff->in(1)->isa_Bool();
roland@4357 914
roland@4357 915 if (b == NULL) {
roland@4357 916 fail = true;
roland@4357 917 break;
roland@4357 918 }
roland@4357 919
never@1515 920 Node* cmp = b->in(1);
never@1515 921 Node* v1 = cmp->in(1);
never@1515 922 Node* v2 = cmp->in(2);
never@1515 923 Node* otherproj = iff->proj_out(1 - ptr->as_Proj()->_con);
never@1515 924
never@1515 925 // Null check of the return of append which can simply be eliminated
never@1515 926 if (b->_test._test == BoolTest::ne &&
never@1515 927 v2->bottom_type() == TypePtr::NULL_PTR &&
never@1515 928 v1->is_Proj() && ctrl_path.member(v1->in(0))) {
never@1515 929 // NULL check of the return value of the append
never@1515 930 null_check_count++;
never@1515 931 if (otherproj->outcnt() == 1) {
never@1515 932 CallStaticJavaNode* call = otherproj->unique_out()->isa_CallStaticJava();
never@1515 933 if (call != NULL && call->_name != NULL && strcmp(call->_name, "uncommon_trap") == 0) {
never@1515 934 ctrl_path.push(call);
never@1515 935 }
never@1515 936 }
never@1515 937 _control.push(ptr);
never@1515 938 ptr = ptr->in(0)->in(0);
never@1515 939 continue;
never@1515 940 }
never@1515 941
never@1515 942 // A test which leads to an uncommon trap which should be safe.
never@1515 943 // Later this trap will be converted into a trap that restarts
never@1515 944 // at the beginning.
never@1515 945 if (otherproj->outcnt() == 1) {
never@1515 946 CallStaticJavaNode* call = otherproj->unique_out()->isa_CallStaticJava();
never@1515 947 if (call != NULL && call->_name != NULL && strcmp(call->_name, "uncommon_trap") == 0) {
never@1515 948 // control flow leads to uct so should be ok
never@1515 949 _uncommon_traps.push(call);
never@1515 950 ctrl_path.push(call);
never@1515 951 ptr = ptr->in(0)->in(0);
never@1515 952 continue;
never@1515 953 }
never@1515 954 }
never@1515 955
never@1515 956 #ifndef PRODUCT
never@1515 957 // Some unexpected control flow we don't know how to handle.
never@1515 958 if (PrintOptimizeStringConcat) {
never@1515 959 tty->print_cr("failing with unknown test");
never@1515 960 b->dump();
never@1515 961 cmp->dump();
never@1515 962 v1->dump();
never@1515 963 v2->dump();
never@1515 964 tty->cr();
never@1515 965 }
never@1515 966 #endif
kvn@2927 967 fail = true;
never@1515 968 break;
never@1515 969 } else if (ptr->is_Proj() && ptr->in(0)->is_Initialize()) {
never@1515 970 ptr = ptr->in(0)->in(0);
never@1515 971 } else if (ptr->is_Region()) {
never@1515 972 Node* copy = ptr->as_Region()->is_copy();
never@1515 973 if (copy != NULL) {
never@1515 974 ptr = copy;
never@1515 975 continue;
never@1515 976 }
never@1515 977 if (ptr->req() == 3 &&
never@1515 978 ptr->in(1) != NULL && ptr->in(1)->is_Proj() &&
never@1515 979 ptr->in(2) != NULL && ptr->in(2)->is_Proj() &&
never@1515 980 ptr->in(1)->in(0) == ptr->in(2)->in(0) &&
never@1515 981 ptr->in(1)->in(0) != NULL && ptr->in(1)->in(0)->is_If()) {
never@1515 982 // Simple diamond.
never@1515 983 // XXX should check for possibly merging stores. simple data merges are ok.
roland@4409 984 // The IGVN will make this simple diamond go away when it
roland@4409 985 // transforms the Region. Make sure it sees it.
roland@4409 986 Compile::current()->record_for_igvn(ptr);
never@1515 987 ptr = ptr->in(1)->in(0)->in(0);
never@1515 988 continue;
never@1515 989 }
never@1515 990 #ifndef PRODUCT
never@1515 991 if (PrintOptimizeStringConcat) {
never@1515 992 tty->print_cr("fusion would fail for region");
never@1515 993 _begin->dump();
never@1515 994 ptr->dump(2);
never@1515 995 }
never@1515 996 #endif
never@1515 997 fail = true;
never@1515 998 break;
never@1515 999 } else {
never@1515 1000 // other unknown control
never@1515 1001 if (!fail) {
never@1515 1002 #ifndef PRODUCT
never@1515 1003 if (PrintOptimizeStringConcat) {
never@1515 1004 tty->print_cr("fusion would fail for");
never@1515 1005 _begin->dump();
never@1515 1006 }
never@1515 1007 #endif
never@1515 1008 fail = true;
never@1515 1009 }
never@1515 1010 #ifndef PRODUCT
never@1515 1011 if (PrintOptimizeStringConcat) {
never@1515 1012 ptr->dump();
never@1515 1013 }
never@1515 1014 #endif
never@1515 1015 ptr = ptr->in(0);
never@1515 1016 }
never@1515 1017 }
never@1515 1018 #ifndef PRODUCT
never@1515 1019 if (PrintOptimizeStringConcat && fail) {
never@1515 1020 tty->cr();
never@1515 1021 }
never@1515 1022 #endif
never@1515 1023 if (fail) return !fail;
never@1515 1024
never@1515 1025 // Validate that all these results produced are contained within
never@1515 1026 // this cluster of objects. First collect all the results produced
never@1515 1027 // by calls in the region.
never@1515 1028 _stringopts->_visited.Clear();
never@1515 1029 Node_List worklist;
never@1515 1030 Node* final_result = _end->proj_out(TypeFunc::Parms);
never@1515 1031 for (uint i = 0; i < _control.size(); i++) {
never@1515 1032 CallNode* cnode = _control.at(i)->isa_Call();
never@1515 1033 if (cnode != NULL) {
never@1515 1034 _stringopts->_visited.test_set(cnode->_idx);
never@1515 1035 }
never@1515 1036 Node* result = cnode != NULL ? cnode->proj_out(TypeFunc::Parms) : NULL;
never@1515 1037 if (result != NULL && result != final_result) {
never@1515 1038 worklist.push(result);
never@1515 1039 }
never@1515 1040 }
never@1515 1041
never@1515 1042 Node* last_result = NULL;
never@1515 1043 while (worklist.size() > 0) {
never@1515 1044 Node* result = worklist.pop();
never@1515 1045 if (_stringopts->_visited.test_set(result->_idx))
never@1515 1046 continue;
never@1515 1047 for (SimpleDUIterator i(result); i.has_next(); i.next()) {
never@1515 1048 Node *use = i.get();
never@1515 1049 if (ctrl_path.member(use)) {
never@1515 1050 // already checked this
never@1515 1051 continue;
never@1515 1052 }
never@1515 1053 int opc = use->Opcode();
never@1515 1054 if (opc == Op_CmpP || opc == Op_Node) {
never@1515 1055 ctrl_path.push(use);
never@1515 1056 continue;
never@1515 1057 }
never@1515 1058 if (opc == Op_CastPP || opc == Op_CheckCastPP) {
never@1515 1059 for (SimpleDUIterator j(use); j.has_next(); j.next()) {
never@1515 1060 worklist.push(j.get());
never@1515 1061 }
never@1515 1062 worklist.push(use->in(1));
never@1515 1063 ctrl_path.push(use);
never@1515 1064 continue;
never@1515 1065 }
never@1515 1066 #ifndef PRODUCT
never@1515 1067 if (PrintOptimizeStringConcat) {
never@1515 1068 if (result != last_result) {
never@1515 1069 last_result = result;
never@1515 1070 tty->print_cr("extra uses for result:");
never@1515 1071 last_result->dump();
never@1515 1072 }
never@1515 1073 use->dump();
never@1515 1074 }
never@1515 1075 #endif
never@1515 1076 fail = true;
never@1515 1077 break;
never@1515 1078 }
never@1515 1079 }
never@1515 1080
never@1515 1081 #ifndef PRODUCT
never@1515 1082 if (PrintOptimizeStringConcat && !fail) {
never@1515 1083 ttyLocker ttyl;
never@1515 1084 tty->cr();
iveresov@5928 1085 tty->print("fusion has correct control flow (%d %d) for ", null_check_count, _uncommon_traps.size());
never@1515 1086 _begin->jvms()->dump_spec(tty); tty->cr();
never@1515 1087 for (int i = 0; i < num_arguments(); i++) {
never@1515 1088 argument(i)->dump();
never@1515 1089 }
never@1515 1090 _control.dump();
never@1515 1091 tty->cr();
never@1515 1092 }
never@1515 1093 #endif
never@1515 1094
never@1515 1095 return !fail;
never@1515 1096 }
never@1515 1097
never@1515 1098 Node* PhaseStringOpts::fetch_static_field(GraphKit& kit, ciField* field) {
never@3746 1099 const TypeInstPtr* mirror_type = TypeInstPtr::make(field->holder()->java_mirror());
never@3746 1100 Node* klass_node = __ makecon(mirror_type);
never@1515 1101 BasicType bt = field->layout_type();
never@1515 1102 ciType* field_klass = field->type();
never@1515 1103
never@1515 1104 const Type *type;
never@1515 1105 if( bt == T_OBJECT ) {
never@1515 1106 if (!field->type()->is_loaded()) {
never@1515 1107 type = TypeInstPtr::BOTTOM;
never@1515 1108 } else if (field->is_constant()) {
never@1515 1109 // This can happen if the constant oop is non-perm.
never@1515 1110 ciObject* con = field->constant_value().as_object();
never@1515 1111 // Do not "join" in the previous type; it doesn't add value,
never@1515 1112 // and may yield a vacuous result if the field is of interface type.
jcoomes@2661 1113 type = TypeOopPtr::make_from_constant(con, true)->isa_oopptr();
never@1515 1114 assert(type != NULL, "field singleton type must be consistent");
never@3746 1115 return __ makecon(type);
never@1515 1116 } else {
never@1515 1117 type = TypeOopPtr::make_from_klass(field_klass->as_klass());
never@1515 1118 }
never@1515 1119 } else {
never@1515 1120 type = Type::get_const_basic_type(bt);
never@1515 1121 }
never@1515 1122
never@1515 1123 return kit.make_load(NULL, kit.basic_plus_adr(klass_node, field->offset_in_bytes()),
never@1515 1124 type, T_OBJECT,
goetz@6479 1125 C->get_alias_index(mirror_type->add_offset(field->offset_in_bytes())),
goetz@6479 1126 MemNode::unordered);
never@1515 1127 }
never@1515 1128
never@1515 1129 Node* PhaseStringOpts::int_stringSize(GraphKit& kit, Node* arg) {
kvn@4115 1130 RegionNode *final_merge = new (C) RegionNode(3);
never@1515 1131 kit.gvn().set_type(final_merge, Type::CONTROL);
kvn@4115 1132 Node* final_size = new (C) PhiNode(final_merge, TypeInt::INT);
never@1515 1133 kit.gvn().set_type(final_size, TypeInt::INT);
never@1515 1134
never@1515 1135 IfNode* iff = kit.create_and_map_if(kit.control(),
never@1515 1136 __ Bool(__ CmpI(arg, __ intcon(0x80000000)), BoolTest::ne),
never@1515 1137 PROB_FAIR, COUNT_UNKNOWN);
never@1515 1138 Node* is_min = __ IfFalse(iff);
never@1515 1139 final_merge->init_req(1, is_min);
never@1515 1140 final_size->init_req(1, __ intcon(11));
never@1515 1141
never@1515 1142 kit.set_control(__ IfTrue(iff));
never@1515 1143 if (kit.stopped()) {
never@1515 1144 final_merge->init_req(2, C->top());
never@1515 1145 final_size->init_req(2, C->top());
never@1515 1146 } else {
never@1515 1147
never@1515 1148 // int size = (i < 0) ? stringSize(-i) + 1 : stringSize(i);
kvn@4115 1149 RegionNode *r = new (C) RegionNode(3);
never@1515 1150 kit.gvn().set_type(r, Type::CONTROL);
kvn@4115 1151 Node *phi = new (C) PhiNode(r, TypeInt::INT);
never@1515 1152 kit.gvn().set_type(phi, TypeInt::INT);
kvn@4115 1153 Node *size = new (C) PhiNode(r, TypeInt::INT);
never@1515 1154 kit.gvn().set_type(size, TypeInt::INT);
never@1515 1155 Node* chk = __ CmpI(arg, __ intcon(0));
never@1515 1156 Node* p = __ Bool(chk, BoolTest::lt);
never@1515 1157 IfNode* iff = kit.create_and_map_if(kit.control(), p, PROB_FAIR, COUNT_UNKNOWN);
never@1515 1158 Node* lessthan = __ IfTrue(iff);
never@1515 1159 Node* greaterequal = __ IfFalse(iff);
never@1515 1160 r->init_req(1, lessthan);
never@1515 1161 phi->init_req(1, __ SubI(__ intcon(0), arg));
never@1515 1162 size->init_req(1, __ intcon(1));
never@1515 1163 r->init_req(2, greaterequal);
never@1515 1164 phi->init_req(2, arg);
never@1515 1165 size->init_req(2, __ intcon(0));
never@1515 1166 kit.set_control(r);
never@1515 1167 C->record_for_igvn(r);
never@1515 1168 C->record_for_igvn(phi);
never@1515 1169 C->record_for_igvn(size);
never@1515 1170
never@1515 1171 // for (int i=0; ; i++)
never@1515 1172 // if (x <= sizeTable[i])
never@1515 1173 // return i+1;
kvn@2665 1174
kvn@2665 1175 // Add loop predicate first.
kvn@2665 1176 kit.add_predicate();
kvn@2665 1177
kvn@4115 1178 RegionNode *loop = new (C) RegionNode(3);
never@1515 1179 loop->init_req(1, kit.control());
never@1515 1180 kit.gvn().set_type(loop, Type::CONTROL);
never@1515 1181
kvn@4115 1182 Node *index = new (C) PhiNode(loop, TypeInt::INT);
never@1515 1183 index->init_req(1, __ intcon(0));
never@1515 1184 kit.gvn().set_type(index, TypeInt::INT);
never@1515 1185 kit.set_control(loop);
never@1515 1186 Node* sizeTable = fetch_static_field(kit, size_table_field);
never@1515 1187
never@1515 1188 Node* value = kit.load_array_element(NULL, sizeTable, index, TypeAryPtr::INTS);
never@1515 1189 C->record_for_igvn(value);
never@1515 1190 Node* limit = __ CmpI(phi, value);
never@1515 1191 Node* limitb = __ Bool(limit, BoolTest::le);
never@1515 1192 IfNode* iff2 = kit.create_and_map_if(kit.control(), limitb, PROB_MIN, COUNT_UNKNOWN);
never@1515 1193 Node* lessEqual = __ IfTrue(iff2);
never@1515 1194 Node* greater = __ IfFalse(iff2);
never@1515 1195
never@1515 1196 loop->init_req(2, greater);
never@1515 1197 index->init_req(2, __ AddI(index, __ intcon(1)));
never@1515 1198
never@1515 1199 kit.set_control(lessEqual);
never@1515 1200 C->record_for_igvn(loop);
never@1515 1201 C->record_for_igvn(index);
never@1515 1202
never@1515 1203 final_merge->init_req(2, kit.control());
never@1515 1204 final_size->init_req(2, __ AddI(__ AddI(index, size), __ intcon(1)));
never@1515 1205 }
never@1515 1206
never@1515 1207 kit.set_control(final_merge);
never@1515 1208 C->record_for_igvn(final_merge);
never@1515 1209 C->record_for_igvn(final_size);
never@1515 1210
never@1515 1211 return final_size;
never@1515 1212 }
never@1515 1213
never@1515 1214 void PhaseStringOpts::int_getChars(GraphKit& kit, Node* arg, Node* char_array, Node* start, Node* end) {
kvn@4115 1215 RegionNode *final_merge = new (C) RegionNode(4);
never@1515 1216 kit.gvn().set_type(final_merge, Type::CONTROL);
never@1515 1217 Node *final_mem = PhiNode::make(final_merge, kit.memory(char_adr_idx), Type::MEMORY, TypeAryPtr::CHARS);
never@1515 1218 kit.gvn().set_type(final_mem, Type::MEMORY);
never@1515 1219
never@1515 1220 // need to handle Integer.MIN_VALUE specially because negating doesn't make it positive
never@1515 1221 {
never@1515 1222 // i == MIN_VALUE
never@1515 1223 IfNode* iff = kit.create_and_map_if(kit.control(),
never@1515 1224 __ Bool(__ CmpI(arg, __ intcon(0x80000000)), BoolTest::ne),
never@1515 1225 PROB_FAIR, COUNT_UNKNOWN);
never@1515 1226
never@1515 1227 Node* old_mem = kit.memory(char_adr_idx);
never@1515 1228
never@1515 1229 kit.set_control(__ IfFalse(iff));
never@1515 1230 if (kit.stopped()) {
never@1515 1231 // Statically not equal to MIN_VALUE so this path is dead
never@1515 1232 final_merge->init_req(3, kit.control());
never@1515 1233 } else {
never@1515 1234 copy_string(kit, __ makecon(TypeInstPtr::make(C->env()->the_min_jint_string())),
never@1515 1235 char_array, start);
never@1515 1236 final_merge->init_req(3, kit.control());
never@1515 1237 final_mem->init_req(3, kit.memory(char_adr_idx));
never@1515 1238 }
never@1515 1239
never@1515 1240 kit.set_control(__ IfTrue(iff));
never@1515 1241 kit.set_memory(old_mem, char_adr_idx);
never@1515 1242 }
never@1515 1243
never@1515 1244
never@1515 1245 // Simplified version of Integer.getChars
never@1515 1246
never@1515 1247 // int q, r;
never@1515 1248 // int charPos = index;
never@1515 1249 Node* charPos = end;
never@1515 1250
never@1515 1251 // char sign = 0;
never@1515 1252
never@1515 1253 Node* i = arg;
never@1515 1254 Node* sign = __ intcon(0);
never@1515 1255
never@1515 1256 // if (i < 0) {
never@1515 1257 // sign = '-';
never@1515 1258 // i = -i;
never@1515 1259 // }
never@1515 1260 {
never@1515 1261 IfNode* iff = kit.create_and_map_if(kit.control(),
never@1515 1262 __ Bool(__ CmpI(arg, __ intcon(0)), BoolTest::lt),
never@1515 1263 PROB_FAIR, COUNT_UNKNOWN);
never@1515 1264
kvn@4115 1265 RegionNode *merge = new (C) RegionNode(3);
never@1515 1266 kit.gvn().set_type(merge, Type::CONTROL);
kvn@4115 1267 i = new (C) PhiNode(merge, TypeInt::INT);
never@1515 1268 kit.gvn().set_type(i, TypeInt::INT);
kvn@4115 1269 sign = new (C) PhiNode(merge, TypeInt::INT);
never@1515 1270 kit.gvn().set_type(sign, TypeInt::INT);
never@1515 1271
never@1515 1272 merge->init_req(1, __ IfTrue(iff));
never@1515 1273 i->init_req(1, __ SubI(__ intcon(0), arg));
never@1515 1274 sign->init_req(1, __ intcon('-'));
never@1515 1275 merge->init_req(2, __ IfFalse(iff));
never@1515 1276 i->init_req(2, arg);
never@1515 1277 sign->init_req(2, __ intcon(0));
never@1515 1278
never@1515 1279 kit.set_control(merge);
never@1515 1280
never@1515 1281 C->record_for_igvn(merge);
never@1515 1282 C->record_for_igvn(i);
never@1515 1283 C->record_for_igvn(sign);
never@1515 1284 }
never@1515 1285
never@1515 1286 // for (;;) {
never@1515 1287 // q = i / 10;
never@1515 1288 // r = i - ((q << 3) + (q << 1)); // r = i-(q*10) ...
never@1515 1289 // buf [--charPos] = digits [r];
never@1515 1290 // i = q;
never@1515 1291 // if (i == 0) break;
never@1515 1292 // }
never@1515 1293
never@1515 1294 {
kvn@2665 1295 // Add loop predicate first.
kvn@2665 1296 kit.add_predicate();
kvn@2665 1297
kvn@4115 1298 RegionNode *head = new (C) RegionNode(3);
never@1515 1299 head->init_req(1, kit.control());
never@1515 1300 kit.gvn().set_type(head, Type::CONTROL);
kvn@4115 1301 Node *i_phi = new (C) PhiNode(head, TypeInt::INT);
never@1515 1302 i_phi->init_req(1, i);
never@1515 1303 kit.gvn().set_type(i_phi, TypeInt::INT);
never@1515 1304 charPos = PhiNode::make(head, charPos);
never@1515 1305 kit.gvn().set_type(charPos, TypeInt::INT);
never@1515 1306 Node *mem = PhiNode::make(head, kit.memory(char_adr_idx), Type::MEMORY, TypeAryPtr::CHARS);
never@1515 1307 kit.gvn().set_type(mem, Type::MEMORY);
never@1515 1308 kit.set_control(head);
never@1515 1309 kit.set_memory(mem, char_adr_idx);
never@1515 1310
never@1685 1311 Node* q = __ DivI(NULL, i_phi, __ intcon(10));
never@1515 1312 Node* r = __ SubI(i_phi, __ AddI(__ LShiftI(q, __ intcon(3)),
never@1515 1313 __ LShiftI(q, __ intcon(1))));
never@1515 1314 Node* m1 = __ SubI(charPos, __ intcon(1));
never@1515 1315 Node* ch = __ AddI(r, __ intcon('0'));
never@1515 1316
never@1515 1317 Node* st = __ store_to_memory(kit.control(), kit.array_element_address(char_array, m1, T_CHAR),
goetz@6479 1318 ch, T_CHAR, char_adr_idx, MemNode::unordered);
never@1515 1319
never@1515 1320
never@1515 1321 IfNode* iff = kit.create_and_map_if(head, __ Bool(__ CmpI(q, __ intcon(0)), BoolTest::ne),
never@1515 1322 PROB_FAIR, COUNT_UNKNOWN);
never@1515 1323 Node* ne = __ IfTrue(iff);
never@1515 1324 Node* eq = __ IfFalse(iff);
never@1515 1325
never@1515 1326 head->init_req(2, ne);
never@1515 1327 mem->init_req(2, st);
never@1515 1328 i_phi->init_req(2, q);
never@1515 1329 charPos->init_req(2, m1);
never@1515 1330
never@1515 1331 charPos = m1;
never@1515 1332
never@1515 1333 kit.set_control(eq);
never@1515 1334 kit.set_memory(st, char_adr_idx);
never@1515 1335
never@1515 1336 C->record_for_igvn(head);
never@1515 1337 C->record_for_igvn(mem);
never@1515 1338 C->record_for_igvn(i_phi);
never@1515 1339 C->record_for_igvn(charPos);
never@1515 1340 }
never@1515 1341
never@1515 1342 {
never@1515 1343 // if (sign != 0) {
never@1515 1344 // buf [--charPos] = sign;
never@1515 1345 // }
never@1515 1346 IfNode* iff = kit.create_and_map_if(kit.control(),
never@1515 1347 __ Bool(__ CmpI(sign, __ intcon(0)), BoolTest::ne),
never@1515 1348 PROB_FAIR, COUNT_UNKNOWN);
never@1515 1349
never@1515 1350 final_merge->init_req(2, __ IfFalse(iff));
never@1515 1351 final_mem->init_req(2, kit.memory(char_adr_idx));
never@1515 1352
never@1515 1353 kit.set_control(__ IfTrue(iff));
never@1515 1354 if (kit.stopped()) {
never@1515 1355 final_merge->init_req(1, C->top());
never@1515 1356 final_mem->init_req(1, C->top());
never@1515 1357 } else {
never@1515 1358 Node* m1 = __ SubI(charPos, __ intcon(1));
never@1515 1359 Node* st = __ store_to_memory(kit.control(), kit.array_element_address(char_array, m1, T_CHAR),
goetz@6479 1360 sign, T_CHAR, char_adr_idx, MemNode::unordered);
never@1515 1361
never@1515 1362 final_merge->init_req(1, kit.control());
never@1515 1363 final_mem->init_req(1, st);
never@1515 1364 }
never@1515 1365
never@1515 1366 kit.set_control(final_merge);
never@1515 1367 kit.set_memory(final_mem, char_adr_idx);
never@1515 1368
never@1515 1369 C->record_for_igvn(final_merge);
never@1515 1370 C->record_for_igvn(final_mem);
never@1515 1371 }
never@1515 1372 }
never@1515 1373
never@1515 1374
never@1515 1375 Node* PhaseStringOpts::copy_string(GraphKit& kit, Node* str, Node* char_array, Node* start) {
never@1515 1376 Node* string = str;
kvn@3760 1377 Node* offset = kit.load_String_offset(kit.control(), string);
kvn@3760 1378 Node* count = kit.load_String_length(kit.control(), string);
kvn@3760 1379 Node* value = kit.load_String_value (kit.control(), string);
never@1515 1380
never@1515 1381 // copy the contents
never@1515 1382 if (offset->is_Con() && count->is_Con() && value->is_Con() && count->get_int() < unroll_string_copy_length) {
never@1515 1383 // For small constant strings just emit individual stores.
never@1515 1384 // A length of 6 seems like a good space/speed tradeof.
never@1515 1385 int c = count->get_int();
never@1515 1386 int o = offset->get_int();
never@1515 1387 const TypeOopPtr* t = kit.gvn().type(value)->isa_oopptr();
never@1515 1388 ciTypeArray* value_array = t->const_oop()->as_type_array();
never@1515 1389 for (int e = 0; e < c; e++) {
never@1515 1390 __ store_to_memory(kit.control(), kit.array_element_address(char_array, start, T_CHAR),
goetz@6479 1391 __ intcon(value_array->char_at(o + e)), T_CHAR, char_adr_idx,
goetz@6479 1392 MemNode::unordered);
never@1515 1393 start = __ AddI(start, __ intcon(1));
never@1515 1394 }
never@1515 1395 } else {
never@1515 1396 Node* src_ptr = kit.array_element_address(value, offset, T_CHAR);
never@1515 1397 Node* dst_ptr = kit.array_element_address(char_array, start, T_CHAR);
never@1515 1398 Node* c = count;
never@1515 1399 Node* extra = NULL;
never@1515 1400 #ifdef _LP64
never@1515 1401 c = __ ConvI2L(c);
never@1515 1402 extra = C->top();
never@1515 1403 #endif
never@1515 1404 Node* call = kit.make_runtime_call(GraphKit::RC_LEAF|GraphKit::RC_NO_FP,
never@1515 1405 OptoRuntime::fast_arraycopy_Type(),
never@1515 1406 CAST_FROM_FN_PTR(address, StubRoutines::jshort_disjoint_arraycopy()),
never@1515 1407 "jshort_disjoint_arraycopy", TypeAryPtr::CHARS,
never@1515 1408 src_ptr, dst_ptr, c, extra);
never@1515 1409 start = __ AddI(start, count);
never@1515 1410 }
never@1515 1411 return start;
never@1515 1412 }
never@1515 1413
never@1515 1414
never@1515 1415 void PhaseStringOpts::replace_string_concat(StringConcat* sc) {
never@1515 1416 // Log a little info about the transformation
never@1515 1417 sc->maybe_log_transform();
never@1515 1418
never@1515 1419 // pull the JVMState of the allocation into a SafePointNode to serve as
never@1515 1420 // as a shim for the insertion of the new code.
never@1515 1421 JVMState* jvms = sc->begin()->jvms()->clone_shallow(C);
never@1515 1422 uint size = sc->begin()->req();
kvn@4115 1423 SafePointNode* map = new (C) SafePointNode(size, jvms);
never@1515 1424
never@1515 1425 // copy the control and memory state from the final call into our
never@1515 1426 // new starting state. This allows any preceeding tests to feed
never@1515 1427 // into the new section of code.
never@1515 1428 for (uint i1 = 0; i1 < TypeFunc::Parms; i1++) {
never@1515 1429 map->init_req(i1, sc->end()->in(i1));
never@1515 1430 }
never@1515 1431 // blow away old allocation arguments
never@1515 1432 for (uint i1 = TypeFunc::Parms; i1 < jvms->debug_start(); i1++) {
never@1515 1433 map->init_req(i1, C->top());
never@1515 1434 }
never@1515 1435 // Copy the rest of the inputs for the JVMState
never@1515 1436 for (uint i1 = jvms->debug_start(); i1 < sc->begin()->req(); i1++) {
never@1515 1437 map->init_req(i1, sc->begin()->in(i1));
never@1515 1438 }
never@1515 1439 // Make sure the memory state is a MergeMem for parsing.
never@1515 1440 if (!map->in(TypeFunc::Memory)->is_MergeMem()) {
never@1515 1441 map->set_req(TypeFunc::Memory, MergeMemNode::make(C, map->in(TypeFunc::Memory)));
never@1515 1442 }
never@1515 1443
never@1515 1444 jvms->set_map(map);
never@1515 1445 map->ensure_stack(jvms, jvms->method()->max_stack());
never@1515 1446
never@1515 1447
never@1515 1448 // disconnect all the old StringBuilder calls from the graph
never@1515 1449 sc->eliminate_unneeded_control();
never@1515 1450
never@1515 1451 // At this point all the old work has been completely removed from
never@1515 1452 // the graph and the saved JVMState exists at the point where the
never@1515 1453 // final toString call used to be.
never@1515 1454 GraphKit kit(jvms);
never@1515 1455
never@1515 1456 // There may be uncommon traps which are still using the
never@1515 1457 // intermediate states and these need to be rewritten to point at
never@1515 1458 // the JVMState at the beginning of the transformation.
never@1515 1459 sc->convert_uncommon_traps(kit, jvms);
never@1515 1460
never@1515 1461 // Now insert the logic to compute the size of the string followed
never@1515 1462 // by all the logic to construct array and resulting string.
never@1515 1463
never@1515 1464 Node* null_string = __ makecon(TypeInstPtr::make(C->env()->the_null_string()));
never@1515 1465
never@1515 1466 // Create a region for the overflow checks to merge into.
never@1515 1467 int args = MAX2(sc->num_arguments(), 1);
kvn@4115 1468 RegionNode* overflow = new (C) RegionNode(args);
never@1515 1469 kit.gvn().set_type(overflow, Type::CONTROL);
never@1515 1470
never@1515 1471 // Create a hook node to hold onto the individual sizes since they
never@1515 1472 // are need for the copying phase.
kvn@4115 1473 Node* string_sizes = new (C) Node(args);
never@1515 1474
never@1515 1475 Node* length = __ intcon(0);
never@1515 1476 for (int argi = 0; argi < sc->num_arguments(); argi++) {
never@1515 1477 Node* arg = sc->argument(argi);
never@1515 1478 switch (sc->mode(argi)) {
never@1515 1479 case StringConcat::IntMode: {
never@1515 1480 Node* string_size = int_stringSize(kit, arg);
never@1515 1481
never@1515 1482 // accumulate total
never@1515 1483 length = __ AddI(length, string_size);
never@1515 1484
never@1515 1485 // Cache this value for the use by int_toString
never@1515 1486 string_sizes->init_req(argi, string_size);
never@1515 1487 break;
never@1515 1488 }
kvn@2413 1489 case StringConcat::StringNullCheckMode: {
kvn@2413 1490 const Type* type = kit.gvn().type(arg);
kvn@2413 1491 assert(type != TypePtr::NULL_PTR, "missing check");
kvn@2413 1492 if (!type->higher_equal(TypeInstPtr::NOTNULL)) {
kvn@2413 1493 // Null check with uncommont trap since
kvn@2413 1494 // StringBuilder(null) throws exception.
kvn@2413 1495 // Use special uncommon trap instead of
kvn@2413 1496 // calling normal do_null_check().
kvn@2413 1497 Node* p = __ Bool(__ CmpP(arg, kit.null()), BoolTest::ne);
kvn@2413 1498 IfNode* iff = kit.create_and_map_if(kit.control(), p, PROB_MIN, COUNT_UNKNOWN);
kvn@2413 1499 overflow->add_req(__ IfFalse(iff));
kvn@2413 1500 Node* notnull = __ IfTrue(iff);
kvn@2413 1501 kit.set_control(notnull); // set control for the cast_not_null
kvn@2413 1502 arg = kit.cast_not_null(arg, false);
kvn@2413 1503 sc->set_argument(argi, arg);
kvn@2413 1504 }
kvn@2413 1505 assert(kit.gvn().type(arg)->higher_equal(TypeInstPtr::NOTNULL), "sanity");
kvn@2413 1506 // Fallthrough to add string length.
kvn@2413 1507 }
never@1515 1508 case StringConcat::StringMode: {
never@1515 1509 const Type* type = kit.gvn().type(arg);
never@1515 1510 if (type == TypePtr::NULL_PTR) {
never@1515 1511 // replace the argument with the null checked version
never@1515 1512 arg = null_string;
never@1515 1513 sc->set_argument(argi, arg);
never@1515 1514 } else if (!type->higher_equal(TypeInstPtr::NOTNULL)) {
never@1515 1515 // s = s != null ? s : "null";
never@1515 1516 // length = length + (s.count - s.offset);
kvn@4115 1517 RegionNode *r = new (C) RegionNode(3);
never@1515 1518 kit.gvn().set_type(r, Type::CONTROL);
kvn@4115 1519 Node *phi = new (C) PhiNode(r, type);
never@1515 1520 kit.gvn().set_type(phi, phi->bottom_type());
never@1515 1521 Node* p = __ Bool(__ CmpP(arg, kit.null()), BoolTest::ne);
never@1515 1522 IfNode* iff = kit.create_and_map_if(kit.control(), p, PROB_MIN, COUNT_UNKNOWN);
never@1515 1523 Node* notnull = __ IfTrue(iff);
never@1515 1524 Node* isnull = __ IfFalse(iff);
never@1685 1525 kit.set_control(notnull); // set control for the cast_not_null
never@1515 1526 r->init_req(1, notnull);
never@1685 1527 phi->init_req(1, kit.cast_not_null(arg, false));
never@1515 1528 r->init_req(2, isnull);
never@1515 1529 phi->init_req(2, null_string);
never@1515 1530 kit.set_control(r);
never@1515 1531 C->record_for_igvn(r);
never@1515 1532 C->record_for_igvn(phi);
never@1515 1533 // replace the argument with the null checked version
never@1515 1534 arg = phi;
never@1515 1535 sc->set_argument(argi, arg);
never@1515 1536 }
kvn@3760 1537
kvn@3760 1538 Node* count = kit.load_String_length(kit.control(), arg);
kvn@3760 1539
never@1515 1540 length = __ AddI(length, count);
never@1515 1541 string_sizes->init_req(argi, NULL);
never@1515 1542 break;
never@1515 1543 }
never@1515 1544 case StringConcat::CharMode: {
never@1515 1545 // one character only
never@1515 1546 length = __ AddI(length, __ intcon(1));
never@1515 1547 break;
never@1515 1548 }
never@1515 1549 default:
never@1515 1550 ShouldNotReachHere();
never@1515 1551 }
never@1515 1552 if (argi > 0) {
never@1515 1553 // Check that the sum hasn't overflowed
never@1515 1554 IfNode* iff = kit.create_and_map_if(kit.control(),
never@1515 1555 __ Bool(__ CmpI(length, __ intcon(0)), BoolTest::lt),
never@1515 1556 PROB_MIN, COUNT_UNKNOWN);
never@1515 1557 kit.set_control(__ IfFalse(iff));
never@1515 1558 overflow->set_req(argi, __ IfTrue(iff));
never@1515 1559 }
never@1515 1560 }
never@1515 1561
never@1515 1562 {
never@1515 1563 // Hook
never@1515 1564 PreserveJVMState pjvms(&kit);
never@1515 1565 kit.set_control(overflow);
kvn@2413 1566 C->record_for_igvn(overflow);
never@1515 1567 kit.uncommon_trap(Deoptimization::Reason_intrinsic,
never@1515 1568 Deoptimization::Action_make_not_entrant);
never@1515 1569 }
never@1515 1570
roland@4357 1571 Node* result;
roland@4357 1572 if (!kit.stopped()) {
roland@4357 1573
roland@4357 1574 // length now contains the number of characters needed for the
roland@4357 1575 // char[] so create a new AllocateArray for the char[]
roland@4357 1576 Node* char_array = NULL;
roland@4357 1577 {
roland@4357 1578 PreserveReexecuteState preexecs(&kit);
roland@4357 1579 // The original jvms is for an allocation of either a String or
roland@4357 1580 // StringBuffer so no stack adjustment is necessary for proper
roland@4357 1581 // reexecution. If we deoptimize in the slow path the bytecode
roland@4357 1582 // will be reexecuted and the char[] allocation will be thrown away.
roland@4357 1583 kit.jvms()->set_should_reexecute(true);
roland@4357 1584 char_array = kit.new_array(__ makecon(TypeKlassPtr::make(ciTypeArrayKlass::make(T_CHAR))),
roland@4357 1585 length, 1);
roland@4357 1586 }
roland@4357 1587
roland@4357 1588 // Mark the allocation so that zeroing is skipped since the code
roland@4357 1589 // below will overwrite the entire array
roland@4357 1590 AllocateArrayNode* char_alloc = AllocateArrayNode::Ideal_array_allocation(char_array, _gvn);
roland@4357 1591 char_alloc->maybe_set_complete(_gvn);
roland@4357 1592
roland@4357 1593 // Now copy the string representations into the final char[]
roland@4357 1594 Node* start = __ intcon(0);
roland@4357 1595 for (int argi = 0; argi < sc->num_arguments(); argi++) {
roland@4357 1596 Node* arg = sc->argument(argi);
roland@4357 1597 switch (sc->mode(argi)) {
roland@4357 1598 case StringConcat::IntMode: {
roland@4357 1599 Node* end = __ AddI(start, string_sizes->in(argi));
roland@4357 1600 // getChars words backwards so pass the ending point as well as the start
roland@4357 1601 int_getChars(kit, arg, char_array, start, end);
roland@4357 1602 start = end;
roland@4357 1603 break;
roland@4357 1604 }
roland@4357 1605 case StringConcat::StringNullCheckMode:
roland@4357 1606 case StringConcat::StringMode: {
roland@4357 1607 start = copy_string(kit, arg, char_array, start);
roland@4357 1608 break;
roland@4357 1609 }
roland@4357 1610 case StringConcat::CharMode: {
roland@4357 1611 __ store_to_memory(kit.control(), kit.array_element_address(char_array, start, T_CHAR),
goetz@6479 1612 arg, T_CHAR, char_adr_idx, MemNode::unordered);
roland@4357 1613 start = __ AddI(start, __ intcon(1));
roland@4357 1614 break;
roland@4357 1615 }
roland@4357 1616 default:
roland@4357 1617 ShouldNotReachHere();
roland@4357 1618 }
roland@4357 1619 }
roland@4357 1620
roland@4357 1621 // If we're not reusing an existing String allocation then allocate one here.
roland@4357 1622 result = sc->string_alloc();
roland@4357 1623 if (result == NULL) {
roland@4357 1624 PreserveReexecuteState preexecs(&kit);
roland@4357 1625 // The original jvms is for an allocation of either a String or
roland@4357 1626 // StringBuffer so no stack adjustment is necessary for proper
roland@4357 1627 // reexecution.
roland@4357 1628 kit.jvms()->set_should_reexecute(true);
roland@4357 1629 result = kit.new_instance(__ makecon(TypeKlassPtr::make(C->env()->String_klass())));
roland@4357 1630 }
roland@4357 1631
roland@4357 1632 // Intialize the string
roland@4357 1633 if (java_lang_String::has_offset_field()) {
roland@4357 1634 kit.store_String_offset(kit.control(), result, __ intcon(0));
roland@4357 1635 kit.store_String_length(kit.control(), result, length);
roland@4357 1636 }
roland@4357 1637 kit.store_String_value(kit.control(), result, char_array);
roland@4357 1638 } else {
roland@4357 1639 result = C->top();
never@1515 1640 }
never@1515 1641 // hook up the outgoing control and result
never@1515 1642 kit.replace_call(sc->end(), result);
never@1515 1643
never@1515 1644 // Unhook any hook nodes
bharadwaj@4315 1645 string_sizes->disconnect_inputs(NULL, C);
never@1515 1646 sc->cleanup();
never@1515 1647 }

mercurial