src/share/vm/gc_implementation/g1/ptrQueue.cpp

Thu, 03 Jan 2013 16:28:22 -0800

author
johnc
date
Thu, 03 Jan 2013 16:28:22 -0800
changeset 4386
d275c3dc73e6
parent 4299
f34d701e952e
child 4889
cc32ccaaf47f
permissions
-rw-r--r--

8004816: G1: Kitchensink failures after marking stack changes
Summary: Reset the marking state, including the mark stack overflow flag, in the event of a marking stack overflow during serial reference processing.
Reviewed-by: jmasa

ysr@777 1 /*
mikael@4153 2 * Copyright (c) 2001, 2012, Oracle and/or its affiliates. All rights reserved.
ysr@777 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
ysr@777 4 *
ysr@777 5 * This code is free software; you can redistribute it and/or modify it
ysr@777 6 * under the terms of the GNU General Public License version 2 only, as
ysr@777 7 * published by the Free Software Foundation.
ysr@777 8 *
ysr@777 9 * This code is distributed in the hope that it will be useful, but WITHOUT
ysr@777 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
ysr@777 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
ysr@777 12 * version 2 for more details (a copy is included in the LICENSE file that
ysr@777 13 * accompanied this code).
ysr@777 14 *
ysr@777 15 * You should have received a copy of the GNU General Public License version
ysr@777 16 * 2 along with this work; if not, write to the Free Software Foundation,
ysr@777 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
ysr@777 18 *
trims@1907 19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
trims@1907 20 * or visit www.oracle.com if you need additional information or have any
trims@1907 21 * questions.
ysr@777 22 *
ysr@777 23 */
ysr@777 24
stefank@2314 25 #include "precompiled.hpp"
stefank@2314 26 #include "gc_implementation/g1/ptrQueue.hpp"
stefank@2314 27 #include "memory/allocation.hpp"
stefank@2314 28 #include "memory/allocation.inline.hpp"
stefank@2314 29 #include "runtime/mutex.hpp"
stefank@2314 30 #include "runtime/mutexLocker.hpp"
stefank@4299 31 #include "runtime/thread.inline.hpp"
ysr@777 32
tonyp@2469 33 PtrQueue::PtrQueue(PtrQueueSet* qset, bool perm, bool active) :
tonyp@2469 34 _qset(qset), _buf(NULL), _index(0), _active(active),
ysr@777 35 _perm(perm), _lock(NULL)
ysr@777 36 {}
ysr@777 37
iveresov@876 38 void PtrQueue::flush() {
ysr@777 39 if (!_perm && _buf != NULL) {
ysr@777 40 if (_index == _sz) {
ysr@777 41 // No work to do.
ysr@777 42 qset()->deallocate_buffer(_buf);
ysr@777 43 } else {
ysr@777 44 // We must NULL out the unused entries, then enqueue.
ysr@777 45 for (size_t i = 0; i < _index; i += oopSize) {
ysr@777 46 _buf[byte_index_to_index((int)i)] = NULL;
ysr@777 47 }
ysr@777 48 qset()->enqueue_complete_buffer(_buf);
ysr@777 49 }
iveresov@876 50 _buf = NULL;
iveresov@876 51 _index = 0;
ysr@777 52 }
ysr@777 53 }
ysr@777 54
ysr@777 55
ysr@777 56 static int byte_index_to_index(int ind) {
ysr@777 57 assert((ind % oopSize) == 0, "Invariant.");
ysr@777 58 return ind / oopSize;
ysr@777 59 }
ysr@777 60
ysr@777 61 static int index_to_byte_index(int byte_ind) {
ysr@777 62 return byte_ind * oopSize;
ysr@777 63 }
ysr@777 64
ysr@777 65 void PtrQueue::enqueue_known_active(void* ptr) {
ysr@777 66 assert(0 <= _index && _index <= _sz, "Invariant.");
ysr@777 67 assert(_index == 0 || _buf != NULL, "invariant");
ysr@777 68
ysr@777 69 while (_index == 0) {
ysr@777 70 handle_zero_index();
ysr@777 71 }
iveresov@1546 72
ysr@777 73 assert(_index > 0, "postcondition");
ysr@777 74 _index -= oopSize;
ysr@777 75 _buf[byte_index_to_index((int)_index)] = ptr;
ysr@777 76 assert(0 <= _index && _index <= _sz, "Invariant.");
ysr@777 77 }
ysr@777 78
ysr@777 79 void PtrQueue::locking_enqueue_completed_buffer(void** buf) {
ysr@777 80 assert(_lock->owned_by_self(), "Required.");
johnc@1604 81
johnc@1604 82 // We have to unlock _lock (which may be Shared_DirtyCardQ_lock) before
johnc@1604 83 // we acquire DirtyCardQ_CBL_mon inside enqeue_complete_buffer as they
johnc@1604 84 // have the same rank and we may get the "possible deadlock" message
ysr@777 85 _lock->unlock();
johnc@1604 86
ysr@777 87 qset()->enqueue_complete_buffer(buf);
ysr@777 88 // We must relock only because the caller will unlock, for the normal
ysr@777 89 // case.
ysr@777 90 _lock->lock_without_safepoint_check();
ysr@777 91 }
ysr@777 92
ysr@777 93
ysr@777 94 PtrQueueSet::PtrQueueSet(bool notify_when_complete) :
ysr@777 95 _max_completed_queue(0),
ysr@777 96 _cbl_mon(NULL), _fl_lock(NULL),
ysr@777 97 _notify_when_complete(notify_when_complete),
ysr@777 98 _sz(0),
ysr@777 99 _completed_buffers_head(NULL),
ysr@777 100 _completed_buffers_tail(NULL),
ysr@777 101 _n_completed_buffers(0),
ysr@777 102 _process_completed_threshold(0), _process_completed(false),
ysr@777 103 _buf_free_list(NULL), _buf_free_list_sz(0)
iveresov@1051 104 {
iveresov@1051 105 _fl_owner = this;
iveresov@1051 106 }
ysr@777 107
ysr@777 108 void** PtrQueueSet::allocate_buffer() {
ysr@777 109 assert(_sz > 0, "Didn't set a buffer size.");
iveresov@1051 110 MutexLockerEx x(_fl_owner->_fl_lock, Mutex::_no_safepoint_check_flag);
iveresov@1051 111 if (_fl_owner->_buf_free_list != NULL) {
iveresov@1546 112 void** res = BufferNode::make_buffer_from_node(_fl_owner->_buf_free_list);
iveresov@1546 113 _fl_owner->_buf_free_list = _fl_owner->_buf_free_list->next();
iveresov@1051 114 _fl_owner->_buf_free_list_sz--;
ysr@777 115 return res;
ysr@777 116 } else {
iveresov@1546 117 // Allocate space for the BufferNode in front of the buffer.
zgu@3900 118 char *b = NEW_C_HEAP_ARRAY(char, _sz + BufferNode::aligned_size(), mtGC);
iveresov@1546 119 return BufferNode::make_buffer_from_block(b);
ysr@777 120 }
ysr@777 121 }
ysr@777 122
ysr@777 123 void PtrQueueSet::deallocate_buffer(void** buf) {
ysr@777 124 assert(_sz > 0, "Didn't set a buffer size.");
iveresov@1051 125 MutexLockerEx x(_fl_owner->_fl_lock, Mutex::_no_safepoint_check_flag);
iveresov@1546 126 BufferNode *node = BufferNode::make_node_from_buffer(buf);
iveresov@1546 127 node->set_next(_fl_owner->_buf_free_list);
iveresov@1546 128 _fl_owner->_buf_free_list = node;
iveresov@1051 129 _fl_owner->_buf_free_list_sz++;
ysr@777 130 }
ysr@777 131
ysr@777 132 void PtrQueueSet::reduce_free_list() {
iveresov@1546 133 assert(_fl_owner == this, "Free list reduction is allowed only for the owner");
ysr@777 134 // For now we'll adopt the strategy of deleting half.
ysr@777 135 MutexLockerEx x(_fl_lock, Mutex::_no_safepoint_check_flag);
ysr@777 136 size_t n = _buf_free_list_sz / 2;
ysr@777 137 while (n > 0) {
ysr@777 138 assert(_buf_free_list != NULL, "_buf_free_list_sz must be wrong.");
iveresov@1546 139 void* b = BufferNode::make_block_from_node(_buf_free_list);
iveresov@1546 140 _buf_free_list = _buf_free_list->next();
zgu@3900 141 FREE_C_HEAP_ARRAY(char, b, mtGC);
johnc@1519 142 _buf_free_list_sz --;
ysr@777 143 n--;
ysr@777 144 }
ysr@777 145 }
ysr@777 146
iveresov@1546 147 void PtrQueue::handle_zero_index() {
tonyp@2469 148 assert(_index == 0, "Precondition.");
tonyp@2469 149
iveresov@1546 150 // This thread records the full buffer and allocates a new one (while
iveresov@1546 151 // holding the lock if there is one).
iveresov@1546 152 if (_buf != NULL) {
tonyp@2469 153 if (!should_enqueue_buffer()) {
tonyp@2469 154 assert(_index > 0, "the buffer can only be re-used if it's not full");
tonyp@2469 155 return;
tonyp@2469 156 }
tonyp@2469 157
iveresov@1546 158 if (_lock) {
johnc@1604 159 assert(_lock->owned_by_self(), "Required.");
johnc@1604 160
johnc@1604 161 // The current PtrQ may be the shared dirty card queue and
johnc@1604 162 // may be being manipulated by more than one worker thread
johnc@1604 163 // during a pause. Since the enqueuing of the completed
johnc@1604 164 // buffer unlocks the Shared_DirtyCardQ_lock more than one
johnc@1604 165 // worker thread can 'race' on reading the shared queue attributes
johnc@1604 166 // (_buf and _index) and multiple threads can call into this
johnc@1604 167 // routine for the same buffer. This will cause the completed
johnc@1604 168 // buffer to be added to the CBL multiple times.
johnc@1604 169
johnc@1604 170 // We "claim" the current buffer by caching value of _buf in
johnc@1604 171 // a local and clearing the field while holding _lock. When
johnc@1604 172 // _lock is released (while enqueueing the completed buffer)
johnc@1604 173 // the thread that acquires _lock will skip this code,
johnc@1604 174 // preventing the subsequent the multiple enqueue, and
johnc@1604 175 // install a newly allocated buffer below.
johnc@1604 176
johnc@1604 177 void** buf = _buf; // local pointer to completed buffer
johnc@1604 178 _buf = NULL; // clear shared _buf field
johnc@1604 179
johnc@1604 180 locking_enqueue_completed_buffer(buf); // enqueue completed buffer
johnc@1604 181
johnc@1604 182 // While the current thread was enqueuing the buffer another thread
johnc@1604 183 // may have a allocated a new buffer and inserted it into this pointer
johnc@1604 184 // queue. If that happens then we just return so that the current
johnc@1604 185 // thread doesn't overwrite the buffer allocated by the other thread
johnc@1604 186 // and potentially losing some dirtied cards.
johnc@1604 187
johnc@1604 188 if (_buf != NULL) return;
iveresov@1546 189 } else {
iveresov@1546 190 if (qset()->process_or_enqueue_complete_buffer(_buf)) {
iveresov@1546 191 // Recycle the buffer. No allocation.
iveresov@1546 192 _sz = qset()->buffer_size();
iveresov@1546 193 _index = _sz;
iveresov@1546 194 return;
iveresov@1546 195 }
iveresov@1546 196 }
iveresov@1546 197 }
iveresov@1546 198 // Reallocate the buffer
iveresov@1546 199 _buf = qset()->allocate_buffer();
iveresov@1546 200 _sz = qset()->buffer_size();
iveresov@1546 201 _index = _sz;
iveresov@1546 202 assert(0 <= _index && _index <= _sz, "Invariant.");
iveresov@1546 203 }
ysr@777 204
iveresov@1546 205 bool PtrQueueSet::process_or_enqueue_complete_buffer(void** buf) {
iveresov@1546 206 if (Thread::current()->is_Java_thread()) {
iveresov@1546 207 // We don't lock. It is fine to be epsilon-precise here.
iveresov@1546 208 if (_max_completed_queue == 0 || _max_completed_queue > 0 &&
iveresov@1546 209 _n_completed_buffers >= _max_completed_queue + _completed_queue_padding) {
iveresov@1546 210 bool b = mut_process_buffer(buf);
iveresov@1546 211 if (b) {
iveresov@1546 212 // True here means that the buffer hasn't been deallocated and the caller may reuse it.
iveresov@1546 213 return true;
iveresov@1546 214 }
iveresov@1546 215 }
iveresov@1546 216 }
iveresov@1546 217 // The buffer will be enqueued. The caller will have to get a new one.
iveresov@1546 218 enqueue_complete_buffer(buf);
iveresov@1546 219 return false;
iveresov@1546 220 }
ysr@777 221
iveresov@1546 222 void PtrQueueSet::enqueue_complete_buffer(void** buf, size_t index) {
iveresov@1546 223 MutexLockerEx x(_cbl_mon, Mutex::_no_safepoint_check_flag);
iveresov@1546 224 BufferNode* cbn = BufferNode::new_from_buffer(buf);
iveresov@1546 225 cbn->set_index(index);
ysr@777 226 if (_completed_buffers_tail == NULL) {
ysr@777 227 assert(_completed_buffers_head == NULL, "Well-formedness");
ysr@777 228 _completed_buffers_head = cbn;
ysr@777 229 _completed_buffers_tail = cbn;
ysr@777 230 } else {
iveresov@1546 231 _completed_buffers_tail->set_next(cbn);
ysr@777 232 _completed_buffers_tail = cbn;
ysr@777 233 }
ysr@777 234 _n_completed_buffers++;
ysr@777 235
iveresov@1546 236 if (!_process_completed && _process_completed_threshold >= 0 &&
iveresov@1229 237 _n_completed_buffers >= _process_completed_threshold) {
ysr@777 238 _process_completed = true;
ysr@777 239 if (_notify_when_complete)
iveresov@1546 240 _cbl_mon->notify();
ysr@777 241 }
ysr@777 242 debug_only(assert_completed_buffer_list_len_correct_locked());
ysr@777 243 }
ysr@777 244
ysr@777 245 int PtrQueueSet::completed_buffers_list_length() {
ysr@777 246 int n = 0;
iveresov@1546 247 BufferNode* cbn = _completed_buffers_head;
ysr@777 248 while (cbn != NULL) {
ysr@777 249 n++;
iveresov@1546 250 cbn = cbn->next();
ysr@777 251 }
ysr@777 252 return n;
ysr@777 253 }
ysr@777 254
ysr@777 255 void PtrQueueSet::assert_completed_buffer_list_len_correct() {
ysr@777 256 MutexLockerEx x(_cbl_mon, Mutex::_no_safepoint_check_flag);
ysr@777 257 assert_completed_buffer_list_len_correct_locked();
ysr@777 258 }
ysr@777 259
ysr@777 260 void PtrQueueSet::assert_completed_buffer_list_len_correct_locked() {
iveresov@1546 261 guarantee(completed_buffers_list_length() == _n_completed_buffers,
ysr@777 262 "Completed buffer length is wrong.");
ysr@777 263 }
ysr@777 264
ysr@777 265 void PtrQueueSet::set_buffer_size(size_t sz) {
ysr@777 266 assert(_sz == 0 && sz > 0, "Should be called only once.");
ysr@777 267 _sz = sz * oopSize;
ysr@777 268 }
ysr@777 269
iveresov@1546 270 // Merge lists of buffers. Notify the processing threads.
iveresov@1546 271 // The source queue is emptied as a result. The queues
iveresov@1051 272 // must share the monitor.
iveresov@1051 273 void PtrQueueSet::merge_bufferlists(PtrQueueSet *src) {
iveresov@1051 274 assert(_cbl_mon == src->_cbl_mon, "Should share the same lock");
iveresov@1051 275 MutexLockerEx x(_cbl_mon, Mutex::_no_safepoint_check_flag);
iveresov@1051 276 if (_completed_buffers_tail == NULL) {
iveresov@1051 277 assert(_completed_buffers_head == NULL, "Well-formedness");
iveresov@1051 278 _completed_buffers_head = src->_completed_buffers_head;
iveresov@1051 279 _completed_buffers_tail = src->_completed_buffers_tail;
iveresov@1051 280 } else {
iveresov@1051 281 assert(_completed_buffers_head != NULL, "Well formedness");
iveresov@1051 282 if (src->_completed_buffers_head != NULL) {
iveresov@1546 283 _completed_buffers_tail->set_next(src->_completed_buffers_head);
iveresov@1051 284 _completed_buffers_tail = src->_completed_buffers_tail;
iveresov@1051 285 }
iveresov@1051 286 }
iveresov@1051 287 _n_completed_buffers += src->_n_completed_buffers;
iveresov@1051 288
iveresov@1051 289 src->_n_completed_buffers = 0;
iveresov@1051 290 src->_completed_buffers_head = NULL;
iveresov@1051 291 src->_completed_buffers_tail = NULL;
iveresov@1051 292
iveresov@1051 293 assert(_completed_buffers_head == NULL && _completed_buffers_tail == NULL ||
iveresov@1051 294 _completed_buffers_head != NULL && _completed_buffers_tail != NULL,
iveresov@1051 295 "Sanity");
iveresov@1546 296 }
iveresov@1051 297
iveresov@1546 298 void PtrQueueSet::notify_if_necessary() {
iveresov@1546 299 MutexLockerEx x(_cbl_mon, Mutex::_no_safepoint_check_flag);
iveresov@1546 300 if (_n_completed_buffers >= _process_completed_threshold || _max_completed_queue == 0) {
iveresov@1051 301 _process_completed = true;
iveresov@1051 302 if (_notify_when_complete)
iveresov@1546 303 _cbl_mon->notify();
iveresov@1051 304 }
iveresov@1051 305 }

mercurial