src/share/vm/classfile/verifier.cpp

Wed, 28 May 2014 07:36:32 -0700

author
dsamersoff
date
Wed, 28 May 2014 07:36:32 -0700
changeset 8049
c2c7fed86a5e
parent 7666
6b65121b3258
child 7994
04ff2f6cd0eb
child 8525
0095e54dcaa1
permissions
-rw-r--r--

6904403: assert(f == k->has_finalizer(),"inconsistent has_finalizer") with debug VM
Summary: Don't assert if one of classes in hierarhy was redefined
Reviewed-by: coleenp, sspitsyn

duke@435 1 /*
hseigel@7594 2 * Copyright (c) 1998, 2015, Oracle and/or its affiliates. All rights reserved.
duke@435 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@435 4 *
duke@435 5 * This code is free software; you can redistribute it and/or modify it
duke@435 6 * under the terms of the GNU General Public License version 2 only, as
duke@435 7 * published by the Free Software Foundation.
duke@435 8 *
duke@435 9 * This code is distributed in the hope that it will be useful, but WITHOUT
duke@435 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@435 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@435 12 * version 2 for more details (a copy is included in the LICENSE file that
duke@435 13 * accompanied this code).
duke@435 14 *
duke@435 15 * You should have received a copy of the GNU General Public License version
duke@435 16 * 2 along with this work; if not, write to the Free Software Foundation,
duke@435 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@435 18 *
trims@1907 19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
trims@1907 20 * or visit www.oracle.com if you need additional information or have any
trims@1907 21 * questions.
duke@435 22 *
duke@435 23 */
duke@435 24
stefank@2314 25 #include "precompiled.hpp"
stefank@2314 26 #include "classfile/classFileStream.hpp"
stefank@2314 27 #include "classfile/javaClasses.hpp"
stefank@2314 28 #include "classfile/stackMapTable.hpp"
kamg@3992 29 #include "classfile/stackMapFrame.hpp"
kamg@3992 30 #include "classfile/stackMapTableFormat.hpp"
stefank@2314 31 #include "classfile/systemDictionary.hpp"
stefank@2314 32 #include "classfile/verifier.hpp"
stefank@2314 33 #include "classfile/vmSymbols.hpp"
kamg@3992 34 #include "interpreter/bytecodes.hpp"
stefank@2314 35 #include "interpreter/bytecodeStream.hpp"
stefank@2314 36 #include "memory/oopFactory.hpp"
stefank@2314 37 #include "memory/resourceArea.hpp"
stefank@2314 38 #include "oops/instanceKlass.hpp"
stefank@2314 39 #include "oops/oop.inline.hpp"
stefank@2314 40 #include "oops/typeArrayOop.hpp"
stefank@2314 41 #include "prims/jvm.h"
stefank@2314 42 #include "runtime/fieldDescriptor.hpp"
stefank@2314 43 #include "runtime/handles.inline.hpp"
stefank@2314 44 #include "runtime/interfaceSupport.hpp"
stefank@2314 45 #include "runtime/javaCalls.hpp"
goetz@6911 46 #include "runtime/orderAccess.inline.hpp"
stefank@2314 47 #include "runtime/os.hpp"
stefank@2314 48 #ifdef TARGET_ARCH_x86
stefank@2314 49 # include "bytes_x86.hpp"
stefank@2314 50 #endif
stefank@2314 51 #ifdef TARGET_ARCH_sparc
stefank@2314 52 # include "bytes_sparc.hpp"
stefank@2314 53 #endif
stefank@2314 54 #ifdef TARGET_ARCH_zero
stefank@2314 55 # include "bytes_zero.hpp"
stefank@2314 56 #endif
bobv@2508 57 #ifdef TARGET_ARCH_arm
bobv@2508 58 # include "bytes_arm.hpp"
bobv@2508 59 #endif
bobv@2508 60 #ifdef TARGET_ARCH_ppc
bobv@2508 61 # include "bytes_ppc.hpp"
bobv@2508 62 #endif
duke@435 63
hseigel@4816 64 #define NOFAILOVER_MAJOR_VERSION 51
hseigel@4816 65 #define NONZERO_PADDING_BYTES_IN_SWITCH_MAJOR_VERSION 51
bharadwaj@4895 66 #define STATIC_METHOD_IN_INTERFACE_MAJOR_VERSION 52
kamg@1915 67
duke@435 68 // Access to external entry for VerifyClassCodes - old byte code verifier
duke@435 69
duke@435 70 extern "C" {
duke@435 71 typedef jboolean (*verify_byte_codes_fn_t)(JNIEnv *, jclass, char *, jint);
duke@435 72 typedef jboolean (*verify_byte_codes_fn_new_t)(JNIEnv *, jclass, char *, jint, jint);
duke@435 73 }
duke@435 74
duke@435 75 static void* volatile _verify_byte_codes_fn = NULL;
duke@435 76
duke@435 77 static volatile jint _is_new_verify_byte_codes_fn = (jint) true;
duke@435 78
duke@435 79 static void* verify_byte_codes_fn() {
duke@435 80 if (_verify_byte_codes_fn == NULL) {
duke@435 81 void *lib_handle = os::native_java_library();
ikrylov@2322 82 void *func = os::dll_lookup(lib_handle, "VerifyClassCodesForMajorVersion");
duke@435 83 OrderAccess::release_store_ptr(&_verify_byte_codes_fn, func);
duke@435 84 if (func == NULL) {
duke@435 85 OrderAccess::release_store(&_is_new_verify_byte_codes_fn, false);
ikrylov@2322 86 func = os::dll_lookup(lib_handle, "VerifyClassCodes");
duke@435 87 OrderAccess::release_store_ptr(&_verify_byte_codes_fn, func);
duke@435 88 }
duke@435 89 }
duke@435 90 return (void*)_verify_byte_codes_fn;
duke@435 91 }
duke@435 92
duke@435 93
duke@435 94 // Methods in Verifier
duke@435 95
acorn@1408 96 bool Verifier::should_verify_for(oop class_loader, bool should_verify_class) {
acorn@1408 97 return (class_loader == NULL || !should_verify_class) ?
duke@435 98 BytecodeVerificationLocal : BytecodeVerificationRemote;
duke@435 99 }
duke@435 100
duke@435 101 bool Verifier::relax_verify_for(oop loader) {
duke@435 102 bool trusted = java_lang_ClassLoader::is_trusted_loader(loader);
duke@435 103 bool need_verify =
duke@435 104 // verifyAll
duke@435 105 (BytecodeVerificationLocal && BytecodeVerificationRemote) ||
duke@435 106 // verifyRemote
duke@435 107 (!BytecodeVerificationLocal && BytecodeVerificationRemote && !trusted);
duke@435 108 return !need_verify;
duke@435 109 }
duke@435 110
acorn@1408 111 bool Verifier::verify(instanceKlassHandle klass, Verifier::Mode mode, bool should_verify_class, TRAPS) {
coleenp@2497 112 HandleMark hm;
duke@435 113 ResourceMark rm(THREAD);
duke@435 114
coleenp@2497 115 Symbol* exception_name = NULL;
duke@435 116 const size_t message_buffer_len = klass->name()->utf8_length() + 1024;
duke@435 117 char* message_buffer = NEW_RESOURCE_ARRAY(char, message_buffer_len);
kamg@3992 118 char* exception_message = message_buffer;
duke@435 119
duke@435 120 const char* klassName = klass->external_name();
kamg@3992 121 bool can_failover = FailOverToOldVerifier &&
kamg@3992 122 klass->major_version() < NOFAILOVER_MAJOR_VERSION;
duke@435 123
duke@435 124 // If the class should be verified, first see if we can use the split
duke@435 125 // verifier. If not, or if verification fails and FailOverToOldVerifier
duke@435 126 // is set, then call the inference verifier.
acorn@1408 127 if (is_eligible_for_verification(klass, should_verify_class)) {
duke@435 128 if (TraceClassInitialization) {
duke@435 129 tty->print_cr("Start class verification for: %s", klassName);
duke@435 130 }
hseigel@4819 131 if (klass->major_version() >= STACKMAP_ATTRIBUTE_MAJOR_VERSION) {
kamg@3992 132 ClassVerifier split_verifier(klass, THREAD);
kamg@3992 133 split_verifier.verify_class(THREAD);
kamg@3992 134 exception_name = split_verifier.result();
kamg@3992 135 if (can_failover && !HAS_PENDING_EXCEPTION &&
duke@435 136 (exception_name == vmSymbols::java_lang_VerifyError() ||
duke@435 137 exception_name == vmSymbols::java_lang_ClassFormatError())) {
kamg@3992 138 if (TraceClassInitialization || VerboseVerification) {
duke@435 139 tty->print_cr(
duke@435 140 "Fail over class verification to old verifier for: %s", klassName);
duke@435 141 }
duke@435 142 exception_name = inference_verify(
duke@435 143 klass, message_buffer, message_buffer_len, THREAD);
duke@435 144 }
kamg@3992 145 if (exception_name != NULL) {
kamg@3992 146 exception_message = split_verifier.exception_message();
kamg@3992 147 }
duke@435 148 } else {
duke@435 149 exception_name = inference_verify(
duke@435 150 klass, message_buffer, message_buffer_len, THREAD);
duke@435 151 }
duke@435 152
kamg@3992 153 if (TraceClassInitialization || VerboseVerification) {
duke@435 154 if (HAS_PENDING_EXCEPTION) {
duke@435 155 tty->print("Verification for %s has", klassName);
duke@435 156 tty->print_cr(" exception pending %s ",
coleenp@4037 157 InstanceKlass::cast(PENDING_EXCEPTION->klass())->external_name());
coleenp@2497 158 } else if (exception_name != NULL) {
duke@435 159 tty->print_cr("Verification for %s failed", klassName);
duke@435 160 }
duke@435 161 tty->print_cr("End class verification for: %s", klassName);
duke@435 162 }
duke@435 163 }
duke@435 164
duke@435 165 if (HAS_PENDING_EXCEPTION) {
duke@435 166 return false; // use the existing exception
coleenp@2497 167 } else if (exception_name == NULL) {
duke@435 168 return true; // verifcation succeeded
duke@435 169 } else { // VerifyError or ClassFormatError to be created and thrown
duke@435 170 ResourceMark rm(THREAD);
duke@435 171 instanceKlassHandle kls =
duke@435 172 SystemDictionary::resolve_or_fail(exception_name, true, CHECK_false);
duke@435 173 while (!kls.is_null()) {
duke@435 174 if (kls == klass) {
duke@435 175 // If the class being verified is the exception we're creating
duke@435 176 // or one of it's superclasses, we're in trouble and are going
duke@435 177 // to infinitely recurse when we try to initialize the exception.
duke@435 178 // So bail out here by throwing the preallocated VM error.
duke@435 179 THROW_OOP_(Universe::virtual_machine_error_instance(), false);
duke@435 180 }
duke@435 181 kls = kls->super();
duke@435 182 }
duke@435 183 message_buffer[message_buffer_len - 1] = '\0'; // just to be sure
kamg@3992 184 THROW_MSG_(exception_name, exception_message, false);
duke@435 185 }
duke@435 186 }
duke@435 187
acorn@1408 188 bool Verifier::is_eligible_for_verification(instanceKlassHandle klass, bool should_verify_class) {
coleenp@2497 189 Symbol* name = klass->name();
coleenp@4037 190 Klass* refl_magic_klass = SystemDictionary::reflect_MagicAccessorImpl_klass();
acorn@5622 191
acorn@5622 192 bool is_reflect = refl_magic_klass != NULL && klass->is_subtype_of(refl_magic_klass);
duke@435 193
acorn@1408 194 return (should_verify_for(klass->class_loader(), should_verify_class) &&
duke@435 195 // return if the class is a bootstrapping class
acorn@1408 196 // or defineClass specified not to verify by default (flags override passed arg)
duke@435 197 // We need to skip the following four for bootstraping
duke@435 198 name != vmSymbols::java_lang_Object() &&
duke@435 199 name != vmSymbols::java_lang_Class() &&
duke@435 200 name != vmSymbols::java_lang_String() &&
duke@435 201 name != vmSymbols::java_lang_Throwable() &&
duke@435 202
duke@435 203 // Can not verify the bytecodes for shared classes because they have
duke@435 204 // already been rewritten to contain constant pool cache indices,
duke@435 205 // which the verifier can't understand.
duke@435 206 // Shared classes shouldn't have stackmaps either.
duke@435 207 !klass()->is_shared() &&
duke@435 208
duke@435 209 // As of the fix for 4486457 we disable verification for all of the
duke@435 210 // dynamically-generated bytecodes associated with the 1.4
duke@435 211 // reflection implementation, not just those associated with
duke@435 212 // sun/reflect/SerializationConstructorAccessor.
duke@435 213 // NOTE: this is called too early in the bootstrapping process to be
duke@435 214 // guarded by Universe::is_gte_jdk14x_version()/UseNewReflection.
acorn@5622 215 // Also for lambda generated code, gte jdk8
minqi@6116 216 (!is_reflect || VerifyReflectionBytecodes));
duke@435 217 }
duke@435 218
coleenp@2497 219 Symbol* Verifier::inference_verify(
duke@435 220 instanceKlassHandle klass, char* message, size_t message_len, TRAPS) {
duke@435 221 JavaThread* thread = (JavaThread*)THREAD;
duke@435 222 JNIEnv *env = thread->jni_environment();
duke@435 223
duke@435 224 void* verify_func = verify_byte_codes_fn();
duke@435 225
duke@435 226 if (verify_func == NULL) {
duke@435 227 jio_snprintf(message, message_len, "Could not link verifier");
duke@435 228 return vmSymbols::java_lang_VerifyError();
duke@435 229 }
duke@435 230
duke@435 231 ResourceMark rm(THREAD);
kamg@3992 232 if (VerboseVerification) {
duke@435 233 tty->print_cr("Verifying class %s with old format", klass->external_name());
duke@435 234 }
duke@435 235
duke@435 236 jclass cls = (jclass) JNIHandles::make_local(env, klass->java_mirror());
duke@435 237 jint result;
duke@435 238
duke@435 239 {
duke@435 240 HandleMark hm(thread);
duke@435 241 ThreadToNativeFromVM ttn(thread);
duke@435 242 // ThreadToNativeFromVM takes care of changing thread_state, so safepoint
duke@435 243 // code knows that we have left the VM
duke@435 244
duke@435 245 if (_is_new_verify_byte_codes_fn) {
duke@435 246 verify_byte_codes_fn_new_t func =
duke@435 247 CAST_TO_FN_PTR(verify_byte_codes_fn_new_t, verify_func);
duke@435 248 result = (*func)(env, cls, message, (int)message_len,
duke@435 249 klass->major_version());
duke@435 250 } else {
duke@435 251 verify_byte_codes_fn_t func =
duke@435 252 CAST_TO_FN_PTR(verify_byte_codes_fn_t, verify_func);
duke@435 253 result = (*func)(env, cls, message, (int)message_len);
duke@435 254 }
duke@435 255 }
duke@435 256
duke@435 257 JNIHandles::destroy_local(cls);
duke@435 258
duke@435 259 // These numbers are chosen so that VerifyClassCodes interface doesn't need
duke@435 260 // to be changed (still return jboolean (unsigned char)), and result is
duke@435 261 // 1 when verification is passed.
duke@435 262 if (result == 0) {
duke@435 263 return vmSymbols::java_lang_VerifyError();
duke@435 264 } else if (result == 1) {
coleenp@2497 265 return NULL; // verified.
duke@435 266 } else if (result == 2) {
coleenp@2497 267 THROW_MSG_(vmSymbols::java_lang_OutOfMemoryError(), message, NULL);
duke@435 268 } else if (result == 3) {
duke@435 269 return vmSymbols::java_lang_ClassFormatError();
duke@435 270 } else {
duke@435 271 ShouldNotReachHere();
coleenp@2497 272 return NULL;
duke@435 273 }
duke@435 274 }
duke@435 275
kamg@3992 276 TypeOrigin TypeOrigin::null() {
kamg@3992 277 return TypeOrigin();
kamg@3992 278 }
kamg@3992 279 TypeOrigin TypeOrigin::local(u2 index, StackMapFrame* frame) {
kamg@3992 280 assert(frame != NULL, "Must have a frame");
kamg@3992 281 return TypeOrigin(CF_LOCALS, index, StackMapFrame::copy(frame),
kamg@3992 282 frame->local_at(index));
kamg@3992 283 }
kamg@3992 284 TypeOrigin TypeOrigin::stack(u2 index, StackMapFrame* frame) {
kamg@3992 285 assert(frame != NULL, "Must have a frame");
kamg@3992 286 return TypeOrigin(CF_STACK, index, StackMapFrame::copy(frame),
kamg@3992 287 frame->stack_at(index));
kamg@3992 288 }
kamg@3992 289 TypeOrigin TypeOrigin::sm_local(u2 index, StackMapFrame* frame) {
kamg@3992 290 assert(frame != NULL, "Must have a frame");
kamg@3992 291 return TypeOrigin(SM_LOCALS, index, StackMapFrame::copy(frame),
kamg@3992 292 frame->local_at(index));
kamg@3992 293 }
kamg@3992 294 TypeOrigin TypeOrigin::sm_stack(u2 index, StackMapFrame* frame) {
kamg@3992 295 assert(frame != NULL, "Must have a frame");
kamg@3992 296 return TypeOrigin(SM_STACK, index, StackMapFrame::copy(frame),
kamg@3992 297 frame->stack_at(index));
kamg@3992 298 }
kamg@3992 299 TypeOrigin TypeOrigin::bad_index(u2 index) {
kamg@3992 300 return TypeOrigin(BAD_INDEX, index, NULL, VerificationType::bogus_type());
kamg@3992 301 }
kamg@3992 302 TypeOrigin TypeOrigin::cp(u2 index, VerificationType vt) {
kamg@3992 303 return TypeOrigin(CONST_POOL, index, NULL, vt);
kamg@3992 304 }
kamg@3992 305 TypeOrigin TypeOrigin::signature(VerificationType vt) {
kamg@3992 306 return TypeOrigin(SIG, 0, NULL, vt);
kamg@3992 307 }
kamg@3992 308 TypeOrigin TypeOrigin::implicit(VerificationType t) {
kamg@3992 309 return TypeOrigin(IMPLICIT, 0, NULL, t);
kamg@3992 310 }
kamg@3992 311 TypeOrigin TypeOrigin::frame(StackMapFrame* frame) {
kamg@3992 312 return TypeOrigin(FRAME_ONLY, 0, StackMapFrame::copy(frame),
kamg@3992 313 VerificationType::bogus_type());
kamg@3992 314 }
kamg@3992 315
kamg@3992 316 void TypeOrigin::reset_frame() {
kamg@3992 317 if (_frame != NULL) {
kamg@3992 318 _frame->restore();
kamg@3992 319 }
kamg@3992 320 }
kamg@3992 321
kamg@3992 322 void TypeOrigin::details(outputStream* ss) const {
kamg@3992 323 _type.print_on(ss);
kamg@3992 324 switch (_origin) {
kamg@3992 325 case CF_LOCALS:
kamg@3992 326 ss->print(" (current frame, locals[%d])", _index);
kamg@3992 327 break;
kamg@3992 328 case CF_STACK:
kamg@3992 329 ss->print(" (current frame, stack[%d])", _index);
kamg@3992 330 break;
kamg@3992 331 case SM_LOCALS:
kamg@3992 332 ss->print(" (stack map, locals[%d])", _index);
kamg@3992 333 break;
kamg@3992 334 case SM_STACK:
kamg@3992 335 ss->print(" (stack map, stack[%d])", _index);
kamg@3992 336 break;
kamg@3992 337 case CONST_POOL:
kamg@3992 338 ss->print(" (constant pool %d)", _index);
kamg@3992 339 break;
kamg@3992 340 case SIG:
kamg@3992 341 ss->print(" (from method signature)");
kamg@3992 342 break;
kamg@3992 343 case IMPLICIT:
kamg@3992 344 case FRAME_ONLY:
kamg@3992 345 case NONE:
kamg@3992 346 default:
kamg@3992 347 ;
kamg@3992 348 }
kamg@3992 349 }
kamg@3992 350
kamg@3992 351 #ifdef ASSERT
kamg@3992 352 void TypeOrigin::print_on(outputStream* str) const {
kamg@3992 353 str->print("{%d,%d,%p:", _origin, _index, _frame);
kamg@3992 354 if (_frame != NULL) {
kamg@3992 355 _frame->print_on(str);
kamg@3992 356 } else {
kamg@3992 357 str->print("null");
kamg@3992 358 }
kamg@3992 359 str->print(",");
kamg@3992 360 _type.print_on(str);
kamg@3992 361 str->print("}");
kamg@3992 362 }
kamg@3992 363 #endif
kamg@3992 364
minqi@5097 365 void ErrorContext::details(outputStream* ss, const Method* method) const {
kamg@3992 366 if (is_valid()) {
drchase@6680 367 ss->cr();
kamg@3992 368 ss->print_cr("Exception Details:");
kamg@3992 369 location_details(ss, method);
kamg@3992 370 reason_details(ss);
kamg@3992 371 frame_details(ss);
kamg@3992 372 bytecode_details(ss, method);
kamg@3992 373 handler_details(ss, method);
kamg@3992 374 stackmap_details(ss, method);
kamg@3992 375 }
kamg@3992 376 }
kamg@3992 377
kamg@3992 378 void ErrorContext::reason_details(outputStream* ss) const {
kamg@3992 379 streamIndentor si(ss);
kamg@3992 380 ss->indent().print_cr("Reason:");
kamg@3992 381 streamIndentor si2(ss);
drchase@6680 382 ss->indent().print("%s", "");
kamg@3992 383 switch (_fault) {
kamg@3992 384 case INVALID_BYTECODE:
kamg@3992 385 ss->print("Error exists in the bytecode");
kamg@3992 386 break;
kamg@3992 387 case WRONG_TYPE:
kamg@3992 388 if (_expected.is_valid()) {
kamg@3992 389 ss->print("Type ");
kamg@3992 390 _type.details(ss);
kamg@3992 391 ss->print(" is not assignable to ");
kamg@3992 392 _expected.details(ss);
kamg@3992 393 } else {
kamg@3992 394 ss->print("Invalid type: ");
kamg@3992 395 _type.details(ss);
kamg@3992 396 }
kamg@3992 397 break;
kamg@3992 398 case FLAGS_MISMATCH:
kamg@3992 399 if (_expected.is_valid()) {
kamg@3992 400 ss->print("Current frame's flags are not assignable "
kamg@3992 401 "to stack map frame's.");
kamg@3992 402 } else {
kamg@3992 403 ss->print("Current frame's flags are invalid in this context.");
kamg@3992 404 }
kamg@3992 405 break;
kamg@3992 406 case BAD_CP_INDEX:
kamg@3992 407 ss->print("Constant pool index %d is invalid", _type.index());
kamg@3992 408 break;
kamg@3992 409 case BAD_LOCAL_INDEX:
kamg@3992 410 ss->print("Local index %d is invalid", _type.index());
kamg@3992 411 break;
kamg@3992 412 case LOCALS_SIZE_MISMATCH:
kamg@3992 413 ss->print("Current frame's local size doesn't match stackmap.");
kamg@3992 414 break;
kamg@3992 415 case STACK_SIZE_MISMATCH:
kamg@3992 416 ss->print("Current frame's stack size doesn't match stackmap.");
kamg@3992 417 break;
kamg@3992 418 case STACK_OVERFLOW:
kamg@3992 419 ss->print("Exceeded max stack size.");
kamg@3992 420 break;
kamg@3992 421 case STACK_UNDERFLOW:
kamg@3992 422 ss->print("Attempt to pop empty stack.");
kamg@3992 423 break;
kamg@3992 424 case MISSING_STACKMAP:
kamg@3992 425 ss->print("Expected stackmap frame at this location.");
kamg@3992 426 break;
kamg@3992 427 case BAD_STACKMAP:
kamg@3992 428 ss->print("Invalid stackmap specification.");
kamg@3992 429 break;
kamg@3992 430 case UNKNOWN:
kamg@3992 431 default:
kamg@3992 432 ShouldNotReachHere();
kamg@3992 433 ss->print_cr("Unknown");
kamg@3992 434 }
drchase@6680 435 ss->cr();
kamg@3992 436 }
kamg@3992 437
minqi@5097 438 void ErrorContext::location_details(outputStream* ss, const Method* method) const {
kamg@3992 439 if (_bci != -1 && method != NULL) {
kamg@3992 440 streamIndentor si(ss);
kamg@3992 441 const char* bytecode_name = "<invalid>";
kamg@3992 442 if (method->validate_bci_from_bcx(_bci) != -1) {
kamg@3992 443 Bytecodes::Code code = Bytecodes::code_or_bp_at(method->bcp_from(_bci));
kamg@3992 444 if (Bytecodes::is_defined(code)) {
kamg@3992 445 bytecode_name = Bytecodes::name(code);
kamg@3992 446 } else {
kamg@3992 447 bytecode_name = "<illegal>";
kamg@3992 448 }
kamg@3992 449 }
coleenp@4251 450 InstanceKlass* ik = method->method_holder();
kamg@3992 451 ss->indent().print_cr("Location:");
kamg@3992 452 streamIndentor si2(ss);
kamg@3992 453 ss->indent().print_cr("%s.%s%s @%d: %s",
kamg@3992 454 ik->name()->as_C_string(), method->name()->as_C_string(),
kamg@3992 455 method->signature()->as_C_string(), _bci, bytecode_name);
kamg@3992 456 }
kamg@3992 457 }
kamg@3992 458
kamg@3992 459 void ErrorContext::frame_details(outputStream* ss) const {
kamg@3992 460 streamIndentor si(ss);
kamg@3992 461 if (_type.is_valid() && _type.frame() != NULL) {
kamg@3992 462 ss->indent().print_cr("Current Frame:");
kamg@3992 463 streamIndentor si2(ss);
kamg@3992 464 _type.frame()->print_on(ss);
kamg@3992 465 }
kamg@3992 466 if (_expected.is_valid() && _expected.frame() != NULL) {
kamg@3992 467 ss->indent().print_cr("Stackmap Frame:");
kamg@3992 468 streamIndentor si2(ss);
kamg@3992 469 _expected.frame()->print_on(ss);
kamg@3992 470 }
kamg@3992 471 }
kamg@3992 472
minqi@5097 473 void ErrorContext::bytecode_details(outputStream* ss, const Method* method) const {
kamg@3992 474 if (method != NULL) {
kamg@3992 475 streamIndentor si(ss);
kamg@3992 476 ss->indent().print_cr("Bytecode:");
kamg@3992 477 streamIndentor si2(ss);
kamg@3992 478 ss->print_data(method->code_base(), method->code_size(), false);
kamg@3992 479 }
kamg@3992 480 }
kamg@3992 481
minqi@5097 482 void ErrorContext::handler_details(outputStream* ss, const Method* method) const {
kamg@3992 483 if (method != NULL) {
kamg@3992 484 streamIndentor si(ss);
kamg@3992 485 ExceptionTable table(method);
kamg@3992 486 if (table.length() > 0) {
kamg@3992 487 ss->indent().print_cr("Exception Handler Table:");
kamg@3992 488 streamIndentor si2(ss);
kamg@3992 489 for (int i = 0; i < table.length(); ++i) {
kamg@3992 490 ss->indent().print_cr("bci [%d, %d] => handler: %d", table.start_pc(i),
kamg@3992 491 table.end_pc(i), table.handler_pc(i));
kamg@3992 492 }
kamg@3992 493 }
kamg@3992 494 }
kamg@3992 495 }
kamg@3992 496
minqi@5097 497 void ErrorContext::stackmap_details(outputStream* ss, const Method* method) const {
kamg@3992 498 if (method != NULL && method->has_stackmap_table()) {
kamg@3992 499 streamIndentor si(ss);
kamg@3992 500 ss->indent().print_cr("Stackmap Table:");
coleenp@4037 501 Array<u1>* data = method->stackmap_data();
kamg@3992 502 stack_map_table* sm_table =
coleenp@4037 503 stack_map_table::at((address)data->adr_at(0));
kamg@3992 504 stack_map_frame* sm_frame = sm_table->entries();
kamg@3992 505 streamIndentor si2(ss);
kamg@3992 506 int current_offset = -1;
kamg@3992 507 for (u2 i = 0; i < sm_table->number_of_entries(); ++i) {
kamg@3992 508 ss->indent();
kamg@3992 509 sm_frame->print_on(ss, current_offset);
drchase@6680 510 ss->cr();
kamg@3992 511 current_offset += sm_frame->offset_delta();
kamg@3992 512 sm_frame = sm_frame->next();
kamg@3992 513 }
kamg@3992 514 }
kamg@3992 515 }
kamg@3992 516
duke@435 517 // Methods in ClassVerifier
duke@435 518
duke@435 519 ClassVerifier::ClassVerifier(
kamg@3992 520 instanceKlassHandle klass, TRAPS)
kamg@3992 521 : _thread(THREAD), _exception_type(NULL), _message(NULL), _klass(klass) {
duke@435 522 _this_type = VerificationType::reference_type(klass->name());
coleenp@2497 523 // Create list to hold symbols in reference area.
coleenp@2497 524 _symbols = new GrowableArray<Symbol*>(100, 0, NULL);
duke@435 525 }
duke@435 526
duke@435 527 ClassVerifier::~ClassVerifier() {
coleenp@2497 528 // Decrement the reference count for any symbols created.
coleenp@2497 529 for (int i = 0; i < _symbols->length(); i++) {
coleenp@2497 530 Symbol* s = _symbols->at(i);
coleenp@2497 531 s->decrement_refcount();
coleenp@2497 532 }
duke@435 533 }
duke@435 534
kamg@2297 535 VerificationType ClassVerifier::object_type() const {
kamg@2297 536 return VerificationType::reference_type(vmSymbols::java_lang_Object());
kamg@2297 537 }
kamg@2297 538
kamg@3992 539 TypeOrigin ClassVerifier::ref_ctx(const char* sig, TRAPS) {
kamg@3992 540 VerificationType vt = VerificationType::reference_type(
kamg@3992 541 create_temporary_symbol(sig, (int)strlen(sig), THREAD));
kamg@3992 542 return TypeOrigin::implicit(vt);
kamg@3992 543 }
kamg@3992 544
duke@435 545 void ClassVerifier::verify_class(TRAPS) {
kamg@3992 546 if (VerboseVerification) {
duke@435 547 tty->print_cr("Verifying class %s with new format",
duke@435 548 _klass->external_name());
duke@435 549 }
duke@435 550
coleenp@4037 551 Array<Method*>* methods = _klass->methods();
duke@435 552 int num_methods = methods->length();
duke@435 553
duke@435 554 for (int index = 0; index < num_methods; index++) {
jrose@1925 555 // Check for recursive re-verification before each method.
jrose@1925 556 if (was_recursively_verified()) return;
jrose@1925 557
coleenp@4037 558 Method* m = methods->at(index);
kamg@4245 559 if (m->is_native() || m->is_abstract() || m->is_overpass()) {
duke@435 560 // If m is native or abstract, skip it. It is checked in class file
kamg@4245 561 // parser that methods do not override a final method. Overpass methods
kamg@4245 562 // are trusted since the VM generates them.
duke@435 563 continue;
duke@435 564 }
duke@435 565 verify_method(methodHandle(THREAD, m), CHECK_VERIFY(this));
duke@435 566 }
jrose@1925 567
kamg@3992 568 if (VerboseVerification || TraceClassInitialization) {
jrose@1925 569 if (was_recursively_verified())
jrose@1925 570 tty->print_cr("Recursive verification detected for: %s",
jrose@1925 571 _klass->external_name());
jrose@1925 572 }
duke@435 573 }
duke@435 574
duke@435 575 void ClassVerifier::verify_method(methodHandle m, TRAPS) {
coleenp@4037 576 HandleMark hm(THREAD);
duke@435 577 _method = m; // initialize _method
kamg@3992 578 if (VerboseVerification) {
duke@435 579 tty->print_cr("Verifying method %s", m->name_and_sig_as_C_string());
duke@435 580 }
duke@435 581
drchase@6680 582 // For clang, the only good constant format string is a literal constant format string.
drchase@6680 583 #define bad_type_msg "Bad type on operand stack in %s"
duke@435 584
twisti@3974 585 int32_t max_stack = m->verifier_max_stack();
duke@435 586 int32_t max_locals = m->max_locals();
duke@435 587 constantPoolHandle cp(THREAD, m->constants());
duke@435 588
duke@435 589 if (!SignatureVerifier::is_valid_method_signature(m->signature())) {
duke@435 590 class_format_error("Invalid method signature");
duke@435 591 return;
duke@435 592 }
duke@435 593
duke@435 594 // Initial stack map frame: offset is 0, stack is initially empty.
duke@435 595 StackMapFrame current_frame(max_locals, max_stack, this);
duke@435 596 // Set initial locals
duke@435 597 VerificationType return_type = current_frame.set_locals_from_arg(
duke@435 598 m, current_type(), CHECK_VERIFY(this));
duke@435 599
duke@435 600 int32_t stackmap_index = 0; // index to the stackmap array
duke@435 601
duke@435 602 u4 code_length = m->code_size();
duke@435 603
duke@435 604 // Scan the bytecode and map each instruction's start offset to a number.
duke@435 605 char* code_data = generate_code_data(m, code_length, CHECK_VERIFY(this));
duke@435 606
duke@435 607 int ex_min = code_length;
duke@435 608 int ex_max = -1;
duke@435 609 // Look through each item on the exception table. Each of the fields must refer
duke@435 610 // to a legal instruction.
duke@435 611 verify_exception_handler_table(
duke@435 612 code_length, code_data, ex_min, ex_max, CHECK_VERIFY(this));
duke@435 613
duke@435 614 // Look through each entry on the local variable table and make sure
duke@435 615 // its range of code array offsets is valid. (4169817)
duke@435 616 if (m->has_localvariable_table()) {
duke@435 617 verify_local_variable_table(code_length, code_data, CHECK_VERIFY(this));
duke@435 618 }
duke@435 619
coleenp@4037 620 Array<u1>* stackmap_data = m->stackmap_data();
duke@435 621 StackMapStream stream(stackmap_data);
duke@435 622 StackMapReader reader(this, &stream, code_data, code_length, THREAD);
duke@435 623 StackMapTable stackmap_table(&reader, &current_frame, max_locals, max_stack,
duke@435 624 code_data, code_length, CHECK_VERIFY(this));
duke@435 625
kamg@3992 626 if (VerboseVerification) {
kamg@3992 627 stackmap_table.print_on(tty);
duke@435 628 }
duke@435 629
duke@435 630 RawBytecodeStream bcs(m);
duke@435 631
duke@435 632 // Scan the byte code linearly from the start to the end
duke@435 633 bool no_control_flow = false; // Set to true when there is no direct control
duke@435 634 // flow from current instruction to the next
duke@435 635 // instruction in sequence
hseigel@6761 636
duke@435 637 Bytecodes::Code opcode;
duke@435 638 while (!bcs.is_last_bytecode()) {
jrose@1925 639 // Check for recursive re-verification before each bytecode.
jrose@1925 640 if (was_recursively_verified()) return;
jrose@1925 641
duke@435 642 opcode = bcs.raw_next();
duke@435 643 u2 bci = bcs.bci();
duke@435 644
duke@435 645 // Set current frame's offset to bci
duke@435 646 current_frame.set_offset(bci);
kamg@3992 647 current_frame.set_mark();
duke@435 648
duke@435 649 // Make sure every offset in stackmap table point to the beginning to
duke@435 650 // an instruction. Match current_frame to stackmap_table entry with
duke@435 651 // the same offset if exists.
duke@435 652 stackmap_index = verify_stackmap_table(
duke@435 653 stackmap_index, bci, &current_frame, &stackmap_table,
duke@435 654 no_control_flow, CHECK_VERIFY(this));
duke@435 655
kamg@3992 656
duke@435 657 bool this_uninit = false; // Set to true when invokespecial <init> initialized 'this'
hseigel@7666 658 bool verified_exc_handlers = false;
duke@435 659
duke@435 660 // Merge with the next instruction
duke@435 661 {
duke@435 662 u2 index;
duke@435 663 int target;
duke@435 664 VerificationType type, type2;
duke@435 665 VerificationType atype;
duke@435 666
duke@435 667 #ifndef PRODUCT
kamg@3992 668 if (VerboseVerification) {
kamg@3992 669 current_frame.print_on(tty);
duke@435 670 tty->print_cr("offset = %d, opcode = %s", bci, Bytecodes::name(opcode));
duke@435 671 }
duke@435 672 #endif
duke@435 673
duke@435 674 // Make sure wide instruction is in correct format
duke@435 675 if (bcs.is_wide()) {
duke@435 676 if (opcode != Bytecodes::_iinc && opcode != Bytecodes::_iload &&
duke@435 677 opcode != Bytecodes::_aload && opcode != Bytecodes::_lload &&
duke@435 678 opcode != Bytecodes::_istore && opcode != Bytecodes::_astore &&
duke@435 679 opcode != Bytecodes::_lstore && opcode != Bytecodes::_fload &&
duke@435 680 opcode != Bytecodes::_dload && opcode != Bytecodes::_fstore &&
duke@435 681 opcode != Bytecodes::_dstore) {
kamg@3992 682 /* Unreachable? RawBytecodeStream's raw_next() returns 'illegal'
kamg@3992 683 * if we encounter a wide instruction that modifies an invalid
kamg@3992 684 * opcode (not one of the ones listed above) */
kamg@3992 685 verify_error(ErrorContext::bad_code(bci), "Bad wide instruction");
duke@435 686 return;
duke@435 687 }
duke@435 688 }
duke@435 689
hseigel@7666 690 // Look for possible jump target in exception handlers and see if it
hseigel@7666 691 // matches current_frame. Do this check here for astore*, dstore*,
hseigel@7666 692 // fstore*, istore*, and lstore* opcodes because they can change the type
hseigel@7666 693 // state by adding a local. JVM Spec says that the incoming type state
hseigel@7666 694 // should be used for this check. So, do the check here before a possible
hseigel@7666 695 // local is added to the type state.
hseigel@7666 696 if (Bytecodes::is_store_into_local(opcode) && bci >= ex_min && bci < ex_max) {
hseigel@7666 697 verify_exception_handler_targets(
hseigel@7666 698 bci, this_uninit, &current_frame, &stackmap_table, CHECK_VERIFY(this));
hseigel@7666 699 verified_exc_handlers = true;
hseigel@7666 700 }
hseigel@7666 701
duke@435 702 switch (opcode) {
duke@435 703 case Bytecodes::_nop :
duke@435 704 no_control_flow = false; break;
duke@435 705 case Bytecodes::_aconst_null :
duke@435 706 current_frame.push_stack(
duke@435 707 VerificationType::null_type(), CHECK_VERIFY(this));
duke@435 708 no_control_flow = false; break;
duke@435 709 case Bytecodes::_iconst_m1 :
duke@435 710 case Bytecodes::_iconst_0 :
duke@435 711 case Bytecodes::_iconst_1 :
duke@435 712 case Bytecodes::_iconst_2 :
duke@435 713 case Bytecodes::_iconst_3 :
duke@435 714 case Bytecodes::_iconst_4 :
duke@435 715 case Bytecodes::_iconst_5 :
duke@435 716 current_frame.push_stack(
duke@435 717 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 718 no_control_flow = false; break;
duke@435 719 case Bytecodes::_lconst_0 :
duke@435 720 case Bytecodes::_lconst_1 :
duke@435 721 current_frame.push_stack_2(
duke@435 722 VerificationType::long_type(),
duke@435 723 VerificationType::long2_type(), CHECK_VERIFY(this));
duke@435 724 no_control_flow = false; break;
duke@435 725 case Bytecodes::_fconst_0 :
duke@435 726 case Bytecodes::_fconst_1 :
duke@435 727 case Bytecodes::_fconst_2 :
duke@435 728 current_frame.push_stack(
duke@435 729 VerificationType::float_type(), CHECK_VERIFY(this));
duke@435 730 no_control_flow = false; break;
duke@435 731 case Bytecodes::_dconst_0 :
duke@435 732 case Bytecodes::_dconst_1 :
duke@435 733 current_frame.push_stack_2(
duke@435 734 VerificationType::double_type(),
duke@435 735 VerificationType::double2_type(), CHECK_VERIFY(this));
duke@435 736 no_control_flow = false; break;
duke@435 737 case Bytecodes::_sipush :
duke@435 738 case Bytecodes::_bipush :
duke@435 739 current_frame.push_stack(
duke@435 740 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 741 no_control_flow = false; break;
duke@435 742 case Bytecodes::_ldc :
duke@435 743 verify_ldc(
jrose@1920 744 opcode, bcs.get_index_u1(), &current_frame,
duke@435 745 cp, bci, CHECK_VERIFY(this));
duke@435 746 no_control_flow = false; break;
duke@435 747 case Bytecodes::_ldc_w :
duke@435 748 case Bytecodes::_ldc2_w :
duke@435 749 verify_ldc(
jrose@1920 750 opcode, bcs.get_index_u2(), &current_frame,
duke@435 751 cp, bci, CHECK_VERIFY(this));
duke@435 752 no_control_flow = false; break;
duke@435 753 case Bytecodes::_iload :
duke@435 754 verify_iload(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
duke@435 755 no_control_flow = false; break;
duke@435 756 case Bytecodes::_iload_0 :
duke@435 757 case Bytecodes::_iload_1 :
duke@435 758 case Bytecodes::_iload_2 :
duke@435 759 case Bytecodes::_iload_3 :
duke@435 760 index = opcode - Bytecodes::_iload_0;
duke@435 761 verify_iload(index, &current_frame, CHECK_VERIFY(this));
duke@435 762 no_control_flow = false; break;
duke@435 763 case Bytecodes::_lload :
duke@435 764 verify_lload(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
duke@435 765 no_control_flow = false; break;
duke@435 766 case Bytecodes::_lload_0 :
duke@435 767 case Bytecodes::_lload_1 :
duke@435 768 case Bytecodes::_lload_2 :
duke@435 769 case Bytecodes::_lload_3 :
duke@435 770 index = opcode - Bytecodes::_lload_0;
duke@435 771 verify_lload(index, &current_frame, CHECK_VERIFY(this));
duke@435 772 no_control_flow = false; break;
duke@435 773 case Bytecodes::_fload :
duke@435 774 verify_fload(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
duke@435 775 no_control_flow = false; break;
duke@435 776 case Bytecodes::_fload_0 :
duke@435 777 case Bytecodes::_fload_1 :
duke@435 778 case Bytecodes::_fload_2 :
duke@435 779 case Bytecodes::_fload_3 :
duke@435 780 index = opcode - Bytecodes::_fload_0;
duke@435 781 verify_fload(index, &current_frame, CHECK_VERIFY(this));
duke@435 782 no_control_flow = false; break;
duke@435 783 case Bytecodes::_dload :
duke@435 784 verify_dload(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
duke@435 785 no_control_flow = false; break;
duke@435 786 case Bytecodes::_dload_0 :
duke@435 787 case Bytecodes::_dload_1 :
duke@435 788 case Bytecodes::_dload_2 :
duke@435 789 case Bytecodes::_dload_3 :
duke@435 790 index = opcode - Bytecodes::_dload_0;
duke@435 791 verify_dload(index, &current_frame, CHECK_VERIFY(this));
duke@435 792 no_control_flow = false; break;
duke@435 793 case Bytecodes::_aload :
duke@435 794 verify_aload(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
duke@435 795 no_control_flow = false; break;
duke@435 796 case Bytecodes::_aload_0 :
duke@435 797 case Bytecodes::_aload_1 :
duke@435 798 case Bytecodes::_aload_2 :
duke@435 799 case Bytecodes::_aload_3 :
duke@435 800 index = opcode - Bytecodes::_aload_0;
duke@435 801 verify_aload(index, &current_frame, CHECK_VERIFY(this));
duke@435 802 no_control_flow = false; break;
duke@435 803 case Bytecodes::_iaload :
duke@435 804 type = current_frame.pop_stack(
duke@435 805 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 806 atype = current_frame.pop_stack(
duke@435 807 VerificationType::reference_check(), CHECK_VERIFY(this));
duke@435 808 if (!atype.is_int_array()) {
kamg@3992 809 verify_error(ErrorContext::bad_type(bci,
kamg@3992 810 current_frame.stack_top_ctx(), ref_ctx("[I", THREAD)),
kamg@3992 811 bad_type_msg, "iaload");
duke@435 812 return;
duke@435 813 }
duke@435 814 current_frame.push_stack(
duke@435 815 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 816 no_control_flow = false; break;
duke@435 817 case Bytecodes::_baload :
duke@435 818 type = current_frame.pop_stack(
duke@435 819 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 820 atype = current_frame.pop_stack(
duke@435 821 VerificationType::reference_check(), CHECK_VERIFY(this));
duke@435 822 if (!atype.is_bool_array() && !atype.is_byte_array()) {
kamg@3992 823 verify_error(
kamg@3992 824 ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
kamg@3992 825 bad_type_msg, "baload");
duke@435 826 return;
duke@435 827 }
duke@435 828 current_frame.push_stack(
duke@435 829 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 830 no_control_flow = false; break;
duke@435 831 case Bytecodes::_caload :
duke@435 832 type = current_frame.pop_stack(
duke@435 833 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 834 atype = current_frame.pop_stack(
duke@435 835 VerificationType::reference_check(), CHECK_VERIFY(this));
duke@435 836 if (!atype.is_char_array()) {
kamg@3992 837 verify_error(ErrorContext::bad_type(bci,
kamg@3992 838 current_frame.stack_top_ctx(), ref_ctx("[C", THREAD)),
kamg@3992 839 bad_type_msg, "caload");
duke@435 840 return;
duke@435 841 }
duke@435 842 current_frame.push_stack(
duke@435 843 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 844 no_control_flow = false; break;
duke@435 845 case Bytecodes::_saload :
duke@435 846 type = current_frame.pop_stack(
duke@435 847 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 848 atype = current_frame.pop_stack(
duke@435 849 VerificationType::reference_check(), CHECK_VERIFY(this));
duke@435 850 if (!atype.is_short_array()) {
kamg@3992 851 verify_error(ErrorContext::bad_type(bci,
kamg@3992 852 current_frame.stack_top_ctx(), ref_ctx("[S", THREAD)),
kamg@3992 853 bad_type_msg, "saload");
duke@435 854 return;
duke@435 855 }
duke@435 856 current_frame.push_stack(
duke@435 857 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 858 no_control_flow = false; break;
duke@435 859 case Bytecodes::_laload :
duke@435 860 type = current_frame.pop_stack(
duke@435 861 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 862 atype = current_frame.pop_stack(
duke@435 863 VerificationType::reference_check(), CHECK_VERIFY(this));
duke@435 864 if (!atype.is_long_array()) {
kamg@3992 865 verify_error(ErrorContext::bad_type(bci,
kamg@3992 866 current_frame.stack_top_ctx(), ref_ctx("[J", THREAD)),
kamg@3992 867 bad_type_msg, "laload");
duke@435 868 return;
duke@435 869 }
duke@435 870 current_frame.push_stack_2(
duke@435 871 VerificationType::long_type(),
duke@435 872 VerificationType::long2_type(), CHECK_VERIFY(this));
duke@435 873 no_control_flow = false; break;
duke@435 874 case Bytecodes::_faload :
duke@435 875 type = current_frame.pop_stack(
duke@435 876 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 877 atype = current_frame.pop_stack(
duke@435 878 VerificationType::reference_check(), CHECK_VERIFY(this));
duke@435 879 if (!atype.is_float_array()) {
kamg@3992 880 verify_error(ErrorContext::bad_type(bci,
kamg@3992 881 current_frame.stack_top_ctx(), ref_ctx("[F", THREAD)),
kamg@3992 882 bad_type_msg, "faload");
duke@435 883 return;
duke@435 884 }
duke@435 885 current_frame.push_stack(
duke@435 886 VerificationType::float_type(), CHECK_VERIFY(this));
duke@435 887 no_control_flow = false; break;
duke@435 888 case Bytecodes::_daload :
duke@435 889 type = current_frame.pop_stack(
duke@435 890 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 891 atype = current_frame.pop_stack(
duke@435 892 VerificationType::reference_check(), CHECK_VERIFY(this));
duke@435 893 if (!atype.is_double_array()) {
kamg@3992 894 verify_error(ErrorContext::bad_type(bci,
kamg@3992 895 current_frame.stack_top_ctx(), ref_ctx("[D", THREAD)),
kamg@3992 896 bad_type_msg, "daload");
duke@435 897 return;
duke@435 898 }
duke@435 899 current_frame.push_stack_2(
duke@435 900 VerificationType::double_type(),
duke@435 901 VerificationType::double2_type(), CHECK_VERIFY(this));
duke@435 902 no_control_flow = false; break;
duke@435 903 case Bytecodes::_aaload : {
duke@435 904 type = current_frame.pop_stack(
duke@435 905 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 906 atype = current_frame.pop_stack(
duke@435 907 VerificationType::reference_check(), CHECK_VERIFY(this));
duke@435 908 if (!atype.is_reference_array()) {
kamg@3992 909 verify_error(ErrorContext::bad_type(bci,
kamg@3992 910 current_frame.stack_top_ctx(),
kamg@3992 911 TypeOrigin::implicit(VerificationType::reference_check())),
kamg@3992 912 bad_type_msg, "aaload");
duke@435 913 return;
duke@435 914 }
duke@435 915 if (atype.is_null()) {
duke@435 916 current_frame.push_stack(
duke@435 917 VerificationType::null_type(), CHECK_VERIFY(this));
duke@435 918 } else {
duke@435 919 VerificationType component =
coleenp@2497 920 atype.get_component(this, CHECK_VERIFY(this));
duke@435 921 current_frame.push_stack(component, CHECK_VERIFY(this));
duke@435 922 }
duke@435 923 no_control_flow = false; break;
duke@435 924 }
duke@435 925 case Bytecodes::_istore :
duke@435 926 verify_istore(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
duke@435 927 no_control_flow = false; break;
duke@435 928 case Bytecodes::_istore_0 :
duke@435 929 case Bytecodes::_istore_1 :
duke@435 930 case Bytecodes::_istore_2 :
duke@435 931 case Bytecodes::_istore_3 :
duke@435 932 index = opcode - Bytecodes::_istore_0;
duke@435 933 verify_istore(index, &current_frame, CHECK_VERIFY(this));
duke@435 934 no_control_flow = false; break;
duke@435 935 case Bytecodes::_lstore :
duke@435 936 verify_lstore(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
duke@435 937 no_control_flow = false; break;
duke@435 938 case Bytecodes::_lstore_0 :
duke@435 939 case Bytecodes::_lstore_1 :
duke@435 940 case Bytecodes::_lstore_2 :
duke@435 941 case Bytecodes::_lstore_3 :
duke@435 942 index = opcode - Bytecodes::_lstore_0;
duke@435 943 verify_lstore(index, &current_frame, CHECK_VERIFY(this));
duke@435 944 no_control_flow = false; break;
duke@435 945 case Bytecodes::_fstore :
duke@435 946 verify_fstore(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
duke@435 947 no_control_flow = false; break;
duke@435 948 case Bytecodes::_fstore_0 :
duke@435 949 case Bytecodes::_fstore_1 :
duke@435 950 case Bytecodes::_fstore_2 :
duke@435 951 case Bytecodes::_fstore_3 :
duke@435 952 index = opcode - Bytecodes::_fstore_0;
duke@435 953 verify_fstore(index, &current_frame, CHECK_VERIFY(this));
duke@435 954 no_control_flow = false; break;
duke@435 955 case Bytecodes::_dstore :
duke@435 956 verify_dstore(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
duke@435 957 no_control_flow = false; break;
duke@435 958 case Bytecodes::_dstore_0 :
duke@435 959 case Bytecodes::_dstore_1 :
duke@435 960 case Bytecodes::_dstore_2 :
duke@435 961 case Bytecodes::_dstore_3 :
duke@435 962 index = opcode - Bytecodes::_dstore_0;
duke@435 963 verify_dstore(index, &current_frame, CHECK_VERIFY(this));
duke@435 964 no_control_flow = false; break;
duke@435 965 case Bytecodes::_astore :
duke@435 966 verify_astore(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
duke@435 967 no_control_flow = false; break;
duke@435 968 case Bytecodes::_astore_0 :
duke@435 969 case Bytecodes::_astore_1 :
duke@435 970 case Bytecodes::_astore_2 :
duke@435 971 case Bytecodes::_astore_3 :
duke@435 972 index = opcode - Bytecodes::_astore_0;
duke@435 973 verify_astore(index, &current_frame, CHECK_VERIFY(this));
duke@435 974 no_control_flow = false; break;
duke@435 975 case Bytecodes::_iastore :
duke@435 976 type = current_frame.pop_stack(
duke@435 977 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 978 type2 = current_frame.pop_stack(
duke@435 979 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 980 atype = current_frame.pop_stack(
duke@435 981 VerificationType::reference_check(), CHECK_VERIFY(this));
duke@435 982 if (!atype.is_int_array()) {
kamg@3992 983 verify_error(ErrorContext::bad_type(bci,
kamg@3992 984 current_frame.stack_top_ctx(), ref_ctx("[I", THREAD)),
kamg@3992 985 bad_type_msg, "iastore");
duke@435 986 return;
duke@435 987 }
duke@435 988 no_control_flow = false; break;
duke@435 989 case Bytecodes::_bastore :
duke@435 990 type = current_frame.pop_stack(
duke@435 991 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 992 type2 = current_frame.pop_stack(
duke@435 993 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 994 atype = current_frame.pop_stack(
duke@435 995 VerificationType::reference_check(), CHECK_VERIFY(this));
duke@435 996 if (!atype.is_bool_array() && !atype.is_byte_array()) {
kamg@3992 997 verify_error(
kamg@3992 998 ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
kamg@3992 999 bad_type_msg, "bastore");
duke@435 1000 return;
duke@435 1001 }
duke@435 1002 no_control_flow = false; break;
duke@435 1003 case Bytecodes::_castore :
duke@435 1004 current_frame.pop_stack(
duke@435 1005 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 1006 current_frame.pop_stack(
duke@435 1007 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 1008 atype = current_frame.pop_stack(
duke@435 1009 VerificationType::reference_check(), CHECK_VERIFY(this));
duke@435 1010 if (!atype.is_char_array()) {
kamg@3992 1011 verify_error(ErrorContext::bad_type(bci,
kamg@3992 1012 current_frame.stack_top_ctx(), ref_ctx("[C", THREAD)),
kamg@3992 1013 bad_type_msg, "castore");
duke@435 1014 return;
duke@435 1015 }
duke@435 1016 no_control_flow = false; break;
duke@435 1017 case Bytecodes::_sastore :
duke@435 1018 current_frame.pop_stack(
duke@435 1019 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 1020 current_frame.pop_stack(
duke@435 1021 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 1022 atype = current_frame.pop_stack(
duke@435 1023 VerificationType::reference_check(), CHECK_VERIFY(this));
duke@435 1024 if (!atype.is_short_array()) {
kamg@3992 1025 verify_error(ErrorContext::bad_type(bci,
kamg@3992 1026 current_frame.stack_top_ctx(), ref_ctx("[S", THREAD)),
kamg@3992 1027 bad_type_msg, "sastore");
duke@435 1028 return;
duke@435 1029 }
duke@435 1030 no_control_flow = false; break;
duke@435 1031 case Bytecodes::_lastore :
duke@435 1032 current_frame.pop_stack_2(
duke@435 1033 VerificationType::long2_type(),
duke@435 1034 VerificationType::long_type(), CHECK_VERIFY(this));
duke@435 1035 current_frame.pop_stack(
duke@435 1036 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 1037 atype = current_frame.pop_stack(
duke@435 1038 VerificationType::reference_check(), CHECK_VERIFY(this));
duke@435 1039 if (!atype.is_long_array()) {
kamg@3992 1040 verify_error(ErrorContext::bad_type(bci,
kamg@3992 1041 current_frame.stack_top_ctx(), ref_ctx("[J", THREAD)),
kamg@3992 1042 bad_type_msg, "lastore");
duke@435 1043 return;
duke@435 1044 }
duke@435 1045 no_control_flow = false; break;
duke@435 1046 case Bytecodes::_fastore :
duke@435 1047 current_frame.pop_stack(
duke@435 1048 VerificationType::float_type(), CHECK_VERIFY(this));
duke@435 1049 current_frame.pop_stack
duke@435 1050 (VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 1051 atype = current_frame.pop_stack(
duke@435 1052 VerificationType::reference_check(), CHECK_VERIFY(this));
duke@435 1053 if (!atype.is_float_array()) {
kamg@3992 1054 verify_error(ErrorContext::bad_type(bci,
kamg@3992 1055 current_frame.stack_top_ctx(), ref_ctx("[F", THREAD)),
kamg@3992 1056 bad_type_msg, "fastore");
duke@435 1057 return;
duke@435 1058 }
duke@435 1059 no_control_flow = false; break;
duke@435 1060 case Bytecodes::_dastore :
duke@435 1061 current_frame.pop_stack_2(
duke@435 1062 VerificationType::double2_type(),
duke@435 1063 VerificationType::double_type(), CHECK_VERIFY(this));
duke@435 1064 current_frame.pop_stack(
duke@435 1065 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 1066 atype = current_frame.pop_stack(
duke@435 1067 VerificationType::reference_check(), CHECK_VERIFY(this));
duke@435 1068 if (!atype.is_double_array()) {
kamg@3992 1069 verify_error(ErrorContext::bad_type(bci,
kamg@3992 1070 current_frame.stack_top_ctx(), ref_ctx("[D", THREAD)),
kamg@3992 1071 bad_type_msg, "dastore");
duke@435 1072 return;
duke@435 1073 }
duke@435 1074 no_control_flow = false; break;
duke@435 1075 case Bytecodes::_aastore :
kamg@2297 1076 type = current_frame.pop_stack(object_type(), CHECK_VERIFY(this));
duke@435 1077 type2 = current_frame.pop_stack(
duke@435 1078 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 1079 atype = current_frame.pop_stack(
duke@435 1080 VerificationType::reference_check(), CHECK_VERIFY(this));
duke@435 1081 // more type-checking is done at runtime
duke@435 1082 if (!atype.is_reference_array()) {
kamg@3992 1083 verify_error(ErrorContext::bad_type(bci,
kamg@3992 1084 current_frame.stack_top_ctx(),
kamg@3992 1085 TypeOrigin::implicit(VerificationType::reference_check())),
kamg@3992 1086 bad_type_msg, "aastore");
duke@435 1087 return;
duke@435 1088 }
duke@435 1089 // 4938384: relaxed constraint in JVMS 3nd edition.
duke@435 1090 no_control_flow = false; break;
duke@435 1091 case Bytecodes::_pop :
duke@435 1092 current_frame.pop_stack(
duke@435 1093 VerificationType::category1_check(), CHECK_VERIFY(this));
duke@435 1094 no_control_flow = false; break;
duke@435 1095 case Bytecodes::_pop2 :
duke@435 1096 type = current_frame.pop_stack(CHECK_VERIFY(this));
duke@435 1097 if (type.is_category1()) {
duke@435 1098 current_frame.pop_stack(
duke@435 1099 VerificationType::category1_check(), CHECK_VERIFY(this));
duke@435 1100 } else if (type.is_category2_2nd()) {
duke@435 1101 current_frame.pop_stack(
duke@435 1102 VerificationType::category2_check(), CHECK_VERIFY(this));
duke@435 1103 } else {
kamg@3992 1104 /* Unreachable? Would need a category2_1st on TOS
kamg@3992 1105 * which does not appear possible. */
kamg@3992 1106 verify_error(
kamg@3992 1107 ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
kamg@3992 1108 bad_type_msg, "pop2");
duke@435 1109 return;
duke@435 1110 }
duke@435 1111 no_control_flow = false; break;
duke@435 1112 case Bytecodes::_dup :
duke@435 1113 type = current_frame.pop_stack(
duke@435 1114 VerificationType::category1_check(), CHECK_VERIFY(this));
duke@435 1115 current_frame.push_stack(type, CHECK_VERIFY(this));
duke@435 1116 current_frame.push_stack(type, CHECK_VERIFY(this));
duke@435 1117 no_control_flow = false; break;
duke@435 1118 case Bytecodes::_dup_x1 :
duke@435 1119 type = current_frame.pop_stack(
duke@435 1120 VerificationType::category1_check(), CHECK_VERIFY(this));
duke@435 1121 type2 = current_frame.pop_stack(
duke@435 1122 VerificationType::category1_check(), CHECK_VERIFY(this));
duke@435 1123 current_frame.push_stack(type, CHECK_VERIFY(this));
duke@435 1124 current_frame.push_stack(type2, CHECK_VERIFY(this));
duke@435 1125 current_frame.push_stack(type, CHECK_VERIFY(this));
duke@435 1126 no_control_flow = false; break;
duke@435 1127 case Bytecodes::_dup_x2 :
duke@435 1128 {
duke@435 1129 VerificationType type3;
duke@435 1130 type = current_frame.pop_stack(
duke@435 1131 VerificationType::category1_check(), CHECK_VERIFY(this));
duke@435 1132 type2 = current_frame.pop_stack(CHECK_VERIFY(this));
duke@435 1133 if (type2.is_category1()) {
duke@435 1134 type3 = current_frame.pop_stack(
duke@435 1135 VerificationType::category1_check(), CHECK_VERIFY(this));
duke@435 1136 } else if (type2.is_category2_2nd()) {
duke@435 1137 type3 = current_frame.pop_stack(
duke@435 1138 VerificationType::category2_check(), CHECK_VERIFY(this));
duke@435 1139 } else {
kamg@3992 1140 /* Unreachable? Would need a category2_1st at stack depth 2 with
kamg@3992 1141 * a category1 on TOS which does not appear possible. */
kamg@3992 1142 verify_error(ErrorContext::bad_type(
kamg@3992 1143 bci, current_frame.stack_top_ctx()), bad_type_msg, "dup_x2");
duke@435 1144 return;
duke@435 1145 }
duke@435 1146 current_frame.push_stack(type, CHECK_VERIFY(this));
duke@435 1147 current_frame.push_stack(type3, CHECK_VERIFY(this));
duke@435 1148 current_frame.push_stack(type2, CHECK_VERIFY(this));
duke@435 1149 current_frame.push_stack(type, CHECK_VERIFY(this));
duke@435 1150 no_control_flow = false; break;
duke@435 1151 }
duke@435 1152 case Bytecodes::_dup2 :
duke@435 1153 type = current_frame.pop_stack(CHECK_VERIFY(this));
duke@435 1154 if (type.is_category1()) {
duke@435 1155 type2 = current_frame.pop_stack(
duke@435 1156 VerificationType::category1_check(), CHECK_VERIFY(this));
duke@435 1157 } else if (type.is_category2_2nd()) {
duke@435 1158 type2 = current_frame.pop_stack(
duke@435 1159 VerificationType::category2_check(), CHECK_VERIFY(this));
duke@435 1160 } else {
kamg@3992 1161 /* Unreachable? Would need a category2_1st on TOS which does not
kamg@3992 1162 * appear possible. */
kamg@3992 1163 verify_error(
kamg@3992 1164 ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
kamg@3992 1165 bad_type_msg, "dup2");
duke@435 1166 return;
duke@435 1167 }
duke@435 1168 current_frame.push_stack(type2, CHECK_VERIFY(this));
duke@435 1169 current_frame.push_stack(type, CHECK_VERIFY(this));
duke@435 1170 current_frame.push_stack(type2, CHECK_VERIFY(this));
duke@435 1171 current_frame.push_stack(type, CHECK_VERIFY(this));
duke@435 1172 no_control_flow = false; break;
duke@435 1173 case Bytecodes::_dup2_x1 :
duke@435 1174 {
duke@435 1175 VerificationType type3;
duke@435 1176 type = current_frame.pop_stack(CHECK_VERIFY(this));
duke@435 1177 if (type.is_category1()) {
duke@435 1178 type2 = current_frame.pop_stack(
duke@435 1179 VerificationType::category1_check(), CHECK_VERIFY(this));
kamg@3992 1180 } else if (type.is_category2_2nd()) {
kamg@3992 1181 type2 = current_frame.pop_stack(
kamg@3992 1182 VerificationType::category2_check(), CHECK_VERIFY(this));
duke@435 1183 } else {
kamg@3992 1184 /* Unreachable? Would need a category2_1st on TOS which does
kamg@3992 1185 * not appear possible. */
kamg@3992 1186 verify_error(
kamg@3992 1187 ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
kamg@3992 1188 bad_type_msg, "dup2_x1");
duke@435 1189 return;
duke@435 1190 }
duke@435 1191 type3 = current_frame.pop_stack(
duke@435 1192 VerificationType::category1_check(), CHECK_VERIFY(this));
duke@435 1193 current_frame.push_stack(type2, CHECK_VERIFY(this));
duke@435 1194 current_frame.push_stack(type, CHECK_VERIFY(this));
duke@435 1195 current_frame.push_stack(type3, CHECK_VERIFY(this));
duke@435 1196 current_frame.push_stack(type2, CHECK_VERIFY(this));
duke@435 1197 current_frame.push_stack(type, CHECK_VERIFY(this));
duke@435 1198 no_control_flow = false; break;
duke@435 1199 }
duke@435 1200 case Bytecodes::_dup2_x2 :
duke@435 1201 {
duke@435 1202 VerificationType type3, type4;
duke@435 1203 type = current_frame.pop_stack(CHECK_VERIFY(this));
duke@435 1204 if (type.is_category1()) {
duke@435 1205 type2 = current_frame.pop_stack(
duke@435 1206 VerificationType::category1_check(), CHECK_VERIFY(this));
duke@435 1207 } else if (type.is_category2_2nd()) {
duke@435 1208 type2 = current_frame.pop_stack(
duke@435 1209 VerificationType::category2_check(), CHECK_VERIFY(this));
duke@435 1210 } else {
kamg@3992 1211 /* Unreachable? Would need a category2_1st on TOS which does
kamg@3992 1212 * not appear possible. */
kamg@3992 1213 verify_error(
kamg@3992 1214 ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
kamg@3992 1215 bad_type_msg, "dup2_x2");
duke@435 1216 return;
duke@435 1217 }
duke@435 1218 type3 = current_frame.pop_stack(CHECK_VERIFY(this));
duke@435 1219 if (type3.is_category1()) {
duke@435 1220 type4 = current_frame.pop_stack(
duke@435 1221 VerificationType::category1_check(), CHECK_VERIFY(this));
duke@435 1222 } else if (type3.is_category2_2nd()) {
duke@435 1223 type4 = current_frame.pop_stack(
duke@435 1224 VerificationType::category2_check(), CHECK_VERIFY(this));
duke@435 1225 } else {
kamg@3992 1226 /* Unreachable? Would need a category2_1st on TOS after popping
kamg@3992 1227 * a long/double or two category 1's, which does not
kamg@3992 1228 * appear possible. */
kamg@3992 1229 verify_error(
kamg@3992 1230 ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
kamg@3992 1231 bad_type_msg, "dup2_x2");
duke@435 1232 return;
duke@435 1233 }
duke@435 1234 current_frame.push_stack(type2, CHECK_VERIFY(this));
duke@435 1235 current_frame.push_stack(type, CHECK_VERIFY(this));
duke@435 1236 current_frame.push_stack(type4, CHECK_VERIFY(this));
duke@435 1237 current_frame.push_stack(type3, CHECK_VERIFY(this));
duke@435 1238 current_frame.push_stack(type2, CHECK_VERIFY(this));
duke@435 1239 current_frame.push_stack(type, CHECK_VERIFY(this));
duke@435 1240 no_control_flow = false; break;
duke@435 1241 }
duke@435 1242 case Bytecodes::_swap :
duke@435 1243 type = current_frame.pop_stack(
duke@435 1244 VerificationType::category1_check(), CHECK_VERIFY(this));
duke@435 1245 type2 = current_frame.pop_stack(
duke@435 1246 VerificationType::category1_check(), CHECK_VERIFY(this));
duke@435 1247 current_frame.push_stack(type, CHECK_VERIFY(this));
duke@435 1248 current_frame.push_stack(type2, CHECK_VERIFY(this));
duke@435 1249 no_control_flow = false; break;
duke@435 1250 case Bytecodes::_iadd :
duke@435 1251 case Bytecodes::_isub :
duke@435 1252 case Bytecodes::_imul :
duke@435 1253 case Bytecodes::_idiv :
duke@435 1254 case Bytecodes::_irem :
duke@435 1255 case Bytecodes::_ishl :
duke@435 1256 case Bytecodes::_ishr :
duke@435 1257 case Bytecodes::_iushr :
duke@435 1258 case Bytecodes::_ior :
duke@435 1259 case Bytecodes::_ixor :
duke@435 1260 case Bytecodes::_iand :
duke@435 1261 current_frame.pop_stack(
duke@435 1262 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 1263 // fall through
duke@435 1264 case Bytecodes::_ineg :
duke@435 1265 current_frame.pop_stack(
duke@435 1266 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 1267 current_frame.push_stack(
duke@435 1268 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 1269 no_control_flow = false; break;
duke@435 1270 case Bytecodes::_ladd :
duke@435 1271 case Bytecodes::_lsub :
duke@435 1272 case Bytecodes::_lmul :
duke@435 1273 case Bytecodes::_ldiv :
duke@435 1274 case Bytecodes::_lrem :
duke@435 1275 case Bytecodes::_land :
duke@435 1276 case Bytecodes::_lor :
duke@435 1277 case Bytecodes::_lxor :
duke@435 1278 current_frame.pop_stack_2(
duke@435 1279 VerificationType::long2_type(),
duke@435 1280 VerificationType::long_type(), CHECK_VERIFY(this));
duke@435 1281 // fall through
duke@435 1282 case Bytecodes::_lneg :
duke@435 1283 current_frame.pop_stack_2(
duke@435 1284 VerificationType::long2_type(),
duke@435 1285 VerificationType::long_type(), CHECK_VERIFY(this));
duke@435 1286 current_frame.push_stack_2(
duke@435 1287 VerificationType::long_type(),
duke@435 1288 VerificationType::long2_type(), CHECK_VERIFY(this));
duke@435 1289 no_control_flow = false; break;
duke@435 1290 case Bytecodes::_lshl :
duke@435 1291 case Bytecodes::_lshr :
duke@435 1292 case Bytecodes::_lushr :
duke@435 1293 current_frame.pop_stack(
duke@435 1294 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 1295 current_frame.pop_stack_2(
duke@435 1296 VerificationType::long2_type(),
duke@435 1297 VerificationType::long_type(), CHECK_VERIFY(this));
duke@435 1298 current_frame.push_stack_2(
duke@435 1299 VerificationType::long_type(),
duke@435 1300 VerificationType::long2_type(), CHECK_VERIFY(this));
duke@435 1301 no_control_flow = false; break;
duke@435 1302 case Bytecodes::_fadd :
duke@435 1303 case Bytecodes::_fsub :
duke@435 1304 case Bytecodes::_fmul :
duke@435 1305 case Bytecodes::_fdiv :
duke@435 1306 case Bytecodes::_frem :
duke@435 1307 current_frame.pop_stack(
duke@435 1308 VerificationType::float_type(), CHECK_VERIFY(this));
duke@435 1309 // fall through
duke@435 1310 case Bytecodes::_fneg :
duke@435 1311 current_frame.pop_stack(
duke@435 1312 VerificationType::float_type(), CHECK_VERIFY(this));
duke@435 1313 current_frame.push_stack(
duke@435 1314 VerificationType::float_type(), CHECK_VERIFY(this));
duke@435 1315 no_control_flow = false; break;
duke@435 1316 case Bytecodes::_dadd :
duke@435 1317 case Bytecodes::_dsub :
duke@435 1318 case Bytecodes::_dmul :
duke@435 1319 case Bytecodes::_ddiv :
duke@435 1320 case Bytecodes::_drem :
duke@435 1321 current_frame.pop_stack_2(
duke@435 1322 VerificationType::double2_type(),
duke@435 1323 VerificationType::double_type(), CHECK_VERIFY(this));
duke@435 1324 // fall through
duke@435 1325 case Bytecodes::_dneg :
duke@435 1326 current_frame.pop_stack_2(
duke@435 1327 VerificationType::double2_type(),
duke@435 1328 VerificationType::double_type(), CHECK_VERIFY(this));
duke@435 1329 current_frame.push_stack_2(
duke@435 1330 VerificationType::double_type(),
duke@435 1331 VerificationType::double2_type(), CHECK_VERIFY(this));
duke@435 1332 no_control_flow = false; break;
duke@435 1333 case Bytecodes::_iinc :
duke@435 1334 verify_iinc(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
duke@435 1335 no_control_flow = false; break;
duke@435 1336 case Bytecodes::_i2l :
duke@435 1337 type = current_frame.pop_stack(
duke@435 1338 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 1339 current_frame.push_stack_2(
duke@435 1340 VerificationType::long_type(),
duke@435 1341 VerificationType::long2_type(), CHECK_VERIFY(this));
duke@435 1342 no_control_flow = false; break;
duke@435 1343 case Bytecodes::_l2i :
duke@435 1344 current_frame.pop_stack_2(
duke@435 1345 VerificationType::long2_type(),
duke@435 1346 VerificationType::long_type(), CHECK_VERIFY(this));
duke@435 1347 current_frame.push_stack(
duke@435 1348 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 1349 no_control_flow = false; break;
duke@435 1350 case Bytecodes::_i2f :
duke@435 1351 current_frame.pop_stack(
duke@435 1352 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 1353 current_frame.push_stack(
duke@435 1354 VerificationType::float_type(), CHECK_VERIFY(this));
duke@435 1355 no_control_flow = false; break;
duke@435 1356 case Bytecodes::_i2d :
duke@435 1357 current_frame.pop_stack(
duke@435 1358 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 1359 current_frame.push_stack_2(
duke@435 1360 VerificationType::double_type(),
duke@435 1361 VerificationType::double2_type(), CHECK_VERIFY(this));
duke@435 1362 no_control_flow = false; break;
duke@435 1363 case Bytecodes::_l2f :
duke@435 1364 current_frame.pop_stack_2(
duke@435 1365 VerificationType::long2_type(),
duke@435 1366 VerificationType::long_type(), CHECK_VERIFY(this));
duke@435 1367 current_frame.push_stack(
duke@435 1368 VerificationType::float_type(), CHECK_VERIFY(this));
duke@435 1369 no_control_flow = false; break;
duke@435 1370 case Bytecodes::_l2d :
duke@435 1371 current_frame.pop_stack_2(
duke@435 1372 VerificationType::long2_type(),
duke@435 1373 VerificationType::long_type(), CHECK_VERIFY(this));
duke@435 1374 current_frame.push_stack_2(
duke@435 1375 VerificationType::double_type(),
duke@435 1376 VerificationType::double2_type(), CHECK_VERIFY(this));
duke@435 1377 no_control_flow = false; break;
duke@435 1378 case Bytecodes::_f2i :
duke@435 1379 current_frame.pop_stack(
duke@435 1380 VerificationType::float_type(), CHECK_VERIFY(this));
duke@435 1381 current_frame.push_stack(
duke@435 1382 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 1383 no_control_flow = false; break;
duke@435 1384 case Bytecodes::_f2l :
duke@435 1385 current_frame.pop_stack(
duke@435 1386 VerificationType::float_type(), CHECK_VERIFY(this));
duke@435 1387 current_frame.push_stack_2(
duke@435 1388 VerificationType::long_type(),
duke@435 1389 VerificationType::long2_type(), CHECK_VERIFY(this));
duke@435 1390 no_control_flow = false; break;
duke@435 1391 case Bytecodes::_f2d :
duke@435 1392 current_frame.pop_stack(
duke@435 1393 VerificationType::float_type(), CHECK_VERIFY(this));
duke@435 1394 current_frame.push_stack_2(
duke@435 1395 VerificationType::double_type(),
duke@435 1396 VerificationType::double2_type(), CHECK_VERIFY(this));
duke@435 1397 no_control_flow = false; break;
duke@435 1398 case Bytecodes::_d2i :
duke@435 1399 current_frame.pop_stack_2(
duke@435 1400 VerificationType::double2_type(),
duke@435 1401 VerificationType::double_type(), CHECK_VERIFY(this));
duke@435 1402 current_frame.push_stack(
duke@435 1403 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 1404 no_control_flow = false; break;
duke@435 1405 case Bytecodes::_d2l :
duke@435 1406 current_frame.pop_stack_2(
duke@435 1407 VerificationType::double2_type(),
duke@435 1408 VerificationType::double_type(), CHECK_VERIFY(this));
duke@435 1409 current_frame.push_stack_2(
duke@435 1410 VerificationType::long_type(),
duke@435 1411 VerificationType::long2_type(), CHECK_VERIFY(this));
duke@435 1412 no_control_flow = false; break;
duke@435 1413 case Bytecodes::_d2f :
duke@435 1414 current_frame.pop_stack_2(
duke@435 1415 VerificationType::double2_type(),
duke@435 1416 VerificationType::double_type(), CHECK_VERIFY(this));
duke@435 1417 current_frame.push_stack(
duke@435 1418 VerificationType::float_type(), CHECK_VERIFY(this));
duke@435 1419 no_control_flow = false; break;
duke@435 1420 case Bytecodes::_i2b :
duke@435 1421 case Bytecodes::_i2c :
duke@435 1422 case Bytecodes::_i2s :
duke@435 1423 current_frame.pop_stack(
duke@435 1424 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 1425 current_frame.push_stack(
duke@435 1426 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 1427 no_control_flow = false; break;
duke@435 1428 case Bytecodes::_lcmp :
duke@435 1429 current_frame.pop_stack_2(
duke@435 1430 VerificationType::long2_type(),
duke@435 1431 VerificationType::long_type(), CHECK_VERIFY(this));
duke@435 1432 current_frame.pop_stack_2(
duke@435 1433 VerificationType::long2_type(),
duke@435 1434 VerificationType::long_type(), CHECK_VERIFY(this));
duke@435 1435 current_frame.push_stack(
duke@435 1436 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 1437 no_control_flow = false; break;
duke@435 1438 case Bytecodes::_fcmpl :
duke@435 1439 case Bytecodes::_fcmpg :
duke@435 1440 current_frame.pop_stack(
duke@435 1441 VerificationType::float_type(), CHECK_VERIFY(this));
duke@435 1442 current_frame.pop_stack(
duke@435 1443 VerificationType::float_type(), CHECK_VERIFY(this));
duke@435 1444 current_frame.push_stack(
duke@435 1445 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 1446 no_control_flow = false; break;
duke@435 1447 case Bytecodes::_dcmpl :
duke@435 1448 case Bytecodes::_dcmpg :
duke@435 1449 current_frame.pop_stack_2(
duke@435 1450 VerificationType::double2_type(),
duke@435 1451 VerificationType::double_type(), CHECK_VERIFY(this));
duke@435 1452 current_frame.pop_stack_2(
duke@435 1453 VerificationType::double2_type(),
duke@435 1454 VerificationType::double_type(), CHECK_VERIFY(this));
duke@435 1455 current_frame.push_stack(
duke@435 1456 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 1457 no_control_flow = false; break;
duke@435 1458 case Bytecodes::_if_icmpeq:
duke@435 1459 case Bytecodes::_if_icmpne:
duke@435 1460 case Bytecodes::_if_icmplt:
duke@435 1461 case Bytecodes::_if_icmpge:
duke@435 1462 case Bytecodes::_if_icmpgt:
duke@435 1463 case Bytecodes::_if_icmple:
duke@435 1464 current_frame.pop_stack(
duke@435 1465 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 1466 // fall through
duke@435 1467 case Bytecodes::_ifeq:
duke@435 1468 case Bytecodes::_ifne:
duke@435 1469 case Bytecodes::_iflt:
duke@435 1470 case Bytecodes::_ifge:
duke@435 1471 case Bytecodes::_ifgt:
duke@435 1472 case Bytecodes::_ifle:
duke@435 1473 current_frame.pop_stack(
duke@435 1474 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 1475 target = bcs.dest();
duke@435 1476 stackmap_table.check_jump_target(
duke@435 1477 &current_frame, target, CHECK_VERIFY(this));
duke@435 1478 no_control_flow = false; break;
duke@435 1479 case Bytecodes::_if_acmpeq :
duke@435 1480 case Bytecodes::_if_acmpne :
duke@435 1481 current_frame.pop_stack(
duke@435 1482 VerificationType::reference_check(), CHECK_VERIFY(this));
duke@435 1483 // fall through
duke@435 1484 case Bytecodes::_ifnull :
duke@435 1485 case Bytecodes::_ifnonnull :
duke@435 1486 current_frame.pop_stack(
duke@435 1487 VerificationType::reference_check(), CHECK_VERIFY(this));
duke@435 1488 target = bcs.dest();
duke@435 1489 stackmap_table.check_jump_target
duke@435 1490 (&current_frame, target, CHECK_VERIFY(this));
duke@435 1491 no_control_flow = false; break;
duke@435 1492 case Bytecodes::_goto :
duke@435 1493 target = bcs.dest();
duke@435 1494 stackmap_table.check_jump_target(
duke@435 1495 &current_frame, target, CHECK_VERIFY(this));
duke@435 1496 no_control_flow = true; break;
duke@435 1497 case Bytecodes::_goto_w :
duke@435 1498 target = bcs.dest_w();
duke@435 1499 stackmap_table.check_jump_target(
duke@435 1500 &current_frame, target, CHECK_VERIFY(this));
duke@435 1501 no_control_flow = true; break;
duke@435 1502 case Bytecodes::_tableswitch :
duke@435 1503 case Bytecodes::_lookupswitch :
duke@435 1504 verify_switch(
duke@435 1505 &bcs, code_length, code_data, &current_frame,
duke@435 1506 &stackmap_table, CHECK_VERIFY(this));
duke@435 1507 no_control_flow = true; break;
duke@435 1508 case Bytecodes::_ireturn :
duke@435 1509 type = current_frame.pop_stack(
duke@435 1510 VerificationType::integer_type(), CHECK_VERIFY(this));
kamg@3992 1511 verify_return_value(return_type, type, bci,
kamg@3992 1512 &current_frame, CHECK_VERIFY(this));
duke@435 1513 no_control_flow = true; break;
duke@435 1514 case Bytecodes::_lreturn :
duke@435 1515 type2 = current_frame.pop_stack(
duke@435 1516 VerificationType::long2_type(), CHECK_VERIFY(this));
duke@435 1517 type = current_frame.pop_stack(
duke@435 1518 VerificationType::long_type(), CHECK_VERIFY(this));
kamg@3992 1519 verify_return_value(return_type, type, bci,
kamg@3992 1520 &current_frame, CHECK_VERIFY(this));
duke@435 1521 no_control_flow = true; break;
duke@435 1522 case Bytecodes::_freturn :
duke@435 1523 type = current_frame.pop_stack(
duke@435 1524 VerificationType::float_type(), CHECK_VERIFY(this));
kamg@3992 1525 verify_return_value(return_type, type, bci,
kamg@3992 1526 &current_frame, CHECK_VERIFY(this));
duke@435 1527 no_control_flow = true; break;
duke@435 1528 case Bytecodes::_dreturn :
duke@435 1529 type2 = current_frame.pop_stack(
duke@435 1530 VerificationType::double2_type(), CHECK_VERIFY(this));
duke@435 1531 type = current_frame.pop_stack(
duke@435 1532 VerificationType::double_type(), CHECK_VERIFY(this));
kamg@3992 1533 verify_return_value(return_type, type, bci,
kamg@3992 1534 &current_frame, CHECK_VERIFY(this));
duke@435 1535 no_control_flow = true; break;
duke@435 1536 case Bytecodes::_areturn :
duke@435 1537 type = current_frame.pop_stack(
duke@435 1538 VerificationType::reference_check(), CHECK_VERIFY(this));
kamg@3992 1539 verify_return_value(return_type, type, bci,
kamg@3992 1540 &current_frame, CHECK_VERIFY(this));
duke@435 1541 no_control_flow = true; break;
duke@435 1542 case Bytecodes::_return :
duke@435 1543 if (return_type != VerificationType::bogus_type()) {
kamg@3992 1544 verify_error(ErrorContext::bad_code(bci),
kamg@3992 1545 "Method expects a return value");
duke@435 1546 return;
duke@435 1547 }
duke@435 1548 // Make sure "this" has been initialized if current method is an
duke@435 1549 // <init>
duke@435 1550 if (_method->name() == vmSymbols::object_initializer_name() &&
duke@435 1551 current_frame.flag_this_uninit()) {
kamg@3992 1552 verify_error(ErrorContext::bad_code(bci),
kamg@3992 1553 "Constructor must call super() or this() "
kamg@3992 1554 "before return");
duke@435 1555 return;
duke@435 1556 }
duke@435 1557 no_control_flow = true; break;
duke@435 1558 case Bytecodes::_getstatic :
duke@435 1559 case Bytecodes::_putstatic :
duke@435 1560 case Bytecodes::_getfield :
duke@435 1561 case Bytecodes::_putfield :
duke@435 1562 verify_field_instructions(
duke@435 1563 &bcs, &current_frame, cp, CHECK_VERIFY(this));
duke@435 1564 no_control_flow = false; break;
duke@435 1565 case Bytecodes::_invokevirtual :
duke@435 1566 case Bytecodes::_invokespecial :
duke@435 1567 case Bytecodes::_invokestatic :
duke@435 1568 verify_invoke_instructions(
hseigel@7473 1569 &bcs, code_length, &current_frame, (bci >= ex_min && bci < ex_max),
hseigel@7473 1570 &this_uninit, return_type, cp, &stackmap_table, CHECK_VERIFY(this));
duke@435 1571 no_control_flow = false; break;
duke@435 1572 case Bytecodes::_invokeinterface :
jrose@1161 1573 case Bytecodes::_invokedynamic :
duke@435 1574 verify_invoke_instructions(
hseigel@7473 1575 &bcs, code_length, &current_frame, (bci >= ex_min && bci < ex_max),
hseigel@7473 1576 &this_uninit, return_type, cp, &stackmap_table, CHECK_VERIFY(this));
duke@435 1577 no_control_flow = false; break;
duke@435 1578 case Bytecodes::_new :
duke@435 1579 {
jrose@1920 1580 index = bcs.get_index_u2();
kamg@3992 1581 verify_cp_class_type(bci, index, cp, CHECK_VERIFY(this));
duke@435 1582 VerificationType new_class_type =
duke@435 1583 cp_index_to_type(index, cp, CHECK_VERIFY(this));
duke@435 1584 if (!new_class_type.is_object()) {
kamg@3992 1585 verify_error(ErrorContext::bad_type(bci,
kamg@3992 1586 TypeOrigin::cp(index, new_class_type)),
kamg@3992 1587 "Illegal new instruction");
duke@435 1588 return;
duke@435 1589 }
duke@435 1590 type = VerificationType::uninitialized_type(bci);
duke@435 1591 current_frame.push_stack(type, CHECK_VERIFY(this));
duke@435 1592 no_control_flow = false; break;
duke@435 1593 }
duke@435 1594 case Bytecodes::_newarray :
duke@435 1595 type = get_newarray_type(bcs.get_index(), bci, CHECK_VERIFY(this));
duke@435 1596 current_frame.pop_stack(
duke@435 1597 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 1598 current_frame.push_stack(type, CHECK_VERIFY(this));
duke@435 1599 no_control_flow = false; break;
duke@435 1600 case Bytecodes::_anewarray :
duke@435 1601 verify_anewarray(
kamg@3992 1602 bci, bcs.get_index_u2(), cp, &current_frame, CHECK_VERIFY(this));
duke@435 1603 no_control_flow = false; break;
duke@435 1604 case Bytecodes::_arraylength :
duke@435 1605 type = current_frame.pop_stack(
duke@435 1606 VerificationType::reference_check(), CHECK_VERIFY(this));
kamg@569 1607 if (!(type.is_null() || type.is_array())) {
kamg@3992 1608 verify_error(ErrorContext::bad_type(
kamg@3992 1609 bci, current_frame.stack_top_ctx()),
kamg@3992 1610 bad_type_msg, "arraylength");
duke@435 1611 }
duke@435 1612 current_frame.push_stack(
duke@435 1613 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 1614 no_control_flow = false; break;
duke@435 1615 case Bytecodes::_checkcast :
duke@435 1616 {
jrose@1920 1617 index = bcs.get_index_u2();
kamg@3992 1618 verify_cp_class_type(bci, index, cp, CHECK_VERIFY(this));
kamg@2297 1619 current_frame.pop_stack(object_type(), CHECK_VERIFY(this));
duke@435 1620 VerificationType klass_type = cp_index_to_type(
duke@435 1621 index, cp, CHECK_VERIFY(this));
duke@435 1622 current_frame.push_stack(klass_type, CHECK_VERIFY(this));
duke@435 1623 no_control_flow = false; break;
duke@435 1624 }
duke@435 1625 case Bytecodes::_instanceof : {
jrose@1920 1626 index = bcs.get_index_u2();
kamg@3992 1627 verify_cp_class_type(bci, index, cp, CHECK_VERIFY(this));
kamg@2297 1628 current_frame.pop_stack(object_type(), CHECK_VERIFY(this));
duke@435 1629 current_frame.push_stack(
duke@435 1630 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 1631 no_control_flow = false; break;
duke@435 1632 }
duke@435 1633 case Bytecodes::_monitorenter :
duke@435 1634 case Bytecodes::_monitorexit :
duke@435 1635 current_frame.pop_stack(
duke@435 1636 VerificationType::reference_check(), CHECK_VERIFY(this));
duke@435 1637 no_control_flow = false; break;
duke@435 1638 case Bytecodes::_multianewarray :
duke@435 1639 {
jrose@1920 1640 index = bcs.get_index_u2();
duke@435 1641 u2 dim = *(bcs.bcp()+3);
kamg@3992 1642 verify_cp_class_type(bci, index, cp, CHECK_VERIFY(this));
duke@435 1643 VerificationType new_array_type =
duke@435 1644 cp_index_to_type(index, cp, CHECK_VERIFY(this));
duke@435 1645 if (!new_array_type.is_array()) {
kamg@3992 1646 verify_error(ErrorContext::bad_type(bci,
kamg@3992 1647 TypeOrigin::cp(index, new_array_type)),
kamg@3992 1648 "Illegal constant pool index in multianewarray instruction");
duke@435 1649 return;
duke@435 1650 }
duke@435 1651 if (dim < 1 || new_array_type.dimensions() < dim) {
kamg@3992 1652 verify_error(ErrorContext::bad_code(bci),
kamg@3992 1653 "Illegal dimension in multianewarray instruction: %d", dim);
duke@435 1654 return;
duke@435 1655 }
duke@435 1656 for (int i = 0; i < dim; i++) {
duke@435 1657 current_frame.pop_stack(
duke@435 1658 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 1659 }
duke@435 1660 current_frame.push_stack(new_array_type, CHECK_VERIFY(this));
duke@435 1661 no_control_flow = false; break;
duke@435 1662 }
duke@435 1663 case Bytecodes::_athrow :
duke@435 1664 type = VerificationType::reference_type(
duke@435 1665 vmSymbols::java_lang_Throwable());
duke@435 1666 current_frame.pop_stack(type, CHECK_VERIFY(this));
duke@435 1667 no_control_flow = true; break;
duke@435 1668 default:
duke@435 1669 // We only need to check the valid bytecodes in class file.
duke@435 1670 // And jsr and ret are not in the new class file format in JDK1.5.
kamg@3992 1671 verify_error(ErrorContext::bad_code(bci),
kamg@3992 1672 "Bad instruction: %02x", opcode);
duke@435 1673 no_control_flow = false;
duke@435 1674 return;
duke@435 1675 } // end switch
duke@435 1676 } // end Merge with the next instruction
duke@435 1677
hseigel@7666 1678 // Look for possible jump target in exception handlers and see if it matches
hseigel@7666 1679 // current_frame. Don't do this check if it has already been done (for
hseigel@7666 1680 // ([a,d,f,i,l]store* opcodes). This check cannot be done earlier because
hseigel@7666 1681 // opcodes, such as invokespecial, may set the this_uninit flag.
hseigel@7666 1682 assert(!(verified_exc_handlers && this_uninit),
hseigel@7666 1683 "Exception handler targets got verified before this_uninit got set");
hseigel@7666 1684 if (!verified_exc_handlers && bci >= ex_min && bci < ex_max) {
duke@435 1685 verify_exception_handler_targets(
duke@435 1686 bci, this_uninit, &current_frame, &stackmap_table, CHECK_VERIFY(this));
duke@435 1687 }
duke@435 1688 } // end while
duke@435 1689
duke@435 1690 // Make sure that control flow does not fall through end of the method
duke@435 1691 if (!no_control_flow) {
kamg@3992 1692 verify_error(ErrorContext::bad_code(code_length),
kamg@3992 1693 "Control flow falls through code end");
duke@435 1694 return;
duke@435 1695 }
duke@435 1696 }
duke@435 1697
drchase@6680 1698 #undef bad_type_message
drchase@6680 1699
duke@435 1700 char* ClassVerifier::generate_code_data(methodHandle m, u4 code_length, TRAPS) {
duke@435 1701 char* code_data = NEW_RESOURCE_ARRAY(char, code_length);
duke@435 1702 memset(code_data, 0, sizeof(char) * code_length);
duke@435 1703 RawBytecodeStream bcs(m);
duke@435 1704
duke@435 1705 while (!bcs.is_last_bytecode()) {
duke@435 1706 if (bcs.raw_next() != Bytecodes::_illegal) {
duke@435 1707 int bci = bcs.bci();
jrose@1920 1708 if (bcs.raw_code() == Bytecodes::_new) {
duke@435 1709 code_data[bci] = NEW_OFFSET;
duke@435 1710 } else {
duke@435 1711 code_data[bci] = BYTECODE_OFFSET;
duke@435 1712 }
duke@435 1713 } else {
kamg@3992 1714 verify_error(ErrorContext::bad_code(bcs.bci()), "Bad instruction");
duke@435 1715 return NULL;
duke@435 1716 }
duke@435 1717 }
duke@435 1718
duke@435 1719 return code_data;
duke@435 1720 }
duke@435 1721
duke@435 1722 void ClassVerifier::verify_exception_handler_table(u4 code_length, char* code_data, int& min, int& max, TRAPS) {
jiangli@3917 1723 ExceptionTable exhandlers(_method());
jiangli@3917 1724 int exlength = exhandlers.length();
duke@435 1725 constantPoolHandle cp (THREAD, _method->constants());
duke@435 1726
jiangli@3917 1727 for(int i = 0; i < exlength; i++) {
jiangli@3917 1728 //reacquire the table in case a GC happened
jiangli@3917 1729 ExceptionTable exhandlers(_method());
jiangli@3917 1730 u2 start_pc = exhandlers.start_pc(i);
jiangli@3917 1731 u2 end_pc = exhandlers.end_pc(i);
jiangli@3917 1732 u2 handler_pc = exhandlers.handler_pc(i);
jiangli@3917 1733 if (start_pc >= code_length || code_data[start_pc] == 0) {
jiangli@3917 1734 class_format_error("Illegal exception table start_pc %d", start_pc);
jiangli@3917 1735 return;
jiangli@3917 1736 }
jiangli@3917 1737 if (end_pc != code_length) { // special case: end_pc == code_length
jiangli@3917 1738 if (end_pc > code_length || code_data[end_pc] == 0) {
jiangli@3917 1739 class_format_error("Illegal exception table end_pc %d", end_pc);
duke@435 1740 return;
duke@435 1741 }
jiangli@3917 1742 }
jiangli@3917 1743 if (handler_pc >= code_length || code_data[handler_pc] == 0) {
jiangli@3917 1744 class_format_error("Illegal exception table handler_pc %d", handler_pc);
jiangli@3917 1745 return;
jiangli@3917 1746 }
jiangli@3917 1747 int catch_type_index = exhandlers.catch_type_index(i);
jiangli@3917 1748 if (catch_type_index != 0) {
jiangli@3917 1749 VerificationType catch_type = cp_index_to_type(
jiangli@3917 1750 catch_type_index, cp, CHECK_VERIFY(this));
jiangli@3917 1751 VerificationType throwable =
jiangli@3917 1752 VerificationType::reference_type(vmSymbols::java_lang_Throwable());
jiangli@3917 1753 bool is_subclass = throwable.is_assignable_from(
hseigel@6824 1754 catch_type, this, false, CHECK_VERIFY(this));
jiangli@3917 1755 if (!is_subclass) {
jiangli@3917 1756 // 4286534: should throw VerifyError according to recent spec change
kamg@3992 1757 verify_error(ErrorContext::bad_type(handler_pc,
kamg@3992 1758 TypeOrigin::cp(catch_type_index, catch_type),
kamg@3992 1759 TypeOrigin::implicit(throwable)),
kamg@3992 1760 "Catch type is not a subclass "
kamg@3992 1761 "of Throwable in exception handler %d", handler_pc);
duke@435 1762 return;
duke@435 1763 }
duke@435 1764 }
jiangli@3917 1765 if (start_pc < min) min = start_pc;
jiangli@3917 1766 if (end_pc > max) max = end_pc;
duke@435 1767 }
duke@435 1768 }
duke@435 1769
duke@435 1770 void ClassVerifier::verify_local_variable_table(u4 code_length, char* code_data, TRAPS) {
duke@435 1771 int localvariable_table_length = _method()->localvariable_table_length();
duke@435 1772 if (localvariable_table_length > 0) {
duke@435 1773 LocalVariableTableElement* table = _method()->localvariable_table_start();
duke@435 1774 for (int i = 0; i < localvariable_table_length; i++) {
duke@435 1775 u2 start_bci = table[i].start_bci;
duke@435 1776 u2 length = table[i].length;
duke@435 1777
duke@435 1778 if (start_bci >= code_length || code_data[start_bci] == 0) {
duke@435 1779 class_format_error(
duke@435 1780 "Illegal local variable table start_pc %d", start_bci);
duke@435 1781 return;
duke@435 1782 }
duke@435 1783 u4 end_bci = (u4)(start_bci + length);
duke@435 1784 if (end_bci != code_length) {
duke@435 1785 if (end_bci >= code_length || code_data[end_bci] == 0) {
duke@435 1786 class_format_error( "Illegal local variable table length %d", length);
duke@435 1787 return;
duke@435 1788 }
duke@435 1789 }
duke@435 1790 }
duke@435 1791 }
duke@435 1792 }
duke@435 1793
duke@435 1794 u2 ClassVerifier::verify_stackmap_table(u2 stackmap_index, u2 bci,
duke@435 1795 StackMapFrame* current_frame,
duke@435 1796 StackMapTable* stackmap_table,
duke@435 1797 bool no_control_flow, TRAPS) {
duke@435 1798 if (stackmap_index < stackmap_table->get_frame_count()) {
duke@435 1799 u2 this_offset = stackmap_table->get_offset(stackmap_index);
duke@435 1800 if (no_control_flow && this_offset > bci) {
kamg@3992 1801 verify_error(ErrorContext::missing_stackmap(bci),
kamg@3992 1802 "Expecting a stack map frame");
duke@435 1803 return 0;
duke@435 1804 }
duke@435 1805 if (this_offset == bci) {
kamg@3992 1806 ErrorContext ctx;
duke@435 1807 // See if current stack map can be assigned to the frame in table.
duke@435 1808 // current_frame is the stackmap frame got from the last instruction.
duke@435 1809 // If matched, current_frame will be updated by this method.
kamg@3992 1810 bool matches = stackmap_table->match_stackmap(
duke@435 1811 current_frame, this_offset, stackmap_index,
hseigel@7454 1812 !no_control_flow, true, false, &ctx, CHECK_VERIFY_(this, 0));
kamg@3992 1813 if (!matches) {
duke@435 1814 // report type error
kamg@3992 1815 verify_error(ctx, "Instruction type does not match stack map");
duke@435 1816 return 0;
duke@435 1817 }
duke@435 1818 stackmap_index++;
duke@435 1819 } else if (this_offset < bci) {
duke@435 1820 // current_offset should have met this_offset.
duke@435 1821 class_format_error("Bad stack map offset %d", this_offset);
duke@435 1822 return 0;
duke@435 1823 }
duke@435 1824 } else if (no_control_flow) {
kamg@3992 1825 verify_error(ErrorContext::bad_code(bci), "Expecting a stack map frame");
duke@435 1826 return 0;
duke@435 1827 }
duke@435 1828 return stackmap_index;
duke@435 1829 }
duke@435 1830
duke@435 1831 void ClassVerifier::verify_exception_handler_targets(u2 bci, bool this_uninit, StackMapFrame* current_frame,
duke@435 1832 StackMapTable* stackmap_table, TRAPS) {
duke@435 1833 constantPoolHandle cp (THREAD, _method->constants());
jiangli@3917 1834 ExceptionTable exhandlers(_method());
jiangli@3917 1835 int exlength = exhandlers.length();
jiangli@3917 1836 for(int i = 0; i < exlength; i++) {
jiangli@3917 1837 //reacquire the table in case a GC happened
jiangli@3917 1838 ExceptionTable exhandlers(_method());
jiangli@3917 1839 u2 start_pc = exhandlers.start_pc(i);
jiangli@3917 1840 u2 end_pc = exhandlers.end_pc(i);
jiangli@3917 1841 u2 handler_pc = exhandlers.handler_pc(i);
jiangli@3917 1842 int catch_type_index = exhandlers.catch_type_index(i);
jiangli@3917 1843 if(bci >= start_pc && bci < end_pc) {
jiangli@3917 1844 u1 flags = current_frame->flags();
jiangli@3917 1845 if (this_uninit) { flags |= FLAG_THIS_UNINIT; }
jiangli@3917 1846 StackMapFrame* new_frame = current_frame->frame_in_exception_handler(flags);
jiangli@3917 1847 if (catch_type_index != 0) {
jiangli@3917 1848 // We know that this index refers to a subclass of Throwable
jiangli@3917 1849 VerificationType catch_type = cp_index_to_type(
jiangli@3917 1850 catch_type_index, cp, CHECK_VERIFY(this));
jiangli@3917 1851 new_frame->push_stack(catch_type, CHECK_VERIFY(this));
jiangli@3917 1852 } else {
jiangli@3917 1853 VerificationType throwable =
jiangli@3917 1854 VerificationType::reference_type(vmSymbols::java_lang_Throwable());
jiangli@3917 1855 new_frame->push_stack(throwable, CHECK_VERIFY(this));
jiangli@3917 1856 }
kamg@3992 1857 ErrorContext ctx;
kamg@3992 1858 bool matches = stackmap_table->match_stackmap(
hseigel@7454 1859 new_frame, handler_pc, true, false, true, &ctx, CHECK_VERIFY(this));
kamg@3992 1860 if (!matches) {
kamg@3992 1861 verify_error(ctx, "Stack map does not match the one at "
kamg@3992 1862 "exception handler %d", handler_pc);
jiangli@3917 1863 return;
duke@435 1864 }
duke@435 1865 }
duke@435 1866 }
duke@435 1867 }
duke@435 1868
kamg@3992 1869 void ClassVerifier::verify_cp_index(
kamg@3992 1870 u2 bci, constantPoolHandle cp, int index, TRAPS) {
duke@435 1871 int nconstants = cp->length();
duke@435 1872 if ((index <= 0) || (index >= nconstants)) {
kamg@3992 1873 verify_error(ErrorContext::bad_cp_index(bci, index),
kamg@3992 1874 "Illegal constant pool index %d in class %s",
coleenp@4251 1875 index, cp->pool_holder()->external_name());
duke@435 1876 return;
duke@435 1877 }
duke@435 1878 }
duke@435 1879
duke@435 1880 void ClassVerifier::verify_cp_type(
kamg@3992 1881 u2 bci, int index, constantPoolHandle cp, unsigned int types, TRAPS) {
duke@435 1882
duke@435 1883 // In some situations, bytecode rewriting may occur while we're verifying.
duke@435 1884 // In this case, a constant pool cache exists and some indices refer to that
jrose@1925 1885 // instead. Be sure we don't pick up such indices by accident.
jrose@1925 1886 // We must check was_recursively_verified() before we get here.
jrose@1925 1887 guarantee(cp->cache() == NULL, "not rewritten yet");
duke@435 1888
kamg@3992 1889 verify_cp_index(bci, cp, index, CHECK_VERIFY(this));
duke@435 1890 unsigned int tag = cp->tag_at(index).value();
duke@435 1891 if ((types & (1 << tag)) == 0) {
kamg@3992 1892 verify_error(ErrorContext::bad_cp_index(bci, index),
duke@435 1893 "Illegal type at constant pool entry %d in class %s",
coleenp@4251 1894 index, cp->pool_holder()->external_name());
duke@435 1895 return;
duke@435 1896 }
duke@435 1897 }
duke@435 1898
duke@435 1899 void ClassVerifier::verify_cp_class_type(
kamg@3992 1900 u2 bci, int index, constantPoolHandle cp, TRAPS) {
kamg@3992 1901 verify_cp_index(bci, cp, index, CHECK_VERIFY(this));
duke@435 1902 constantTag tag = cp->tag_at(index);
duke@435 1903 if (!tag.is_klass() && !tag.is_unresolved_klass()) {
kamg@3992 1904 verify_error(ErrorContext::bad_cp_index(bci, index),
kamg@3992 1905 "Illegal type at constant pool entry %d in class %s",
coleenp@4251 1906 index, cp->pool_holder()->external_name());
duke@435 1907 return;
duke@435 1908 }
duke@435 1909 }
duke@435 1910
kamg@3992 1911 void ClassVerifier::verify_error(ErrorContext ctx, const char* msg, ...) {
kamg@3992 1912 stringStream ss;
duke@435 1913
kamg@3992 1914 ctx.reset_frames();
duke@435 1915 _exception_type = vmSymbols::java_lang_VerifyError();
kamg@3992 1916 _error_context = ctx;
duke@435 1917 va_list va;
kamg@3992 1918 va_start(va, msg);
kamg@3992 1919 ss.vprint(msg, va);
duke@435 1920 va_end(va);
kamg@3992 1921 _message = ss.as_string();
kamg@3992 1922 #ifdef ASSERT
kamg@3992 1923 ResourceMark rm;
kamg@3992 1924 const char* exception_name = _exception_type->as_C_string();
kamg@3992 1925 Exceptions::debug_check_abort(exception_name, NULL);
kamg@3992 1926 #endif // ndef ASSERT
duke@435 1927 }
duke@435 1928
duke@435 1929 void ClassVerifier::class_format_error(const char* msg, ...) {
kamg@3992 1930 stringStream ss;
duke@435 1931 _exception_type = vmSymbols::java_lang_ClassFormatError();
duke@435 1932 va_list va;
duke@435 1933 va_start(va, msg);
kamg@3992 1934 ss.vprint(msg, va);
duke@435 1935 va_end(va);
kamg@3992 1936 if (!_method.is_null()) {
kamg@3992 1937 ss.print(" in method %s", _method->name_and_sig_as_C_string());
kamg@3992 1938 }
kamg@3992 1939 _message = ss.as_string();
duke@435 1940 }
duke@435 1941
coleenp@4037 1942 Klass* ClassVerifier::load_class(Symbol* name, TRAPS) {
duke@435 1943 // Get current loader and protection domain first.
duke@435 1944 oop loader = current_class()->class_loader();
duke@435 1945 oop protection_domain = current_class()->protection_domain();
duke@435 1946
duke@435 1947 return SystemDictionary::resolve_or_fail(
duke@435 1948 name, Handle(THREAD, loader), Handle(THREAD, protection_domain),
duke@435 1949 true, CHECK_NULL);
duke@435 1950 }
duke@435 1951
duke@435 1952 bool ClassVerifier::is_protected_access(instanceKlassHandle this_class,
coleenp@4037 1953 Klass* target_class,
coleenp@2497 1954 Symbol* field_name,
coleenp@2497 1955 Symbol* field_sig,
duke@435 1956 bool is_method) {
duke@435 1957 No_Safepoint_Verifier nosafepoint;
duke@435 1958
duke@435 1959 // If target class isn't a super class of this class, we don't worry about this case
duke@435 1960 if (!this_class->is_subclass_of(target_class)) {
duke@435 1961 return false;
duke@435 1962 }
duke@435 1963 // Check if the specified method or field is protected
coleenp@4037 1964 InstanceKlass* target_instance = InstanceKlass::cast(target_class);
duke@435 1965 fieldDescriptor fd;
duke@435 1966 if (is_method) {
lfoltan@6632 1967 Method* m = target_instance->uncached_lookup_method(field_name, field_sig, Klass::normal);
duke@435 1968 if (m != NULL && m->is_protected()) {
duke@435 1969 if (!this_class->is_same_class_package(m->method_holder())) {
duke@435 1970 return true;
duke@435 1971 }
duke@435 1972 }
duke@435 1973 } else {
coleenp@4037 1974 Klass* member_klass = target_instance->find_field(field_name, field_sig, &fd);
kamg@3992 1975 if (member_klass != NULL && fd.is_protected()) {
duke@435 1976 if (!this_class->is_same_class_package(member_klass)) {
duke@435 1977 return true;
duke@435 1978 }
duke@435 1979 }
duke@435 1980 }
duke@435 1981 return false;
duke@435 1982 }
duke@435 1983
duke@435 1984 void ClassVerifier::verify_ldc(
kamg@3992 1985 int opcode, u2 index, StackMapFrame* current_frame,
kamg@3992 1986 constantPoolHandle cp, u2 bci, TRAPS) {
kamg@3992 1987 verify_cp_index(bci, cp, index, CHECK_VERIFY(this));
duke@435 1988 constantTag tag = cp->tag_at(index);
duke@435 1989 unsigned int types;
duke@435 1990 if (opcode == Bytecodes::_ldc || opcode == Bytecodes::_ldc_w) {
coleenp@4037 1991 if (!tag.is_unresolved_klass()) {
duke@435 1992 types = (1 << JVM_CONSTANT_Integer) | (1 << JVM_CONSTANT_Float)
jrose@1957 1993 | (1 << JVM_CONSTANT_String) | (1 << JVM_CONSTANT_Class)
jrose@1957 1994 | (1 << JVM_CONSTANT_MethodHandle) | (1 << JVM_CONSTANT_MethodType);
jrose@1957 1995 // Note: The class file parser already verified the legality of
jrose@1957 1996 // MethodHandle and MethodType constants.
kamg@3992 1997 verify_cp_type(bci, index, cp, types, CHECK_VERIFY(this));
duke@435 1998 }
duke@435 1999 } else {
duke@435 2000 assert(opcode == Bytecodes::_ldc2_w, "must be ldc2_w");
duke@435 2001 types = (1 << JVM_CONSTANT_Double) | (1 << JVM_CONSTANT_Long);
kamg@3992 2002 verify_cp_type(bci, index, cp, types, CHECK_VERIFY(this));
duke@435 2003 }
jrose@866 2004 if (tag.is_string() && cp->is_pseudo_string_at(index)) {
kamg@2297 2005 current_frame->push_stack(object_type(), CHECK_VERIFY(this));
coleenp@4037 2006 } else if (tag.is_string()) {
duke@435 2007 current_frame->push_stack(
duke@435 2008 VerificationType::reference_type(
duke@435 2009 vmSymbols::java_lang_String()), CHECK_VERIFY(this));
duke@435 2010 } else if (tag.is_klass() || tag.is_unresolved_klass()) {
duke@435 2011 current_frame->push_stack(
duke@435 2012 VerificationType::reference_type(
duke@435 2013 vmSymbols::java_lang_Class()), CHECK_VERIFY(this));
duke@435 2014 } else if (tag.is_int()) {
duke@435 2015 current_frame->push_stack(
duke@435 2016 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 2017 } else if (tag.is_float()) {
duke@435 2018 current_frame->push_stack(
duke@435 2019 VerificationType::float_type(), CHECK_VERIFY(this));
duke@435 2020 } else if (tag.is_double()) {
duke@435 2021 current_frame->push_stack_2(
duke@435 2022 VerificationType::double_type(),
duke@435 2023 VerificationType::double2_type(), CHECK_VERIFY(this));
duke@435 2024 } else if (tag.is_long()) {
duke@435 2025 current_frame->push_stack_2(
duke@435 2026 VerificationType::long_type(),
duke@435 2027 VerificationType::long2_type(), CHECK_VERIFY(this));
jrose@1957 2028 } else if (tag.is_method_handle()) {
jrose@1957 2029 current_frame->push_stack(
jrose@1957 2030 VerificationType::reference_type(
jrose@2742 2031 vmSymbols::java_lang_invoke_MethodHandle()), CHECK_VERIFY(this));
jrose@1957 2032 } else if (tag.is_method_type()) {
jrose@1957 2033 current_frame->push_stack(
jrose@1957 2034 VerificationType::reference_type(
jrose@2742 2035 vmSymbols::java_lang_invoke_MethodType()), CHECK_VERIFY(this));
duke@435 2036 } else {
kamg@3992 2037 /* Unreachable? verify_cp_type has already validated the cp type. */
kamg@3992 2038 verify_error(
kamg@3992 2039 ErrorContext::bad_cp_index(bci, index), "Invalid index in ldc");
duke@435 2040 return;
duke@435 2041 }
duke@435 2042 }
duke@435 2043
duke@435 2044 void ClassVerifier::verify_switch(
duke@435 2045 RawBytecodeStream* bcs, u4 code_length, char* code_data,
duke@435 2046 StackMapFrame* current_frame, StackMapTable* stackmap_table, TRAPS) {
duke@435 2047 int bci = bcs->bci();
duke@435 2048 address bcp = bcs->bcp();
duke@435 2049 address aligned_bcp = (address) round_to((intptr_t)(bcp + 1), jintSize);
duke@435 2050
hseigel@4816 2051 if (_klass->major_version() < NONZERO_PADDING_BYTES_IN_SWITCH_MAJOR_VERSION) {
hseigel@4816 2052 // 4639449 & 4647081: padding bytes must be 0
hseigel@4816 2053 u2 padding_offset = 1;
hseigel@4816 2054 while ((bcp + padding_offset) < aligned_bcp) {
hseigel@4816 2055 if(*(bcp + padding_offset) != 0) {
hseigel@4816 2056 verify_error(ErrorContext::bad_code(bci),
hseigel@4816 2057 "Nonzero padding byte in lookswitch or tableswitch");
hseigel@4816 2058 return;
hseigel@4816 2059 }
hseigel@4816 2060 padding_offset++;
duke@435 2061 }
duke@435 2062 }
hseigel@4816 2063
duke@435 2064 int default_offset = (int) Bytes::get_Java_u4(aligned_bcp);
duke@435 2065 int keys, delta;
duke@435 2066 current_frame->pop_stack(
duke@435 2067 VerificationType::integer_type(), CHECK_VERIFY(this));
jrose@1920 2068 if (bcs->raw_code() == Bytecodes::_tableswitch) {
duke@435 2069 jint low = (jint)Bytes::get_Java_u4(aligned_bcp + jintSize);
duke@435 2070 jint high = (jint)Bytes::get_Java_u4(aligned_bcp + 2*jintSize);
duke@435 2071 if (low > high) {
kamg@3992 2072 verify_error(ErrorContext::bad_code(bci),
kamg@3992 2073 "low must be less than or equal to high in tableswitch");
duke@435 2074 return;
duke@435 2075 }
duke@435 2076 keys = high - low + 1;
duke@435 2077 if (keys < 0) {
kamg@3992 2078 verify_error(ErrorContext::bad_code(bci), "too many keys in tableswitch");
duke@435 2079 return;
duke@435 2080 }
duke@435 2081 delta = 1;
duke@435 2082 } else {
duke@435 2083 keys = (int)Bytes::get_Java_u4(aligned_bcp + jintSize);
duke@435 2084 if (keys < 0) {
kamg@3992 2085 verify_error(ErrorContext::bad_code(bci),
kamg@3992 2086 "number of keys in lookupswitch less than 0");
duke@435 2087 return;
duke@435 2088 }
duke@435 2089 delta = 2;
duke@435 2090 // Make sure that the lookupswitch items are sorted
duke@435 2091 for (int i = 0; i < (keys - 1); i++) {
duke@435 2092 jint this_key = Bytes::get_Java_u4(aligned_bcp + (2+2*i)*jintSize);
duke@435 2093 jint next_key = Bytes::get_Java_u4(aligned_bcp + (2+2*i+2)*jintSize);
duke@435 2094 if (this_key >= next_key) {
kamg@3992 2095 verify_error(ErrorContext::bad_code(bci),
kamg@3992 2096 "Bad lookupswitch instruction");
duke@435 2097 return;
duke@435 2098 }
duke@435 2099 }
duke@435 2100 }
duke@435 2101 int target = bci + default_offset;
duke@435 2102 stackmap_table->check_jump_target(current_frame, target, CHECK_VERIFY(this));
duke@435 2103 for (int i = 0; i < keys; i++) {
kamg@3821 2104 // Because check_jump_target() may safepoint, the bytecode could have
kamg@3821 2105 // moved, which means 'aligned_bcp' is no good and needs to be recalculated.
kamg@3821 2106 aligned_bcp = (address)round_to((intptr_t)(bcs->bcp() + 1), jintSize);
duke@435 2107 target = bci + (jint)Bytes::get_Java_u4(aligned_bcp+(3+i*delta)*jintSize);
duke@435 2108 stackmap_table->check_jump_target(
duke@435 2109 current_frame, target, CHECK_VERIFY(this));
duke@435 2110 }
kamg@3821 2111 NOT_PRODUCT(aligned_bcp = NULL); // no longer valid at this point
duke@435 2112 }
duke@435 2113
duke@435 2114 bool ClassVerifier::name_in_supers(
coleenp@2497 2115 Symbol* ref_name, instanceKlassHandle current) {
coleenp@4037 2116 Klass* super = current->super();
duke@435 2117 while (super != NULL) {
coleenp@4037 2118 if (super->name() == ref_name) {
duke@435 2119 return true;
duke@435 2120 }
coleenp@4037 2121 super = super->super();
duke@435 2122 }
duke@435 2123 return false;
duke@435 2124 }
duke@435 2125
duke@435 2126 void ClassVerifier::verify_field_instructions(RawBytecodeStream* bcs,
duke@435 2127 StackMapFrame* current_frame,
duke@435 2128 constantPoolHandle cp,
duke@435 2129 TRAPS) {
jrose@1920 2130 u2 index = bcs->get_index_u2();
kamg@3992 2131 verify_cp_type(bcs->bci(), index, cp,
kamg@3992 2132 1 << JVM_CONSTANT_Fieldref, CHECK_VERIFY(this));
duke@435 2133
duke@435 2134 // Get field name and signature
coleenp@2497 2135 Symbol* field_name = cp->name_ref_at(index);
coleenp@2497 2136 Symbol* field_sig = cp->signature_ref_at(index);
duke@435 2137
duke@435 2138 if (!SignatureVerifier::is_valid_type_signature(field_sig)) {
duke@435 2139 class_format_error(
duke@435 2140 "Invalid signature for field in class %s referenced "
duke@435 2141 "from constant pool index %d", _klass->external_name(), index);
duke@435 2142 return;
duke@435 2143 }
duke@435 2144
duke@435 2145 // Get referenced class type
duke@435 2146 VerificationType ref_class_type = cp_ref_index_to_type(
duke@435 2147 index, cp, CHECK_VERIFY(this));
duke@435 2148 if (!ref_class_type.is_object()) {
kamg@3992 2149 /* Unreachable? Class file parser verifies Fieldref contents */
kamg@3992 2150 verify_error(ErrorContext::bad_type(bcs->bci(),
kamg@3992 2151 TypeOrigin::cp(index, ref_class_type)),
kamg@3992 2152 "Expecting reference to class in class %s at constant pool index %d",
kamg@3992 2153 _klass->external_name(), index);
duke@435 2154 return;
duke@435 2155 }
duke@435 2156 VerificationType target_class_type = ref_class_type;
duke@435 2157
duke@435 2158 assert(sizeof(VerificationType) == sizeof(uintptr_t),
duke@435 2159 "buffer type must match VerificationType size");
duke@435 2160 uintptr_t field_type_buffer[2];
duke@435 2161 VerificationType* field_type = (VerificationType*)field_type_buffer;
duke@435 2162 // If we make a VerificationType[2] array directly, the compiler calls
duke@435 2163 // to the c-runtime library to do the allocation instead of just
duke@435 2164 // stack allocating it. Plus it would run constructors. This shows up
duke@435 2165 // in performance profiles.
duke@435 2166
duke@435 2167 SignatureStream sig_stream(field_sig, false);
duke@435 2168 VerificationType stack_object_type;
duke@435 2169 int n = change_sig_to_verificationType(
duke@435 2170 &sig_stream, field_type, CHECK_VERIFY(this));
duke@435 2171 u2 bci = bcs->bci();
duke@435 2172 bool is_assignable;
jrose@1920 2173 switch (bcs->raw_code()) {
duke@435 2174 case Bytecodes::_getstatic: {
duke@435 2175 for (int i = 0; i < n; i++) {
duke@435 2176 current_frame->push_stack(field_type[i], CHECK_VERIFY(this));
duke@435 2177 }
duke@435 2178 break;
duke@435 2179 }
duke@435 2180 case Bytecodes::_putstatic: {
duke@435 2181 for (int i = n - 1; i >= 0; i--) {
duke@435 2182 current_frame->pop_stack(field_type[i], CHECK_VERIFY(this));
duke@435 2183 }
duke@435 2184 break;
duke@435 2185 }
duke@435 2186 case Bytecodes::_getfield: {
duke@435 2187 stack_object_type = current_frame->pop_stack(
duke@435 2188 target_class_type, CHECK_VERIFY(this));
duke@435 2189 for (int i = 0; i < n; i++) {
duke@435 2190 current_frame->push_stack(field_type[i], CHECK_VERIFY(this));
duke@435 2191 }
duke@435 2192 goto check_protected;
duke@435 2193 }
duke@435 2194 case Bytecodes::_putfield: {
duke@435 2195 for (int i = n - 1; i >= 0; i--) {
duke@435 2196 current_frame->pop_stack(field_type[i], CHECK_VERIFY(this));
duke@435 2197 }
duke@435 2198 stack_object_type = current_frame->pop_stack(CHECK_VERIFY(this));
duke@435 2199
duke@435 2200 // The JVMS 2nd edition allows field initialization before the superclass
duke@435 2201 // initializer, if the field is defined within the current class.
duke@435 2202 fieldDescriptor fd;
duke@435 2203 if (stack_object_type == VerificationType::uninitialized_this_type() &&
duke@435 2204 target_class_type.equals(current_type()) &&
coleenp@2497 2205 _klass->find_local_field(field_name, field_sig, &fd)) {
duke@435 2206 stack_object_type = current_type();
duke@435 2207 }
duke@435 2208 is_assignable = target_class_type.is_assignable_from(
hseigel@6824 2209 stack_object_type, this, false, CHECK_VERIFY(this));
duke@435 2210 if (!is_assignable) {
kamg@3992 2211 verify_error(ErrorContext::bad_type(bci,
kamg@3992 2212 current_frame->stack_top_ctx(),
kamg@3992 2213 TypeOrigin::cp(index, target_class_type)),
kamg@3992 2214 "Bad type on operand stack in putfield");
duke@435 2215 return;
duke@435 2216 }
duke@435 2217 }
duke@435 2218 check_protected: {
duke@435 2219 if (_this_type == stack_object_type)
duke@435 2220 break; // stack_object_type must be assignable to _current_class_type
coleenp@2497 2221 Symbol* ref_class_name =
coleenp@2497 2222 cp->klass_name_at(cp->klass_ref_index_at(index));
coleenp@2497 2223 if (!name_in_supers(ref_class_name, current_class()))
duke@435 2224 // stack_object_type must be assignable to _current_class_type since:
duke@435 2225 // 1. stack_object_type must be assignable to ref_class.
duke@435 2226 // 2. ref_class must be _current_class or a subclass of it. It can't
duke@435 2227 // be a superclass of it. See revised JVMS 5.4.4.
duke@435 2228 break;
duke@435 2229
coleenp@4037 2230 Klass* ref_class_oop = load_class(ref_class_name, CHECK);
coleenp@2497 2231 if (is_protected_access(current_class(), ref_class_oop, field_name,
coleenp@2497 2232 field_sig, false)) {
duke@435 2233 // It's protected access, check if stack object is assignable to
duke@435 2234 // current class.
duke@435 2235 is_assignable = current_type().is_assignable_from(
hseigel@6824 2236 stack_object_type, this, true, CHECK_VERIFY(this));
duke@435 2237 if (!is_assignable) {
kamg@3992 2238 verify_error(ErrorContext::bad_type(bci,
kamg@3992 2239 current_frame->stack_top_ctx(),
kamg@3992 2240 TypeOrigin::implicit(current_type())),
kamg@3992 2241 "Bad access to protected data in getfield");
duke@435 2242 return;
duke@435 2243 }
duke@435 2244 }
duke@435 2245 break;
duke@435 2246 }
duke@435 2247 default: ShouldNotReachHere();
duke@435 2248 }
duke@435 2249 }
duke@435 2250
hseigel@6871 2251 // Look at the method's handlers. If the bci is in the handler's try block
hseigel@7643 2252 // then check if the handler_pc is already on the stack. If not, push it
hseigel@7643 2253 // unless the handler has already been scanned.
hseigel@6871 2254 void ClassVerifier::push_handlers(ExceptionTable* exhandlers,
hseigel@7643 2255 GrowableArray<u4>* handler_list,
hseigel@6871 2256 GrowableArray<u4>* handler_stack,
hseigel@6871 2257 u4 bci) {
hseigel@6871 2258 int exlength = exhandlers->length();
hseigel@6871 2259 for(int x = 0; x < exlength; x++) {
hseigel@6871 2260 if (bci >= exhandlers->start_pc(x) && bci < exhandlers->end_pc(x)) {
hseigel@7643 2261 u4 exhandler_pc = exhandlers->handler_pc(x);
hseigel@7643 2262 if (!handler_list->contains(exhandler_pc)) {
hseigel@7643 2263 handler_stack->append_if_missing(exhandler_pc);
hseigel@7643 2264 handler_list->append(exhandler_pc);
hseigel@7643 2265 }
hseigel@6871 2266 }
hseigel@6871 2267 }
hseigel@6871 2268 }
hseigel@6871 2269
hseigel@6871 2270 // Return TRUE if all code paths starting with start_bc_offset end in
hseigel@6871 2271 // bytecode athrow or loop.
hseigel@6871 2272 bool ClassVerifier::ends_in_athrow(u4 start_bc_offset) {
hseigel@6871 2273 ResourceMark rm;
hseigel@6871 2274 // Create bytecode stream.
hseigel@6871 2275 RawBytecodeStream bcs(method());
hseigel@6871 2276 u4 code_length = method()->code_size();
hseigel@6871 2277 bcs.set_start(start_bc_offset);
hseigel@6871 2278 u4 target;
hseigel@6871 2279 // Create stack for storing bytecode start offsets for if* and *switch.
hseigel@6871 2280 GrowableArray<u4>* bci_stack = new GrowableArray<u4>(30);
hseigel@6871 2281 // Create stack for handlers for try blocks containing this handler.
hseigel@6871 2282 GrowableArray<u4>* handler_stack = new GrowableArray<u4>(30);
hseigel@7643 2283 // Create list of handlers that have been pushed onto the handler_stack
hseigel@7643 2284 // so that handlers embedded inside of their own TRY blocks only get
hseigel@7643 2285 // scanned once.
hseigel@7643 2286 GrowableArray<u4>* handler_list = new GrowableArray<u4>(30);
hseigel@6871 2287 // Create list of visited branch opcodes (goto* and if*).
hseigel@6871 2288 GrowableArray<u4>* visited_branches = new GrowableArray<u4>(30);
hseigel@6871 2289 ExceptionTable exhandlers(_method());
hseigel@6871 2290
hseigel@6871 2291 while (true) {
hseigel@6871 2292 if (bcs.is_last_bytecode()) {
hseigel@6871 2293 // if no more starting offsets to parse or if at the end of the
hseigel@6871 2294 // method then return false.
hseigel@6871 2295 if ((bci_stack->is_empty()) || ((u4)bcs.end_bci() == code_length))
hseigel@6871 2296 return false;
hseigel@6871 2297 // Pop a bytecode starting offset and scan from there.
hseigel@6871 2298 bcs.set_start(bci_stack->pop());
hseigel@6871 2299 }
hseigel@6871 2300 Bytecodes::Code opcode = bcs.raw_next();
hseigel@6871 2301 u4 bci = bcs.bci();
hseigel@6871 2302
hseigel@6871 2303 // If the bytecode is in a TRY block, push its handlers so they
hseigel@6871 2304 // will get parsed.
hseigel@7643 2305 push_handlers(&exhandlers, handler_list, handler_stack, bci);
hseigel@6871 2306
hseigel@6871 2307 switch (opcode) {
hseigel@6871 2308 case Bytecodes::_if_icmpeq:
hseigel@6871 2309 case Bytecodes::_if_icmpne:
hseigel@6871 2310 case Bytecodes::_if_icmplt:
hseigel@6871 2311 case Bytecodes::_if_icmpge:
hseigel@6871 2312 case Bytecodes::_if_icmpgt:
hseigel@6871 2313 case Bytecodes::_if_icmple:
hseigel@6871 2314 case Bytecodes::_ifeq:
hseigel@6871 2315 case Bytecodes::_ifne:
hseigel@6871 2316 case Bytecodes::_iflt:
hseigel@6871 2317 case Bytecodes::_ifge:
hseigel@6871 2318 case Bytecodes::_ifgt:
hseigel@6871 2319 case Bytecodes::_ifle:
hseigel@6871 2320 case Bytecodes::_if_acmpeq:
hseigel@6871 2321 case Bytecodes::_if_acmpne:
hseigel@6871 2322 case Bytecodes::_ifnull:
hseigel@6871 2323 case Bytecodes::_ifnonnull:
hseigel@6871 2324 target = bcs.dest();
hseigel@6871 2325 if (visited_branches->contains(bci)) {
hseigel@6871 2326 if (bci_stack->is_empty()) return true;
hseigel@6871 2327 // Pop a bytecode starting offset and scan from there.
hseigel@6871 2328 bcs.set_start(bci_stack->pop());
hseigel@6871 2329 } else {
hseigel@6871 2330 if (target > bci) { // forward branch
hseigel@6871 2331 if (target >= code_length) return false;
hseigel@6871 2332 // Push the branch target onto the stack.
hseigel@6871 2333 bci_stack->push(target);
hseigel@6871 2334 // then, scan bytecodes starting with next.
hseigel@6871 2335 bcs.set_start(bcs.next_bci());
hseigel@6871 2336 } else { // backward branch
hseigel@6871 2337 // Push bytecode offset following backward branch onto the stack.
hseigel@6871 2338 bci_stack->push(bcs.next_bci());
hseigel@6871 2339 // Check bytecodes starting with branch target.
hseigel@6871 2340 bcs.set_start(target);
hseigel@6871 2341 }
hseigel@6871 2342 // Record target so we don't branch here again.
hseigel@6871 2343 visited_branches->append(bci);
hseigel@6871 2344 }
hseigel@6871 2345 break;
hseigel@6871 2346
hseigel@6871 2347 case Bytecodes::_goto:
hseigel@6871 2348 case Bytecodes::_goto_w:
hseigel@6871 2349 target = (opcode == Bytecodes::_goto ? bcs.dest() : bcs.dest_w());
hseigel@6871 2350 if (visited_branches->contains(bci)) {
hseigel@6871 2351 if (bci_stack->is_empty()) return true;
hseigel@6871 2352 // Been here before, pop new starting offset from stack.
hseigel@6871 2353 bcs.set_start(bci_stack->pop());
hseigel@6871 2354 } else {
hseigel@6871 2355 if (target >= code_length) return false;
hseigel@6871 2356 // Continue scanning from the target onward.
hseigel@6871 2357 bcs.set_start(target);
hseigel@6871 2358 // Record target so we don't branch here again.
hseigel@6871 2359 visited_branches->append(bci);
hseigel@6871 2360 }
hseigel@6871 2361 break;
hseigel@6871 2362
hseigel@6871 2363 // Check that all switch alternatives end in 'athrow' bytecodes. Since it
hseigel@6871 2364 // is difficult to determine where each switch alternative ends, parse
hseigel@6871 2365 // each switch alternative until either hit a 'return', 'athrow', or reach
hseigel@6871 2366 // the end of the method's bytecodes. This is gross but should be okay
hseigel@6871 2367 // because:
hseigel@6871 2368 // 1. tableswitch and lookupswitch byte codes in handlers for ctor explicit
hseigel@6871 2369 // constructor invocations should be rare.
hseigel@6871 2370 // 2. if each switch alternative ends in an athrow then the parsing should be
hseigel@6871 2371 // short. If there is no athrow then it is bogus code, anyway.
hseigel@6871 2372 case Bytecodes::_lookupswitch:
hseigel@6871 2373 case Bytecodes::_tableswitch:
hseigel@6871 2374 {
hseigel@6871 2375 address aligned_bcp = (address) round_to((intptr_t)(bcs.bcp() + 1), jintSize);
hseigel@6871 2376 u4 default_offset = Bytes::get_Java_u4(aligned_bcp) + bci;
hseigel@6871 2377 int keys, delta;
hseigel@6871 2378 if (opcode == Bytecodes::_tableswitch) {
hseigel@6871 2379 jint low = (jint)Bytes::get_Java_u4(aligned_bcp + jintSize);
hseigel@6871 2380 jint high = (jint)Bytes::get_Java_u4(aligned_bcp + 2*jintSize);
hseigel@6871 2381 // This is invalid, but let the regular bytecode verifier
hseigel@6871 2382 // report this because the user will get a better error message.
hseigel@6871 2383 if (low > high) return true;
hseigel@6871 2384 keys = high - low + 1;
hseigel@6871 2385 delta = 1;
hseigel@6871 2386 } else {
hseigel@6871 2387 keys = (int)Bytes::get_Java_u4(aligned_bcp + jintSize);
hseigel@6871 2388 delta = 2;
hseigel@6871 2389 }
hseigel@6871 2390 // Invalid, let the regular bytecode verifier deal with it.
hseigel@6871 2391 if (keys < 0) return true;
hseigel@6871 2392
hseigel@6871 2393 // Push the offset of the next bytecode onto the stack.
hseigel@6871 2394 bci_stack->push(bcs.next_bci());
hseigel@6871 2395
hseigel@6871 2396 // Push the switch alternatives onto the stack.
hseigel@6871 2397 for (int i = 0; i < keys; i++) {
hseigel@6871 2398 u4 target = bci + (jint)Bytes::get_Java_u4(aligned_bcp+(3+i*delta)*jintSize);
hseigel@6871 2399 if (target > code_length) return false;
hseigel@6871 2400 bci_stack->push(target);
hseigel@6871 2401 }
hseigel@6871 2402
hseigel@6871 2403 // Start bytecode parsing for the switch at the default alternative.
hseigel@6871 2404 if (default_offset > code_length) return false;
hseigel@6871 2405 bcs.set_start(default_offset);
hseigel@6871 2406 break;
hseigel@6871 2407 }
hseigel@6871 2408
hseigel@6871 2409 case Bytecodes::_return:
hseigel@6871 2410 return false;
hseigel@6871 2411
hseigel@6871 2412 case Bytecodes::_athrow:
hseigel@6871 2413 {
hseigel@6871 2414 if (bci_stack->is_empty()) {
hseigel@6871 2415 if (handler_stack->is_empty()) {
hseigel@6871 2416 return true;
hseigel@6871 2417 } else {
hseigel@6871 2418 // Parse the catch handlers for try blocks containing athrow.
hseigel@6871 2419 bcs.set_start(handler_stack->pop());
hseigel@6871 2420 }
hseigel@6871 2421 } else {
hseigel@6871 2422 // Pop a bytecode offset and starting scanning from there.
hseigel@6871 2423 bcs.set_start(bci_stack->pop());
hseigel@6871 2424 }
hseigel@6871 2425 }
hseigel@6871 2426 break;
hseigel@6871 2427
hseigel@6871 2428 default:
hseigel@6871 2429 ;
hseigel@6871 2430 } // end switch
hseigel@6871 2431 } // end while loop
hseigel@6871 2432
hseigel@6871 2433 return false;
hseigel@6871 2434 }
hseigel@6871 2435
duke@435 2436 void ClassVerifier::verify_invoke_init(
kamg@3992 2437 RawBytecodeStream* bcs, u2 ref_class_index, VerificationType ref_class_type,
hseigel@7473 2438 StackMapFrame* current_frame, u4 code_length, bool in_try_block,
hseigel@7473 2439 bool *this_uninit, constantPoolHandle cp, StackMapTable* stackmap_table,
hseigel@7473 2440 TRAPS) {
duke@435 2441 u2 bci = bcs->bci();
duke@435 2442 VerificationType type = current_frame->pop_stack(
duke@435 2443 VerificationType::reference_check(), CHECK_VERIFY(this));
duke@435 2444 if (type == VerificationType::uninitialized_this_type()) {
kamg@3858 2445 // The method must be an <init> method of this class or its superclass
coleenp@4037 2446 Klass* superk = current_class()->super();
apangin@2032 2447 if (ref_class_type.name() != current_class()->name() &&
coleenp@4037 2448 ref_class_type.name() != superk->name()) {
kamg@3992 2449 verify_error(ErrorContext::bad_type(bci,
kamg@3992 2450 TypeOrigin::implicit(ref_class_type),
kamg@3992 2451 TypeOrigin::implicit(current_type())),
kamg@3992 2452 "Bad <init> method call");
duke@435 2453 return;
duke@435 2454 }
hseigel@6761 2455
hseigel@7473 2456 // If this invokespecial call is done from inside of a TRY block then make
hseigel@7473 2457 // sure that all catch clause paths end in a throw. Otherwise, this can
hseigel@7473 2458 // result in returning an incomplete object.
hseigel@7473 2459 if (in_try_block) {
hseigel@7473 2460 ExceptionTable exhandlers(_method());
hseigel@7473 2461 int exlength = exhandlers.length();
hseigel@7473 2462 for(int i = 0; i < exlength; i++) {
hseigel@7473 2463 u2 start_pc = exhandlers.start_pc(i);
hseigel@7473 2464 u2 end_pc = exhandlers.end_pc(i);
hseigel@6871 2465
hseigel@7473 2466 if (bci >= start_pc && bci < end_pc) {
hseigel@7473 2467 if (!ends_in_athrow(exhandlers.handler_pc(i))) {
hseigel@7473 2468 verify_error(ErrorContext::bad_code(bci),
hseigel@7473 2469 "Bad <init> method call from after the start of a try block");
hseigel@7473 2470 return;
hseigel@7473 2471 } else if (VerboseVerification) {
hseigel@7473 2472 ResourceMark rm;
hseigel@7473 2473 tty->print_cr(
hseigel@7473 2474 "Survived call to ends_in_athrow(): %s",
hseigel@7473 2475 current_class()->name()->as_C_string());
hseigel@7473 2476 }
hseigel@6871 2477 }
hseigel@6761 2478 }
hseigel@7473 2479
hseigel@7473 2480 // Check the exception handler target stackmaps with the locals from the
hseigel@7473 2481 // incoming stackmap (before initialize_object() changes them to outgoing
hseigel@7473 2482 // state).
hseigel@7473 2483 verify_exception_handler_targets(bci, true, current_frame,
hseigel@7473 2484 stackmap_table, CHECK_VERIFY(this));
hseigel@7473 2485 } // in_try_block
hseigel@6761 2486
duke@435 2487 current_frame->initialize_object(type, current_type());
duke@435 2488 *this_uninit = true;
duke@435 2489 } else if (type.is_uninitialized()) {
duke@435 2490 u2 new_offset = type.bci();
duke@435 2491 address new_bcp = bcs->bcp() - bci + new_offset;
duke@435 2492 if (new_offset > (code_length - 3) || (*new_bcp) != Bytecodes::_new) {
kamg@3992 2493 /* Unreachable? Stack map parsing ensures valid type and new
kamg@3992 2494 * instructions have a valid BCI. */
kamg@3992 2495 verify_error(ErrorContext::bad_code(new_offset),
kamg@3992 2496 "Expecting new instruction");
duke@435 2497 return;
duke@435 2498 }
duke@435 2499 u2 new_class_index = Bytes::get_Java_u2(new_bcp + 1);
kamg@3992 2500 verify_cp_class_type(bci, new_class_index, cp, CHECK_VERIFY(this));
duke@435 2501
duke@435 2502 // The method must be an <init> method of the indicated class
duke@435 2503 VerificationType new_class_type = cp_index_to_type(
duke@435 2504 new_class_index, cp, CHECK_VERIFY(this));
duke@435 2505 if (!new_class_type.equals(ref_class_type)) {
kamg@3992 2506 verify_error(ErrorContext::bad_type(bci,
kamg@3992 2507 TypeOrigin::cp(new_class_index, new_class_type),
kamg@3992 2508 TypeOrigin::cp(ref_class_index, ref_class_type)),
kamg@3992 2509 "Call to wrong <init> method");
duke@435 2510 return;
duke@435 2511 }
duke@435 2512 // According to the VM spec, if the referent class is a superclass of the
duke@435 2513 // current class, and is in a different runtime package, and the method is
duke@435 2514 // protected, then the objectref must be the current class or a subclass
duke@435 2515 // of the current class.
duke@435 2516 VerificationType objectref_type = new_class_type;
duke@435 2517 if (name_in_supers(ref_class_type.name(), current_class())) {
hseigel@7594 2518 Klass* ref_klass = load_class(ref_class_type.name(), CHECK);
coleenp@4037 2519 Method* m = InstanceKlass::cast(ref_klass)->uncached_lookup_method(
duke@435 2520 vmSymbols::object_initializer_name(),
asaha@6779 2521 cp->signature_ref_at(bcs->get_index_u2()), Klass::normal);
hseigel@6784 2522 // Do nothing if method is not found. Let resolution detect the error.
hseigel@6784 2523 if (m != NULL) {
hseigel@6784 2524 instanceKlassHandle mh(THREAD, m->method_holder());
hseigel@6784 2525 if (m->is_protected() && !mh->is_same_class_package(_klass())) {
hseigel@6784 2526 bool assignable = current_type().is_assignable_from(
asaha@6832 2527 objectref_type, this, true, CHECK_VERIFY(this));
hseigel@6784 2528 if (!assignable) {
hseigel@6784 2529 verify_error(ErrorContext::bad_type(bci,
hseigel@6784 2530 TypeOrigin::cp(new_class_index, objectref_type),
hseigel@6784 2531 TypeOrigin::implicit(current_type())),
hseigel@6784 2532 "Bad access to protected <init> method");
hseigel@6784 2533 return;
hseigel@6784 2534 }
duke@435 2535 }
duke@435 2536 }
duke@435 2537 }
hseigel@7473 2538 // Check the exception handler target stackmaps with the locals from the
hseigel@7473 2539 // incoming stackmap (before initialize_object() changes them to outgoing
hseigel@7473 2540 // state).
hseigel@7473 2541 if (in_try_block) {
hseigel@7473 2542 verify_exception_handler_targets(bci, *this_uninit, current_frame,
hseigel@7473 2543 stackmap_table, CHECK_VERIFY(this));
hseigel@7473 2544 }
duke@435 2545 current_frame->initialize_object(type, new_class_type);
duke@435 2546 } else {
kamg@3992 2547 verify_error(ErrorContext::bad_type(bci, current_frame->stack_top_ctx()),
kamg@3992 2548 "Bad operand type when invoking <init>");
duke@435 2549 return;
duke@435 2550 }
duke@435 2551 }
duke@435 2552
hseigel@6132 2553 bool ClassVerifier::is_same_or_direct_interface(
hseigel@6132 2554 instanceKlassHandle klass,
hseigel@6132 2555 VerificationType klass_type,
hseigel@6132 2556 VerificationType ref_class_type) {
hseigel@6132 2557 if (ref_class_type.equals(klass_type)) return true;
hseigel@6132 2558 Array<Klass*>* local_interfaces = klass->local_interfaces();
hseigel@6132 2559 if (local_interfaces != NULL) {
hseigel@6132 2560 for (int x = 0; x < local_interfaces->length(); x++) {
hseigel@6132 2561 Klass* k = local_interfaces->at(x);
hseigel@6132 2562 assert (k != NULL && k->is_interface(), "invalid interface");
hseigel@6132 2563 if (ref_class_type.equals(VerificationType::reference_type(k->name()))) {
hseigel@6132 2564 return true;
hseigel@6132 2565 }
hseigel@6132 2566 }
hseigel@6132 2567 }
hseigel@6132 2568 return false;
hseigel@6132 2569 }
hseigel@6132 2570
duke@435 2571 void ClassVerifier::verify_invoke_instructions(
duke@435 2572 RawBytecodeStream* bcs, u4 code_length, StackMapFrame* current_frame,
hseigel@7473 2573 bool in_try_block, bool *this_uninit, VerificationType return_type,
hseigel@7473 2574 constantPoolHandle cp, StackMapTable* stackmap_table, TRAPS) {
duke@435 2575 // Make sure the constant pool item is the right type
jrose@1920 2576 u2 index = bcs->get_index_u2();
jrose@1920 2577 Bytecodes::Code opcode = bcs->raw_code();
kamg@4245 2578 unsigned int types;
kamg@4245 2579 switch (opcode) {
kamg@4245 2580 case Bytecodes::_invokeinterface:
kamg@4245 2581 types = 1 << JVM_CONSTANT_InterfaceMethodref;
kamg@4245 2582 break;
kamg@4245 2583 case Bytecodes::_invokedynamic:
kamg@4245 2584 types = 1 << JVM_CONSTANT_InvokeDynamic;
kamg@4245 2585 break;
kamg@4245 2586 case Bytecodes::_invokespecial:
bharadwaj@4895 2587 case Bytecodes::_invokestatic:
bharadwaj@4895 2588 types = (_klass->major_version() < STATIC_METHOD_IN_INTERFACE_MAJOR_VERSION) ?
bharadwaj@4895 2589 (1 << JVM_CONSTANT_Methodref) :
bharadwaj@4895 2590 ((1 << JVM_CONSTANT_InterfaceMethodref) | (1 << JVM_CONSTANT_Methodref));
bharadwaj@4895 2591 break;
kamg@4245 2592 default:
kamg@4245 2593 types = 1 << JVM_CONSTANT_Methodref;
kamg@4245 2594 }
kamg@3992 2595 verify_cp_type(bcs->bci(), index, cp, types, CHECK_VERIFY(this));
duke@435 2596
duke@435 2597 // Get method name and signature
coleenp@2497 2598 Symbol* method_name = cp->name_ref_at(index);
coleenp@2497 2599 Symbol* method_sig = cp->signature_ref_at(index);
duke@435 2600
duke@435 2601 if (!SignatureVerifier::is_valid_method_signature(method_sig)) {
duke@435 2602 class_format_error(
duke@435 2603 "Invalid method signature in class %s referenced "
duke@435 2604 "from constant pool index %d", _klass->external_name(), index);
duke@435 2605 return;
duke@435 2606 }
duke@435 2607
duke@435 2608 // Get referenced class type
jrose@1161 2609 VerificationType ref_class_type;
jrose@1161 2610 if (opcode == Bytecodes::_invokedynamic) {
jrose@1957 2611 if (!EnableInvokeDynamic ||
jrose@1957 2612 _klass->major_version() < Verifier::INVOKEDYNAMIC_MAJOR_VERSION) {
drchase@6680 2613 if (!EnableInvokeDynamic) {
drchase@6680 2614 class_format_error("invokedynamic instructions not enabled in this JVM");
drchase@6680 2615 } else {
drchase@6680 2616 class_format_error("invokedynamic instructions not supported by this class file version (%d), class %s",
drchase@6680 2617 _klass->major_version(), _klass->external_name());
drchase@6680 2618 }
jrose@1161 2619 return;
jrose@1161 2620 }
jrose@1161 2621 } else {
jrose@1161 2622 ref_class_type = cp_ref_index_to_type(index, cp, CHECK_VERIFY(this));
jrose@1161 2623 }
duke@435 2624
duke@435 2625 // For a small signature length, we just allocate 128 bytes instead
duke@435 2626 // of parsing the signature once to find its size.
duke@435 2627 // -3 is for '(', ')' and return descriptor; multiply by 2 is for
duke@435 2628 // longs/doubles to be consertive.
duke@435 2629 assert(sizeof(VerificationType) == sizeof(uintptr_t),
duke@435 2630 "buffer type must match VerificationType size");
duke@435 2631 uintptr_t on_stack_sig_types_buffer[128];
duke@435 2632 // If we make a VerificationType[128] array directly, the compiler calls
duke@435 2633 // to the c-runtime library to do the allocation instead of just
duke@435 2634 // stack allocating it. Plus it would run constructors. This shows up
duke@435 2635 // in performance profiles.
duke@435 2636
duke@435 2637 VerificationType* sig_types;
duke@435 2638 int size = (method_sig->utf8_length() - 3) * 2;
duke@435 2639 if (size > 128) {
duke@435 2640 // Long and double occupies two slots here.
duke@435 2641 ArgumentSizeComputer size_it(method_sig);
duke@435 2642 size = size_it.size();
duke@435 2643 sig_types = NEW_RESOURCE_ARRAY_IN_THREAD(THREAD, VerificationType, size);
duke@435 2644 } else{
duke@435 2645 sig_types = (VerificationType*)on_stack_sig_types_buffer;
duke@435 2646 }
duke@435 2647 SignatureStream sig_stream(method_sig);
duke@435 2648 int sig_i = 0;
duke@435 2649 while (!sig_stream.at_return_type()) {
duke@435 2650 sig_i += change_sig_to_verificationType(
duke@435 2651 &sig_stream, &sig_types[sig_i], CHECK_VERIFY(this));
duke@435 2652 sig_stream.next();
duke@435 2653 }
duke@435 2654 int nargs = sig_i;
duke@435 2655
duke@435 2656 #ifdef ASSERT
duke@435 2657 {
duke@435 2658 ArgumentSizeComputer size_it(method_sig);
duke@435 2659 assert(nargs == size_it.size(), "Argument sizes do not match");
duke@435 2660 assert(nargs <= (method_sig->utf8_length() - 3) * 2, "estimate of max size isn't conservative enough");
duke@435 2661 }
duke@435 2662 #endif
duke@435 2663
duke@435 2664 // Check instruction operands
duke@435 2665 u2 bci = bcs->bci();
duke@435 2666 if (opcode == Bytecodes::_invokeinterface) {
duke@435 2667 address bcp = bcs->bcp();
duke@435 2668 // 4905268: count operand in invokeinterface should be nargs+1, not nargs.
duke@435 2669 // JSR202 spec: The count operand of an invokeinterface instruction is valid if it is
duke@435 2670 // the difference between the size of the operand stack before and after the instruction
duke@435 2671 // executes.
duke@435 2672 if (*(bcp+3) != (nargs+1)) {
kamg@3992 2673 verify_error(ErrorContext::bad_code(bci),
kamg@3992 2674 "Inconsistent args count operand in invokeinterface");
duke@435 2675 return;
duke@435 2676 }
duke@435 2677 if (*(bcp+4) != 0) {
kamg@3992 2678 verify_error(ErrorContext::bad_code(bci),
kamg@3992 2679 "Fourth operand byte of invokeinterface must be zero");
duke@435 2680 return;
duke@435 2681 }
duke@435 2682 }
duke@435 2683
jrose@1161 2684 if (opcode == Bytecodes::_invokedynamic) {
jrose@1161 2685 address bcp = bcs->bcp();
jrose@1161 2686 if (*(bcp+3) != 0 || *(bcp+4) != 0) {
kamg@3992 2687 verify_error(ErrorContext::bad_code(bci),
kamg@3992 2688 "Third and fourth operand bytes of invokedynamic must be zero");
jrose@1161 2689 return;
jrose@1161 2690 }
jrose@1161 2691 }
jrose@1161 2692
duke@435 2693 if (method_name->byte_at(0) == '<') {
duke@435 2694 // Make sure <init> can only be invoked by invokespecial
duke@435 2695 if (opcode != Bytecodes::_invokespecial ||
coleenp@2497 2696 method_name != vmSymbols::object_initializer_name()) {
kamg@3992 2697 verify_error(ErrorContext::bad_code(bci),
kamg@3992 2698 "Illegal call to internal method");
duke@435 2699 return;
duke@435 2700 }
duke@435 2701 } else if (opcode == Bytecodes::_invokespecial
hseigel@6132 2702 && !is_same_or_direct_interface(current_class(), current_type(), ref_class_type)
duke@435 2703 && !ref_class_type.equals(VerificationType::reference_type(
coleenp@4037 2704 current_class()->super()->name()))) {
acorn@5930 2705 bool subtype = false;
hseigel@6132 2706 bool have_imr_indirect = cp->tag_at(index).value() == JVM_CONSTANT_InterfaceMethodref;
acorn@5930 2707 if (!current_class()->is_anonymous()) {
acorn@5930 2708 subtype = ref_class_type.is_assignable_from(
hseigel@6824 2709 current_type(), this, false, CHECK_VERIFY(this));
acorn@5930 2710 } else {
hseigel@6132 2711 VerificationType host_klass_type =
hseigel@6132 2712 VerificationType::reference_type(current_class()->host_klass()->name());
hseigel@6824 2713 subtype = ref_class_type.is_assignable_from(host_klass_type, this, false, CHECK_VERIFY(this));
hseigel@6132 2714
hseigel@6132 2715 // If invokespecial of IMR, need to recheck for same or
hseigel@6132 2716 // direct interface relative to the host class
hseigel@6132 2717 have_imr_indirect = (have_imr_indirect &&
hseigel@6132 2718 !is_same_or_direct_interface(
hseigel@6132 2719 InstanceKlass::cast(current_class()->host_klass()),
hseigel@6132 2720 host_klass_type, ref_class_type));
acorn@5930 2721 }
duke@435 2722 if (!subtype) {
acorn@5930 2723 verify_error(ErrorContext::bad_code(bci),
acorn@5930 2724 "Bad invokespecial instruction: "
acorn@5930 2725 "current class isn't assignable to reference class.");
acorn@5930 2726 return;
hseigel@6132 2727 } else if (have_imr_indirect) {
hseigel@6132 2728 verify_error(ErrorContext::bad_code(bci),
hseigel@6132 2729 "Bad invokespecial instruction: "
hseigel@6132 2730 "interface method reference is in an indirect superinterface.");
hseigel@6132 2731 return;
duke@435 2732 }
hseigel@6132 2733
duke@435 2734 }
duke@435 2735 // Match method descriptor with operand stack
duke@435 2736 for (int i = nargs - 1; i >= 0; i--) { // Run backwards
duke@435 2737 current_frame->pop_stack(sig_types[i], CHECK_VERIFY(this));
duke@435 2738 }
duke@435 2739 // Check objectref on operand stack
jrose@1161 2740 if (opcode != Bytecodes::_invokestatic &&
jrose@1161 2741 opcode != Bytecodes::_invokedynamic) {
coleenp@2497 2742 if (method_name == vmSymbols::object_initializer_name()) { // <init> method
kamg@3992 2743 verify_invoke_init(bcs, index, ref_class_type, current_frame,
hseigel@7473 2744 code_length, in_try_block, this_uninit, cp, stackmap_table,
hseigel@7473 2745 CHECK_VERIFY(this));
duke@435 2746 } else { // other methods
duke@435 2747 // Ensures that target class is assignable to method class.
duke@435 2748 if (opcode == Bytecodes::_invokespecial) {
acorn@5852 2749 if (!current_class()->is_anonymous()) {
acorn@5852 2750 current_frame->pop_stack(current_type(), CHECK_VERIFY(this));
acorn@5852 2751 } else {
acorn@5930 2752 // anonymous class invokespecial calls: check if the
acorn@5930 2753 // objectref is a subtype of the host_klass of the current class
acorn@5852 2754 // to allow an anonymous class to reference methods in the host_klass
acorn@5852 2755 VerificationType top = current_frame->pop_stack(CHECK_VERIFY(this));
acorn@5930 2756 VerificationType hosttype =
acorn@5930 2757 VerificationType::reference_type(current_class()->host_klass()->name());
hseigel@6824 2758 bool subtype = hosttype.is_assignable_from(top, this, false, CHECK_VERIFY(this));
acorn@5852 2759 if (!subtype) {
acorn@5852 2760 verify_error( ErrorContext::bad_type(current_frame->offset(),
acorn@5852 2761 current_frame->stack_top_ctx(),
acorn@5852 2762 TypeOrigin::implicit(top)),
acorn@5852 2763 "Bad type on operand stack");
acorn@5852 2764 return;
acorn@5852 2765 }
acorn@5852 2766 }
duke@435 2767 } else if (opcode == Bytecodes::_invokevirtual) {
duke@435 2768 VerificationType stack_object_type =
duke@435 2769 current_frame->pop_stack(ref_class_type, CHECK_VERIFY(this));
duke@435 2770 if (current_type() != stack_object_type) {
duke@435 2771 assert(cp->cache() == NULL, "not rewritten yet");
coleenp@2497 2772 Symbol* ref_class_name =
coleenp@2497 2773 cp->klass_name_at(cp->klass_ref_index_at(index));
duke@435 2774 // See the comments in verify_field_instructions() for
duke@435 2775 // the rationale behind this.
coleenp@2497 2776 if (name_in_supers(ref_class_name, current_class())) {
coleenp@4037 2777 Klass* ref_class = load_class(ref_class_name, CHECK);
duke@435 2778 if (is_protected_access(
coleenp@2497 2779 _klass, ref_class, method_name, method_sig, true)) {
duke@435 2780 // It's protected access, check if stack object is
duke@435 2781 // assignable to current class.
duke@435 2782 bool is_assignable = current_type().is_assignable_from(
hseigel@6824 2783 stack_object_type, this, true, CHECK_VERIFY(this));
duke@435 2784 if (!is_assignable) {
duke@435 2785 if (ref_class_type.name() == vmSymbols::java_lang_Object()
duke@435 2786 && stack_object_type.is_array()
coleenp@2497 2787 && method_name == vmSymbols::clone_name()) {
duke@435 2788 // Special case: arrays pretend to implement public Object
duke@435 2789 // clone().
duke@435 2790 } else {
kamg@3992 2791 verify_error(ErrorContext::bad_type(bci,
kamg@3992 2792 current_frame->stack_top_ctx(),
kamg@3992 2793 TypeOrigin::implicit(current_type())),
kamg@3992 2794 "Bad access to protected data in invokevirtual");
duke@435 2795 return;
duke@435 2796 }
duke@435 2797 }
duke@435 2798 }
duke@435 2799 }
duke@435 2800 }
duke@435 2801 } else {
duke@435 2802 assert(opcode == Bytecodes::_invokeinterface, "Unexpected opcode encountered");
duke@435 2803 current_frame->pop_stack(ref_class_type, CHECK_VERIFY(this));
duke@435 2804 }
duke@435 2805 }
duke@435 2806 }
duke@435 2807 // Push the result type.
duke@435 2808 if (sig_stream.type() != T_VOID) {
coleenp@2497 2809 if (method_name == vmSymbols::object_initializer_name()) {
duke@435 2810 // <init> method must have a void return type
kamg@3992 2811 /* Unreachable? Class file parser verifies that methods with '<' have
kamg@3992 2812 * void return */
kamg@3992 2813 verify_error(ErrorContext::bad_code(bci),
kamg@3992 2814 "Return type must be void in <init> method");
duke@435 2815 return;
duke@435 2816 }
duke@435 2817 VerificationType return_type[2];
duke@435 2818 int n = change_sig_to_verificationType(
duke@435 2819 &sig_stream, return_type, CHECK_VERIFY(this));
duke@435 2820 for (int i = 0; i < n; i++) {
duke@435 2821 current_frame->push_stack(return_type[i], CHECK_VERIFY(this)); // push types backwards
duke@435 2822 }
duke@435 2823 }
duke@435 2824 }
duke@435 2825
duke@435 2826 VerificationType ClassVerifier::get_newarray_type(
duke@435 2827 u2 index, u2 bci, TRAPS) {
duke@435 2828 const char* from_bt[] = {
duke@435 2829 NULL, NULL, NULL, NULL, "[Z", "[C", "[F", "[D", "[B", "[S", "[I", "[J",
duke@435 2830 };
duke@435 2831 if (index < T_BOOLEAN || index > T_LONG) {
kamg@3992 2832 verify_error(ErrorContext::bad_code(bci), "Illegal newarray instruction");
duke@435 2833 return VerificationType::bogus_type();
duke@435 2834 }
duke@435 2835
duke@435 2836 // from_bt[index] contains the array signature which has a length of 2
coleenp@2497 2837 Symbol* sig = create_temporary_symbol(
duke@435 2838 from_bt[index], 2, CHECK_(VerificationType::bogus_type()));
duke@435 2839 return VerificationType::reference_type(sig);
duke@435 2840 }
duke@435 2841
duke@435 2842 void ClassVerifier::verify_anewarray(
kamg@3992 2843 u2 bci, u2 index, constantPoolHandle cp,
kamg@3992 2844 StackMapFrame* current_frame, TRAPS) {
kamg@3992 2845 verify_cp_class_type(bci, index, cp, CHECK_VERIFY(this));
duke@435 2846 current_frame->pop_stack(
duke@435 2847 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 2848
duke@435 2849 VerificationType component_type =
duke@435 2850 cp_index_to_type(index, cp, CHECK_VERIFY(this));
duke@435 2851 int length;
duke@435 2852 char* arr_sig_str;
duke@435 2853 if (component_type.is_array()) { // it's an array
duke@435 2854 const char* component_name = component_type.name()->as_utf8();
duke@435 2855 // add one dimension to component
duke@435 2856 length = (int)strlen(component_name) + 1;
duke@435 2857 arr_sig_str = NEW_RESOURCE_ARRAY_IN_THREAD(THREAD, char, length);
duke@435 2858 arr_sig_str[0] = '[';
duke@435 2859 strncpy(&arr_sig_str[1], component_name, length - 1);
duke@435 2860 } else { // it's an object or interface
duke@435 2861 const char* component_name = component_type.name()->as_utf8();
duke@435 2862 // add one dimension to component with 'L' prepended and ';' postpended.
duke@435 2863 length = (int)strlen(component_name) + 3;
duke@435 2864 arr_sig_str = NEW_RESOURCE_ARRAY_IN_THREAD(THREAD, char, length);
duke@435 2865 arr_sig_str[0] = '[';
duke@435 2866 arr_sig_str[1] = 'L';
duke@435 2867 strncpy(&arr_sig_str[2], component_name, length - 2);
duke@435 2868 arr_sig_str[length - 1] = ';';
duke@435 2869 }
coleenp@2497 2870 Symbol* arr_sig = create_temporary_symbol(
duke@435 2871 arr_sig_str, length, CHECK_VERIFY(this));
duke@435 2872 VerificationType new_array_type = VerificationType::reference_type(arr_sig);
duke@435 2873 current_frame->push_stack(new_array_type, CHECK_VERIFY(this));
duke@435 2874 }
duke@435 2875
duke@435 2876 void ClassVerifier::verify_iload(u2 index, StackMapFrame* current_frame, TRAPS) {
duke@435 2877 current_frame->get_local(
duke@435 2878 index, VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 2879 current_frame->push_stack(
duke@435 2880 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 2881 }
duke@435 2882
duke@435 2883 void ClassVerifier::verify_lload(u2 index, StackMapFrame* current_frame, TRAPS) {
duke@435 2884 current_frame->get_local_2(
duke@435 2885 index, VerificationType::long_type(),
duke@435 2886 VerificationType::long2_type(), CHECK_VERIFY(this));
duke@435 2887 current_frame->push_stack_2(
duke@435 2888 VerificationType::long_type(),
duke@435 2889 VerificationType::long2_type(), CHECK_VERIFY(this));
duke@435 2890 }
duke@435 2891
duke@435 2892 void ClassVerifier::verify_fload(u2 index, StackMapFrame* current_frame, TRAPS) {
duke@435 2893 current_frame->get_local(
duke@435 2894 index, VerificationType::float_type(), CHECK_VERIFY(this));
duke@435 2895 current_frame->push_stack(
duke@435 2896 VerificationType::float_type(), CHECK_VERIFY(this));
duke@435 2897 }
duke@435 2898
duke@435 2899 void ClassVerifier::verify_dload(u2 index, StackMapFrame* current_frame, TRAPS) {
duke@435 2900 current_frame->get_local_2(
duke@435 2901 index, VerificationType::double_type(),
duke@435 2902 VerificationType::double2_type(), CHECK_VERIFY(this));
duke@435 2903 current_frame->push_stack_2(
duke@435 2904 VerificationType::double_type(),
duke@435 2905 VerificationType::double2_type(), CHECK_VERIFY(this));
duke@435 2906 }
duke@435 2907
duke@435 2908 void ClassVerifier::verify_aload(u2 index, StackMapFrame* current_frame, TRAPS) {
duke@435 2909 VerificationType type = current_frame->get_local(
duke@435 2910 index, VerificationType::reference_check(), CHECK_VERIFY(this));
duke@435 2911 current_frame->push_stack(type, CHECK_VERIFY(this));
duke@435 2912 }
duke@435 2913
duke@435 2914 void ClassVerifier::verify_istore(u2 index, StackMapFrame* current_frame, TRAPS) {
duke@435 2915 current_frame->pop_stack(
duke@435 2916 VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 2917 current_frame->set_local(
duke@435 2918 index, VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 2919 }
duke@435 2920
duke@435 2921 void ClassVerifier::verify_lstore(u2 index, StackMapFrame* current_frame, TRAPS) {
duke@435 2922 current_frame->pop_stack_2(
duke@435 2923 VerificationType::long2_type(),
duke@435 2924 VerificationType::long_type(), CHECK_VERIFY(this));
duke@435 2925 current_frame->set_local_2(
duke@435 2926 index, VerificationType::long_type(),
duke@435 2927 VerificationType::long2_type(), CHECK_VERIFY(this));
duke@435 2928 }
duke@435 2929
duke@435 2930 void ClassVerifier::verify_fstore(u2 index, StackMapFrame* current_frame, TRAPS) {
duke@435 2931 current_frame->pop_stack(VerificationType::float_type(), CHECK_VERIFY(this));
duke@435 2932 current_frame->set_local(
duke@435 2933 index, VerificationType::float_type(), CHECK_VERIFY(this));
duke@435 2934 }
duke@435 2935
duke@435 2936 void ClassVerifier::verify_dstore(u2 index, StackMapFrame* current_frame, TRAPS) {
duke@435 2937 current_frame->pop_stack_2(
duke@435 2938 VerificationType::double2_type(),
duke@435 2939 VerificationType::double_type(), CHECK_VERIFY(this));
duke@435 2940 current_frame->set_local_2(
duke@435 2941 index, VerificationType::double_type(),
duke@435 2942 VerificationType::double2_type(), CHECK_VERIFY(this));
duke@435 2943 }
duke@435 2944
duke@435 2945 void ClassVerifier::verify_astore(u2 index, StackMapFrame* current_frame, TRAPS) {
duke@435 2946 VerificationType type = current_frame->pop_stack(
duke@435 2947 VerificationType::reference_check(), CHECK_VERIFY(this));
duke@435 2948 current_frame->set_local(index, type, CHECK_VERIFY(this));
duke@435 2949 }
duke@435 2950
duke@435 2951 void ClassVerifier::verify_iinc(u2 index, StackMapFrame* current_frame, TRAPS) {
duke@435 2952 VerificationType type = current_frame->get_local(
duke@435 2953 index, VerificationType::integer_type(), CHECK_VERIFY(this));
duke@435 2954 current_frame->set_local(index, type, CHECK_VERIFY(this));
duke@435 2955 }
duke@435 2956
duke@435 2957 void ClassVerifier::verify_return_value(
kamg@3992 2958 VerificationType return_type, VerificationType type, u2 bci,
kamg@3992 2959 StackMapFrame* current_frame, TRAPS) {
duke@435 2960 if (return_type == VerificationType::bogus_type()) {
kamg@3992 2961 verify_error(ErrorContext::bad_type(bci,
kamg@3992 2962 current_frame->stack_top_ctx(), TypeOrigin::signature(return_type)),
kamg@3992 2963 "Method expects a return value");
duke@435 2964 return;
duke@435 2965 }
hseigel@6824 2966 bool match = return_type.is_assignable_from(type, this, false, CHECK_VERIFY(this));
duke@435 2967 if (!match) {
kamg@3992 2968 verify_error(ErrorContext::bad_type(bci,
kamg@3992 2969 current_frame->stack_top_ctx(), TypeOrigin::signature(return_type)),
kamg@3992 2970 "Bad return type");
duke@435 2971 return;
duke@435 2972 }
duke@435 2973 }
coleenp@2497 2974
coleenp@2497 2975 // The verifier creates symbols which are substrings of Symbols.
coleenp@2497 2976 // These are stored in the verifier until the end of verification so that
coleenp@2497 2977 // they can be reference counted.
coleenp@2497 2978 Symbol* ClassVerifier::create_temporary_symbol(const Symbol *s, int begin,
coleenp@2497 2979 int end, TRAPS) {
coleenp@2497 2980 Symbol* sym = SymbolTable::new_symbol(s, begin, end, CHECK_NULL);
coleenp@2497 2981 _symbols->push(sym);
coleenp@2497 2982 return sym;
coleenp@2497 2983 }
coleenp@2497 2984
coleenp@2497 2985 Symbol* ClassVerifier::create_temporary_symbol(const char *s, int length, TRAPS) {
coleenp@2497 2986 Symbol* sym = SymbolTable::new_symbol(s, length, CHECK_NULL);
coleenp@2497 2987 _symbols->push(sym);
coleenp@2497 2988 return sym;
coleenp@2497 2989 }

mercurial