src/share/vm/opto/lcm.cpp

Wed, 03 Jun 2015 14:22:57 +0200

author
roland
date
Wed, 03 Jun 2015 14:22:57 +0200
changeset 7859
c1c199dde5c9
parent 7598
ddce0b7cee93
child 7994
04ff2f6cd0eb
child 8316
626f594dffa6
permissions
-rw-r--r--

8077504: Unsafe load can loose control dependency and cause crash
Summary: Node::depends_only_on_test() should return false for Unsafe loads
Reviewed-by: kvn, adinn

duke@435 1 /*
dlong@7598 2 * Copyright (c) 1998, 2015, Oracle and/or its affiliates. All rights reserved.
duke@435 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@435 4 *
duke@435 5 * This code is free software; you can redistribute it and/or modify it
duke@435 6 * under the terms of the GNU General Public License version 2 only, as
duke@435 7 * published by the Free Software Foundation.
duke@435 8 *
duke@435 9 * This code is distributed in the hope that it will be useful, but WITHOUT
duke@435 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@435 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@435 12 * version 2 for more details (a copy is included in the LICENSE file that
duke@435 13 * accompanied this code).
duke@435 14 *
duke@435 15 * You should have received a copy of the GNU General Public License version
duke@435 16 * 2 along with this work; if not, write to the Free Software Foundation,
duke@435 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@435 18 *
trims@1907 19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
trims@1907 20 * or visit www.oracle.com if you need additional information or have any
trims@1907 21 * questions.
duke@435 22 *
duke@435 23 */
duke@435 24
stefank@2314 25 #include "precompiled.hpp"
stefank@2314 26 #include "memory/allocation.inline.hpp"
stefank@2314 27 #include "opto/block.hpp"
stefank@2314 28 #include "opto/c2compiler.hpp"
stefank@2314 29 #include "opto/callnode.hpp"
stefank@2314 30 #include "opto/cfgnode.hpp"
stefank@2314 31 #include "opto/machnode.hpp"
stefank@2314 32 #include "opto/runtime.hpp"
dlong@7598 33 #if defined AD_MD_HPP
dlong@7598 34 # include AD_MD_HPP
dlong@7598 35 #elif defined TARGET_ARCH_MODEL_x86_32
stefank@2314 36 # include "adfiles/ad_x86_32.hpp"
dlong@7598 37 #elif defined TARGET_ARCH_MODEL_x86_64
stefank@2314 38 # include "adfiles/ad_x86_64.hpp"
dlong@7598 39 #elif defined TARGET_ARCH_MODEL_sparc
stefank@2314 40 # include "adfiles/ad_sparc.hpp"
dlong@7598 41 #elif defined TARGET_ARCH_MODEL_zero
stefank@2314 42 # include "adfiles/ad_zero.hpp"
dlong@7598 43 #elif defined TARGET_ARCH_MODEL_ppc_64
goetz@6441 44 # include "adfiles/ad_ppc_64.hpp"
jcoomes@2993 45 #endif
stefank@2314 46
duke@435 47 // Optimization - Graph Style
duke@435 48
goetz@6486 49 // Check whether val is not-null-decoded compressed oop,
goetz@6486 50 // i.e. will grab into the base of the heap if it represents NULL.
goetz@6486 51 static bool accesses_heap_base_zone(Node *val) {
goetz@6486 52 if (Universe::narrow_oop_base() > 0) { // Implies UseCompressedOops.
goetz@6486 53 if (val && val->is_Mach()) {
goetz@6486 54 if (val->as_Mach()->ideal_Opcode() == Op_DecodeN) {
goetz@6486 55 // This assumes all Decodes with TypePtr::NotNull are matched to nodes that
goetz@6486 56 // decode NULL to point to the heap base (Decode_NN).
goetz@6486 57 if (val->bottom_type()->is_oopptr()->ptr() == TypePtr::NotNull) {
goetz@6486 58 return true;
goetz@6486 59 }
goetz@6486 60 }
goetz@6486 61 // Must recognize load operation with Decode matched in memory operand.
goetz@6486 62 // We should not reach here exept for PPC/AIX, as os::zero_page_read_protected()
goetz@6486 63 // returns true everywhere else. On PPC, no such memory operands
goetz@6486 64 // exist, therefore we did not yet implement a check for such operands.
goetz@6486 65 NOT_AIX(Unimplemented());
goetz@6486 66 }
goetz@6486 67 }
goetz@6486 68 return false;
goetz@6486 69 }
goetz@6486 70
goetz@6486 71 static bool needs_explicit_null_check_for_read(Node *val) {
goetz@6486 72 // On some OSes (AIX) the page at address 0 is only write protected.
goetz@6486 73 // If so, only Store operations will trap.
goetz@6486 74 if (os::zero_page_read_protected()) {
goetz@6486 75 return false; // Implicit null check will work.
goetz@6486 76 }
goetz@6486 77 // Also a read accessing the base of a heap-based compressed heap will trap.
goetz@6486 78 if (accesses_heap_base_zone(val) && // Hits the base zone page.
goetz@6486 79 Universe::narrow_oop_use_implicit_null_checks()) { // Base zone page is protected.
goetz@6486 80 return false;
goetz@6486 81 }
goetz@6486 82
goetz@6486 83 return true;
goetz@6486 84 }
goetz@6486 85
duke@435 86 //------------------------------implicit_null_check----------------------------
duke@435 87 // Detect implicit-null-check opportunities. Basically, find NULL checks
duke@435 88 // with suitable memory ops nearby. Use the memory op to do the NULL check.
duke@435 89 // I can generate a memory op if there is not one nearby.
duke@435 90 // The proj is the control projection for the not-null case.
kvn@1930 91 // The val is the pointer being checked for nullness or
kvn@1930 92 // decodeHeapOop_not_null node if it did not fold into address.
adlertz@5639 93 void PhaseCFG::implicit_null_check(Block* block, Node *proj, Node *val, int allowed_reasons) {
duke@435 94 // Assume if null check need for 0 offset then always needed
duke@435 95 // Intel solaris doesn't support any null checks yet and no
duke@435 96 // mechanism exists (yet) to set the switches at an os_cpu level
duke@435 97 if( !ImplicitNullChecks || MacroAssembler::needs_explicit_null_check(0)) return;
duke@435 98
duke@435 99 // Make sure the ptr-is-null path appears to be uncommon!
adlertz@5639 100 float f = block->end()->as_MachIf()->_prob;
duke@435 101 if( proj->Opcode() == Op_IfTrue ) f = 1.0f - f;
duke@435 102 if( f > PROB_UNLIKELY_MAG(4) ) return;
duke@435 103
duke@435 104 uint bidx = 0; // Capture index of value into memop
duke@435 105 bool was_store; // Memory op is a store op
duke@435 106
duke@435 107 // Get the successor block for if the test ptr is non-null
duke@435 108 Block* not_null_block; // this one goes with the proj
duke@435 109 Block* null_block;
adlertz@5639 110 if (block->get_node(block->number_of_nodes()-1) == proj) {
adlertz@5639 111 null_block = block->_succs[0];
adlertz@5639 112 not_null_block = block->_succs[1];
duke@435 113 } else {
adlertz@5639 114 assert(block->get_node(block->number_of_nodes()-2) == proj, "proj is one or the other");
adlertz@5639 115 not_null_block = block->_succs[0];
adlertz@5639 116 null_block = block->_succs[1];
duke@435 117 }
kvn@767 118 while (null_block->is_Empty() == Block::empty_with_goto) {
kvn@767 119 null_block = null_block->_succs[0];
kvn@767 120 }
duke@435 121
duke@435 122 // Search the exception block for an uncommon trap.
duke@435 123 // (See Parse::do_if and Parse::do_ifnull for the reason
duke@435 124 // we need an uncommon trap. Briefly, we need a way to
duke@435 125 // detect failure of this optimization, as in 6366351.)
duke@435 126 {
duke@435 127 bool found_trap = false;
adlertz@5639 128 for (uint i1 = 0; i1 < null_block->number_of_nodes(); i1++) {
adlertz@5635 129 Node* nn = null_block->get_node(i1);
duke@435 130 if (nn->is_MachCall() &&
twisti@2103 131 nn->as_MachCall()->entry_point() == SharedRuntime::uncommon_trap_blob()->entry_point()) {
duke@435 132 const Type* trtype = nn->in(TypeFunc::Parms)->bottom_type();
duke@435 133 if (trtype->isa_int() && trtype->is_int()->is_con()) {
duke@435 134 jint tr_con = trtype->is_int()->get_con();
duke@435 135 Deoptimization::DeoptReason reason = Deoptimization::trap_request_reason(tr_con);
duke@435 136 Deoptimization::DeoptAction action = Deoptimization::trap_request_action(tr_con);
duke@435 137 assert((int)reason < (int)BitsPerInt, "recode bit map");
duke@435 138 if (is_set_nth_bit(allowed_reasons, (int) reason)
duke@435 139 && action != Deoptimization::Action_none) {
duke@435 140 // This uncommon trap is sure to recompile, eventually.
duke@435 141 // When that happens, C->too_many_traps will prevent
duke@435 142 // this transformation from happening again.
duke@435 143 found_trap = true;
duke@435 144 }
duke@435 145 }
duke@435 146 break;
duke@435 147 }
duke@435 148 }
duke@435 149 if (!found_trap) {
duke@435 150 // We did not find an uncommon trap.
duke@435 151 return;
duke@435 152 }
duke@435 153 }
duke@435 154
kvn@1930 155 // Check for decodeHeapOop_not_null node which did not fold into address
kvn@1930 156 bool is_decoden = ((intptr_t)val) & 1;
kvn@1930 157 val = (Node*)(((intptr_t)val) & ~1);
kvn@1930 158
kvn@1930 159 assert(!is_decoden || (val->in(0) == NULL) && val->is_Mach() &&
kvn@1930 160 (val->as_Mach()->ideal_Opcode() == Op_DecodeN), "sanity");
kvn@1930 161
duke@435 162 // Search the successor block for a load or store who's base value is also
duke@435 163 // the tested value. There may be several.
duke@435 164 Node_List *out = new Node_List(Thread::current()->resource_area());
duke@435 165 MachNode *best = NULL; // Best found so far
duke@435 166 for (DUIterator i = val->outs(); val->has_out(i); i++) {
duke@435 167 Node *m = val->out(i);
duke@435 168 if( !m->is_Mach() ) continue;
duke@435 169 MachNode *mach = m->as_Mach();
duke@435 170 was_store = false;
kvn@2048 171 int iop = mach->ideal_Opcode();
kvn@2048 172 switch( iop ) {
duke@435 173 case Op_LoadB:
kvn@3882 174 case Op_LoadUB:
twisti@993 175 case Op_LoadUS:
duke@435 176 case Op_LoadD:
duke@435 177 case Op_LoadF:
duke@435 178 case Op_LoadI:
duke@435 179 case Op_LoadL:
duke@435 180 case Op_LoadP:
coleenp@548 181 case Op_LoadN:
duke@435 182 case Op_LoadS:
duke@435 183 case Op_LoadKlass:
kvn@599 184 case Op_LoadNKlass:
duke@435 185 case Op_LoadRange:
duke@435 186 case Op_LoadD_unaligned:
duke@435 187 case Op_LoadL_unaligned:
kvn@1586 188 assert(mach->in(2) == val, "should be address");
duke@435 189 break;
duke@435 190 case Op_StoreB:
duke@435 191 case Op_StoreC:
duke@435 192 case Op_StoreCM:
duke@435 193 case Op_StoreD:
duke@435 194 case Op_StoreF:
duke@435 195 case Op_StoreI:
duke@435 196 case Op_StoreL:
duke@435 197 case Op_StoreP:
coleenp@548 198 case Op_StoreN:
roland@4159 199 case Op_StoreNKlass:
duke@435 200 was_store = true; // Memory op is a store op
duke@435 201 // Stores will have their address in slot 2 (memory in slot 1).
duke@435 202 // If the value being nul-checked is in another slot, it means we
duke@435 203 // are storing the checked value, which does NOT check the value!
duke@435 204 if( mach->in(2) != val ) continue;
duke@435 205 break; // Found a memory op?
duke@435 206 case Op_StrComp:
cfang@1116 207 case Op_StrEquals:
cfang@1116 208 case Op_StrIndexOf:
rasbold@604 209 case Op_AryEq:
kvn@4479 210 case Op_EncodeISOArray:
duke@435 211 // Not a legit memory op for implicit null check regardless of
duke@435 212 // embedded loads
duke@435 213 continue;
duke@435 214 default: // Also check for embedded loads
duke@435 215 if( !mach->needs_anti_dependence_check() )
duke@435 216 continue; // Not an memory op; skip it
kvn@2048 217 if( must_clone[iop] ) {
kvn@2048 218 // Do not move nodes which produce flags because
kvn@2048 219 // RA will try to clone it to place near branch and
kvn@2048 220 // it will cause recompilation, see clone_node().
kvn@2048 221 continue;
kvn@2048 222 }
kvn@1586 223 {
kvn@1930 224 // Check that value is used in memory address in
kvn@1930 225 // instructions with embedded load (CmpP val1,(val2+off)).
kvn@1586 226 Node* base;
kvn@1586 227 Node* index;
kvn@1586 228 const MachOper* oper = mach->memory_inputs(base, index);
kvn@1586 229 if (oper == NULL || oper == (MachOper*)-1) {
kvn@1586 230 continue; // Not an memory op; skip it
kvn@1586 231 }
kvn@1586 232 if (val == base ||
kvn@1586 233 val == index && val->bottom_type()->isa_narrowoop()) {
kvn@1586 234 break; // Found it
kvn@1586 235 } else {
kvn@1586 236 continue; // Skip it
kvn@1586 237 }
kvn@1586 238 }
duke@435 239 break;
duke@435 240 }
goetz@6486 241
goetz@6486 242 // On some OSes (AIX) the page at address 0 is only write protected.
goetz@6486 243 // If so, only Store operations will trap.
goetz@6486 244 // But a read accessing the base of a heap-based compressed heap will trap.
goetz@6486 245 if (!was_store && needs_explicit_null_check_for_read(val)) {
goetz@6486 246 continue;
goetz@6486 247 }
goetz@6486 248
duke@435 249 // check if the offset is not too high for implicit exception
duke@435 250 {
duke@435 251 intptr_t offset = 0;
duke@435 252 const TypePtr *adr_type = NULL; // Do not need this return value here
duke@435 253 const Node* base = mach->get_base_and_disp(offset, adr_type);
duke@435 254 if (base == NULL || base == NodeSentinel) {
kvn@767 255 // Narrow oop address doesn't have base, only index
kvn@767 256 if( val->bottom_type()->isa_narrowoop() &&
kvn@767 257 MacroAssembler::needs_explicit_null_check(offset) )
kvn@767 258 continue; // Give up if offset is beyond page size
duke@435 259 // cannot reason about it; is probably not implicit null exception
duke@435 260 } else {
kvn@1077 261 const TypePtr* tptr;
kvn@5111 262 if (UseCompressedOops && (Universe::narrow_oop_shift() == 0 ||
kvn@5111 263 Universe::narrow_klass_shift() == 0)) {
kvn@1077 264 // 32-bits narrow oop can be the base of address expressions
kvn@5111 265 tptr = base->get_ptr_type();
kvn@1077 266 } else {
kvn@1077 267 // only regular oops are expected here
kvn@1077 268 tptr = base->bottom_type()->is_ptr();
kvn@1077 269 }
duke@435 270 // Give up if offset is not a compile-time constant
duke@435 271 if( offset == Type::OffsetBot || tptr->_offset == Type::OffsetBot )
duke@435 272 continue;
duke@435 273 offset += tptr->_offset; // correct if base is offseted
duke@435 274 if( MacroAssembler::needs_explicit_null_check(offset) )
duke@435 275 continue; // Give up is reference is beyond 4K page size
duke@435 276 }
duke@435 277 }
duke@435 278
duke@435 279 // Check ctrl input to see if the null-check dominates the memory op
adlertz@5639 280 Block *cb = get_block_for_node(mach);
duke@435 281 cb = cb->_idom; // Always hoist at least 1 block
duke@435 282 if( !was_store ) { // Stores can be hoisted only one block
adlertz@5639 283 while( cb->_dom_depth > (block->_dom_depth + 1))
duke@435 284 cb = cb->_idom; // Hoist loads as far as we want
duke@435 285 // The non-null-block should dominate the memory op, too. Live
duke@435 286 // range spilling will insert a spill in the non-null-block if it is
duke@435 287 // needs to spill the memory op for an implicit null check.
adlertz@5639 288 if (cb->_dom_depth == (block->_dom_depth + 1)) {
duke@435 289 if (cb != not_null_block) continue;
duke@435 290 cb = cb->_idom;
duke@435 291 }
duke@435 292 }
adlertz@5639 293 if( cb != block ) continue;
duke@435 294
duke@435 295 // Found a memory user; see if it can be hoisted to check-block
duke@435 296 uint vidx = 0; // Capture index of value into memop
duke@435 297 uint j;
duke@435 298 for( j = mach->req()-1; j > 0; j-- ) {
kvn@1930 299 if( mach->in(j) == val ) {
kvn@1930 300 vidx = j;
kvn@1930 301 // Ignore DecodeN val which could be hoisted to where needed.
kvn@1930 302 if( is_decoden ) continue;
kvn@1930 303 }
duke@435 304 // Block of memory-op input
adlertz@5639 305 Block *inb = get_block_for_node(mach->in(j));
adlertz@5639 306 Block *b = block; // Start from nul check
duke@435 307 while( b != inb && b->_dom_depth > inb->_dom_depth )
duke@435 308 b = b->_idom; // search upwards for input
duke@435 309 // See if input dominates null check
duke@435 310 if( b != inb )
duke@435 311 break;
duke@435 312 }
duke@435 313 if( j > 0 )
duke@435 314 continue;
adlertz@5639 315 Block *mb = get_block_for_node(mach);
duke@435 316 // Hoisting stores requires more checks for the anti-dependence case.
duke@435 317 // Give up hoisting if we have to move the store past any load.
duke@435 318 if( was_store ) {
duke@435 319 Block *b = mb; // Start searching here for a local load
duke@435 320 // mach use (faulting) trying to hoist
duke@435 321 // n might be blocker to hoisting
adlertz@5639 322 while( b != block ) {
duke@435 323 uint k;
adlertz@5639 324 for( k = 1; k < b->number_of_nodes(); k++ ) {
adlertz@5635 325 Node *n = b->get_node(k);
duke@435 326 if( n->needs_anti_dependence_check() &&
duke@435 327 n->in(LoadNode::Memory) == mach->in(StoreNode::Memory) )
duke@435 328 break; // Found anti-dependent load
duke@435 329 }
adlertz@5639 330 if( k < b->number_of_nodes() )
duke@435 331 break; // Found anti-dependent load
duke@435 332 // Make sure control does not do a merge (would have to check allpaths)
duke@435 333 if( b->num_preds() != 2 ) break;
adlertz@5639 334 b = get_block_for_node(b->pred(1)); // Move up to predecessor block
duke@435 335 }
adlertz@5639 336 if( b != block ) continue;
duke@435 337 }
duke@435 338
duke@435 339 // Make sure this memory op is not already being used for a NullCheck
duke@435 340 Node *e = mb->end();
duke@435 341 if( e->is_MachNullCheck() && e->in(1) == mach )
duke@435 342 continue; // Already being used as a NULL check
duke@435 343
duke@435 344 // Found a candidate! Pick one with least dom depth - the highest
duke@435 345 // in the dom tree should be closest to the null check.
adlertz@5639 346 if (best == NULL || get_block_for_node(mach)->_dom_depth < get_block_for_node(best)->_dom_depth) {
duke@435 347 best = mach;
duke@435 348 bidx = vidx;
duke@435 349 }
duke@435 350 }
duke@435 351 // No candidate!
adlertz@5509 352 if (best == NULL) {
adlertz@5509 353 return;
adlertz@5509 354 }
duke@435 355
duke@435 356 // ---- Found an implicit null check
duke@435 357 extern int implicit_null_checks;
duke@435 358 implicit_null_checks++;
duke@435 359
kvn@1930 360 if( is_decoden ) {
kvn@1930 361 // Check if we need to hoist decodeHeapOop_not_null first.
adlertz@5639 362 Block *valb = get_block_for_node(val);
adlertz@5639 363 if( block != valb && block->_dom_depth < valb->_dom_depth ) {
kvn@1930 364 // Hoist it up to the end of the test block.
kvn@1930 365 valb->find_remove(val);
adlertz@5639 366 block->add_inst(val);
adlertz@5639 367 map_node_to_block(val, block);
kvn@1930 368 // DecodeN on x86 may kill flags. Check for flag-killing projections
kvn@1930 369 // that also need to be hoisted.
kvn@1930 370 for (DUIterator_Fast jmax, j = val->fast_outs(jmax); j < jmax; j++) {
kvn@1930 371 Node* n = val->fast_out(j);
kvn@3040 372 if( n->is_MachProj() ) {
adlertz@5639 373 get_block_for_node(n)->find_remove(n);
adlertz@5639 374 block->add_inst(n);
adlertz@5639 375 map_node_to_block(n, block);
kvn@1930 376 }
kvn@1930 377 }
kvn@1930 378 }
kvn@1930 379 }
duke@435 380 // Hoist the memory candidate up to the end of the test block.
adlertz@5639 381 Block *old_block = get_block_for_node(best);
duke@435 382 old_block->find_remove(best);
adlertz@5639 383 block->add_inst(best);
adlertz@5639 384 map_node_to_block(best, block);
duke@435 385
duke@435 386 // Move the control dependence
adlertz@5635 387 if (best->in(0) && best->in(0) == old_block->head())
adlertz@5639 388 best->set_req(0, block->head());
duke@435 389
duke@435 390 // Check for flag-killing projections that also need to be hoisted
duke@435 391 // Should be DU safe because no edge updates.
duke@435 392 for (DUIterator_Fast jmax, j = best->fast_outs(jmax); j < jmax; j++) {
duke@435 393 Node* n = best->fast_out(j);
kvn@3040 394 if( n->is_MachProj() ) {
adlertz@5639 395 get_block_for_node(n)->find_remove(n);
adlertz@5639 396 block->add_inst(n);
adlertz@5639 397 map_node_to_block(n, block);
duke@435 398 }
duke@435 399 }
duke@435 400
duke@435 401 // proj==Op_True --> ne test; proj==Op_False --> eq test.
duke@435 402 // One of two graph shapes got matched:
duke@435 403 // (IfTrue (If (Bool NE (CmpP ptr NULL))))
duke@435 404 // (IfFalse (If (Bool EQ (CmpP ptr NULL))))
duke@435 405 // NULL checks are always branch-if-eq. If we see a IfTrue projection
duke@435 406 // then we are replacing a 'ne' test with a 'eq' NULL check test.
duke@435 407 // We need to flip the projections to keep the same semantics.
duke@435 408 if( proj->Opcode() == Op_IfTrue ) {
duke@435 409 // Swap order of projections in basic block to swap branch targets
adlertz@5639 410 Node *tmp1 = block->get_node(block->end_idx()+1);
adlertz@5639 411 Node *tmp2 = block->get_node(block->end_idx()+2);
adlertz@5639 412 block->map_node(tmp2, block->end_idx()+1);
adlertz@5639 413 block->map_node(tmp1, block->end_idx()+2);
kvn@4115 414 Node *tmp = new (C) Node(C->top()); // Use not NULL input
duke@435 415 tmp1->replace_by(tmp);
duke@435 416 tmp2->replace_by(tmp1);
duke@435 417 tmp->replace_by(tmp2);
duke@435 418 tmp->destruct();
duke@435 419 }
duke@435 420
duke@435 421 // Remove the existing null check; use a new implicit null check instead.
duke@435 422 // Since schedule-local needs precise def-use info, we need to correct
duke@435 423 // it as well.
duke@435 424 Node *old_tst = proj->in(0);
duke@435 425 MachNode *nul_chk = new (C) MachNullCheckNode(old_tst->in(0),best,bidx);
adlertz@5639 426 block->map_node(nul_chk, block->end_idx());
adlertz@5639 427 map_node_to_block(nul_chk, block);
duke@435 428 // Redirect users of old_test to nul_chk
duke@435 429 for (DUIterator_Last i2min, i2 = old_tst->last_outs(i2min); i2 >= i2min; --i2)
duke@435 430 old_tst->last_out(i2)->set_req(0, nul_chk);
duke@435 431 // Clean-up any dead code
thartmann@7559 432 for (uint i3 = 0; i3 < old_tst->req(); i3++) {
thartmann@7559 433 Node* in = old_tst->in(i3);
duke@435 434 old_tst->set_req(i3, NULL);
thartmann@7559 435 if (in->outcnt() == 0) {
thartmann@7559 436 // Remove dead input node
thartmann@7559 437 in->disconnect_inputs(NULL, C);
thartmann@7559 438 block->find_remove(in);
thartmann@7559 439 }
thartmann@7559 440 }
duke@435 441
adlertz@5639 442 latency_from_uses(nul_chk);
adlertz@5639 443 latency_from_uses(best);
duke@435 444 }
duke@435 445
duke@435 446
duke@435 447 //------------------------------select-----------------------------------------
duke@435 448 // Select a nice fellow from the worklist to schedule next. If there is only
duke@435 449 // one choice, then use it. Projections take top priority for correctness
duke@435 450 // reasons - if I see a projection, then it is next. There are a number of
duke@435 451 // other special cases, for instructions that consume condition codes, et al.
duke@435 452 // These are chosen immediately. Some instructions are required to immediately
duke@435 453 // precede the last instruction in the block, and these are taken last. Of the
duke@435 454 // remaining cases (most), choose the instruction with the greatest latency
duke@435 455 // (that is, the most number of pseudo-cycles required to the end of the
duke@435 456 // routine). If there is a tie, choose the instruction with the most inputs.
adlertz@5639 457 Node* PhaseCFG::select(Block* block, Node_List &worklist, GrowableArray<int> &ready_cnt, VectorSet &next_call, uint sched_slot) {
duke@435 458
duke@435 459 // If only a single entry on the stack, use it
duke@435 460 uint cnt = worklist.size();
duke@435 461 if (cnt == 1) {
duke@435 462 Node *n = worklist[0];
duke@435 463 worklist.map(0,worklist.pop());
duke@435 464 return n;
duke@435 465 }
duke@435 466
duke@435 467 uint choice = 0; // Bigger is most important
duke@435 468 uint latency = 0; // Bigger is scheduled first
duke@435 469 uint score = 0; // Bigger is better
kvn@688 470 int idx = -1; // Index in worklist
shade@4691 471 int cand_cnt = 0; // Candidate count
duke@435 472
duke@435 473 for( uint i=0; i<cnt; i++ ) { // Inspect entire worklist
duke@435 474 // Order in worklist is used to break ties.
duke@435 475 // See caller for how this is used to delay scheduling
duke@435 476 // of induction variable increments to after the other
duke@435 477 // uses of the phi are scheduled.
duke@435 478 Node *n = worklist[i]; // Get Node on worklist
duke@435 479
duke@435 480 int iop = n->is_Mach() ? n->as_Mach()->ideal_Opcode() : 0;
duke@435 481 if( n->is_Proj() || // Projections always win
duke@435 482 n->Opcode()== Op_Con || // So does constant 'Top'
duke@435 483 iop == Op_CreateEx || // Create-exception must start block
duke@435 484 iop == Op_CheckCastPP
duke@435 485 ) {
kvn@7332 486 worklist.map(i,worklist.pop());
duke@435 487 return n;
duke@435 488 }
duke@435 489
duke@435 490 // Final call in a block must be adjacent to 'catch'
adlertz@5639 491 Node *e = block->end();
duke@435 492 if( e->is_Catch() && e->in(0)->in(0) == n )
duke@435 493 continue;
duke@435 494
duke@435 495 // Memory op for an implicit null check has to be at the end of the block
duke@435 496 if( e->is_MachNullCheck() && e->in(1) == n )
duke@435 497 continue;
duke@435 498
kvn@3882 499 // Schedule IV increment last.
kvn@3882 500 if (e->is_Mach() && e->as_Mach()->ideal_Opcode() == Op_CountedLoopEnd &&
kvn@3882 501 e->in(1)->in(1) == n && n->is_iteratively_computed())
kvn@3882 502 continue;
kvn@3882 503
duke@435 504 uint n_choice = 2;
duke@435 505
duke@435 506 // See if this instruction is consumed by a branch. If so, then (as the
duke@435 507 // branch is the last instruction in the basic block) force it to the
duke@435 508 // end of the basic block
duke@435 509 if ( must_clone[iop] ) {
duke@435 510 // See if any use is a branch
duke@435 511 bool found_machif = false;
duke@435 512
duke@435 513 for (DUIterator_Fast jmax, j = n->fast_outs(jmax); j < jmax; j++) {
duke@435 514 Node* use = n->fast_out(j);
duke@435 515
duke@435 516 // The use is a conditional branch, make them adjacent
adlertz@5639 517 if (use->is_MachIf() && get_block_for_node(use) == block) {
duke@435 518 found_machif = true;
duke@435 519 break;
duke@435 520 }
duke@435 521
duke@435 522 // More than this instruction pending for successor to be ready,
duke@435 523 // don't choose this if other opportunities are ready
roland@3447 524 if (ready_cnt.at(use->_idx) > 1)
duke@435 525 n_choice = 1;
duke@435 526 }
duke@435 527
duke@435 528 // loop terminated, prefer not to use this instruction
duke@435 529 if (found_machif)
duke@435 530 continue;
duke@435 531 }
duke@435 532
duke@435 533 // See if this has a predecessor that is "must_clone", i.e. sets the
duke@435 534 // condition code. If so, choose this first
duke@435 535 for (uint j = 0; j < n->req() ; j++) {
duke@435 536 Node *inn = n->in(j);
duke@435 537 if (inn) {
duke@435 538 if (inn->is_Mach() && must_clone[inn->as_Mach()->ideal_Opcode()] ) {
duke@435 539 n_choice = 3;
duke@435 540 break;
duke@435 541 }
duke@435 542 }
duke@435 543 }
duke@435 544
duke@435 545 // MachTemps should be scheduled last so they are near their uses
duke@435 546 if (n->is_MachTemp()) {
duke@435 547 n_choice = 1;
duke@435 548 }
duke@435 549
adlertz@5639 550 uint n_latency = get_latency_for_node(n);
duke@435 551 uint n_score = n->req(); // Many inputs get high score to break ties
duke@435 552
duke@435 553 // Keep best latency found
shade@4691 554 cand_cnt++;
shade@4691 555 if (choice < n_choice ||
shade@4691 556 (choice == n_choice &&
shade@4691 557 ((StressLCM && Compile::randomized_select(cand_cnt)) ||
shade@4691 558 (!StressLCM &&
shade@4691 559 (latency < n_latency ||
shade@4691 560 (latency == n_latency &&
shade@4691 561 (score < n_score))))))) {
duke@435 562 choice = n_choice;
duke@435 563 latency = n_latency;
duke@435 564 score = n_score;
duke@435 565 idx = i; // Also keep index in worklist
duke@435 566 }
duke@435 567 } // End of for all ready nodes in worklist
duke@435 568
kvn@688 569 assert(idx >= 0, "index should be set");
kvn@688 570 Node *n = worklist[(uint)idx]; // Get the winner
duke@435 571
kvn@7332 572 worklist.map((uint)idx, worklist.pop()); // Compress worklist
duke@435 573 return n;
duke@435 574 }
duke@435 575
duke@435 576
duke@435 577 //------------------------------set_next_call----------------------------------
adlertz@5639 578 void PhaseCFG::set_next_call(Block* block, Node* n, VectorSet& next_call) {
duke@435 579 if( next_call.test_set(n->_idx) ) return;
duke@435 580 for( uint i=0; i<n->len(); i++ ) {
duke@435 581 Node *m = n->in(i);
duke@435 582 if( !m ) continue; // must see all nodes in block that precede call
adlertz@5639 583 if (get_block_for_node(m) == block) {
adlertz@5639 584 set_next_call(block, m, next_call);
adlertz@5509 585 }
duke@435 586 }
duke@435 587 }
duke@435 588
duke@435 589 //------------------------------needed_for_next_call---------------------------
duke@435 590 // Set the flag 'next_call' for each Node that is needed for the next call to
duke@435 591 // be scheduled. This flag lets me bias scheduling so Nodes needed for the
duke@435 592 // next subroutine call get priority - basically it moves things NOT needed
duke@435 593 // for the next call till after the call. This prevents me from trying to
duke@435 594 // carry lots of stuff live across a call.
adlertz@5639 595 void PhaseCFG::needed_for_next_call(Block* block, Node* this_call, VectorSet& next_call) {
duke@435 596 // Find the next control-defining Node in this block
duke@435 597 Node* call = NULL;
duke@435 598 for (DUIterator_Fast imax, i = this_call->fast_outs(imax); i < imax; i++) {
duke@435 599 Node* m = this_call->fast_out(i);
adlertz@5642 600 if (get_block_for_node(m) == block && // Local-block user
duke@435 601 m != this_call && // Not self-start node
adlertz@5642 602 m->is_MachCall()) {
duke@435 603 call = m;
duke@435 604 break;
adlertz@5642 605 }
duke@435 606 }
duke@435 607 if (call == NULL) return; // No next call (e.g., block end is near)
duke@435 608 // Set next-call for all inputs to this call
adlertz@5639 609 set_next_call(block, call, next_call);
duke@435 610 }
duke@435 611
roland@3316 612 //------------------------------add_call_kills-------------------------------------
adlertz@5639 613 // helper function that adds caller save registers to MachProjNode
adlertz@5639 614 static void add_call_kills(MachProjNode *proj, RegMask& regs, const char* save_policy, bool exclude_soe) {
roland@3316 615 // Fill in the kill mask for the call
roland@3316 616 for( OptoReg::Name r = OptoReg::Name(0); r < _last_Mach_Reg; r=OptoReg::add(r,1) ) {
roland@3316 617 if( !regs.Member(r) ) { // Not already defined by the call
roland@3316 618 // Save-on-call register?
roland@3316 619 if ((save_policy[r] == 'C') ||
roland@3316 620 (save_policy[r] == 'A') ||
roland@3316 621 ((save_policy[r] == 'E') && exclude_soe)) {
roland@3316 622 proj->_rout.Insert(r);
roland@3316 623 }
roland@3316 624 }
roland@3316 625 }
roland@3316 626 }
roland@3316 627
roland@3316 628
duke@435 629 //------------------------------sched_call-------------------------------------
adlertz@5639 630 uint PhaseCFG::sched_call(Block* block, uint node_cnt, Node_List& worklist, GrowableArray<int>& ready_cnt, MachCallNode* mcall, VectorSet& next_call) {
duke@435 631 RegMask regs;
duke@435 632
duke@435 633 // Schedule all the users of the call right now. All the users are
duke@435 634 // projection Nodes, so they must be scheduled next to the call.
duke@435 635 // Collect all the defined registers.
duke@435 636 for (DUIterator_Fast imax, i = mcall->fast_outs(imax); i < imax; i++) {
duke@435 637 Node* n = mcall->fast_out(i);
kvn@3040 638 assert( n->is_MachProj(), "" );
roland@3447 639 int n_cnt = ready_cnt.at(n->_idx)-1;
roland@3447 640 ready_cnt.at_put(n->_idx, n_cnt);
roland@3447 641 assert( n_cnt == 0, "" );
duke@435 642 // Schedule next to call
adlertz@5639 643 block->map_node(n, node_cnt++);
duke@435 644 // Collect defined registers
duke@435 645 regs.OR(n->out_RegMask());
duke@435 646 // Check for scheduling the next control-definer
duke@435 647 if( n->bottom_type() == Type::CONTROL )
duke@435 648 // Warm up next pile of heuristic bits
adlertz@5639 649 needed_for_next_call(block, n, next_call);
duke@435 650
duke@435 651 // Children of projections are now all ready
duke@435 652 for (DUIterator_Fast jmax, j = n->fast_outs(jmax); j < jmax; j++) {
duke@435 653 Node* m = n->fast_out(j); // Get user
adlertz@5639 654 if(get_block_for_node(m) != block) {
adlertz@5509 655 continue;
adlertz@5509 656 }
duke@435 657 if( m->is_Phi() ) continue;
roland@3447 658 int m_cnt = ready_cnt.at(m->_idx)-1;
roland@3447 659 ready_cnt.at_put(m->_idx, m_cnt);
roland@3447 660 if( m_cnt == 0 )
duke@435 661 worklist.push(m);
duke@435 662 }
duke@435 663
duke@435 664 }
duke@435 665
duke@435 666 // Act as if the call defines the Frame Pointer.
duke@435 667 // Certainly the FP is alive and well after the call.
adlertz@5639 668 regs.Insert(_matcher.c_frame_pointer());
duke@435 669
duke@435 670 // Set all registers killed and not already defined by the call.
duke@435 671 uint r_cnt = mcall->tf()->range()->cnt();
duke@435 672 int op = mcall->ideal_Opcode();
adlertz@5639 673 MachProjNode *proj = new (C) MachProjNode( mcall, r_cnt+1, RegMask::Empty, MachProjNode::fat_proj );
adlertz@5639 674 map_node_to_block(proj, block);
adlertz@5639 675 block->insert_node(proj, node_cnt++);
duke@435 676
duke@435 677 // Select the right register save policy.
duke@435 678 const char * save_policy;
duke@435 679 switch (op) {
duke@435 680 case Op_CallRuntime:
duke@435 681 case Op_CallLeaf:
duke@435 682 case Op_CallLeafNoFP:
duke@435 683 // Calling C code so use C calling convention
adlertz@5639 684 save_policy = _matcher._c_reg_save_policy;
duke@435 685 break;
duke@435 686
duke@435 687 case Op_CallStaticJava:
duke@435 688 case Op_CallDynamicJava:
duke@435 689 // Calling Java code so use Java calling convention
adlertz@5639 690 save_policy = _matcher._register_save_policy;
duke@435 691 break;
duke@435 692
duke@435 693 default:
duke@435 694 ShouldNotReachHere();
duke@435 695 }
duke@435 696
duke@435 697 // When using CallRuntime mark SOE registers as killed by the call
duke@435 698 // so values that could show up in the RegisterMap aren't live in a
duke@435 699 // callee saved register since the register wouldn't know where to
duke@435 700 // find them. CallLeaf and CallLeafNoFP are ok because they can't
duke@435 701 // have debug info on them. Strictly speaking this only needs to be
duke@435 702 // done for oops since idealreg2debugmask takes care of debug info
duke@435 703 // references but there no way to handle oops differently than other
duke@435 704 // pointers as far as the kill mask goes.
duke@435 705 bool exclude_soe = op == Op_CallRuntime;
duke@435 706
twisti@1572 707 // If the call is a MethodHandle invoke, we need to exclude the
twisti@1572 708 // register which is used to save the SP value over MH invokes from
twisti@1572 709 // the mask. Otherwise this register could be used for
twisti@1572 710 // deoptimization information.
twisti@1572 711 if (op == Op_CallStaticJava) {
twisti@1572 712 MachCallStaticJavaNode* mcallstaticjava = (MachCallStaticJavaNode*) mcall;
twisti@1572 713 if (mcallstaticjava->_method_handle_invoke)
twisti@1572 714 proj->_rout.OR(Matcher::method_handle_invoke_SP_save_mask());
twisti@1572 715 }
twisti@1572 716
roland@3316 717 add_call_kills(proj, regs, save_policy, exclude_soe);
duke@435 718
duke@435 719 return node_cnt;
duke@435 720 }
duke@435 721
duke@435 722
duke@435 723 //------------------------------schedule_local---------------------------------
duke@435 724 // Topological sort within a block. Someday become a real scheduler.
adlertz@5639 725 bool PhaseCFG::schedule_local(Block* block, GrowableArray<int>& ready_cnt, VectorSet& next_call) {
duke@435 726 // Already "sorted" are the block start Node (as the first entry), and
duke@435 727 // the block-ending Node and any trailing control projections. We leave
duke@435 728 // these alone. PhiNodes and ParmNodes are made to follow the block start
duke@435 729 // Node. Everything else gets topo-sorted.
duke@435 730
duke@435 731 #ifndef PRODUCT
adlertz@5639 732 if (trace_opto_pipelining()) {
adlertz@5639 733 tty->print_cr("# --- schedule_local B%d, before: ---", block->_pre_order);
adlertz@5639 734 for (uint i = 0;i < block->number_of_nodes(); i++) {
duke@435 735 tty->print("# ");
adlertz@5639 736 block->get_node(i)->fast_dump();
duke@435 737 }
duke@435 738 tty->print_cr("#");
duke@435 739 }
duke@435 740 #endif
duke@435 741
duke@435 742 // RootNode is already sorted
adlertz@5639 743 if (block->number_of_nodes() == 1) {
adlertz@5639 744 return true;
adlertz@5639 745 }
duke@435 746
duke@435 747 // Move PhiNodes and ParmNodes from 1 to cnt up to the start
adlertz@5639 748 uint node_cnt = block->end_idx();
duke@435 749 uint phi_cnt = 1;
duke@435 750 uint i;
duke@435 751 for( i = 1; i<node_cnt; i++ ) { // Scan for Phi
adlertz@5639 752 Node *n = block->get_node(i);
duke@435 753 if( n->is_Phi() || // Found a PhiNode or ParmNode
adlertz@5639 754 (n->is_Proj() && n->in(0) == block->head()) ) {
duke@435 755 // Move guy at 'phi_cnt' to the end; makes a hole at phi_cnt
adlertz@5639 756 block->map_node(block->get_node(phi_cnt), i);
adlertz@5639 757 block->map_node(n, phi_cnt++); // swap Phi/Parm up front
duke@435 758 } else { // All others
duke@435 759 // Count block-local inputs to 'n'
duke@435 760 uint cnt = n->len(); // Input count
duke@435 761 uint local = 0;
duke@435 762 for( uint j=0; j<cnt; j++ ) {
duke@435 763 Node *m = n->in(j);
adlertz@5639 764 if( m && get_block_for_node(m) == block && !m->is_top() )
duke@435 765 local++; // One more block-local input
duke@435 766 }
roland@3447 767 ready_cnt.at_put(n->_idx, local); // Count em up
duke@435 768
never@2780 769 #ifdef ASSERT
never@2780 770 if( UseConcMarkSweepGC || UseG1GC ) {
never@2780 771 if( n->is_Mach() && n->as_Mach()->ideal_Opcode() == Op_StoreCM ) {
never@2780 772 // Check the precedence edges
never@2780 773 for (uint prec = n->req(); prec < n->len(); prec++) {
never@2780 774 Node* oop_store = n->in(prec);
never@2780 775 if (oop_store != NULL) {
adlertz@5639 776 assert(get_block_for_node(oop_store)->_dom_depth <= block->_dom_depth, "oop_store must dominate card-mark");
never@2780 777 }
never@2780 778 }
never@2780 779 }
never@2780 780 }
never@2780 781 #endif
never@2780 782
duke@435 783 // A few node types require changing a required edge to a precedence edge
duke@435 784 // before allocation.
kvn@1535 785 if( n->is_Mach() && n->req() > TypeFunc::Parms &&
kvn@1535 786 (n->as_Mach()->ideal_Opcode() == Op_MemBarAcquire ||
kvn@1535 787 n->as_Mach()->ideal_Opcode() == Op_MemBarVolatile) ) {
kvn@688 788 // MemBarAcquire could be created without Precedent edge.
kvn@688 789 // del_req() replaces the specified edge with the last input edge
kvn@688 790 // and then removes the last edge. If the specified edge > number of
kvn@688 791 // edges the last edge will be moved outside of the input edges array
kvn@688 792 // and the edge will be lost. This is why this code should be
kvn@688 793 // executed only when Precedent (== TypeFunc::Parms) edge is present.
duke@435 794 Node *x = n->in(TypeFunc::Parms);
duke@435 795 n->del_req(TypeFunc::Parms);
duke@435 796 n->add_prec(x);
duke@435 797 }
duke@435 798 }
duke@435 799 }
adlertz@5639 800 for(uint i2=i; i2< block->number_of_nodes(); i2++ ) // Trailing guys get zapped count
adlertz@5639 801 ready_cnt.at_put(block->get_node(i2)->_idx, 0);
duke@435 802
duke@435 803 // All the prescheduled guys do not hold back internal nodes
duke@435 804 uint i3;
duke@435 805 for(i3 = 0; i3<phi_cnt; i3++ ) { // For all pre-scheduled
adlertz@5639 806 Node *n = block->get_node(i3); // Get pre-scheduled
duke@435 807 for (DUIterator_Fast jmax, j = n->fast_outs(jmax); j < jmax; j++) {
duke@435 808 Node* m = n->fast_out(j);
adlertz@5639 809 if (get_block_for_node(m) == block) { // Local-block user
roland@3447 810 int m_cnt = ready_cnt.at(m->_idx)-1;
roland@3447 811 ready_cnt.at_put(m->_idx, m_cnt); // Fix ready count
roland@3447 812 }
duke@435 813 }
duke@435 814 }
duke@435 815
duke@435 816 Node_List delay;
duke@435 817 // Make a worklist
duke@435 818 Node_List worklist;
duke@435 819 for(uint i4=i3; i4<node_cnt; i4++ ) { // Put ready guys on worklist
adlertz@5639 820 Node *m = block->get_node(i4);
roland@3447 821 if( !ready_cnt.at(m->_idx) ) { // Zero ready count?
duke@435 822 if (m->is_iteratively_computed()) {
duke@435 823 // Push induction variable increments last to allow other uses
duke@435 824 // of the phi to be scheduled first. The select() method breaks
duke@435 825 // ties in scheduling by worklist order.
duke@435 826 delay.push(m);
never@560 827 } else if (m->is_Mach() && m->as_Mach()->ideal_Opcode() == Op_CreateEx) {
never@560 828 // Force the CreateEx to the top of the list so it's processed
never@560 829 // first and ends up at the start of the block.
never@560 830 worklist.insert(0, m);
duke@435 831 } else {
duke@435 832 worklist.push(m); // Then on to worklist!
duke@435 833 }
duke@435 834 }
duke@435 835 }
duke@435 836 while (delay.size()) {
duke@435 837 Node* d = delay.pop();
duke@435 838 worklist.push(d);
duke@435 839 }
duke@435 840
duke@435 841 // Warm up the 'next_call' heuristic bits
adlertz@5639 842 needed_for_next_call(block, block->head(), next_call);
duke@435 843
duke@435 844 #ifndef PRODUCT
adlertz@5639 845 if (trace_opto_pipelining()) {
adlertz@5639 846 for (uint j=0; j< block->number_of_nodes(); j++) {
adlertz@5639 847 Node *n = block->get_node(j);
duke@435 848 int idx = n->_idx;
roland@3447 849 tty->print("# ready cnt:%3d ", ready_cnt.at(idx));
adlertz@5639 850 tty->print("latency:%3d ", get_latency_for_node(n));
duke@435 851 tty->print("%4d: %s\n", idx, n->Name());
duke@435 852 }
duke@435 853 }
duke@435 854 #endif
duke@435 855
roland@3447 856 uint max_idx = (uint)ready_cnt.length();
duke@435 857 // Pull from worklist and schedule
duke@435 858 while( worklist.size() ) { // Worklist is not ready
duke@435 859
duke@435 860 #ifndef PRODUCT
adlertz@5639 861 if (trace_opto_pipelining()) {
duke@435 862 tty->print("# ready list:");
duke@435 863 for( uint i=0; i<worklist.size(); i++ ) { // Inspect entire worklist
duke@435 864 Node *n = worklist[i]; // Get Node on worklist
duke@435 865 tty->print(" %d", n->_idx);
duke@435 866 }
duke@435 867 tty->cr();
duke@435 868 }
duke@435 869 #endif
duke@435 870
duke@435 871 // Select and pop a ready guy from worklist
adlertz@5639 872 Node* n = select(block, worklist, ready_cnt, next_call, phi_cnt);
adlertz@5639 873 block->map_node(n, phi_cnt++); // Schedule him next
duke@435 874
duke@435 875 #ifndef PRODUCT
adlertz@5639 876 if (trace_opto_pipelining()) {
duke@435 877 tty->print("# select %d: %s", n->_idx, n->Name());
adlertz@5639 878 tty->print(", latency:%d", get_latency_for_node(n));
duke@435 879 n->dump();
duke@435 880 if (Verbose) {
duke@435 881 tty->print("# ready list:");
duke@435 882 for( uint i=0; i<worklist.size(); i++ ) { // Inspect entire worklist
duke@435 883 Node *n = worklist[i]; // Get Node on worklist
duke@435 884 tty->print(" %d", n->_idx);
duke@435 885 }
duke@435 886 tty->cr();
duke@435 887 }
duke@435 888 }
duke@435 889
duke@435 890 #endif
duke@435 891 if( n->is_MachCall() ) {
duke@435 892 MachCallNode *mcall = n->as_MachCall();
adlertz@5639 893 phi_cnt = sched_call(block, phi_cnt, worklist, ready_cnt, mcall, next_call);
duke@435 894 continue;
duke@435 895 }
roland@3316 896
roland@3316 897 if (n->is_Mach() && n->as_Mach()->has_call()) {
roland@3316 898 RegMask regs;
adlertz@5639 899 regs.Insert(_matcher.c_frame_pointer());
roland@3316 900 regs.OR(n->out_RegMask());
roland@3316 901
adlertz@5639 902 MachProjNode *proj = new (C) MachProjNode( n, 1, RegMask::Empty, MachProjNode::fat_proj );
adlertz@5639 903 map_node_to_block(proj, block);
adlertz@5639 904 block->insert_node(proj, phi_cnt++);
roland@3316 905
adlertz@5639 906 add_call_kills(proj, regs, _matcher._c_reg_save_policy, false);
roland@3316 907 }
roland@3316 908
duke@435 909 // Children are now all ready
duke@435 910 for (DUIterator_Fast i5max, i5 = n->fast_outs(i5max); i5 < i5max; i5++) {
duke@435 911 Node* m = n->fast_out(i5); // Get user
adlertz@5639 912 if (get_block_for_node(m) != block) {
adlertz@5509 913 continue;
adlertz@5509 914 }
duke@435 915 if( m->is_Phi() ) continue;
roland@3447 916 if (m->_idx >= max_idx) { // new node, skip it
roland@3316 917 assert(m->is_MachProj() && n->is_Mach() && n->as_Mach()->has_call(), "unexpected node types");
roland@3316 918 continue;
roland@3316 919 }
roland@3447 920 int m_cnt = ready_cnt.at(m->_idx)-1;
roland@3447 921 ready_cnt.at_put(m->_idx, m_cnt);
roland@3447 922 if( m_cnt == 0 )
duke@435 923 worklist.push(m);
duke@435 924 }
duke@435 925 }
duke@435 926
adlertz@5639 927 if( phi_cnt != block->end_idx() ) {
duke@435 928 // did not schedule all. Retry, Bailout, or Die
duke@435 929 if (C->subsume_loads() == true && !C->failing()) {
duke@435 930 // Retry with subsume_loads == false
duke@435 931 // If this is the first failure, the sentinel string will "stick"
duke@435 932 // to the Compile object, and the C2Compiler will see it and retry.
duke@435 933 C->record_failure(C2Compiler::retry_no_subsuming_loads());
duke@435 934 }
duke@435 935 // assert( phi_cnt == end_idx(), "did not schedule all" );
duke@435 936 return false;
duke@435 937 }
duke@435 938
duke@435 939 #ifndef PRODUCT
adlertz@5639 940 if (trace_opto_pipelining()) {
duke@435 941 tty->print_cr("#");
duke@435 942 tty->print_cr("# after schedule_local");
adlertz@5639 943 for (uint i = 0;i < block->number_of_nodes();i++) {
duke@435 944 tty->print("# ");
adlertz@5639 945 block->get_node(i)->fast_dump();
duke@435 946 }
duke@435 947 tty->cr();
duke@435 948 }
duke@435 949 #endif
duke@435 950
duke@435 951
duke@435 952 return true;
duke@435 953 }
duke@435 954
duke@435 955 //--------------------------catch_cleanup_fix_all_inputs-----------------------
duke@435 956 static void catch_cleanup_fix_all_inputs(Node *use, Node *old_def, Node *new_def) {
duke@435 957 for (uint l = 0; l < use->len(); l++) {
duke@435 958 if (use->in(l) == old_def) {
duke@435 959 if (l < use->req()) {
duke@435 960 use->set_req(l, new_def);
duke@435 961 } else {
duke@435 962 use->rm_prec(l);
duke@435 963 use->add_prec(new_def);
duke@435 964 l--;
duke@435 965 }
duke@435 966 }
duke@435 967 }
duke@435 968 }
duke@435 969
duke@435 970 //------------------------------catch_cleanup_find_cloned_def------------------
adlertz@5639 971 Node* PhaseCFG::catch_cleanup_find_cloned_def(Block *use_blk, Node *def, Block *def_blk, int n_clone_idx) {
duke@435 972 assert( use_blk != def_blk, "Inter-block cleanup only");
duke@435 973
duke@435 974 // The use is some block below the Catch. Find and return the clone of the def
duke@435 975 // that dominates the use. If there is no clone in a dominating block, then
duke@435 976 // create a phi for the def in a dominating block.
duke@435 977
duke@435 978 // Find which successor block dominates this use. The successor
duke@435 979 // blocks must all be single-entry (from the Catch only; I will have
duke@435 980 // split blocks to make this so), hence they all dominate.
duke@435 981 while( use_blk->_dom_depth > def_blk->_dom_depth+1 )
duke@435 982 use_blk = use_blk->_idom;
duke@435 983
duke@435 984 // Find the successor
duke@435 985 Node *fixup = NULL;
duke@435 986
duke@435 987 uint j;
duke@435 988 for( j = 0; j < def_blk->_num_succs; j++ )
duke@435 989 if( use_blk == def_blk->_succs[j] )
duke@435 990 break;
duke@435 991
duke@435 992 if( j == def_blk->_num_succs ) {
duke@435 993 // Block at same level in dom-tree is not a successor. It needs a
duke@435 994 // PhiNode, the PhiNode uses from the def and IT's uses need fixup.
duke@435 995 Node_Array inputs = new Node_List(Thread::current()->resource_area());
duke@435 996 for(uint k = 1; k < use_blk->num_preds(); k++) {
adlertz@5639 997 Block* block = get_block_for_node(use_blk->pred(k));
adlertz@5639 998 inputs.map(k, catch_cleanup_find_cloned_def(block, def, def_blk, n_clone_idx));
duke@435 999 }
duke@435 1000
duke@435 1001 // Check to see if the use_blk already has an identical phi inserted.
duke@435 1002 // If it exists, it will be at the first position since all uses of a
duke@435 1003 // def are processed together.
adlertz@5635 1004 Node *phi = use_blk->get_node(1);
duke@435 1005 if( phi->is_Phi() ) {
duke@435 1006 fixup = phi;
duke@435 1007 for (uint k = 1; k < use_blk->num_preds(); k++) {
duke@435 1008 if (phi->in(k) != inputs[k]) {
duke@435 1009 // Not a match
duke@435 1010 fixup = NULL;
duke@435 1011 break;
duke@435 1012 }
duke@435 1013 }
duke@435 1014 }
duke@435 1015
duke@435 1016 // If an existing PhiNode was not found, make a new one.
duke@435 1017 if (fixup == NULL) {
duke@435 1018 Node *new_phi = PhiNode::make(use_blk->head(), def);
adlertz@5635 1019 use_blk->insert_node(new_phi, 1);
adlertz@5639 1020 map_node_to_block(new_phi, use_blk);
duke@435 1021 for (uint k = 1; k < use_blk->num_preds(); k++) {
duke@435 1022 new_phi->set_req(k, inputs[k]);
duke@435 1023 }
duke@435 1024 fixup = new_phi;
duke@435 1025 }
duke@435 1026
duke@435 1027 } else {
duke@435 1028 // Found the use just below the Catch. Make it use the clone.
adlertz@5635 1029 fixup = use_blk->get_node(n_clone_idx);
duke@435 1030 }
duke@435 1031
duke@435 1032 return fixup;
duke@435 1033 }
duke@435 1034
duke@435 1035 //--------------------------catch_cleanup_intra_block--------------------------
duke@435 1036 // Fix all input edges in use that reference "def". The use is in the same
duke@435 1037 // block as the def and both have been cloned in each successor block.
duke@435 1038 static void catch_cleanup_intra_block(Node *use, Node *def, Block *blk, int beg, int n_clone_idx) {
duke@435 1039
duke@435 1040 // Both the use and def have been cloned. For each successor block,
duke@435 1041 // get the clone of the use, and make its input the clone of the def
duke@435 1042 // found in that block.
duke@435 1043
duke@435 1044 uint use_idx = blk->find_node(use);
duke@435 1045 uint offset_idx = use_idx - beg;
duke@435 1046 for( uint k = 0; k < blk->_num_succs; k++ ) {
duke@435 1047 // Get clone in each successor block
duke@435 1048 Block *sb = blk->_succs[k];
adlertz@5635 1049 Node *clone = sb->get_node(offset_idx+1);
duke@435 1050 assert( clone->Opcode() == use->Opcode(), "" );
duke@435 1051
duke@435 1052 // Make use-clone reference the def-clone
adlertz@5635 1053 catch_cleanup_fix_all_inputs(clone, def, sb->get_node(n_clone_idx));
duke@435 1054 }
duke@435 1055 }
duke@435 1056
duke@435 1057 //------------------------------catch_cleanup_inter_block---------------------
duke@435 1058 // Fix all input edges in use that reference "def". The use is in a different
duke@435 1059 // block than the def.
adlertz@5639 1060 void PhaseCFG::catch_cleanup_inter_block(Node *use, Block *use_blk, Node *def, Block *def_blk, int n_clone_idx) {
duke@435 1061 if( !use_blk ) return; // Can happen if the use is a precedence edge
duke@435 1062
adlertz@5639 1063 Node *new_def = catch_cleanup_find_cloned_def(use_blk, def, def_blk, n_clone_idx);
duke@435 1064 catch_cleanup_fix_all_inputs(use, def, new_def);
duke@435 1065 }
duke@435 1066
duke@435 1067 //------------------------------call_catch_cleanup-----------------------------
duke@435 1068 // If we inserted any instructions between a Call and his CatchNode,
duke@435 1069 // clone the instructions on all paths below the Catch.
adlertz@5639 1070 void PhaseCFG::call_catch_cleanup(Block* block) {
duke@435 1071
duke@435 1072 // End of region to clone
adlertz@5639 1073 uint end = block->end_idx();
adlertz@5639 1074 if( !block->get_node(end)->is_Catch() ) return;
duke@435 1075 // Start of region to clone
duke@435 1076 uint beg = end;
adlertz@5639 1077 while(!block->get_node(beg-1)->is_MachProj() ||
adlertz@5639 1078 !block->get_node(beg-1)->in(0)->is_MachCall() ) {
duke@435 1079 beg--;
duke@435 1080 assert(beg > 0,"Catch cleanup walking beyond block boundary");
duke@435 1081 }
duke@435 1082 // Range of inserted instructions is [beg, end)
duke@435 1083 if( beg == end ) return;
duke@435 1084
duke@435 1085 // Clone along all Catch output paths. Clone area between the 'beg' and
duke@435 1086 // 'end' indices.
adlertz@5639 1087 for( uint i = 0; i < block->_num_succs; i++ ) {
adlertz@5639 1088 Block *sb = block->_succs[i];
duke@435 1089 // Clone the entire area; ignoring the edge fixup for now.
duke@435 1090 for( uint j = end; j > beg; j-- ) {
kvn@2048 1091 // It is safe here to clone a node with anti_dependence
kvn@2048 1092 // since clones dominate on each path.
adlertz@5639 1093 Node *clone = block->get_node(j-1)->clone();
adlertz@5635 1094 sb->insert_node(clone, 1);
adlertz@5639 1095 map_node_to_block(clone, sb);
duke@435 1096 }
duke@435 1097 }
duke@435 1098
duke@435 1099
duke@435 1100 // Fixup edges. Check the def-use info per cloned Node
duke@435 1101 for(uint i2 = beg; i2 < end; i2++ ) {
duke@435 1102 uint n_clone_idx = i2-beg+1; // Index of clone of n in each successor block
adlertz@5639 1103 Node *n = block->get_node(i2); // Node that got cloned
duke@435 1104 // Need DU safe iterator because of edge manipulation in calls.
duke@435 1105 Unique_Node_List *out = new Unique_Node_List(Thread::current()->resource_area());
duke@435 1106 for (DUIterator_Fast j1max, j1 = n->fast_outs(j1max); j1 < j1max; j1++) {
duke@435 1107 out->push(n->fast_out(j1));
duke@435 1108 }
duke@435 1109 uint max = out->size();
duke@435 1110 for (uint j = 0; j < max; j++) {// For all users
duke@435 1111 Node *use = out->pop();
adlertz@5639 1112 Block *buse = get_block_for_node(use);
duke@435 1113 if( use->is_Phi() ) {
duke@435 1114 for( uint k = 1; k < use->req(); k++ )
duke@435 1115 if( use->in(k) == n ) {
adlertz@5639 1116 Block* b = get_block_for_node(buse->pred(k));
adlertz@5639 1117 Node *fixup = catch_cleanup_find_cloned_def(b, n, block, n_clone_idx);
duke@435 1118 use->set_req(k, fixup);
duke@435 1119 }
duke@435 1120 } else {
adlertz@5639 1121 if (block == buse) {
adlertz@5639 1122 catch_cleanup_intra_block(use, n, block, beg, n_clone_idx);
duke@435 1123 } else {
adlertz@5639 1124 catch_cleanup_inter_block(use, buse, n, block, n_clone_idx);
duke@435 1125 }
duke@435 1126 }
duke@435 1127 } // End for all users
duke@435 1128
duke@435 1129 } // End of for all Nodes in cloned area
duke@435 1130
duke@435 1131 // Remove the now-dead cloned ops
duke@435 1132 for(uint i3 = beg; i3 < end; i3++ ) {
adlertz@5639 1133 block->get_node(beg)->disconnect_inputs(NULL, C);
adlertz@5639 1134 block->remove_node(beg);
duke@435 1135 }
duke@435 1136
duke@435 1137 // If the successor blocks have a CreateEx node, move it back to the top
adlertz@5639 1138 for(uint i4 = 0; i4 < block->_num_succs; i4++ ) {
adlertz@5639 1139 Block *sb = block->_succs[i4];
duke@435 1140 uint new_cnt = end - beg;
duke@435 1141 // Remove any newly created, but dead, nodes.
duke@435 1142 for( uint j = new_cnt; j > 0; j-- ) {
adlertz@5635 1143 Node *n = sb->get_node(j);
duke@435 1144 if (n->outcnt() == 0 &&
duke@435 1145 (!n->is_Proj() || n->as_Proj()->in(0)->outcnt() == 1) ){
bharadwaj@4315 1146 n->disconnect_inputs(NULL, C);
adlertz@5635 1147 sb->remove_node(j);
duke@435 1148 new_cnt--;
duke@435 1149 }
duke@435 1150 }
duke@435 1151 // If any newly created nodes remain, move the CreateEx node to the top
duke@435 1152 if (new_cnt > 0) {
adlertz@5635 1153 Node *cex = sb->get_node(1+new_cnt);
duke@435 1154 if( cex->is_Mach() && cex->as_Mach()->ideal_Opcode() == Op_CreateEx ) {
adlertz@5635 1155 sb->remove_node(1+new_cnt);
adlertz@5635 1156 sb->insert_node(cex, 1);
duke@435 1157 }
duke@435 1158 }
duke@435 1159 }
duke@435 1160 }

mercurial