Fri, 16 Aug 2019 16:50:17 +0200
8229345: Memory leak due to vtable stubs not being shared on SPARC
Reviewed-by: mdoerr, dholmes, kvn
duke@435 | 1 | /* |
dbuck@8997 | 2 | * Copyright (c) 1997, 2017, Oracle and/or its affiliates. All rights reserved. |
duke@435 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
duke@435 | 4 | * |
duke@435 | 5 | * This code is free software; you can redistribute it and/or modify it |
duke@435 | 6 | * under the terms of the GNU General Public License version 2 only, as |
duke@435 | 7 | * published by the Free Software Foundation. |
duke@435 | 8 | * |
duke@435 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
duke@435 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
duke@435 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
duke@435 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
duke@435 | 13 | * accompanied this code). |
duke@435 | 14 | * |
duke@435 | 15 | * You should have received a copy of the GNU General Public License version |
duke@435 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
duke@435 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
duke@435 | 18 | * |
trims@1907 | 19 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
trims@1907 | 20 | * or visit www.oracle.com if you need additional information or have any |
trims@1907 | 21 | * questions. |
duke@435 | 22 | * |
duke@435 | 23 | */ |
duke@435 | 24 | |
stefank@2314 | 25 | #include "precompiled.hpp" |
twisti@4318 | 26 | #include "asm/macroAssembler.hpp" |
stefank@2314 | 27 | #include "code/vtableStubs.hpp" |
roland@5987 | 28 | #include "interp_masm_x86.hpp" |
stefank@2314 | 29 | #include "memory/resourceArea.hpp" |
dbuck@8997 | 30 | #include "oops/compiledICHolder.hpp" |
stefank@2314 | 31 | #include "oops/instanceKlass.hpp" |
stefank@2314 | 32 | #include "oops/klassVtable.hpp" |
stefank@2314 | 33 | #include "runtime/sharedRuntime.hpp" |
stefank@2314 | 34 | #include "vmreg_x86.inline.hpp" |
stefank@2314 | 35 | #ifdef COMPILER2 |
stefank@2314 | 36 | #include "opto/runtime.hpp" |
stefank@2314 | 37 | #endif |
duke@435 | 38 | |
duke@435 | 39 | // machine-dependent part of VtableStubs: create VtableStub of correct size and |
duke@435 | 40 | // initialize its code |
duke@435 | 41 | |
duke@435 | 42 | #define __ masm-> |
duke@435 | 43 | |
duke@435 | 44 | #ifndef PRODUCT |
duke@435 | 45 | extern "C" void bad_compiled_vtable_index(JavaThread* thread, oop receiver, int index); |
duke@435 | 46 | #endif |
duke@435 | 47 | |
jrose@1058 | 48 | // These stubs are used by the compiler only. |
jrose@1058 | 49 | // Argument registers, which must be preserved: |
jrose@1058 | 50 | // rcx - receiver (always first argument) |
jrose@1058 | 51 | // rdx - second argument (if any) |
jrose@1058 | 52 | // Other registers that might be usable: |
jrose@1058 | 53 | // rax - inline cache register (is interface for itable stub) |
jrose@1058 | 54 | // rbx - method (used when calling out to interpreter) |
jrose@1058 | 55 | // Available now, but may become callee-save at some point: |
jrose@1058 | 56 | // rsi, rdi |
jrose@1058 | 57 | // Note that rax and rdx are also used for return values. |
duke@435 | 58 | // |
duke@435 | 59 | VtableStub* VtableStubs::create_vtable_stub(int vtable_index) { |
duke@435 | 60 | const int i486_code_length = VtableStub::pd_code_size_limit(true); |
duke@435 | 61 | VtableStub* s = new(i486_code_length) VtableStub(true, vtable_index); |
anoll@5762 | 62 | // Can be NULL if there is no free space in the code cache. |
anoll@5762 | 63 | if (s == NULL) { |
anoll@5762 | 64 | return NULL; |
anoll@5762 | 65 | } |
anoll@5762 | 66 | |
duke@435 | 67 | ResourceMark rm; |
duke@435 | 68 | CodeBuffer cb(s->entry_point(), i486_code_length); |
duke@435 | 69 | MacroAssembler* masm = new MacroAssembler(&cb); |
duke@435 | 70 | |
duke@435 | 71 | #ifndef PRODUCT |
duke@435 | 72 | |
duke@435 | 73 | if (CountCompiledCalls) { |
never@739 | 74 | __ incrementl(ExternalAddress((address) SharedRuntime::nof_megamorphic_calls_addr())); |
duke@435 | 75 | } |
duke@435 | 76 | #endif /* PRODUCT */ |
duke@435 | 77 | |
duke@435 | 78 | // get receiver (need to skip return address on top of stack) |
duke@435 | 79 | assert(VtableStub::receiver_location() == rcx->as_VMReg(), "receiver expected in rcx"); |
duke@435 | 80 | |
duke@435 | 81 | // get receiver klass |
duke@435 | 82 | address npe_addr = __ pc(); |
never@739 | 83 | __ movptr(rax, Address(rcx, oopDesc::klass_offset_in_bytes())); |
twisti@3969 | 84 | |
duke@435 | 85 | #ifndef PRODUCT |
duke@435 | 86 | if (DebugVtables) { |
duke@435 | 87 | Label L; |
duke@435 | 88 | // check offset vs vtable length |
coleenp@4037 | 89 | __ cmpl(Address(rax, InstanceKlass::vtable_length_offset()*wordSize), vtable_index*vtableEntry::size()); |
duke@435 | 90 | __ jcc(Assembler::greater, L); |
duke@435 | 91 | __ movl(rbx, vtable_index); |
duke@435 | 92 | __ call_VM(noreg, CAST_FROM_FN_PTR(address, bad_compiled_vtable_index), rcx, rbx); |
duke@435 | 93 | __ bind(L); |
duke@435 | 94 | } |
duke@435 | 95 | #endif // PRODUCT |
duke@435 | 96 | |
duke@435 | 97 | const Register method = rbx; |
duke@435 | 98 | |
coleenp@4037 | 99 | // load Method* and target address |
twisti@3969 | 100 | __ lookup_virtual_method(rax, vtable_index, method); |
twisti@3969 | 101 | |
duke@435 | 102 | if (DebugVtables) { |
duke@435 | 103 | Label L; |
never@739 | 104 | __ cmpptr(method, (int32_t)NULL_WORD); |
duke@435 | 105 | __ jcc(Assembler::equal, L); |
coleenp@4037 | 106 | __ cmpptr(Address(method, Method::from_compiled_offset()), (int32_t)NULL_WORD); |
duke@435 | 107 | __ jcc(Assembler::notZero, L); |
duke@435 | 108 | __ stop("Vtable entry is NULL"); |
duke@435 | 109 | __ bind(L); |
duke@435 | 110 | } |
duke@435 | 111 | |
duke@435 | 112 | // rax,: receiver klass |
coleenp@4037 | 113 | // method (rbx): Method* |
duke@435 | 114 | // rcx: receiver |
duke@435 | 115 | address ame_addr = __ pc(); |
coleenp@4037 | 116 | __ jmp( Address(method, Method::from_compiled_offset())); |
duke@435 | 117 | |
duke@435 | 118 | masm->flush(); |
jrose@1058 | 119 | |
jrose@1058 | 120 | if (PrintMiscellaneous && (WizardMode || Verbose)) { |
kevinw@9327 | 121 | tty->print_cr("vtable #%d at " PTR_FORMAT "[%d] left over: %d", |
drchase@6680 | 122 | vtable_index, p2i(s->entry_point()), |
jrose@1058 | 123 | (int)(s->code_end() - s->entry_point()), |
jrose@1058 | 124 | (int)(s->code_end() - __ pc())); |
jrose@1058 | 125 | } |
jrose@1058 | 126 | guarantee(__ pc() <= s->code_end(), "overflowed buffer"); |
jrose@1144 | 127 | // shut the door on sizing bugs |
jrose@1144 | 128 | int slop = 3; // 32-bit offset is this much larger than an 8-bit one |
jrose@1144 | 129 | assert(vtable_index > 10 || __ pc() + slop <= s->code_end(), "room for 32-bit offset"); |
jrose@1058 | 130 | |
duke@435 | 131 | s->set_exception_points(npe_addr, ame_addr); |
duke@435 | 132 | return s; |
duke@435 | 133 | } |
duke@435 | 134 | |
duke@435 | 135 | |
jrose@1058 | 136 | VtableStub* VtableStubs::create_itable_stub(int itable_index) { |
duke@435 | 137 | // Note well: pd_code_size_limit is the absolute minimum we can get away with. If you |
duke@435 | 138 | // add code here, bump the code stub size returned by pd_code_size_limit! |
duke@435 | 139 | const int i486_code_length = VtableStub::pd_code_size_limit(false); |
jrose@1058 | 140 | VtableStub* s = new(i486_code_length) VtableStub(false, itable_index); |
anoll@5762 | 141 | // Can be NULL if there is no free space in the code cache. |
anoll@5762 | 142 | if (s == NULL) { |
anoll@5762 | 143 | return NULL; |
anoll@5762 | 144 | } |
anoll@5762 | 145 | |
duke@435 | 146 | ResourceMark rm; |
duke@435 | 147 | CodeBuffer cb(s->entry_point(), i486_code_length); |
duke@435 | 148 | MacroAssembler* masm = new MacroAssembler(&cb); |
duke@435 | 149 | |
duke@435 | 150 | // Entry arguments: |
dbuck@8997 | 151 | // rax: CompiledICHolder |
duke@435 | 152 | // rcx: Receiver |
duke@435 | 153 | |
duke@435 | 154 | #ifndef PRODUCT |
duke@435 | 155 | if (CountCompiledCalls) { |
never@739 | 156 | __ incrementl(ExternalAddress((address) SharedRuntime::nof_megamorphic_calls_addr())); |
duke@435 | 157 | } |
duke@435 | 158 | #endif /* PRODUCT */ |
duke@435 | 159 | |
dbuck@8997 | 160 | // Most registers are in use; we'll use rax, rbx, rsi, rdi |
dbuck@8997 | 161 | // (If we need to make rsi, rdi callee-save, do a push/pop here.) |
dbuck@8997 | 162 | const Register recv_klass_reg = rsi; |
dbuck@8997 | 163 | const Register holder_klass_reg = rax; // declaring interface klass (DECC) |
dbuck@8997 | 164 | const Register resolved_klass_reg = rbx; // resolved interface klass (REFC) |
dbuck@8997 | 165 | const Register temp_reg = rdi; |
dbuck@8997 | 166 | |
dbuck@8997 | 167 | const Register icholder_reg = rax; |
dbuck@8997 | 168 | __ movptr(resolved_klass_reg, Address(icholder_reg, CompiledICHolder::holder_klass_offset())); |
dbuck@8997 | 169 | __ movptr(holder_klass_reg, Address(icholder_reg, CompiledICHolder::holder_metadata_offset())); |
dbuck@8997 | 170 | |
dbuck@8997 | 171 | Label L_no_such_interface; |
duke@435 | 172 | |
duke@435 | 173 | // get receiver klass (also an implicit null-check) |
duke@435 | 174 | address npe_addr = __ pc(); |
dbuck@8997 | 175 | assert(VtableStub::receiver_location() == rcx->as_VMReg(), "receiver expected in rcx"); |
dbuck@8997 | 176 | __ load_klass(recv_klass_reg, rcx); |
duke@435 | 177 | |
dbuck@8997 | 178 | // Receiver subtype check against REFC. |
dbuck@8997 | 179 | // Destroys recv_klass_reg value. |
dbuck@8997 | 180 | __ lookup_interface_method(// inputs: rec. class, interface |
dbuck@8997 | 181 | recv_klass_reg, resolved_klass_reg, noreg, |
dbuck@8997 | 182 | // outputs: scan temp. reg1, scan temp. reg2 |
dbuck@8997 | 183 | recv_klass_reg, temp_reg, |
dbuck@8997 | 184 | L_no_such_interface, |
dbuck@8997 | 185 | /*return_method=*/false); |
dbuck@8997 | 186 | |
dbuck@8997 | 187 | // Get selected method from declaring class and itable index |
jrose@1058 | 188 | const Register method = rbx; |
dbuck@8997 | 189 | __ load_klass(recv_klass_reg, rcx); // restore recv_klass_reg |
jrose@1058 | 190 | __ lookup_interface_method(// inputs: rec. class, interface, itable index |
dbuck@8997 | 191 | recv_klass_reg, holder_klass_reg, itable_index, |
jrose@1058 | 192 | // outputs: method, scan temp. reg |
dbuck@8997 | 193 | method, temp_reg, |
dbuck@8997 | 194 | L_no_such_interface); |
duke@435 | 195 | |
coleenp@4037 | 196 | // method (rbx): Method* |
duke@435 | 197 | // rcx: receiver |
duke@435 | 198 | |
duke@435 | 199 | #ifdef ASSERT |
duke@435 | 200 | if (DebugVtables) { |
duke@435 | 201 | Label L1; |
never@739 | 202 | __ cmpptr(method, (int32_t)NULL_WORD); |
duke@435 | 203 | __ jcc(Assembler::equal, L1); |
coleenp@4037 | 204 | __ cmpptr(Address(method, Method::from_compiled_offset()), (int32_t)NULL_WORD); |
duke@435 | 205 | __ jcc(Assembler::notZero, L1); |
coleenp@4037 | 206 | __ stop("Method* is null"); |
duke@435 | 207 | __ bind(L1); |
duke@435 | 208 | } |
duke@435 | 209 | #endif // ASSERT |
duke@435 | 210 | |
duke@435 | 211 | address ame_addr = __ pc(); |
coleenp@4037 | 212 | __ jmp(Address(method, Method::from_compiled_offset())); |
duke@435 | 213 | |
dbuck@8997 | 214 | __ bind(L_no_such_interface); |
dcubed@451 | 215 | __ jump(RuntimeAddress(StubRoutines::throw_IncompatibleClassChangeError_entry())); |
dbuck@8997 | 216 | |
dbuck@8997 | 217 | __ flush(); |
dcubed@451 | 218 | |
jrose@1058 | 219 | if (PrintMiscellaneous && (WizardMode || Verbose)) { |
kevinw@9327 | 220 | tty->print_cr("itable #%d at " PTR_FORMAT "[%d] left over: %d", |
drchase@6680 | 221 | itable_index, p2i(s->entry_point()), |
jrose@1058 | 222 | (int)(s->code_end() - s->entry_point()), |
jrose@1058 | 223 | (int)(s->code_end() - __ pc())); |
jrose@1058 | 224 | } |
dcubed@451 | 225 | guarantee(__ pc() <= s->code_end(), "overflowed buffer"); |
jrose@1144 | 226 | // shut the door on sizing bugs |
jrose@1144 | 227 | int slop = 3; // 32-bit offset is this much larger than an 8-bit one |
jrose@1144 | 228 | assert(itable_index > 10 || __ pc() + slop <= s->code_end(), "room for 32-bit offset"); |
dcubed@451 | 229 | |
duke@435 | 230 | s->set_exception_points(npe_addr, ame_addr); |
duke@435 | 231 | return s; |
duke@435 | 232 | } |
duke@435 | 233 | |
duke@435 | 234 | |
duke@435 | 235 | |
duke@435 | 236 | int VtableStub::pd_code_size_limit(bool is_vtable_stub) { |
duke@435 | 237 | if (is_vtable_stub) { |
duke@435 | 238 | // Vtable stub size |
duke@435 | 239 | return (DebugVtables ? 210 : 16) + (CountCompiledCalls ? 6 : 0); |
duke@435 | 240 | } else { |
duke@435 | 241 | // Itable stub size |
dbuck@8997 | 242 | return (DebugVtables ? 256 : 116) + (CountCompiledCalls ? 6 : 0); |
duke@435 | 243 | } |
jrose@1144 | 244 | // In order to tune these parameters, run the JVM with VM options |
jrose@1144 | 245 | // +PrintMiscellaneous and +WizardMode to see information about |
jrose@1144 | 246 | // actual itable stubs. Look for lines like this: |
jrose@1144 | 247 | // itable #1 at 0x5551212[65] left over: 3 |
jrose@1144 | 248 | // Reduce the constants so that the "left over" number is >=3 |
jrose@1144 | 249 | // for the common cases. |
jrose@1144 | 250 | // Do not aim at a left-over number of zero, because a |
jrose@1144 | 251 | // large vtable or itable index (> 16) will require a 32-bit |
jrose@1144 | 252 | // immediate displacement instead of an 8-bit one. |
jrose@1144 | 253 | // |
jrose@1144 | 254 | // The JVM98 app. _202_jess has a megamorphic interface call. |
jrose@1144 | 255 | // The itable code looks like this: |
jrose@1144 | 256 | // Decoding VtableStub itbl[1]@1 |
jrose@1144 | 257 | // mov 0x4(%ecx),%esi |
jrose@1144 | 258 | // mov 0xe8(%esi),%edi |
jrose@1144 | 259 | // lea 0x130(%esi,%edi,4),%edi |
jrose@1144 | 260 | // add $0x7,%edi |
jrose@1144 | 261 | // and $0xfffffff8,%edi |
jrose@1144 | 262 | // lea 0x4(%esi),%esi |
jrose@1144 | 263 | // mov (%edi),%ebx |
jrose@1144 | 264 | // cmp %ebx,%eax |
jrose@1144 | 265 | // je success |
jrose@1144 | 266 | // loop: |
jrose@1144 | 267 | // test %ebx,%ebx |
jrose@1144 | 268 | // je throw_icce |
jrose@1144 | 269 | // add $0x8,%edi |
jrose@1144 | 270 | // mov (%edi),%ebx |
jrose@1144 | 271 | // cmp %ebx,%eax |
jrose@1144 | 272 | // jne loop |
jrose@1144 | 273 | // success: |
jrose@1144 | 274 | // mov 0x4(%edi),%edi |
jrose@1144 | 275 | // mov (%esi,%edi,1),%ebx |
jrose@1144 | 276 | // jmp *0x44(%ebx) |
jrose@1144 | 277 | // throw_icce: |
jrose@1144 | 278 | // jmp throw_ICCE_entry |
duke@435 | 279 | } |
duke@435 | 280 | |
duke@435 | 281 | int VtableStub::pd_code_alignment() { |
duke@435 | 282 | return wordSize; |
duke@435 | 283 | } |