• file
• revisions
• annotate
• diff
• comparison
• raw

src/share/vm/gc_implementation/shared/gSpaceCounters.hpp@b2ef234911c9 (annotated)

src/share/vm/gc_implementation/shared/gSpaceCounters.hpp

Thu, 20 Sep 2012 09:52:56 -0700

author

johnc

date

Thu, 20 Sep 2012 09:52:56 -0700

changeset 4067

b2ef234911c9

parent 3900

d2a62e0f25eb

child 4153

b9a9ed0f8eeb

permissions

-rw-r--r--

7190666: G1: assert(_unused == 0) failed: Inconsistency in PLAB stats
Summary: Reset the fields in ParGCAllocBuffer, that are used for accumulating values for the ResizePLAB sensors in PLABStats, to zero after flushing the values to the PLABStats fields. Flush PLABStats values only when retiring the final allocation buffers prior to disposing of a G1ParScanThreadState object, rather than when retiring every allocation buffer.
Reviewed-by: jwilhelm, jmasa, ysr

duke@435	1	/*
stefank@2314	2	* Copyright (c) 2002, 2010, Oracle and/or its affiliates. All rights reserved.
duke@435	3	* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@435	4	*
duke@435	5	* This code is free software; you can redistribute it and/or modify it
duke@435	6	* under the terms of the GNU General Public License version 2 only, as
duke@435	7	* published by the Free Software Foundation.
duke@435	8	*
duke@435	9	* This code is distributed in the hope that it will be useful, but WITHOUT
duke@435	10	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@435	11	* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@435	12	* version 2 for more details (a copy is included in the LICENSE file that
duke@435	13	* accompanied this code).
duke@435	14	*
duke@435	15	* You should have received a copy of the GNU General Public License version
duke@435	16	* 2 along with this work; if not, write to the Free Software Foundation,
duke@435	17	* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@435	18	*
trims@1907	19	* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
trims@1907	20	* or visit www.oracle.com if you need additional information or have any
trims@1907	21	* questions.
duke@435	22	*
duke@435	23	*/
duke@435	24
stefank@2314	25	#ifndef SHARE_VM_GC_IMPLEMENTATION_SHARED_GSPACECOUNTERS_HPP
stefank@2314	26	#define SHARE_VM_GC_IMPLEMENTATION_SHARED_GSPACECOUNTERS_HPP
stefank@2314	27
stefank@2314	28	#ifndef SERIALGC
stefank@2314	29	#include "gc_implementation/shared/generationCounters.hpp"
stefank@2314	30	#include "memory/generation.hpp"
stefank@2314	31	#include "runtime/perfData.hpp"
stefank@2314	32	#endif
stefank@2314	33
duke@435	34	// A GSpaceCounter is a holder class for performance counters
duke@435	35	// that track a space;
duke@435	36
zgu@3900	37	class GSpaceCounters: public CHeapObj<mtGC> {
duke@435	38	friend class VMStructs;
duke@435	39
duke@435	40	private:
duke@435	41	PerfVariable* _capacity;
duke@435	42	PerfVariable* _used;
duke@435	43
duke@435	44	// Constant PerfData types don't need to retain a reference.
duke@435	45	// However, it's a good idea to document them here.
duke@435	46	// PerfConstant* _size;
duke@435	47
duke@435	48	Generation* _gen;
duke@435	49	char* _name_space;
duke@435	50
duke@435	51	public:
duke@435	52
duke@435	53	GSpaceCounters(const char* name, int ordinal, size_t max_size, Generation* g,
duke@435	54	GenerationCounters* gc, bool sampled=true);
duke@435	55
duke@435	56	~GSpaceCounters() {
zgu@3900	57	if (_name_space != NULL) FREE_C_HEAP_ARRAY(char, _name_space, mtGC);
duke@435	58	}
duke@435	59
duke@435	60	inline void update_capacity() {
duke@435	61	_capacity->set_value(_gen->capacity());
duke@435	62	}
duke@435	63
duke@435	64	inline void update_used() {
duke@435	65	_used->set_value(_gen->used());
duke@435	66	}
duke@435	67
duke@435	68	// special version of update_used() to allow the used value to be
duke@435	69	// passed as a parameter. This method can can be used in cases were
duke@435	70	// the utilization is already known and/or when the _gen->used()
duke@435	71	// method is known to be expensive and we want to avoid unnecessary
duke@435	72	// calls to it.
duke@435	73	//
duke@435	74	inline void update_used(size_t used) {
duke@435	75	_used->set_value(used);
duke@435	76	}
duke@435	77
duke@435	78	inline void inc_used(size_t size) {
duke@435	79	_used->inc(size);
duke@435	80	}
duke@435	81
duke@435	82	debug_only(
duke@435	83	// for security reasons, we do not allow arbitrary reads from
duke@435	84	// the counters as they may live in shared memory.
duke@435	85	jlong used() {
duke@435	86	return _used->get_value();
duke@435	87	}
duke@435	88	jlong capacity() {
duke@435	89	return _used->get_value();
duke@435	90	}
duke@435	91	)
duke@435	92
duke@435	93	inline void update_all() {
duke@435	94	update_used();
duke@435	95	update_capacity();
duke@435	96	}
duke@435	97
duke@435	98	const char* name_space() const { return _name_space; }
duke@435	99	};
duke@435	100
duke@435	101	class GenerationUsedHelper : public PerfLongSampleHelper {
duke@435	102	private:
duke@435	103	Generation* _gen;
duke@435	104
duke@435	105	public:
duke@435	106	GenerationUsedHelper(Generation* g) : _gen(g) { }
duke@435	107
duke@435	108	inline jlong take_sample() {
duke@435	109	return _gen->used();
duke@435	110	}
duke@435	111	};
stefank@2314	112
stefank@2314	113	#endif // SHARE_VM_GC_IMPLEMENTATION_SHARED_GSPACECOUNTERS_HPP