Thu, 20 Sep 2012 09:52:56 -0700
7190666: G1: assert(_unused == 0) failed: Inconsistency in PLAB stats
Summary: Reset the fields in ParGCAllocBuffer, that are used for accumulating values for the ResizePLAB sensors in PLABStats, to zero after flushing the values to the PLABStats fields. Flush PLABStats values only when retiring the final allocation buffers prior to disposing of a G1ParScanThreadState object, rather than when retiring every allocation buffer.
Reviewed-by: jwilhelm, jmasa, ysr
duke@435 | 1 | /* |
coleenp@4037 | 2 | * Copyright (c) 2002, 2012, Oracle and/or its affiliates. All rights reserved. |
duke@435 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
duke@435 | 4 | * |
duke@435 | 5 | * This code is free software; you can redistribute it and/or modify it |
duke@435 | 6 | * under the terms of the GNU General Public License version 2 only, as |
duke@435 | 7 | * published by the Free Software Foundation. |
duke@435 | 8 | * |
duke@435 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
duke@435 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
duke@435 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
duke@435 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
duke@435 | 13 | * accompanied this code). |
duke@435 | 14 | * |
duke@435 | 15 | * You should have received a copy of the GNU General Public License version |
duke@435 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
duke@435 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
duke@435 | 18 | * |
trims@1907 | 19 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
trims@1907 | 20 | * or visit www.oracle.com if you need additional information or have any |
trims@1907 | 21 | * questions. |
duke@435 | 22 | * |
duke@435 | 23 | */ |
duke@435 | 24 | |
stefank@2314 | 25 | #ifndef SHARE_VM_GC_IMPLEMENTATION_SHARED_CSPACECOUNTERS_HPP |
stefank@2314 | 26 | #define SHARE_VM_GC_IMPLEMENTATION_SHARED_CSPACECOUNTERS_HPP |
stefank@2314 | 27 | |
stefank@2314 | 28 | #include "gc_implementation/shared/generationCounters.hpp" |
stefank@2314 | 29 | #include "memory/space.inline.hpp" |
stefank@2314 | 30 | #include "runtime/perfData.hpp" |
stefank@2314 | 31 | |
duke@435 | 32 | // A CSpaceCounters is a holder class for performance counters |
duke@435 | 33 | // that track a space; |
duke@435 | 34 | |
zgu@3900 | 35 | class CSpaceCounters: public CHeapObj<mtGC> { |
duke@435 | 36 | friend class VMStructs; |
duke@435 | 37 | |
duke@435 | 38 | private: |
duke@435 | 39 | PerfVariable* _capacity; |
duke@435 | 40 | PerfVariable* _used; |
coleenp@4037 | 41 | PerfVariable* _max_capacity; |
duke@435 | 42 | |
duke@435 | 43 | // Constant PerfData types don't need to retain a reference. |
duke@435 | 44 | // However, it's a good idea to document them here. |
duke@435 | 45 | // PerfConstant* _size; |
duke@435 | 46 | |
duke@435 | 47 | ContiguousSpace* _space; |
duke@435 | 48 | char* _name_space; |
duke@435 | 49 | |
duke@435 | 50 | public: |
duke@435 | 51 | |
duke@435 | 52 | CSpaceCounters(const char* name, int ordinal, size_t max_size, |
duke@435 | 53 | ContiguousSpace* s, GenerationCounters* gc); |
duke@435 | 54 | |
duke@435 | 55 | ~CSpaceCounters() { |
zgu@3900 | 56 | if (_name_space != NULL) FREE_C_HEAP_ARRAY(char, _name_space, mtInternal); |
duke@435 | 57 | } |
duke@435 | 58 | |
coleenp@4037 | 59 | virtual inline void update_capacity() { |
duke@435 | 60 | _capacity->set_value(_space->capacity()); |
duke@435 | 61 | } |
duke@435 | 62 | |
coleenp@4037 | 63 | virtual inline void update_used() { |
duke@435 | 64 | _used->set_value(_space->used()); |
duke@435 | 65 | } |
duke@435 | 66 | |
coleenp@4037 | 67 | virtual inline void update_all() { |
duke@435 | 68 | update_used(); |
duke@435 | 69 | update_capacity(); |
duke@435 | 70 | } |
duke@435 | 71 | |
duke@435 | 72 | const char* name_space() const { return _name_space; } |
duke@435 | 73 | }; |
duke@435 | 74 | |
duke@435 | 75 | class ContiguousSpaceUsedHelper : public PerfLongSampleHelper { |
duke@435 | 76 | private: |
duke@435 | 77 | ContiguousSpace* _space; |
duke@435 | 78 | |
duke@435 | 79 | public: |
duke@435 | 80 | ContiguousSpaceUsedHelper(ContiguousSpace* space) : _space(space) { } |
duke@435 | 81 | |
duke@435 | 82 | inline jlong take_sample() { |
duke@435 | 83 | return _space->used(); |
duke@435 | 84 | } |
duke@435 | 85 | }; |
stefank@2314 | 86 | |
stefank@2314 | 87 | #endif // SHARE_VM_GC_IMPLEMENTATION_SHARED_CSPACECOUNTERS_HPP |