Tue, 15 Nov 2011 20:17:33 +0100
7110152: assert(size_in_words <= (julong)max_jint) failed: no overflow
Summary: Reduce what arrayOopDesc::max_array_length() returns to avoid int overflow
Reviewed-by: kvn, dholmes, tonyp
duke@435 | 1 | /* |
stefank@2314 | 2 | * Copyright (c) 1997, 2010, Oracle and/or its affiliates. All rights reserved. |
duke@435 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
duke@435 | 4 | * |
duke@435 | 5 | * This code is free software; you can redistribute it and/or modify it |
duke@435 | 6 | * under the terms of the GNU General Public License version 2 only, as |
duke@435 | 7 | * published by the Free Software Foundation. |
duke@435 | 8 | * |
duke@435 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
duke@435 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
duke@435 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
duke@435 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
duke@435 | 13 | * accompanied this code). |
duke@435 | 14 | * |
duke@435 | 15 | * You should have received a copy of the GNU General Public License version |
duke@435 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
duke@435 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
duke@435 | 18 | * |
trims@1907 | 19 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
trims@1907 | 20 | * or visit www.oracle.com if you need additional information or have any |
trims@1907 | 21 | * questions. |
duke@435 | 22 | * |
duke@435 | 23 | */ |
duke@435 | 24 | |
stefank@2314 | 25 | #include "precompiled.hpp" |
stefank@2314 | 26 | #include "oops/markOop.hpp" |
stefank@2314 | 27 | #ifdef TARGET_OS_FAMILY_linux |
stefank@2314 | 28 | # include "thread_linux.inline.hpp" |
stefank@2314 | 29 | #endif |
stefank@2314 | 30 | #ifdef TARGET_OS_FAMILY_solaris |
stefank@2314 | 31 | # include "thread_solaris.inline.hpp" |
stefank@2314 | 32 | #endif |
stefank@2314 | 33 | #ifdef TARGET_OS_FAMILY_windows |
stefank@2314 | 34 | # include "thread_windows.inline.hpp" |
stefank@2314 | 35 | #endif |
never@3156 | 36 | #ifdef TARGET_OS_FAMILY_bsd |
never@3156 | 37 | # include "thread_bsd.inline.hpp" |
never@3156 | 38 | #endif |
duke@435 | 39 | |
duke@435 | 40 | |
duke@435 | 41 | void markOopDesc::print_on(outputStream* st) const { |
duke@435 | 42 | if (is_locked()) { |
duke@435 | 43 | st->print("locked(0x%lx)->", value()); |
duke@435 | 44 | markOop(*(markOop*)value())->print_on(st); |
duke@435 | 45 | } else { |
jrose@1474 | 46 | assert(is_unlocked() || has_bias_pattern(), "just checking"); |
duke@435 | 47 | st->print("mark("); |
jrose@1474 | 48 | if (has_bias_pattern()) st->print("biased,"); |
duke@435 | 49 | st->print("hash %#lx,", hash()); |
duke@435 | 50 | st->print("age %d)", age()); |
duke@435 | 51 | } |
duke@435 | 52 | } |
dcubed@483 | 53 | |
dcubed@483 | 54 | |
dcubed@483 | 55 | // Give advice about whether the oop that contains this markOop |
dcubed@483 | 56 | // should be cached or not. |
dcubed@483 | 57 | bool markOopDesc::should_not_be_cached() const { |
dcubed@483 | 58 | // the cast is because decode_pointer() isn't marked const |
dcubed@483 | 59 | if (is_marked() && ((markOopDesc *)this)->decode_pointer() != NULL) { |
dcubed@483 | 60 | // If the oop containing this markOop is being forwarded, then |
dcubed@483 | 61 | // we are in the middle of GC and we do not want the containing |
dcubed@483 | 62 | // oop to be added to a cache. We have no way of knowing whether |
dcubed@483 | 63 | // the cache has already been visited by the current GC phase so |
dcubed@483 | 64 | // we don't know whether the forwarded oop will be properly |
dcubed@483 | 65 | // processed in this phase. If the forwarded oop is not properly |
dcubed@483 | 66 | // processed, then we'll see strange crashes or asserts during |
dcubed@483 | 67 | // the next GC run because the markOop will contain an unexpected |
dcubed@483 | 68 | // value. |
dcubed@483 | 69 | // |
dcubed@483 | 70 | // This situation has been seen when we are GC'ing a methodOop |
dcubed@483 | 71 | // because we use the methodOop while we're GC'ing it. Scary |
dcubed@483 | 72 | // stuff. Some of the uses the methodOop cause the methodOop to |
dcubed@483 | 73 | // be added to the OopMapCache in the instanceKlass as a side |
dcubed@483 | 74 | // effect. This check lets the cache maintainer know when a |
dcubed@483 | 75 | // cache addition would not be safe. |
dcubed@483 | 76 | return true; |
dcubed@483 | 77 | } |
dcubed@483 | 78 | |
dcubed@483 | 79 | // caching the containing oop should be just fine |
dcubed@483 | 80 | return false; |
dcubed@483 | 81 | } |