Tue, 05 May 2009 22:15:35 -0700
6833576: G1: assert illegal index, growableArray.hpp:186
Summary: The code that calculates the heap region index for an object address incorrectly used signed arithmetic.
Reviewed-by: jcoomes, ysr
ysr@777 | 1 | /* |
ysr@777 | 2 | * Copyright 2001-2007 Sun Microsystems, Inc. All Rights Reserved. |
ysr@777 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
ysr@777 | 4 | * |
ysr@777 | 5 | * This code is free software; you can redistribute it and/or modify it |
ysr@777 | 6 | * under the terms of the GNU General Public License version 2 only, as |
ysr@777 | 7 | * published by the Free Software Foundation. |
ysr@777 | 8 | * |
ysr@777 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
ysr@777 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
ysr@777 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
ysr@777 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
ysr@777 | 13 | * accompanied this code). |
ysr@777 | 14 | * |
ysr@777 | 15 | * You should have received a copy of the GNU General Public License version |
ysr@777 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
ysr@777 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
ysr@777 | 18 | * |
ysr@777 | 19 | * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara, |
ysr@777 | 20 | * CA 95054 USA or visit www.sun.com if you need additional information or |
ysr@777 | 21 | * have any questions. |
ysr@777 | 22 | * |
ysr@777 | 23 | */ |
ysr@777 | 24 | |
ysr@777 | 25 | inline HeapWord* G1OffsetTableContigSpace::allocate(size_t size) { |
ysr@777 | 26 | HeapWord* res = ContiguousSpace::allocate(size); |
ysr@777 | 27 | if (res != NULL) { |
ysr@777 | 28 | _offsets.alloc_block(res, size); |
ysr@777 | 29 | } |
ysr@777 | 30 | return res; |
ysr@777 | 31 | } |
ysr@777 | 32 | |
ysr@777 | 33 | // Because of the requirement of keeping "_offsets" up to date with the |
ysr@777 | 34 | // allocations, we sequentialize these with a lock. Therefore, best if |
ysr@777 | 35 | // this is used for larger LAB allocations only. |
ysr@777 | 36 | inline HeapWord* G1OffsetTableContigSpace::par_allocate(size_t size) { |
ysr@777 | 37 | MutexLocker x(&_par_alloc_lock); |
ysr@777 | 38 | // This ought to be just "allocate", because of the lock above, but that |
ysr@777 | 39 | // ContiguousSpace::allocate asserts that either the allocating thread |
ysr@777 | 40 | // holds the heap lock or it is the VM thread and we're at a safepoint. |
ysr@777 | 41 | // The best I (dld) could figure was to put a field in ContiguousSpace |
ysr@777 | 42 | // meaning "locking at safepoint taken care of", and set/reset that |
ysr@777 | 43 | // here. But this will do for now, especially in light of the comment |
ysr@777 | 44 | // above. Perhaps in the future some lock-free manner of keeping the |
ysr@777 | 45 | // coordination. |
ysr@777 | 46 | HeapWord* res = ContiguousSpace::par_allocate(size); |
ysr@777 | 47 | if (res != NULL) { |
ysr@777 | 48 | _offsets.alloc_block(res, size); |
ysr@777 | 49 | } |
ysr@777 | 50 | return res; |
ysr@777 | 51 | } |
ysr@777 | 52 | |
ysr@777 | 53 | inline HeapWord* G1OffsetTableContigSpace::block_start(const void* p) { |
ysr@777 | 54 | return _offsets.block_start(p); |
ysr@777 | 55 | } |
ysr@777 | 56 | |
ysr@777 | 57 | inline HeapWord* |
ysr@777 | 58 | G1OffsetTableContigSpace::block_start_const(const void* p) const { |
ysr@777 | 59 | return _offsets.block_start_const(p); |
ysr@777 | 60 | } |