Tue, 05 May 2009 22:15:35 -0700
6833576: G1: assert illegal index, growableArray.hpp:186
Summary: The code that calculates the heap region index for an object address incorrectly used signed arithmetic.
Reviewed-by: jcoomes, ysr
ysr@777 | 1 | /* |
ysr@777 | 2 | * Copyright 2001-2007 Sun Microsystems, Inc. All Rights Reserved. |
ysr@777 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
ysr@777 | 4 | * |
ysr@777 | 5 | * This code is free software; you can redistribute it and/or modify it |
ysr@777 | 6 | * under the terms of the GNU General Public License version 2 only, as |
ysr@777 | 7 | * published by the Free Software Foundation. |
ysr@777 | 8 | * |
ysr@777 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
ysr@777 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
ysr@777 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
ysr@777 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
ysr@777 | 13 | * accompanied this code). |
ysr@777 | 14 | * |
ysr@777 | 15 | * You should have received a copy of the GNU General Public License version |
ysr@777 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
ysr@777 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
ysr@777 | 18 | * |
ysr@777 | 19 | * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara, |
ysr@777 | 20 | * CA 95054 USA or visit www.sun.com if you need additional information or |
ysr@777 | 21 | * have any questions. |
ysr@777 | 22 | * |
ysr@777 | 23 | */ |
ysr@777 | 24 | |
ysr@777 | 25 | // Forward Decl. |
ysr@777 | 26 | class ConcurrentG1Refine; |
ysr@777 | 27 | |
ysr@777 | 28 | // The G1 Concurrent Refinement Thread (could be several in the future). |
ysr@777 | 29 | |
ysr@777 | 30 | class ConcurrentG1RefineThread: public ConcurrentGCThread { |
ysr@777 | 31 | friend class VMStructs; |
ysr@777 | 32 | friend class G1CollectedHeap; |
ysr@777 | 33 | |
ysr@777 | 34 | double _vtime_start; // Initial virtual time. |
ysr@777 | 35 | double _vtime_accum; // Initial virtual time. |
ysr@777 | 36 | |
ysr@777 | 37 | public: |
ysr@777 | 38 | virtual void run(); |
ysr@777 | 39 | |
ysr@777 | 40 | private: |
ysr@777 | 41 | ConcurrentG1Refine* _cg1r; |
ysr@777 | 42 | bool _started; |
ysr@777 | 43 | bool _in_progress; |
ysr@777 | 44 | volatile bool _restart; |
ysr@777 | 45 | |
ysr@777 | 46 | COTracker _co_tracker; |
ysr@777 | 47 | double _interval_ms; |
ysr@777 | 48 | |
ysr@777 | 49 | bool _do_traversal; |
ysr@777 | 50 | |
ysr@777 | 51 | void decreaseInterval(int processing_time_ms) { |
ysr@777 | 52 | double min_interval_ms = (double) processing_time_ms; |
ysr@777 | 53 | _interval_ms = 0.8 * _interval_ms; |
ysr@777 | 54 | if (_interval_ms < min_interval_ms) |
ysr@777 | 55 | _interval_ms = min_interval_ms; |
ysr@777 | 56 | } |
ysr@777 | 57 | void increaseInterval(int processing_time_ms) { |
ysr@777 | 58 | double max_interval_ms = 9.0 * (double) processing_time_ms; |
ysr@777 | 59 | _interval_ms = 1.1 * _interval_ms; |
ysr@777 | 60 | if (max_interval_ms > 0 && _interval_ms > max_interval_ms) |
ysr@777 | 61 | _interval_ms = max_interval_ms; |
ysr@777 | 62 | } |
ysr@777 | 63 | |
ysr@777 | 64 | void sleepBeforeNextCycle(); |
ysr@777 | 65 | |
ysr@777 | 66 | void traversalBasedRefinement(); |
ysr@777 | 67 | |
ysr@777 | 68 | void queueBasedRefinement(); |
ysr@777 | 69 | |
ysr@777 | 70 | // For use by G1CollectedHeap, which is a friend. |
ysr@777 | 71 | static SuspendibleThreadSet* sts() { return &_sts; } |
ysr@777 | 72 | |
ysr@777 | 73 | public: |
ysr@777 | 74 | // Constructor |
ysr@777 | 75 | ConcurrentG1RefineThread(ConcurrentG1Refine* cg1r); |
ysr@777 | 76 | |
ysr@777 | 77 | // Printing |
ysr@777 | 78 | void print(); |
ysr@777 | 79 | |
ysr@777 | 80 | // Total virtual time so far. |
ysr@777 | 81 | double vtime_accum() { return _vtime_accum; } |
ysr@777 | 82 | |
ysr@777 | 83 | ConcurrentG1Refine* cg1r() { return _cg1r; } |
ysr@777 | 84 | |
ysr@777 | 85 | |
ysr@777 | 86 | void set_started() { _started = true; } |
ysr@777 | 87 | void clear_started() { _started = false; } |
ysr@777 | 88 | bool started() { return _started; } |
ysr@777 | 89 | |
ysr@777 | 90 | void set_in_progress() { _in_progress = true; } |
ysr@777 | 91 | void clear_in_progress() { _in_progress = false; } |
ysr@777 | 92 | bool in_progress() { return _in_progress; } |
ysr@777 | 93 | |
ysr@777 | 94 | void set_do_traversal(bool b); |
ysr@777 | 95 | bool do_traversal() { return _do_traversal; } |
ysr@777 | 96 | |
ysr@777 | 97 | void sample_young_list_rs_lengths(); |
ysr@777 | 98 | |
ysr@777 | 99 | // Yield for GC |
ysr@777 | 100 | void yield(); |
ysr@777 | 101 | |
ysr@777 | 102 | // shutdown |
ysr@777 | 103 | static void stop(); |
ysr@777 | 104 | }; |