Fri, 15 Apr 2011 09:36:28 -0400
7032407: Crash in LinkResolver::runtime_resolve_virtual_method()
Summary: Make CDS reorder vtables so that dump time vtables match run time order, so when redefine classes reinitializes them, they aren't in the wrong order.
Reviewed-by: dcubed, acorn
duke@435 | 1 | /* |
stefank@2314 | 2 | * Copyright (c) 1997, 2010, Oracle and/or its affiliates. All rights reserved. |
duke@435 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
duke@435 | 4 | * |
duke@435 | 5 | * This code is free software; you can redistribute it and/or modify it |
duke@435 | 6 | * under the terms of the GNU General Public License version 2 only, as |
duke@435 | 7 | * published by the Free Software Foundation. |
duke@435 | 8 | * |
duke@435 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
duke@435 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
duke@435 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
duke@435 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
duke@435 | 13 | * accompanied this code). |
duke@435 | 14 | * |
duke@435 | 15 | * You should have received a copy of the GNU General Public License version |
duke@435 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
duke@435 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
duke@435 | 18 | * |
trims@1907 | 19 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
trims@1907 | 20 | * or visit www.oracle.com if you need additional information or have any |
trims@1907 | 21 | * questions. |
duke@435 | 22 | * |
duke@435 | 23 | */ |
duke@435 | 24 | |
stefank@2314 | 25 | #ifndef SHARE_VM_MEMORY_GCLOCKER_HPP |
stefank@2314 | 26 | #define SHARE_VM_MEMORY_GCLOCKER_HPP |
stefank@2314 | 27 | |
stefank@2314 | 28 | #include "gc_interface/collectedHeap.hpp" |
stefank@2314 | 29 | #include "memory/genCollectedHeap.hpp" |
stefank@2314 | 30 | #include "memory/universe.hpp" |
stefank@2314 | 31 | #include "oops/oop.hpp" |
stefank@2314 | 32 | #ifdef TARGET_OS_FAMILY_linux |
stefank@2314 | 33 | # include "os_linux.inline.hpp" |
stefank@2314 | 34 | # include "thread_linux.inline.hpp" |
stefank@2314 | 35 | #endif |
stefank@2314 | 36 | #ifdef TARGET_OS_FAMILY_solaris |
stefank@2314 | 37 | # include "os_solaris.inline.hpp" |
stefank@2314 | 38 | # include "thread_solaris.inline.hpp" |
stefank@2314 | 39 | #endif |
stefank@2314 | 40 | #ifdef TARGET_OS_FAMILY_windows |
stefank@2314 | 41 | # include "os_windows.inline.hpp" |
stefank@2314 | 42 | # include "thread_windows.inline.hpp" |
stefank@2314 | 43 | #endif |
stefank@2314 | 44 | |
duke@435 | 45 | // The direct lock/unlock calls do not force a collection if an unlock |
duke@435 | 46 | // decrements the count to zero. Avoid calling these if at all possible. |
duke@435 | 47 | |
duke@435 | 48 | class GC_locker: public AllStatic { |
duke@435 | 49 | private: |
duke@435 | 50 | static volatile jint _jni_lock_count; // number of jni active instances |
duke@435 | 51 | static volatile jint _lock_count; // number of other active instances |
duke@435 | 52 | static volatile bool _needs_gc; // heap is filling, we need a GC |
duke@435 | 53 | // note: bool is typedef'd as jint |
duke@435 | 54 | static volatile bool _doing_gc; // unlock_critical() is doing a GC |
duke@435 | 55 | |
duke@435 | 56 | // Accessors |
duke@435 | 57 | static bool is_jni_active() { |
duke@435 | 58 | return _jni_lock_count > 0; |
duke@435 | 59 | } |
duke@435 | 60 | |
duke@435 | 61 | static void set_needs_gc() { |
duke@435 | 62 | assert(SafepointSynchronize::is_at_safepoint(), |
duke@435 | 63 | "needs_gc is only set at a safepoint"); |
duke@435 | 64 | _needs_gc = true; |
duke@435 | 65 | } |
duke@435 | 66 | |
duke@435 | 67 | static void clear_needs_gc() { |
duke@435 | 68 | assert_lock_strong(JNICritical_lock); |
duke@435 | 69 | _needs_gc = false; |
duke@435 | 70 | } |
duke@435 | 71 | |
duke@435 | 72 | static void jni_lock() { |
duke@435 | 73 | Atomic::inc(&_jni_lock_count); |
duke@435 | 74 | CHECK_UNHANDLED_OOPS_ONLY( |
duke@435 | 75 | if (CheckUnhandledOops) { Thread::current()->_gc_locked_out_count++; }) |
duke@435 | 76 | assert(Universe::heap() == NULL || !Universe::heap()->is_gc_active(), |
duke@435 | 77 | "locking failed"); |
duke@435 | 78 | } |
duke@435 | 79 | |
duke@435 | 80 | static void jni_unlock() { |
duke@435 | 81 | Atomic::dec(&_jni_lock_count); |
duke@435 | 82 | CHECK_UNHANDLED_OOPS_ONLY( |
duke@435 | 83 | if (CheckUnhandledOops) { Thread::current()->_gc_locked_out_count--; }) |
duke@435 | 84 | } |
duke@435 | 85 | |
duke@435 | 86 | static void jni_lock_slow(); |
duke@435 | 87 | static void jni_unlock_slow(); |
duke@435 | 88 | |
duke@435 | 89 | public: |
duke@435 | 90 | // Accessors |
duke@435 | 91 | static bool is_active(); |
duke@435 | 92 | static bool needs_gc() { return _needs_gc; } |
duke@435 | 93 | // Shorthand |
duke@435 | 94 | static bool is_active_and_needs_gc() { return is_active() && needs_gc();} |
duke@435 | 95 | |
duke@435 | 96 | // Calls set_needs_gc() if is_active() is true. Returns is_active(). |
duke@435 | 97 | static bool check_active_before_gc(); |
duke@435 | 98 | |
duke@435 | 99 | // Stalls the caller (who should not be in a jni critical section) |
duke@435 | 100 | // until needs_gc() clears. Note however that needs_gc() may be |
duke@435 | 101 | // set at a subsequent safepoint and/or cleared under the |
duke@435 | 102 | // JNICritical_lock, so the caller may not safely assert upon |
duke@435 | 103 | // return from this method that "!needs_gc()" since that is |
duke@435 | 104 | // not a stable predicate. |
duke@435 | 105 | static void stall_until_clear(); |
duke@435 | 106 | |
duke@435 | 107 | // Non-structured GC locking: currently needed for JNI. Use with care! |
duke@435 | 108 | static void lock(); |
duke@435 | 109 | static void unlock(); |
duke@435 | 110 | |
duke@435 | 111 | // The following two methods are used for JNI critical regions. |
duke@435 | 112 | // If we find that we failed to perform a GC because the GC_locker |
duke@435 | 113 | // was active, arrange for one as soon as possible by allowing |
duke@435 | 114 | // all threads in critical regions to complete, but not allowing |
duke@435 | 115 | // other critical regions to be entered. The reasons for that are: |
duke@435 | 116 | // 1) a GC request won't be starved by overlapping JNI critical |
duke@435 | 117 | // region activities, which can cause unnecessary OutOfMemory errors. |
duke@435 | 118 | // 2) even if allocation requests can still be satisfied before GC locker |
duke@435 | 119 | // becomes inactive, for example, in tenured generation possibly with |
duke@435 | 120 | // heap expansion, those allocations can trigger lots of safepointing |
duke@435 | 121 | // attempts (ineffective GC attempts) and require Heap_lock which |
duke@435 | 122 | // slow down allocations tremendously. |
duke@435 | 123 | // |
duke@435 | 124 | // Note that critical regions can be nested in a single thread, so |
duke@435 | 125 | // we must allow threads already in critical regions to continue. |
duke@435 | 126 | // |
duke@435 | 127 | // JNI critical regions are the only participants in this scheme |
duke@435 | 128 | // because they are, by spec, well bounded while in a critical region. |
duke@435 | 129 | // |
duke@435 | 130 | // Each of the following two method is split into a fast path and a slow |
duke@435 | 131 | // path. JNICritical_lock is only grabbed in the slow path. |
duke@435 | 132 | // _needs_gc is initially false and every java thread will go |
duke@435 | 133 | // through the fast path (which does the same thing as the slow path |
duke@435 | 134 | // when _needs_gc is false). When GC happens at a safepoint, |
duke@435 | 135 | // GC_locker::is_active() is checked. Since there is no safepoint in the |
duke@435 | 136 | // fast path of lock_critical() and unlock_critical(), there is no race |
duke@435 | 137 | // condition between the fast path and GC. After _needs_gc is set at a |
duke@435 | 138 | // safepoint, every thread will go through the slow path after the safepoint. |
duke@435 | 139 | // Since after a safepoint, each of the following two methods is either |
duke@435 | 140 | // entered from the method entry and falls into the slow path, or is |
duke@435 | 141 | // resumed from the safepoints in the method, which only exist in the slow |
duke@435 | 142 | // path. So when _needs_gc is set, the slow path is always taken, till |
duke@435 | 143 | // _needs_gc is cleared. |
duke@435 | 144 | static void lock_critical(JavaThread* thread); |
duke@435 | 145 | static void unlock_critical(JavaThread* thread); |
duke@435 | 146 | }; |
duke@435 | 147 | |
duke@435 | 148 | |
duke@435 | 149 | // A No_GC_Verifier object can be placed in methods where one assumes that |
duke@435 | 150 | // no garbage collection will occur. The destructor will verify this property |
duke@435 | 151 | // unless the constructor is called with argument false (not verifygc). |
duke@435 | 152 | // |
duke@435 | 153 | // The check will only be done in debug mode and if verifygc true. |
duke@435 | 154 | |
duke@435 | 155 | class No_GC_Verifier: public StackObj { |
duke@435 | 156 | friend class Pause_No_GC_Verifier; |
duke@435 | 157 | |
duke@435 | 158 | protected: |
duke@435 | 159 | bool _verifygc; |
duke@435 | 160 | unsigned int _old_invocations; |
duke@435 | 161 | |
duke@435 | 162 | public: |
duke@435 | 163 | #ifdef ASSERT |
duke@435 | 164 | No_GC_Verifier(bool verifygc = true); |
duke@435 | 165 | ~No_GC_Verifier(); |
duke@435 | 166 | #else |
duke@435 | 167 | No_GC_Verifier(bool verifygc = true) {} |
duke@435 | 168 | ~No_GC_Verifier() {} |
duke@435 | 169 | #endif |
duke@435 | 170 | }; |
duke@435 | 171 | |
duke@435 | 172 | // A Pause_No_GC_Verifier is used to temporarily pause the behavior |
duke@435 | 173 | // of a No_GC_Verifier object. If we are not in debug mode or if the |
duke@435 | 174 | // No_GC_Verifier object has a _verifygc value of false, then there |
duke@435 | 175 | // is nothing to do. |
duke@435 | 176 | |
duke@435 | 177 | class Pause_No_GC_Verifier: public StackObj { |
duke@435 | 178 | private: |
duke@435 | 179 | No_GC_Verifier * _ngcv; |
duke@435 | 180 | |
duke@435 | 181 | public: |
duke@435 | 182 | #ifdef ASSERT |
duke@435 | 183 | Pause_No_GC_Verifier(No_GC_Verifier * ngcv); |
duke@435 | 184 | ~Pause_No_GC_Verifier(); |
duke@435 | 185 | #else |
duke@435 | 186 | Pause_No_GC_Verifier(No_GC_Verifier * ngcv) {} |
duke@435 | 187 | ~Pause_No_GC_Verifier() {} |
duke@435 | 188 | #endif |
duke@435 | 189 | }; |
duke@435 | 190 | |
duke@435 | 191 | |
duke@435 | 192 | // A No_Safepoint_Verifier object will throw an assertion failure if |
duke@435 | 193 | // the current thread passes a possible safepoint while this object is |
duke@435 | 194 | // instantiated. A safepoint, will either be: an oop allocation, blocking |
duke@435 | 195 | // on a Mutex or JavaLock, or executing a VM operation. |
duke@435 | 196 | // |
duke@435 | 197 | // If StrictSafepointChecks is turned off, it degrades into a No_GC_Verifier |
duke@435 | 198 | // |
duke@435 | 199 | class No_Safepoint_Verifier : public No_GC_Verifier { |
duke@435 | 200 | friend class Pause_No_Safepoint_Verifier; |
duke@435 | 201 | |
duke@435 | 202 | private: |
duke@435 | 203 | bool _activated; |
duke@435 | 204 | Thread *_thread; |
duke@435 | 205 | public: |
duke@435 | 206 | #ifdef ASSERT |
never@533 | 207 | No_Safepoint_Verifier(bool activated = true, bool verifygc = true ) : |
never@533 | 208 | No_GC_Verifier(verifygc), |
never@533 | 209 | _activated(activated) { |
duke@435 | 210 | _thread = Thread::current(); |
duke@435 | 211 | if (_activated) { |
duke@435 | 212 | _thread->_allow_allocation_count++; |
duke@435 | 213 | _thread->_allow_safepoint_count++; |
duke@435 | 214 | } |
duke@435 | 215 | } |
duke@435 | 216 | |
duke@435 | 217 | ~No_Safepoint_Verifier() { |
duke@435 | 218 | if (_activated) { |
duke@435 | 219 | _thread->_allow_allocation_count--; |
duke@435 | 220 | _thread->_allow_safepoint_count--; |
duke@435 | 221 | } |
duke@435 | 222 | } |
duke@435 | 223 | #else |
duke@435 | 224 | No_Safepoint_Verifier(bool activated = true, bool verifygc = true) : No_GC_Verifier(verifygc){} |
duke@435 | 225 | ~No_Safepoint_Verifier() {} |
duke@435 | 226 | #endif |
duke@435 | 227 | }; |
duke@435 | 228 | |
duke@435 | 229 | // A Pause_No_Safepoint_Verifier is used to temporarily pause the |
duke@435 | 230 | // behavior of a No_Safepoint_Verifier object. If we are not in debug |
duke@435 | 231 | // mode then there is nothing to do. If the No_Safepoint_Verifier |
duke@435 | 232 | // object has an _activated value of false, then there is nothing to |
duke@435 | 233 | // do for safepoint and allocation checking, but there may still be |
duke@435 | 234 | // something to do for the underlying No_GC_Verifier object. |
duke@435 | 235 | |
duke@435 | 236 | class Pause_No_Safepoint_Verifier : public Pause_No_GC_Verifier { |
duke@435 | 237 | private: |
duke@435 | 238 | No_Safepoint_Verifier * _nsv; |
duke@435 | 239 | |
duke@435 | 240 | public: |
duke@435 | 241 | #ifdef ASSERT |
duke@435 | 242 | Pause_No_Safepoint_Verifier(No_Safepoint_Verifier * nsv) |
duke@435 | 243 | : Pause_No_GC_Verifier(nsv) { |
duke@435 | 244 | |
duke@435 | 245 | _nsv = nsv; |
duke@435 | 246 | if (_nsv->_activated) { |
duke@435 | 247 | _nsv->_thread->_allow_allocation_count--; |
duke@435 | 248 | _nsv->_thread->_allow_safepoint_count--; |
duke@435 | 249 | } |
duke@435 | 250 | } |
duke@435 | 251 | |
duke@435 | 252 | ~Pause_No_Safepoint_Verifier() { |
duke@435 | 253 | if (_nsv->_activated) { |
duke@435 | 254 | _nsv->_thread->_allow_allocation_count++; |
duke@435 | 255 | _nsv->_thread->_allow_safepoint_count++; |
duke@435 | 256 | } |
duke@435 | 257 | } |
duke@435 | 258 | #else |
duke@435 | 259 | Pause_No_Safepoint_Verifier(No_Safepoint_Verifier * nsv) |
duke@435 | 260 | : Pause_No_GC_Verifier(nsv) {} |
duke@435 | 261 | ~Pause_No_Safepoint_Verifier() {} |
duke@435 | 262 | #endif |
duke@435 | 263 | }; |
duke@435 | 264 | |
ysr@1241 | 265 | // A SkipGCALot object is used to elide the usual effect of gc-a-lot |
ysr@1241 | 266 | // over a section of execution by a thread. Currently, it's used only to |
ysr@1241 | 267 | // prevent re-entrant calls to GC. |
ysr@1241 | 268 | class SkipGCALot : public StackObj { |
ysr@1241 | 269 | private: |
ysr@1241 | 270 | bool _saved; |
ysr@1241 | 271 | Thread* _t; |
ysr@1241 | 272 | |
ysr@1241 | 273 | public: |
ysr@1241 | 274 | #ifdef ASSERT |
ysr@1241 | 275 | SkipGCALot(Thread* t) : _t(t) { |
ysr@1241 | 276 | _saved = _t->skip_gcalot(); |
ysr@1241 | 277 | _t->set_skip_gcalot(true); |
ysr@1241 | 278 | } |
ysr@1241 | 279 | |
ysr@1241 | 280 | ~SkipGCALot() { |
ysr@1241 | 281 | assert(_t->skip_gcalot(), "Save-restore protocol invariant"); |
ysr@1241 | 282 | _t->set_skip_gcalot(_saved); |
ysr@1241 | 283 | } |
ysr@1241 | 284 | #else |
ysr@1241 | 285 | SkipGCALot(Thread* t) { } |
ysr@1241 | 286 | ~SkipGCALot() { } |
ysr@1241 | 287 | #endif |
ysr@1241 | 288 | }; |
ysr@1241 | 289 | |
duke@435 | 290 | // JRT_LEAF currently can be called from either _thread_in_Java or |
duke@435 | 291 | // _thread_in_native mode. In _thread_in_native, it is ok |
duke@435 | 292 | // for another thread to trigger GC. The rest of the JRT_LEAF |
duke@435 | 293 | // rules apply. |
duke@435 | 294 | class JRT_Leaf_Verifier : public No_Safepoint_Verifier { |
duke@435 | 295 | static bool should_verify_GC(); |
duke@435 | 296 | public: |
duke@435 | 297 | #ifdef ASSERT |
duke@435 | 298 | JRT_Leaf_Verifier(); |
duke@435 | 299 | ~JRT_Leaf_Verifier(); |
duke@435 | 300 | #else |
duke@435 | 301 | JRT_Leaf_Verifier() {} |
duke@435 | 302 | ~JRT_Leaf_Verifier() {} |
duke@435 | 303 | #endif |
duke@435 | 304 | }; |
duke@435 | 305 | |
duke@435 | 306 | // A No_Alloc_Verifier object can be placed in methods where one assumes that |
duke@435 | 307 | // no allocation will occur. The destructor will verify this property |
duke@435 | 308 | // unless the constructor is called with argument false (not activated). |
duke@435 | 309 | // |
duke@435 | 310 | // The check will only be done in debug mode and if activated. |
duke@435 | 311 | // Note: this only makes sense at safepoints (otherwise, other threads may |
duke@435 | 312 | // allocate concurrently.) |
duke@435 | 313 | |
duke@435 | 314 | class No_Alloc_Verifier : public StackObj { |
duke@435 | 315 | private: |
duke@435 | 316 | bool _activated; |
duke@435 | 317 | |
duke@435 | 318 | public: |
duke@435 | 319 | #ifdef ASSERT |
duke@435 | 320 | No_Alloc_Verifier(bool activated = true) { |
duke@435 | 321 | _activated = activated; |
duke@435 | 322 | if (_activated) Thread::current()->_allow_allocation_count++; |
duke@435 | 323 | } |
duke@435 | 324 | |
duke@435 | 325 | ~No_Alloc_Verifier() { |
duke@435 | 326 | if (_activated) Thread::current()->_allow_allocation_count--; |
duke@435 | 327 | } |
duke@435 | 328 | #else |
duke@435 | 329 | No_Alloc_Verifier(bool activated = true) {} |
duke@435 | 330 | ~No_Alloc_Verifier() {} |
duke@435 | 331 | #endif |
duke@435 | 332 | }; |
stefank@2314 | 333 | |
stefank@2314 | 334 | #endif // SHARE_VM_MEMORY_GCLOCKER_HPP |