Sat, 07 Mar 2009 11:07:37 -0500
6814467: G1: small fixes related to concurrent marking verboseness
Summary: A few small fixes to remove some inconsistencies in the concurrent mark-related verbose GC output.
Reviewed-by: jmasa
ysr@777 | 1 | /* |
xdono@905 | 2 | * Copyright 2001-2008 Sun Microsystems, Inc. All Rights Reserved. |
ysr@777 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
ysr@777 | 4 | * |
ysr@777 | 5 | * This code is free software; you can redistribute it and/or modify it |
ysr@777 | 6 | * under the terms of the GNU General Public License version 2 only, as |
ysr@777 | 7 | * published by the Free Software Foundation. |
ysr@777 | 8 | * |
ysr@777 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
ysr@777 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
ysr@777 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
ysr@777 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
ysr@777 | 13 | * accompanied this code). |
ysr@777 | 14 | * |
ysr@777 | 15 | * You should have received a copy of the GNU General Public License version |
ysr@777 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
ysr@777 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
ysr@777 | 18 | * |
ysr@777 | 19 | * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara, |
ysr@777 | 20 | * CA 95054 USA or visit www.sun.com if you need additional information or |
ysr@777 | 21 | * have any questions. |
ysr@777 | 22 | * |
ysr@777 | 23 | */ |
ysr@777 | 24 | |
ysr@777 | 25 | # include "incls/_precompiled.incl" |
ysr@777 | 26 | # include "incls/_dirtyCardQueue.cpp.incl" |
ysr@777 | 27 | |
ysr@777 | 28 | bool DirtyCardQueue::apply_closure(CardTableEntryClosure* cl, |
ysr@777 | 29 | bool consume, |
ysr@777 | 30 | size_t worker_i) { |
ysr@777 | 31 | bool res = true; |
ysr@777 | 32 | if (_buf != NULL) { |
ysr@777 | 33 | res = apply_closure_to_buffer(cl, _buf, _index, _sz, |
ysr@777 | 34 | consume, |
ysr@777 | 35 | (int) worker_i); |
ysr@777 | 36 | if (res && consume) _index = _sz; |
ysr@777 | 37 | } |
ysr@777 | 38 | return res; |
ysr@777 | 39 | } |
ysr@777 | 40 | |
ysr@777 | 41 | bool DirtyCardQueue::apply_closure_to_buffer(CardTableEntryClosure* cl, |
ysr@777 | 42 | void** buf, |
ysr@777 | 43 | size_t index, size_t sz, |
ysr@777 | 44 | bool consume, |
ysr@777 | 45 | int worker_i) { |
ysr@777 | 46 | if (cl == NULL) return true; |
ysr@777 | 47 | for (size_t i = index; i < sz; i += oopSize) { |
ysr@777 | 48 | int ind = byte_index_to_index((int)i); |
ysr@777 | 49 | jbyte* card_ptr = (jbyte*)buf[ind]; |
ysr@777 | 50 | if (card_ptr != NULL) { |
ysr@777 | 51 | // Set the entry to null, so we don't do it again (via the test |
ysr@777 | 52 | // above) if we reconsider this buffer. |
ysr@777 | 53 | if (consume) buf[ind] = NULL; |
ysr@777 | 54 | if (!cl->do_card_ptr(card_ptr, worker_i)) return false; |
ysr@777 | 55 | } |
ysr@777 | 56 | } |
ysr@777 | 57 | return true; |
ysr@777 | 58 | } |
ysr@777 | 59 | |
ysr@777 | 60 | #ifdef _MSC_VER // the use of 'this' below gets a warning, make it go away |
ysr@777 | 61 | #pragma warning( disable:4355 ) // 'this' : used in base member initializer list |
ysr@777 | 62 | #endif // _MSC_VER |
ysr@777 | 63 | |
ysr@777 | 64 | DirtyCardQueueSet::DirtyCardQueueSet() : |
ysr@777 | 65 | PtrQueueSet(true /*notify_when_complete*/), |
ysr@777 | 66 | _closure(NULL), |
ysr@777 | 67 | _shared_dirty_card_queue(this, true /*perm*/), |
ysr@777 | 68 | _free_ids(NULL), |
ysr@777 | 69 | _processed_buffers_mut(0), _processed_buffers_rs_thread(0) |
ysr@777 | 70 | { |
ysr@777 | 71 | _all_active = true; |
ysr@777 | 72 | } |
ysr@777 | 73 | |
ysr@777 | 74 | size_t DirtyCardQueueSet::num_par_ids() { |
ysr@777 | 75 | return MAX2(ParallelGCThreads, (size_t)2); |
ysr@777 | 76 | } |
ysr@777 | 77 | |
ysr@777 | 78 | |
ysr@777 | 79 | void DirtyCardQueueSet::initialize(Monitor* cbl_mon, Mutex* fl_lock, |
ysr@777 | 80 | int max_completed_queue, |
iveresov@1051 | 81 | Mutex* lock, PtrQueueSet* fl_owner) { |
iveresov@1051 | 82 | PtrQueueSet::initialize(cbl_mon, fl_lock, max_completed_queue, fl_owner); |
ysr@777 | 83 | set_buffer_size(DCQBarrierQueueBufferSize); |
ysr@777 | 84 | set_process_completed_threshold(DCQBarrierProcessCompletedThreshold); |
ysr@777 | 85 | |
ysr@777 | 86 | _shared_dirty_card_queue.set_lock(lock); |
ysr@777 | 87 | _free_ids = new FreeIdSet((int) num_par_ids(), _cbl_mon); |
ysr@777 | 88 | bool b = _free_ids->claim_perm_id(0); |
ysr@777 | 89 | guarantee(b, "Must reserve id zero for concurrent refinement thread."); |
ysr@777 | 90 | } |
ysr@777 | 91 | |
ysr@777 | 92 | void DirtyCardQueueSet::handle_zero_index_for_thread(JavaThread* t) { |
ysr@777 | 93 | t->dirty_card_queue().handle_zero_index(); |
ysr@777 | 94 | } |
ysr@777 | 95 | |
ysr@777 | 96 | void DirtyCardQueueSet::set_closure(CardTableEntryClosure* closure) { |
ysr@777 | 97 | _closure = closure; |
ysr@777 | 98 | } |
ysr@777 | 99 | |
ysr@777 | 100 | void DirtyCardQueueSet::iterate_closure_all_threads(bool consume, |
ysr@777 | 101 | size_t worker_i) { |
ysr@777 | 102 | assert(SafepointSynchronize::is_at_safepoint(), "Must be at safepoint."); |
ysr@777 | 103 | for(JavaThread* t = Threads::first(); t; t = t->next()) { |
ysr@777 | 104 | bool b = t->dirty_card_queue().apply_closure(_closure, consume); |
ysr@777 | 105 | guarantee(b, "Should not be interrupted."); |
ysr@777 | 106 | } |
ysr@777 | 107 | bool b = shared_dirty_card_queue()->apply_closure(_closure, |
ysr@777 | 108 | consume, |
ysr@777 | 109 | worker_i); |
ysr@777 | 110 | guarantee(b, "Should not be interrupted."); |
ysr@777 | 111 | } |
ysr@777 | 112 | |
ysr@777 | 113 | bool DirtyCardQueueSet::mut_process_buffer(void** buf) { |
ysr@777 | 114 | |
ysr@777 | 115 | // Used to determine if we had already claimed a par_id |
ysr@777 | 116 | // before entering this method. |
ysr@777 | 117 | bool already_claimed = false; |
ysr@777 | 118 | |
ysr@777 | 119 | // We grab the current JavaThread. |
ysr@777 | 120 | JavaThread* thread = JavaThread::current(); |
ysr@777 | 121 | |
ysr@777 | 122 | // We get the the number of any par_id that this thread |
ysr@777 | 123 | // might have already claimed. |
ysr@777 | 124 | int worker_i = thread->get_claimed_par_id(); |
ysr@777 | 125 | |
ysr@777 | 126 | // If worker_i is not -1 then the thread has already claimed |
ysr@777 | 127 | // a par_id. We make note of it using the already_claimed value |
ysr@777 | 128 | if (worker_i != -1) { |
ysr@777 | 129 | already_claimed = true; |
ysr@777 | 130 | } else { |
ysr@777 | 131 | |
ysr@777 | 132 | // Otherwise we need to claim a par id |
ysr@777 | 133 | worker_i = _free_ids->claim_par_id(); |
ysr@777 | 134 | |
ysr@777 | 135 | // And store the par_id value in the thread |
ysr@777 | 136 | thread->set_claimed_par_id(worker_i); |
ysr@777 | 137 | } |
ysr@777 | 138 | |
ysr@777 | 139 | bool b = false; |
ysr@777 | 140 | if (worker_i != -1) { |
ysr@777 | 141 | b = DirtyCardQueue::apply_closure_to_buffer(_closure, buf, 0, |
ysr@777 | 142 | _sz, true, worker_i); |
ysr@777 | 143 | if (b) Atomic::inc(&_processed_buffers_mut); |
ysr@777 | 144 | |
ysr@777 | 145 | // If we had not claimed an id before entering the method |
ysr@777 | 146 | // then we must release the id. |
ysr@777 | 147 | if (!already_claimed) { |
ysr@777 | 148 | |
ysr@777 | 149 | // we release the id |
ysr@777 | 150 | _free_ids->release_par_id(worker_i); |
ysr@777 | 151 | |
ysr@777 | 152 | // and set the claimed_id in the thread to -1 |
ysr@777 | 153 | thread->set_claimed_par_id(-1); |
ysr@777 | 154 | } |
ysr@777 | 155 | } |
ysr@777 | 156 | return b; |
ysr@777 | 157 | } |
ysr@777 | 158 | |
ysr@777 | 159 | DirtyCardQueueSet::CompletedBufferNode* |
ysr@777 | 160 | DirtyCardQueueSet::get_completed_buffer_lock(int stop_at) { |
ysr@777 | 161 | CompletedBufferNode* nd = NULL; |
ysr@777 | 162 | MutexLockerEx x(_cbl_mon, Mutex::_no_safepoint_check_flag); |
ysr@777 | 163 | |
ysr@777 | 164 | if ((int)_n_completed_buffers <= stop_at) { |
ysr@777 | 165 | _process_completed = false; |
ysr@777 | 166 | return NULL; |
ysr@777 | 167 | } |
ysr@777 | 168 | |
ysr@777 | 169 | if (_completed_buffers_head != NULL) { |
ysr@777 | 170 | nd = _completed_buffers_head; |
ysr@777 | 171 | _completed_buffers_head = nd->next; |
ysr@777 | 172 | if (_completed_buffers_head == NULL) |
ysr@777 | 173 | _completed_buffers_tail = NULL; |
ysr@777 | 174 | _n_completed_buffers--; |
ysr@777 | 175 | } |
ysr@777 | 176 | debug_only(assert_completed_buffer_list_len_correct_locked()); |
ysr@777 | 177 | return nd; |
ysr@777 | 178 | } |
ysr@777 | 179 | |
ysr@777 | 180 | // We only do this in contexts where there is no concurrent enqueueing. |
ysr@777 | 181 | DirtyCardQueueSet::CompletedBufferNode* |
ysr@777 | 182 | DirtyCardQueueSet::get_completed_buffer_CAS() { |
ysr@777 | 183 | CompletedBufferNode* nd = _completed_buffers_head; |
ysr@777 | 184 | |
ysr@777 | 185 | while (nd != NULL) { |
ysr@777 | 186 | CompletedBufferNode* next = nd->next; |
ysr@777 | 187 | CompletedBufferNode* result = |
ysr@777 | 188 | (CompletedBufferNode*)Atomic::cmpxchg_ptr(next, |
ysr@777 | 189 | &_completed_buffers_head, |
ysr@777 | 190 | nd); |
ysr@777 | 191 | if (result == nd) { |
ysr@777 | 192 | return result; |
ysr@777 | 193 | } else { |
ysr@777 | 194 | nd = _completed_buffers_head; |
ysr@777 | 195 | } |
ysr@777 | 196 | } |
ysr@777 | 197 | assert(_completed_buffers_head == NULL, "Loop post"); |
ysr@777 | 198 | _completed_buffers_tail = NULL; |
ysr@777 | 199 | return NULL; |
ysr@777 | 200 | } |
ysr@777 | 201 | |
ysr@777 | 202 | bool DirtyCardQueueSet:: |
ysr@777 | 203 | apply_closure_to_completed_buffer_helper(int worker_i, |
ysr@777 | 204 | CompletedBufferNode* nd) { |
ysr@777 | 205 | if (nd != NULL) { |
ysr@777 | 206 | bool b = |
ysr@777 | 207 | DirtyCardQueue::apply_closure_to_buffer(_closure, nd->buf, |
ysr@777 | 208 | nd->index, _sz, |
ysr@777 | 209 | true, worker_i); |
ysr@777 | 210 | void** buf = nd->buf; |
tonyp@799 | 211 | size_t index = nd->index; |
ysr@777 | 212 | delete nd; |
ysr@777 | 213 | if (b) { |
ysr@777 | 214 | deallocate_buffer(buf); |
ysr@777 | 215 | return true; // In normal case, go on to next buffer. |
ysr@777 | 216 | } else { |
tonyp@799 | 217 | enqueue_complete_buffer(buf, index, true); |
ysr@777 | 218 | return false; |
ysr@777 | 219 | } |
ysr@777 | 220 | } else { |
ysr@777 | 221 | return false; |
ysr@777 | 222 | } |
ysr@777 | 223 | } |
ysr@777 | 224 | |
ysr@777 | 225 | bool DirtyCardQueueSet::apply_closure_to_completed_buffer(int worker_i, |
ysr@777 | 226 | int stop_at, |
ysr@777 | 227 | bool with_CAS) |
ysr@777 | 228 | { |
ysr@777 | 229 | CompletedBufferNode* nd = NULL; |
ysr@777 | 230 | if (with_CAS) { |
ysr@777 | 231 | guarantee(stop_at == 0, "Precondition"); |
ysr@777 | 232 | nd = get_completed_buffer_CAS(); |
ysr@777 | 233 | } else { |
ysr@777 | 234 | nd = get_completed_buffer_lock(stop_at); |
ysr@777 | 235 | } |
ysr@777 | 236 | bool res = apply_closure_to_completed_buffer_helper(worker_i, nd); |
ysr@777 | 237 | if (res) _processed_buffers_rs_thread++; |
ysr@777 | 238 | return res; |
ysr@777 | 239 | } |
ysr@777 | 240 | |
ysr@777 | 241 | void DirtyCardQueueSet::apply_closure_to_all_completed_buffers() { |
ysr@777 | 242 | CompletedBufferNode* nd = _completed_buffers_head; |
ysr@777 | 243 | while (nd != NULL) { |
ysr@777 | 244 | bool b = |
ysr@777 | 245 | DirtyCardQueue::apply_closure_to_buffer(_closure, nd->buf, 0, _sz, |
ysr@777 | 246 | false); |
ysr@777 | 247 | guarantee(b, "Should not stop early."); |
ysr@777 | 248 | nd = nd->next; |
ysr@777 | 249 | } |
ysr@777 | 250 | } |
ysr@777 | 251 | |
ysr@777 | 252 | void DirtyCardQueueSet::abandon_logs() { |
ysr@777 | 253 | assert(SafepointSynchronize::is_at_safepoint(), "Must be at safepoint."); |
ysr@777 | 254 | CompletedBufferNode* buffers_to_delete = NULL; |
ysr@777 | 255 | { |
ysr@777 | 256 | MutexLockerEx x(_cbl_mon, Mutex::_no_safepoint_check_flag); |
ysr@777 | 257 | while (_completed_buffers_head != NULL) { |
ysr@777 | 258 | CompletedBufferNode* nd = _completed_buffers_head; |
ysr@777 | 259 | _completed_buffers_head = nd->next; |
ysr@777 | 260 | nd->next = buffers_to_delete; |
ysr@777 | 261 | buffers_to_delete = nd; |
ysr@777 | 262 | } |
ysr@777 | 263 | _n_completed_buffers = 0; |
ysr@777 | 264 | _completed_buffers_tail = NULL; |
ysr@777 | 265 | debug_only(assert_completed_buffer_list_len_correct_locked()); |
ysr@777 | 266 | } |
ysr@777 | 267 | while (buffers_to_delete != NULL) { |
ysr@777 | 268 | CompletedBufferNode* nd = buffers_to_delete; |
ysr@777 | 269 | buffers_to_delete = nd->next; |
ysr@777 | 270 | deallocate_buffer(nd->buf); |
ysr@777 | 271 | delete nd; |
ysr@777 | 272 | } |
ysr@777 | 273 | // Since abandon is done only at safepoints, we can safely manipulate |
ysr@777 | 274 | // these queues. |
ysr@777 | 275 | for (JavaThread* t = Threads::first(); t; t = t->next()) { |
ysr@777 | 276 | t->dirty_card_queue().reset(); |
ysr@777 | 277 | } |
ysr@777 | 278 | shared_dirty_card_queue()->reset(); |
ysr@777 | 279 | } |
ysr@777 | 280 | |
ysr@777 | 281 | |
ysr@777 | 282 | void DirtyCardQueueSet::concatenate_logs() { |
ysr@777 | 283 | // Iterate over all the threads, if we find a partial log add it to |
ysr@777 | 284 | // the global list of logs. Temporarily turn off the limit on the number |
ysr@777 | 285 | // of outstanding buffers. |
ysr@777 | 286 | int save_max_completed_queue = _max_completed_queue; |
ysr@777 | 287 | _max_completed_queue = max_jint; |
ysr@777 | 288 | assert(SafepointSynchronize::is_at_safepoint(), "Must be at safepoint."); |
ysr@777 | 289 | for (JavaThread* t = Threads::first(); t; t = t->next()) { |
ysr@777 | 290 | DirtyCardQueue& dcq = t->dirty_card_queue(); |
ysr@777 | 291 | if (dcq.size() != 0) { |
ysr@777 | 292 | void **buf = t->dirty_card_queue().get_buf(); |
ysr@777 | 293 | // We must NULL out the unused entries, then enqueue. |
ysr@777 | 294 | for (size_t i = 0; i < t->dirty_card_queue().get_index(); i += oopSize) { |
ysr@777 | 295 | buf[PtrQueue::byte_index_to_index((int)i)] = NULL; |
ysr@777 | 296 | } |
ysr@777 | 297 | enqueue_complete_buffer(dcq.get_buf(), dcq.get_index()); |
ysr@777 | 298 | dcq.reinitialize(); |
ysr@777 | 299 | } |
ysr@777 | 300 | } |
ysr@777 | 301 | if (_shared_dirty_card_queue.size() != 0) { |
ysr@777 | 302 | enqueue_complete_buffer(_shared_dirty_card_queue.get_buf(), |
ysr@777 | 303 | _shared_dirty_card_queue.get_index()); |
ysr@777 | 304 | _shared_dirty_card_queue.reinitialize(); |
ysr@777 | 305 | } |
ysr@777 | 306 | // Restore the completed buffer queue limit. |
ysr@777 | 307 | _max_completed_queue = save_max_completed_queue; |
ysr@777 | 308 | } |