src/share/vm/gc_implementation/g1/g1RemSet.cpp

Mon, 21 Jul 2014 09:59:46 +0200

author
tschatzl
date
Mon, 21 Jul 2014 09:59:46 +0200
changeset 7007
7df07d855c8e
parent 6969
02e61cf08ab3
child 7049
eec72fa4b108
permissions
-rw-r--r--

8048085: Aborting marking just before remark results in useless additional clearing of the next mark bitmap
Summary: Skip clearing the next bitmap if we just recently aborted since the full GC already clears this bitmap.
Reviewed-by: brutisso

ysr@777 1 /*
drchase@6680 2 * Copyright (c) 2001, 2014, Oracle and/or its affiliates. All rights reserved.
ysr@777 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
ysr@777 4 *
ysr@777 5 * This code is free software; you can redistribute it and/or modify it
ysr@777 6 * under the terms of the GNU General Public License version 2 only, as
ysr@777 7 * published by the Free Software Foundation.
ysr@777 8 *
ysr@777 9 * This code is distributed in the hope that it will be useful, but WITHOUT
ysr@777 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
ysr@777 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
ysr@777 12 * version 2 for more details (a copy is included in the LICENSE file that
ysr@777 13 * accompanied this code).
ysr@777 14 *
ysr@777 15 * You should have received a copy of the GNU General Public License version
ysr@777 16 * 2 along with this work; if not, write to the Free Software Foundation,
ysr@777 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
ysr@777 18 *
trims@1907 19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
trims@1907 20 * or visit www.oracle.com if you need additional information or have any
trims@1907 21 * questions.
ysr@777 22 *
ysr@777 23 */
ysr@777 24
stefank@2314 25 #include "precompiled.hpp"
stefank@2314 26 #include "gc_implementation/g1/concurrentG1Refine.hpp"
stefank@2314 27 #include "gc_implementation/g1/concurrentG1RefineThread.hpp"
stefank@2314 28 #include "gc_implementation/g1/g1BlockOffsetTable.inline.hpp"
stefank@2314 29 #include "gc_implementation/g1/g1CollectedHeap.inline.hpp"
stefank@2314 30 #include "gc_implementation/g1/g1CollectorPolicy.hpp"
johnc@5078 31 #include "gc_implementation/g1/g1HotCardCache.hpp"
brutisso@3923 32 #include "gc_implementation/g1/g1GCPhaseTimes.hpp"
stefank@2314 33 #include "gc_implementation/g1/g1OopClosures.inline.hpp"
stefank@2314 34 #include "gc_implementation/g1/g1RemSet.inline.hpp"
stefank@2314 35 #include "gc_implementation/g1/heapRegionSeq.inline.hpp"
tschatzl@5204 36 #include "gc_implementation/g1/heapRegionRemSet.hpp"
stefank@2314 37 #include "memory/iterator.hpp"
stefank@2314 38 #include "oops/oop.inline.hpp"
stefank@2314 39 #include "utilities/intHisto.hpp"
ysr@777 40
drchase@6680 41 PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC
drchase@6680 42
ysr@777 43 #define CARD_REPEAT_HISTO 0
ysr@777 44
ysr@777 45 #if CARD_REPEAT_HISTO
ysr@777 46 static size_t ct_freq_sz;
ysr@777 47 static jbyte* ct_freq = NULL;
ysr@777 48
ysr@777 49 void init_ct_freq_table(size_t heap_sz_bytes) {
ysr@777 50 if (ct_freq == NULL) {
ysr@777 51 ct_freq_sz = heap_sz_bytes/CardTableModRefBS::card_size;
ysr@777 52 ct_freq = new jbyte[ct_freq_sz];
ysr@777 53 for (size_t j = 0; j < ct_freq_sz; j++) ct_freq[j] = 0;
ysr@777 54 }
ysr@777 55 }
ysr@777 56
ysr@777 57 void ct_freq_note_card(size_t index) {
ysr@777 58 assert(0 <= index && index < ct_freq_sz, "Bounds error.");
ysr@777 59 if (ct_freq[index] < 100) { ct_freq[index]++; }
ysr@777 60 }
ysr@777 61
ysr@777 62 static IntHistogram card_repeat_count(10, 10);
ysr@777 63
ysr@777 64 void ct_freq_update_histo_and_reset() {
ysr@777 65 for (size_t j = 0; j < ct_freq_sz; j++) {
ysr@777 66 card_repeat_count.add_entry(ct_freq[j]);
ysr@777 67 ct_freq[j] = 0;
ysr@777 68 }
ysr@777 69
ysr@777 70 }
ysr@777 71 #endif
ysr@777 72
johnc@2216 73 G1RemSet::G1RemSet(G1CollectedHeap* g1, CardTableModRefBS* ct_bs)
johnc@2216 74 : _g1(g1), _conc_refine_cards(0),
johnc@2216 75 _ct_bs(ct_bs), _g1p(_g1->g1_policy()),
ysr@777 76 _cg1r(g1->concurrent_g1_refine()),
johnc@2060 77 _cset_rs_update_cl(NULL),
tschatzl@5204 78 _cards_scanned(NULL), _total_cards_scanned(0),
tschatzl@5204 79 _prev_period_summary()
ysr@777 80 {
ysr@777 81 _seq_task = new SubTasksDone(NumSeqTasks);
iveresov@1051 82 guarantee(n_workers() > 0, "There should be some workers");
zgu@3900 83 _cset_rs_update_cl = NEW_C_HEAP_ARRAY(OopsInHeapRegionClosure*, n_workers(), mtGC);
iveresov@1051 84 for (uint i = 0; i < n_workers(); i++) {
johnc@2060 85 _cset_rs_update_cl[i] = NULL;
iveresov@1051 86 }
tschatzl@5812 87 if (G1SummarizeRSetStats) {
tschatzl@5812 88 _prev_period_summary.initialize(this);
tschatzl@5812 89 }
ysr@777 90 }
ysr@777 91
johnc@2216 92 G1RemSet::~G1RemSet() {
ysr@777 93 delete _seq_task;
iveresov@1051 94 for (uint i = 0; i < n_workers(); i++) {
johnc@2060 95 assert(_cset_rs_update_cl[i] == NULL, "it should be");
iveresov@1051 96 }
zgu@3900 97 FREE_C_HEAP_ARRAY(OopsInHeapRegionClosure*, _cset_rs_update_cl, mtGC);
ysr@777 98 }
ysr@777 99
ysr@777 100 void CountNonCleanMemRegionClosure::do_MemRegion(MemRegion mr) {
ysr@777 101 if (_g1->is_in_g1_reserved(mr.start())) {
ysr@777 102 _n += (int) ((mr.byte_size() / CardTableModRefBS::card_size));
ysr@777 103 if (_start_first == NULL) _start_first = mr.start();
ysr@777 104 }
ysr@777 105 }
ysr@777 106
ysr@777 107 class ScanRSClosure : public HeapRegionClosure {
ysr@777 108 size_t _cards_done, _cards;
ysr@777 109 G1CollectedHeap* _g1h;
johnc@5548 110
ysr@777 111 OopsInHeapRegionClosure* _oc;
johnc@5548 112 CodeBlobToOopClosure* _code_root_cl;
johnc@5548 113
ysr@777 114 G1BlockOffsetSharedArray* _bot_shared;
mgerdin@5811 115 G1SATBCardTableModRefBS *_ct_bs;
johnc@5548 116
johnc@5548 117 double _strong_code_root_scan_time_sec;
vkempik@6552 118 uint _worker_i;
johnc@5548 119 int _block_size;
johnc@5548 120 bool _try_claimed;
johnc@5548 121
ysr@777 122 public:
johnc@5548 123 ScanRSClosure(OopsInHeapRegionClosure* oc,
johnc@5548 124 CodeBlobToOopClosure* code_root_cl,
vkempik@6552 125 uint worker_i) :
ysr@777 126 _oc(oc),
johnc@5548 127 _code_root_cl(code_root_cl),
johnc@5548 128 _strong_code_root_scan_time_sec(0.0),
ysr@777 129 _cards(0),
ysr@777 130 _cards_done(0),
ysr@777 131 _worker_i(worker_i),
ysr@777 132 _try_claimed(false)
ysr@777 133 {
ysr@777 134 _g1h = G1CollectedHeap::heap();
ysr@777 135 _bot_shared = _g1h->bot_shared();
mgerdin@5811 136 _ct_bs = _g1h->g1_barrier_set();
iveresov@1696 137 _block_size = MAX2<int>(G1RSetScanBlockSize, 1);
ysr@777 138 }
ysr@777 139
ysr@777 140 void set_try_claimed() { _try_claimed = true; }
ysr@777 141
ysr@777 142 void scanCard(size_t index, HeapRegion *r) {
johnc@3219 143 // Stack allocate the DirtyCardToOopClosure instance
johnc@3219 144 HeapRegionDCTOC cl(_g1h, r, _oc,
johnc@3219 145 CardTableModRefBS::Precise,
johnc@3219 146 HeapRegionDCTOC::IntoCSFilterKind);
ysr@777 147
ysr@777 148 // Set the "from" region in the closure.
ysr@777 149 _oc->set_region(r);
ysr@777 150 HeapWord* card_start = _bot_shared->address_for_index(index);
ysr@777 151 HeapWord* card_end = card_start + G1BlockOffsetSharedArray::N_words;
ysr@777 152 Space *sp = SharedHeap::heap()->space_containing(card_start);
tonyp@2849 153 MemRegion sm_region = sp->used_region_at_save_marks();
ysr@777 154 MemRegion mr = sm_region.intersection(MemRegion(card_start,card_end));
tonyp@2849 155 if (!mr.is_empty() && !_ct_bs->is_card_claimed(index)) {
tonyp@2849 156 // We make the card as "claimed" lazily (so races are possible
tonyp@2849 157 // but they're benign), which reduces the number of duplicate
tonyp@2849 158 // scans (the rsets of the regions in the cset can intersect).
tonyp@2849 159 _ct_bs->set_card_claimed(index);
tonyp@2849 160 _cards_done++;
johnc@3219 161 cl.do_MemRegion(mr);
ysr@777 162 }
ysr@777 163 }
ysr@777 164
ysr@777 165 void printCard(HeapRegion* card_region, size_t card_index,
ysr@777 166 HeapWord* card_start) {
vkempik@6552 167 gclog_or_tty->print_cr("T " UINT32_FORMAT " Region [" PTR_FORMAT ", " PTR_FORMAT ") "
ysr@777 168 "RS names card %p: "
ysr@777 169 "[" PTR_FORMAT ", " PTR_FORMAT ")",
ysr@777 170 _worker_i,
ysr@777 171 card_region->bottom(), card_region->end(),
ysr@777 172 card_index,
ysr@777 173 card_start, card_start + G1BlockOffsetSharedArray::N_words);
ysr@777 174 }
ysr@777 175
johnc@5548 176 void scan_strong_code_roots(HeapRegion* r) {
johnc@5548 177 double scan_start = os::elapsedTime();
johnc@5548 178 r->strong_code_roots_do(_code_root_cl);
johnc@5548 179 _strong_code_root_scan_time_sec += (os::elapsedTime() - scan_start);
johnc@5548 180 }
johnc@5548 181
ysr@777 182 bool doHeapRegion(HeapRegion* r) {
ysr@777 183 assert(r->in_collection_set(), "should only be called on elements of CS.");
ysr@777 184 HeapRegionRemSet* hrrs = r->rem_set();
ysr@777 185 if (hrrs->iter_is_complete()) return false; // All done.
ysr@777 186 if (!_try_claimed && !hrrs->claim_iter()) return false;
tonyp@2849 187 // If we ever free the collection set concurrently, we should also
tonyp@2849 188 // clear the card table concurrently therefore we won't need to
tonyp@2849 189 // add regions of the collection set to the dirty cards region.
apetrusenko@1231 190 _g1h->push_dirty_cards_region(r);
ysr@777 191 // If we didn't return above, then
ysr@777 192 // _try_claimed || r->claim_iter()
ysr@777 193 // is true: either we're supposed to work on claimed-but-not-complete
ysr@777 194 // regions, or we successfully claimed the region.
johnc@5548 195
johnc@5014 196 HeapRegionRemSetIterator iter(hrrs);
ysr@777 197 size_t card_index;
iveresov@1696 198
iveresov@1696 199 // We claim cards in block so as to recude the contention. The block size is determined by
iveresov@1696 200 // the G1RSetScanBlockSize parameter.
iveresov@1696 201 size_t jump_to_card = hrrs->iter_claimed_next(_block_size);
johnc@5014 202 for (size_t current_card = 0; iter.has_next(card_index); current_card++) {
iveresov@1696 203 if (current_card >= jump_to_card + _block_size) {
iveresov@1696 204 jump_to_card = hrrs->iter_claimed_next(_block_size);
iveresov@1182 205 }
iveresov@1696 206 if (current_card < jump_to_card) continue;
ysr@777 207 HeapWord* card_start = _g1h->bot_shared()->address_for_index(card_index);
ysr@777 208 #if 0
ysr@777 209 gclog_or_tty->print("Rem set iteration yielded card [" PTR_FORMAT ", " PTR_FORMAT ").\n",
ysr@777 210 card_start, card_start + CardTableModRefBS::card_size_in_words);
ysr@777 211 #endif
ysr@777 212
ysr@777 213 HeapRegion* card_region = _g1h->heap_region_containing(card_start);
ysr@777 214 assert(card_region != NULL, "Yielding cards not in the heap?");
ysr@777 215 _cards++;
ysr@777 216
apetrusenko@1231 217 if (!card_region->is_on_dirty_cards_region_list()) {
apetrusenko@1231 218 _g1h->push_dirty_cards_region(card_region);
apetrusenko@1231 219 }
apetrusenko@1231 220
tonyp@2849 221 // If the card is dirty, then we will scan it during updateRS.
tonyp@2849 222 if (!card_region->in_collection_set() &&
tonyp@2849 223 !_ct_bs->is_card_dirty(card_index)) {
tonyp@2849 224 scanCard(card_index, card_region);
ysr@777 225 }
ysr@777 226 }
iveresov@1182 227 if (!_try_claimed) {
johnc@5548 228 // Scan the strong code root list attached to the current region
johnc@5548 229 scan_strong_code_roots(r);
johnc@5548 230
iveresov@1182 231 hrrs->set_iter_complete();
iveresov@1182 232 }
ysr@777 233 return false;
ysr@777 234 }
johnc@5548 235
johnc@5548 236 double strong_code_root_scan_time_sec() {
johnc@5548 237 return _strong_code_root_scan_time_sec;
johnc@5548 238 }
johnc@5548 239
ysr@777 240 size_t cards_done() { return _cards_done;}
ysr@777 241 size_t cards_looked_up() { return _cards;}
ysr@777 242 };
ysr@777 243
johnc@5548 244 void G1RemSet::scanRS(OopsInHeapRegionClosure* oc,
johnc@5548 245 CodeBlobToOopClosure* code_root_cl,
vkempik@6552 246 uint worker_i) {
ysr@777 247 double rs_time_start = os::elapsedTime();
johnc@3296 248 HeapRegion *startRegion = _g1->start_cset_region_for_worker(worker_i);
ysr@777 249
johnc@5548 250 ScanRSClosure scanRScl(oc, code_root_cl, worker_i);
johnc@3175 251
ysr@777 252 _g1->collection_set_iterate_from(startRegion, &scanRScl);
ysr@777 253 scanRScl.set_try_claimed();
ysr@777 254 _g1->collection_set_iterate_from(startRegion, &scanRScl);
ysr@777 255
johnc@5548 256 double scan_rs_time_sec = (os::elapsedTime() - rs_time_start)
johnc@5548 257 - scanRScl.strong_code_root_scan_time_sec();
ysr@777 258
johnc@5548 259 assert(_cards_scanned != NULL, "invariant");
ysr@777 260 _cards_scanned[worker_i] = scanRScl.cards_done();
ysr@777 261
brutisso@3923 262 _g1p->phase_times()->record_scan_rs_time(worker_i, scan_rs_time_sec * 1000.0);
johnc@5548 263 _g1p->phase_times()->record_strong_code_root_scan_time(worker_i,
johnc@5548 264 scanRScl.strong_code_root_scan_time_sec() * 1000.0);
ysr@777 265 }
ysr@777 266
johnc@2060 267 // Closure used for updating RSets and recording references that
johnc@2060 268 // point into the collection set. Only called during an
johnc@2060 269 // evacuation pause.
ysr@777 270
johnc@2060 271 class RefineRecordRefsIntoCSCardTableEntryClosure: public CardTableEntryClosure {
johnc@2060 272 G1RemSet* _g1rs;
johnc@2060 273 DirtyCardQueue* _into_cset_dcq;
johnc@2060 274 public:
johnc@2060 275 RefineRecordRefsIntoCSCardTableEntryClosure(G1CollectedHeap* g1h,
johnc@2060 276 DirtyCardQueue* into_cset_dcq) :
johnc@2060 277 _g1rs(g1h->g1_rem_set()), _into_cset_dcq(into_cset_dcq)
johnc@2060 278 {}
vkempik@6552 279 bool do_card_ptr(jbyte* card_ptr, uint worker_i) {
johnc@2060 280 // The only time we care about recording cards that
johnc@2060 281 // contain references that point into the collection set
johnc@2060 282 // is during RSet updating within an evacuation pause.
johnc@2060 283 // In this case worker_i should be the id of a GC worker thread.
johnc@2060 284 assert(SafepointSynchronize::is_at_safepoint(), "not during an evacuation pause");
vkempik@6552 285 assert(worker_i < (ParallelGCThreads == 0 ? 1 : ParallelGCThreads), "should be a GC worker");
johnc@2060 286
johnc@5078 287 if (_g1rs->refine_card(card_ptr, worker_i, true)) {
johnc@2060 288 // 'card_ptr' contains references that point into the collection
johnc@2060 289 // set. We need to record the card in the DCQS
johnc@2060 290 // (G1CollectedHeap::into_cset_dirty_card_queue_set())
johnc@2060 291 // that's used for that purpose.
johnc@2060 292 //
johnc@2060 293 // Enqueue the card
johnc@2060 294 _into_cset_dcq->enqueue(card_ptr);
johnc@2060 295 }
johnc@2060 296 return true;
johnc@2060 297 }
johnc@2060 298 };
johnc@2060 299
vkempik@6552 300 void G1RemSet::updateRS(DirtyCardQueue* into_cset_dcq, uint worker_i) {
ysr@777 301 double start = os::elapsedTime();
johnc@2060 302 // Apply the given closure to all remaining log entries.
johnc@2060 303 RefineRecordRefsIntoCSCardTableEntryClosure into_cset_update_rs_cl(_g1, into_cset_dcq);
johnc@3175 304
johnc@2060 305 _g1->iterate_dirty_card_closure(&into_cset_update_rs_cl, into_cset_dcq, false, worker_i);
johnc@2060 306
iveresov@1229 307 // Now there should be no dirty cards.
iveresov@1229 308 if (G1RSLogCheckCardTable) {
iveresov@1229 309 CountNonCleanMemRegionClosure cl(_g1);
iveresov@1229 310 _ct_bs->mod_card_iterate(&cl);
iveresov@1229 311 // XXX This isn't true any more: keeping cards of young regions
iveresov@1229 312 // marked dirty broke it. Need some reasonable fix.
iveresov@1229 313 guarantee(cl.n() == 0, "Card table should be clean.");
ysr@777 314 }
iveresov@1229 315
brutisso@3923 316 _g1p->phase_times()->record_update_rs_time(worker_i, (os::elapsedTime() - start) * 1000.0);
ysr@777 317 }
ysr@777 318
johnc@2216 319 void G1RemSet::cleanupHRRS() {
ysr@777 320 HeapRegionRemSet::cleanup();
ysr@777 321 }
ysr@777 322
johnc@2216 323 void G1RemSet::oops_into_collection_set_do(OopsInHeapRegionClosure* oc,
johnc@5548 324 CodeBlobToOopClosure* code_root_cl,
vkempik@6552 325 uint worker_i) {
ysr@777 326 #if CARD_REPEAT_HISTO
ysr@777 327 ct_freq_update_histo_and_reset();
ysr@777 328 #endif
ysr@777 329
johnc@2060 330 // We cache the value of 'oc' closure into the appropriate slot in the
johnc@2060 331 // _cset_rs_update_cl for this worker
vkempik@6552 332 assert(worker_i < n_workers(), "sanity");
johnc@2060 333 _cset_rs_update_cl[worker_i] = oc;
johnc@2060 334
johnc@2060 335 // A DirtyCardQueue that is used to hold cards containing references
johnc@2060 336 // that point into the collection set. This DCQ is associated with a
johnc@2060 337 // special DirtyCardQueueSet (see g1CollectedHeap.hpp). Under normal
johnc@2060 338 // circumstances (i.e. the pause successfully completes), these cards
johnc@2060 339 // are just discarded (there's no need to update the RSets of regions
johnc@2060 340 // that were in the collection set - after the pause these regions
johnc@2060 341 // are wholly 'free' of live objects. In the event of an evacuation
johnc@2060 342 // failure the cards/buffers in this queue set are:
johnc@2060 343 // * passed to the DirtyCardQueueSet that is used to manage deferred
johnc@2060 344 // RSet updates, or
johnc@2060 345 // * scanned for references that point into the collection set
johnc@2060 346 // and the RSet of the corresponding region in the collection set
johnc@2060 347 // is updated immediately.
johnc@2060 348 DirtyCardQueue into_cset_dcq(&_g1->into_cset_dirty_card_queue_set());
johnc@2060 349
johnc@2063 350 assert((ParallelGCThreads > 0) || worker_i == 0, "invariant");
johnc@2063 351
johnc@2063 352 // The two flags below were introduced temporarily to serialize
johnc@2063 353 // the updating and scanning of remembered sets. There are some
johnc@2063 354 // race conditions when these two operations are done in parallel
johnc@2063 355 // and they are causing failures. When we resolve said race
johnc@2063 356 // conditions, we'll revert back to parallel remembered set
johnc@2063 357 // updating and scanning. See CRs 6677707 and 6677708.
johnc@2063 358 if (G1UseParallelRSetUpdating || (worker_i == 0)) {
johnc@2063 359 updateRS(&into_cset_dcq, worker_i);
ysr@777 360 } else {
brutisso@4015 361 _g1p->phase_times()->record_update_rs_processed_buffers(worker_i, 0);
brutisso@3923 362 _g1p->phase_times()->record_update_rs_time(worker_i, 0.0);
johnc@2063 363 }
johnc@2063 364 if (G1UseParallelRSetScanning || (worker_i == 0)) {
johnc@5548 365 scanRS(oc, code_root_cl, worker_i);
johnc@2063 366 } else {
brutisso@3923 367 _g1p->phase_times()->record_scan_rs_time(worker_i, 0.0);
ysr@777 368 }
johnc@2060 369
johnc@2060 370 // We now clear the cached values of _cset_rs_update_cl for this worker
johnc@2060 371 _cset_rs_update_cl[worker_i] = NULL;
ysr@777 372 }
ysr@777 373
johnc@2216 374 void G1RemSet::prepare_for_oops_into_collection_set_do() {
ysr@777 375 cleanupHRRS();
ysr@777 376 ConcurrentG1Refine* cg1r = _g1->concurrent_g1_refine();
ysr@777 377 _g1->set_refine_cte_cl_concurrency(false);
ysr@777 378 DirtyCardQueueSet& dcqs = JavaThread::dirty_card_queue_set();
ysr@777 379 dcqs.concatenate_logs();
ysr@777 380
ysr@777 381 guarantee( _cards_scanned == NULL, "invariant" );
zgu@3900 382 _cards_scanned = NEW_C_HEAP_ARRAY(size_t, n_workers(), mtGC);
apetrusenko@980 383 for (uint i = 0; i < n_workers(); ++i) {
apetrusenko@980 384 _cards_scanned[i] = 0;
apetrusenko@980 385 }
ysr@777 386 _total_cards_scanned = 0;
ysr@777 387 }
ysr@777 388
ysr@777 389
johnc@2060 390 // This closure, applied to a DirtyCardQueueSet, is used to immediately
johnc@2060 391 // update the RSets for the regions in the CSet. For each card it iterates
johnc@2060 392 // through the oops which coincide with that card. It scans the reference
johnc@2060 393 // fields in each oop; when it finds an oop that points into the collection
johnc@2060 394 // set, the RSet for the region containing the referenced object is updated.
johnc@2060 395 class UpdateRSetCardTableEntryIntoCSetClosure: public CardTableEntryClosure {
iveresov@1051 396 G1CollectedHeap* _g1;
johnc@2060 397 CardTableModRefBS* _ct_bs;
iveresov@1051 398 public:
johnc@2060 399 UpdateRSetCardTableEntryIntoCSetClosure(G1CollectedHeap* g1,
johnc@2060 400 CardTableModRefBS* bs):
johnc@2060 401 _g1(g1), _ct_bs(bs)
johnc@2060 402 { }
johnc@2060 403
vkempik@6552 404 bool do_card_ptr(jbyte* card_ptr, uint worker_i) {
johnc@2060 405 // Construct the region representing the card.
johnc@2060 406 HeapWord* start = _ct_bs->addr_for(card_ptr);
johnc@2060 407 // And find the region containing it.
johnc@2060 408 HeapRegion* r = _g1->heap_region_containing(start);
johnc@2060 409 assert(r != NULL, "unexpected null");
johnc@2060 410
johnc@2060 411 // Scan oops in the card looking for references into the collection set
coleenp@4037 412 // Don't use addr_for(card_ptr + 1) which can ask for
coleenp@4037 413 // a card beyond the heap. This is not safe without a perm
coleenp@4037 414 // gen.
coleenp@4037 415 HeapWord* end = start + CardTableModRefBS::card_size_in_words;
johnc@2060 416 MemRegion scanRegion(start, end);
johnc@2060 417
johnc@2060 418 UpdateRSetImmediate update_rs_cl(_g1->g1_rem_set());
johnc@3179 419 FilterIntoCSClosure update_rs_cset_oop_cl(NULL, _g1, &update_rs_cl);
johnc@2060 420 FilterOutOfRegionClosure filter_then_update_rs_cset_oop_cl(r, &update_rs_cset_oop_cl);
johnc@2060 421
johnc@2060 422 // We can pass false as the "filter_young" parameter here as:
johnc@2060 423 // * we should be in a STW pause,
johnc@2060 424 // * the DCQS to which this closure is applied is used to hold
johnc@2060 425 // references that point into the collection set from the prior
johnc@2060 426 // RSet updating,
johnc@2060 427 // * the post-write barrier shouldn't be logging updates to young
johnc@2060 428 // regions (but there is a situation where this can happen - see
johnc@5078 429 // the comment in G1RemSet::refine_card() below -
johnc@2060 430 // that should not be applicable here), and
johnc@2060 431 // * during actual RSet updating, the filtering of cards in young
johnc@2060 432 // regions in HeapRegion::oops_on_card_seq_iterate_careful is
johnc@2060 433 // employed.
johnc@2060 434 // As a result, when this closure is applied to "refs into cset"
johnc@2060 435 // DCQS, we shouldn't see any cards in young regions.
johnc@2060 436 update_rs_cl.set_region(r);
johnc@2060 437 HeapWord* stop_point =
johnc@2060 438 r->oops_on_card_seq_iterate_careful(scanRegion,
tonyp@2849 439 &filter_then_update_rs_cset_oop_cl,
tonyp@2849 440 false /* filter_young */,
tonyp@2849 441 NULL /* card_ptr */);
johnc@2060 442
johnc@2060 443 // Since this is performed in the event of an evacuation failure, we
johnc@2060 444 // we shouldn't see a non-null stop point
johnc@2060 445 assert(stop_point == NULL, "saw an unallocated region");
johnc@2060 446 return true;
iveresov@1051 447 }
iveresov@1051 448 };
iveresov@1051 449
johnc@2216 450 void G1RemSet::cleanup_after_oops_into_collection_set_do() {
ysr@777 451 guarantee( _cards_scanned != NULL, "invariant" );
ysr@777 452 _total_cards_scanned = 0;
tonyp@2974 453 for (uint i = 0; i < n_workers(); ++i) {
ysr@777 454 _total_cards_scanned += _cards_scanned[i];
tonyp@2974 455 }
zgu@3900 456 FREE_C_HEAP_ARRAY(size_t, _cards_scanned, mtGC);
ysr@777 457 _cards_scanned = NULL;
ysr@777 458 // Cleanup after copy
ysr@777 459 _g1->set_refine_cte_cl_concurrency(true);
ysr@777 460 // Set all cards back to clean.
ysr@777 461 _g1->cleanUpCardTable();
iveresov@1229 462
johnc@2060 463 DirtyCardQueueSet& into_cset_dcqs = _g1->into_cset_dirty_card_queue_set();
johnc@2060 464 int into_cset_n_buffers = into_cset_dcqs.completed_buffers_num();
johnc@2060 465
iveresov@1051 466 if (_g1->evacuation_failed()) {
tschatzl@6406 467 double restore_remembered_set_start = os::elapsedTime();
tschatzl@6406 468
johnc@2060 469 // Restore remembered sets for the regions pointing into the collection set.
iveresov@1051 470 if (G1DeferredRSUpdate) {
johnc@2060 471 // If deferred RS updates are enabled then we just need to transfer
johnc@2060 472 // the completed buffers from (a) the DirtyCardQueueSet used to hold
johnc@2060 473 // cards that contain references that point into the collection set
johnc@2060 474 // to (b) the DCQS used to hold the deferred RS updates
johnc@2060 475 _g1->dirty_card_queue_set().merge_bufferlists(&into_cset_dcqs);
iveresov@1051 476 } else {
johnc@2060 477
johnc@2060 478 CardTableModRefBS* bs = (CardTableModRefBS*)_g1->barrier_set();
johnc@2060 479 UpdateRSetCardTableEntryIntoCSetClosure update_rs_cset_immediate(_g1, bs);
johnc@2060 480
johnc@2060 481 int n_completed_buffers = 0;
johnc@2060 482 while (into_cset_dcqs.apply_closure_to_completed_buffer(&update_rs_cset_immediate,
johnc@2060 483 0, 0, true)) {
johnc@2060 484 n_completed_buffers++;
johnc@2060 485 }
johnc@2060 486 assert(n_completed_buffers == into_cset_n_buffers, "missed some buffers");
iveresov@1051 487 }
tschatzl@6406 488
tschatzl@6406 489 _g1->g1_policy()->phase_times()->record_evac_fail_restore_remsets((os::elapsedTime() - restore_remembered_set_start) * 1000.0);
iveresov@1051 490 }
johnc@2060 491
johnc@2060 492 // Free any completed buffers in the DirtyCardQueueSet used to hold cards
johnc@2060 493 // which contain references that point into the collection.
johnc@2060 494 _g1->into_cset_dirty_card_queue_set().clear();
johnc@2060 495 assert(_g1->into_cset_dirty_card_queue_set().completed_buffers_num() == 0,
johnc@2060 496 "all buffers should be freed");
johnc@2060 497 _g1->into_cset_dirty_card_queue_set().clear_n_completed_buffers();
ysr@777 498 }
ysr@777 499
ysr@777 500 class ScrubRSClosure: public HeapRegionClosure {
ysr@777 501 G1CollectedHeap* _g1h;
ysr@777 502 BitMap* _region_bm;
ysr@777 503 BitMap* _card_bm;
ysr@777 504 CardTableModRefBS* _ctbs;
ysr@777 505 public:
ysr@777 506 ScrubRSClosure(BitMap* region_bm, BitMap* card_bm) :
ysr@777 507 _g1h(G1CollectedHeap::heap()),
ysr@777 508 _region_bm(region_bm), _card_bm(card_bm),
mgerdin@5811 509 _ctbs(_g1h->g1_barrier_set()) {}
ysr@777 510
ysr@777 511 bool doHeapRegion(HeapRegion* r) {
ysr@777 512 if (!r->continuesHumongous()) {
ysr@777 513 r->rem_set()->scrub(_ctbs, _region_bm, _card_bm);
ysr@777 514 }
ysr@777 515 return false;
ysr@777 516 }
ysr@777 517 };
ysr@777 518
johnc@2216 519 void G1RemSet::scrub(BitMap* region_bm, BitMap* card_bm) {
ysr@777 520 ScrubRSClosure scrub_cl(region_bm, card_bm);
ysr@777 521 _g1->heap_region_iterate(&scrub_cl);
ysr@777 522 }
ysr@777 523
johnc@2216 524 void G1RemSet::scrub_par(BitMap* region_bm, BitMap* card_bm,
jmasa@3357 525 uint worker_num, int claim_val) {
ysr@777 526 ScrubRSClosure scrub_cl(region_bm, card_bm);
jmasa@3294 527 _g1->heap_region_par_iterate_chunked(&scrub_cl,
jmasa@3294 528 worker_num,
jmasa@3357 529 n_workers(),
jmasa@3294 530 claim_val);
ysr@777 531 }
ysr@777 532
johnc@3466 533 G1TriggerClosure::G1TriggerClosure() :
johnc@3466 534 _triggered(false) { }
johnc@2060 535
johnc@3466 536 G1InvokeIfNotTriggeredClosure::G1InvokeIfNotTriggeredClosure(G1TriggerClosure* t_cl,
johnc@3466 537 OopClosure* oop_cl) :
johnc@3466 538 _trigger_cl(t_cl), _oop_cl(oop_cl) { }
johnc@3466 539
johnc@3466 540 G1Mux2Closure::G1Mux2Closure(OopClosure *c1, OopClosure *c2) :
johnc@3466 541 _c1(c1), _c2(c2) { }
johnc@3466 542
johnc@3466 543 G1UpdateRSOrPushRefOopClosure::
johnc@3466 544 G1UpdateRSOrPushRefOopClosure(G1CollectedHeap* g1h,
johnc@3466 545 G1RemSet* rs,
johnc@3466 546 OopsInHeapRegionClosure* push_ref_cl,
johnc@3466 547 bool record_refs_into_cset,
vkempik@6552 548 uint worker_i) :
johnc@3466 549 _g1(g1h), _g1_rem_set(rs), _from(NULL),
johnc@3466 550 _record_refs_into_cset(record_refs_into_cset),
johnc@3466 551 _push_ref_cl(push_ref_cl), _worker_i(worker_i) { }
johnc@2060 552
johnc@5078 553 // Returns true if the given card contains references that point
johnc@5078 554 // into the collection set, if we're checking for such references;
johnc@5078 555 // false otherwise.
johnc@5078 556
vkempik@6552 557 bool G1RemSet::refine_card(jbyte* card_ptr, uint worker_i,
johnc@5078 558 bool check_for_refs_into_cset) {
johnc@5078 559
johnc@5078 560 // If the card is no longer dirty, nothing to do.
johnc@5078 561 if (*card_ptr != CardTableModRefBS::dirty_card_val()) {
johnc@5078 562 // No need to return that this card contains refs that point
johnc@5078 563 // into the collection set.
johnc@5078 564 return false;
johnc@5078 565 }
johnc@5078 566
johnc@1325 567 // Construct the region representing the card.
johnc@1325 568 HeapWord* start = _ct_bs->addr_for(card_ptr);
johnc@1325 569 // And find the region containing it.
johnc@1325 570 HeapRegion* r = _g1->heap_region_containing(start);
johnc@5078 571 if (r == NULL) {
johnc@5078 572 // Again no need to return that this card contains refs that
johnc@5078 573 // point into the collection set.
johnc@5078 574 return false; // Not in the G1 heap (might be in perm, for example.)
johnc@5078 575 }
johnc@5078 576
johnc@5078 577 // Why do we have to check here whether a card is on a young region,
johnc@5078 578 // given that we dirty young regions and, as a result, the
johnc@5078 579 // post-barrier is supposed to filter them out and never to enqueue
johnc@5078 580 // them? When we allocate a new region as the "allocation region" we
johnc@5078 581 // actually dirty its cards after we release the lock, since card
johnc@5078 582 // dirtying while holding the lock was a performance bottleneck. So,
johnc@5078 583 // as a result, it is possible for other threads to actually
johnc@5078 584 // allocate objects in the region (after the acquire the lock)
johnc@5078 585 // before all the cards on the region are dirtied. This is unlikely,
johnc@5078 586 // and it doesn't happen often, but it can happen. So, the extra
johnc@5078 587 // check below filters out those cards.
johnc@5078 588 if (r->is_young()) {
johnc@5078 589 return false;
johnc@5078 590 }
johnc@5078 591
johnc@5078 592 // While we are processing RSet buffers during the collection, we
johnc@5078 593 // actually don't want to scan any cards on the collection set,
johnc@5078 594 // since we don't want to update remebered sets with entries that
johnc@5078 595 // point into the collection set, given that live objects from the
johnc@5078 596 // collection set are about to move and such entries will be stale
johnc@5078 597 // very soon. This change also deals with a reliability issue which
johnc@5078 598 // involves scanning a card in the collection set and coming across
johnc@5078 599 // an array that was being chunked and looking malformed. Note,
johnc@5078 600 // however, that if evacuation fails, we have to scan any objects
johnc@5078 601 // that were not moved and create any missing entries.
johnc@5078 602 if (r->in_collection_set()) {
johnc@5078 603 return false;
johnc@5078 604 }
johnc@5078 605
johnc@5078 606 // The result from the hot card cache insert call is either:
johnc@5078 607 // * pointer to the current card
johnc@5078 608 // (implying that the current card is not 'hot'),
johnc@5078 609 // * null
johnc@5078 610 // (meaning we had inserted the card ptr into the "hot" card cache,
johnc@5078 611 // which had some headroom),
johnc@5078 612 // * a pointer to a "hot" card that was evicted from the "hot" cache.
johnc@5078 613 //
johnc@5078 614
johnc@5078 615 G1HotCardCache* hot_card_cache = _cg1r->hot_card_cache();
johnc@5078 616 if (hot_card_cache->use_cache()) {
johnc@5078 617 assert(!check_for_refs_into_cset, "sanity");
johnc@5078 618 assert(!SafepointSynchronize::is_at_safepoint(), "sanity");
johnc@5078 619
johnc@5078 620 card_ptr = hot_card_cache->insert(card_ptr);
johnc@5078 621 if (card_ptr == NULL) {
johnc@5078 622 // There was no eviction. Nothing to do.
johnc@5078 623 return false;
johnc@5078 624 }
johnc@5078 625
johnc@5078 626 start = _ct_bs->addr_for(card_ptr);
johnc@5078 627 r = _g1->heap_region_containing(start);
johnc@5078 628 if (r == NULL) {
johnc@5078 629 // Not in the G1 heap
johnc@5078 630 return false;
johnc@5078 631 }
johnc@5078 632
johnc@5078 633 // Checking whether the region we got back from the cache
johnc@5078 634 // is young here is inappropriate. The region could have been
johnc@5078 635 // freed, reallocated and tagged as young while in the cache.
johnc@5078 636 // Hence we could see its young type change at any time.
johnc@5078 637 }
johnc@1325 638
coleenp@4037 639 // Don't use addr_for(card_ptr + 1) which can ask for
coleenp@4037 640 // a card beyond the heap. This is not safe without a perm
coleenp@4037 641 // gen at the upper end of the heap.
coleenp@4037 642 HeapWord* end = start + CardTableModRefBS::card_size_in_words;
johnc@1325 643 MemRegion dirtyRegion(start, end);
johnc@1325 644
johnc@1325 645 #if CARD_REPEAT_HISTO
johnc@2504 646 init_ct_freq_table(_g1->max_capacity());
johnc@1325 647 ct_freq_note_card(_ct_bs->index_for(start));
johnc@1325 648 #endif
johnc@1325 649
brutisso@3267 650 OopsInHeapRegionClosure* oops_in_heap_closure = NULL;
brutisso@3267 651 if (check_for_refs_into_cset) {
brutisso@3267 652 // ConcurrentG1RefineThreads have worker numbers larger than what
brutisso@3267 653 // _cset_rs_update_cl[] is set up to handle. But those threads should
brutisso@3267 654 // only be active outside of a collection which means that when they
brutisso@3267 655 // reach here they should have check_for_refs_into_cset == false.
brutisso@3267 656 assert((size_t)worker_i < n_workers(), "index of worker larger than _cset_rs_update_cl[].length");
brutisso@3267 657 oops_in_heap_closure = _cset_rs_update_cl[worker_i];
brutisso@3267 658 }
johnc@3466 659 G1UpdateRSOrPushRefOopClosure update_rs_oop_cl(_g1,
johnc@3466 660 _g1->g1_rem_set(),
johnc@3466 661 oops_in_heap_closure,
johnc@3466 662 check_for_refs_into_cset,
johnc@3466 663 worker_i);
johnc@1325 664 update_rs_oop_cl.set_from(r);
johnc@2060 665
johnc@3466 666 G1TriggerClosure trigger_cl;
johnc@3179 667 FilterIntoCSClosure into_cs_cl(NULL, _g1, &trigger_cl);
johnc@3466 668 G1InvokeIfNotTriggeredClosure invoke_cl(&trigger_cl, &into_cs_cl);
johnc@3466 669 G1Mux2Closure mux(&invoke_cl, &update_rs_oop_cl);
johnc@2060 670
johnc@2060 671 FilterOutOfRegionClosure filter_then_update_rs_oop_cl(r,
johnc@2060 672 (check_for_refs_into_cset ?
johnc@2060 673 (OopClosure*)&mux :
johnc@2060 674 (OopClosure*)&update_rs_oop_cl));
johnc@1325 675
johnc@2021 676 // The region for the current card may be a young region. The
johnc@2021 677 // current card may have been a card that was evicted from the
johnc@2021 678 // card cache. When the card was inserted into the cache, we had
johnc@2021 679 // determined that its region was non-young. While in the cache,
johnc@2021 680 // the region may have been freed during a cleanup pause, reallocated
johnc@2021 681 // and tagged as young.
johnc@2021 682 //
johnc@2021 683 // We wish to filter out cards for such a region but the current
tonyp@2849 684 // thread, if we're running concurrently, may "see" the young type
johnc@2021 685 // change at any time (so an earlier "is_young" check may pass or
johnc@2021 686 // fail arbitrarily). We tell the iteration code to perform this
johnc@2021 687 // filtering when it has been determined that there has been an actual
johnc@2021 688 // allocation in this region and making it safe to check the young type.
johnc@2021 689 bool filter_young = true;
johnc@2021 690
johnc@1325 691 HeapWord* stop_point =
johnc@1325 692 r->oops_on_card_seq_iterate_careful(dirtyRegion,
johnc@2021 693 &filter_then_update_rs_oop_cl,
tonyp@2849 694 filter_young,
tonyp@2849 695 card_ptr);
johnc@2021 696
johnc@1325 697 // If stop_point is non-null, then we encountered an unallocated region
johnc@1325 698 // (perhaps the unfilled portion of a TLAB.) For now, we'll dirty the
johnc@1325 699 // card and re-enqueue: if we put off the card until a GC pause, then the
johnc@1325 700 // unallocated portion will be filled in. Alternatively, we might try
johnc@1325 701 // the full complexity of the technique used in "regular" precleaning.
johnc@1325 702 if (stop_point != NULL) {
johnc@1325 703 // The card might have gotten re-dirtied and re-enqueued while we
johnc@1325 704 // worked. (In fact, it's pretty likely.)
johnc@1325 705 if (*card_ptr != CardTableModRefBS::dirty_card_val()) {
johnc@1325 706 *card_ptr = CardTableModRefBS::dirty_card_val();
johnc@1325 707 MutexLockerEx x(Shared_DirtyCardQ_lock,
johnc@1325 708 Mutex::_no_safepoint_check_flag);
johnc@1325 709 DirtyCardQueue* sdcq =
johnc@1325 710 JavaThread::dirty_card_queue_set().shared_dirty_card_queue();
johnc@1325 711 sdcq->enqueue(card_ptr);
johnc@1325 712 }
johnc@1325 713 } else {
johnc@1325 714 _conc_refine_cards++;
johnc@1325 715 }
johnc@2060 716
johnc@5078 717 // This gets set to true if the card being refined has
johnc@5078 718 // references that point into the collection set.
johnc@5078 719 bool has_refs_into_cset = trigger_cl.triggered();
johnc@1325 720
johnc@5078 721 // We should only be detecting that the card contains references
johnc@5078 722 // that point into the collection set if the current thread is
johnc@5078 723 // a GC worker thread.
johnc@5078 724 assert(!has_refs_into_cset || SafepointSynchronize::is_at_safepoint(),
johnc@5078 725 "invalid result at non safepoint");
ysr@777 726
johnc@5078 727 return has_refs_into_cset;
ysr@777 728 }
ysr@777 729
tschatzl@5807 730 void G1RemSet::print_periodic_summary_info(const char* header) {
tschatzl@5204 731 G1RemSetSummary current;
tschatzl@5812 732 current.initialize(this);
ysr@777 733
tschatzl@5204 734 _prev_period_summary.subtract_from(&current);
tschatzl@5807 735 print_summary_info(&_prev_period_summary, header);
ysr@777 736
tschatzl@5204 737 _prev_period_summary.set(&current);
tschatzl@5204 738 }
iveresov@1229 739
johnc@2216 740 void G1RemSet::print_summary_info() {
tschatzl@5204 741 G1RemSetSummary current;
tschatzl@5812 742 current.initialize(this);
tschatzl@5204 743
tschatzl@5204 744 print_summary_info(&current, " Cumulative RS summary");
tschatzl@5204 745 }
tschatzl@5204 746
tschatzl@5204 747 void G1RemSet::print_summary_info(G1RemSetSummary * summary, const char * header) {
tschatzl@5204 748 assert(summary != NULL, "just checking");
tschatzl@5204 749
tschatzl@5204 750 if (header != NULL) {
tschatzl@5204 751 gclog_or_tty->print_cr("%s", header);
tschatzl@5204 752 }
ysr@777 753
ysr@777 754 #if CARD_REPEAT_HISTO
ysr@777 755 gclog_or_tty->print_cr("\nG1 card_repeat count histogram: ");
ysr@777 756 gclog_or_tty->print_cr(" # of repeats --> # of cards with that number.");
ysr@777 757 card_repeat_count.print_on(gclog_or_tty);
ysr@777 758 #endif
ysr@777 759
tschatzl@5204 760 summary->print_on(gclog_or_tty);
ysr@777 761 }
johnc@2060 762
johnc@2216 763 void G1RemSet::prepare_for_verify() {
iveresov@1072 764 if (G1HRRSFlushLogBuffersOnVerify &&
iveresov@1072 765 (VerifyBeforeGC || VerifyAfterGC)
johnc@5205 766 && (!_g1->full_collection() || G1VerifyRSetsDuringFullGC)) {
ysr@777 767 cleanupHRRS();
ysr@777 768 _g1->set_refine_cte_cl_concurrency(false);
ysr@777 769 if (SafepointSynchronize::is_at_safepoint()) {
ysr@777 770 DirtyCardQueueSet& dcqs = JavaThread::dirty_card_queue_set();
ysr@777 771 dcqs.concatenate_logs();
ysr@777 772 }
johnc@5078 773
johnc@5078 774 G1HotCardCache* hot_card_cache = _cg1r->hot_card_cache();
johnc@5078 775 bool use_hot_card_cache = hot_card_cache->use_cache();
johnc@5078 776 hot_card_cache->set_use_cache(false);
johnc@5078 777
johnc@2060 778 DirtyCardQueue into_cset_dcq(&_g1->into_cset_dirty_card_queue_set());
johnc@2060 779 updateRS(&into_cset_dcq, 0);
johnc@2060 780 _g1->into_cset_dirty_card_queue_set().clear();
iveresov@1072 781
johnc@5078 782 hot_card_cache->set_use_cache(use_hot_card_cache);
iveresov@1072 783 assert(JavaThread::dirty_card_queue_set().completed_buffers_num() == 0, "All should be consumed");
ysr@777 784 }
ysr@777 785 }

mercurial