Thu, 11 Dec 2008 12:05:08 -0800
6578152: fill_region_with_object has usability and safety issues
Reviewed-by: apetrusenko, ysr
duke@435 | 1 | /* |
duke@435 | 2 | * Copyright 2000-2005 Sun Microsystems, Inc. All Rights Reserved. |
duke@435 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
duke@435 | 4 | * |
duke@435 | 5 | * This code is free software; you can redistribute it and/or modify it |
duke@435 | 6 | * under the terms of the GNU General Public License version 2 only, as |
duke@435 | 7 | * published by the Free Software Foundation. |
duke@435 | 8 | * |
duke@435 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
duke@435 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
duke@435 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
duke@435 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
duke@435 | 13 | * accompanied this code). |
duke@435 | 14 | * |
duke@435 | 15 | * You should have received a copy of the GNU General Public License version |
duke@435 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
duke@435 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
duke@435 | 18 | * |
duke@435 | 19 | * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara, |
duke@435 | 20 | * CA 95054 USA or visit www.sun.com if you need additional information or |
duke@435 | 21 | * have any questions. |
duke@435 | 22 | * |
duke@435 | 23 | */ |
duke@435 | 24 | |
duke@435 | 25 | inline bool GC_locker::is_active() { |
duke@435 | 26 | return _lock_count > 0 || _jni_lock_count > 0; |
duke@435 | 27 | } |
duke@435 | 28 | |
duke@435 | 29 | inline bool GC_locker::check_active_before_gc() { |
duke@435 | 30 | if (is_active()) { |
duke@435 | 31 | set_needs_gc(); |
duke@435 | 32 | } |
duke@435 | 33 | return is_active(); |
duke@435 | 34 | } |
duke@435 | 35 | |
duke@435 | 36 | inline void GC_locker::lock() { |
duke@435 | 37 | // cast away volatile |
duke@435 | 38 | Atomic::inc(&_lock_count); |
duke@435 | 39 | CHECK_UNHANDLED_OOPS_ONLY( |
duke@435 | 40 | if (CheckUnhandledOops) { Thread::current()->_gc_locked_out_count++; }) |
duke@435 | 41 | assert(Universe::heap() == NULL || |
duke@435 | 42 | !Universe::heap()->is_gc_active(), "locking failed"); |
duke@435 | 43 | } |
duke@435 | 44 | |
duke@435 | 45 | inline void GC_locker::unlock() { |
duke@435 | 46 | // cast away volatile |
duke@435 | 47 | Atomic::dec(&_lock_count); |
duke@435 | 48 | CHECK_UNHANDLED_OOPS_ONLY( |
duke@435 | 49 | if (CheckUnhandledOops) { Thread::current()->_gc_locked_out_count--; }) |
duke@435 | 50 | } |
duke@435 | 51 | |
duke@435 | 52 | inline void GC_locker::lock_critical(JavaThread* thread) { |
duke@435 | 53 | if (!thread->in_critical()) { |
duke@435 | 54 | if (!needs_gc()) { |
duke@435 | 55 | jni_lock(); |
duke@435 | 56 | } else { |
duke@435 | 57 | jni_lock_slow(); |
duke@435 | 58 | } |
duke@435 | 59 | } |
duke@435 | 60 | thread->enter_critical(); |
duke@435 | 61 | } |
duke@435 | 62 | |
duke@435 | 63 | inline void GC_locker::unlock_critical(JavaThread* thread) { |
duke@435 | 64 | thread->exit_critical(); |
duke@435 | 65 | if (!thread->in_critical()) { |
duke@435 | 66 | if (!needs_gc()) { |
duke@435 | 67 | jni_unlock(); |
duke@435 | 68 | } else { |
duke@435 | 69 | jni_unlock_slow(); |
duke@435 | 70 | } |
duke@435 | 71 | } |
duke@435 | 72 | } |