Mon, 12 Mar 2012 14:59:00 -0700
7147724: G1: hang in SurrogateLockerThread::manipulatePLL
Summary: Attempting to initiate a marking cycle when allocating a humongous object can, if a marking cycle is successfully initiated by another thread, result in the allocating thread spinning until the marking cycle is complete. Eliminate a deadlock between the main ConcurrentMarkThread, the SurrogateLocker thread, the VM thread, and a mutator thread waiting on the SecondaryFreeList_lock (while free regions are going to become available) by not manipulating the pending list lock during the prologue and epilogue of the cleanup pause.
Reviewed-by: brutisso, jcoomes, tonyp
ysr@777 | 1 | /* |
tonyp@3464 | 2 | * Copyright (c) 2001, 2012, Oracle and/or its affiliates. All rights reserved. |
ysr@777 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
ysr@777 | 4 | * |
ysr@777 | 5 | * This code is free software; you can redistribute it and/or modify it |
ysr@777 | 6 | * under the terms of the GNU General Public License version 2 only, as |
ysr@777 | 7 | * published by the Free Software Foundation. |
ysr@777 | 8 | * |
ysr@777 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
ysr@777 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
ysr@777 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
ysr@777 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
ysr@777 | 13 | * accompanied this code). |
ysr@777 | 14 | * |
ysr@777 | 15 | * You should have received a copy of the GNU General Public License version |
ysr@777 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
ysr@777 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
ysr@777 | 18 | * |
trims@1907 | 19 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
trims@1907 | 20 | * or visit www.oracle.com if you need additional information or have any |
trims@1907 | 21 | * questions. |
ysr@777 | 22 | * |
ysr@777 | 23 | */ |
ysr@777 | 24 | |
stefank@2314 | 25 | #ifndef SHARE_VM_GC_IMPLEMENTATION_G1_G1OOPCLOSURES_INLINE_HPP |
stefank@2314 | 26 | #define SHARE_VM_GC_IMPLEMENTATION_G1_G1OOPCLOSURES_INLINE_HPP |
stefank@2314 | 27 | |
tonyp@2968 | 28 | #include "gc_implementation/g1/concurrentMark.inline.hpp" |
stefank@2314 | 29 | #include "gc_implementation/g1/g1CollectedHeap.hpp" |
stefank@2314 | 30 | #include "gc_implementation/g1/g1OopClosures.hpp" |
stefank@2314 | 31 | #include "gc_implementation/g1/g1RemSet.hpp" |
stefank@2314 | 32 | |
ysr@777 | 33 | /* |
ysr@777 | 34 | * This really ought to be an inline function, but apparently the C++ |
ysr@777 | 35 | * compiler sometimes sees fit to ignore inline declarations. Sigh. |
ysr@777 | 36 | */ |
ysr@777 | 37 | |
ysr@777 | 38 | // This must a ifdef'ed because the counting it controls is in a |
ysr@777 | 39 | // perf-critical inner loop. |
ysr@777 | 40 | #define FILTERINTOCSCLOSURE_DOHISTOGRAMCOUNT 0 |
ysr@777 | 41 | |
tonyp@3464 | 42 | template <class T> |
tonyp@3464 | 43 | inline void FilterIntoCSClosure::do_oop_nv(T* p) { |
ysr@1280 | 44 | T heap_oop = oopDesc::load_heap_oop(p); |
ysr@1280 | 45 | if (!oopDesc::is_null(heap_oop) && |
ysr@1280 | 46 | _g1->obj_in_cs(oopDesc::decode_heap_oop_not_null(heap_oop))) { |
ysr@777 | 47 | _oc->do_oop(p); |
ysr@777 | 48 | #if FILTERINTOCSCLOSURE_DOHISTOGRAMCOUNT |
johnc@2060 | 49 | if (_dcto_cl != NULL) |
johnc@2060 | 50 | _dcto_cl->incr_count(); |
ysr@777 | 51 | #endif |
ysr@777 | 52 | } |
ysr@777 | 53 | } |
ysr@777 | 54 | |
ysr@777 | 55 | #define FILTEROUTOFREGIONCLOSURE_DOHISTOGRAMCOUNT 0 |
ysr@777 | 56 | |
tonyp@3464 | 57 | template <class T> |
tonyp@3464 | 58 | inline void FilterOutOfRegionClosure::do_oop_nv(T* p) { |
ysr@1280 | 59 | T heap_oop = oopDesc::load_heap_oop(p); |
ysr@1280 | 60 | if (!oopDesc::is_null(heap_oop)) { |
ysr@1280 | 61 | HeapWord* obj_hw = (HeapWord*)oopDesc::decode_heap_oop_not_null(heap_oop); |
ysr@1280 | 62 | if (obj_hw < _r_bottom || obj_hw >= _r_end) { |
ysr@1280 | 63 | _oc->do_oop(p); |
ysr@777 | 64 | #if FILTEROUTOFREGIONCLOSURE_DOHISTOGRAMCOUNT |
ysr@1280 | 65 | _out_of_region++; |
ysr@777 | 66 | #endif |
ysr@1280 | 67 | } |
ysr@777 | 68 | } |
ysr@777 | 69 | } |
ysr@777 | 70 | |
ysr@1280 | 71 | // This closure is applied to the fields of the objects that have just been copied. |
tonyp@3464 | 72 | template <class T> |
tonyp@3464 | 73 | inline void G1ParScanClosure::do_oop_nv(T* p) { |
ysr@1280 | 74 | T heap_oop = oopDesc::load_heap_oop(p); |
ysr@1280 | 75 | |
ysr@1280 | 76 | if (!oopDesc::is_null(heap_oop)) { |
ysr@1280 | 77 | oop obj = oopDesc::decode_heap_oop_not_null(heap_oop); |
ysr@1280 | 78 | if (_g1->in_cset_fast_test(obj)) { |
ysr@1280 | 79 | // We're not going to even bother checking whether the object is |
ysr@1280 | 80 | // already forwarded or not, as this usually causes an immediate |
ysr@1280 | 81 | // stall. We'll try to prefetch the object (for write, given that |
ysr@1280 | 82 | // we might need to install the forwarding reference) and we'll |
ysr@1280 | 83 | // get back to it when pop it from the queue |
ysr@1280 | 84 | Prefetch::write(obj->mark_addr(), 0); |
ysr@1280 | 85 | Prefetch::read(obj->mark_addr(), (HeapWordSize*2)); |
ysr@1280 | 86 | |
ysr@1280 | 87 | // slightly paranoid test; I'm trying to catch potential |
ysr@1280 | 88 | // problems before we go into push_on_queue to know where the |
ysr@1280 | 89 | // problem is coming from |
johnc@3322 | 90 | assert((obj == oopDesc::load_decode_heap_oop(p)) || |
johnc@3322 | 91 | (obj->is_forwarded() && |
johnc@3322 | 92 | obj->forwardee() == oopDesc::load_decode_heap_oop(p)), |
johnc@3322 | 93 | "p should still be pointing to obj or to its forwardee"); |
johnc@3322 | 94 | |
ysr@1280 | 95 | _par_scan_state->push_on_queue(p); |
ysr@1280 | 96 | } else { |
ysr@1280 | 97 | _par_scan_state->update_rs(_from, p, _par_scan_state->queue_num()); |
ysr@1280 | 98 | } |
ysr@1280 | 99 | } |
ysr@777 | 100 | } |
iveresov@1696 | 101 | |
tonyp@3464 | 102 | template <class T> |
tonyp@3464 | 103 | inline void G1ParPushHeapRSClosure::do_oop_nv(T* p) { |
iveresov@1696 | 104 | T heap_oop = oopDesc::load_heap_oop(p); |
iveresov@1696 | 105 | |
iveresov@1696 | 106 | if (!oopDesc::is_null(heap_oop)) { |
iveresov@1696 | 107 | oop obj = oopDesc::decode_heap_oop_not_null(heap_oop); |
iveresov@1696 | 108 | if (_g1->in_cset_fast_test(obj)) { |
iveresov@1696 | 109 | Prefetch::write(obj->mark_addr(), 0); |
iveresov@1696 | 110 | Prefetch::read(obj->mark_addr(), (HeapWordSize*2)); |
johnc@2060 | 111 | |
johnc@2060 | 112 | // Place on the references queue |
iveresov@1696 | 113 | _par_scan_state->push_on_queue(p); |
iveresov@1696 | 114 | } |
iveresov@1696 | 115 | } |
iveresov@1696 | 116 | } |
johnc@2060 | 117 | |
tonyp@3464 | 118 | template <class T> |
tonyp@3464 | 119 | inline void G1CMOopClosure::do_oop_nv(T* p) { |
tonyp@2968 | 120 | assert(_g1h->is_in_g1_reserved((HeapWord*) p), "invariant"); |
tonyp@2968 | 121 | assert(!_g1h->is_on_master_free_list( |
tonyp@2968 | 122 | _g1h->heap_region_containing((HeapWord*) p)), "invariant"); |
tonyp@2968 | 123 | |
tonyp@2968 | 124 | oop obj = oopDesc::load_decode_heap_oop(p); |
tonyp@2968 | 125 | if (_cm->verbose_high()) { |
tonyp@2968 | 126 | gclog_or_tty->print_cr("[%d] we're looking at location " |
tonyp@2968 | 127 | "*"PTR_FORMAT" = "PTR_FORMAT, |
tonyp@2968 | 128 | _task->task_id(), p, (void*) obj); |
tonyp@2968 | 129 | } |
tonyp@2968 | 130 | _task->deal_with_reference(obj); |
tonyp@2968 | 131 | } |
stefank@2314 | 132 | |
tonyp@3464 | 133 | template <class T> |
tonyp@3464 | 134 | inline void G1RootRegionScanClosure::do_oop_nv(T* p) { |
tonyp@3464 | 135 | T heap_oop = oopDesc::load_heap_oop(p); |
tonyp@3464 | 136 | if (!oopDesc::is_null(heap_oop)) { |
tonyp@3464 | 137 | oop obj = oopDesc::decode_heap_oop_not_null(heap_oop); |
tonyp@3464 | 138 | HeapRegion* hr = _g1h->heap_region_containing((HeapWord*) obj); |
tonyp@3464 | 139 | if (hr != NULL) { |
tonyp@3464 | 140 | _cm->grayRoot(obj, obj->size(), _worker_id, hr); |
tonyp@3464 | 141 | } |
tonyp@3464 | 142 | } |
tonyp@3464 | 143 | } |
tonyp@3464 | 144 | |
johnc@3466 | 145 | template <class T> |
johnc@3466 | 146 | inline void G1Mux2Closure::do_oop_nv(T* p) { |
johnc@3466 | 147 | // Apply first closure; then apply the second. |
johnc@3466 | 148 | _c1->do_oop(p); |
johnc@3466 | 149 | _c2->do_oop(p); |
johnc@3466 | 150 | } |
johnc@3466 | 151 | |
johnc@3466 | 152 | template <class T> |
johnc@3466 | 153 | inline void G1TriggerClosure::do_oop_nv(T* p) { |
johnc@3466 | 154 | // Record that this closure was actually applied (triggered). |
johnc@3466 | 155 | _triggered = true; |
johnc@3466 | 156 | } |
johnc@3466 | 157 | |
johnc@3466 | 158 | template <class T> |
johnc@3466 | 159 | inline void G1InvokeIfNotTriggeredClosure::do_oop_nv(T* p) { |
johnc@3466 | 160 | if (!_trigger_cl->triggered()) { |
johnc@3466 | 161 | _oop_cl->do_oop(p); |
johnc@3466 | 162 | } |
johnc@3466 | 163 | } |
johnc@3466 | 164 | |
johnc@3466 | 165 | template <class T> |
johnc@3466 | 166 | inline void G1UpdateRSOrPushRefOopClosure::do_oop_nv(T* p) { |
johnc@3466 | 167 | oop obj = oopDesc::load_decode_heap_oop(p); |
johnc@3466 | 168 | #ifdef ASSERT |
johnc@3466 | 169 | // can't do because of races |
johnc@3466 | 170 | // assert(obj == NULL || obj->is_oop(), "expected an oop"); |
johnc@3466 | 171 | |
johnc@3466 | 172 | // Do the safe subset of is_oop |
johnc@3466 | 173 | if (obj != NULL) { |
johnc@3466 | 174 | #ifdef CHECK_UNHANDLED_OOPS |
johnc@3466 | 175 | oopDesc* o = obj.obj(); |
johnc@3466 | 176 | #else |
johnc@3466 | 177 | oopDesc* o = obj; |
johnc@3466 | 178 | #endif // CHECK_UNHANDLED_OOPS |
johnc@3466 | 179 | assert((intptr_t)o % MinObjAlignmentInBytes == 0, "not oop aligned"); |
johnc@3466 | 180 | assert(Universe::heap()->is_in_reserved(obj), "must be in heap"); |
johnc@3466 | 181 | } |
johnc@3466 | 182 | #endif // ASSERT |
johnc@3466 | 183 | |
johnc@3466 | 184 | assert(_from != NULL, "from region must be non-NULL"); |
johnc@3466 | 185 | |
johnc@3466 | 186 | HeapRegion* to = _g1->heap_region_containing(obj); |
johnc@3466 | 187 | if (to != NULL && _from != to) { |
johnc@3466 | 188 | // The _record_refs_into_cset flag is true during the RSet |
johnc@3466 | 189 | // updating part of an evacuation pause. It is false at all |
johnc@3466 | 190 | // other times: |
johnc@3466 | 191 | // * rebuilding the rembered sets after a full GC |
johnc@3466 | 192 | // * during concurrent refinement. |
johnc@3466 | 193 | // * updating the remembered sets of regions in the collection |
johnc@3466 | 194 | // set in the event of an evacuation failure (when deferred |
johnc@3466 | 195 | // updates are enabled). |
johnc@3466 | 196 | |
johnc@3466 | 197 | if (_record_refs_into_cset && to->in_collection_set()) { |
johnc@3466 | 198 | // We are recording references that point into the collection |
johnc@3466 | 199 | // set and this particular reference does exactly that... |
johnc@3466 | 200 | // If the referenced object has already been forwarded |
johnc@3466 | 201 | // to itself, we are handling an evacuation failure and |
johnc@3466 | 202 | // we have already visited/tried to copy this object |
johnc@3466 | 203 | // there is no need to retry. |
johnc@3466 | 204 | if (!self_forwarded(obj)) { |
johnc@3466 | 205 | assert(_push_ref_cl != NULL, "should not be null"); |
johnc@3466 | 206 | // Push the reference in the refs queue of the G1ParScanThreadState |
johnc@3466 | 207 | // instance for this worker thread. |
johnc@3466 | 208 | _push_ref_cl->do_oop(p); |
johnc@3466 | 209 | } |
johnc@3466 | 210 | |
johnc@3466 | 211 | // Deferred updates to the CSet are either discarded (in the normal case), |
johnc@3466 | 212 | // or processed (if an evacuation failure occurs) at the end |
johnc@3466 | 213 | // of the collection. |
johnc@3466 | 214 | // See G1RemSet::cleanup_after_oops_into_collection_set_do(). |
johnc@3466 | 215 | } else { |
johnc@3466 | 216 | // We either don't care about pushing references that point into the |
johnc@3466 | 217 | // collection set (i.e. we're not during an evacuation pause) _or_ |
johnc@3466 | 218 | // the reference doesn't point into the collection set. Either way |
johnc@3466 | 219 | // we add the reference directly to the RSet of the region containing |
johnc@3466 | 220 | // the referenced object. |
johnc@3466 | 221 | _g1_rem_set->par_write_ref(_from, p, _worker_i); |
johnc@3466 | 222 | } |
johnc@3466 | 223 | } |
johnc@3466 | 224 | } |
johnc@3466 | 225 | |
stefank@2314 | 226 | #endif // SHARE_VM_GC_IMPLEMENTATION_G1_G1OOPCLOSURES_INLINE_HPP |